Re: [libvirt] [PATCH v2 17/23] conf: convert over to use GRegex for regular expressions

2019-10-10 Thread Daniel P . Berrangé
On Wed, Oct 09, 2019 at 10:08:32AM +0200, Bjoern Walk wrote: > Daniel P. Berrangé [2019-10-07, 06:14PM +0100]: > > @@ -2306,20 +2304,17 @@ > > virDomainQemuMonitorEventStateRegisterID(virConnectPtr conn, > > return -1; > > data->flags = flags; > > if (event && flags != -1) { >

Re: [libvirt] [PATCH v2 17/23] conf: convert over to use GRegex for regular expressions

2019-10-09 Thread Bjoern Walk
Daniel P. Berrangé [2019-10-07, 06:14PM +0100]: > @@ -2306,20 +2304,17 @@ > virDomainQemuMonitorEventStateRegisterID(virConnectPtr conn, > return -1; > data->flags = flags; > if (event && flags != -1) { > -int rflags = REG_NOSUB; > - > -if (flags &

Re: [libvirt] [PATCH v2 17/23] conf: convert over to use GRegex for regular expressions

2019-10-08 Thread Ján Tomko
On Mon, Oct 07, 2019 at 06:14:19PM +0100, Daniel P. Berrangé wrote: Reviewed-by: Pavel Hrdina Signed-off-by: Daniel P. Berrangé --- src/conf/domain_event.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc