Re: [libvirt] [PATCH v3 2/4] qemu: add dtb capability

2013-03-13 Thread Yin Olivia-R63875
v3 2/4] qemu: add dtb capability On 02/27/2013 09:56 AM, Eric Blake wrote: @@ -944,6 +945,8 @@ virQEMUCapsComputeCmdFlags(const char *help, } if (strstr(help, -uuid)) virQEMUCapsSet(qemuCaps, QEMU_CAPS_UUID); +if (strstr(help, -dtb)) +virQEMUCapsSet

Re: [libvirt] [PATCH v3 2/4] qemu: add dtb capability

2013-02-27 Thread Eric Blake
On 02/27/2013 01:28 AM, Olivia Yin wrote: Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/qemu/qemu_capabilities.c |3 +++ src/qemu/qemu_capabilities.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) [not a patch review, but a general comment] You did deep

Re: [libvirt] [PATCH v3 2/4] qemu: add dtb capability

2013-02-27 Thread Eric Blake
On 02/27/2013 09:56 AM, Eric Blake wrote: @@ -944,6 +945,8 @@ virQEMUCapsComputeCmdFlags(const char *help, } if (strstr(help, -uuid)) virQEMUCapsSet(qemuCaps, QEMU_CAPS_UUID); +if (strstr(help, -dtb)) +virQEMUCapsSet(qemuCaps, QEMU_CAPS_DTB); This won't

Re: [libvirt] [PATCH v3 2/4] qemu: add dtb capability

2013-02-27 Thread Yin Olivia-R63875
Hi Eric, Thanks for your comments. -Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Thursday, February 28, 2013 12:57 AM To: Yin Olivia-R63875 Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH v3 2/4] qemu: add dtb capability On 02/27/2013 01:28 AM