Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 11:12:18AM +0800, Osier Yang wrote: On 24/07/13 01:11, Paolo Bonzini wrote: Il 23/07/2013 18:47, John Ferlan ha scritto: On 07/23/2013 12:18 PM, Paolo Bonzini wrote: Il 23/07/2013 18:01, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 11:54, Daniel P. Berrange ha scritto: but anyway, we provide good enough documentations, so if one wants to use direct mode, he can still change the xml to use it, any big problems here? though defaulting to direct is more convenient for these users. Defaulting to direct is

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 12:25:17PM +0200, Paolo Bonzini wrote: Il 24/07/2013 11:54, Daniel P. Berrange ha scritto: but anyway, we provide good enough documentations, so if one wants to use direct mode, he can still change the xml to use it, any big problems here? though defaulting to direct

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 12:31, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:25:17PM +0200, Paolo Bonzini wrote: Il 24/07/2013 11:54, Daniel P. Berrange ha scritto: but anyway, we provide good enough documentations, so if one wants to use direct mode, he can still change the xml to use it,

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:31, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:25:17PM +0200, Paolo Bonzini wrote: Il 24/07/2013 11:54, Daniel P. Berrange ha scritto: but anyway, we provide good enough documentations, so if one

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 12:39, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:31, Daniel P. Berrange ha scritto: breaking the default config for QEMU's without iSCSI support. Understood, that's why I suggested not having a default config

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 12:41:49PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:39, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:31, Daniel P. Berrange ha scritto: breaking the default config for QEMU's without iSCSI support.

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 12:46, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:41:49PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:39, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:31, Daniel P. Berrange ha scritto: breaking

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 12:59:27PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:46, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:41:49PM +0200, Paolo Bonzini wrote: Il 24/07/2013 12:39, Daniel P. Berrange ha scritto: On Wed, Jul 24, 2013 at 12:37:10PM +0200, Paolo Bonzini

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 13:03, Daniel P. Berrange ha scritto: Can you make the pool active, but at the same time not expose it as devices on the host? LUNs can be discovered by talking directly to the target (similar to the iscsi-ls command included with libiscsi). I've never considered that

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Paolo Bonzini
Il 22/07/2013 12:30, Osier Yang ha scritto: +def-srcpool-pooltype = pooldef-type; +if (pooldef-type == VIR_STORAGE_POOL_ISCSI) { +/* Default to use the LUN's path on host */ +if (!def-srcpool-mode) +def-srcpool-mode =

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 03:22:54PM +0200, Paolo Bonzini wrote: Il 22/07/2013 12:30, Osier Yang ha scritto: +def-srcpool-pooltype = pooldef-type; +if (pooldef-type == VIR_STORAGE_POOL_ISCSI) { +/* Default to use the LUN's path on host */ +if

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 15:26, Daniel P. Berrange ha scritto: Ok, this answers my question. :) I think the default mode should be direct, because otherwise things such as persistent reservations do not work. No, the default has to be host mode, because that is the only mode that is guaranteed

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote: Il 23/07/2013 15:26, Daniel P. Berrange ha scritto: Ok, this answers my question. :) I think the default mode should be direct, because otherwise things such as persistent reservations do not work. No, the default

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 15:36, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote: Il 23/07/2013 15:26, Daniel P. Berrange ha scritto: Ok, this answers my question. :) I think the default mode should be direct, because otherwise things such as persistent

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 03:52:56PM +0200, Paolo Bonzini wrote: Il 23/07/2013 15:36, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote: Il 23/07/2013 15:26, Daniel P. Berrange ha scritto: Ok, this answers my question. :) I think the default

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 03:52:56PM +0200, Paolo Bonzini wrote: Il 23/07/2013 15:36, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 03:29:40PM +0200, Paolo Bonzini wrote: Il 23/07/2013 15:26, Daniel P. Berrange ha scritto: Ok, this

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 16:14, Daniel P. Berrange ha scritto: Perhaps the default could be specified in a configuration file (and the default should be the safe one). No, that is even worse because now the default is not predictable.. We simply default to host mode and if applications want to use

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Daniel P. Berrange
On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote: Il 23/07/2013 16:14, Daniel P. Berrange ha scritto: Perhaps the default could be specified in a configuration file (and the default should be the safe one). No, that is even worse because now the default is not predictable..

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 18:01, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote: Il 23/07/2013 16:14, Daniel P. Berrange ha scritto: Perhaps the default could be specified in a configuration file (and the default should be the safe one). No, that is even

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread John Ferlan
On 07/23/2013 12:18 PM, Paolo Bonzini wrote: Il 23/07/2013 18:01, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote: Il 23/07/2013 16:14, Daniel P. Berrange ha scritto: Perhaps the default could be specified in a configuration file (and the default

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Paolo Bonzini
Il 23/07/2013 18:47, John Ferlan ha scritto: On 07/23/2013 12:18 PM, Paolo Bonzini wrote: Il 23/07/2013 18:01, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote: Il 23/07/2013 16:14, Daniel P. Berrange ha scritto: Perhaps the default could be

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-23 Thread Osier Yang
On 24/07/13 01:11, Paolo Bonzini wrote: Il 23/07/2013 18:47, John Ferlan ha scritto: On 07/23/2013 12:18 PM, Paolo Bonzini wrote: Il 23/07/2013 18:01, Daniel P. Berrange ha scritto: On Tue, Jul 23, 2013 at 05:35:57PM +0200, Paolo Bonzini wrote: Il 23/07/2013 16:14, Daniel P. Berrange ha

Re: [libvirt] [PATCH v3 4/7] qemu: Translate the iscsi pool/volume disk source

2013-07-22 Thread Osier Yang
On 19/07/13 20:32, John Ferlan wrote: The difference with already supported pool types (dir, fs, block) is: there are two modes for iscsi pool (or network pools in future), one can specify it either to use the volume target path (the path showed up on host) with mode='host', or to use the remote