Re: [libvirt] [PATCH v9] bhyve: add a basic driver

2014-02-18 Thread Roman Bogorodskiy
Eric Blake wrote: I didn't see any edits to cfg.mk; not sure if you were trying 'make syntax-check' or if we may have some tweaks to clean up. Oh, and I guess you're still waiting on me to find time to tweak upstream gnulib to use $(SED) during syntax-check. Indeed, I'm waiting for gnulib

Re: [libvirt] [PATCH v9] bhyve: add a basic driver

2014-02-18 Thread Daniel P. Berrange
On Tue, Feb 18, 2014 at 02:23:31PM +0400, Roman Bogorodskiy wrote: Eric Blake wrote: I didn't see any edits to cfg.mk; not sure if you were trying 'make syntax-check' or if we may have some tweaks to clean up. Oh, and I guess you're still waiting on me to find time to tweak upstream

Re: [libvirt] [PATCH v9] bhyve: add a basic driver

2014-02-17 Thread Daniel P. Berrange
On Thu, Feb 13, 2014 at 02:14:32PM +0400, Roman Bogorodskiy wrote: +static int +bhyveBuildDiskArgStr(const virDomainDef *def, virCommandPtr cmd) +{ +virDomainDiskDefPtr disk; + +if (def-ndisks != 1) { +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, %s, +

Re: [libvirt] [PATCH v9] bhyve: add a basic driver

2014-02-17 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: +virCommandAddArg(cmd, -s); +virCommandAddArgFormat(cmd, 2:0,ahci-hd,%s, disk-src); What is the '2:0' bit here ? Is that disk controller/unit number ? Quoting the manpage [1]: pcislot[:function] The pcislot value is 0 to

Re: [libvirt] [PATCH v9] bhyve: add a basic driver

2014-02-17 Thread Eric Blake
On 02/13/2014 03:14 AM, Roman Bogorodskiy wrote: At this point it has a limited functionality and is highly experimental. Supported domain operations are: * define * start * destroy * dumpxml * dominfo * undefine It's only possible to have only one disk device and only one