Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-23 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-23 Thread Michael S. Tsirkin
On Tue, Sep 23, 2014 at 09:59:17AM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Alex Bligh
On 22 Sep 2014, at 12:36, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to disabled. Rename machine type pc-1.0 to

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 12:50:14PM +0100, Alex Bligh wrote: On 22 Sep 2014, at 12:36, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm,

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Alex Bligh
Sadly that is not true. For instance on Ubuntu Precise it's invoked as qemu-system-x86_64 by at least one management application known to me. Well change it to call qemu-kvm then :) Also what happens if you install qemu as well? Does it conflict? I'm not an Ubuntu maintainer but AFAIK

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to disabled. Rename machine type pc-1.0 to pc-1.0-qemu-git. Make pc-1.0

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 05:24:55PM +0200, Markus Armbruster wrote: Daniel P. Berrange berra...@redhat.com writes: On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 17:24, Markus Armbruster ha scritto: You're right. However, this particular horse left the barn a long time ago: the pc-* machine types differ in qemu-kvm and upstream QEMU. Sure, when qemu-kvm was merged back into QEMU, its machine type variants were dropped. But they live

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Andreas Färber
Am 22.09.2014 um 15:05 schrieb Alex Bligh: Sadly that is not true. For instance on Ubuntu Precise it's invoked as qemu-system-x86_64 by at least one management application known to me. Well change it to call qemu-kvm then :) Also what happens if you install qemu as well? Does it conflict?

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Serge Hallyn
Quoting Michael S. Tsirkin (m...@redhat.com): On Mon, Sep 22, 2014 at 05:24:55PM +0200, Markus Armbruster wrote: Daniel P. Berrange berra...@redhat.com writes: On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Alex Bligh
On 22 Sep 2014, at 16:45, Andreas Färber afaer...@suse.de wrote: What about adding a bool property qemu-kvm-compat to the MachineClass? Then a qemu-kvm shell script (like SUSE uses) can pass -global machine.qemu-kvm-compat=on whereas qemu-system-x86_64 would run in the default non-qemu-kvm

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote: Add a configure option --enable-pc-1-0-qemu-kvm and the corresponding --disable-pc-1-0-qemu-kvm, defaulting to

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Markus Armbruster
Alex Bligh a...@alex.org.uk writes: On 22 Sep 2014, at 16:45, Andreas Färber afaer...@suse.de wrote: What about adding a bool property qemu-kvm-compat to the MachineClass? Then a qemu-kvm shell script (like SUSE uses) can pass -global machine.qemu-kvm-compat=on whereas qemu-system-x86_64

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Alex Bligh
On 22 Sep 2014, at 16:44, Paolo Bonzini pbonz...@redhat.com wrote: time, RHEL7 did it. Ubuntu didn't, and probably neither did Debian. This patch singles out pc-1.0 just because it used to be the default in Ubuntu 12.04. So basically it's making upstream carry the burden of a decision of

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Alex Bligh
On 22 Sep 2014, at 20:10, Paolo Bonzini pbonz...@redhat.com wrote: I'm arguing against special-casing pc-1.0. Just apply the patch to Ubuntu downstream and call it a day. It's perfectly normal for machine types to be part of the downstream (not so secret) sauce. Well, I've just sent

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Serge Hallyn
Quoting Alex Bligh (a...@alex.org.uk): On 22 Sep 2014, at 20:10, Paolo Bonzini pbonz...@redhat.com wrote: I'm arguing against special-casing pc-1.0. Just apply the patch to Ubuntu downstream and call it a day. It's perfectly normal for machine types to be part of the downstream

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 05:45:28PM +0200, Andreas Färber wrote: Am 22.09.2014 um 15:05 schrieb Alex Bligh: Sadly that is not true. For instance on Ubuntu Precise it's invoked as qemu-system-x86_64 by at least one management application known to me. Well change it to call qemu-kvm then

Re: [libvirt] [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 05:54:02PM +0100, Alex Bligh wrote: However, that's not compatible with using PC_COMPAT as far as I know (unless there is some cunning way you can make a machine parameter change compat_props things). Of course not, PC_COMPAT is the reverse: have machine type influence