Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2019 at 04:22:49PM +0200, Andrea Bolognani wrote: > To me the Web-based workflow is inferior to the mail-based one, this > opinion being informed by using GitHub regularly for the past two > months or so. I'm willing to take hit if it can be proven that the > drawbacks are

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Andrea Bolognani
On Thu, 2019-10-17 at 09:48 +0100, Daniel P. Berrangé wrote: > On Thu, Oct 17, 2019 at 09:40:08AM +0200, Andrea Bolognani wrote: > > On Wed, 2019-10-16 at 17:03 +0100, Daniel P. Berrangé wrote: > The point of integrating with GitLab is to get the pre-merge > checking of patches, instead of

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Andrea Bolognani
On Thu, 2019-10-17 at 10:33 +0200, Martin Kletzander wrote: > Another thing we completely missed (which could also be more > effective) is to have a PR template [1] which would say "please open MRs on > gitlab instead (or "we don't do GitHub" for current state). Yup, that's definitely a good idea

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2019 at 08:55:35AM +0200, Pavel Hrdina wrote: > On Thu, Oct 17, 2019 at 07:57:46AM +0200, Peter Krempa wrote: > > On Wed, Oct 16, 2019 at 17:08:20 +0100, Daniel Berrange wrote: > > > On Wed, Oct 16, 2019 at 05:03:31PM +0200, Ján Tomko wrote: > > > > On Wed, Oct 16, 2019 at

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Roman Mohr
On Wed, Oct 16, 2019 at 6:42 PM Daniel Henrique Barboza < danielhb...@gmail.com> wrote: > > > On 10/16/19 9:22 AM, Andrea Bolognani wrote: > > As we look to make the libvirt project easier to contribute to, one > > fact that certainly comes to mind is that we only accept patches via > > the

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Daniel P . Berrangé
On Thu, Oct 17, 2019 at 09:40:08AM +0200, Andrea Bolognani wrote: > On Wed, 2019-10-16 at 17:03 +0100, Daniel P. Berrangé wrote: > > There's two tools being discussed here - both GitHub and GitLab. > > Splitting attention between email and a web based tool is bad, > > but splitting attention

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Martin Kletzander
On Thu, Oct 17, 2019 at 09:40:08AM +0200, Andrea Bolognani wrote: On Wed, 2019-10-16 at 17:03 +0100, Daniel P. Berrangé wrote: There's two tools being discussed here - both GitHub and GitLab. Splitting attention between email and a web based tool is bad, but splitting attention between email

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Andrea Bolognani
On Wed, 2019-10-16 at 17:03 +0100, Daniel P. Berrangé wrote: > There's two tools being discussed here - both GitHub and GitLab. > Splitting attention between email and a web based tool is bad, > but splitting attention between email and two web based tools > is even worse. > > Finally I have

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-17 Thread Pavel Hrdina
On Thu, Oct 17, 2019 at 07:57:46AM +0200, Peter Krempa wrote: > On Wed, Oct 16, 2019 at 17:08:20 +0100, Daniel Berrange wrote: > > On Wed, Oct 16, 2019 at 05:03:31PM +0200, Ján Tomko wrote: > > > On Wed, Oct 16, 2019 at 02:22:56PM +0200, Andrea Bolognani wrote: > > [...] > > > > Here it deviates

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-16 Thread Peter Krempa
On Wed, Oct 16, 2019 at 17:08:20 +0100, Daniel Berrange wrote: > On Wed, Oct 16, 2019 at 05:03:31PM +0200, Ján Tomko wrote: > > On Wed, Oct 16, 2019 at 02:22:56PM +0200, Andrea Bolognani wrote: [...] > > Here it deviates from the usual mailing list workflow where the patch > > has (in theory) a

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-16 Thread Daniel Henrique Barboza
On 10/16/19 9:22 AM, Andrea Bolognani wrote: As we look to make the libvirt project easier to contribute to, one fact that certainly comes to mind is that we only accept patches via the mailing list. While the core developers are comfortable with the email-based workflow and swear by it, many

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-16 Thread Daniel P . Berrangé
On Wed, Oct 16, 2019 at 05:03:31PM +0200, Ján Tomko wrote: > On Wed, Oct 16, 2019 at 02:22:56PM +0200, Andrea Bolognani wrote: > > First of all, we'd remove the ominous message from GitHub mirror > > repositories (interestingly, the same is not present on GitLab). > > > > Well if you're using

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-16 Thread Daniel P . Berrangé
On Wed, Oct 16, 2019 at 02:22:56PM +0200, Andrea Bolognani wrote: > As we look to make the libvirt project easier to contribute to, one > fact that certainly comes to mind is that we only accept patches via > the mailing list. While the core developers are comfortable with the > email-based

Re: [libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

2019-10-16 Thread Ján Tomko
On Wed, Oct 16, 2019 at 02:22:56PM +0200, Andrea Bolognani wrote: First of all, we'd remove the ominous message from GitHub mirror repositories (interestingly, the same is not present on GitLab). Well if you're using GitLab then you're already aware of the fact that not everything is hosted