Re: [libvirt] [RFC 0/2] Fix detection of slow guest shutdown

2018-08-06 Thread Christian Ehrhardt
On Mon, Aug 6, 2018 at 10:47 AM Daniel P. Berrangé wrote: > On Mon, Aug 06, 2018 at 07:20:10AM +0200, Christian Ehrhardt wrote: > > In that case I wonder what the libvirt community thinks of the proposed > > general "Pid is gone means we can assume it is dead" approach? > > The key thing with

Re: [libvirt] [RFC 0/2] Fix detection of slow guest shutdown

2018-08-06 Thread Daniel P . Berrangé
On Mon, Aug 06, 2018 at 07:20:10AM +0200, Christian Ehrhardt wrote: > In that case I wonder what the libvirt community thinks of the proposed > general "Pid is gone means we can assume it is dead" approach? The key thing with the shutdown process is that we use the dissapperance of the PID as the

Re: [libvirt] [RFC 0/2] Fix detection of slow guest shutdown

2018-08-05 Thread Christian Ehrhardt
On Fri, Aug 3, 2018 at 6:39 PM Alex Williamson wrote: > On Fri, 3 Aug 2018 08:29:39 +0200 > Christian Ehrhardt wrote: > > > Hi, > > I was recently looking into a case which essentially looked like this: > > 1. virsh shutdown guest > > 2. after <1 second the qemu process was gone from

Re: [libvirt] [RFC 0/2] Fix detection of slow guest shutdown

2018-08-05 Thread no-reply
Hi, This series was run against 'syntax-check' test by patchew.org, which failed, please find the details below: Type: series Message-id: 20180803062941.31641-1-christian.ehrha...@canonical.com Subject: [libvirt] [RFC 0/2] Fix detection of slow guest shutdown === TEST SCRIPT BEGIN ===

Re: [libvirt] [RFC 0/2] Fix detection of slow guest shutdown

2018-08-05 Thread Alex Williamson
On Fri, 3 Aug 2018 08:29:39 +0200 Christian Ehrhardt wrote: > Hi, > I was recently looking into a case which essentially looked like this: > 1. virsh shutdown guest > 2. after <1 second the qemu process was gone from /proc/ > 3. but libvirt spun in virProcessKillPainfully because the