Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Andrea Bolognani
On Wed, 2019-09-18 at 17:46 +0100, Daniel P. Berrangé wrote: > On Wed, Sep 18, 2019 at 02:55:53PM +0200, Andrea Bolognani wrote: > > So, to be clear, you're advocating for keeping our list of target > > platforms unchanged and exempt Meson specifically from the implicit > > requirement we've had

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Andrea Bolognani
On Thu, 2019-09-19 at 14:21 +0100, Daniel P. Berrangé wrote: > On Thu, Sep 19, 2019 at 02:45:53PM +0200, Andrea Bolognani wrote: > > On Thu, 2019-09-19 at 09:36 +0100, Daniel P. Berrangé wrote: > > Jumping in a bit late, but why do we care about this distinction in > > CI at all? In our existing

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 02:45:53PM +0200, Andrea Bolognani wrote: > On Thu, 2019-09-19 at 09:36 +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 19, 2019 at 10:20:04AM +0200, Pavel Hrdina wrote: > > > Another argument from my side was that we require syntax-check and check > > > to be executed

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Andrea Bolognani
On Thu, 2019-09-19 at 09:36 +0100, Daniel P. Berrangé wrote: > On Thu, Sep 19, 2019 at 10:20:04AM +0200, Pavel Hrdina wrote: > > Another argument from my side was that we require syntax-check and check > > to be executed before posting patches to mailing list, having it under > > single target

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 12:09:23PM +0200, Ján Tomko wrote: > On Thu, Sep 19, 2019 at 09:36:35AM +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 19, 2019 at 10:20:04AM +0200, Pavel Hrdina wrote: > > > On Thu, Sep 19, 2019 at 12:05:23AM +0200, Fabiano Fidêncio wrote: > > > > On Wed, Sep 18, 2019 at

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Ján Tomko
On Thu, Sep 19, 2019 at 09:36:35AM +0100, Daniel P. Berrangé wrote: On Thu, Sep 19, 2019 at 10:20:04AM +0200, Pavel Hrdina wrote: On Thu, Sep 19, 2019 at 12:05:23AM +0200, Fabiano Fidêncio wrote: > On Wed, Sep 18, 2019 at 9:57 PM Ján Tomko wrote: > > > > On Wed, Sep 18, 2019 at 05:40:06PM

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Daniel P . Berrangé
On Thu, Sep 19, 2019 at 10:20:04AM +0200, Pavel Hrdina wrote: > On Thu, Sep 19, 2019 at 12:05:23AM +0200, Fabiano Fidêncio wrote: > > On Wed, Sep 18, 2019 at 9:57 PM Ján Tomko wrote: > > > > > > On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote: > > > >On Wed, Sep 18, 2019 at 1:22

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-19 Thread Pavel Hrdina
On Thu, Sep 19, 2019 at 12:05:23AM +0200, Fabiano Fidêncio wrote: > On Wed, Sep 18, 2019 at 9:57 PM Ján Tomko wrote: > > > > On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote: > > >On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio > > >wrote: > > >> > > >> On Tue, Sep 17, 2019 at

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-18 Thread Fabiano Fidêncio
On Wed, Sep 18, 2019 at 9:57 PM Ján Tomko wrote: > > On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote: > >On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio wrote: > >> > >> On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote: > >> > > >> > On Tue, Sep 17, 2019 at 06:53:30PM +0200,

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-18 Thread Ján Tomko
On Wed, Sep 18, 2019 at 05:40:06PM +0200, Fabiano Fidêncio wrote: On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio wrote: On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote: > > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote: > > On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-18 Thread Daniel P . Berrangé
On Wed, Sep 18, 2019 at 02:55:53PM +0200, Andrea Bolognani wrote: > On Wed, 2019-09-18 at 10:39 +0100, Daniel P. Berrangé wrote: > > We certainly could bundle meson with them, but given that in very > > short time we're going to have libvirt, libvirt-dbus, osinfo-db-tools, > > libosinfo, gtk-vnc,

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-18 Thread Fabiano Fidêncio
On Wed, Sep 18, 2019 at 1:22 AM Fabiano Fidêncio wrote: > > On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote: > > > > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote: > > > On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina wrote: > > > > > > > > Meson build system is simple and

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-18 Thread Andrea Bolognani
On Wed, 2019-09-18 at 10:39 +0100, Daniel P. Berrangé wrote: > We certainly could bundle meson with them, but given that in very > short time we're going to have libvirt, libvirt-dbus, osinfo-db-tools, > libosinfo, gtk-vnc, spice-gtk all using meson, bundling meson in the > individual tarballs

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-18 Thread Daniel P . Berrangé
On Wed, Sep 18, 2019 at 11:30:14AM +0200, Andrea Bolognani wrote: > On Tue, 2019-09-17 at 20:17 +0200, Pavel Hrdina wrote: > > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote: > > > I didn't go through the patch, will do that in the next days ... but a > > > few things should be

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-18 Thread Andrea Bolognani
On Tue, 2019-09-17 at 20:17 +0200, Pavel Hrdina wrote: > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote: > > I didn't go through the patch, will do that in the next days ... but a > > few things should be considered here: > > - meson >= 0.49.0 basically means the project won't be

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-17 Thread Fabiano Fidêncio
On Tue, Sep 17, 2019 at 8:17 PM Pavel Hrdina wrote: > > On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote: > > On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina wrote: > > > > > > Meson build system is simple and quick compared to Autotools and it's > > > able to fully replace our

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-17 Thread Pavel Hrdina
On Tue, Sep 17, 2019 at 06:53:30PM +0200, Fabiano Fidêncio wrote: > On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina wrote: > > > > Meson build system is simple and quick compared to Autotools and it's > > able to fully replace our Autotools usage. There are few drawbacks as > > it's a fairly new

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-17 Thread Pavel Hrdina
On Tue, Sep 17, 2019 at 06:39:17PM +0200, Ján Tomko wrote: > On Tue, Sep 17, 2019 at 05:20:43PM +0200, Pavel Hrdina wrote: > > Meson build system is simple and quick compared to Autotools and it's > > able to fully replace our Autotools usage. There are few drawbacks as > > it's a fairly new

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-17 Thread Fabiano Fidêncio
On Tue, Sep 17, 2019 at 5:22 PM Pavel Hrdina wrote: > > Meson build system is simple and quick compared to Autotools and it's > able to fully replace our Autotools usage. There are few drawbacks as > it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, > it's still evolving

Re: [libvirt] [dbus PATCH] build: convert to Meson/Ninja build system

2019-09-17 Thread Ján Tomko
On Tue, Sep 17, 2019 at 05:20:43PM +0200, Pavel Hrdina wrote: Meson build system is simple and quick compared to Autotools and it's able to fully replace our Autotools usage. There are few drawbacks as it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, it's still evolving