Re: [libvirt] [libvirt-glib/libvirt-gconfig 06/17] gconfig: Implement gvir_config_domain_graphics_spice_get_tls_port()

2016-09-05 Thread Christophe Fergeau
On Thu, Apr 21, 2016 at 12:12:19PM +0200, Christophe Fergeau wrote: > For patches up to this one: > > Acked-by: Christophe Fergeau On second thought, the API added by the patches before this one becomes redundant and deprecated once the Remote/Local classes are introduced,

Re: [libvirt] [libvirt-glib/libvirt-gconfig 06/17] gconfig: Implement gvir_config_domain_graphics_spice_get_tls_port()

2016-04-21 Thread Christophe Fergeau
For patches up to this one: Acked-by: Christophe Fergeau You could have added a few more tests like this: diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index be55ef9..d78292c 100644 --- a/tests/test-gconfig.c +++ b/tests/test-gconfig.c @@ -466,6 +466,10 @@