Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

2021-04-19 Thread Pavel Hrdina
On Mon, Apr 19, 2021 at 05:26:55PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 06:22:18PM +0200, Pavel Hrdina wrote: > > On Mon, Apr 19, 2021 at 05:05:56PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > > > > On Mon,

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

2021-04-19 Thread Daniel P . Berrangé
On Mon, Apr 19, 2021 at 06:22:18PM +0200, Pavel Hrdina wrote: > On Mon, Apr 19, 2021 at 05:05:56PM +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > > > On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > > > > On Fri, Apr 16, 2021

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

2021-04-19 Thread Pavel Hrdina
On Mon, Apr 19, 2021 at 05:05:56PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > > On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > > > On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > > > > - if not

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

2021-04-19 Thread Daniel P . Berrangé
On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > > > - if not get_option('storage_iscsi').disabled() and iscsiadm_prog.found() > > > + if not

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

2021-04-19 Thread Andrea Bolognani
On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > > - if not get_option('storage_iscsi').disabled() and iscsiadm_prog.found() > > + if not get_option('storage_iscsi').disabled() > > use_storage = true > >

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

2021-04-19 Thread Daniel P . Berrangé
On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > These binaries are used only during runtime so technically there is no > need to check for them while compiling libvirt. > > Usually the location is the same while compiling and running but it may > not be true. In addition they are