On Fri, Oct 1, 2021 at 8:28 PM Daniel P. Berrangé wrote:
>
> On Fri, Oct 01, 2021 at 01:13:00PM -0400, Laine Stump wrote:
> > On 10/1/21 5:57 AM, Daniel P. Berrangé wrote:
> > > On Mon, Sep 27, 2021 at 10:30:47PM +0300, Dmitrii Shcherbakov wrote:
> >
> > [...]
> >
> > > +GType
> > > >
On Fri, Oct 1, 2021 at 7:49 PM Daniel P. Berrangé wrote:
> > A GTree is used as a data structure in order to maintain key ordering
> > which will be important in XML to XML tests later.
>
> Now, I've learnt a bit more about VPD and considering my comments on
> the XML format in the last patch, I
> > +if (VIR_CLOSE(vpdFileFd) < 0) {
> > +virReportSystemError(errno, _("Unable to close the VPD file, fd:
> > %d"), vpdFileFd);
> > +return NULL;
> > +}
>
> This is closing an FD that is owned & passed in by the caller. I'd
> consider that an undesirable pattern. Whomever
On Fri, Oct 01, 2021 at 01:13:00PM -0400, Laine Stump wrote:
> On 10/1/21 5:57 AM, Daniel P. Berrangé wrote:
> > On Mon, Sep 27, 2021 at 10:30:47PM +0300, Dmitrii Shcherbakov wrote:
>
> [...]
>
> > +GType
> > > +vir_pci_vpd_resource_type_get_type(void)
>
> I know you had asked about using
Thanks a lot for the review!
Responses inline - ACKs to address in v6.
On Fri, Oct 1, 2021 at 12:58 PM Daniel P. Berrangé wrote:
> I don't know what the thread concurrency rules are of the callers of
> this code, but regardless we generally aim to make any one-time
> initializers thread safe
On 10/1/21 5:57 AM, Daniel P. Berrangé wrote:
On Mon, Sep 27, 2021 at 10:30:47PM +0300, Dmitrii Shcherbakov wrote:
[...]
+GType
+vir_pci_vpd_resource_type_get_type(void)
I know you had asked about using under_scored_naming in a reply to Peter
pointing out "non-standard" names in V3 of
On Mon, Sep 27, 2021 at 10:30:47PM +0300, Dmitrii Shcherbakov wrote:
> Add support for deserializing the binary PCI/PCIe VPD format and storing
> results in memory.
>
> The VPD format is specified in "I.3. VPD Definitions" in PCI specs
> (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in
On Mon, Sep 27, 2021 at 10:30:47PM +0300, Dmitrii Shcherbakov wrote:
> Add support for deserializing the binary PCI/PCIe VPD format and storing
> results in memory.
>
> The VPD format is specified in "I.3. VPD Definitions" in PCI specs
> (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in
On Mon, Sep 27, 2021 at 10:30:47PM +0300, Dmitrii Shcherbakov wrote:
> Add support for deserializing the binary PCI/PCIe VPD format and storing
> results in memory.
>
> The VPD format is specified in "I.3. VPD Definitions" in PCI specs
> (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in
