Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread beth kon
Richard W.M. Jones wrote: beth kon wrote: Patch for accessing available memory. --- libvirt.danielpatch/src/driver.h2007-09-11 15:29:43.0 -0400 +++ libvirt.cellsMemory/src/driver.h2007-09-27 18:39:52.0 -0400 @@ -258,8 +258,9 @@ typedef virDriver *virDriverPtr;

Re: [Libvir] [PATCH] Enhanced stats for fullvirt domains

2007-09-28 Thread Daniel Veillard
On Fri, Sep 28, 2007 at 10:26:05AM +0100, Richard W.M. Jones wrote: Thanks Jim. Here is an updated patch which fixes this issue, and is tested against Xen 3.1. The principle of the patch sounds good to me, I didn't spot anything obvious, but I didn't try to test it. +1 Once it's in CVS

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Richard W.M. Jones
beth kon wrote: Patch for accessing available memory. --- libvirt.danielpatch/src/driver.h2007-09-11 15:29:43.0 -0400 +++ libvirt.cellsMemory/src/driver.h2007-09-27 18:39:52.0 -0400 @@ -258,8 +258,9 @@ typedef virDriver *virDriverPtr; typedef int

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread beth kon
Daniel P. Berrange wrote: On Fri, Sep 28, 2007 at 02:52:51PM +0100, Richard W.M. Jones wrote: # src/virsh capabilities [...] topology cells num='1' cell id='0' cpus num='4' cpu id='0'/ cpu id='1'/ cpu id='2'/ cpu id='3'/ /cpus

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Richard W.M. Jones
My results are a bit inconclusive. I have a machine here which supposedly supports NUMA (2 socket, 2 core AMD with hypertransport and two separate banks of RAM). BIOS is _not_ configured to interleave memory. Other BIOS settings lead me to suppose that NUMA is enabled (or at least not

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread beth kon
Richard W.M. Jones wrote: beth kon wrote: Patch for accessing available memory. --- libvirt.danielpatch/src/driver.h2007-09-11 15:29:43.0 -0400 +++ libvirt.cellsMemory/src/driver.h2007-09-27 18:39:52.0 -0400 @@ -258,8 +258,9 @@ typedef virDriver *virDriverPtr;

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Ryan Harper
* Richard W.M. Jones [EMAIL PROTECTED] [2007-09-28 11:20]: beth kon wrote: Richard W.M. Jones wrote: My results are a bit inconclusive. I have a machine here which supposedly supports NUMA (2 socket, 2 core AMD with hypertransport and two separate banks of RAM). BIOS is _not_

Re: [Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread beth kon
Ryan Harper wrote: * Elizabeth Kon [EMAIL PROTECTED] [2007-09-28 11:27]: Daniel Veillard wrote: - isolate as a separate call what is the total sum of free memory available on the Node There is currently no way to get that information from Xen. no, we can always get

Re: [Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Ryan Harper
* Elizabeth Kon [EMAIL PROTECTED] [2007-09-28 12:32]: Ryan Harper wrote: * Elizabeth Kon [EMAIL PROTECTED] [2007-09-28 11:27]: Daniel Veillard wrote: - isolate as a separate call what is the total sum of free memory available on the Node There is currently no

Re: [Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread beth kon
Daniel Veillard wrote: - isolate as a separate call what is the total sum of free memory available on the Node There is currently no way to get that information from Xen. - on NUMA boxes in the capability dump I would like to see the amount of memory available on the cell see

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Richard W.M. Jones
beth kon wrote: Richard W.M. Jones wrote: My results are a bit inconclusive. I have a machine here which supposedly supports NUMA (2 socket, 2 core AMD with hypertransport and two separate banks of RAM). BIOS is _not_ configured to interleave memory. Other BIOS settings lead me to

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread beth kon
Richard W.M. Jones wrote: My results are a bit inconclusive. I have a machine here which supposedly supports NUMA (2 socket, 2 core AMD with hypertransport and two separate banks of RAM). BIOS is _not_ configured to interleave memory. Other BIOS settings lead me to suppose that NUMA is

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Daniel P. Berrange
On Fri, Sep 28, 2007 at 02:52:51PM +0100, Richard W.M. Jones wrote: # src/virsh capabilities [...] topology cells num='1' cell id='0' cpus num='4' cpu id='0'/ cpu id='1'/ cpu id='2'/ cpu id='3'/ /cpus /cell

Re: [Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Daniel Veillard
On Fri, Sep 28, 2007 at 12:06:24AM -0400, beth kon wrote: I have tested the patches on a NUMA and a non-NUMA configuration, and they fundamentally appear to work. The first patch is for accessing available memory on a per-node basis. The second patch is for accessing NUMA node topology.

Re: [Libvir] updated: Support Sun's Compiler

2007-09-28 Thread Daniel P. Berrange
On Fri, Sep 28, 2007 at 11:26:06AM -0400, Mark Johnson wrote: I've cleaned up the patch from the previous comments... Sorry I'm off the original thread, switched over to mutt and am waiting for fetchmail to catch up with gmail.. ACK, this version addresses all the comments I had with the

Re: [Libvir] PATCH: Fix crash parsing input devices for QEMU

2007-09-28 Thread Richard W.M. Jones
Daniel P. Berrange wrote: There is an edge case in parsing of input devices where if you have a PS2 mouse defined, before a USB tablet, it could generate a null pointer deference thus crash. Normally you'd only have one pointer defined, but one might add a USB tablet for getting a improved

Re: [Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Daniel Veillard
On Fri, Sep 28, 2007 at 12:41:21PM -0500, Ryan Harper wrote: * Elizabeth Kon [EMAIL PROTECTED] [2007-09-28 12:32]: no, we can always get a total of _free_ memory, we just don't have a call for _total_ ram (ie, free and non-free) -- only what's in the heap (free mem). I asked DV

Re: [Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Daniel Veillard
On Fri, Sep 28, 2007 at 06:42:10AM -0400, beth kon wrote: Richard W.M. Jones wrote: beth kon wrote: Patch for accessing available memory. --- libvirt.danielpatch/src/driver.h2007-09-11 15:29:43.0 -0400 +++ libvirt.cellsMemory/src/driver.h2007-09-27 18:39:52.0

Re: [Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology

2007-09-28 Thread Daniel P. Berrange
On Fri, Sep 28, 2007 at 01:08:08PM -0500, Ryan Harper wrote: * Daniel Veillard [EMAIL PROTECTED] [2007-09-28 12:59]: On Fri, Sep 28, 2007 at 12:41:21PM -0500, Ryan Harper wrote: * Elizabeth Kon [EMAIL PROTECTED] [2007-09-28 12:32]: no, we can always get a total of _free_ memory, we just

[Libvir] Updated Solaris dom0 patch (part 1)

2007-09-28 Thread Mark Johnson
I've broken this patch up into a few pieces to make it more reviewable and tried to address the comments from the previous patch (Jun 15th'ish if your looking). Here is first part... tested on today's CVS bits on a FC7 dom0 (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) One note, it looks

Re: [Libvir] Updated Solaris dom0 patch (part 1)

2007-09-28 Thread Daniel P. Berrange
On Fri, Sep 28, 2007 at 03:03:15PM -0400, Mark Johnson wrote: I've broken this patch up into a few pieces to make it more reviewable and tried to address the comments from the previous patch (Jun 15th'ish if your looking). Here is first part... tested on today's CVS bits on a FC7 dom0

[Libvir] PATCH: vncpasswd

2007-09-28 Thread Mark Johnson
This adds support for handling vncpasswd.. MRJ vncpasswd support diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -1657,11 +1657,14 @@ xend_parse_sexp_desc(virConnectPtr conn, } else if (tmp !strcmp(tmp, vnc)) {

Re: [Libvir] PATCH: vncpasswd

2007-09-28 Thread Daniel P. Berrange
On Fri, Sep 28, 2007 at 04:14:35PM -0400, Mark Johnson wrote: This adds support for handling vncpasswd.. The reason I left this out is that XML ends up in log files, which then end up in bug reports, which then end up indexed by Google ! Also the XML dump is oneof the data items available to

[Libvir] PATCH: Allow emptry bootloader

2007-09-28 Thread Daniel P. Berrange
Latest XenD allows for default bootloader to be used if one is not defined for a paravirt OS. libvirt doesn't currently cope with this (see Solaris thread), since it requires either a bootloader or kernel to always be present. The attached patch allows for an emptry bootloader element to indicate