On Mon, Oct 10, 2011 at 03:35:42PM -0600, Eric Blake wrote:
To date, disk snapshots worked by accident, as they were always
using hmp fallback due to a typo in commit e702b5b not picking up
on the (intentional) difference in command names between the two
monitor protocols.
*
Hello List,
I was wondering if there are any targets that are just for the documentation
to build and install. I am curious about separating the documentation from
the software from a building and installation point-of-view, and offering
this in the port for FreeBSD. So a user that gives a
On Mon, Oct 10, 2011 at 11:54:16AM +0200, Michal Privoznik wrote:
This patch creates basic dissector for Libvirt RPC. The protocol
description can be found here:
http://libvirt.org/internals/rpc.html
Currently, only packet head dissecting is written. To fully dissect
packet payloads a
BZ# https://bugzilla.redhat.com/show_bug.cgi?id=736214
The problem is caused by the original info of domain's PCI dev is
maintained by qemu_driver-activePciHostdevs list, (E.g. dev-reprobe,
which stands for whether need to reprobe driver for the dev when do
reattachment). The fields (dev-reprobe,
On Mon, Oct 10, 2011 at 01:49:40PM -0600, Eric Blake wrote:
On 10/10/2011 01:29 PM, berra...@redhat.com wrote:
Overall status: failed
Start date: Mon Oct 10 2011
Start time: 19:05:02 UTC / 15:05:02 EDT
Build counter: 1318273502
Build timestamp: 1318273502
URL:
On Mon, Oct 10, 2011 at 04:15:47PM -0600, Eric Blake wrote:
On 10/10/2011 03:46 PM, Guido Günther wrote:
Hi,
having JUnit like XML allows for easy integration into CI tools like
Jenkins. Attach patch adds this using TAP::Formatter::JUnit.
Does this look reasonable?
Do we need to modify a
On Mon, Oct 10, 2011 at 11:19:09PM -0700, Jason Helfman wrote:
Hello List,
I was wondering if there are any targets that are just for the documentation
to build and install. I am curious about separating the documentation from
the software from a building and installation point-of-view, and
于 2011-10-1 5:08, Eric Blake 写道:
On 09/28/2011 10:48 PM, Wayne Xia wrote:
Hi, I want to build rpm for latest libvit version on Redhat6, but when
I type:
./autogen.sh --system
make rpm -j4
error happens:
sitemap.html.tmp index.html.tmp archdomain.html.tmp downloads.html.tmp
auth.html.tmp
At 10/11/2011 04:07 PM, Wayne Xia Write:
于 2011-10-1 5:08, Eric Blake 写道:
On 09/28/2011 10:48 PM, Wayne Xia wrote:
Hi, I want to build rpm for latest libvit version on Redhat6, but when
I type:
./autogen.sh --system
make rpm -j4
error happens:
sitemap.html.tmp index.html.tmp
On Mon, Oct 10, 2011 at 06:45:17PM +0100, Daniel P. Berrange wrote:
Can you tell me what GIT commitref this series is based on ?
I tried to git am the series over current head, but it didn't
pan out.
The tree can be found at
https://gitorious.org/~teuf/libvirt/teuf-libvirt-glib/commits/gconfig
On 2011?10?10? 23:54, shao...@linux.vnet.ibm.com wrote:
From: Shaohe Fengshao...@linux.vnet.ibm.com
Basically, this feature can go along with qemu monitor passthrough.
That way, if we use new commands in the monitor that generate new events, we
want
some way to receive those new events too.
2011/10/10 Eric Blake ebl...@redhat.com:
On 10/10/2011 11:30 AM, Udayan Bapat wrote:
Hi
I am new to open source development and had a question about libvirt/KVM
support in the linux kernel. In general since many people are contributing
to the library, are there any 'standardized regressions
On Mon, Oct 10, 2011 at 05:16:32PM +0530, Harsh Bora wrote:
On 10/10/2011 03:47 PM, Daniel P. Berrange wrote:
We can use an enum for this too. eg
VIR_ENUM_DECL(qemuFSDriverName);
VIR_ENUM_IMPL(qemuFSDriverName, VIR_DOMAIN_FS_DRIVER_TYPE_LAST,
local, handle);
On Mon, Oct 10, 2011 at 05:18:53PM +0530, Harsh Prateek Bora wrote:
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 492a41d..3937393 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1025,6 +1025,15 @@
/choice
From: Daniel P. Berrange berra...@redhat.com
Very occassionally the sequence of events from poll would result
in getting a HANGUP on its own, instead of a HANGUP+READABLE
at the same time. In the former case we would send back an error
event to the client, but never send the empty packet to
From: Daniel P. Berrange berra...@redhat.com
If we are comparing storage pools we must skip comparing with
ourself, so that re-defining an existing pool works
* conf/storage_conf.c: Skip self when comparing
---
src/conf/storage_conf.c |4
1 files changed, 4 insertions(+), 0
On 11.10.2011 09:26, Daniel P. Berrange wrote:
On Mon, Oct 10, 2011 at 11:54:16AM +0200, Michal Privoznik wrote:
This patch creates basic dissector for Libvirt RPC. The protocol
description can be found here:
http://libvirt.org/internals/rpc.html
Currently, only packet head dissecting is
On Mon, Sep 19, 2011 at 09:13:42PM -0700, Sage Weil wrote:
Implement a generic helper to escape a given set of characters with a
leading '\'. Generalizes virBufferEscapeSexpr().
Signed-off-by: Sage Weil s...@newdream.net
---
src/libvirt_private.syms |1 +
src/util/buf.c |
Overall status: failed
Start date: Tue Oct 11 2011
Start time: 11:05:02 UTC / 07:05:02 EDT
Build counter: 1318331102
Build timestamp: 1318331102
URL: http://builder.virt-tools.org/index.html
Module: libvirt
Status: failed
URL: http://builder.virt-tools.org/module-libvirt.html
--
libvir-list
This is a regression introduced by new RPC codes, previously
we advertise the service via ssh even if the daemon doesn't
listen on TLS port (TCP is not choosed). Now the service is
only advertised when it listens on TLS or TCP port. This breaks
upper layer apps which intends to discover the
On Tue, Oct 11, 2011 at 07:11:46AM -0400, berra...@redhat.com wrote:
Overall status: failed
Start date: Tue Oct 11 2011
Start time: 11:05:02 UTC / 07:05:02 EDT
Build counter: 1318331102
Build timestamp: 1318331102
URL: http://builder.virt-tools.org/index.html
Module: libvirt
Status:
On Tue, Oct 11, 2011 at 07:46:49PM +0800, Osier Yang wrote:
This is a regression introduced by new RPC codes, previously
we advertise the service via ssh even if the daemon doesn't
listen on TLS port (TCP is not choosed). Now the service is
only advertised when it listens on TLS or TCP port.
VirtFS allows the user to choose between path/handle based fs driver.
As of now, libvirt hardcode to use path based driver only. This patch provides
a solution to allow user to choose between path/handle based fs driver.
Sample:
filesystem type='mount'
driver type='handle'/
On Tue, Oct 11, 2011 at 05:00:40PM +0530, Harsh Prateek Bora wrote:
VirtFS allows the user to choose between path/handle based fs driver.
As of now, libvirt hardcode to use path based driver only. This patch provides
a solution to allow user to choose between path/handle based fs driver.
On Thu, Oct 06, 2011 at 01:43:09PM +0200, Marc-André Lureau wrote:
Instead of the message:
GLib-CRITICAL **: g_hash_table_get_values: assertion `hash_table !=
NULL' failed
gvir_storage_pool_get_volumes uses the same construct, can you fix it as
well? ACK with that additional change.
On Fri, Oct 07, 2011 at 02:59:28PM +0300, Zeeshan Ali (Khattak) wrote:
On Fri, Oct 7, 2011 at 12:40 PM, Christophe Fergeau cferg...@redhat.com
wrote:
* I don't know how to handle XMLs where the same node appears multiple
times (eg name). If it's the latest name that wins, what do we do
This is a regression introduced by new RPC codes, previously
we advertise the service via ssh even if the daemon doesn't
listen on TLS port (TCP is not choosed). Now the service is
only advertised when it listens on TLS or TCP port. This breaks
upper layer apps which intends to discover the
This patch extends qemudDomainCoreDump so it supports new VIR_DUMP_RESET
flag. If this flag is set, domain is reset on successful dump. However,
this is needed to be done after we start CPUs.
---
src/qemu/qemu_driver.c | 20 +++-
1 files changed, 15 insertions(+), 5 deletions(-)
On Tue, Oct 11, 2011 at 08:41:09AM +0100, Daniel P. Berrange wrote:
On Mon, Oct 10, 2011 at 04:15:47PM -0600, Eric Blake wrote:
On 10/10/2011 03:46 PM, Guido Günther wrote:
Hi,
having JUnit like XML allows for easy integration into CI tools like
Jenkins. Attach patch adds this using
Hi,
I got a bit confused how snapshotting/reverting is supposed to work now
so I added some tests. O.k. to apply?
This requires Sys::Virt 0.9.5.
Cheers,
-- Guido
---
Build.PL |2 +-
perl-Sys-Virt-TCK.spec.PL |2 +-
scripts/domain/400-snapshots.t | 127
On Mon, Oct 10, 2011 at 11:54:08PM +0800, shao...@linux.vnet.ibm.com wrote:
From: Shaohe Feng shao...@linux.vnet.ibm.com
Basically, this feature can go along with qemu monitor passthrough.
That way, if we use new commands in the monitor that generate new events, we
want
some way to
On Tue, Oct 11, 2011 at 03:44:32PM +0200, Guido Günther wrote:
On Tue, Oct 11, 2011 at 08:41:09AM +0100, Daniel P. Berrange wrote:
On Mon, Oct 10, 2011 at 04:15:47PM -0600, Eric Blake wrote:
On 10/10/2011 03:46 PM, Guido Günther wrote:
Hi,
having JUnit like XML allows for easy
On Tue, Oct 11, 2011 at 02:57:20PM +0100, Daniel P. Berrange wrote:
On Tue, Oct 11, 2011 at 03:44:32PM +0200, Guido Günther wrote:
On Tue, Oct 11, 2011 at 08:41:09AM +0100, Daniel P. Berrange wrote:
On Mon, Oct 10, 2011 at 04:15:47PM -0600, Eric Blake wrote:
On 10/10/2011 03:46 PM, Guido
On Tue, Oct 11, 2011 at 3:35 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Fri, Oct 07, 2011 at 02:59:28PM +0300, Zeeshan Ali (Khattak) wrote:
Not sure about booleans though. Do
we really need to check if value is provided btw? AFAIK, every
node/attribute has a default value.
Ah if
On 10/11/2011 07:47 AM, Guido Günther wrote:
Hi,
I got a bit confused how snapshotting/reverting is supposed to work now
so I added some tests. O.k. to apply?
This requires Sys::Virt 0.9.5.
Cheers,
-- Guido
I haven't looked at this test yet, but we also need Dan's proposed tests
to be
Note that make check still fails for me in VPATH build because od
undefined references in libvirt_test.a which I don't really understand
since src/Makefile.am contains
libvirt_la_LIBADD += probes.o
libvirt_test_la_LIBADD = $(libvirt_la_LIBADD)
This is a sample of the erros I get:
On Mon, Oct 10, 2011 at 09:45:09PM +0800, Lei HH Li wrote:
Hi Lei. You are missing a patch summary at the top of this email. In your
summary you want to let reviewers know what the patch is doing. For example,
this patch defines the new virDomainBlockIoThrottle API and specifies the XML
On Tue, Oct 11, 2011 at 05:17:03PM +0300, Zeeshan Ali (Khattak) wrote:
Can't we declare that as more advanced/special use-case and
therefore have the app developer use libxml directly? We will still be
helping out by providing a direct pointer to XMLNode.
That's also an option, but that's
On 10/11/2011 08:49 AM, Jiri Denemark wrote:
Note that make check still fails for me in VPATH build because od
undefined references in libvirt_test.a which I don't really understand
since src/Makefile.am contains
libvirt_la_LIBADD += probes.o
libvirt_test_la_LIBADD = $(libvirt_la_LIBADD)
This
On Mon, Oct 10, 2011 at 09:45:10PM +0800, Lei HH Li wrote:
Patch summary please.
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com
---
daemon/remote.c | 51
src/remote/remote_driver.c | 53
On 10/11/2011 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
If we are comparing storage pools we must skip comparing with
ourself, so that re-defining an existing pool works
* conf/storage_conf.c: Skip self when comparing
---
src/conf/storage_conf.c |4
On 10/11/2011 04:26 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Very occassionally the sequence of events from poll would result
s/occassionally/occasionally/
in getting a HANGUP on its own, instead of a HANGUP+READABLE
at the same time. In the former case we
On Mon, Oct 10, 2011 at 09:45:12PM +0800, Lei HH Li wrote:
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com
---
tools/virsh.c | 86
+++
tools/virsh.pod | 13
2 files changed, 99 insertions(+), 0 deletions(-)
diff
On 10/11/2011 05:17 AM, Daniel P. Berrange wrote:
Looks like a parallel make issue, wrt probes.o
I think the following might be what we need:
diff --git a/src/Makefile.am b/src/Makefile.am
index f937b97..6451ad3 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1253,7 +1253,8 @@
On Mon, Oct 10, 2011 at 09:45:11PM +0800, Lei HH Li wrote:
Summary here.
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com
---
src/qemu/qemu_command.c | 35 ++
src/qemu/qemu_driver.c | 54 +
src/qemu/qemu_migration.c| 16 +++---
Hi,
when building libvirt in Fedora/s390x I've found that xenlight needs to
be explicitly disabled in the spec file. Configure properly sets the
library as non-existent, but the %files section still wants to package
the 3 /var/*/libvirt/libxl directories. See also
On 10/11/2011 06:02 PM, Rick Vernam wrote:
On Tuesday 11 October 2011 10:45:14 Paolo Bonzini wrote:
Hi all, please go here to cast your vote on when QEMU 1.0 test day will
be help.
http://www.doodle.com/35ae4zk7e4ndb5qq
Having an official date will make it easier to put people in
---
libvirt-gobject/libvirt-gobject-input-stream.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-input-stream.c
b/libvirt-gobject/libvirt-gobject-input-stream.c
index a76d670..39459c4 100644
---
On 10/11/2011 08:49 AM, Jiri Denemark wrote:
Note that make check still fails for me in VPATH build because od
undefined references in libvirt_test.a which I don't really understand
since src/Makefile.am contains
libvirt_la_LIBADD += probes.o
libvirt_test_la_LIBADD = $(libvirt_la_LIBADD)
This
Hey,
It took me a bit of time to understand that GVirInputStream is an internal
object and that the only way to get one is to go through GVirStream.
ACK from me.
Christophe
On Tue, Oct 11, 2011 at 07:38:45PM +0200, Marc-André Lureau wrote:
---
libvirt-gobject/libvirt-gobject-input-stream.c |
Building on Linux with dtrace enabled was failing 'make check':
CCLD nodeinfotest
../src/.libs/libvirt_test.a(libvirt_net_rpc_client_la-virnetclient.o): In
function `virNetClientNew':
/home/remote/eblake/libvirt/src/rpc/virnetclient.c:162: undefined reference to
On Tue, Oct 11, 2011 at 13:54:40 -0600, Eric Blake wrote:
Building on Linux with dtrace enabled was failing 'make check':
CCLD nodeinfotest
../src/.libs/libvirt_test.a(libvirt_net_rpc_client_la-virnetclient.o): In
function `virNetClientNew':
On 10/11/2011 01:59 PM, Jiri Denemark wrote:
On Tue, Oct 11, 2011 at 13:54:40 -0600, Eric Blake wrote:
Building on Linux with dtrace enabled was failing 'make check':
CCLD nodeinfotest
../src/.libs/libvirt_test.a(libvirt_net_rpc_client_la-virnetclient.o): In
function `virNetClientNew':
On 10/11/2011 09:30 AM, Dan Horák wrote:
Hi,
when building libvirt in Fedora/s390x I've found that xenlight needs to
be explicitly disabled in the spec file. Configure properly sets the
library as non-existent, but the %files section still wants to package
the 3/var/*/libvirt/libxl directories.
Otherwise, 'make rpm' fails with:
GENlibvirt_qemu.def
make[2]: *** No rule to make target `dtrace2systemtap.pl', needed by
`libvirt_probes.stp'. Stop.
* src/Makefile.am (EXTRA_DIST): Add recent script additions.
---
Pushing under the build-breaker rule.
src/Makefile.am |8 +---
On 10/11/2011 02:38 PM, Eric Blake wrote:
Otherwise, 'make rpm' fails with:
GENlibvirt_qemu.def
make[2]: *** No rule to make target `dtrace2systemtap.pl', needed by
`libvirt_probes.stp'. Stop.
* src/Makefile.am (EXTRA_DIST): Add recent script additions.
---
Pushing under the
On Tue, Oct 11, 2011 at 08:33:49AM -0600, Eric Blake wrote:
On 10/11/2011 07:47 AM, Guido Günther wrote:
Hi,
I got a bit confused how snapshotting/reverting is supposed to work now
so I added some tests. O.k. to apply?
This requires Sys::Virt 0.9.5.
Cheers,
-- Guido
I haven't looked at
I got these distcheck failures with sanlock enabled:
ERROR: files left in build directory after distclean:
./tools/virt-sanlock-cleanup
./src/locking/qemu-sanlock.conf
* src/Makefile.am (DISTCLEANFILES) [HAVE_SANLOCK]: Clean built
file.
* tools/Makefile.am (DISTCLEANFILES): Likewise.
---
Since commit ddf3bd3, 'make rpm' failed with:
RPM build errors:
File not found:
/home/remote/eblake/rpmbuild/BUILDROOT/libvirt-0.9.6-1.fc14.eblake1318366440.x86_64/usr/share/systemtap/tapset/libvirtd.stp
* libvirt.spec.in (with_dtrace): Match installed .stp files.
---
Pushing under the
On 10/10/2011 05:45 AM, Michal Privoznik wrote:
Currently, push pop from event queue (both server client side)
rely on lock from higher levels, e.g. on driver lock (qemu),
private_data (remote), ...; This alone is not sufficient as not
every function that interacts with this queue can/does
Detected by autogen.sh on a cross-mingw build.
* src/libvirt_private.syms (virnetsaslcontext.h): Move symbols...
* src/libvirt_sasl.syms: ...to new file.
* src/Makefile.am (USED_SYM_FILES) [HAVE_SASL]: Use new file.
(EXTRA_DIST): Ship it.
---
Pushing under the build-breaker rule.
On 10/09/2011 09:07 PM, Daniel Veillard wrote:
On Thu, Oct 06, 2011 at 05:41:11PM -0600, Eric Blake wrote:
Rather than having to do:
$ virsh snapshot-revert dom $(virsh snapshot-current dom --name)
I thought it would be nice to do:
$ virsh snaphot-revert dom --current
ACK, an useful
On 10/10/2011 11:53 PM, Daniel Veillard wrote:
On Mon, Oct 10, 2011 at 03:35:42PM -0600, Eric Blake wrote:
To date, disk snapshots worked by accident, as they were always
using hmp fallback due to a typo in commit e702b5b not picking up
on the (intentional) difference in command names between
On 10/10/2011 08:39 PM, Daniel Veillard wrote:
Okay, agreed then, I was just wondering if more 'canonical' code
and data would lead to simpler code and hence easier to debug in case
of trouble, but we are already in the optimization phase, so fine :-)
ACK
I'll wait on your feedback
I found there's a way for a unprivileged user to overwrite sensitive
system file with virsh, here's how:
1. (as an unprivileged user) start virsh and connect to the r/w socket
of libvirtd:
virsh -c qemu+unix:///system?socket=/var/run/libvirt/libvirt-sock
2. start a guest, then issue 'save'
Hi All,
I failed to 'make distcheck' on Ubuntu 11.04 with the following
information:
.33 OK
PASS: nwfilterschematest
TEST: domainsnapshotschematest
... 11 OK
PASS: domainsnapshotschematest
TEST:
The keepalive program has two procedures: PING, and PONG.
Both are used only in asynchronous messages and the sender doesn't wait
for any reply. However, the party which receives PING messages is
supposed to react by sending PONG message the other party, but no
explicit binding between PING and
This patchset can also be found at
https://gitorious.org/~jirka/libvirt/jirka-staging/commits/keepalive
This allows us to detect broken connections between server and client without
waiting for TCP timeout and dead deamon/client. By default a connection is
considered broken after about 30
virConnectSetKeepAlive public API can be used by a client connecting to
remote server to start using keepalive protocol. The API is handled
directly by remote driver and not transmitted over the wire to the
server.
---
Notes:
Version 3:
- remove virConnectAllowKeepAlive
- rename
These APIs are used by both client and server RPC layer to handle
processing of keepalive messages.
---
Notes:
Version 3:
- remove ADVERTISE message handling
Version 2:
- no change
po/POTFILES.in |1 +
src/Makefile.am|3 +-
src/rpc/virkeepalive.c |
Since virsh already implements event loop, it has to also run it. So far
the event loop was only running during virsh console command.
---
Notes:
Version 3:
- new patch
tools/console.c | 17 ++---
tools/virsh.c | 31 +++
2 files changed, 45
When a client wants to send a keepalive message it needs to do so in a
non-blocking way to avoid blocking its event loop. This patch adds
dontBlock flag which says that the call should be processed without
blocking. Such calls do not have a thread waiting for the result
associated with them. This
---
Notes:
Version 3:
- remoteStartKeepAlive renamed as remoteSetKeepAlive
- clients that implement event loop are required to run it, thus
keepalive is enabled if event loop implementation is found without
the need to call remoteAllowKeepAlive (which was dropped)
-
---
Notes:
Version 3:
- keepalive_supported configuration option can be used to refuse
connections from clients that do not support keepalive protocol
- explain what keepalive_interval = -1 means
- start up the keepalive protocol when a client asks if we support
it
---
Notes:
Version 3:
- no changes
Version 2:
- no changes
src/rpc/virnetclient.c | 76 ++--
1 files changed, 67 insertions(+), 9 deletions(-)
diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c
index 8ac319a..e33f745
---
Notes:
Version 3:
- no changes
Version 2:
- new patch
src/esx/esx_driver.c | 18 ++
src/hyperv/hyperv_driver.c | 18 ++
src/libxl/libxl_driver.c |8
src/lxc/lxc_driver.c |7 +++
---
Notes:
Version 3:
- explain what keepalive_interval = -1 means
- update to client API changes (virConnectAllowKeepAlive dropped
and virConnectStartKeepAlive renamed as virConnectSetKeepAlive)
Version 2:
- no changes
src/qemu/libvirtd_qemu.aug |2 ++
This API can be used to check if the socket associated with
virConnectPtr is still open or it was closed (probably because keepalive
protocol timed out). If there the connection is local (i.e., no socket
is associated with the connection, it is trivially always alive.
---
Notes:
Version 3:
---
Notes:
Version 3:
- update to client API changes (virConnectAllowKeepAlive dropped
and virConnectStartKeepAlive renamed as virConnectSetKeepAlive)
Version 2:
- automatically exit when a connection is closed because of
keepalive timeout
If a connection to destination host is lost during peer-to-peer
migration (because keepalive protocol timed out), we won't be able to
finish the migration and it doesn't make sense to wait for qemu to
transmit all data. This patch automatically cancels such migration
without waiting for
On 10/12/2011 01:14 PM, Wenyi Gao wrote:
Hi All,
I failed to 'make distcheck' on Ubuntu 11.04 with the following
information:
.33 OK
PASS: nwfilterschematest
TEST: domainsnapshotschematest
... 11 OK
81 matches
Mail list logo
