Re: [libvirt] [PATCH v2 1/4] doc: Add deviceboot capability.

2011-11-03 Thread Philipp Hahn
Hello, Ping? At least this patch should qualify for 0.9.7. Currently it's only used by qemu, but currently there's no test case for qemu, which uses deviceboot, so it was never noticed that it's missing in the schema. On Tuesday 01 November 2011 10:27:47 Philipp Hahn wrote: Allow

Re: [libvirt] [PATCH 2/2] virnetsockettest: Use a temporary directory in /tmp

2011-11-03 Thread Guido Günther
On Wed, Nov 02, 2011 at 04:28:54PM -0600, Eric Blake wrote: On 11/02/2011 04:00 PM, Guido Günther wrote: +template = strdup(/tmp/libvirt_XX); No need to malloc() the template. Just do: char template[] = /tmp/libvirt_XX; This was actually the first version I had but it

[libvirt] can't start domain with a corrupted disk attatched

2011-11-03 Thread lvroyce
Hi all, I came across below issue when testing: 1.make a volume and attach it to a domain A 2.unplug the vg from the host in order to emulating a volume failure 3.start domain A(failed) In step 3 can't start domainA . because can't find disk listed in xml when create the

Re: [libvirt] [PATCH v2 2/4] xen: support bootable flag for Xen-PV.

2011-11-03 Thread Jiri Denemark
On Mon, Oct 31, 2011 at 13:39:09 +0100, Philipp Hahn wrote: Add support for adding the bootable S-Expr to disks. This is needd for Xen-PV domains using GyPgrub as the boot loader. Signed-off-by: Philipp Hahn h...@univention.de --- src/xen/xend_internal.c |4 ++-- src/xenxs/xen_sxpr.c

Re: [libvirt] [PATCH v2 1/4] doc: Add deviceboot capability.

2011-11-03 Thread Jiri Denemark
On Tue, Nov 01, 2011 at 10:27:47 +0100, Philipp Hahn wrote: Allow /capabilities/guest/features/deviceboot. Signed-off-by: Philipp Hahn h...@univention.de --- docs/schemas/capability.rng |5 + 1 files changed, 5 insertions(+), 0 deletions(-) ACK and I agree with this being 0.9.7

Re: [libvirt] Start of freeze for libvirt-0.9.7 and availability of rc1

2011-11-03 Thread Daniel Veillard
Thanks to everybody who provided feedback and patches on rc1, I have made an rc2 available at ftp://libvirt.org/libvirt/libvirt-0.9.7-rc2.tar.gz there is also the rpms rebuilds for Fedora 14. One think I noted while the rpm was building is the following warnings: CCLD libvirt_test.la ***

Re: [libvirt] [PATCH v2 3/4] xen: fix PyGrub device order using boot/@order

2011-11-03 Thread Jiri Denemark
On Mon, Oct 31, 2011 at 13:39:09 +0100, Philipp Hahn wrote: When PyGrub is used as the bootloader in Xen, it gets passed the first bootable disk. Xend supports a bootable-flag for this, which was previously unused. In commit c2969ec7aec5c40519aadf422ab5c47a21938bff the bootable=1 flag was

Re: [libvirt] Start of freeze for libvirt-0.9.7 and availability of rc1

2011-11-03 Thread Daniel P. Berrange
On Thu, Nov 03, 2011 at 06:19:25PM +0800, Daniel Veillard wrote: Thanks to everybody who provided feedback and patches on rc1, I have made an rc2 available at ftp://libvirt.org/libvirt/libvirt-0.9.7-rc2.tar.gz there is also the rpms rebuilds for Fedora 14. One think I noted while the rpm

[libvirt] [PATCH 2/4] remote driver implementation

2011-11-03 Thread Hong Xiang
* src/remote/remote_driver.c: remote_driver data structure extension. * src/remote/remote_protocol.x: remote protocol extension. Signed-off-by: Hong Xiang hxi...@linux.vnet.ibm.com --- src/remote/remote_driver.c |4 src/remote/remote_protocol.x | 31 ++-

[libvirt] [PATCH 0/4] new APIs/commands for managed core dump

2011-11-03 Thread Hong Xiang
This patch series added new APIs and virsh commands for 'managed core dump' functionality. Existing functionalities are intact. The 'managed core dump' functionality is in line with 'managed save', there can be at most 1 managed core dump per domain. In addition to the

[libvirt] [PATCH 4/4] New virsh commands for managed core dump

2011-11-03 Thread Hong Xiang
New commands: . manageddump . manageddump-remove . manageddump-download * tools/virsh.c: new commands. Signed-off-by: Hong Xiang hxi...@linux.vnet.ibm.com --- tools/virsh.c | 200 + 1 files changed, 200 insertions(+), 0 deletions(-) diff

[libvirt] [PATCH 3/4] qemu driver implementation

2011-11-03 Thread Hong Xiang
* src/qemu/qemu_conf.h: qemud_driver data structure extension. * src/qemu/qemu_driver.c: qemu driver API extension. Signed-off-by: Hong Xiang hxi...@linux.vnet.ibm.com --- src/qemu/qemu_conf.h |2 + src/qemu/qemu_driver.c | 176 +++- 2 files

[libvirt] [PATCH 1/4] new public APIs for managed core dump

2011-11-03 Thread Hong Xiang
Added new public APIs for managed-core-dump. In line with managed-save functionality, there's at most one managed core-dump per domain. New APIs: . virDomainManagedCoreDump . virDomainHasManagedCoreDump . virDomainManagedCoreDumpRemove . virDomainManagedCoreDumpDownload *

[libvirt] Re: can't start domain with a corrupted disk attatched

2011-11-03 Thread Nicolas Sebrecht
The 03/11/11, lvroyce wrote: Hi all, I came across below issue when testing: 1.make a volume and attach it to a domain A 2.unplug the vg from the host in order to emulating a volume failure 3.start domain A(failed) In step 3 can't start domainA . because can't find

Re: [libvirt] [PATCH v2 3/4] xen: fix PyGrub device order using boot/@order

2011-11-03 Thread Jiri Denemark
On Thu, Nov 03, 2011 at 11:21:24 +0100, Jiri Denemark wrote: On Mon, Oct 31, 2011 at 13:39:09 +0100, Philipp Hahn wrote: When PyGrub is used as the bootloader in Xen, it gets passed the first bootable disk. Xend supports a bootable-flag for this, which was previously unused. In commit

Re: [libvirt] [PATCH 1/7] Allow multiple consoles per virtual guest

2011-11-03 Thread Daniel P. Berrange
On Tue, Nov 01, 2011 at 04:03:27PM -0600, Eric Blake wrote: On 10/20/2011 08:47 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com While Xen only has a single paravirt console, UML, and QEMU both support multiple paravirt consoles. The LXC driver can also be trivially

Re: [libvirt] [PATCH 4/7] Add support for multiple consoles in LXC

2011-11-03 Thread Daniel P. Berrange
On Wed, Nov 02, 2011 at 02:46:50PM -0600, Eric Blake wrote: On 10/20/2011 08:47 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Currently the LXC controller only supports setup of a single text console. This is wired up to the container init's stdio, as well as

Re: [libvirt] [PATCH] Remove translations in socket test case

2011-11-03 Thread Stefan Berger
On 11/03/2011 06:54 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com The test case errors should not be translated since they're only targetted at developers, not users. * tests/virnetsockettest.c: Remove error reporting with translations --- tests/virnetsockettest.c

[libvirt] [PATCH 01/10] enable cgroup cpuset by default

2011-11-03 Thread Hu Tao
This prepares for subsequent patches which introduce dependence on cgroup cpuset. Enable cgroup cpuset by default so users don't have to modify configuration file before encountering a cpuset error. --- src/qemu/qemu.conf |5 +++-- src/qemu/qemu_conf.c |3 ++- 2 files changed, 5

[libvirt] [PATCH 03/10] use cpuset to manage numa

2011-11-03 Thread Hu Tao
This patch deprecates libnuma and uses cpuset to manage numa. We can further add a `numatune' command to adjust numa parameters through cpuset. --- src/qemu/qemu_cgroup.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_cgroup.c

[libvirt] [PATCH 05/10] new numa parameters

2011-11-03 Thread Hu Tao
This patch adds two parameters: strict and exclusive that we can get/set through cpuset. --- src/conf/domain_conf.c | 15 +++ src/conf/domain_conf.h |2 ++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH 06/10] add new API virDomain{G, S}etNumaParameters

2011-11-03 Thread Hu Tao
Set up the types for the numa functions and insert them into the virDriver structure definition. --- include/libvirt/libvirt.h.in | 23 +++ python/generator.py |2 ++ src/driver.h | 15 +++ src/libvirt_public.syms |6 ++

[libvirt] [RFC PATCH 00/10] use cpuset to manage numa

2011-11-03 Thread Hu Tao
The goal of this series is to use cpuset to manage numa. Currently numa tuning is achieved by libnuma, the disadvantage is numa parameters can not be modified when the domain is running. By using cpuset, we can do this and more: - a new command, numatune, to get/set numa parameters - cpuset

[libvirt] [PATCH 07/10] Implement main entries of virDomain{G, S}etNumaParameters

2011-11-03 Thread Hu Tao
--- src/libvirt.c | 106 + 1 files changed, 106 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index b0d1e01..af791bf 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3712,6 +3712,112 @@ error: } /** + *

[libvirt] [PATCH 10/10] add new command numatune to virsh

2011-11-03 Thread Hu Tao
add new command numatune to virsh to get/set numa parameters --- tools/virsh.c | 187 + 1 files changed, 187 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 5544a41..e2c3cc2 100644 --- a/tools/virsh.c +++

[libvirt] [PATCH 08/10] Add virDomain{G, S}etNumaParameters support to the remote driver

2011-11-03 Thread Hu Tao
--- daemon/remote.c | 63 ++ src/remote/remote_driver.c | 50 + src/remote/remote_protocol.x | 25 - src/remote_protocol-structs | 16 ++ 4 files changed, 153 insertions(+), 1

[libvirt] [PATCH 02/10] Add functions to set/get cpuset parameters

2011-11-03 Thread Hu Tao
--- src/libvirt_private.syms |6 +++ src/util/cgroup.c| 80 ++ src/util/cgroup.h|7 3 files changed, 93 insertions(+), 0 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6a1562e..64da63d

[libvirt] [PATCH 04/10] remove dependence on libnuma

2011-11-03 Thread Hu Tao
Since we use cpuset to manage numa, we can safely remove dependence on libnuma. --- src/conf/domain_conf.c | 24 +-- src/conf/domain_conf.h |1 - src/qemu/qemu_process.c | 111 --- 3 files changed, 1 insertions(+), 135 deletions(-)

[libvirt] [PATCH 09/10] Implement virDomain{G, S}etNumaParameters for the qemu driver

2011-11-03 Thread Hu Tao
--- src/qemu/qemu_cgroup.c | 14 ++ src/qemu/qemu_driver.c | 307 2 files changed, 321 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 49307b2..99714ab 100644 --- a/src/qemu/qemu_cgroup.c +++

Re: [libvirt] [PATCH 04/10] remove dependence on libnuma

2011-11-03 Thread Daniel P. Berrange
On Thu, Nov 03, 2011 at 07:55:19PM +0800, Hu Tao wrote: Since we use cpuset to manage numa, we can safely remove dependence on libnuma. --- src/conf/domain_conf.c | 24 +-- src/conf/domain_conf.h |1 - src/qemu/qemu_process.c | 111

Re: [libvirt] [PATCH 05/10] new numa parameters

2011-11-03 Thread Daniel P. Berrange
On Thu, Nov 03, 2011 at 07:55:20PM +0800, Hu Tao wrote: This patch adds two parameters: strict and exclusive that we can get/set through cpuset. --- src/conf/domain_conf.c | 15 +++ src/conf/domain_conf.h |2 ++ 2 files changed, 17 insertions(+), 0 deletions(-) diff

[libvirt] sVirt support for LXC?

2011-11-03 Thread Dong-In David Kang
Hello, We are at the later stage of a project. We are very much interested in sVirt support for LXC. Is there any branch that we can try? We are willing to test one. As I wrote below, we tried Daniel's branch https://gitorious.org/~berrange/libvirt/staging/commits/lxc-svirt. But we didn't

Re: [libvirt] sVirt support for LXC?

2011-11-03 Thread Daniel P. Berrange
On Thu, Nov 03, 2011 at 07:06:46AM -0700, Dong-In David Kang wrote: Hello, We are at the later stage of a project. We are very much interested in sVirt support for LXC. Is there any branch that we can try? We are willing to test one. As I wrote below, we tried Daniel's branch

Re: [libvirt] sVirt support for LXC?

2011-11-03 Thread Dong-In David Kang
Thanks a lot. It would be wonderful if it can be done by the end of November. David. -- Dr. Dong-In David Kang Computer Scientist USC/ISI - Original Message - From: Daniel P. Berrange berra...@redhat.com To: Dong-In David Kang dk...@isi.edu Cc:

[libvirt] [PATCH] lxc: use common code for process cleanup

2011-11-03 Thread Eric Blake
Based on a Coverity report - the return value of waitpid() should always be checked, to avoid problems with leaking resources. * src/lxc/lxc_controller.c (lxcControllerRun): Use simpler virPidAbort. --- Daniel previously said to wait until after the lxc multi-console patches were in before

Re: [libvirt] [PATCH] lxc: use common code for process cleanup

2011-11-03 Thread Daniel P. Berrange
On Thu, Nov 03, 2011 at 08:45:45AM -0600, Eric Blake wrote: Based on a Coverity report - the return value of waitpid() should always be checked, to avoid problems with leaking resources. * src/lxc/lxc_controller.c (lxcControllerRun): Use simpler virPidAbort. --- Daniel previously said to

[libvirt] client hang in virDomainCreateXML

2011-11-03 Thread Wolverine
Hi, We are using Ubuntu 10.04 eucalyptus 1.6.2 and libvirt 0.7.5. We found eucalyptus-nc sometimes hangs in virDomainCreateXML, and never gets response from libvirtd. After 2 days of investigation, I found there is another libvirt client connects to libvirtd 'qemu:///system', which is the same

Re: [libvirt] [PATCH] lxc: use common code for process cleanup

2011-11-03 Thread Eric Blake
On 11/03/2011 08:48 AM, Daniel P. Berrange wrote: On Thu, Nov 03, 2011 at 08:45:45AM -0600, Eric Blake wrote: Based on a Coverity report - the return value of waitpid() should always be checked, to avoid problems with leaking resources. * src/lxc/lxc_controller.c (lxcControllerRun): Use

Re: [libvirt] can't start domain with a corrupted disk attatched

2011-11-03 Thread shu ming
On 2011-11-3 18:12, Daniel P. Berrange wrote: On Thu, Nov 03, 2011 at 05:33:56PM +0800, lvroyce wrote: Hi all, I came across below issue when testing: 1.make a volume and attach it to a domain A 2.unplug the vg from the host in order to emulating a volume failure 3.start

Re: [libvirt] [libvirt-glib] Ask gtkdoc-scan to generate the sections file

2011-11-03 Thread Daniel P. Berrange
On Tue, Nov 01, 2011 at 06:45:44PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This frees us from maintaining the sections file. --- docs/libvirt-gconfig/Libvirt-gconfig-sections.txt | 166 -- docs/libvirt-gconfig/Makefile.am

[libvirt] [PATCH 11/33] Rename virVirtualPortProfileParams APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Rename the virVirtualPortProfileParams struct to be virNetDevVPortProfile, and rename the APIs to match this prefix. * src/util/network.c, src/util/network.h: Rename port profile APIs * src/conf/domain_conf.c, src/conf/domain_conf.h,

[libvirt] [PATCH 03/33] Rename all brXXXX APIs to follow new convention

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The existing brXXX APIs in src/util/bridge.h are renamed to follow one of three different conventions - virNetDevXXX - operations for any type of interface - virNetDevBridgeXXX - operations for bridge interfaces - virNetDevTapXXX-

[libvirt] [PATCH 00/33] Refactor all network device handling code

2011-11-03 Thread Daniel P. Berrange
This series is a major re-arrangement and de-duplication of internal code for dealing with physical network interfaces. Currently code for physical network interfaces is split across the following files - bridge.c: bridge management, TAP device management and interface IPv4 address

[libvirt] [PATCH 05/33] Expose MTU management APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The MTU management APIs are useful to other code inside libvirt, so should be exposed as non-static APIs. * src/util/bridge.c, src/util/bridge.h: Expose virNetDevSetMTU, virNetDevSetMTUFromDevice virNetDevGetMTU --- src/util/bridge.c | 18

[libvirt] [PATCH 22/33] Move the low level macvlan creation APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the low level macvlan creation APIs into the virnetdevmacvlan.c file where they more naturally belong * util/interface.c, util/interface.h: Remove virNetDevMacVLanCreate and virNetDevMacVLanDelete * util/virnetdevmacvlan.c,

[libvirt] [PATCH 16/33] Remove ifaceUp, ifaceDown, ifaceCtrl ifaceIsUp APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The ifaceUp, ifaceDown, ifaceCtrl ifaceIsUp APIs can be replaced with calls to virNetDevSetOnline and virNetDevIsOnline * src/util/interface.c, src/util/interface.h: Delete ifaceUp, ifaceDown, ifaceCtrl ifaceIsUp *

[libvirt] [PATCH 28/33] Move virNetDevGetIPv4Address to virnetdev.c

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the virNetDevGetIPv4Address function to virnetdev.c * util/interface.c, util/interface.h: Remove virNetDevGetIPv4Address * util/virnetdev.c, util/virnetdev.h: Add virNetDevGetIPv4Address --- src/util/interface.c | 63

[libvirt] [PATCH 06/33] Add an API for retrieving the MAC address of an interface

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com * src/util/bridge.c, src/util/bridge.h: Add virNetDevGetMAC --- src/util/bridge.c | 35 +++ src/util/bridge.h |3 +++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/src/util/bridge.c

[libvirt] [PATCH 15/33] Move LXC veth.c code into shared utility APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the virNetDevSetName and virNetDevSetNamespace APIs out of LXC's veth.c and into virnetdev.c. Move the remaining content of the file to src/util/virnetdevveth.c * src/lxc/veth.c: Rename to src/util/virnetdevveth.c * src/lxc/veth.h: Rename to

[libvirt] [PATCH 14/33] Rename the LXC veth management APIs and delete duplicated APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The src/lxc/veth.c file contains APIs for managing veth devices, but some of the APIs duplicate stuff from src/util/virnetdev.h. Delete thed duplicate APIs and rename the remaining ones to follow virNetDevVeth * src/lxc/veth.c, src/lxc/veth.h:

[libvirt] [PATCH 29/33] Rename ifaceCheck to virNetDevValidateConfig

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Rename the ifaceCheck method to virNetDevValidateConfig and change so that it always raises an error and returns -1 on error. * src/util/interface.c, src/util/interface.h: Rename ifaceCheck to virNetDevValidateConfig *

[libvirt] [PATCH 17/33] Remove ifaceSetMac and ifaceGetMac APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The ifaceSetMac and ifaceGetMac APIs duplicate the functionality of the virNetDevSetMAC and virNetDevGetMAC APIs, but returning errno's instead of raising errors. * src/util/interface.c, src/util/interface.h: Remove ifaceSetMac and ifaceGetMac APIs,

[libvirt] [PATCH 24/33] Move MAC address replacement functions to virnetdev.c

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move virNetDevReplaceMacAddress and virNetDevRestoreMacAddress to the virnetdev.c file where they naturally belong * util/interface.c, util/interface.h: Remove virNetDevReplaceMacAddress and virNetDevRestoreMacAddress * util/virnetdev.c,

[libvirt] [PATCH 27/33] Rename ifaceGetIPAddress to virNetDevGetIPv4Address

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com To match up with the existing virNetDevSetIPv4Address, rename ifaceGetIPAddress to virNetDevGetIPv4Address * util/interface.h, util/interface.c: Rename API * network/bridge_driver.c: Update for API rename --- src/libvirt_private.syms|2 +-

[libvirt] [PATCH 31/33] Rename APIs for dealing with virtual/physical functions

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Rename ifaceIsVirtualFunction to virNetDevIsVirtualFunction, ifaceGetVirtualFunctionIndex to virNetDevGetVirtualFunctionIndex and ifaceGetPhysicalFunction to virNetDevGetPhysicalFunction * src/util/interface.c, src/util/interface.h: Rename APIs *

[libvirt] [PATCH 23/33] Rename interface MAC address replacement APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Rename ifaceReplaceMacAddress to virNetDevReplaceMacAddress and ifaceRestoreMacAddress to virNetDevRestoreMacAddress. * util/interface.c, util/interface.h, util/virnetdevmacvlan.c: Rename APIs --- src/libvirt_private.syms|4 ++--

[libvirt] [PATCH 18/33] Rename Macvtap management APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com In preparation for code re-organization, rename the Macvtap management APIs to have the following patterns virNetDevMacVLanX - macvlan/macvtap interface management virNetDevVPortProfile - virtual port profile management *

[libvirt] [PATCH 25/33] Rename ifaceGetIndex and ifaceGetVLAN

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Rename the ifaceGetIndex method to virNetDevGetIndex and ifaceGetVlanID to virNetDevGetVLanID. Also change the error reporting behaviour to always raise errors and return -1 on failure * util/interface.c, util/interface.h: Rename ifaceGetIndex and

[libvirt] [PATCH 32/33] Move functions for dealing with physical/virtual devices

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move virNetDevIsVirtualFunction, virNetDevGetVirtualFunctionIndex and virNetDevGetPhysicalFunction to virnetdev.c * src/util/interface.c, src/util/interface.h, src/util/virnetdev.c, src/util/virnetdev.h: Move APIs --- src/util/interface.c | 146

[libvirt] [PATCH 12/33] Fix error reporting in port profile parsing/formatting APIs

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virtual port profile parsing/formatting APIs do not correctly handle unknown profile type strings/numbers. They behave as a no-op, instead of raising an error * src/util/network.c, src/util/network.h: Fix error handling of port profile APIs *

[libvirt] [PATCH 33/33] Move ifaceMacvtapLinkDump and ifaceGetNthParent functions

2011-11-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the ifaceMacvtapLinkDump and ifaceGetNthParent functions into virnetdevvportprofile.c since they are specific to that code. This avoids polluting the headers with the Linux specific netlink data types * src/util/interface.c, src/util/interface.h:

[libvirt] [PATCHv6 3/5] API: add trivial qemu support for VIR_TYPED_PARAM_STRING

2011-11-03 Thread Eric Blake
Qemu will be the first driver to make use of a typed string in the next round of additions. Separate out the trivial addition. * src/qemu/qemu_driver.c (qemudSupportsFeature): Advertise feature. (qemuDomainGetBlkioParameters, qemuDomainGetMemoryParameters) (qemuGetSchedulerParametersFlags,

[libvirt] [PATCHv6 1/5] API: add VIR_TYPED_PARAM_STRING

2011-11-03 Thread Eric Blake
This allows strings to be transported between client and server in the context of name-type-value virTypedParameter functions. For compatibility, o new clients will not send strings to old servers, based on a feature check o new servers will not send strings to old clients without

[libvirt] [PATCHv6 5/5] blkiotune: add qemu support for blkiotune.device_weight

2011-11-03 Thread Eric Blake
From: Hu Tao hu...@cn.fujitsu.com Implement setting/getting per-device blkio weights in qemu, using the cgroups blkio.weight_device tunable. --- v5: did not include this patch v6: split v4 2/2 into two parts; this part covers just the qemu. Rebase to accomodate 'device_weight' naming and

[libvirt] [PATCHv6 0/5] expose per-device blkio weight tuning, via string param

2011-11-03 Thread Eric Blake
This is v6 of Hu's original proposal: v1: https://www.redhat.com/archives/libvir-list/2011-September/msg00334.html v4: https://www.redhat.com/archives/libvir-list/2011-October/msg00444.html v5: https://www.redhat.com/archives/libvir-list/2011-November/msg00060.html Patches 1-3 are solid in my

[libvirt] [PATCHv6 2/5] API: remote support for VIR_TYPED_PARAM_STRING

2011-11-03 Thread Eric Blake
Send and receive string typed parameters across RPC. This also completes the back-compat mentioned in the previous patch - the only time we have an older client talking to a newer server is if RPC is in use, so filtering out strings during RPC prevents returning an unknown type to the older

Re: [libvirt] [PATCH v2 1/4] doc: Add deviceboot capability.

2011-11-03 Thread Eric Blake
On 11/03/2011 04:10 AM, Jiri Denemark wrote: On Tue, Nov 01, 2011 at 10:27:47 +0100, Philipp Hahn wrote: Allow /capabilities/guest/features/deviceboot. Signed-off-by: Philipp Hahnh...@univention.de --- docs/schemas/capability.rng |5 + 1 files changed, 5 insertions(+), 0

[libvirt] [PATCH] build: fix deep VPATH builds

2011-11-03 Thread Eric Blake
I ran into the following build failure: $ mkdir -p build1 build2/a/very/deep/hierarcy $ cd build2/a/very/deep/hierarcy $ ../../../../../configure make $ cd ../../../../build1 $ ../configure make ... ../../src/remote/remote_protocol.c:7:55: fatal error:

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.7 and availability of rc1

2011-11-03 Thread Eric Blake
On 11/03/2011 04:19 AM, Daniel Veillard wrote: Thanks to everybody who provided feedback and patches on rc1, I have made an rc2 available at ftp://libvirt.org/libvirt/libvirt-0.9.7-rc2.tar.gz *** Warning: Linking the shared library libvirt.la against the non-libtool *** objects

Re: [libvirt] [Libvirt-announce] Start of freeze for libvirt-0.9.7 and availability of rc1

2011-11-03 Thread Jason Helfman
On Tue, Nov 01, 2011 at 08:20:16AM -0600, Eric Blake thus spake: On 11/01/2011 04:44 AM, Justin Clift wrote: Fails on OSX 10.6.8, with this: make all-am Undefined symbols: _ptsname_r, referenced from: _virFileOpenTty in libvirt_util.a(libvirt_util_la-util.o) ld:

Re: [libvirt] Start of freeze for libvirt-0.9.7 and availability of rc1

2011-11-03 Thread Guido Günther
On Thu, Nov 03, 2011 at 06:19:25PM +0800, Daniel Veillard wrote: Thanks to everybody who provided feedback and patches on rc1, I have made an rc2 available at ftp://libvirt.org/libvirt/libvirt-0.9.7-rc2.tar.gz there is also the rpms rebuilds for Fedora 14. Builds fine now on Debian:

Re: [libvirt] [PATCHv6 2/5] API: remote support for VIR_TYPED_PARAM_STRING

2011-11-03 Thread Stefan Berger
On 11/03/2011 02:05 PM, Eric Blake wrote: Send and receive string typed parameters across RPC. This also completes the back-compat mentioned in the previous patch - the only time we have an older client talking to a newer server is if RPC is in use, so filtering out strings during RPC prevents

[libvirt] [PATCH] lxc: avoid use-after-free

2011-11-03 Thread Eric Blake
I got this weird failure: error: Failed to start domain simple error: internal error cannot mix caller fds with blocking execution and tracked it down to a use-after-free - virCommandSetOutputFD was storing the address of a stack-local variable, which then went out of scope before the

Re: [libvirt] [PATCHv6 4/5] blkiotune: add interface for blkiotune.device_weight

2011-11-03 Thread Stefan Berger
On 11/03/2011 02:06 PM, Eric Blake wrote: This adds per-device weights toblkiotune. Note that the cgroups implementation only supports weights per block device, and not per-file within the device; hence this option must be global to the domain definition rather than tied to individual