Re: [libvirt] [Libguestfs] [ANNOUNCE] libguestfs webinar TOMORROW (Friday)

2011-11-18 Thread Richard W.M. Jones
On Thu, Nov 17, 2011 at 08:23:14PM +, Richard W.M. Jones wrote: date -d '2011-11-17 16:00Z' This command should be: date -d '2011-11-18 16:00Z' Full call-in details are now available here: https://rwmj.wordpress.com/2011/11/17/libguestfs-web-seminar-this-friday/ Rich. -- Richard

Re: [libvirt] [libvirt-glib] Adjust example to pygobject-3.0

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 10:38:01PM +0100, Guido Günther wrote: Hi, attached patch makes the example work again with recent pygobject-3.0 which doesn't allow to import gtk anymore. Cheers, ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [RFC][PATCHv2 00/11] add numatune command

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:10PM +0800, Hu Tao wrote: This series does mainly two things: 1. use cgroup cpuset to manage numa parameters 2. add a virsh command numatune to allow user to change numa parameters from command line Current numa parameters include nodeset and mode,

Re: [libvirt] [PATCHv2 07/11] add new API virDomain{G, S}etNumaParameters

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:17PM +0800, Hu Tao wrote: Set up the types for the numa functions and insert them into the virDriver structure definition. --- include/libvirt/libvirt.h.in | 23 +++ python/generator.py |2 ++ src/driver.h |

Re: [libvirt] [PATCHv2 04/11] introduce numa backend

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:14PM +0800, Hu Tao wrote: Currently we are using libnuma to set up numa, but it's desired to use cgroup cpuset to do the job instead. But for old systems that don't have cgroup cpuset, we fall back to libnuma. --- src/conf/domain_conf.h |8

Re: [libvirt] [PATCHv2 06/11] add VIR_DOMAIN_NUMATUNE_MEM_NONE

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:16PM +0800, Hu Tao wrote: add VIR_DOMAIN_NUMATUNE_MEM_NONE to represent none of the numatune modes is set --- src/conf/domain_conf.c |1 + src/conf/domain_conf.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCHv2 03/11] Add functions to set/get cgroup cpuset parameters

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:13PM +0800, Hu Tao wrote: --- src/libvirt_private.syms | 10 src/util/cgroup.c| 112 ++ src/util/cgroup.h| 11 + 3 files changed, 133 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] [PATCHv2 02/11] enable cgroup cpuset by default

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:12PM +0800, Hu Tao wrote: This prepares for subsequent patches which introduce dependence on cgroup cpuset. Enable cgroup cpuset by default so users don't have to modify configuration file before encountering a cpuset error. --- src/qemu/qemu.conf |5

Re: [libvirt] [PATCHv2 05/11] use cpuset to manage numa

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:15PM +0800, Hu Tao wrote: This patch deprecates libnuma and uses cpuset to manage numa. We can further add a `numatune' command to adjust numa parameters through cpuset. --- src/qemu/qemu_cgroup.c | 73 1

Re: [libvirt] [PATCHv2 10/11] Implement virDomain{G, S}etNumaParameters for the qemu driver

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 05:44:20PM +0800, Hu Tao wrote: --- src/qemu/qemu_driver.c | 399 1 files changed, 399 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5f4a18d..5b6398c 100644 ---

Re: [libvirt] [PATCH] storage: Skips backingStore of virtual snapshot lv

2011-11-18 Thread Osier Yang
于 2011年11月18日 19:15, Osier Yang 写道: lvs outputs [$lvname_vorigin] for the virtual snapshot lv (created with --virtualsize), and the original device pointed by $lvname_vorigin is just for lvm internal use, one should never use it. Forgot to mention the problem. If one creates a virtual snapshot

Re: [libvirt] [PATCH V5 10/10] Add test cases

2011-11-18 Thread Stefan Berger
On 11/17/2011 07:17 PM, Eric Blake wrote: On 11/17/2011 01:11 PM, Stefan Berger wrote: Add test case for the chain names with known prefixes and the chain priority. Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com --- tests/nwfilterxml2xmlin/chain_prefixtest1.xml | 37

Re: [libvirt] [PATCH V5 09/10] Interleave jumping into chains with filtering rules in root table

2011-11-18 Thread Stefan Berger
On 11/17/2011 07:15 PM, Eric Blake wrote: On 11/17/2011 01:11 PM, Stefan Berger wrote: The previous patch extends the priority of filtering rules into negative numbers. We now use this possibility to interleave the jumping into chains with filtering rules to for example create the 'root' table

Re: [libvirt] [PATCH V5 07/10] Enable chains with names having a known prefix

2011-11-18 Thread Stefan Berger
On 11/17/2011 06:38 PM, Eric Blake wrote: On 11/17/2011 01:11 PM, Stefan Berger wrote: + +if (strlen(chainname) MAX_CHAIN_SUFFIX_SIZE) { +virNWFilterReportError(VIR_ERR_INVALID_ARG, + _(Name of chain is longer than %u characters), +

Re: [libvirt] [libvirt-glib] Adjust example to pygobject-3.0

2011-11-18 Thread Guido Günther
On Fri, Nov 18, 2011 at 10:00:52AM +, Daniel P. Berrange wrote: On Thu, Nov 17, 2011 at 10:38:01PM +0100, Guido Günther wrote: Hi, attached patch makes the example work again with recent pygobject-3.0 which doesn't allow to import gtk anymore. Cheers, ACK Pushed. Thanks, -- Guido

[libvirt] [PATCH V6 10/11] Add test cases

2011-11-18 Thread Stefan Berger
Add test case for the chain names with known prefixes and the chain priority. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- tests/nwfilterxml2xmlin/chain_prefixtest1.xml | 37 + tests/nwfilterxml2xmlout/chain_prefixtest1.xml | 21 ++

[libvirt] [PATCH V6 00/11] Make inner workings of nwfilters more flexible + extensions

2011-11-18 Thread Stefan Berger
The following series of patches re-does some of the inner workings of nwfilters with the goal to enable users to write filters that have other than the system-known chains supported right now ('root','arp','rarp','ipv4' and 'ipv6'). Ideally users should be able to provide a chain name in the

[libvirt] [PATCH V6 02/11] Introduce an internal priority for chains

2011-11-18 Thread Stefan Berger
For better handling of the sorting of chains introduce an internally used priority. Use a lookup table to store the priorities. For now their actual values do not matter just that the values cause the chains to be properly sorted through changes in the following patches. However, the values are

[libvirt] [PATCH V6 07/11] Enable chains with names having a known prefix

2011-11-18 Thread Stefan Berger
This patch enables chains that have a known prefix in their name. Known prefixes are: 'ipv4', 'ipv6', 'arp', 'rarp'. All prefixes are also protocols that can be evaluated on the ebtables level. Following the prefix they will be automatically connected to an interface's 'root' chain and jumped

[libvirt] [PATCH V6 09/11] Interleave jumping into chains with filtering rules in root table

2011-11-18 Thread Stefan Berger
The previous patch extends the priority of filtering rules into negative numbers. We now use this possibility to interleave the jumping into chains with filtering rules to for example create the 'root' table of an interface with the following sequence of rules: Bridge chain: libvirt-I-vnet0,

[libvirt] [PATCH V6 04/11] Use scripting for cleaning and renaming of chains

2011-11-18 Thread Stefan Berger
Use scripts for the renaming and cleaning up of chains. This allows us to get rid of some of the code that is only capable of renaming and removing chains whose names are hardcoded. A shell function 'collect_chains' is introduced that is given the name of an ebtables chain and then recursively

[libvirt] [PATCH V6 03/11] Make filter creation in root table more flexible

2011-11-18 Thread Stefan Berger
Use the previously introduced chain priorities to sort the chains for access from an interface's 'root' table and have them created in the proper order. This gets rid of a lot of code that was previously creating the chains in a more hardcoded way. To determine what protocol a filter is used for

[libvirt] [PATCH V6 01/11] Add function to get hash tables key/value pairs

2011-11-18 Thread Stefan Berger
Add a function to the virHashTable for getting an array of the hash table's key-value pairs and have the keys (optionally) sorted. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- v5: - follwed Eric Blake's suggestions: - added better description to new function - return array

[libvirt] [PATCH V6 06/11] Extend the filter XML to support priorities of chains

2011-11-18 Thread Stefan Berger
This patch extends the filter XML to support priorities of chains in the XML. An example would be: filter name='allow-arpxyz' chain='arp-xyz' priority='200' [...] /filter The permitted values for priorities are [-1000, 1000]. By setting the priority of a chain the order in which it is accessed

[libvirt] [PATCH V6 11/11] Documentation about chains priorities, lists of elements etc.

2011-11-18 Thread Stefan Berger
This patch adds several aspects of documentation about the network filtering system: - chains, chains' priorities and chains' default priorities - talks about lists of elements, i.e., a variable assigned multiple values (part of already ACK-ed series) - already mentions the vlan, stp and mac

[libvirt] [PATCH V6 08/11] Extend rule priorities into negative numbers

2011-11-18 Thread Stefan Berger
So far rules' priorities have only been valid in the range [0,1000]. Now I am extending their priority into the range [-1000, 1000] for subsequently being able to sort rules and the access of (jumps into) chains following priorities. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

[libvirt] [PATCH V6 05/11] Use the actual names of chains in data structure

2011-11-18 Thread Stefan Berger
Use the name of the chain rather than its type index (enum). This pushes the later enablement of chains with user-given names into the XML parser. For now we still only allow those names that are well known ('root', 'arp', 'rarp', 'ipv4' and 'ipv6'). Signed-off-by: Stefan Berger

[libvirt] Bug 754974 - connection with xen+ssh vm's are missing with list (virsh)

2011-11-18 Thread Robin van Leeuwen
Hi I posted the above mentioned bug to Bugzilla and one reply said to mention it on libvir-list@redhat.com as well. So here it is: https://bugzilla.redhat.com/show_bug.cgi?id=754974 Is mentioning it in this list too, (when it involves libvirt offcourse) after filing a bug on Bugzilla, the

Re: [libvirt] [PATCH V5 01.5/10] tests: test recent hash addition

2011-11-18 Thread Stefan Berger
On 11/17/2011 05:07 PM, Eric Blake wrote: Excercise the new hash API, to ensure we avoid regressions. * tests/hashtest.c (testHashGetItems): New test. --- I'd still feel a bit better if we had coverage for the new function in tests/hashtest.c, but I'll let that slide to another patch; On

Re: [libvirt] [PATCH 12/16] Rename ifaceCheck to virNetDevValidateConfig

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 07:01:52AM -0500, Laine Stump wrote: On 11/15/2011 06:14 AM, Daniel P. Berrange wrote: Rename the ifaceCheck method to virNetDevValidateConfig and change so that it always raises an error and returns -1 on error. * src/util/interface.c, src/util/interface.h: Rename

Re: [libvirt] [PATCH 08/16] Rename ifaceGetIndex and ifaceGetVLAN

2011-11-18 Thread Daniel P. Berrange
On Thu, Nov 17, 2011 at 06:55:34AM -0500, Laine Stump wrote: On 11/15/2011 06:14 AM, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Rename the ifaceGetIndex method to virNetDevGetIndex and ifaceGetVlanID to virNetDevGetVLanID. Also change the error reporting behaviour

Re: [libvirt] [PATCH V6 04/11] Use scripting for cleaning and renaming of chains

2011-11-18 Thread Eric Blake
On 11/18/2011 06:32 AM, Stefan Berger wrote: Use scripts for the renaming and cleaning up of chains. This allows us to get rid of some of the code that is only capable of renaming and removing chains whose names are hardcoded. +static const char ebtables_script_func_collect_chains[] = +

Re: [libvirt] [PATCH V6 07/11] Enable chains with names having a known prefix

2011-11-18 Thread Eric Blake
On 11/18/2011 06:32 AM, Stefan Berger wrote: This patch enables chains that have a known prefix in their name. Known prefixes are: 'ipv4', 'ipv6', 'arp', 'rarp'. All prefixes are also protocols that can be evaluated on the ebtables level. + +if (chainname[strspn(chainname,

Re: [libvirt] [PATCH V6 11/11] Documentation about chains priorities, lists of elements etc.

2011-11-18 Thread Eric Blake
On 11/18/2011 06:32 AM, Stefan Berger wrote: This patch adds several aspects of documentation about the network filtering system: - chains, chains' priorities and chains' default priorities - talks about lists of elements, i.e., a variable assigned multiple values (part of already ACK-ed

Re: [libvirt] [PATCH V6 00/11] Make inner workings of nwfilters more flexible + extensions

2011-11-18 Thread Eric Blake
On 11/18/2011 06:32 AM, Stefan Berger wrote: The following series of patches re-does some of the inner workings of nwfilters with the goal to enable users to write filters that have other than the system-known chains supported right now ('root','arp','rarp','ipv4' and 'ipv6'). Ideally users

Re: [libvirt] [PATCH V6 07/11] Enable chains with names having a known prefix

2011-11-18 Thread Stefan Berger
On 11/18/2011 11:01 AM, Eric Blake wrote: On 11/18/2011 06:32 AM, Stefan Berger wrote: This patch enables chains that have a known prefix in their name. Known prefixes are: 'ipv4', 'ipv6', 'arp', 'rarp'. All prefixes are also protocols that can be evaluated on the ebtables level. + +if

Re: [libvirt] [PATCH V6 04/11] Use scripting for cleaning and renaming of chains

2011-11-18 Thread Stefan Berger
On 11/18/2011 11:01 AM, Eric Blake wrote: On 11/18/2011 06:32 AM, Stefan Berger wrote: Use scripts for the renaming and cleaning up of chains. This allows us to get rid of some of the code that is only capable of renaming and removing chains whose names are hardcoded. +static const char

Re: [libvirt] [PATCH V6 11/11] Documentation about chains priorities, lists of elements etc.

2011-11-18 Thread Stefan Berger
On 11/18/2011 11:01 AM, Eric Blake wrote: On 11/18/2011 06:32 AM, Stefan Berger wrote: This patch adds several aspects of documentation about the network filtering system: - chains, chains' priorities and chains' default priorities - talks about lists of elements, i.e., a variable assigned

Re: [libvirt] [PATCH V6 00/11] Make inner workings of nwfilters more flexible + extensions

2011-11-18 Thread Stefan Berger
On 11/18/2011 11:02 AM, Eric Blake wrote: On 11/18/2011 06:32 AM, Stefan Berger wrote: The following series of patches re-does some of the inner workings of nwfilters with the goal to enable users to write filters that have other than the system-known chains supported right now

Re: [libvirt] [PATCH V5 4/4] Add test cases for parsing of list values

2011-11-18 Thread Stefan Berger
On 11/02/2011 07:21 PM, Eric Blake wrote: On 10/31/2011 07:01 AM, Stefan Berger wrote: This patch adds test cases for parsing of parameters with multiple occurrances of the same name. s/occurrances/occurrences/ +++ libvirt-acl/tests/nwfilterxml2xmlin/attr-value-test.xml @@ -0,0 +1,27 @@

Re: [libvirt] virt-viewer, requirement question

2011-11-18 Thread Jason Helfman
On Fri, Nov 18, 2011 at 10:03:05AM +, Daniel P. Berrange thus spake: On Thu, Nov 17, 2011 at 05:24:15PM -0800, Jason Helfman wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I am the port maintainer for libvirt, and associated tools, in the FreeBSD Project. I was wondering if

[libvirt] [PATCH] build: fix accidental POTFILES.in regression

2011-11-18 Thread Eric Blake
The original patch for commit 4789fb2 considered renaming a file, then backed out the name change, but forgot to back out the POTFILES.in change, resulting in 'make syntax-check' failure. --- Pushing under the build-breaker rule. po/POTFILES.in |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH V5 01.5/10] tests: test recent hash addition

2011-11-18 Thread Eric Blake
On 11/18/2011 08:17 AM, Stefan Berger wrote: On 11/17/2011 05:07 PM, Eric Blake wrote: Excercise the new hash API, to ensure we avoid regressions. * tests/hashtest.c (testHashGetItems): New test. --- ACK Thanks; pushed. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [libvirt] [PATCHv2 01/11] don't modify CPU set string in virDomainCpuSetParse

2011-11-18 Thread Eric Blake
On 11/18/2011 03:35 AM, Daniel P. Berrange wrote: On Thu, Nov 17, 2011 at 05:44:11PM +0800, Hu Tao wrote: As the function only parses the CPU set string, there is no good reason to modify it. --- src/conf/domain_conf.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[libvirt] [osinfo PATCH 2/8] Add openSUSE data

2011-11-18 Thread Christophe Fergeau
--- data/oses/Makefile.am |1 + data/oses/opensuse.xml | 35 +++ 2 files changed, 36 insertions(+), 0 deletions(-) create mode 100644 data/oses/opensuse.xml diff --git a/data/oses/Makefile.am b/data/oses/Makefile.am index 2ee9cee..30168d5 100644 ---

[libvirt] [osinfo PATCH 1/8] Add #include string.h for strcmp

2011-11-18 Thread Christophe Fergeau
--- tools/osinfo-detect.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c index 6afa30a..be36afb 100644 --- a/tools/osinfo-detect.c +++ b/tools/osinfo-detect.c @@ -23,6 +23,7 @@ */ #include osinfo/osinfo.h +#include

[libvirt] [osinfo PATCH 4/8] Fix volume-id for RHEL 5.x

2011-11-18 Thread Christophe Fergeau
The VolumeID for RHEL 5.x was RHEL/5.x, it was changed to RHEL_6.x for RHEL6. I checked this with ISOs straight from RHN. --- data/oses/rhel.xml | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/data/oses/rhel.xml b/data/oses/rhel.xml index c6eeaab..e6c9d1e

[libvirt] [osinfo PATCH 3/8] Fix version for RHEL 5.4

2011-11-18 Thread Christophe Fergeau
There was a typo. --- data/oses/rhel.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/data/oses/rhel.xml b/data/oses/rhel.xml index 6ad634d..c6eeaab 100644 --- a/data/oses/rhel.xml +++ b/data/oses/rhel.xml @@ -62,7 +62,7 @@ os id=http://redhat.com/rhel/5.4;

[libvirt] [osinfo PATCH 5/8] Fix volume-id for RHEL 4.x

2011-11-18 Thread Christophe Fergeau
The VolumeID for RHEL 4.x was RHEL/4-Ux, it was changed to RHEL_6.x for RHEL6. I checked this with ISOs straight from RHN. --- data/oses/rhel.xml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/oses/rhel.xml b/data/oses/rhel.xml index e6c9d1e..ac6149b 100644 ---

[libvirt] [osinfo PATCH 6/8] Add VolumeIDs for 2011 Ubuntu releases

2011-11-18 Thread Christophe Fergeau
Note that due to a bug in libosinfo, the detection of 11.10 won't work. The 11.10 isos don't have a system id nor a publisher id, so they end up as NULL in the parsed database, but they are a string of N consecutive space when read from the iso. This prevents the match from working. ---

[libvirt] [osinfo PATCH 8/8] Add VolumeIDs for CentOS

2011-11-18 Thread Christophe Fergeau
It doesn't seem to be possible to make the difference between a 32 or 64 bit CentOS iso just by looking at its headers so the iso type guessing will need to be improved --- data/oses/centos.xml | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git

[libvirt] [osinfo PATCH 7/8] Fix CentOS 6.1 entry

2011-11-18 Thread Christophe Fergeau
There were a few copy and paste typos --- data/oses/centos.xml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data/oses/centos.xml b/data/oses/centos.xml index 96c7442..9c2e647 100644 --- a/data/oses/centos.xml +++ b/data/oses/centos.xml @@ -9,14 +9,14 @@ clones

Re: [libvirt] [osinfo PATCH 1/8] Add #include string.h for strcmp

2011-11-18 Thread Eric Blake
[adding virt-tools-list] On 11/18/2011 11:04 AM, Christophe Fergeau wrote: --- tools/osinfo-detect.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/osinfo-detect.c b/tools/osinfo-detect.c index 6afa30a..be36afb 100644 --- a/tools/osinfo-detect.c +++

[libvirt] [PATCHv3] conf: don't modify cpu set string during parsing

2011-11-18 Thread Eric Blake
None of the callers cared if str was updated to point to the next byte after the parsed cpuset; simplifying this results in quite a few code simplifications. Additionally, virCPUDefParseXML was strdup()'ing a malloc()'d string; avoiding a memory copy resulted in less code. *

Re: [libvirt] [PATCHv2 02/11] enable cgroup cpuset by default

2011-11-18 Thread Eric Blake
On 11/18/2011 03:34 AM, Daniel P. Berrange wrote: On Thu, Nov 17, 2011 at 05:44:12PM +0800, Hu Tao wrote: This prepares for subsequent patches which introduce dependence on cgroup cpuset. Enable cgroup cpuset by default so users don't have to modify configuration file before encountering a

Re: [libvirt] [PATCH] storage: Skips backingStore of virtual snapshot lv

2011-11-18 Thread Eric Blake
On 11/18/2011 04:15 AM, Osier Yang wrote: lvs outputs [$lvname_vorigin] for the virtual snapshot lv (created with --virtualsize), and the original device pointed by $lvname_vorigin is just for lvm internal use, one should never use it. Per lvm's nameing rules, [ is not valid as part of the

[libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-18 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-connection.c | 37 ++ libvirt-gobject/libvirt-gobject-connection.h |4 +++ libvirt-gobject/libvirt-gobject.sym |1 + 3 files changed, 42 insertions(+), 0 deletions(-)

Re: [libvirt] virt-viewer, requirement question

2011-11-18 Thread Jason Helfman
On Fri, Nov 18, 2011 at 09:37:11AM -0800, Jason Helfman thus spake: On Fri, Nov 18, 2011 at 10:03:05AM +, Daniel P. Berrange thus spake: On Thu, Nov 17, 2011 at 05:24:15PM -0800, Jason Helfman wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I am the port maintainer for

[libvirt] [PATCH] tests: avoid xend ABRT crash report

2011-11-18 Thread Eric Blake
I installed the xen development packages on my non-Xen F16 machine in order to compile-test xen code and ensure we don't break things on that front, but being a non-xen machine, /usr/sbin/xend is obviously not running. Unfortunately, xen-4.1.2-1.fc16 has a bug where merely trying to probe xend

[libvirt] [PATCH] build: fix compile error with no macvtap

2011-11-18 Thread Eric Blake
Since commit 6ec8288a, compilation has failed on RHEL 5: util/virnetdevmacvlan.c:672: error: conflicting types for 'virNetDevMacVLanCreateWithVPortProfile' * src/util/virnetdevmacvlan.c (virNetDevMacVLanCreateWithVPortProfile): Add missing parameter. --- (That function name is a mouthful!)

[libvirt] [PATCH] Don't copy sexpr node value that is an empty string

2011-11-18 Thread Jim Fehlig
Xen4.1 initializes some unspecified sexpr config items to an empty string, unlike previous Xen versions that would leave the item unset. E.g. the kernel item for an HVM guest (non-direct kernel boot): Xen4.0 and earlier ... (image (hvm (kernel ) ... Xen4.1 ... (image (hvm

Re: [libvirt] [PATCH] Don't copy sexpr node value that is an empty string

2011-11-18 Thread Eric Blake
On 11/18/2011 03:16 PM, Jim Fehlig wrote: Xen4.1 initializes some unspecified sexpr config items to an empty string, unlike previous Xen versions that would leave the item unset. E.g. the kernel item for an HVM guest (non-direct kernel boot): Xen4.0 and earlier ... (image (hvm

Re: [libvirt] make rpm failing with git head on RHEL6

2011-11-18 Thread Eric Blake
On 11/09/2011 05:12 AM, Justin Clift wrote: On another note, Eric, do you reckon it's possible to add the XHTML1 DTDs to maintainer requirements? Without them, generation of the html docs fails at the validation stage. Good idea, but I'm not quite sure how, yet. Requiring xmllint is

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-18 Thread Christophe Fergeau
Hey, Reading this patch, I'm wondering if gvir_domain_set_config might achieve what you are after (it's not implemented either) On Fri, Nov 18, 2011 at 09:24:32PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---

Re: [libvirt] [PATCH] Don't copy sexpr node value that is an empty string

2011-11-18 Thread Jim Fehlig
Eric Blake wrote: On 11/18/2011 03:16 PM, Jim Fehlig wrote: Xen4.1 initializes some unspecified sexpr config items to an empty string, unlike previous Xen versions that would leave the item unset. E.g. the kernel item for an HVM guest (non-direct kernel boot): Xen4.0 and earlier ...

Re: [libvirt] [osinfo PATCH 1/8] Add #include string.h for strcmp

2011-11-18 Thread Christophe Fergeau
On Fri, Nov 18, 2011 at 11:26:21AM -0700, Eric Blake wrote: I've typically seen libosinfo patches sent to virt-tools-l...@redhat.com. However, I just glanced through README in libosinfo.git and didn't see any mention of the preferred address for patch submission, nor mention of a project web

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-18 Thread Zeeshan Ali (Khattak)
On Sat, Nov 19, 2011 at 12:56 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, Reading this patch, I'm wondering if gvir_domain_set_config might achieve what you are after (it's not implemented either) Yeah, that might actually be better. +    GVirConnectionPrivate *priv =

Re: [libvirt] [libvirt-glib] Add API to redefine an existing domain

2011-11-18 Thread Christophe Fergeau
On Sat, Nov 19, 2011 at 01:02:28AM +0200, Zeeshan Ali (Khattak) wrote: On Sat, Nov 19, 2011 at 12:56 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, Reading this patch, I'm wondering if gvir_domain_set_config might achieve what you are after (it's not implemented either)

Re: [libvirt] virt-viewer, requirement question

2011-11-18 Thread Jason Helfman
I see that this was moved to vncconnection.h, however I don't see this patch in there. Is this patch still relevant to the code? http://osdir.com/ml/gtk-vnc-list/2009-11/msg00029.html Thanks, Jason This has already been fixed by FreeBSD Gnome team, and will be updated when 9 comes out. -jgh

Re: [libvirt] [PATCH V1 2/9] Add test cases for VLAN traffic filtering

2011-11-18 Thread Eric Blake
On 10/26/2011 09:11 AM, Stefan Berger wrote: This patch adds a few test cases for the XML parsing of VLAN filtering nodes. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- tests/nwfilterxml2xmlin/vlan-test.xml | 45 +

Re: [libvirt] [PATCH V1 3/9] Add documentation for VLAN filtering support

2011-11-18 Thread Eric Blake
On 10/26/2011 09:12 AM, Stefan Berger wrote: Add documentation for the VLAN filtering support. Describe the XML attributes that are supported. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Not sure if this overlaps with any of the stuff you pulled in earlier (it will be Monday

[libvirt] [PATCH] build: require more tools from maintainers

2011-11-18 Thread Eric Blake
We want our tarballs to be complete - this means that any generated file that gets shipped as part of the tarball so that ordinary users don't have to rebuild it must be something that the maintainer can generate. There have been various reports of random build failures when using libvirt.git

Re: [libvirt] [PATCH] build: require more tools from maintainers

2011-11-18 Thread Eric Blake
On 11/18/2011 05:18 PM, Eric Blake wrote: We want our tarballs to be complete - this means that any generated file that gets shipped as part of the tarball so that ordinary users don't have to rebuild it must be something that the maintainer can generate. There have been various reports of

Re: [libvirt] [PATCHv3] conf: don't modify cpu set string during parsing

2011-11-18 Thread Bharata B Rao
On Fri, Nov 18, 2011 at 11:31:12AM -0700, Eric Blake wrote: None of the callers cared if str was updated to point to the next byte after the parsed cpuset; simplifying this results in quite a few code simplifications. Additionally, virCPUDefParseXML was strdup()'ing a malloc()'d string;