Re: [libvirt] [PATCH v5] Implement DNS SRV record into the bridge driver

2012-01-02 Thread Peter Krempa
On 12/07/2011 11:58 AM, Michal Novotny wrote: Hi, this is the fifth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax is based on DNSMasq man page and tests for both

Re: [libvirt] [PATCH 1/2] Set default fs driver when not provided in input xml

2012-01-02 Thread Deepak C Shetty
Now that I think again, I am not sure if the below is really needed ? driver... being an optional sub-element, it should be ok for it not to be present in the returned XML, which means the consumer should make appropriate checks and handle the presence/absence of driver accordingly I

Re: [libvirt] [PATCH v5] Implement DNS SRV record into the bridge driver

2012-01-02 Thread Michal Novotny
On 01/02/2012 12:39 PM, Peter Krempa wrote: On 12/07/2011 11:58 AM, Michal Novotny wrote: Hi, this is the fifth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax

Re: [libvirt] [libvirt-glib] API to set SPICE password

2012-01-02 Thread Christophe Fergeau
ACK On Wed, Dec 28, 2011 at 09:38:19PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- .../libvirt-gconfig-domain-graphics-spice.c| 10 ++ .../libvirt-gconfig-domain-graphics-spice.h|3 +++

Re: [libvirt] [libvirt-glib] API to set SPICE password

2012-01-02 Thread Christophe Fergeau
Actually, if it's not too late, can you squash the change mentioned below in: On Mon, Jan 02, 2012 at 05:51:29PM +0400, Christophe Fergeau wrote: ACK On Wed, Dec 28, 2011 at 09:38:19PM +0200, Zeeshan Ali (Khattak) wrote: diff --git a/libvirt-gconfig/libvirt-gconfig.sym

[libvirt] [libvirt-glib] Add gvir_config_domain_graphics_vnc_set_password

2012-01-02 Thread Christophe Fergeau
Based on the similar patch for SPICE --- .../libvirt-gconfig-domain-graphics-vnc.c | 10 ++ .../libvirt-gconfig-domain-graphics-vnc.h |3 +++ libvirt-gconfig/libvirt-gconfig.sym|1 + 3 files changed, 14 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH v5] Implement DNS SRV record into the bridge driver

2012-01-02 Thread Michal Novotny
Hi, this is the fifth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax is based on DNSMasq man page and tests for both xml2xml and xml2argv were added as well. There

Re: [libvirt] [libvirt-glib] Add gvir_config_domain_graphics_vnc_set_password

2012-01-02 Thread Zeeshan Ali (Khattak)
On Mon, Jan 2, 2012 at 4:00 PM, Christophe Fergeau cferg...@redhat.com wrote: Based on the similar patch for SPICE ACK. :) -- Regards, Zeeshan Ali (Khattak) FSF member#5124 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/2] qemu: add new disk type='lun' for bus='virtio'

2012-01-02 Thread Eric Blake
On 12/22/2011 11:39 AM, Laine Stump wrote: These two patches are in response to CVE-2011-4127: http://seclists.org/oss-sec/2011/q4/536 Once the kernel security fix and corresponding qemu mitigation patch are in place, access to SG_IO commands from qemu guests will be disabled by

Re: [libvirt] [PATCH 0/2] qemu: add new disk type='lun' for bus='virtio'

2012-01-02 Thread Eric Blake
On 12/23/2011 01:42 AM, Paolo Bonzini wrote: On 12/23/2011 12:15 AM, Daniel P. Berrange wrote: The 'type' attribute refers to how the host emulator deals with the disk. The 'device' attribute refers to what type of device hardware is exposed to the guest. What we're doing here is

Re: [libvirt] [PATCH 1/2] qemu: add capabilities flags related to SG_IO

2012-01-02 Thread Eric Blake
On 12/22/2011 11:39 AM, Laine Stump wrote: This patch adds two capabilities flags to deal with various aspects of supporting SG_IO commands on virtio-blk-pci devices: QEMU_CAPS_VIRTIO_BLK_SCSI set if -device virtio-blk-pci accepts the scsi=on|off option When present, this is on by

Re: [libvirt] [PATCH v5] Implement DNS SRV record into the bridge driver

2012-01-02 Thread Daniel Veillard
On Mon, Jan 02, 2012 at 03:23:54PM +0100, Michal Novotny wrote: Hi, this is the fifth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in the DNS. The syntax is based on DNSMasq man

Re: [libvirt] [PATCH v5] Implement DNS SRV record into the bridge driver

2012-01-02 Thread Michal Novotny
On 01/02/2012 04:21 PM, Daniel Veillard wrote: On Mon, Jan 02, 2012 at 03:23:54PM +0100, Michal Novotny wrote: Hi, this is the fifth version of my SRV record for DNSMasq patch rebased for the current codebase to the bridge driver and libvirt XML file to include support for the SRV records in

[libvirt] [PATCH] virsh: Fix checking for reconnect conditions

2012-01-02 Thread Peter Krempa
virshReportError() function frees the most recent error reported from libvirt. Condition that checks if connection to the daemon was broken during last command was then limited to check for SIGPIPE signal not taking into account possible errors signalized without SIGPIPE. This patch moves the

Re: [libvirt] [PATCH] virsh: Fix checking for reconnect conditions

2012-01-02 Thread Eric Blake
On 01/02/2012 09:15 AM, Peter Krempa wrote: virshReportError() function frees the most recent error reported from libvirt. Condition that checks if connection to the daemon was broken during last command was then limited to check for SIGPIPE signal not taking into account possible errors

Re: [libvirt] [PATCH 2/2] qemu: add new disk type='lun' for bus='virtio'

2012-01-02 Thread Eric Blake
On 12/22/2011 11:39 AM, Laine Stump wrote: As a result of CVE-2011-4127 (see: http://seclists.org/oss-sec/2011/q4/536), qemu (and the kernel) now disable all SG_IO commands on disks via qemu by default. To continue providing this capability to those who specifically ask for it (and hopefully

[libvirt] [PATCH] network_conf: Fix whitespace to pass syntax-check

2012-01-02 Thread Peter Krempa
--- Pushed under trivial rule. src/conf/network_conf.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h index 975d5e8..8920e18 100644 --- a/src/conf/network_conf.h +++ b/src/conf/network_conf.h @@ -24,7 +24,7 @@ #ifndef

Re: [libvirt] [PATCH] virsh: Fix checking for reconnect conditions

2012-01-02 Thread Peter Krempa
On 01/02/2012 05:47 PM, Eric Blake wrote: On 01/02/2012 09:15 AM, Peter Krempa wrote: virshReportError() function frees the most recent error reported from libvirt. Condition that checks if connection to the daemon was broken during last command was then limited to check for SIGPIPE signal not

Re: [libvirt] [PATCHv4 5/6] Add virDomain{S, G}etInterfaceParameters support to qemu driver

2012-01-02 Thread Eric Blake
On 12/31/2011 02:12 PM, Eric Blake wrote: On 12/29/2011 12:33 AM, Hu Tao wrote: * src/qemu/qemu_driver.c: implement the qemu driver support --- src/qemu/qemu_driver.c | 353 1 files changed, 353 insertions(+), 0 deletions(-) +if

[libvirt] [PATCH] domiftune: clean up previous patches

2012-01-02 Thread Eric Blake
Most severe here is a latent (but currently untriggered) memory leak if any hypervisor ever adds a string interface property; the remainder are mainly cosmetic. * include/libvirt/libvirt.h.in (VIR_DOMAIN_BANDWIDTH_*): Move macros closer to interface that uses them, and document type. *

[libvirt] [PATCH] qemu: one more client to live/config helper

2012-01-02 Thread Eric Blake
Commit ae523427 missed one pair of functions that could use the helper routine. * src/qemu/qemu_driver.c (qemuSetSchedulerParametersFlags) (qemuGetSchedulerParametersFlags): Simplify. --- src/qemu/qemu_driver.c | 73 +++ 1 files changed, 11

Re: [libvirt] [PATCH] qemu: one more client to live/config helper

2012-01-02 Thread Eric Blake
On 01/02/2012 04:37 PM, Eric Blake wrote: Commit ae523427 missed one pair of functions that could use the helper routine. Missed one in qemu, but I also found multiple sites to clean up in lxc_driver.c. I guess I'll submit those as a followup. * src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] domiftune: clean up previous patches

2012-01-02 Thread Hu Tao
On Mon, Jan 02, 2012 at 02:37:03PM -0700, Eric Blake wrote: Most severe here is a latent (but currently untriggered) memory leak if any hypervisor ever adds a string interface property; the remainder are mainly cosmetic. * include/libvirt/libvirt.h.in (VIR_DOMAIN_BANDWIDTH_*): Move macros

[libvirt] [PATCH] revert commit baade4cd2bf partly

2012-01-02 Thread Hu Tao
This is not a memory leak. See line 8029 and 8030 of qemu_driver.c. To ensure this, I tested twice following these steps: 1. set bandwidth lively (--live) 2. query bandwidth (--live) 3. set bandwidth lively (--live) The first time libvirtd crashed at step 2. The second time on step 2 I

[libvirt] [PATCH] qemu: fix block stat naming

2012-01-02 Thread Eric Blake
Typo has existed since API introduction in commit ee0d8c3. * src/qemu/qemu_driver.c (qemuDomainBlockStatsFlags): Use correct name. --- Pushing under the trivial rule. src/qemu/qemu_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] domiftune: clean up previous patches

2012-01-02 Thread Eric Blake
On 01/02/2012 07:46 PM, Hu Tao wrote: On Mon, Jan 02, 2012 at 02:37:03PM -0700, Eric Blake wrote: Most severe here is a latent (but currently untriggered) memory leak if any hypervisor ever adds a string interface property; the remainder are mainly cosmetic. ACK. Thanks; pushed. -- Eric