This patch introduces XML schema for capability XML.
process and cap element are added.
The list of cap elements represents process capabilities host supports.
capabilities
host
...
process
cap name='chown'/
cap name='dac_override'/
...
/process
/host
...
This patch extends virExecWithHook() to receive
capability information.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp
---
src/util/command.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
Index:
This patch revises qemuProcessStart() function for qemu
processes to retain arbitrary capabilities.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
Signed-off-by: Shota Hirae m11g1...@hibikino.ne.jp
---
src/qemu/qemu_process.c |1 +
1 file changed, 1 insertion(+)
Index:
This patch introduces virKeepCapabilities() function and implements
virCommandAllowCap() function.
Existing virClearCapabilities() is function to clear all capabilities.
Instead virKeepCapabilities() is function to keep arbitrary capabilities.
Signed-off-by: Taku Izumi
On 12.01.2012 01:46, Eric Blake wrote:
Detected by Coverity. Although unlikely, if we are ever started
with stdin closed, we could reach a situation where we open a
uuid file but then fail to close it, making that file the new
stdin for the rest of the process.
* src/util/uuid.c
If client stream does not have any data to sink and neither received
EOF, a dummy packet is sent to the daemon signalising client is ready to
sink some data. However, after we added event loop to client a race may
occur:
Thread 1 calls virNetClientStreamRecvPacket and since no data are cached
nor
The new introduced optional attribute copy_on_read/code controls
wether to copy read backing file into the image file. The value can
be either on or off. Copy-on-read avoids accessing the same backing
file sectors repeatedly and is useful when the backing file is over a
slow network. By default
On 2012年01月12日 01:20, Eric Blake wrote:
On 01/11/2012 05:45 AM, Osier Yang wrote:
Just like command domblklist, the command extracts type,
source, target, model, and MAC of all virtual interfaces
from domain XML (live or persistent).
---
tools/virsh.c | 98
Earlier, when the number of vcpus was greater than the topology allowed,
libvirt didn't raise an error and continued, resulting in running qemu
with parameters making no sense. Even though qemu did not report any
error itself, the number of vcpus was set to maximum allowed by the
topology.
---
v2:
On Thu, Jan 12, 2012 at 09:54:15AM +0100, Michal Privoznik wrote:
If client stream does not have any data to sink and neither received
EOF, a dummy packet is sent to the daemon signalising client is ready to
sink some data. However, after we added event loop to client a race may
occur:
Disk type and device are generally interesting stuffs the
user who wants to known too. To not breaking the scripts which
parses the output field, new options --details is introduced
to output the two introduced fields.
---
tools/virsh.c | 32 +---
tools/virsh.pod |
On Wed, Jan 11, 2012 at 05:21:12PM -0700, Eric Blake wrote:
Pick up recent gnulib improvements.
* .gnulib: Update to latest.
* bootstrap: Resync.
* bootstrap.conf (gnulib_tool_option_extras): Adjust to bootstrap
changes.
* gnulib/lib/Makefile.am: Likewise.
---
I'm not sure that we are
On 2012年01月12日 01:37, Eric Blake wrote:
On 01/11/2012 10:25 AM, Laine Stump wrote:
On 01/11/2012 08:39 AM, Osier Yang wrote:
We supportinterface of type mcast, server, and client,
but the RNG schema for them are missed.
Right you are! ACK. (A test case with one of each in the xml2argv test
Eric,
Many Thanks for your comments and for pushing the patches through.
I understand the review comments you and Daniel posted on my patch series and
was going to work on them today.
I saw your modified patches and wanted to thank you for your contribution
towards the patch series and for
On 01/10/2012 11:23 AM, Daniel P. Berrange wrote:
On Wed, Dec 14, 2011 at 10:47:23AM +, Shradha Shah wrote:
Interface Pools and Passthrough mode:
Current Method:
The passthrough mode uses a macvtap direct connection to connect each
guest to the network. The physical interface to be used
VIR_DOMAIN_XML_UPDATE_CPU flag for virDomainGetXMLDesc may be used to
get updated custom mode guest CPU definition in case it depends on host
CPU. This patch implements the same behavior for host-model and
host-passtrhough CPU modes.
---
Notes:
Version 2:
- more verbose commit message
It's not totally obvious that a failure in
CPU guest data(x86): host/guest (models, pref=qemu64)
test means one needs to fix
x86-host+guest,models,qemu64-result.xml
where the expected XML is stored. Better to provide a nice hint in
verbose mode for failed tests.
---
Notes:
Version
There are several reasons for doing this:
- the CPU specification is out of libvirt's control so we cannot
guarantee stable guest ABI
- not every feature of a CPU may actually work as expected when
advertised directly to a guest
- migration between two machines with exactly the same CPU may
The main goal of this series is to provide an easy way to say that a guest CPU
should match host. Details can be found in individual patches.
Jiri Denemark (6):
tests: Print XML file name in verbose CPU test
cpu: Optionally forbid fallback CPU models
Add support for cpu mode attribute
In case a hypervisor doesn't support the exact CPU model requested by a
domain XML, we automatically fallback to a closest CPU model the
hypervisor supports (and make sure we add/remove any additional features
if needed). This patch adds 'fallback' attribute to model element, which
can be used to
The mode can be either of custom (default), host-model,
host-passthrough. The semantics of each mode is described in the
following examples:
- guest CPU is a default model with specified topology:
cpu
topology sockets='1' cores='2' threads='1'/
/cpu
- guest CPU matches selected
This adds support for host-model and host-passthrough CPU modes to qemu
driver. The host-passthrough mode is mapped to -cpu host.
---
Notes:
Version 2:
- more verbose commit messages
- portability fixes in shell scripts
src/libvirt_private.syms |1 +
On 12.01.2012 11:13, Daniel P. Berrange wrote:
On Thu, Jan 12, 2012 at 09:54:15AM +0100, Michal Privoznik wrote:
If client stream does not have any data to sink and neither received
EOF, a dummy packet is sent to the daemon signalising client is ready to
sink some data. However, after we added
From: Daniel P. Berrange berra...@redhat.com
Domain IDs are at least 16 bits for most hypervisors, theoretically
event 32-bits. 3 characters is clearly too small an alignment.
Increase alignment to 5 characters to allow 16-bit domain IDs to
display cleanly. Commonly seen with LXC where domain
On 01/12/2012 12:49 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Domain IDs are at least 16 bits for most hypervisors, theoretically
event 32-bits. 3 characters is clearly too small an alignment.
Increase alignment to 5 characters to allow 16-bit domain IDs to
On 01/12/2012 12:49 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Domain IDs are at least 16 bits for most hypervisors, theoretically
event 32-bits. 3 characters is clearly too small an alignment.
Increase alignment to 5 characters to allow 16-bit domain IDs to
From: Daniel P. Berrange berra...@redhat.com
Domain IDs are at least 16 bits for most hypervisors, theoretically
event 32-bits. 3 characters is clearly too small an alignment.
Increase alignment to 10 characters to allow 32-bit domain IDs to
display cleanly. Commonly seen with LXC where domain
Hi.
Attached is the RFC version of patch (against old version of libvirt)
which compiles out support for SSL encryption on libvirt connections.
It is meant only to provoke a discussion whether such option is deemed
acceptable to libvirt, or it would be a complete waste of time to rebase
On 01/12/2012 01:19 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Domain IDs are at least 16 bits for most hypervisors, theoretically
event 32-bits. 3 characters is clearly too small an alignment.
Increase alignment to 10 characters to allow 32-bit domain IDs to
On Thu, Jan 12, 2012 at 01:43:29PM +0100, Mikhail Gusarov wrote:
Hi.
Attached is the RFC version of patch (against old version of
libvirt) which compiles out support for SSL encryption on libvirt
connections.
It is meant only to provoke a discussion whether such option is
deemed
These set bridge part of QoS when bringing domain's interface up.
---
po/POTFILES.in|1 +
src/util/virnetdevbandwidth.c | 177 +
src/util/virnetdevbandwidth.h | 14 +++
3 files changed, 192 insertions(+), 0 deletions(-)
diff --git
Network should be notified if we plug in or unplug an
interface, so it can perform some action, e.g. set/unset
network part of QoS.
---
src/conf/domain_conf.h |1 +
src/conf/network_conf.c |1 +
src/conf/network_conf.h |2 +
src/libvirt_network.syms|2 +
These classes can borrow unused bandwidth. Basically,
only egress qdsics can have classes, therefore we can
do this kind of traffic shaping only on host's outgoing,
that is domain's incoming traffic.
---
src/lxc/lxc_driver.c |3 ++-
src/network/bridge_driver.c |4 +++-
This is however supported only on domain interfaces with
type='network'. Moreover, target network needs to have at least
inbound QoS set. This is required by hierarchical traffic shaping.
---
docs/formatdomain.html.in| 21 --
docs/schemas/networkcommon.rng |5 ++
Since 0.9.4 release libvirt supports setting some QoS attributes on virtual
bridges and/or virtual interfaces. Average and peak rate, namely. It lacks
minimal guaranteed bandwidth aka 'floor' attribute, though. This patch set
tries to fill that hole. However, there are some things you want to know
Like we keep domain status file to keep some internal data
during daemon restart, now it is needed for network as well.
Because network has now class_id attribute which is hidden
from users and thus not part of network XML.
---
daemon/libvirtd.c |3 +
src/conf/network_conf.c |
Interfaces keeps a class_id, which is an ID from which bridge
part of QoS settings is derived. We need to store class_id
in domain status file, so we can later pass it to
virNetDevBandwidthUnplug.
---
src/conf/domain_conf.c |4 +-
src/qemu/qemu_domain.c | 66
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
A predicate to check if domain is persistent or not.
---
libvirt-gobject/libvirt-gobject-domain.c | 13 +
libvirt-gobject/libvirt-gobject-domain.h |1 +
libvirt-gobject/libvirt-gobject.sym |1 +
3 files changed, 15
On 01/12/2012 03:49 AM, Eric Blake wrote:
I'm still trying to understand the qemu semantics: your choices are an
explicit writeout=immediate (with explicit requests to the host) or
nothing (host writes may be delayed). So, you are saying the a missing
attribute lets qemu choose, and an explicit
I'm not sure whether this mail missed you, because I haven't
received any reply, so I re-send this mail again, I expect
your reply.
Thanks in advance,
Alex
- Original Message -
From: Alex Jia a...@redhat.com
To: libvir libvir-list@redhat.com
Sent: Thursday, January 5, 2012 1:24:34 PM
On Thu, Jan 12, 2012 at 08:20:02AM -0700, Eric Blake wrote:
On 01/12/2012 05:49 AM, Peter Krempa wrote:
On 01/12/2012 01:19 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Domain IDs are at least 16 bits for most hypervisors, theoretically
event 32-bits. 3
On 01/12/2012 05:49 AM, Peter Krempa wrote:
On 01/12/2012 01:19 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrangeberra...@redhat.com
Domain IDs are at least 16 bits for most hypervisors, theoretically
event 32-bits. 3 characters is clearly too small an alignment.
Increase alignment to
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add a predicate and property to check if domain is persistent or not.
---
libvirt-gobject/libvirt-gobject-domain.c | 29 +
libvirt-gobject/libvirt-gobject-domain.h |1 +
libvirt-gobject/libvirt-gobject.sym |
On Thu, Jan 12, 2012 at 4:52 PM, Zeeshan Ali (Khattak)
zeesha...@gnome.org wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
A predicate to check if domain is persistent or not.
Ignore this one please, already sent a revised version of this with
a property as well.
--
Regards,
On Thu, Jan 12, 2012 at 05:29:31PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add a predicate and property to check if domain is persistent or not.
---
libvirt-gobject/libvirt-gobject-domain.c | 29 +
On Thu, Jan 12, 2012 at 05:29:31PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
Add a predicate and property to check if domain is persistent or not.
---
libvirt-gobject/libvirt-gobject-domain.c | 29 +
From: Daniel P. Berrange berra...@redhat.com
Currently the LXC controller attempts to deal with EOF on a
tty by spawning a thread todo a edge triggered epoll_wait().
This avoids the normal event loop spinning on POLLHUP. There
is a subtle mistake though - even after seeing POLLHUP on a
master
One of my latest patches (d8db0f9690) created support for setting
the limit for the maximum of opened files by qemu user. However,
since libvirtd keeps one FD opened per domain (well, for qemu at least)
it will likely hit this limit on huge scenarios.
---
daemon/libvirtd.init.in|7 +++
Overall status: failed
Start date: Thu Jan 12 2012
Start time: 18:05:01 UTC / 13:05:01 EST
Build counter: 1326391501
Build timestamp: 1326391501
URL: http://builder.virt-tools.org/index.html
Module: libvirt
Status: failed
URL: http://builder.virt-tools.org/module-libvirt.html
--
libvir-list
Daniel, Eric
On Jan 5, 2012, at 6:35 PM, Daniel P. Berrange wrote:
Thank you very much for the introduction, I've spent the
week digging through the code and have a way better
understanding of the difference in the handling of events
now.
Any event loop callback must be sure to complete in
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-gconfig/libvirt-gconfig-domain-channel.c | 23 ++
libvirt-gconfig/libvirt-gconfig-domain-channel.h | 11 ++
libvirt-gconfig/libvirt-gconfig-domain-console.c | 12 +++
On Thu, Jan 12, 2012 at 07:07:22PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-gconfig/libvirt-gconfig-domain-channel.c | 23
++
libvirt-gconfig/libvirt-gconfig-domain-channel.h | 11 ++
On Thu, Jan 12, 2012 at 08:21:48PM +0100, Christophe Fergeau wrote:
On Thu, Jan 12, 2012 at 07:07:22PM +, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
---
libvirt-gconfig/libvirt-gconfig-domain-channel.c | 23
++
This eliminates the warning message reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=624447
It was caused by a failure to open an image file that is not
accessible by root (the uid libvirtd is running as) because it's on a
root-squash NFS share, owned by a different user, with
[Oops. This is a prerequisite of the previous patch that I forgot to
send. That patch should be 2/2 and this should be 1/2.]
This just simplifies use of virFileOpenAs a bit - if you're in a place
where you don't have access to a different uid|gid, just give -1.
---
src/libxl/libxl_driver.c
On 01/12/2012 10:20 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Currently the LXC controller attempts to deal with EOF on a
tty by spawning a thread todo a edge triggered epoll_wait().
s/todo a edge /to do an edge-/
This avoids the normal event loop spinning
On 01/12/2012 12:33 PM, Laine Stump wrote:
[Oops. This is a prerequisite of the previous patch that I forgot to
send. That patch should be 2/2 and this should be 1/2.]
This just simplifies use of virFileOpenAs a bit - if you're in a place
where you don't have access to a different uid|gid,
On Thu, Jan 12, 2012 at 12:56:23PM -0700, Eric Blake wrote:
On 01/12/2012 10:20 AM, Daniel P. Berrange wrote:
@@ -1103,9 +1163,32 @@ static int lxcControllerMain(int serverFd,
}
for (i = 0 ; i nFds ; i++) {
+consoles[i].epollFd = -1;
+consoles[i].epollFd =
On 01/12/2012 12:28 PM, Laine Stump wrote:
This eliminates the warning message reported in:
https://bugzilla.redhat.com/show_bug.cgi?id=624447
It was caused by a failure to open an image file that is not
accessible by root (the uid libvirtd is running as) because it's on a
root-squash
From: Daniel P. Berrange berra...@redhat.com
Pushing under trivial rule
---
src/util/keymaps.csv |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/util/keymaps.csv b/src/util/keymaps.csv
index c447f46..98c723b 100644
--- a/src/util/keymaps.csv
+++
On 01/12/2012 01:45 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Pushing under trivial rule
---
src/util/keymaps.csv |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Is this something we can automate at 'make dist' time?
--
Eric Blake
On Thu, Jan 12, 2012 at 02:06:13PM -0700, Eric Blake wrote:
On 01/12/2012 01:45 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Pushing under trivial rule
---
src/util/keymaps.csv |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Is this
On 01/12/2012 02:10 PM, Daniel P. Berrange wrote:
On Thu, Jan 12, 2012 at 02:06:13PM -0700, Eric Blake wrote:
On 01/12/2012 01:45 PM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Pushing under trivial rule
---
src/util/keymaps.csv |1 +
1 files changed, 1
I am pleased to announce that a new release of the libvirt-glib package,
version 0.0.4 is now available from
ftp://libvirt.org/libvirt/glib/
The packages are GPG signed with
Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R)
New in this release:
- Add support
Commit 69f0b446 failed to update the expected test output.
* tests/virshtest.c (testCompareListDefault)
(testCompareListCustom): Adjust to recent code change.
---
Pushing under the build-breaker rule.
tests/virshtest.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
On 01/12/2012 01:30 AM, Michal Privoznik wrote:
On 12.01.2012 01:46, Eric Blake wrote:
Detected by Coverity. Although unlikely, if we are ever started
with stdin closed, we could reach a situation where we open a
uuid file but then fail to close it, making that file the new
stdin for the
I pleased to announce the first public release of libvirt-sandbox,
version 0.0.2 is now available for download
ftp://libvirt.org/libvirt/sandbox/
The packages are GPG signed with
Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R)
The libvirt-sandbox package
On 01/12/2012 03:25 AM, Daniel P. Berrange wrote:
On Wed, Jan 11, 2012 at 05:21:12PM -0700, Eric Blake wrote:
Pick up recent gnulib improvements.
* .gnulib: Update to latest.
* bootstrap: Resync.
* bootstrap.conf (gnulib_tool_option_extras): Adjust to bootstrap
changes.
*
On 01/12/2012 03:53 AM, Osier Yang wrote:
Disk type and device are generally interesting stuffs the
s/stuffs/stuff/
user who wants to known too. To not breaking the scripts which
s/who wants to known too/may want to know, too/
s/breaking the/break any/
parses the output field, new options
On 01/12/2012 03:11 AM, Martin Kletzander wrote:
Earlier, when the number of vcpus was greater than the topology allowed,
libvirt didn't raise an error and continued, resulting in running qemu
with parameters making no sense. Even though qemu did not report any
error itself, the number of
Gnulib claims that there are some classes of warnings that are
worth enabling during development, but where silencing those
warnings causes code bloat that is not necessary in an optimized
build. The code bloat to silence the warnings is only enabled
by -Dlint. Follow the lead of coreutils in
On 01/12/2012 03:13 AM, Osier Yang wrote:
The new introduced optional attribute copy_on_read/code controls
wether to copy read backing file into the image file. The value can
s/wether/whether/
be either on or off. Copy-on-read avoids accessing the same backing
file sectors repeatedly and is
On 2012年01月13日 08:11, Eric Blake wrote:
On 01/12/2012 03:13 AM, Osier Yang wrote:
The new introduced optional attribute copy_on_read/code controls
wether to copy read backing file into the image file. The value can
s/wether/whether/
be either on or off. Copy-on-read avoids accessing the
The unit attribute of a drive address is optional in the code, so should
also be in the XML schema.
Signed-off-by: Michael Ellerman mich...@ellerman.id.au
---
docs/schemas/domaincommon.rng |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git
Add four tests of the XML - argv handling for the PPC64 pseries machine.
The first is just a basic test of a bare bones machine.
The three others test various aspects of the spapr-vio address handling.
It seems that currently we can't include network devices, doing so leads
to a segfault
We can't call qemuCapsExtractVersionInfo() from test code, because it
expects to be able to call the emulator, and for testing we have fake
emulators that can't be executed. For that reason qemuxml2argvtest.c
doesn't call qemuDomainAssignPCIAddresses(), instead it open codes its
own version.
That
There are three address validation routines that do nothing:
virDomainDeviceDriveAddressIsValid()
virDomainDeviceUSBAddressIsValid()
virDomainDeviceVirtioSerialAddressIsValid()
Remove them, and replace their call sites with 1 which is what they
currently return. In some cases this means we
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gobject/libvirt-gobject-connection.c | 28 +
libvirt-gobject/libvirt-gobject-domain-snapshot.c |4 +--
libvirt-gobject/libvirt-gobject-domain.c |8 +
Hi Daniel,
I'm trying libvirt-glib, however, I met some compilation warning
and error, for details, please see attachment.
Regards,
Alex
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p...
79 matches
Mail list logo
