Re: [libvirt] [PATCH] Xen: Fix clock handling

2012-01-18 Thread Philipp Hahn
Hello Daniel, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 17, 2012 at 05:02:14PM +0100, Philipp Hahn wrote: For PV, Xen implements the clock offset='utc' and clock offset='localtime' behaviour, while for HV it implements clock offset='variable'. This difference is important for

Re: [libvirt] [BUG] EPOLL_CLOEXEC undeclared

2012-01-18 Thread Philipp Hahn
Hello Eric, Eric Blake ebl...@redhat.com wrote: On 01/17/2012 04:42 AM, Philipp Hahn wrote: And what kernel is that system running? 2.6.32 We already refuse to compile lxc for RHEL 5 (kernel 2.6.18), as that particular kernel is too old to usefully support namespace and other operations

[libvirt] [PATCH] python: Expose virDomain{G, S}etInterfaceParameters' APIs in python binding

2012-01-18 Thread ajia
From: Alex Jia a...@redhat.com An simple example to show how to use it: #!/usr/bin/env python import libvirt conn = libvirt.open(None) dom = conn.lookupByName('foo') print dom.interfaceParameters('vnet0', 0) params = {'outbound.peak': 20, 'inbound.peak': 20,

Re: [libvirt] [libvirt-glib 1/3] API to get/set 'description' node in domain config

2012-01-18 Thread Daniel P. Berrange
On Wed, Jan 18, 2012 at 04:53:27AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain.c | 28 libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym

[libvirt] [PATCHv2] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-01-18 Thread ajia
From: Alex Jia a...@redhat.com Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % make -C tests check TESTS=networkxml2argvtest % cd tests valgrind -v --leak-check=full

Re: [libvirt] [libvirt-glib 1/3] API to get/set 'description' node in domain config

2012-01-18 Thread Christophe Fergeau
On Wed, Jan 18, 2012 at 04:53:27AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain.c | 28 libvirt-gconfig/libvirt-gconfig-domain.h |2 ++ libvirt-gconfig/libvirt-gconfig.sym

Re: [libvirt] [libvirt-glib 3/3] Correct return type of gvir_storage_pool_create_volume()

2012-01-18 Thread Christophe Fergeau
On Wed, Jan 18, 2012 at 04:53:29AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-storage-pool.c |6 +++--- libvirt-gobject/libvirt-gobject-storage-pool.h |4 ++-- 2 files changed, 5 insertions(+), 5

[libvirt] [libvirt-glib] Fix compilation with glib 2.22

2012-01-18 Thread Christophe Fergeau
This commit raises glib required version to 2.22 or newer, adds a few missing functions to libvirt-gobject-compat.h and includes it in the files using these functions. --- configure.ac|2 +- libvirt-gobject/Makefile.am |1 +

Re: [libvirt] [PATCH v2 0/6] Console coruption with two or more clients series

2012-01-18 Thread Peter Krempa
On 01/17/2012 10:47 PM, Daniel P. Berrange wrote: What is the status of these patches ? Do you have any v3 pending ? In the libvirt-sandbox project, we're finding that we need this console protection you've done, to stop virt-manager intefering with the sandboxes Now that the review on v2 is

Re: [libvirt] [libvirt-glib] Fix compilation with glib 2.22

2012-01-18 Thread Daniel P. Berrange
On Wed, Jan 18, 2012 at 12:14:46PM +0100, Christophe Fergeau wrote: This commit raises glib required version to 2.22 or newer, adds a few missing functions to libvirt-gobject-compat.h and includes it in the files using these functions. --- configure.ac|

Re: [libvirt] [libvirt-glib 3/3] Correct return type of gvir_storage_pool_create_volume()

2012-01-18 Thread Zeeshan Ali (Khattak)
On Wed, Jan 18, 2012 at 12:11 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jan 18, 2012 at 04:53:29AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---  libvirt-gobject/libvirt-gobject-storage-pool.c |    6 +++---  

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations

2012-01-18 Thread Peter Krempa
On 01/18/2012 12:38 AM, Eric Blake wrote: On 12/07/2011 11:08 AM, Peter Krempa wrote: This patch adds a set of functions used in creating console streams for domains using PTYs and ensures mutualy exculsive access to the PTYs. Picking up on my (stalled) review... +++ b/src/Makefile.am @@

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations

2012-01-18 Thread Daniel P. Berrange
On Wed, Jan 18, 2012 at 02:47:13PM +0100, Peter Krempa wrote: On 01/18/2012 12:38 AM, Eric Blake wrote: On 12/07/2011 11:08 AM, Peter Krempa wrote: This patch adds a set of functions used in creating console streams for domains using PTYs and ensures mutualy exculsive access to the PTYs.

[libvirt] Schedule for libvirt-0.9.10 release

2012-01-18 Thread Daniel Veillard
First I don't see any good reason to try to bump the major release number :-) so next release is expected to be 0.9.10, hope there isn't disapointment ;-) [1] Second I would really like to keep the monthly shedule, and have the release done by February 6 or earlier, so this would mean entering

Re: [libvirt] [libvirt-glib 3/3] Correct return type of gvir_storage_pool_create_volume()

2012-01-18 Thread Christophe Fergeau
On Wed, Jan 18, 2012 at 03:49:28PM +0200, Zeeshan Ali (Khattak) wrote: On Wed, Jan 18, 2012 at 12:11 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jan 18, 2012 at 04:53:29AM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org ---  

Re: [libvirt] [libvirt-glib 3/3] Correct return type of gvir_storage_pool_create_volume()

2012-01-18 Thread Zeeshan Ali (Khattak)
On Wed, Jan 18, 2012 at 4:07 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jan 18, 2012 at 03:49:28PM +0200, Zeeshan Ali (Khattak) wrote: On Wed, Jan 18, 2012 at 12:11 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jan 18, 2012 at 04:53:29AM +0200, Zeeshan Ali (Khattak)

[libvirt] [PATCH v2 4/8] virsh: Add support for modifying domain description and titles

2012-01-18 Thread Peter Krempa
This patch adds a new command desc to show and modify titles and description for the domains using the new API. This patch also adds a new flag for the list command to show titles in the domain list, to allow easy identification of VMs by storing a short description. Example: virsh # list

[libvirt] [PATCH v2 0/8] Add ability to store notes with domains

2012-01-18 Thread Peter Krempa
I've reworked this patches to use a separate element for storing the short note. This v2 also contains som new patches, especially added support for the LXC driver, and optionaly API to get the description. (See patches marked as optional). These are not required, just add a helper api to get the

[libvirt] [PATCH 7/8] lxc, qemu: Add support for virDomainGetDescription

2012-01-18 Thread Peter Krempa
This patch adds support for the newly added api for the LXC and qemu drivers. --- src/lxc/lxc_driver.c | 69 src/qemu/qemu_driver.c | 69 2 files changed, 138 insertions(+), 0 deletions(-)

[libvirt] [PATCH 5/8] lxc: implement description API in LXC driver.

2012-01-18 Thread Peter Krempa
This patch adds support for the new api to change domain descriptions to the lxc driver. --- src/lxc/lxc_driver.c | 70 ++ 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index

[libvirt] [PATCH v2 1/8] xml: Add element title to allow short description of domains

2012-01-18 Thread Peter Krempa
This patch adds a new element title to the domain XML. This attribute can hold a short title defined by the user to ease the identification of domains. The title is limited to 40 bytes and can't contain newlines. *docs/formatdomain.html.in *docs/schemas/domaincommon.rng - add schema

[libvirt] [PATCH v2 3/8] qemu: Implement note API in qemu driver

2012-01-18 Thread Peter Krempa
This patch adds support for the new api to change domain descriptions to the qemu driver. --- Diff to v1: - use consistent goto labels - simplified error path - add flush of config to disk after it's changed - fixed flag checking logic operators src/qemu/qemu_driver.c | 70

[libvirt] [PATCH 6/8] api: Add API to get domain title and description

2012-01-18 Thread Peter Krempa
This patch add a helper API as a counterpart to virDomainSetDescription to allow easy getting of the description and title fields from domain's config. --- include/libvirt/libvirt.h.in |3 +++ src/driver.h |4 src/libvirt.c| 40

[libvirt] [PATCH 8/8] virsh: Add support for virDomainGetDescription api

2012-01-18 Thread Peter Krempa
This patch modifies the description parser to use the new API if available with option to fall back to XML parsing. --- tools/virsh.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 976c2d9..08bfb27 100644 ---

[libvirt] [PATCH 2/8] api: Add api to set domain title and description in runtime

2012-01-18 Thread Peter Krempa
The description and title elements are accessible only through the XML, that makes it hard to work with. Atomic operations and modification of the live domain are impossible. This patch adds a function to the public API to set arbitrary descriptions for live and persistent domains.

Re: [libvirt] [PATCH 2/5 V3] remote: mplement new API virDomainGetPcpusUsage for remote driver

2012-01-18 Thread Richard W.M. Jones
There is a typo in the commit message: mplement - implement On Wed, Jan 18, 2012 at 03:12:09PM +0800, Lai Jiangshan wrote: +/* Upper limit on list of physical cpu parameters. */ +const REMOTE_DOMAIN_PCPUS_USAGE_PARAMETERS_MAX = 32; This number is bigger than the previous version, but is there

Re: [libvirt] [PATCH RFCv2 2/5] libssh2_transport: add ssh context support to virNetSocket

2012-01-18 Thread Michal Privoznik
On 04.01.2012 00:47, Peter Krempa wrote: This patch enables virNetSocket to be used as an ssh client when properly configured. Fucntion virNetSocketNewConnectLibSSH() is added, that takes all needed parameters and creates a libssh2 session context and performs steps needed to open the

Re: [libvirt] [PATCH RFCv2 1/5] libssh2_transport: add main libssh2 transport implementation

2012-01-18 Thread Michal Privoznik
On 04.01.2012 00:47, Peter Krempa wrote: This patch adds helper functions to libssh2 that enable us to use libssh2 in conjunction with libvirt-native virNetSocket-s instead of using a spawned ssh client process. This implemetation supports tunneled plaintext, keyboard-interactive, private

Re: [libvirt] [PATCH 2/5 V3] remote: mplement new API virDomainGetPcpusUsage for remote driver

2012-01-18 Thread Daniel P. Berrange
On Wed, Jan 18, 2012 at 02:53:50PM +, Richard W.M. Jones wrote: There is a typo in the commit message: mplement - implement On Wed, Jan 18, 2012 at 03:12:09PM +0800, Lai Jiangshan wrote: +/* Upper limit on list of physical cpu parameters. */ +const

[libvirt] [libvirt-glib 2/4] Add gvir_config_object_delete_children

2012-01-18 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-object-private.h |1 + libvirt-gconfig/libvirt-gconfig-object.c | 13 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h

[libvirt] [libvirt-glib 1/4] Refactor gvir_config_object_delete_child

2012-01-18 Thread Christophe Fergeau
By changing gvir_config_xml_foreach_child to make it robust against current node deletion in the foreach callback, we can use gvir_config_object_foreach_child to implement gvir_config_object_delete_child --- libvirt-gconfig/libvirt-gconfig-helpers.c |5 +++-

[libvirt] [libvirt-glib 4/4] Remove 2 unwanted exports

2012-01-18 Thread Christophe Fergeau
These 2 GVirObject helpers are declared in libvirt-gobject-private.h and so shouldn't be exported. --- libvirt-gconfig/libvirt-gconfig.sym |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index

[libvirt] [libvirt-glib 3/4] Split gvir_config_object_attach

2012-01-18 Thread Christophe Fergeau
Most of the time we want gvir_config_object_attach to replace existing nodes, but sometimes (for devices subnodes) we want it to append the new node and to keep the existing nodes with the same name. This commit solves this by adding 2 distinct helpers, _attach_add and _attach_replace. This should

[libvirt] [PATCH] Added capability checking for block iotune setting.

2012-01-18 Thread Martin Kletzander
There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. --- src/qemu/qemu_capabilities.c |6 ++ src/qemu/qemu_capabilities.h |2 ++

Re: [libvirt] [PATCH] Added capability checking for block iotune setting.

2012-01-18 Thread Eric Blake
On 01/18/2012 09:01 AM, Martin Kletzander wrote: There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. --- src/qemu/qemu_capabilities.c |6 ++

Re: [libvirt] [PATCH RFCv2 3/5] libssh2_transport: Add libssh2 session support to net client code

2012-01-18 Thread Michal Privoznik
On 04.01.2012 00:47, Peter Krempa wrote: This patch adds a glue layer to enable using libssh2 code with the network client code. As in the original client implementation, shell code is sent to the server to detect correct options for netcat. *src/rpc/virnetclient.c:

[libvirt] [PATCH v2 1/3] Compare two hash tables for equality

2012-01-18 Thread Stefan Berger
Add function to compare two hash tables for equality. --- src/util/hash.c | 46 ++ src/util/hash.h | 12 2 files changed, 58 insertions(+) Index: libvirt-iterator/src/util/hash.c

[libvirt] [PATCH v2 2/3] Add test case for virHashEqual function

2012-01-18 Thread Stefan Berger
Add a test case to test the virHashEqual function. --- tests/hashtest.c | 78 +++ 1 file changed, 78 insertions(+) Index: libvirt-iterator/tests/hashtest.c === ---

[libvirt] [PATCH v2 3/3] nwfilter: Rebuild filters only if new filter is different than current

2012-01-18 Thread Stefan Berger
Compare two filter definitions for equality and only rebuild/instantiate the new filter if the two filters are found to be different. This improves performance during an update of a filter with no obvious change or the reloading of filters during a 'kill -SIGHUP' Unforuntately this more involved

Re: [libvirt] [PATCH 0/8 v5] Summary on block IO throttle

2012-01-18 Thread Eric Blake
On 11/23/2011 02:18 AM, Stefan Hajnoczi wrote: Notes: Now all the planed features were implemented (#1#2 were implemented by Zhi Yong Wu), the previous comments were all fixed up too. And the qemu part patches have been accepted upstream and are expected to be part of the QEMU 1.1 release,

[libvirt] [PATCH] Replace hashing algorithm with murmurhash

2012-01-18 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Recent discussions have illustrated the potential for DOS attacks with the hash table implementations used by most languages and libraries. https://lwn.net/Articles/474912/ libvirt has an internal hash table impl, and uses hash tables for a

[libvirt] [PATCH v2 0/3] nwfilter: Compare filters for equality when updating

2012-01-18 Thread Stefan Berger
When a filter is updated, compare it and the original one for equality so that unnecessary instantiations of rules can be avoided. v2: - added a test case for testing virHashEqual Regards, Stefan -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH RFCv2 5/5] virsh: Reconnect to daemon if remote netcat crashes while using libssh

2012-01-18 Thread Michal Privoznik
On 04.01.2012 00:47, Peter Krempa wrote: This patch enables reconnection if for some reason remote netcat, that is connecting libvirt daemon to the ssh transport layer crashes. * tools/virsh.c: Add support for Libssh's error code --- tools/virsh.c |3 ++- 1 files changed, 2

Re: [libvirt] [PATCH RFCv2 4/5] libssh2_transport: Use libssh2 driver code in remote driver

2012-01-18 Thread Michal Privoznik
On 04.01.2012 00:47, Peter Krempa wrote: This patch adds URI options to support libssh2 transport in the remote driver. A new transport sceme is introduced eg. qemu+libssh://... that utilizes the libssh2 code added in previous patches. The libssh2 code requires the authentication callback

Re: [libvirt] [PATCH] Added capability checking for block iotune setting.

2012-01-18 Thread Martin Kletzander
On 01/18/12 17:13, Eric Blake wrote: On 01/18/2012 09:01 AM, Martin Kletzander wrote: There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. ---

[libvirt] [PATCH v2] Added capability checking for block iotune setting.

2012-01-18 Thread Martin Kletzander
There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. The support for blkiotune setting was added in upstream qemu repo under commit

Re: [libvirt] [PATCH v2] Added capability checking for block iotune setting.

2012-01-18 Thread Eric Blake
On 01/18/2012 09:42 AM, Martin Kletzander wrote: There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. The support for blkiotune setting was added in

[libvirt] [RFC PATCH V2] Add proxy FS support to libvirt

2012-01-18 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com A new FS driver type 'proxy' is added to QEMU 9p server. This patch adds support for using proxy FS driver from libvirt. QEMU proxy FS driver uses socket for communicating between helper and qemu proxy FS driver. Proxy helper (a stand alone binary part of

Re: [libvirt] [PATCH] BlockJob: Support sync/async virDomainBlockJobAbort

2012-01-18 Thread Federico Simoncelli
- Original Message - From: Adam Litke a...@us.ibm.com To: Dave Allan dal...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, January 13, 2012 9:51:23 PM Subject: [libvirt] [PATCH] BlockJob: Support sync/async virDomainBlockJobAbort Qemu has changed the semantics of the

Re: [libvirt] [PATCH] Replace hashing algorithm with murmurhash

2012-01-18 Thread Eric Blake
On 01/18/2012 09:23 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Recent discussions have illustrated the potential for DOS attacks with the hash table implementations used by most languages and libraries. https://lwn.net/Articles/474912/ libvirt has an

[libvirt] ALERT Virtualization Automatic Builder

2012-01-18 Thread berrange
Overall status: failed Start date: Wed Jan 18 2012 Start time: 18:32:52 UTC / 18:32:52 GMT Build counter: 1326911571 Build timestamp: 1326911571 URL: http://dhcp-0-241.camlab.fab.redhat.com/index.html Module: libvirt Status: failed URL: http://dhcp-0-241.camlab.fab.redhat.com/module-libvirt.html

Re: [libvirt] [PATCH 1/5 V3] libvirt: Add new public API virDomainGetPcpusUsage

2012-01-18 Thread Eric Blake
On 01/18/2012 12:12 AM, Lai Jiangshan wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- include/libvirt/libvirt.h.in |5 python/generator.py |1 + src/driver.h |7 + src/libvirt.c| 51

Re: [libvirt] [PATCH] Add two NUMA tuning python bindings APIs

2012-01-18 Thread Guan Nan Ren
Hi Anybody could give a hand on reviewing this patch, I appreciate it. Chinese New Year is coming, best wishes to this community :) Guannan Ren - Original Message - From: Guannan Ren g...@redhat.com To: libvir-list@redhat.com Sent: Monday, January 16, 2012 6:58:06

Re: [libvirt] [PATCH] Add two NUMA tuning python bindings APIs

2012-01-18 Thread Alex Jia
On 01/19/2012 09:38 AM, Guan Nan Ren wrote: Hi Anybody could give a hand on reviewing this patch, I appreciate it. Chinese New Year is coming, best wishes to this community :) Guannan Ren Happy New Year! - Original Message - From: Guannan Reng...@redhat.com

Re: [libvirt] [PATCH] Add two NUMA tuning python bindings APIs

2012-01-18 Thread Alex Jia
On 01/19/2012 11:29 AM, Alex Jia wrote: On 01/19/2012 09:38 AM, Guan Nan Ren wrote: Hi Anybody could give a hand on reviewing this patch, I appreciate it. Chinese New Year is coming, best wishes to this community :) Guannan Ren Happy New Year! - Original Message