Re: [libvirt] [PATCH v3 0/5] RFC: grant KVM guests retain arbitrary capabilities

2012-01-20 Thread Paolo Bonzini
On 01/19/2012 10:48 PM, Eric Blake wrote: On 01/19/2012 02:10 PM, Daniel P. Berrange wrote: On Thu, Jan 19, 2012 at 01:32:08PM -0700, Eric Blake wrote: On 01/18/2012 12:38 AM, Taku Izumi wrote: I am now wondering if we should do this in a different way. ie if there is some XML configuration

Re: [libvirt] [test-API][PATCH 2/2] Fix problem of a logger instance

2012-01-20 Thread Guan Nan Ren
ack Guannan Ren - Original Message - From: Wayne Sun g...@redhat.com To: libvir-list@redhat.com Sent: Friday, January 20, 2012 1:34:14 PM Subject: [libvirt] [test-API][PATCH 2/2] Fix problem of a logger instance --- utils/Python/format.py |2 +- 1 files changed, 1

Re: [libvirt] [test-API][PATCH 1/2] Fix compatibility problem on python 2.4

2012-01-20 Thread Guan Nan Ren
ack The rpartition string methods family is from Python 2.5. Guannan Ren - Original Message - From: Wayne Sun g...@redhat.com To: libvir-list@redhat.com Sent: Friday, January 20, 2012 1:34:13 PM Subject: [libvirt] [test-API][PATCH 1/2] Fix compatibility problem on python 2.4

Re: [libvirt] [RFC 0/5]: QMP: add balloon-get-memory-stats command

2012-01-20 Thread Luiz Capitulino
On Thu, 19 Jan 2012 10:15:55 -0700 Eric Blake ebl...@redhat.com wrote: On 01/19/2012 08:56 AM, Luiz Capitulino wrote: Long ago, commit 625a5be added the guest provided memory statistics to the query-balloon command. Unfortunately, it also introduced a severe bug: query-balloon would hang

Re: [libvirt] [PATCH] BlockJob: Support sync/async virDomainBlockJobAbort

2012-01-20 Thread Adam Litke
On Thu, Jan 19, 2012 at 05:39:43PM -0700, Eric Blake wrote: On 01/13/2012 01:51 PM, Adam Litke wrote: Qemu has changed the semantics of the block_job_cancel API. Originally, the operation was synchronous (ie. upon command completion, the operation was guaranteed to be completely

[libvirt] [PATCH 2/2] macvtap: listen for netlink messages from lldpad

2012-01-20 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name Make macvtap setup code register a callback to handle link status changes sent by lldpad. This is prototype code for reference only. Signed-off-by: D. Herrendoerfer d.herrendoer...@herrendoerfer.name --- src/util/virnetdevmacvlan.c |

[libvirt] [PATCH 0/2][RFC] netlink events

2012-01-20 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name I'd like to put this up for discussion. This is the prototype for netlink events as discussed before, it follows the design of the event_poll functions. Included is the unfinished prototype netlink event callback for virnetdevmacvtap.c as

[libvirt] [PATCH 1/2] Add netlink message event service

2012-01-20 Thread D. Herrendoerfer
From: D. Herrendoerfer d.herrendoer...@herrendoerfer.name This code adds an event service for netlink messages addressed to libvirt and passes the message to registered callback handlers. Itself, it makes use of the polling file event service and follows a similar design. Signed-off-by: D.

[libvirt] Using Libvirt to change the bridge a virtual network card of a running vm is connected to

2012-01-20 Thread Ralf Spenneberg
Hi there, we are using libvirt to manage our VMs. We have several VMs connected to different bridges on the same physical KVM host. We need to change the bridge a virtual machine is connected to once in a while. Currently we are just using brctl to do that. Since this needs to be done over the

[libvirt] [PATCH] xen: properly report out of memory when hvm_type is too small

2012-01-20 Thread Guido Günther
--- src/xen/xen_hypervisor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c index 855576c..51b92d3 100644 --- a/src/xen/xen_hypervisor.c +++ b/src/xen/xen_hypervisor.c @@ -2598,7 +2598,7 @@

Re: [libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-20 Thread Daniel P. Berrange
On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote: by dereferencing a NULL pointer in the call to virNodeSuspendGetTargetMask. Only warn but Don't set an error to not overwrite an error code set by xenHypervisorMakeCapabilities. --- src/xen/xen_hypervisor.c |4 1

[libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-20 Thread Guido Günther
by dereferencing a NULL pointer in the call to virNodeSuspendGetTargetMask. Only warn but Don't set an error to not overwrite an error code set by xenHypervisorMakeCapabilities. --- src/xen/xen_hypervisor.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [libvirt] Using Libvirt to change the bridge a virtual network card of a running vm is connected to

2012-01-20 Thread Laine Stump
On 01/20/2012 11:05 AM, Ralf Spenneberg wrote: Hi there, we are using libvirt to manage our VMs. We have several VMs connected to different bridges on the same physical KVM host. We need to change the bridge a virtual machine is connected to once in a while. Currently we are just using brctl to

Re: [libvirt] Using Libvirt to change the bridge a virtual network card of a running vm is connected to

2012-01-20 Thread Daniel P. Berrange
On Fri, Jan 20, 2012 at 12:42:18PM -0500, Laine Stump wrote: On 01/20/2012 11:05 AM, Ralf Spenneberg wrote: Hi there, we are using libvirt to manage our VMs. We have several VMs connected to different bridges on the same physical KVM host. We need to change the bridge a virtual machine is

Re: [libvirt] [PATCH] xen: Don't crash when we fail to init caps

2012-01-20 Thread Guido Günther
On Fri, Jan 20, 2012 at 05:01:48PM +, Daniel P. Berrange wrote: On Fri, Jan 20, 2012 at 05:57:34PM +0100, Guido Günther wrote: by dereferencing a NULL pointer in the call to virNodeSuspendGetTargetMask. Only warn but Don't set an error to not overwrite an error code set by

Re: [libvirt] [PATCH 1/4] QEMU guest agent support

2012-01-20 Thread Michal Privoznik
On 19.01.2012 23:18, Eric Blake wrote: On 01/17/2012 04:44 AM, Michal Privoznik wrote: There is now a standard QEMU guest agent that can be installed and given a virtio serial channel channel type='unix' source mode='bind' path='/var/lib/libvirt/qemu/f16x86_64.agent'/ Do we

[libvirt] Allow custom metadata in domain configuration XML

2012-01-20 Thread Zeeshan Ali (Khattak)
Hi, Apologies for not using git-send-mail but for some reason its not working for me at the moment with gmail's SMTP. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 From 6895c107970ea6daf3d0e7f8be9a1a4e97b2278b Mon Sep 17 00:00:00 2001 From: Zeeshan Ali (Khattak) zeesha...@gnome.org Date:

[libvirt] [PATCH 2/2] maint: enforce use of _LAST marker

2012-01-20 Thread Eric Blake
When converting a linear enum to a string, we have checks in place in the VIR_ENUM_IMPL macro to ensure that there is one string for every value, which lets us quickly flag if a user added a value but forgot to add a counterpart string. However, this only works if we use the _LAST marker. *

[libvirt] [PATCH 0/2] consistent use of _LAST enum markers

2012-01-20 Thread Eric Blake
This patch series will make it harder to add an enum value while forgetting to translate that enum to or from an appropriate string value. It also alters the public API so that users don't get _LAST enum values unless they ask for them, since such values are markers that might change over time

[libvirt] [PATCH 1/2] API: make declaration of _LAST enum values conditional

2012-01-20 Thread Eric Blake
Although this is a public API break, it only affects users that were compiling against *_LAST values, and can be trivially worked around without impacting compilation against older headers, by the user defining LIBVIRT_ENUM_SENTINELS before including libvirt.h. It is not an ABI break, since enum

[libvirt] [libvirt-glib] API to get/set custom metadata from/to domain config

2012-01-20 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain.c | 115 + libvirt-gconfig/libvirt-gconfig-domain.h |8 ++ libvirt-gconfig/libvirt-gconfig-helpers.c |4 +- libvirt-gconfig/libvirt-gconfig.sym |2 + 4

Re: [libvirt] [PATCH 2/2] maint: enforce use of _LAST marker

2012-01-20 Thread Jiri Denemark
On Fri, Jan 20, 2012 at 14:06:27 -0700, Eric Blake wrote: When converting a linear enum to a string, we have checks in place in the VIR_ENUM_IMPL macro to ensure that there is one string for every value, which lets us quickly flag if a user added a value but forgot to add a counterpart string.

Re: [libvirt] [PATCH 1/2] API: make declaration of _LAST enum values conditional

2012-01-20 Thread Jiri Denemark
On Fri, Jan 20, 2012 at 14:06:26 -0700, Eric Blake wrote: Although this is a public API break, it only affects users that were compiling against *_LAST values, and can be trivially worked around without impacting compilation against older headers, by the user defining LIBVIRT_ENUM_SENTINELS

[libvirt] RFC: setting mac address on network devices being assigned to a guest via PCI passthrough (hostdev)

2012-01-20 Thread Laine Stump
To refresh everyone's memory, the origin of the problem I'm trying to solve here is that the VFs of an SRIOV-capable ethernet card are given new random MAC addresses each time the card is initialized. If those VFs are then passed-through to a guest using the existing hostdev config, the guest

Re: [libvirt] Allow custom metadata in domain configuration XML

2012-01-20 Thread Eric Blake
On 01/20/2012 01:15 PM, Zeeshan Ali (Khattak) wrote: From 6895c107970ea6daf3d0e7f8be9a1a4e97b2278b Mon Sep 17 00:00:00 2001 From: Zeeshan Ali (Khattak) zeesha...@gnome.org Date: Fri, 20 Jan 2012 21:50:35 +0200 Subject: [PATCH] Allow custom metadata in domain configuration XML Applications

Re: [libvirt] Allow custom metadata in domain configuration XML

2012-01-20 Thread Zeeshan Ali (Khattak)
Hi Eric, On Fri, Jan 20, 2012 at 11:55 PM, Eric Blake ebl...@redhat.com wrote: On 01/20/2012 01:15 PM, Zeeshan Ali (Khattak) wrote: From 6895c107970ea6daf3d0e7f8be9a1a4e97b2278b Mon Sep 17 00:00:00 2001 From: Zeeshan Ali (Khattak) zeesha...@gnome.org Date: Fri, 20 Jan 2012 21:50:35 +0200

Re: [libvirt] [PATCH 1/2] API: make declaration of _LAST enum values conditional

2012-01-20 Thread Eric Blake
On 01/20/2012 02:41 PM, Jiri Denemark wrote: On Fri, Jan 20, 2012 at 14:06:26 -0700, Eric Blake wrote: Although this is a public API break, it only affects users that were compiling against *_LAST values, and can be trivially worked around without impacting compilation against older headers,

[libvirt] [PATCH] maint: cleanup qemu capabilities

2012-01-20 Thread Eric Blake
Fix inconsistent whitespace and long lines. * src/qemu/qemu_capabilities.h (qemuCapsFlags): Improve formatting. --- Pushing under the trivial rule, since this has come up multiple times this month with people trying to tweak unrelated parts of this enum while adding new values.

Re: [libvirt] [PATCH] xen: properly report out of memory when hvm_type is too small

2012-01-20 Thread Eric Blake
On 01/20/2012 09:57 AM, Guido Günther wrote: --- src/xen/xen_hypervisor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c index 855576c..51b92d3 100644 --- a/src/xen/xen_hypervisor.c +++

Re: [libvirt] [PATCH 1/2] virsh: extend domif-{get, set}link command to accept target name as a parameter

2012-01-20 Thread Eric Blake
long subject line; I trimmed it to: virsh: let domif-{get,set}link take target name On 01/19/2012 11:30 PM, Taku Izumi wrote: Other virsh domifXXX commands can accept target name as a parameter to specify interface. From viewpoint of consistency, virsh domif-getlink command should accept

Re: [libvirt] [PATCH 2/2] virsh: extend domif-{get, set}link command to accept target name as a parameter

2012-01-20 Thread Eric Blake
On 01/19/2012 11:38 PM, Taku Izumi wrote: Other virsh domifXXX commands can accept target name as a parameter to specify interface. From viewpoint of consistency, virsh domif-setlink command should accept target name as a parameter. This patch achieves this. Signd-off-by: Taku Izumi

Re: [libvirt] [PATCH v2 1/3] Compare two hash tables for equality

2012-01-20 Thread Eric Blake
On 01/18/2012 09:20 AM, Stefan Berger wrote: Add function to compare two hash tables for equality. --- src/util/hash.c | 46 ++ src/util/hash.h | 12 2 files changed, 58 insertions(+) ACK. Pretty straightforward. -- Eric

Re: [libvirt] [PATCH v2 2/3] Add test case for virHashEqual function

2012-01-20 Thread Eric Blake
On 01/18/2012 09:20 AM, Stefan Berger wrote: Add a test case to test the virHashEqual function. --- tests/hashtest.c | 78 +++ 1 file changed, 78 insertions(+) Even better - you test your new API. I would have squashed this into 1/3,