Re: [libvirt] [PATCH] qemu: Fix (managed)save and snapshots with host mode CPU

2012-03-13 Thread Jiri Denemark
On Mon, Mar 12, 2012 at 17:32:45 -0600, Eric Blake wrote: On 03/12/2012 08:31 AM, Jiri Denemark wrote: When host-model and host-passthrouh CPU modes were introduced, qemu driver was properly modify to update guest CPU definition during migration so that we use the right CPU at the

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-13 Thread Itamar Heim
On 03/12/2012 10:19 PM, Ayal Baron wrote: - Original Message - On 03/12/2012 02:12 PM, Itamar Heim wrote: On 03/12/2012 09:01 PM, Anthony Liguori wrote: It's a trade off. From a RAS perspective, it's helpful to have information about the host available in the guest. If you're

[libvirt] libvirt hooks stopped vs crashed

2012-03-13 Thread Ante Karamatic
Hi all I've noticed libvirt's qemu hook doesn't make a difference between crashed and stopped VM. While I do understand that crashed VM is essentially a stopped VM, I'd be interested in providing (and working on) a patch that would differentiate these two cases. What I'm interested in is if

Re: [libvirt] libvirt hooks stopped vs crashed

2012-03-13 Thread Osier Yang
On 03/13/2012 05:00 PM, Ante Karamatic wrote: Hi all I've noticed libvirt's qemu hook doesn't make a difference between crashed and stopped VM. While I do understand that crashed VM is essentially a stopped VM, I'd be interested in providing (and working on) a patch that would differentiate

Re: [libvirt] [PATCH 4/9] qemu: Do not start with source for removable disks if tray is open

2012-03-13 Thread Osier Yang
On 03/12/2012 05:10 PM, Paolo Bonzini wrote: Il 12/03/2012 10:28, Osier Yang ha scritto: VMs with physical CD-ROMs in general should not be migrated, so I think migration is not a problem in this case. QEMU will prohibit that, right? if so, we have no problem here. Either migrate or (save +

[libvirt] These two machines look like they have dontaudit rules disabled.

2012-03-13 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 audit_log-ex-std-node22.prod.rhcloud.com-2012-03-12 audit_log-ex-std-node24.prod.rhcloud.com-2012-03-12 semodule -B Will turn dontaudit rules back on. 22:31:32.791:507663) : avc: denied { siginh } for pid=15258 comm=trap-user

[libvirt] Postgresql binding to other localhosts by libra instances.

2012-03-13 Thread Daniel J Walsh
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I see several postgresql instances trying to bind to 127.0.0.1 audit_log-ex-lg-node4.prod.rhcloud.com-2012-03-12 audit_log-ex-std-node18.prod.rhcloud.com-2012-03-12 audit_log-ex-std-node5.prod.rhcloud.com-2012-03-12

Re: [libvirt] [PATCH] cpu: Add cpu definition for Intel Sandy Bridge cpu type

2012-03-13 Thread Peter Krempa
On 03/07/2012 02:30 PM, Peter Krempa wrote: This patch adds support for the new tsc-deadline feature flag and a new model to the supported model list describing the Intel Sandy Bridge platform. --- The Sandy Bridge processor model along with the tsc-deadline feature were just commited to qemu

[libvirt] [PATCH] Added support for AMD Bulldozer CPU

2012-03-13 Thread Martin Kletzander
AMD Bulldozer (or Opteron_G4 as called in QEMU) was added to the list of cpu models, flags were taken from upstream qemu cpu specifications and should be sorted by bit values (or first occurence in the feature specification part of cpu_map.xml). Based on QEMU upstream commit

Re: [libvirt] [PATCH] Added support for AMD Bulldozer CPU

2012-03-13 Thread Peter Krempa
On 03/13/2012 12:35 PM, Martin Kletzander wrote: AMD Bulldozer (or Opteron_G4 as called in QEMU) was added to the list of cpu models, flags were taken from upstream qemu cpu specifications and should be sorted by bit values (or first occurence in the feature specification part of cpu_map.xml).

Re: [libvirt] [PATCH] Added support for AMD Bulldozer CPU

2012-03-13 Thread Martin Kletzander
On 03/13/2012 12:56 PM, Peter Krempa wrote: On 03/13/2012 12:35 PM, Martin Kletzander wrote: AMD Bulldozer (or Opteron_G4 as called in QEMU) was added to the list of cpu models, flags were taken from upstream qemu cpu specifications and should be sorted by bit values (or first occurence in the

Re: [libvirt] [PATCH RFC 8/8] add qemu cache mutex

2012-03-13 Thread Lee Schermerhorn
On Mon, 2012-03-12 at 10:16 -0400, Lee Schermerhorn wrote: On Mon, 2012-03-12 at 14:00 +0100, Michal Privoznik wrote: On 11.03.2012 19:56, Lee Schermerhorn wrote: Add a mutex for access to the qemu emulator cache. Not clear that this is actually needed -- driver should be locked across

[libvirt] [PATCH v2] apparmor: QEMU bridge helper policy updates

2012-03-13 Thread Corey Bryant
This patch provides AppArmor policy updates for the QEMU bridge helper. The QEMU bridge helper is a SUID executable exec'd by QEMU that drops capabilities to CAP_NET_ADMIN and adds a tap device to a network bridge. For more details on the helper, please refer to:

Re: [libvirt] [PATCH] apparmor: QEMU bridge helper policy updates

2012-03-13 Thread Corey Bryant
On 03/12/2012 05:07 PM, Corey Bryant wrote: ... + network inet stream, I understood why net_admin was needed, but this one is less clear. Why does qemu-bridge-helper need this? Good question. I'm going to test without this and see if it's necessary. I'm wondering if it's a subset of

Re: [libvirt] [PATCH] vmware: detect when a domain was shut down from the inside

2012-03-13 Thread Jean-Baptiste Rouault
On Friday 03 February 2012 09:42:29 Matthias Bolte wrote: You changed all lifecycle functions not to rely on possible stale information, but you missed to update the cached state information in the virDomainObj list resulting in virsh list giving wrong output and possibly listing VMs as

[libvirt] [PATCH 3/4] storage: Implement jobs for storage driver

2012-03-13 Thread Michal Privoznik
Simply, when we are about to take an action which might take ages, like allocating new volumes, wiping, etc. increment a counter of jobs in pool object and unlock it. We don't want to hold the pool locked during long term actions. --- src/conf/storage_conf.c | 12 ++

[libvirt] [PATCH 1/4] storage: Introduce virStorageVolAbortJob

2012-03-13 Thread Michal Privoznik
This API can be used to terminate long running jobs on a volume like its building, resizing, wiping. Moreover, like virDomainAbortJob() calling this API will block until job has either completed or aborted. --- include/libvirt/libvirt.h.in |3 ++ src/driver.h |5

[libvirt] [PATCH 0/4] Introduce jobs for storage driver

2012-03-13 Thread Michal Privoznik
Disk operations can take ages to finish. Therefore users might want to abort such job, e.g. because host is going down for maintenance. This patch set is trying to allow this kind of behaviour. The inspiration was taken from qemu driver. How it works: An API that is known to run for a long time,

[libvirt] [PATCH 2/4] virsh: Expose virStorageVolAbortJob

2012-03-13 Thread Michal Privoznik
via new virsh command 'vol-jobabort'. Currently, it accepts only volume specification as argument. --- tools/virsh.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 630b77f..00668ff 100644 ---

[libvirt] [PATCH 4/4] storage: Implement virStorageVolAbortJob

2012-03-13 Thread Michal Privoznik
This implies breaking up some jobs into cycles during which we check for job abortion request. The virStorageVolAbortJob API will then just set request and wait until job is released. If a job was, however, interrupted it should fail with VIR_ERR_OPERATION_ABORTED error. ---

Re: [libvirt] [PATCH 1/4] storage: Introduce virStorageVolAbortJob

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 03:35:29PM +0100, Michal Privoznik wrote: This API can be used to terminate long running jobs on a volume like its building, resizing, wiping. Moreover, like virDomainAbortJob() calling this API will block until job has either completed or aborted. ---

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-13 Thread Eduardo Habkost
So, trying to summarize what was discussed in the call: On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote: Let's say we moved CPU definitions to /usr/share/qemu/cpu-models.xml. Obviously, we'd want a command line option to be able to change that location so we'd introduce

Re: [libvirt] [PATCH 1/4] storage: Introduce virStorageVolAbortJob

2012-03-13 Thread Michal Privoznik
On 13.03.2012 15:48, Daniel P. Berrange wrote: On Tue, Mar 13, 2012 at 03:35:29PM +0100, Michal Privoznik wrote: This API can be used to terminate long running jobs on a volume like its building, resizing, wiping. Moreover, like virDomainAbortJob() calling this API will block until job has

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
Hey, On Tue, Mar 13, 2012 at 01:22:09AM +0100, Marc-André Lureau wrote: On Mon, Mar 12, 2012 at 5:56 PM, Christophe Fergeau cferg...@redhat.com wrote: Ping for this patch and for 3/3 ? ./test-domain-create gives: channel type=spicevmc target type=channel-target-virtio/

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Marc-André Lureau
On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly looking at, and I wish the test would cover a more complex and needed case, just to be sure. -- Marc-André Lureau -- libvir-list mailing list

Re: [libvirt] [PATCH] qemu: Copy console definition from serial

2012-03-13 Thread Jan Kiszka
On 2012-03-09 19:11, Jan Kiszka wrote: On 2012-03-09 19:02, Daniel P. Berrange wrote: On Fri, Mar 09, 2012 at 06:58:06PM +0100, Jan Kiszka wrote: On 2012-03-09 18:53, Daniel P. Berrange wrote: On Fri, Mar 09, 2012 at 06:48:42PM +0100, Jan Kiszka wrote: On 2011-11-16 14:14, Michal Privoznik

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote: On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly looking at, and I wish the test would cover a more complex and needed case,

Re: [libvirt] [PATCH] qemu: Copy console definition from serial

2012-03-13 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 07:11:05PM +0100, Jan Kiszka wrote: On 2012-03-09 19:02, Daniel P. Berrange wrote: On Fri, Mar 09, 2012 at 06:58:06PM +0100, Jan Kiszka wrote: On 2012-03-09 18:53, Daniel P. Berrange wrote: On Fri, Mar 09, 2012 at 06:48:42PM +0100, Jan Kiszka wrote: On 2011-11-16

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 04:15:59PM +0100, Christophe Fergeau wrote: Hey, On Tue, Mar 13, 2012 at 01:22:09AM +0100, Marc-André Lureau wrote: On Mon, Mar 12, 2012 at 5:56 PM, Christophe Fergeau cferg...@redhat.com wrote: Ping for this patch and for 3/3 ? ./test-domain-create gives:

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
On Tue, Mar 13, 2012 at 04:31:56PM +0100, Christophe Fergeau wrote: On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote: On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
On Tue, Mar 13, 2012 at 04:18:21PM +0100, Marc-André Lureau wrote: On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote:       target type=channel-target-virtio/ That's what I was mainly looking at, and I wish the test would cover a more complex and needed case,

[libvirt] [PATCH] Do not enforce source type of console[0]

2012-03-13 Thread Jan Kiszka
If console[0] is an alias for serial[0], do not enforce the former to have a PTY source type. This breaks serial consoles on stdio and makes no sense. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- src/qemu/qemu_process.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Marc-André Lureau
So it looks ok to me, but On Tue, Mar 13, 2012 at 4:15 PM, Christophe Fergeau cferg...@redhat.com wrote: I tend to only add API in libvirt-gconfig when there's a need for it, but I can look into adding API to set the address element if you think that's needed now. How do you verify

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Christophe Fergeau
On Tue, Mar 13, 2012 at 05:01:14PM +0100, Marc-André Lureau wrote: How do you verify new_from_xml()? Am I missing something? This is just copy and paste, and keeping all files consistent. I don't think we have any user of these methods, except the top level ones, and I'm not sure it's really

Re: [libvirt] [libvirt-glib 2/3] Add LibvirtGConfigDomainChardevSourceSpiceVmc

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 06:37:04PM +0100, Christophe Fergeau wrote: On Tue, Mar 13, 2012 at 05:01:14PM +0100, Marc-André Lureau wrote: How do you verify new_from_xml()? Am I missing something? This is just copy and paste, and keeping all files consistent. I don't think we have any user of

Re: [libvirt] [PATCH v2] apparmor: QEMU bridge helper policy updates

2012-03-13 Thread Jamie Strandboge
On Tue, 2012-03-13 at 08:42 -0400, Corey Bryant wrote: This patch provides AppArmor policy updates for the QEMU bridge helper. The QEMU bridge helper is a SUID executable exec'd by QEMU that drops capabilities to CAP_NET_ADMIN and adds a tap device to a network bridge. For more details on the

Re: [libvirt] [PATCH] cpu: Add cpu definition for Intel Sandy Bridge cpu type

2012-03-13 Thread Eric Blake
On 03/07/2012 06:30 AM, Peter Krempa wrote: This patch adds support for the new tsc-deadline feature flag and a new model to the supported model list describing the Intel Sandy Bridge platform. --- ACK. That promised followup patch that sorts things into bit order would be helpful :) --

Re: [libvirt] [PATCH 4/9] qemu: Do not start with source for removable disks if tray is open

2012-03-13 Thread Eric Blake
On 03/11/2012 08:44 AM, Paolo Bonzini wrote: Il 05/03/2012 11:25, Osier Yang ha scritto: This is similiar with physical world, one will be surprised if the box starts with medium exists while the tray is open. New tests are added, tests disk-{cdrom,floppy}-tray are for the qemu supports

Re: [libvirt] [PATCH v2] apparmor: QEMU bridge helper policy updates

2012-03-13 Thread coreyb
Quoting Jamie Strandboge ja...@canonical.com: ... The policy looks good to me. Thanks! It might make more sense to have this committed when libvirt has qemu-bridge-helper, but others can decide on that. Acked-By: Jamie Strandboge ja...@canonical.com -- Jamie Strandboge |

[libvirt] RFC: mirrored live block migration in libvirt 0.9.11

2012-03-13 Thread Eric Blake
Here's what I'm planning on implementing for libvirt 0.9.11 to support oVirt's desire to do live block migration, and built on top of qemu 1.1's new 'transaction' QMP monitor command. Comments are welcome before I actually post patches. Background == Here is oVirt's description of

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

2012-03-13 Thread Ayal Baron
- Original Message - On 03/12/2012 10:19 PM, Ayal Baron wrote: - Original Message - On 03/12/2012 02:12 PM, Itamar Heim wrote: On 03/12/2012 09:01 PM, Anthony Liguori wrote: It's a trade off. From a RAS perspective, it's helpful to have information about the host

[libvirt] Modified version of the libvirt-test-api wrapper

2012-03-13 Thread Lucas Meneghel Rodrigues
Hi Guannan: I've worked on your first version of the libvirt-test-api wrapper for autotest. Could you please check if you like the modified version? https://github.com/autotest/autotest/pull/230 If you do think it's fine, you can ack it, or you might take it, modify and resend it. On a git

[libvirt] [PATCH][TCK] add tests for network interface transaction

2012-03-13 Thread Xiaoqiang Hu
add tests for network interface transaction: interface_change_begin, interface_change_commit and interface_change_rollback --- .../networks/110-interface-change-transaction.t| 81 1 files changed, 81 insertions(+), 0 deletions(-) create mode 100644

[libvirt] [PATCH] Emit graphics events when a SPICE client connects/disconnects

2012-03-13 Thread Laine Stump
Wire up the domain graphics event notifications for SPICE. Adapted from a RHEL-only patch written by Dan Berrange that used custom __com.redhat_SPICE events - equivalent events are now available in upstream QEMU (including a SPICE_CONNECTED event, which was missing in the __COM.redhat_SPICE