Re: [libvirt] [PATCH] qemu: Make sure qemu can access its directory in hugetlbfs

2012-04-30 Thread Jiri Denemark
On Sat, Apr 28, 2012 at 15:27:12 +0800, Osier Yang wrote: On 2012年04月27日 22:45, Jiri Denemark wrote: When libvirtd is started, we create libvirt/qemu directories under hugetlbfs mount point. Only the qemu subdirectory is chowned to qemu user and libvirt remains owned by root. If umask was

Re: [libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-04-30 Thread Martin Kletzander
On 04/28/2012 12:13 PM, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the most strict search usbFindDevByBus():get usb device according to bus, device it returns only one usb device

Re: [libvirt] ANNOUNCE: Stable release libvirt-0.9.11.2

2012-04-30 Thread Daniel P. Berrange
On Sat, Apr 28, 2012 at 08:35:19PM -0700, Jason Helfman wrote: Okay, I screwed up the tarball for the first stable release, due to not building it from a fresh checkout :/ No changes for this one except a version bump and dist rebuild. This release can be downloaded at:

Re: [libvirt] [PATCH] storage: Allow multiple hosts for a storage pool

2012-04-30 Thread Daniel Veillard
On Wed, Apr 25, 2012 at 11:47:17AM +0100, Daniel P. Berrange wrote: On Wed, Apr 25, 2012 at 12:43:09PM +0200, Wido den Hollander wrote: The current storage pools for NFS and iSCSI only require one host to connect to. Future storage pools like RBD and Sheepdog will require multiple hosts.

[libvirt] A couple of questions on snapshot-create/ snapshot-create-as

2012-04-30 Thread Kashyap Chamarthy
Hi (Eric?), I got a couple of questions for 'snapshot-create' / 'snapshot-create-as' : 1/ can '--disk-only' option (when used with virsh snapshot-create-as) be run on an offline guest and generate an 'external snapshot' ? Or a running guest is needed? 2/ Can anyone point me to a bit more

Re: [libvirt] [Qemu-devel] [PATCH qemu 4/6] vl.c: change 'defconfig' variable to bool

2012-04-30 Thread Eduardo Habkost
On Sat, Apr 28, 2012 at 07:53:41AM +, Blue Swirl wrote: On Tue, Apr 24, 2012 at 20:32, Eduardo Habkost ehabk...@redhat.com wrote: Signed-off-by: Eduardo Habkost ehabk...@redhat.com ---  vl.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c

Re: [libvirt] [PATCH] storage: Break out the loop if duplicate pool is found

2012-04-30 Thread Osier Yang
On 2012年04月28日 17:06, Michal Privoznik wrote: On 28.04.2012 10:22, Osier Yang wrote: It doesn't break out the for loop even if duplicate pool is found, and thus the matchpool could be overriden as NULL again if there is different pool afterwards. To address the problem in libvirt-user list:

Re: [libvirt] A couple of questions on snapshot-create/ snapshot-create-as

2012-04-30 Thread Eric Blake
On 04/30/2012 06:17 AM, Kashyap Chamarthy wrote: Hi (Eric?), I got a couple of questions for 'snapshot-create' / 'snapshot-create-as' : 1/ can '--disk-only' option (when used with virsh snapshot-create-as) be run on an offline guest and generate an 'external snapshot' ? Not yet, but

[libvirt] [PATCH qemu 7/6] vl.c: actually change defconfig variable to bool

2012-04-30 Thread Eduardo Habkost
I changed everything on my previous patch to change 'defconfig', but forgot to actually change the variable data type. As the incomplete change doesn't cause any issues or compiler warnings, I am simply sending this additional patch instead of respinning the whole series. Signed-off-by: Eduardo

Re: [libvirt] A couple of questions on snapshot-create/ snapshot-create-as

2012-04-30 Thread Kashyap Chamarthy
On 04/30/2012 06:48 PM, Eric Blake wrote: On 04/30/2012 06:17 AM, Kashyap Chamarthy wrote: Hi (Eric?), I got a couple of questions for 'snapshot-create' / 'snapshot-create-as' : 1/ can '--disk-only' option (when used with virsh snapshot-create-as) be run on an offline guest and generate

Re: [libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-04-30 Thread Osier Yang
On 2012年04月28日 18:13, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the most strict search usbFindDevByBus():get usb device according to bus, device it returns only one usb device same

[libvirt] [PATCH libvirt-glib] Add complete docs for the Libvirt GLib library

2012-04-30 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Flesh out the section intros for each of the Libvirt GLib library modules, providing using examples where needed, and adding any missing function docs. --- cfg.mk |2 +- configure.ac|

[libvirt] [PATCH] Ensure libvirt_lxc process loads the live XML config

2012-04-30 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently the libvirt_lxc process uses VIR_DOMAIN_XML_INACTIVE when loading the XML for the container. This means it looses any dynamic data such as the, just allocated, SELinux label. Further there is an inconsistency in the libvirt LXC driver

[libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Stefan Berger
Addressing the following reports: Error: RESOURCE_LEAK: /libvirt/src/nodeinfo.c:631: alloc_fn: Calling allocation function fopen. /libvirt/src/nodeinfo.c:631: var_assign: Assigning: cpuinfo = storage returned from fopen(/proc/cpuinfo, r). /libvirt/src/nodeinfo.c:640: leaked_storage: Variable

Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote: Addressing the following reports: None of those reports mention daemon/libvirtd.c and yet daemon/libvirtd.c | 24 +++- Index: libvirt-acl/daemon/libvirtd.c

[libvirt] [PATCH] storage: fix build with iscsi

2012-04-30 Thread Eric Blake
The previous storage patch missed an instance affected by the struct member rename. * src/storage/storage_backend_iscsi.c (virStorageBackendISCSIFindPoolSources): Adjust to new struct. --- Pushing under the build-breaker rule. src/storage/storage_backend_iscsi.c | 12 1 files

Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Stefan Berger
On 04/30/2012 12:34 PM, Daniel P. Berrange wrote: On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote: Addressing the following reports: None of those reports mention daemon/libvirtd.c and yet These must have gotten lost: Error: RESOURCE_LEAK: /libvirt/daemon/libvirtd.c:147:

Re: [libvirt] [PATCH] storage: fix build with iscsi

2012-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2012 at 10:38:38AM -0600, Eric Blake wrote: The previous storage patch missed an instance affected by the struct member rename. * src/storage/storage_backend_iscsi.c (virStorageBackendISCSIFindPoolSources): Adjust to new struct. --- Pushing under the build-breaker rule.

Re: [libvirt] [PATCH] storage: fix build with iscsi

2012-04-30 Thread Stefan Berger
On 04/30/2012 12:38 PM, Eric Blake wrote: The previous storage patch missed an instance affected by the struct member rename. @@ -589,11 +589,13 @@ virStorageBackendISCSIFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED, } for (i = 0 ; i ntargets ; i++) { -if

Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Daniel P. Berrange
On Mon, Apr 30, 2012 at 12:42:37PM -0400, Stefan Berger wrote: On 04/30/2012 12:34 PM, Daniel P. Berrange wrote: On Mon, Apr 30, 2012 at 12:28:26PM -0400, Stefan Berger wrote: Addressing the following reports: None of those reports mention daemon/libvirtd.c and yet These must have

Re: [libvirt] [PATCH] Yet more coverity fixes

2012-04-30 Thread Stefan Berger
On 04/30/2012 12:55 PM, Daniel P. Berrange wrote: On Mon, Apr 30, 2012 at 12:42:37PM -0400, Stefan Berger wrote: /libvirt/daemon/libvirtd.c:168: leaked_handle: Handle variable stdinfd going out of scope leaks the handle. This is refering to the 3rd line here: switch

Re: [libvirt] [PATCH] storage: fix build with iscsi

2012-04-30 Thread Eric Blake
On 04/30/2012 10:50 AM, Stefan Berger wrote: On 04/30/2012 12:38 PM, Eric Blake wrote: The previous storage patch missed an instance affected by the struct member rename. @@ -589,11 +589,13 @@ virStorageBackendISCSIFindPoolSources(virConnectPtr conn ATTRIBUTE_UNUSED, } for

Re: [libvirt] [PATCH] util: Avoid libvirtd crash

2012-04-30 Thread Eric Blake
The subject line is pretty generic; it's better to add something like the name of the function being fixed to minimize the chance of patch name collision causing backporters minor confusion in deciding what to backport. On 04/28/2012 05:01 AM, Alex Jia wrote: In fact, the 'tapfd' is always NULL,

Re: [libvirt] [PATCH] Ensure libvirt_lxc process loads the live XML config

2012-04-30 Thread Eric Blake
On 04/30/2012 08:52 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently the libvirt_lxc process uses VIR_DOMAIN_XML_INACTIVE when loading the XML for the container. This means it looses s/looses/loses/ any dynamic data such as the, just allocated, SELinux

Re: [libvirt] ANNOUNCE: Stable release libvirt-0.9.11.2

2012-04-30 Thread Doug Goldstein
On Sat, Apr 28, 2012 at 10:35 PM, Jason Helfman jhelf...@e-e.com wrote: Okay, I screwed up the tarball for the first stable release, due to not building it from a fresh checkout :/ No changes for this one except a version bump and dist rebuild. This release can be downloaded at:

Re: [libvirt] ANNOUNCE: Stable release libvirt-0.9.11.2

2012-04-30 Thread Jason Helfman
On Mon, Apr 30, 2012 at 01:38:27PM -0500, Doug Goldstein thus spake: On Sat, Apr 28, 2012 at 10:35 PM, Jason Helfman jhelf...@e-e.com wrote: Okay, I screwed up the tarball for the first stable release, due to not building it from a fresh checkout :/ No changes for this one except a version bump

[libvirt] [PATCH] Use XDG Base Directories instead of storing in home

2012-04-30 Thread William Jon McCann
Hi, New to the list so hopefully I'm following the correct protocol. Attached is a patch (mostly untested at the moment) to change the default storage location from .libvirt to the locations defined in the XDG Base Directory Specification

Re: [libvirt] ANNOUNCE: Stable release libvirt-0.9.11.2

2012-04-30 Thread Eric Blake
On 04/30/2012 12:43 PM, Jason Helfman wrote: Is there any particular reason that the project is using the same naming convention for stable releases? It appears to be a minor revision update from the standard release cycle. From an outsiders prospective, I don't know how anyone would think

Re: [libvirt] ANNOUNCE: Stable release libvirt-0.9.11.2

2012-04-30 Thread Jason Helfman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Mon, Apr 30, 2012 at 12:56:05PM -0600, Eric Blake thus spake: On 04/30/2012 12:43 PM, Jason Helfman wrote: Is there any particular reason that the project is using the same naming convention for stable releases? It appears to be a minor

Re: [libvirt] [PATCHv6 9/8] blockjob: allow speed setting in block copy

2012-04-30 Thread Paolo Bonzini
Il 26/04/2012 22:55, Eric Blake ha scritto: Paolo proposed 'drive-mirror' to upstream qemu prior to Stefan Hajnoczi's patch to 'block-stream'. qemu 1.1 has included Stefan's patch, but Paolo's is still in limbo, and needs to be rebased if it will even make qemu 1.1. But it is a logical

[libvirt] [PATCH 2/2] virsh: output scaled values with correct units

2012-04-30 Thread Eric Blake
The recent push to use correct scaling terms (kB for 1000, KiB for 1024 - such as commit 9dfdead) missed some places in virsh. * tools/virsh.c (prettyCapacity, cmdDominfo, cmdFreecell) (cmdNodeinfo, cmdNodeMemStats): Use KiB, not kB, when referring to multiples of 1024. --- tools/virsh.c | 24

[libvirt] [PATCH 1/2] virsh: make -h always give help

2012-04-30 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=817244 mentions that unlike most other tools, where --help or --version prevent all further parsing of all later options, virsh was strange in that --version stopped parsing but --help tried to plow on to the end. There was no rationale for this original

[libvirt] [PATCH] docs: mention migration issue of which credentials are used

2012-04-30 Thread Eric Blake
Based on a report by Seth Vidal. Just because _you_ can use virsh to connect to both source and destinations does not mean that libvirtd on the source (aka _root_) can likewise connect to the destination; this matters when setting up a peer-to-peer migration instead of a native one. *

[libvirt] [PATCH] maint: avoid false positives on unmarked diagnostics

2012-04-30 Thread Eric Blake
Otherwise, a string such as _(Don't use \ VAR \.) would complain about unmarked diagnostics. * cfg.mk (sc_libvirt_unmarked_diagnostics): Handle \ in message. --- I needed this patch to let me verify Stefan's DHCP Snooping series. cfg.mk |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH 2/2] virsh: output scaled values with correct units

2012-04-30 Thread Eric Blake
On 04/30/2012 02:31 PM, Eric Blake wrote: The recent push to use correct scaling terms (kB for 1000, KiB for 1024 - such as commit 9dfdead) missed some places in virsh. * tools/virsh.c (prettyCapacity, cmdDominfo, cmdFreecell) (cmdNodeinfo, cmdNodeMemStats): Use KiB, not kB, when referring

[libvirt] [PATCHv2 2/2] virsh: output scaled values with correct units

2012-04-30 Thread Eric Blake
The recent push to use correct scaling terms (kB for 1000, KiB for 1024 - such as commit 9dfdead) missed some places in virsh. * tools/virsh.c (prettyCapacity, cmdDominfo, cmdFreecell) (cmdNodeinfo, cmdNodeMemStats): Use KiB, not kB, when referring to multiples of 1024. * tests/virshtest.c:

[libvirt] [PATCH 1/1] Support libnl-3 as well as libnl-1

2012-04-30 Thread Serge Hallyn
configure.ac: Check for libnl-3. If found, find libnl-route-3. If not found, do the original check to look for libnl-1. src/util/virnetlink.c: support libnl3 api. I could play games to make the patch smaller, but this would just hide what is actually needing to be done at the expense of

Re: [libvirt] [PATCH V13 2/5] nwfilter: add DHCP snooping

2012-04-30 Thread Eric Blake
On 04/25/2012 06:59 AM, Stefan Berger wrote: This patch adds DHCP snooping support to libvirt. The learning method for IP addresses is specified by setting the CTRL_IP_LEARNING variable to one of any [default] (existing IP learning code), none (static only addresses) or dhcp (DHCP snooping).

Re: [libvirt] [PATCH v5 1/9] pvs: add driver skeleton

2012-04-30 Thread Eric Blake
On 04/20/2012 10:01 AM, Dmitry Guryanov wrote: Add driver, which can report node info only. Since this is the first commit in the series, can you please add more information about pvs? This content from your 0/9 message would be useful here: Parallels Virtuozzo Server is a cloud-ready

Re: [libvirt] [PATCH libvirt-glib] Add complete docs for the Libvirt GLib library

2012-04-30 Thread Zeeshan Ali (Khattak)
On Mon, Apr 30, 2012 at 5:38 PM, Daniel P. Berrange berra...@redhat.com wrote: From: Daniel P. Berrange berra...@redhat.com Flesh out the section intros for each of the Libvirt GLib library modules, providing using examples where needed, and adding any missing function docs. Looks good, ACK!

Re: [libvirt] [Libvirt-announce] ANNOUNCE: Stable release libvirt-0.9.11.1

2012-04-30 Thread Justin Clift
On 27/04/2012, at 5:45 AM, Cole Robinson wrote: snip For a complete list of changes since libvirt-0.9.11 GA, please see: http://wiki.libvirt.org/page/Stable_Releases * Just as a FYI, this Stable_Releases page needs some linkage. It's not referred to from the News section, there no link to