[libvirt] [PATCH 1/1] Correct indent errors in the function qemuDomainNetsRestart

2012-05-03 Thread Li Zhang
There are three spapces for a indent every line in the function qemuDomainNetsRestart. This patch is to correct it. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-)

[libvirt] [PATCH 1/1] Correct indent errors in the function qemuDomainNetsRestart

2012-05-03 Thread Li Zhang
There are three spapces for a indent every line in the function qemuDomainNetsRestart. This patch is to correct it. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-)

Re: [libvirt] [PATCH 3/7] Coverity: Fix resource leak in esx driver

2012-05-03 Thread Matthias Bolte
2012/5/2 Osier Yang jy...@redhat.com: Error: RESOURCE_LEAK: /builddir/build/BUILD/libvirt-0.9.10/src/esx/esx_vi.c:1893: alloc_arg: Calling allocation function esxVI_ObjectSpec_Alloc on objectSpec. /builddir/build/BUILD/libvirt-0.9.10/src/esx/esx_vi_types.generated.c:2065: alloc_arg:

Re: [libvirt] [PATCH] Use XDG Base Directories instead of storing in home

2012-05-03 Thread Christophe Fergeau
Hey, On Wed, May 02, 2012 at 01:49:42PM -0400, William Jon McCann wrote: Hi, On Wed, May 2, 2012 at 6:26 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Mon, Apr 30, 2012 at 02:55:06PM -0400, William Jon McCann wrote: This has a number of advantages for us:     It

Re: [libvirt] [PATCH v2 2/3] qemu: make use of usb search function to initialize usb devices

2012-05-03 Thread Guannan Ren
On 05/03/2012 01:29 AM, Eric Blake wrote: On 05/01/2012 02:16 AM, Guannan Ren wrote: refactor qemuPrepareHostdevUSBDevices function, make it focus on adding usb device to activeUsbHostdevs after check. After that, the usb hotplug function qemuDomainAttachHostDevice also could use it. expand

Re: [libvirt] [PATCH 1/1] Correct indent errors in the function qemuDomainNetsRestart

2012-05-03 Thread Alex Jia
On 05/03/2012 01:53 PM, Li Zhang wrote: There are three spapces for a indent every line in the function qemuDomainNetsRestart. Yeah, the codes exist indentation issues, in addition, also need to align function arguments in 'qemuDomainNetsRestart'(): diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v2 3/3] qemu: search usb device accurately to improve usb device hotplug

2012-05-03 Thread Guannan Ren
On 05/03/2012 01:31 AM, Eric Blake wrote: On 05/01/2012 02:16 AM, Guannan Ren wrote: One usb device could be allowed to hotplug in at a time. If user give a xml as follows. Probably there are two usb devices avaiable s/avaiable/available/ but with different value of bus, device we give a

Re: [libvirt] [PATCH 1/2] rpc: Switch to dynamically allocated message buffer

2012-05-03 Thread Daniel P. Berrange
On Wed, May 02, 2012 at 01:52:27PM -0600, Eric Blake wrote: On 04/27/2012 07:22 AM, Michal Privoznik wrote: Currently, we are allocating buffer for RPC messages statically. This is not such pain when RPC limits are small. However, if we want ever to increase those limits, we need to

Re: [libvirt] [PATCH alternative 1] util: fix libvirtd startup failure due to netlink error

2012-05-03 Thread Daniel P. Berrange
On Wed, May 02, 2012 at 04:35:48PM -0400, Laine Stump wrote: On 05/02/2012 11:32 AM, Daniel P. Berrange wrote: On Wed, May 02, 2012 at 11:29:36AM -0400, Laine Stump wrote: On 05/02/2012 05:11 AM, Daniel P. Berrange wrote: On Tue, May 01, 2012 at 03:10:42PM -0400, Laine Stump wrote: This

Re: [libvirt] [PATCH v2 1/3] usb: create functions to search usb device accurately

2012-05-03 Thread Guannan Ren
On 05/03/2012 01:17 AM, Osier Yang wrote: On 2012年05月01日 16:16, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the most strict search usbFindDevByBus():get usb device according to bus, device Should we

Re: [libvirt] [PATCH v2 2/3] qemu: make use of usb search function to initialize usb devices

2012-05-03 Thread Guannan Ren
On 05/03/2012 01:45 AM, Osier Yang wrote: On 2012年05月01日 16:16, Guannan Ren wrote: refactor qemuPrepareHostdevUSBDevices function, make it focus on adding usb device to activeUsbHostdevs after check. After that, the usb hotplug function qemuDomainAttachHostDevice also could use it. expand

Re: [libvirt] [PATCH v2 3/3] qemu: search usb device accurately to improve usb device hotplug

2012-05-03 Thread Guannan Ren
On 05/03/2012 02:06 AM, Osier Yang wrote: On 2012年05月01日 16:16, Guannan Ren wrote: One usb device could be allowed to hotplug in at a time. If user give a xml as follows. s/give/gives/ Probably there are two usb devices avaiable s/avaiable/available/ but with different value of bus,

[libvirt] [PATCH] [libvirt-test-API] Use YABOOT instead of ISOLINUX to create bootable ISO.

2012-05-03 Thread Lin Qing
Yaboot is the bootloader of PowerPC (ISOLINUX on AMD64/x86 systems, yaboot on PowerPC), so should change the yaboot.conf firstly,then use mkiso command to create bootable ISO. Signed-off-by: Qing Linqing...@linux.vnet.ibm.com --- utils/ksiso.sh | 57

Re: [libvirt] [PATCH 1/1] Correct indent errors in the function qemuDomainNetsRestart

2012-05-03 Thread Osier Yang
On 2012年05月03日 13:52, Li Zhang wrote: There are three spapces for a indent every line in the s/spapces/spaces/ function qemuDomainNetsRestart. This patch is to correct it. Signed-off-by: Li Zhangzhlci...@linux.vnet.ibm.com --- src/qemu/qemu_driver.c | 42

Re: [libvirt] [PATCH v6 0/9] Add basic driver for Parallels Virtuozzo Server

2012-05-03 Thread Daniel Veillard
On Wed, May 02, 2012 at 10:32:35PM +0400, Dmitry Guryanov wrote: Parallels Virtuozzo Server is a cloud-ready virtualization solution that allows users to simultaneously run multiple virtual machines and containers on the same physical server. Current name of this product is Parallels Server

Re: [libvirt] [PATCH 1/1] Correct indent errors in the function qemuDomainNetsRestart

2012-05-03 Thread Alex Jia
On 05/03/2012 05:25 PM, Osier Yang wrote: On 2012年05月03日 13:52, Li Zhang wrote: There are three spapces for a indent every line in the s/spapces/spaces/ function qemuDomainNetsRestart. This patch is to correct it. Signed-off-by: Li Zhangzhlci...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH v6 2/9] util: add functions for interating over json object

2012-05-03 Thread Daniel P. Berrange
On Wed, May 02, 2012 at 10:32:37PM +0400, Dmitry Guryanov wrote: Add function virJSONValueObjectKeysNumber, virJSONValueObjectGetKey and virJSONValueObjectGetValue, which allow you to iterate over all fields of json object: you can get number of fields and then get name and value, stored in

Re: [libvirt] [PATCH] [libvirt-test-API] Use YABOOT instead of ISOLINUX to create bootable ISO.

2012-05-03 Thread Alex Jia
On 05/03/2012 05:11 PM, Lin Qing wrote: Yaboot is the bootloader of PowerPC (ISOLINUX on AMD64/x86 systems, yaboot on PowerPC), so should change the yaboot.conf firstly,then use mkiso command to create bootable ISO. Whether we consider to rewrite it in python language and add it as a

[libvirt] Entering freeze for libvirt-0.9.12

2012-05-03 Thread Daniel Veillard
A bit late compared to my estimate from last week, I have just tagged the git tree and made an rc1 snapshot for testing: ftp://libvirt.org/libvirt/libvirt-0.9.12-rc1.tar.gz and currently pushing along the large set of rpms. We still have a number of pending patches as pointed out by

[libvirt] [PATCH 3/3] qemu: search usb device accurately to improve usb device hotplug

2012-05-03 Thread Guannan Ren
One usb device could be allowed to hotplug in at a time. If user gives a xml as follows. Probably there are two usb devices available but with different value of bus, device we give an error to let user use address to specify the desired one. hostdev mode='subsystem' type='usb' managed='yes'

[libvirt] [PATCH 2/3] qemu: make use of usb search function to initialize usb devices

2012-05-03 Thread Guannan Ren
refactor qemuPrepareHostdevUSBDevices function, make it focus on adding usb device to activeUsbHostdevs after check. After that, the usb hotplug function qemuDomainAttachHostDevice also could use it. expand qemuPrepareHostUSBDevices to perform the usb search, rollback on failure. ---

[libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-05-03 Thread Guannan Ren
usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the exact match of the four parameters usbFindDeviceByBus():get usb device according to bus, device it returns only one usb device same as usbFindDevice

[libvirt] [PATCH v3 0/3] usb devices with same vendorID, productID hotplug support

2012-05-03 Thread Guannan Ren
https://bugzilla.redhat.com/show_bug.cgi?id=815755 The set of patch tries to fix the issue when multiple usb devices with same idVendor, idProduct are availible on host, the usb device with lowest bus:device will be attached to guest if usb xml file is given like this: hostdev mode='subsystem'

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-03 Thread Christophe Fergeau
On Wed, May 02, 2012 at 09:04:00PM +0300, Zeeshan Ali (Khattak) wrote: On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau cferg...@redhat.com wrote: What would be these getters apart from the already existing _get_name? The features under 'guest' can have boolean attributes, 'default' and

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-03 Thread Daniel P. Berrange
On Thu, May 03, 2012 at 01:11:26PM +0200, Christophe Fergeau wrote: On Wed, May 02, 2012 at 09:04:00PM +0300, Zeeshan Ali (Khattak) wrote: On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau cferg...@redhat.com wrote: What would be these getters apart from the already existing _get_name?

Re: [libvirt] [PATCH] [libvirt-test-API] Use YABOOT instead of ISOLINUX to create bootable ISO.

2012-05-03 Thread Guannan Ren
On 05/03/2012 05:11 PM, Lin Qing wrote: Yaboot is the bootloader of PowerPC (ISOLINUX on AMD64/x86 systems, yaboot on PowerPC), so should change the yaboot.conf firstly,then use mkiso command to create bootable ISO. Signed-off-by: Qing Linqing...@linux.vnet.ibm.com --- utils/ksiso.sh |

Re: [libvirt] [PATCH] [libvirt-test-API] Use YABOOT instead of ISOLINUX to create bootable ISO.

2012-05-03 Thread Guannan Ren
On 05/03/2012 06:23 PM, Alex Jia wrote: On 05/03/2012 05:11 PM, Lin Qing wrote: Yaboot is the bootloader of PowerPC (ISOLINUX on AMD64/x86 systems, yaboot on PowerPC), so should change the yaboot.conf firstly,then use mkiso command to create bootable ISO. Whether we consider to rewrite it

Re: [libvirt] [PATCH] Use XDG Base Directories instead of storing in home directory

2012-05-03 Thread Daniel P. Berrange
On Wed, May 02, 2012 at 01:53:36PM -0400, William Jon McCann wrote: +static int migrateProfile(void) +{ +char *old_base = NULL; +char *updated = NULL; +char *home = NULL; +char *xdg_dir = NULL; +char *config_dir = NULL; +const char *config_home; +int ret = -1;

Re: [libvirt] [PATCH v6 2/9] util: add functions for interating over json object

2012-05-03 Thread Eric Blake
On 05/03/2012 04:10 AM, Daniel P. Berrange wrote: On Wed, May 02, 2012 at 10:32:37PM +0400, Dmitry Guryanov wrote: Add function virJSONValueObjectKeysNumber, virJSONValueObjectGetKey and virJSONValueObjectGetValue, which allow you to iterate over all fields of json object: you can get number

[libvirt] [PATCHv2] util: fix libvirtd startup failure due to netlink error

2012-05-03 Thread Laine Stump
This solves the problem detailed in: https://bugzilla.redhat.com/show_bug.cgi?id=816465 and further detailed in https://www.redhat.com/archives/libvir-list/2012-May/msg00202.htm A short explanation is included in the comments of the patch itself. Even with ACK, I will wait to push this

[libvirt] [PATCH 1/2] coverity: fix memory leak in error path in virnetlink.c

2012-05-03 Thread Guannan Ren
--- src/util/virnetlink.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index b2e9d51..e199d62 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -340,8 +340,10 @@ virNetlinkEventServiceStart(void)

[libvirt] [PATCH 2/2] coverity: fd and memory leak in nodeinfo.c

2012-05-03 Thread Guannan Ren
--- src/nodeinfo.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index e842474..012f0f8 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -626,32 +626,31 @@ int nodeGetInfo(virConnectPtr conn ATTRIBUTE_UNUSED,

Re: [libvirt] [PATCH alternative 1] util: fix libvirtd startup failure due to netlink error

2012-05-03 Thread Laine Stump
On 05/03/2012 04:09 AM, Daniel P. Berrange wrote: On Wed, May 02, 2012 at 04:35:48PM -0400, Laine Stump wrote: [lots of explanation snipped] So, the conclusions to draw from this analysis are: 1) my alternative 1 patch was only coincidentally succeeding, and would be about as useful as

Re: [libvirt] [PATCHv2] util: fix libvirtd startup failure due to netlink error

2012-05-03 Thread Daniel P. Berrange
On Thu, May 03, 2012 at 11:10:49AM -0400, Laine Stump wrote: This solves the problem detailed in: https://bugzilla.redhat.com/show_bug.cgi?id=816465 and further detailed in https://www.redhat.com/archives/libvir-list/2012-May/msg00202.htm A short explanation is included in the

[libvirt] [PATCH] util: remove error log from stub versions of virNetlinkEventServiceStart|Stop

2012-05-03 Thread Laine Stump
These two functions are called from main() on all platforms, and always return success on platforms that don't support libnl. They still log an error message, though, which doesn't make sense - they should just be NOPs on those platforms. --- src/util/virnetlink.c |2 -- 1 file changed, 2

[libvirt] [PATCH 1/1] support libnl-3 (v2)

2012-05-03 Thread Serge Hallyn
configure.ac+Makefile.am: support libnl-3 as well as libnl-1 src/util/virnetlink.c: support libnl3 api. To minimize impact on code flow with #ifdefs as requested by Stefan Berger, do some #defines at the top. Unfortunately libnl3 moves netlink/msg.h to /usr/include/libnl3/netlink/msg.h, so the

Re: [libvirt] [PATCH] util: remove error log from stub versions of virNetlinkEventServiceStart|Stop

2012-05-03 Thread Daniel P. Berrange
On Thu, May 03, 2012 at 11:58:02AM -0400, Laine Stump wrote: These two functions are called from main() on all platforms, and always return success on platforms that don't support libnl. They still log an error message, though, which doesn't make sense - they should just be NOPs on those

Re: [libvirt] [PATCH] util: remove error log from stub versions of virNetlinkEventServiceStart|Stop

2012-05-03 Thread Osier Yang
On 2012年05月03日 23:58, Laine Stump wrote: These two functions are called from main() on all platforms, and always return success on platforms that don't support libnl. They still log an error message, though, which doesn't make sense - they should just be NOPs on those platforms. ---

[libvirt] [PATCHv4] Use XDG Base Directories instead of storing in home directory

2012-05-03 Thread William Jon McCann
As defined in: http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html This offers a number of advantages: * Allows sharing a home directory between different machines, or sessions (eg. using NFS) * Cleanly separates cache, runtime (eg. sockets), or app data from user settings *

Re: [libvirt] [PATCHv2] util: fix libvirtd startup failure due to netlink error

2012-05-03 Thread Eric Blake
On 05/03/2012 09:10 AM, Laine Stump wrote: This solves the problem detailed in: https://bugzilla.redhat.com/show_bug.cgi?id=816465 and further detailed in https://www.redhat.com/archives/libvir-list/2012-May/msg00202.htm A short explanation is included in the comments of the patch

[libvirt] [PATCHv2] openvz: read vmguarpages/privvmpages to set memory tunables

2012-05-03 Thread Guido Günther
--- Changes since last time: * check sysconf return value before division * use virStrToLong_ull instead of sscanf O.k. to apply? Cheers, -- Guido src/openvz/openvz_conf.c| 115 src/openvz/openvz_driver.c | 222

Re: [libvirt] [PATCH 1/2] coverity: fix memory leak in error path in virnetlink.c

2012-05-03 Thread Eric Blake
On 05/03/2012 09:28 AM, Guannan Ren wrote: --- src/util/virnetlink.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index b2e9d51..e199d62 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -340,8

Re: [libvirt] [PATCH 2/2] coverity: fd and memory leak in nodeinfo.c

2012-05-03 Thread Eric Blake
On 05/03/2012 09:28 AM, Guannan Ren wrote: --- src/nodeinfo.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index e842474..012f0f8 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -626,32 +626,31 @@ int

Re: [libvirt] [PATCH 1/1] support libnl-3 (v2)

2012-05-03 Thread Stefan Berger
On 05/03/2012 12:10 PM, Serge Hallyn wrote: configure.ac+Makefile.am: support libnl-3 as well as libnl-1 src/util/virnetlink.c: support libnl3 api. To minimize impact on code flow with #ifdefs as requested by Stefan Berger, do some #defines at the top. Unfortunately libnl3 moves netlink/msg.h

Re: [libvirt] [PATCH 1/1] support libnl-3 (v2)

2012-05-03 Thread Eric Blake
On 05/03/2012 10:10 AM, Serge Hallyn wrote: configure.ac+Makefile.am: support libnl-3 as well as libnl-1 src/util/virnetlink.c: support libnl3 api. To minimize impact on code flow with #ifdefs as requested by Stefan Berger, do some #defines at the top. Unfortunately libnl3 moves

Re: [libvirt] [PATCH v6 2/9] util: add functions for interating over json object

2012-05-03 Thread Dmitry Guryanov
On 05/03/2012 07:08 PM, Eric Blake wrote: On 05/03/2012 04:10 AM, Daniel P. Berrange wrote: On Wed, May 02, 2012 at 10:32:37PM +0400, Dmitry Guryanov wrote: Add function virJSONValueObjectKeysNumber, virJSONValueObjectGetKey and virJSONValueObjectGetValue, which allow you to iterate over all

Re: [libvirt] [PATCH 1/1] support libnl-3 (v2)

2012-05-03 Thread Eric Blake
On 05/03/2012 11:55 AM, Stefan Berger wrote: +#ifdef HAVE_LIBNL1 +#define nl_alloc nl_handle_alloc +#define nl_free nl_handle_destroy +typedef struct nl_handle nlhandle_t; +#else +#define nl_alloc nl_socket_alloc +#define nl_free nl_socket_free +typedef struct nl_sock nlhandle_t; +#endif

Re: [libvirt] [PATCH 0/2] Rework RPC message buffer

2012-05-03 Thread Eric Blake
On 04/27/2012 07:22 AM, Michal Privoznik wrote: This patch set tries to fix corner cases where libvirt runs on huge system, e.g. 4K CPU monster. In these cases, capabilities XML is enormously big, as we are transferring info about each singe CPU core (to which NUMA node it belongs, etc.). This

Re: [libvirt] [PATCH 1/1] support libnl-3 (v2)

2012-05-03 Thread Serge Hallyn
Quoting Eric Blake (ebl...@redhat.com): On 05/03/2012 11:55 AM, Stefan Berger wrote: +#ifdef HAVE_LIBNL1 +#define nl_alloc nl_handle_alloc +#define nl_free nl_handle_destroy +typedef struct nl_handle nlhandle_t; +#else +#define nl_alloc nl_socket_alloc +#define nl_free

Re: [libvirt] [Qemu-devel] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-05-03 Thread Anthony Liguori
On 05/02/2012 04:45 AM, Kevin Wolf wrote: Am 02.05.2012 10:53, schrieb Daniel P. Berrange: I would much prefer to see us be able to pass FDs in directly alongside the disk config as we do for netdev TAP/etc, and for QEMU / kernel to be fixed so that you do not need to re-open FDs on the fly.

[libvirt] [PATCHv3] build: support libnl-3

2012-05-03 Thread Eric Blake
From: Serge Hallyn serge.hal...@canonical.com configure.ac: check for libnl-3 in addition to libnl-1 src/Makefile.am: link against libnl when needed src/util/virnetlink.c: support libnl3 api. To minimize impact on code flow, wrap the differences under the virNetlink* namespace. Unfortunately

Re: [libvirt] [PATCHv2] openvz: read vmguarpages/privvmpages to set memory tunables

2012-05-03 Thread Eric Blake
On 05/03/2012 11:13 AM, Guido Günther wrote: --- Changes since last time: * check sysconf return value before division * use virStrToLong_ull instead of sscanf O.k. to apply? Cheers, -- Guido ACK. +long kb_per_pages; +unsigned long long barrier, limit, val; + +

[libvirt] [PATCH] build: fix build on cygwin

2012-05-03 Thread Eric Blake
Now that tests are built unconditionally, this cases 'make' to fail on cygwin (previously, only 'make check' failed), since on cygwin, rpc/rpc.h lives in a different directory than /usr/include. * tests/Makefile.am (virnetmessagetest_CFLAGS): Find rpc headers. --- Pushing under the build-breaker

Re: [libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-05-03 Thread Eric Blake
On 05/03/2012 04:51 AM, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the exact match of the four parameters usbFindDeviceByBus():get usb device according to bus, device it returns only

Re: [libvirt] [PATCHv3] build: support libnl-3

2012-05-03 Thread Stefan Berger
On 05/03/2012 04:26 PM, Eric Blake wrote: From: Serge Hallynserge.hal...@canonical.com configure.ac: check for libnl-3 in addition to libnl-1 src/Makefile.am: link against libnl when needed src/util/virnetlink.c: support libnl3 api. To minimize impact on code flow, wrap the differences under

Re: [libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-05-03 Thread Eric Blake
On 05/03/2012 03:21 PM, Eric Blake wrote: On 05/03/2012 04:51 AM, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the exact match of the four parameters usbFindDeviceByBus():get usb device according to bus,

Re: [libvirt] [PATCHv3] build: support libnl-3

2012-05-03 Thread Eric Blake
On 05/03/2012 03:15 PM, Stefan Berger wrote: On 05/03/2012 04:26 PM, Eric Blake wrote: From: Serge Hallynserge.hal...@canonical.com configure.ac: check for libnl-3 in addition to libnl-1 src/Makefile.am: link against libnl when needed src/util/virnetlink.c: support libnl3 api. To

Re: [libvirt] [PATCH 2/7] Coverity: Fix resource leaks in phyp driver

2012-05-03 Thread Eric Blake
On 05/02/2012 08:51 AM, Osier Yang wrote: Coverity logs: Error: RESOURCE_LEAK: /builddir/build/BUILD/libvirt-0.9.10/src/phyp/phyp_driver.c:523: alloc_fn: Calling allocation function fopen. /builddir/build/BUILD/libvirt-0.9.10/src/phyp/phyp_driver.c:523: var_assign: Assigning: fd =

Re: [libvirt] [PATCHv3] build: support libnl-3

2012-05-03 Thread Serge Hallyn
Quoting Eric Blake (ebl...@redhat.com): On 05/03/2012 03:15 PM, Stefan Berger wrote: On 05/03/2012 04:26 PM, Eric Blake wrote: From: Serge Hallynserge.hal...@canonical.com configure.ac: check for libnl-3 in addition to libnl-1 src/Makefile.am: link against libnl when needed

Re: [libvirt] [PATCH 4/7] Coverity: Fix resource leak in xen driver

2012-05-03 Thread Eric Blake
On 05/02/2012 08:51 AM, Osier Yang wrote: Coverity logs: --- src/xen/xen_hypervisor.c |5 +++-- src/xen/xen_inotify.c|1 + 2 files changed, 4 insertions(+), 2 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

Re: [libvirt] [PATCH 08/12] Add an SELinux access control driver

2012-05-03 Thread Eric Blake
On 05/02/2012 05:44 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com sparse on the commit message (I sound like a broken record...) +++ b/src/Makefile.am @@ -537,7 +537,8 @@ ACCESS_DRIVER_SOURCES = \ access/viraccessdriver.h \

Re: [libvirt] [PATCH 09/12] Add ability to associate real/effective identity on virNetServerClientPtr

2012-05-03 Thread Eric Blake
On 05/02/2012 05:44 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add APIs which allow storage of a real effective identity on all server clients. Also add an API which allows creation of an initial identity based on the results of client authentication

[libvirt] [PATCH] qemu: avoid 32-bit compiler warning

2012-05-03 Thread Eric Blake
On 32-bit platforms, gcc warns that the comparison between a long and (ULLONG_MAX/1024/1024) is always false; throwing in a type conversion shuts up the warning. * src/qemu/qemu_monitor.c (qemuMonitorBlockJob): Shut gcc up. --- Pushing under the build-breaker rule. src/qemu/qemu_monitor.c |

Re: [libvirt] [PATCH 10/12] Set the identity for the access manager during API call dispatch

2012-05-03 Thread Eric Blake
On 05/02/2012 05:44 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When dispatching an RPC API call, setup the access manager to hold the real effective identities of the current server client whose RPC is being dispatched. The setting is thread-local, so only

Re: [libvirt] [PATCH 11/12] Add configuration to QEMU driver to support access control managers

2012-05-03 Thread Eric Blake
On 05/02/2012 05:44 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce a new 'access_driver' configuration parameter which specifies the name of the access control manager driver to activate. By default the 'no op' driver is active --- src/qemu/qemu.conf

Re: [libvirt] [PATCH 12/12] Insert access control checks for virDomainObjPtr into QEMU driver

2012-05-03 Thread Eric Blake
On 05/02/2012 05:44 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Inserts the minimal access control checks to the QEMU driver to protect usage of virDomainObjPtr objects. --- src/qemu/qemu_driver.c| 626 +++-- 600

[libvirt] [libvirt-glib 4/4] Add gvir_config_domain_os_get_boot_devices()

2012-05-03 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-os.c | 44 +++ libvirt-gconfig/libvirt-gconfig-domain-os.h |1 + libvirt-gconfig/libvirt-gconfig.sym |1 + 3 files changed, 46 insertions(+), 0 deletions(-) diff

[libvirt] [libvirt-glib 2/4] Add gvir_config_domain_get_os()

2012-05-03 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain.c | 18 ++ libvirt-gconfig/libvirt-gconfig-domain.h |1 + libvirt-gconfig/libvirt-gconfig.sym |5 + 3 files changed, 24 insertions(+), 0 deletions(-) diff --git

[libvirt] [libvirt-glib 1/4] More generic gvir_config_object_add_child()

2012-05-03 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gconfig/libvirt-gconfig-domain-channel.c |6 -- libvirt-gconfig/libvirt-gconfig-domain-console.c |3 ++- libvirt-gconfig/libvirt-gconfig-domain-disk.c | 18 --

[libvirt] [libvirt-glib 3/4] Allow unsetting of string object properties

2012-05-03 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Passing a 'NULL' value now deletes the corresponding node/tree. --- .../libvirt-gconfig-domain-chardev-source-pty.c|6 ++ .../libvirt-gconfig-domain-controller.c| 14 - libvirt-gconfig/libvirt-gconfig-domain-os.c|

Re: [libvirt] [PATCH 1/1] Correct indent errors in the function qemuDomainNetsRestart

2012-05-03 Thread Li Zhang
On 05/03/2012 05:25 PM, Osier Yang wrote: On 2012年05月03日 13:52, Li Zhang wrote: There are three spapces for a indent every line in the s/spapces/spaces/ function qemuDomainNetsRestart. This patch is to correct it. Signed-off-by: Li Zhangzhlci...@linux.vnet.ibm.com ---

Re: [libvirt] [libvirt-glib 2/3] Add host capabilities API

2012-05-03 Thread Zeeshan Ali (Khattak)
On Wed, May 2, 2012 at 5:25 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, May 01, 2012 at 08:30:39PM +0300, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Not quite complete but its a good start. CUT --- +/** + *

[libvirt] [PATCH 1/2] Add VSCSI bus type and VSCSI controller type for pseries guest.

2012-05-03 Thread Li Zhang
Now, there is only SCSI bus and controller type in libvirt. And when configuring VSCSI controller, it needs to configure the spapr-vio bus address type externally. It's a little inconvenient to configure the controller type. This patch is to add VSCSI bus type and VSCSI controller type. And

[libvirt] [PATCH 2/2] Modify interface qemuDefaultScsiControllerModel().

2012-05-03 Thread Li Zhang
Now, the libvirt sets the default module as 'ibmvscsi' for pseries, and 'lsi' for other platforms.The controller model should be set according to controller type, not only just the platform, otherwise, it will have to set controller's model externally to select right model for specific

Re: [libvirt] [PATCH 7/7] Coverity: Fix resource leak in virnetlink.c

2012-05-03 Thread Osier Yang
On 2012年05月03日 02:31, Eric Blake wrote: On 05/02/2012 08:51 AM, Osier Yang wrote: --- src/util/virnetlink.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) ACK. Thanks for the reviewing, pushed the set without 3/7, and FILE *fd = NULL squashed in 2/7 (yeah, strange to

Re: [libvirt] [PATCH 2/2] coverity: fd and memory leak in nodeinfo.c

2012-05-03 Thread Osier Yang
On 2012年05月04日 01:21, Eric Blake wrote: On 05/03/2012 09:28 AM, Guannan Ren wrote: --- src/nodeinfo.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index e842474..012f0f8 100644 --- a/src/nodeinfo.c +++

Re: [libvirt] [RFC 0/5] block: File descriptor passing using -open-hook-fd

2012-05-03 Thread Zhi Yong Wu
On Tue, May 1, 2012 at 11:31 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Libvirt can take advantage of SELinux to restrict the QEMU process and prevent it from opening files that it should not have access to.  This improves security because it prevents the attacker from escaping the

Re: [libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-05-03 Thread Guannan Ren
On 05/04/2012 05:38 AM, Eric Blake wrote: On 05/03/2012 03:21 PM, Eric Blake wrote: On 05/03/2012 04:51 AM, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the exact match of the four parameters

Re: [libvirt] [PATCH 1/3] usb: create functions to search usb device accurately

2012-05-03 Thread Osier Yang
On 2012年05月04日 12:39, Guannan Ren wrote: On 05/04/2012 05:38 AM, Eric Blake wrote: On 05/03/2012 03:21 PM, Eric Blake wrote: On 05/03/2012 04:51 AM, Guannan Ren wrote: usbFindDevice():get usb device according to idVendor, idProduct, bus, device it is the exact match of the four parameters