[libvirt] [PATCH v4 2/3] qemu: Add support for gluster protocol based network storage backend.

2012-11-22 Thread Harsh Prateek Bora
Qemu accepts gluster protocol as supported storage backend beside others. This patch allows users to specify disks on gluster backends like this: disk type='network' device='disk' driver name='qemu' type='raw'/ source protocol='gluster' name='Volume1/image' host

[libvirt] [PATCH v4 3/3] tests: Add tests for gluster protocol based network disks support

2012-11-22 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- tests/qemuargv2xmltest.c | 1 + .../qemuxml2argv-disk-drive-network-gluster.args | 1 + .../qemuxml2argv-disk-drive-network-gluster.xml| 34 ++ tests/qemuxml2argvtest.c

[libvirt] [PATCH v4 0/3] Qemu/Gluster support in Libvirt

2012-11-22 Thread Harsh Prateek Bora
Changelog: v4: - Addressed review comment by Jiri on v3 updated series. v3 updated: - Fix other network backends (nbd, rbd, sheepdog) to initialize new members (transport, socket) of _virDomainDiskHostDef appropriately so that garbage values doesnt break the argv2xml tests. v3: - RNG

[libvirt] [PATCH v4 1/3] Add Gluster protocol as supported network disk backend

2012-11-22 Thread Harsh Prateek Bora
This patch introduces the RNG schema and updates necessary data strucutures to allow various hypervisors to make use of Gluster protocol as one of the supported network disk backend. Next patch will add support to make use of this feature in Qemu since it now supports Gluster protocol as one of

Re: [libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-11-22 Thread Harsh Bora
On 11/16/2012 03:53 AM, Jiri Denemark wrote: On Fri, Oct 26, 2012 at 22:27:35 +0530, Harsh Prateek Bora wrote: Qemu accepts gluster protocol as supported storage backend beside others. This patch allows users to specify disks on gluster backends like this: disk type='network'

Re: [libvirt] [libvirt-glib v2] gobject: Also delete storage volume from its pool's list

2012-11-22 Thread Christophe Fergeau
On Wed, Nov 21, 2012 at 08:04:36PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Without this patch, storage pool still lists the volume even after it is deleted. Related Boxes bug: https://bugzilla.gnome.org/show_bug.cgi?id=688724 ---

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-22 Thread Martin Kletzander
On 11/21/2012 11:50 PM, Doug Goldstein wrote: On Wed, Nov 21, 2012 at 10:13 AM, Martin Kletzander mklet...@redhat.com wrote: On 11/21/2012 05:06 PM, Ján Tomko wrote: On 11/21/12 16:37, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for

[libvirt] [PATCH] virsh: Report error when taking a snapshot with empty --memspec argument

2012-11-22 Thread Peter Krempa
When the value of memspec was empty taking of a snapshot failed without reporting an error. --- This is only a quick fix. I think we should improve vshCommandOptStr to detect this for us and report an appropriate error, but this change will require a lot of changes not relevant to this problem.

Re: [libvirt] [PATCH] Add device operations for lxc v1

2012-11-22 Thread Daniel P. Berrange
On Wed, Oct 24, 2012 at 11:38:25AM +0800, Heiher wrote: Hello, Operations: 1. lxcDomainAttachDevice 2. lxcDomainAttachDeviceFlags 3. lxcDomainDetachDevice 4. lxcDomainDetachDeviceFlags 5. lxcDomainUpdateDeviceFlags In live mode, set devices.allow/deny to instance's cgroup and

Re: [libvirt] [PATCH] Correct include-password option for domdisplay

2012-11-22 Thread Ján Tomko
On 11/22/12 11:03, Martin Kletzander wrote: I'll rework it to make it as URI as possible then. Just one question, though (for anyone, I guess); why do we append port as a parameter for spice scheme? Martin I think it's because of what spicy supported initially (since v0.1.0):

Re: [libvirt] [PATCH] virsh: Report error when taking a snapshot with empty --memspec argument

2012-11-22 Thread Martin Kletzander
On 11/22/2012 11:03 AM, Peter Krempa wrote: When the value of memspec was empty taking of a snapshot failed without reporting an error. --- This is only a quick fix. I think we should improve vshCommandOptStr to detect this for us and report an appropriate error, but this change will require

Re: [libvirt] [PATCH] qemu: Stop recursive detection of image chains when an image is missing

2012-11-22 Thread Peter Krempa
On 11/21/12 15:14, Eric Blake wrote: On 11/21/2012 04:05 AM, Peter Krempa wrote: Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection of image chain wasn't complete. Iteration through the backing image chain has to stop at the last existing image if some of the images are

Re: [libvirt] [PATCH v2] Correct include-password option and rewrite domdisplay

2012-11-22 Thread Peter Krempa
On 11/22/12 11:34, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for spice, but it was missing for vnc type graphics. Also, there were some inconsistencies that are cleaned now. --- tools/virsh-domain.c | 74

Re: [libvirt] [PATCH v2] conf: Report sensible error for invalid disk name

2012-11-22 Thread Peter Krempa
On 11/20/12 16:20, Martin Kletzander wrote: The error ... but the cause is unknown appeared for XMLs similar to this: disk type='file' device='cdrom' driver name='qemu' type='raw'/ source file='/dev/zero'/ target dev='sr0'/ /disk Notice unsupported disk type (for the driver),

[libvirt] [PATCH] build: trivial fix error: implicit declaration of function 'malloc'

2012-11-22 Thread Natanael Copa
Fixes this error when building with -Werror on Alpine Linux: util/processinfo.c: In function 'virProcessInfoSetAffinity': util/processinfo.c:52:5: error: implicit declaration of function 'malloc' [-Werror=implicit-function-declaration] Signed-off-by: Natanael Copa nc...@alpinelinux.org ---

Re: [libvirt] [PATCH] virsh: Report error when taking a snapshot with empty --memspec argument

2012-11-22 Thread Peter Krempa
On 11/22/12 12:09, Martin Kletzander wrote: On 11/22/2012 11:03 AM, Peter Krempa wrote: When the value of memspec was empty taking of a snapshot failed without reporting an error. --- tools/virsh-snapshot.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-11-22 Thread Eric Blake
On 11/22/2012 01:49 AM, Harsh Bora wrote: +transp = strstr(uri-scheme, +); strstr() for a single-byte needle is overkill. +transp++; You could even squash the increment into the previous line :-) That would give me: qemu/qemu_command.c: In function

Re: [libvirt] [PATCH] build: trivial fix error: implicit declaration of function 'malloc'

2012-11-22 Thread Daniel P. Berrange
On Thu, Nov 22, 2012 at 01:28:08PM +0100, Natanael Copa wrote: Fixes this error when building with -Werror on Alpine Linux: util/processinfo.c: In function 'virProcessInfoSetAffinity': util/processinfo.c:52:5: error: implicit declaration of function 'malloc'

[libvirt] [PATCHv2] virsh: Report error when taking a snapshot with empty --memspec argument

2012-11-22 Thread Peter Krempa
When the value of memspec was empty taking of a snapshot failed without reporting an error. --- tools/virsh-snapshot.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 398730c..8ec6456 100644 ---

Re: [libvirt] [PATCH] qemu: Stop recursive detection of image chains when an image is missing

2012-11-22 Thread Eric Blake
On 11/22/2012 04:26 AM, Peter Krempa wrote: +++ b/src/util/storage_file.c @@ -729,6 +729,8 @@ virStorageFileGetMetadataFromBuf(int format, if (meta-backingStore == NULL) { /* the backing file is (currently) unavailable, treat this

Re: [libvirt] [PATCH v2] Correct include-password option and rewrite domdisplay

2012-11-22 Thread Martin Kletzander
On 11/22/2012 02:10 PM, Peter Krempa wrote: On 11/22/12 11:34, Martin Kletzander wrote: The 'virsh domdisplay' command is able to display the password configured for spice, but it was missing for vnc type graphics. Also, there were some inconsistencies that are cleaned now. --- [...] +

Re: [libvirt] [PATCH] build: trivial fix error: implicit declaration of function 'malloc'

2012-11-22 Thread Natanael Copa
On Thu, 22 Nov 2012 13:36:14 + Daniel P. Berrange berra...@redhat.com wrote: On Thu, Nov 22, 2012 at 01:28:08PM +0100, Natanael Copa wrote: Fixes this error when building with -Werror on Alpine Linux: ... --- a/src/util/processinfo.c +++ b/src/util/processinfo.c @@ -21,6 +21,7 @@

Re: [libvirt] [PATCH] build: trivial fix error: implicit declaration of function 'malloc'

2012-11-22 Thread Eric Blake
On 11/22/2012 06:36 AM, Daniel P. Berrange wrote: util/processinfo.c: In function 'virProcessInfoSetAffinity': util/processinfo.c:52:5: error: implicit declaration of function 'malloc' [-Werror=implicit-function-declaration] mask = CPU_ALLOC(numcpus); On glibc this is defined to a

Re: [libvirt] [PATCH] build: trivial fix error: implicit declaration of function 'malloc'

2012-11-22 Thread Eric Blake
On 11/22/2012 06:46 AM, Natanael Copa wrote: If your headers are defining this in terms of malloc(), then IMHO, the sched.h should be including stdlib.h on our behalf. IOW, I think this is a bug in the c library headers You are right. uclibc does this: #if 0 /* in uClibc we use macros */

[libvirt] [PATCH] util: refactor iptables command construction into multiple steps

2012-11-22 Thread Natanael Copa
Instead of creating an iptables command in one shot, do it in steps so we can add conditional options like physdev and protocol. This removes code duplication while keeping existing behaviour. Signed-off-by: Natanael Copa nc...@alpinelinux.org --- This started with me wanting to add support for

[libvirt] [PATCH] cpu: Add Intel Haswell cpu model

2012-11-22 Thread Peter Krempa
The new model supports following features in addition to those supported by SandyBridge: fma, movbe, fsgsbase, bmi1, hle, avx2, smep, bmi2, erms, invpcid, rtm --- Based on: https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg01328.html --- src/cpu/cpu_map.xml | 16 1 file

[libvirt] RFC: Enable unprivileged SG_IO

2012-11-22 Thread Osier Yang
Hi, http://lwn.net/Articles/524720/ introduces new sysfs knob (unpriv_sgio) for SCSI device to allow the unprivileged SG_IO. I don't have solid thought on how the libvirt interface should be yet. It shouldn't be a XML entry of disk device, as the device can be shared by multiple guests, and the

Re: [libvirt] [PATCH] qemu: Stop recursive detection of image chains when an image is missing

2012-11-22 Thread Peter Krempa
On 11/22/12 14:44, Eric Blake wrote: On 11/22/2012 04:26 AM, Peter Krempa wrote: +++ b/src/util/storage_file.c @@ -729,6 +729,8 @@ virStorageFileGetMetadataFromBuf(int format, if (meta-backingStore == NULL) { /* the backing file is (currently)

Re: [libvirt] [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

2012-11-22 Thread Harsh Bora
On 11/22/2012 07:05 PM, Eric Blake wrote: On 11/22/2012 01:49 AM, Harsh Bora wrote: +transp = strstr(uri-scheme, +); strstr() for a single-byte needle is overkill. +transp++; You could even squash the increment into the previous line :-) That would give me:

Re: [libvirt] RFC: Enable unprivileged SG_IO

2012-11-22 Thread Daniel P. Berrange
On Thu, Nov 22, 2012 at 10:11:01PM +0800, Osier Yang wrote: Hi, http://lwn.net/Articles/524720/ introduces new sysfs knob (unpriv_sgio) for SCSI device to allow the unprivileged SG_IO. I don't have solid thought on how the libvirt interface should be yet. It shouldn't be a XML entry of

Re: [libvirt] RFC: Enable unprivileged SG_IO

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 15:11, Osier Yang ha scritto: Hi, http://lwn.net/Articles/524720/ introduces new sysfs knob (unpriv_sgio) for SCSI device to allow the unprivileged SG_IO. I don't have solid thought on how the libvirt interface should be yet. It shouldn't be a XML entry of disk device, as

Re: [libvirt] [PATCH v2] conf: Report sensible error for invalid disk name

2012-11-22 Thread Martin Kletzander
On 11/22/2012 02:16 PM, Peter Krempa wrote: On 11/20/12 16:20, Martin Kletzander wrote: The error ... but the cause is unknown appeared for XMLs similar to this: disk type='file' device='cdrom' driver name='qemu' type='raw'/ source file='/dev/zero'/ target dev='sr0'/ /disk

Re: [libvirt] RFC: Enable unprivileged SG_IO

2012-11-22 Thread Osier Yang
On 2012年11月22日 22:20, Paolo Bonzini wrote: Il 22/11/2012 15:11, Osier Yang ha scritto: Hi, http://lwn.net/Articles/524720/ introduces new sysfs knob (unpriv_sgio) for SCSI device to allow the unprivileged SG_IO. I don't have solid thought on how the libvirt interface should be yet. It

Re: [libvirt] RFC: Enable unprivileged SG_IO

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 15:19, Daniel P. Berrange ha scritto: What Paolo suggested is to add an entry in qemu.conf, just like cgroup_device_acl: sgio_device_acl = [ /dev/sda ] When libvirtd starting, set the sysfs knob unpriv_sgio of the devices listed to 1, and 0 when libvirtd exists. I don't

[libvirt] [PATCHv2] qemu: Stop recursive detection of image chains when an image is missing

2012-11-22 Thread Peter Krempa
Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection of image chain wasn't complete. Iteration through the backing image chain has to stop at the last existing image if some of the images are missing otherwise the backing chain that is cached contains entries with paths being

Re: [libvirt] [PATCH] cpu: Add Intel Haswell cpu model

2012-11-22 Thread Martin Kletzander
On 11/22/2012 03:05 PM, Peter Krempa wrote: The new model supports following features in addition to those supported by SandyBridge: fma, movbe, fsgsbase, bmi1, hle, avx2, smep, bmi2, erms, invpcid, rtm missing 'pcid' flag --- Based on:

Re: [libvirt] [PATCHv2] qemu: Stop recursive detection of image chains when an image is missing

2012-11-22 Thread Eric Blake
On 11/22/2012 07:50 AM, Peter Krempa wrote: Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection of image chain wasn't complete. Iteration through the backing image chain has to stop at the last existing image if some of the images are missing otherwise the backing chain

Re: [libvirt] [PATCH] build: trivial fix error: implicit declaration of function 'malloc'

2012-11-22 Thread Natanael Copa
On Thu, 22 Nov 2012 06:53:12 -0700 Eric Blake ebl...@redhat.com wrote: On 11/22/2012 06:46 AM, Natanael Copa wrote: If your headers are defining this in terms of malloc(), then IMHO, the sched.h should be including stdlib.h on our behalf. IOW, I think this is a bug in the c library headers

Re: [libvirt] [PATCHv2] qemu: Stop recursive detection of image chains when an image is missing

2012-11-22 Thread Peter Krempa
On 11/22/12 16:02, Eric Blake wrote: On 11/22/2012 07:50 AM, Peter Krempa wrote: Commit e0c469e58b93f852a72265919703cb6abd3779f8 that fixes the detection of image chain wasn't complete. Iteration through the backing image chain has to stop at the last existing image if some of the images are

[libvirt] [PATCH v2] virsh: Rewrite cmdDomDisplay

2012-11-22 Thread Martin Kletzander
Just a little rewrite of the cmdDomDisplay function to make it consistent and hopefully more readable. This also fixes a problem with password not being displayed for vnc even with the --include-password option. --- tools/virsh-domain.c | 132 +--

Re: [libvirt] [PATCH] cpu: Add Intel Haswell cpu model

2012-11-22 Thread Peter Krempa
On 11/22/12 15:52, Martin Kletzander wrote: On 11/22/2012 03:05 PM, Peter Krempa wrote: The new model supports following features in addition to those supported by SandyBridge: fma, movbe, fsgsbase, bmi1, hle, avx2, smep, bmi2, erms, invpcid, rtm missing 'pcid' flag Ah, yeah, thanks for

Re: [libvirt] [PATCH] util: refactor iptables command construction into multiple steps

2012-11-22 Thread Natanael Copa
On Thu, 22 Nov 2012 15:02:18 +0100 Natanael Copa nc...@alpinelinux.org wrote: Instead of creating an iptables command in one shot, do it in steps so we can add conditional options like physdev and protocol. This removes code duplication while keeping existing behaviour. Signed-off-by:

[libvirt] QMP Capability Detection Issues with GIT version of QEMU

2012-11-22 Thread Viktor Mihajlovski
I ran into trouble today trying to use the GIT level of QEMU. In a nutshell: the capability detection with QMP is failing and the fallback using -help isn't working with the GIT level probably due to help text reformatting. The failure reason is that QEMU cannot bind to the QMP monitor socket

[libvirt] [PATCH 0/6] Misc unrelated fixes

2012-11-22 Thread Daniel P. Berrange
The following are miscellaneous patches fixes various issues I've come across today, while hacking on LXC -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/6] Fix virDiskNameToIndex to actually ignore partition numbers

2012-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The docs for virDiskNameToIndex claim it ignores partition numbers. In actual fact though, a code ordering buy means that a partition number will cause the code to accidentally multiply the result by 26. Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH 2/6] Warn if requesting update to non-existant timer/handle watch

2012-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The event code is a no-op if requested to update a non-existant timer/handle watch. This makes it hard to detect bugs in the caller who have passed bogus data. Add a VIR_WARN output in such cases, since the API does not allow for return errors.

[libvirt] [PATCH 4/6] Fix exiting of libvirt_lxc program on container quit

2012-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virLXCControllerClientCloseHook method was mistakenly assuming that the private data associated with the network client was the virLXCControllerPtr. In fact it was just a dummy int, so we were derefencing a bogus struct. The frequent result of this

[libvirt] [PATCH 3/6] Skip deleted timers when calculting next timeout

2012-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com It is possible for there to be deleted timers when we calculate the next timeout, and they must be skipped. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/event_poll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[libvirt] [PATCH 5/6] Fix error handling in virSecurityManagerGetMountOptions

2012-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The impls of virSecurityManagerGetMountOptions had no way to return errors, since the code was treating 'NULL' as a success value. This is somewhat pointless, since the calling code did not want NULL in the first place and has to translate it into the

[libvirt] [PATCH 6/6] Pass virSecurityManagerPtr object further down into LXC setup code

2012-11-22 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently the lxcContainerSetupMounts method uses the virSecurityManagerPtr instance to obtain the mount options string and then only passes the string down into methods it calls. As functionality in LXC grows though, those methods need to have direct

Re: [libvirt] QMP Capability Detection Issues with GIT version of QEMU

2012-11-22 Thread Daniel P. Berrange
On Thu, Nov 22, 2012 at 05:41:30PM +0100, Viktor Mihajlovski wrote: I ran into trouble today trying to use the GIT level of QEMU. In a nutshell: the capability detection with QMP is failing and the fallback using -help isn't working with the GIT level probably due to help text reformatting.

Re: [libvirt] QMP Capability Detection Issues with GIT version of QEMU

2012-11-22 Thread Viktor Mihajlovski
On 11/22/2012 05:50 PM, Daniel P. Berrange wrote: 3. Run the QMP QEMU under the configured qemu user. This would be my favorite. Yep, this seems like the right thing todo. OK, I'll go for it :-). /me tries to understand why I didn't see this problem myself. Daniel This happens

[libvirt] [PATCH v5 4/4] tests: Add tests for gluster protocol based network disks support

2012-11-22 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- tests/qemuargv2xmltest.c | 1 + .../qemuxml2argv-disk-drive-network-gluster.args | 1 + .../qemuxml2argv-disk-drive-network-gluster.xml| 34 ++ tests/qemuxml2argvtest.c

[libvirt] [PATCH v5 3/4] qemu: Fix nbd, rbd, sheepdog to initialize defaults for new host members.

2012-11-22 Thread Harsh Prateek Bora
struct _virDomainDiskHostDef recently got new members to support transport and socket attributes. Consumers of this struct therefore needs to initialize default values for them. This patch initializes default values for transport and socket for nbd, rbd and sheepdog storage backends.

[libvirt] [PATCH v5 2/4] qemu: Add support for gluster protocol based network storage backend.

2012-11-22 Thread Harsh Prateek Bora
Qemu accepts gluster protocol as supported storage backend beside others. This patch allows users to specify disks on gluster backends like this: disk type='network' device='disk' driver name='qemu' type='raw'/ source protocol='gluster' name='Volume1/image' host

[libvirt] [PATCH v5 0/4] Qemu/Gluster support in Libvirt

2012-11-22 Thread Harsh Prateek Bora
Changelog: v5: - Separated initialization of new host members for nbd, rbd, sheepdog in a separate patch [Patch 3/4] - Fixed tests for appropriate args to DO_TEST - Code cleanups for squashing pointer incrememnts into single line. v4: - Addressed review comment by Jiri on v3 updated series.

[libvirt] [PATCH v5 1/4] Add Gluster protocol as supported network disk backend

2012-11-22 Thread Harsh Prateek Bora
This patch introduces the RNG schema and updates necessary data strucutures to allow various hypervisors to make use of Gluster protocol as one of the supported network disk backend. Next patch will add support to make use of this feature in Qemu since it now supports Gluster protocol as one of

Re: [libvirt] [PATCH 2/3] v7.1 add support for DHCPv6

2012-11-22 Thread Gene Czarcinski
On 11/22/2012 02:21 PM, Gene Czarcinski wrote: On 11/21/2012 04:18 PM, Gene Czarcinski wrote: The DHCPv6 support includes IPV6 dhcp-range and dhcp-host for one IPv6 subnetwork on one interface. This support will only work if dnsmasq version = 2.64; otherwise an error occurs if dhcp-range or

Re: [libvirt] [PATCH 2/6] Warn if requesting update to non-existant timer/handle watch

2012-11-22 Thread Peter Krempa
s/non-existant/non-existent/ in the subject On 11/22/12 17:48, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The event code is a no-op if requested to update a non-existant s/non-existant/non-existent/ timer/handle watch. This makes it hard to detect bugs in the

[libvirt] [PATCH v1 2/2][RFC] help to create disk images of non-shared migration

2012-11-22 Thread liguang
try to do non-shared migration without bothering to create disk images at target by hand. consider this situation: 1. non-shared migration virsh migrate --copy-storage-all ... 2. migration fails 3. create disk images required qemu-img create ... 4 migration run smoothly so, try do remove

[libvirt] Remote connection to KVM hypervisor failed using libvirt 0.10.2

2012-11-22 Thread Ido Levy
Hello, I compiled libvirt 0.10.2 from source providing extra parameters to the configure procedure to support phyp and hyper-v driver support, and python binding. When running virsh from the tools directory (libvirt-0.10.2/tools) and trying to connect to remote KVM hypervisor using connect

Re: [libvirt] [PATCH v1 2/2][RFC] help to create disk images of non-shared migration

2012-11-22 Thread li guang
Hi, Doug for your comment, I changed to use virDomainGetBlockInfo() to prepare disk images for non-shared migration, but, it really looks ugly and doesn't make much sense. what's your opinion? 在 2012-11-23五的 13:28 +0800,liguang写道: try to do non-shared migration without bothering to create

[libvirt] [PATCH] bitmap: fix typo to use UL type of integer constant in virBitmapIsAllSet

2012-11-22 Thread Guannan Ren
This bug leads to get incorrect vcpupin information via qemudDomainGetVcpuPinInfo() API when the number of maximum cpu on a host falls into a scope such as 31 ncpus 64. gcc warning: left shift count = width of type The following bug is such a case

[libvirt] [PATCH] node_device: Fix the improper logic when enumerating SRIOV VF

2012-11-22 Thread Osier Yang
pciGetVirtualFunctions returns 0 even if there is no virtfn entry under the device sysfs path. And pciGetVirtualFunctions returns -1 when it tries to get the PCI config space of the VF, however, with keeping the the VFs already detected. That's why udevProcessPCI and gather_pci_cap use logic

Re: [libvirt] Remote connection to KVM hypervisor failed using libvirt 0.10.2

2012-11-22 Thread Osier Yang
On 2012年11月23日 13:43, Ido Levy wrote: Hello, I compiled libvirt 0.10.2 from source providing extra parameters to the configure procedure to support phyp and hyper-v driver support, and python binding. When running virsh from the tools directory (libvirt-0.10.2/tools) and trying to connect to