Re: [libvirt] [PATCH 5/7] Fix conditional build of virNetDevSetupControlFull

2013-03-08 Thread Peter Krempa
On 03/07/13 19:10, Daniel P. Berrange wrote: On Thu, Mar 07, 2013 at 06:34:04PM +0100, Peter Krempa wrote: On 03/07/13 17:41, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virNetDevSetupControlFull function was protected by a Part of the sentence missing?

Re: [libvirt] [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-08 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an

Re: [libvirt] failed to mount cgroup

2013-03-08 Thread Yin Olivia-R63875
Thanks, It works now. Best Regards, Olivia -Original Message- From: Gao feng [mailto:gaof...@cn.fujitsu.com] Sent: Thursday, March 07, 2013 4:58 PM To: Yin Olivia-R63875 Cc: libvir-list@redhat.com Subject: Re: [libvirt] failed to mount cgroup On 2013/03/07 16:45, Yin

Re: [libvirt] how virbr0-nic is created

2013-03-08 Thread Michal Privoznik
On 08.03.2013 08:40, yue wrote: libvirt has a default NAT network, it create a bridge based on virbr0-nic, how virbr0-nic is created? thanks It's created in networkStartNetworkVirtual and subsequent functions which all boils down to: fd = open(/dev/net/tun, O_RDWR)); in

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Markus Armbruster
Osier Yang jy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most of the cases). If it's too long, it will be a problem for management, because it looks like hanging. We can

[libvirt] [PATCH 0/2] Proper fix for xmlSaveToBuffer missing on RHEL4

2013-03-08 Thread Peter Krempa
The original fix for one of the issues was done by defining a missing symbol from libxml2. The fix is not needed as the code using the function is never used. Revert the fix and remove the unused offending function instead. Peter Krempa (2): Revert Ensure xmlSaveToBuffer is always defined

[libvirt] [PATCH 2/2] virsh-domain: Remove unused vshCompleteXMLFromDomain

2013-03-08 Thread Peter Krempa
The function is marked as unused and breaks compilation on RHEL4. Remove it from the tree until a new use case can be found. --- tools/virsh-domain.c | 128 --- 1 file changed, 128 deletions(-) diff --git a/tools/virsh-domain.c

[libvirt] [PATCH 1/2] Revert Ensure xmlSaveToBuffer is always defined

2013-03-08 Thread Peter Krempa
The commit originally fixed code that isn't being used. Revert it and remove the unused code as a real fix. This reverts commit a66b32d9295ed87698ffd98d82e9e5818ff799e5. --- tools/virsh-domain.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/tools/virsh-domain.c

[libvirt] [libvirt-sandbox][PATCH] docs: fix some typos in architecture.txt

2013-03-08 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- docs/architecture.txt | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/architecture.txt b/docs/architecture.txt index 16bffad..c227cbd 100644 --- a/docs/architecture.txt +++ b/docs/architecture.txt @@ -17,7

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Jiri Denemark
On Fri, Mar 08, 2013 at 09:50:55 +0100, Markus Armbruster wrote: Osier Yang jy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most of the cases). If it's too long, it will

[libvirt] [libvirt-sandbox][PATCH] docs: fix some typos in TODO

2013-03-08 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- TODO |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/TODO b/TODO index 1ac37a0..fc63361 100644 --- a/TODO +++ b/TODO @@ -12,10 +12,10 @@ If we run a syslog within the container will it get messages from the outside?

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Osier Yang
On 2013年03月08日 17:25, Jiri Denemark wrote: On Fri, Mar 08, 2013 at 09:50:55 +0100, Markus Armbruster wrote: Osier Yangjy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Osier Yang
On 2013年03月08日 16:50, Markus Armbruster wrote: Osier Yangjy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for most of the cases). If it's too long, it will be a problem for

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-08 Thread Osier Yang
On 2013年03月08日 18:37, Osier Yang wrote: On 2013年03月08日 17:25, Jiri Denemark wrote: On Fri, Mar 08, 2013 at 09:50:55 +0100, Markus Armbruster wrote: Osier Yangjy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can

[libvirt] [PATCH] qemuDomainBlockStatsFlags: Guard disk lookup with a domain job

2013-03-08 Thread Michal Privoznik
When there are two concurrent threads, we may dereference a NULL pointer, even though it has been checked before: 1. Thread1: starts executing qemuDomainBlockStatsFlags() with nparams != 0. It finds given disk and successfully pass check for disk-info.alias not being NULL.

Re: [libvirt] [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event

2013-03-08 Thread Anthony Liguori
Markus Armbruster arm...@redhat.com writes: Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does

Re: [libvirt] [PATCH] qemuDomainBlockStatsFlags: Guard disk lookup with a domain job

2013-03-08 Thread Peter Krempa
On 03/08/13 13:20, Michal Privoznik wrote: When there are two concurrent threads, we may dereference a NULL pointer, even though it has been checked before: 1. Thread1: starts executing qemuDomainBlockStatsFlags() with nparams != 0. It finds given disk and successfully pass check

Re: [libvirt] [PATCH] qemuDomainBlockStatsFlags: Guard disk lookup with a domain job

2013-03-08 Thread Michal Privoznik
On 08.03.2013 14:46, Peter Krempa wrote: On 03/08/13 13:20, Michal Privoznik wrote: When there are two concurrent threads, we may dereference a NULL pointer, even though it has been checked before: 1. Thread1: starts executing qemuDomainBlockStatsFlags() with nparams != 0. It

[libvirt] Mentors and project ideas wanted for GSoC 2013

2013-03-08 Thread Stefan Hajnoczi
QEMU will apply to Google Summer of Code 2013 on Monday 18th March. We need the have project ideas ready as part of QEMU's application as a GSoC 2013 organization. The wiki is still sparse so I'm asking that everyone posts their project ideas: http://wiki.qemu.org/Google_Summer_of_Code_2013

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-08 Thread Dusty Mabe
On Thu, Mar 7, 2013 at 11:03 AM, Dusty Mabe dustym...@gmail.com wrote: --- docs/schemas/capability.rng | 10 src/conf/capabilities.c | 8 +++ src/conf/capabilities.h | 2 + src/nodeinfo.c| 58

[libvirt] [PATCH] lxc: include sys/{types,stat}.h

2013-03-08 Thread Guido Günther
This fixes the build on Debian Wheezy which otherwise fails with: CC libvirt_driver_lxc_impl_la-lxc_process.lo lxc/lxc_process.c: In function 'virLXCProcessGetNsInode': lxc/lxc_process.c:648:5: error: implicit declaration of function 'stat' [-Werror=implicit-function-declaration]

Re: [libvirt] [PATCH 0/2] Proper fix for xmlSaveToBuffer missing on RHEL4

2013-03-08 Thread Eric Blake
On 03/08/2013 02:15 AM, Peter Krempa wrote: The original fix for one of the issues was done by defining a missing symbol from libxml2. The fix is not needed as the code using the function is never used. Revert the fix and remove the unused offending function instead. ACK series. Peter

Re: [libvirt] [PATCH] lxc: include sys/{types,stat}.h

2013-03-08 Thread Eric Blake
On 03/08/2013 09:40 AM, Guido Günther wrote: This fixes the build on Debian Wheezy which otherwise fails with: CC libvirt_driver_lxc_impl_la-lxc_process.lo lxc/lxc_process.c: In function 'virLXCProcessGetNsInode': lxc/lxc_process.c:648:5: error: implicit declaration of function

Re: [libvirt] [PATCH] lxc: include sys/{types,stat}.h

2013-03-08 Thread Guido Günther
On Fri, Mar 08, 2013 at 11:02:47AM -0700, Eric Blake wrote: On 03/08/2013 09:40 AM, Guido Günther wrote: This fixes the build on Debian Wheezy which otherwise fails with: CC libvirt_driver_lxc_impl_la-lxc_process.lo lxc/lxc_process.c: In function 'virLXCProcessGetNsInode':

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-08 Thread Eric Blake
On 03/07/2013 09:03 AM, Dusty Mabe wrote: --- The commit message should mention the XML changes being made. I'm modifying it to capture this snippet of your testcase: topology cells num='2' cell id='0' memory unit='KiB'12572412/memory cpus num='12'

Re: [libvirt] [PATCH] Add NUMA memory information to virsh capabilities output.

2013-03-08 Thread Dusty Mabe
On Fri, Mar 8, 2013 at 1:50 PM, Eric Blake ebl...@redhat.com wrote: ACK once this is squashed in, so I pushed it. Thanks again for the patch, and for persisting with addressing our feedback, even if it took a while. Thanks Eric and Dan! Dusty -- libvir-list mailing list