[libvirt] One problem of libvirt for fc18.

2013-03-12 Thread Li Zhang
Hi all, We are trying to compile libvirt on fc18. But it always reports such a problem with rpcgen. make fails: GEN lxc/lxc_monitor_protocol.h /usr/bin/rpcgen: C preprocessor failed with exit code 1 cannot shutdown /usr/bin/rpcgen: at ./rpc/genprotocol.pl line 124. make[2]: ***

Re: [libvirt] [PATCH] docs: Clarify semantics of sparse storage volumes

2013-03-12 Thread Jiri Denemark
On Mon, Mar 11, 2013 at 09:48:45 -0600, Eric Blake wrote: On 03/11/2013 07:46 AM, Jiri Denemark wrote: Sparse LVM volumes do not behave in the way one would naively expect. The allocation does not automatically increase (which is different from how sparse files work). ---

[libvirt] [PATCH] qemu: Avoid NULL dereference in qemuSharedDiskEntryFree

2013-03-12 Thread Jiri Denemark
At least one caller may call qemuSharedDiskEntryFree with NULL as the first argument. Let's make the function similar to other *Free functions and do nothing in such case. --- src/qemu/qemu_conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c

Re: [libvirt] [PATCH] qemu: Avoid NULL dereference in qemuSharedDiskEntryFree

2013-03-12 Thread Peter Krempa
On 03/12/13 09:13, Jiri Denemark wrote: At least one caller may call qemuSharedDiskEntryFree with NULL as the first argument. Let's make the function similar to other *Free functions and do nothing in such case. --- src/qemu/qemu_conf.c | 3 +++ 1 file changed, 3 insertions(+) ACK. Peter

Re: [libvirt] [PATCH] qemu: Avoid NULL dereference in qemuSharedDiskEntryFree

2013-03-12 Thread Jiri Denemark
On Tue, Mar 12, 2013 at 09:32:16 +0100, Peter Krempa wrote: On 03/12/13 09:13, Jiri Denemark wrote: At least one caller may call qemuSharedDiskEntryFree with NULL as the first argument. Let's make the function similar to other *Free functions and do nothing in such case. ---

Re: [libvirt] [Qemu-devel] [RFC] qcow3 format in libvirt

2013-03-12 Thread Kevin Wolf
Am 11.03.2013 um 19:03 hat Ján Tomko geschrieben: On 03/04/2013 04:40 PM, Kevin Wolf wrote: Am 04.03.2013 um 16:19 hat Daniel P. Berrange geschrieben: On Mon, Mar 04, 2013 at 04:05:50PM +0100, Kevin Wolf wrote: I'm not talking about the QEMU cli, but about qcow2 as the format as defined

[libvirt] Libvirt and qemu multiqueue net

2013-03-12 Thread Michal Privoznik
It's been a while since qemu added support for multiqueue virtio-net. For more info follow [1]. From usage POV, libvirt is required to pass multiple FDs: qemu-kvm -netdev tap,id=hn0,fds=x:y:...:z,vhost=on,vhostfds=a:b:...:c -device virtio-net-pci,netdev=hn0,vectors=N ... where count(x:...:z) =

Re: [libvirt] [libvirt-glib PATCHv2] Remove FSF address from source file headers

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 01:59:27PM +0100, Christophe Fergeau wrote: The FSF moved a while ago which made the address we use in every source file header invalid. Follow the recommendation from http://www.gnu.org/licenses/gpl-howto.html and don't put any address in these headers, just a link to

Re: [libvirt] One problem of libvirt for fc18.

2013-03-12 Thread Michal Privoznik
On 12.03.2013 07:45, Li Zhang wrote: Hi all, We are trying to compile libvirt on fc18. But it always reports such a problem with rpcgen. make fails: GEN lxc/lxc_monitor_protocol.h /usr/bin/rpcgen: C preprocessor failed with exit code 1 cannot shutdown /usr/bin/rpcgen: at

Re: [libvirt] [PATCH] audit: Audit operations done by using VirtIO RNG

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 05:19:36PM +0100, Peter Krempa wrote: This patch adds auditing of resources used by the 'random' backend of virtio RNG. --- If there's desire to audit also use of the egd backend that uses a generic character device, a way how to audit this device will need to be

Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-12 Thread Stefan Berger
On 03/11/2013 05:36 PM, Eric Blake wrote: On 03/07/2013 11:14 AM, Stefan Berger wrote: serial type='dev' source path='/dev/ttyS0'/ target port='0'/ /serial serial type='pipe' source path='/tmp/testpipe'/ target port='1'/ /serial And here, these

Re: [libvirt] [PATCH] audit: Audit operations done by using VirtIO RNG

2013-03-12 Thread Peter Krempa
On 03/12/13 12:19, Daniel P. Berrange wrote: On Mon, Mar 11, 2013 at 05:19:36PM +0100, Peter Krempa wrote: This patch adds auditing of resources used by the 'random' backend of virtio RNG. --- If there's desire to audit also use of the egd backend that uses a generic character device, a way how

Re: [libvirt] [PATCH] util: escapes special characters in VIR_LOG_REGEX

2013-03-12 Thread Guannan Ren
On 03/09/2013 10:49 PM, Guannan Ren wrote: In debug mode, the bug failed to start vm error: Failed to start domain rhel5u9 error: internal error Out of space while reading console log output: ... --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [libvirt-sandbox][PATCH] docs: fix some typos in TODO

2013-03-12 Thread Daniel P. Berrange
On Fri, Mar 08, 2013 at 05:32:51PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- TODO |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

Re: [libvirt] [libvirt-sandbox][PATCH] docs: fix some typos in architecture.txt

2013-03-12 Thread Daniel P. Berrange
On Fri, Mar 08, 2013 at 05:22:21PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- docs/architecture.txt | 16 1 files changed, 8 insertions(+), 8 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/

Re: [libvirt] [libvirt-glib] gconfig: API for SPICE image compression options

2013-03-12 Thread Daniel P. Berrange
On Sat, Mar 09, 2013 at 04:44:14PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds API to set/get image compression options on domain/graphics[@type='spice'] nodes. Also included are simple tests for this API. ---

Re: [libvirt] [PATCH] util: escapes special characters in VIR_LOG_REGEX

2013-03-12 Thread Daniel P. Berrange
On Sat, Mar 09, 2013 at 10:49:16PM +0800, Guannan Ren wrote: In debug mode, the bug failed to start vm error: Failed to start domain rhel5u9 error: internal error Out of space while reading console log output: ... --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] Add missing break in LXC loop device setup

2013-03-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com When setting up disks with loop devices for LXC, one of the switch cases was missing a 'break' causing it to fallthrough to an error condition. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/lxc/lxc_controller.c | 1 + 1 file changed,

Re: [libvirt] [PATCH] Add support for disks backed by plain files in LXC

2013-03-12 Thread Daniel P. Berrange
On Thu, Mar 07, 2013 at 03:55:01PM -0500, John Ferlan wrote: On 03/07/2013 06:41 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com By using a loopback device, disks backed by plain files can be made available to LXC containers. We make no attempt to auto-detect

Re: [libvirt] using virSetUIDGID() with unprivileged qemu defeats setuid helper

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 01:21:48PM -0600, Eric Blake wrote: On 03/10/2013 10:25 PM, Csaba Henk wrote: Hi, I recently experienced that my qemu guest (which I'm using with unprivileged user) fails to start with: error: internal error process exited while connecting to monitor:

Re: [libvirt] [PATCH] Add missing break in LXC loop device setup

2013-03-12 Thread Peter Krempa
On 03/12/13 12:53, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When setting up disks with loop devices for LXC, one of the switch cases was missing a 'break' causing it to fallthrough to an error condition. Signed-off-by: Daniel P. Berrange berra...@redhat.com ---

Re: [libvirt] IPv6: getting it to work

2013-03-12 Thread Gene Czarcinski
On 03/11/2013 03:32 PM, Gene Czarcinski wrote: Before I start creating patches (since it is not only source code but also documentation, schemas, tests, etc), I thought I would run this by you folks for comments/suggestions. With IPv4, it is relatively easy to set up working networks: just

Re: [libvirt] [PATCHv3 01/27] virCaps: conf: start splitting out irrelevat data

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:12PM +0100, Peter Krempa wrote: The virCaps structure gathered a ton of irrelevant data over time that. The original reason is that it was propagated to the XML parser functions. This patch aims to create a new data structure virDomainXMLConf that will contain

Re: [libvirt] [PATCHv3 03/27] fix fallout in src/esx

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:14PM +0100, Peter Krempa wrote: --- src/esx/esx_driver.c | 14 ++ src/esx/esx_private.h | 2 ++ 2 files changed, 12 insertions(+), 4 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [PATCHv3 02/27] fix fallout in src/conf/

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:13PM +0100, Peter Krempa wrote: --- src/conf/domain_conf.c | 104 +-- src/conf/domain_conf.h | 20 ++--- src/conf/snapshot_conf.c | 3 +- src/conf/snapshot_conf.h | 1 + src/libvirt_private.syms | 2 +

Re: [libvirt] [PATCHv3 04/27] fix fallout in src/lxc

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:15PM +0100, Peter Krempa wrote: --- src/Makefile.am | 1 + src/lxc/lxc_conf.c | 8 src/lxc/lxc_conf.h | 2 ++ src/lxc/lxc_controller.c | 7 ++- src/lxc/lxc_domain.c | 13 ++--- src/lxc/lxc_domain.h | 2 +-

Re: [libvirt] [PATCHv3 05/27] fix fallout in src/openvz

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:16PM +0100, Peter Krempa wrote: --- src/openvz/openvz_conf.c | 3 ++- src/openvz/openvz_conf.h | 1 + src/openvz/openvz_driver.c | 16 ++-- 3 files changed, 13 insertions(+), 7 deletions(-) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv3 06/27] fix fallout in src/parallels

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:17PM +0100, Peter Krempa wrote: --- src/parallels/parallels_driver.c | 12 src/parallels/parallels_utils.h | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv3 07/27] fix fallout in phyp driver

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:18PM +0100, Peter Krempa wrote: --- src/phyp/phyp_driver.c | 8 ++-- src/phyp/phyp_driver.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |:

Re: [libvirt] [PATCHv3 09/27] fix fallout in tests/

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:20PM +0100, Peter Krempa wrote: --- tests/domainsnapshotxml2xmltest.c | 5 + tests/lxcxml2xmltest.c| 7 ++- tests/qemuargv2xmltest.c | 8 ++-- tests/qemumonitorjsontest.c | 29 +++--

Re: [libvirt] [PATCHv3 08/27] fix fallout in src/qemu/

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:19PM +0100, Peter Krempa wrote: --- src/qemu/qemu_command.c | 9 ++-- src/qemu/qemu_command.h | 3 ++ src/qemu/qemu_conf.c | 10 ++-- src/qemu/qemu_conf.h | 4 ++ src/qemu/qemu_domain.c| 58 +-

Re: [libvirt] [PATCHv3 10/27] fix fallout in src/xen

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:21PM +0100, Peter Krempa wrote: --- src/xen/xen_driver.c| 8 ++-- src/xen/xen_driver.h| 1 + src/xen/xend_internal.c | 8 src/xen/xm_internal.c | 2 +- 4 files changed, 12 insertions(+), 7 deletions(-) ACK Daniel -- |:

Re: [libvirt] [PATCHv3 11/27] fix fallout in src/vmware

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:22PM +0100, Peter Krempa wrote: --- src/vmware/vmware_conf.c | 3 ++- src/vmware/vmware_conf.h | 1 + src/vmware/vmware_driver.c | 25 + 3 files changed, 20 insertions(+), 9 deletions(-) ACK Daniel -- |: http://berrange.com

Re: [libvirt] [PATCHv3 13/27] fix fallout in test driver

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:24PM +0100, Peter Krempa wrote: --- src/test/test_driver.c | 61 ++ 1 file changed, 42 insertions(+), 19 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|

Re: [libvirt] [PATCHv3 15/27] fix fallout in aahelper code

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:26PM +0100, Peter Krempa wrote: --- src/security/virt-aa-helper.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o-

Re: [libvirt] [PATCHv3 16/27] fix fallout in src/libxl

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:27PM +0100, Peter Krempa wrote: --- src/libxl/libxl_conf.h | 1 + src/libxl/libxl_driver.c | 51 ++-- 2 files changed, 33 insertions(+), 19 deletions(-) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv3 12/27] fix fallout in src/uml

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:23PM +0100, Peter Krempa wrote: --- src/uml/uml_conf.h | 1 + src/uml/uml_driver.c | 29 +++-- 2 files changed, 20 insertions(+), 10 deletions(-) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv3 17/27] fix fallout in src/xenapi

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:28PM +0100, Peter Krempa wrote: --- src/xenapi/xenapi_driver.c | 34 ++ src/xenapi/xenapi_driver_private.h | 1 + 2 files changed, 23 insertions(+), 12 deletions(-) ACK Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv3 18/27] fix fallout in selinux test

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:29PM +0100, Peter Krempa wrote: --- tests/securityselinuxlabeltest.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o-

Re: [libvirt] [PATCHv3 14/27] fix fallout in vbox driver

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:25PM +0100, Peter Krempa wrote: --- src/vbox/vbox_tmpl.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

Re: [libvirt] [PATCH v3 1/3] virFile: Add APIs for extended attributes handling

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 05:13:27PM +0100, Michal Privoznik wrote: Currently, only three wrappers are being implemented: virFileSetAttr for setting attributes virFileGetAttr for querying attributes (note we need to call it twice, first time to get length of attribute value, second to get actual

Re: [libvirt] [PATCH v3 1/3] virFile: Add APIs for extended attributes handling

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 05:13:27PM +0100, Michal Privoznik wrote: Currently, only three wrappers are being implemented: virFileSetAttr for setting attributes virFileGetAttr for querying attributes (note we need to call it twice, first time to get length of attribute value, second to get actual

Re: [libvirt] [PATCH v3 2/3] virfile: Introduce internal API for managing ACL

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 05:13:28PM +0100, Michal Privoznik wrote: diff --git a/m4/virt-acl.m4 b/m4/virt-acl.m4 new file mode 100644 index 000..7f16dca --- /dev/null +++ b/m4/virt-acl.m4 @@ -0,0 +1,9 @@ +dnl The libacl.so library + +AC_DEFUN([LIBVIRT_CHECK_ACL],[ +

Re: [libvirt] [PATCH] audit: Audit operations done by using VirtIO RNG

2013-03-12 Thread Daniel P. Berrange
On Tue, Mar 12, 2013 at 12:25:14PM +0100, Peter Krempa wrote: On 03/12/13 12:19, Daniel P. Berrange wrote: On Mon, Mar 11, 2013 at 05:19:36PM +0100, Peter Krempa wrote: This patch adds auditing of resources used by the 'random' backend of virtio RNG. --- If there's desire to audit also use

Re: [libvirt] [PATCHv3 20/27] fix fallout from adding new parameter to internal APIs

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:31PM +0100, Peter Krempa wrote: --- src/conf/domain_conf.c | 4 +++- src/conf/domain_conf.h | 2 ++ src/libxl/libxl_driver.c | 6 -- src/lxc/lxc_driver.c | 6 -- src/openvz/openvz_driver.c | 4 ++-- src/phyp/phyp_driver.c | 4

Re: [libvirt] [PATCHv3 19/27] conf: Add separate defaults addition and validation for XML parsing

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:30PM +0100, Peter Krempa wrote: This patch adds instrumentation that will ultimately allow to split out filling of defaults and input validation from the XML parser to separate functions. With this patch, after the XML is parsed, a callback to the driver is

Re: [libvirt] [PATCHv3 21/27] conf: Add argument to support use of the driver adjust callbacks

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:32PM +0100, Peter Krempa wrote: This patch adds a argument to the virDomainXMLConfNew constructor to pass the driver adjust callback pointers and fixes the fallout of this change. --- src/conf/domain_conf.c | 4 src/conf/domain_conf.h |

Re: [libvirt] [PATCHv3 22/27] qemu: Record the default NIC model in the domain XML

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:33PM +0100, Peter Krempa wrote: This patch implements the callback that is used to fill the qemu default network card into the XML if none is specified. Libvirt assumes that the network card for qemu if none specified is the rtl8139. Record this in the XML using

Re: [libvirt] [PATCHv3 23/27] fix fallout of the change of the network device default

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:34PM +0100, Peter Krempa wrote: --- tests/qemuxml2argvdata/qemuxml2argv-net-bandwidth.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-net-client.args | 4 ++-- tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.args | 4 ++--

Re: [libvirt] [PATCHv3 24/27] virCaps: get rid of defaultInitPath value in the virCaps struct

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:35PM +0100, Peter Krempa wrote: This gets rid of the parameter in favor of using the new callback infrastructure to do the same stuff. This patch implements the domain adjustment callback in the openVZ driver and moves the check from the parser to a new

Re: [libvirt] [PATCHv3 25/27] virCaps: get rid of defaultDiskDriverName

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:36PM +0100, Peter Krempa wrote: This patch removes the defaultDiskDriverName from the virCaps structure. This particular default value is used only in the qemu driver so this patch uses the recently added callback to fill the driver name if it's needed instead of

Re: [libvirt] [PATCHv3 26/27] virCaps: get rid of emulatorRequired

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 04:06:37PM +0100, Peter Krempa wrote: This patch removes the emulatorRequired field and associated infrastructure from the virCaps object. Instead the driver specific callbacks are used as this field isn't enforced by all drivers. This patch implements the appropriate

Re: [libvirt] [libvirt-glib] gconfig: API for SPICE image compression options

2013-03-12 Thread Christophe Fergeau
On Sat, Mar 09, 2013 at 04:44:14PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds API to set/get image compression options on domain/graphics[@type='spice'] nodes. Also included are simple tests for this API. Do we really need a

Re: [libvirt] [PATCH v3 3/3] security_dac: Favour ACLs over chown()

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 05:13:29PM +0100, Michal Privoznik wrote: On filesystems supporting ACLs we don't need to do a chown but we can just set ACLs to gain access for qemu. However, since we are setting these on too low level, where we don't know if disk is just a read only or read write, we

Re: [libvirt] [PATCH 1/1] Set legacy USB option with default for ppc64.

2013-03-12 Thread Viktor Mihajlovski
On 03/04/2013 07:47 AM, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch is to legacy USB option with default for ppc64. Signed-off-by: Li Zhang

[libvirt] [PATCHv2] audit: Audit resources used by VirtIO RNG

2013-03-12 Thread Peter Krempa
This patch adds auditing of resources used by Virtio RNG devices. Only resources on the local filesystems are audited properly. For remote character device sources remote is logged as the path and none is logged for character device backends that don't have a source. The audit logs look like:

Re: [libvirt] [Qemu-devel] [PATCH] qdev: DEVICE_DELETED event

2013-03-12 Thread Laine Stump
On 03/08/2013 04:25 AM, Jiri Denemark wrote: On Fri, Mar 08, 2013 at 09:50:55 +0100, Markus Armbruster wrote: Osier Yang jy...@redhat.com writes: I'm wondering if it could be long time to wait for the device_del completes (AFAIK from previous bugs, it can be, though it should be fine for

[libvirt] we can't build a new libvirt package (error 1)

2013-03-12 Thread Erdembileg. G
Hi, I installed Xen 4.2.1-4.el6 on CentOS 6.4. kernel version is 3.8.2-3.el6xen.x86_64. Libvirt version is libvirt-0.10.2-18.el6 Before configure and installion are OK. But I can't build a new libvirt package. PASS: test_conf.sh PASS: cpuset PASS: define-dev-segfault PASS: int-overflow PASS:

Re: [libvirt] we can't build a new libvirt package (error 1)

2013-03-12 Thread Peter Krempa
On 03/12/13 10:22, Erdembileg. G wrote: Hi, I installed Xen 4.2.1-4.el6 on CentOS 6.4. kernel version is 3.8.2-3.el6xen.x86_64. Libvirt version is libvirt-0.10.2-18.el6 Before configure and installion are OK. But I can't build a new libvirt package. PASS: test_conf.sh PASS: cpuset PASS:

Re: [libvirt] [libvirt-glib] gconfig: API for SPICE image compression options

2013-03-12 Thread Zeeshan Ali (Khattak)
On Tue, Mar 12, 2013 at 3:16 PM, Christophe Fergeau cferg...@redhat.com wrote: On Sat, Mar 09, 2013 at 04:44:14PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds API to set/get image compression options on domain/graphics[@type='spice']

Re: [libvirt] Libvirt and qemu multiqueue net

2013-03-12 Thread Laine Stump
On 03/12/2013 06:17 AM, Michal Privoznik wrote: It's been a while since qemu added support for multiqueue virtio-net. For more info follow [1]. From usage POV, libvirt is required to pass multiple FDs: qemu-kvm -netdev tap,id=hn0,fds=x:y:...:z,vhost=on,vhostfds=a:b:...:c -device

Re: [libvirt] [libvirt-glib] gconfig: API for SPICE image compression options

2013-03-12 Thread Christophe Fergeau
On Tue, Mar 12, 2013 at 06:28:36PM +0200, Zeeshan Ali (Khattak) wrote: On Tue, Mar 12, 2013 at 3:16 PM, Christophe Fergeau cferg...@redhat.com wrote: On Sat, Mar 09, 2013 at 04:44:14PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds

Re: [libvirt] Libvirt and qemu multiqueue net

2013-03-12 Thread Daniel P. Berrange
On Tue, Mar 12, 2013 at 11:17:16AM +0100, Michal Privoznik wrote: It's been a while since qemu added support for multiqueue virtio-net. For more info follow [1]. From usage POV, libvirt is required to pass multiple FDs: qemu-kvm -netdev tap,id=hn0,fds=x:y:...:z,vhost=on,vhostfds=a:b:...:c

[libvirt] Race/broken mutex when closing a connection

2013-03-12 Thread Viktor Mihajlovski
I received a report of a virsh coredump that happened on a heavy loaded system. Debugging the corefile I saw that under certain circumstances the mutex for a connection can be destroyed while another thread is waiting for the lock on that connection. Specifically this seems to happen when

Re: [libvirt] RFC: vfio pci passthrough support

2013-03-12 Thread Laine Stump
On 03/11/2013 02:06 PM, Alex Williamson wrote: On Mon, 2013-03-11 at 13:23 -0400, Laine Stump wrote: VFIO is a new method of doing PCI device assignment (PCI passthrough aka hostdev) available in newish kernels (3.6?; it's in Fedora 18 at any rate) and via the vfio-pci device in qemu-1.4+. In

[libvirt] [PATCH] Apply security label when entering LXC namespaces

2013-03-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a new virDomainLxcEnterSecurityLabel() function as a counterpart to virDomainLxcEnterNamespaces(), which can change the current calling process to have a new security context. This call runs client side, not in libvirtd so we can't use the security

Re: [libvirt] IPv6: getting it to work

2013-03-12 Thread Gene Czarcinski
On 03/12/2013 08:05 AM, Gene Czarcinski wrote: On 03/11/2013 03:32 PM, Gene Czarcinski wrote: Before I start creating patches (since it is not only source code but also documentation, schemas, tests, etc), I thought I would run this by you folks for comments/suggestions. With IPv4, it is

[libvirt] [PATCH] Fix query of LXC security label

2013-03-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virDomainGetSecurityLabel method is currently (mistakenly) showing the label of the libvirt_lxc process: ...snip... Security model: selinux Security DOI: 0 Security label: system_u:system_r:virtd_t:s0-s0:c0.c1023 (permissive) when it should be

[libvirt] [PATCH] Fix missing error dispatch in virDomainLxcEnterNamespace

2013-03-12 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The virDomainLxcEnterNamespace method mistakenly uses virCheckFlags, which returns immediately instead of virCheckFlagsGoto which jumps to the error cleanup patch where there is a virDispatchError call --- src/libvirt-lxc.c | 2 +- 1 file changed, 1

[libvirt] Adding and Clearing bridge addresses

2013-03-12 Thread Gene Czarcinski
I have been working on this patch to have libvirt optionally set static routes. So I found the function that adds both IPv4 and IPv6 addresses to the bridge in virnetdev.c. I found that besides the virNetDevAddIPv4Address() there is also virNetDevCleanIPv4Address(). I patterned my

Re: [libvirt] [PATCH] Fix missing error dispatch in virDomainLxcEnterNamespace

2013-03-12 Thread Eric Blake
On 03/12/2013 11:37 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The virDomainLxcEnterNamespace method mistakenly uses virCheckFlags, which returns immediately instead of virCheckFlagsGoto which jumps to the error cleanup patch where there is a virDispatchError

Re: [libvirt] [PATCH 1/8] Add API for thread cancellation

2013-03-12 Thread Daniel P. Berrange
On Thu, Mar 07, 2013 at 05:10:36PM -0700, Eric Blake wrote: On 03/06/2013 05:49 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a virThreadCancel function. This functional is inherantly s/inherantly/inherently/ dangerous and not something we want to

Re: [libvirt] [PATCHv2] audit: Audit resources used by VirtIO RNG

2013-03-12 Thread Daniel P. Berrange
On Tue, Mar 12, 2013 at 04:11:15PM +0100, Peter Krempa wrote: This patch adds auditing of resources used by Virtio RNG devices. Only resources on the local filesystems are audited properly. For remote character device sources remote is logged as the path and none is logged for character device

Re: [libvirt] [PATCH 3/8] Add APIs to get at more client security data

2013-03-12 Thread Daniel P. Berrange
On Thu, Mar 07, 2013 at 05:33:07PM -0700, Eric Blake wrote: On 03/06/2013 05:49 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com A socket object has various pieces of security data associated with it, such as the SELinux context, the SASL username and the x509

Re: [libvirt] RFC: vfio pci passthrough support

2013-03-12 Thread Alex Williamson
On Tue, 2013-03-12 at 13:20 -0400, Laine Stump wrote: On 03/11/2013 02:06 PM, Alex Williamson wrote: On Mon, 2013-03-11 at 13:23 -0400, Laine Stump wrote: VFIO is a new method of doing PCI device assignment (PCI passthrough aka hostdev) available in newish kernels (3.6?; it's in Fedora 18

Re: [libvirt] libvirt accidentally destroys guests after being restarted

2013-03-12 Thread Sergey Fionov
Hello. We finally found the cause of this problem. When we use virsh reboot domain, it is actually two calls qemuMonitorSystemPowerdown() and qemuProcessFakeReboot(). Inside the first call domain stateReason is set to VIR_DOMAIN_SHUTDOWN_UNKNOWN and then virDomainSaveStatus() is called. Inside

Re: [libvirt] [PATCH 1/1] Set legacy USB option with default for ppc64.

2013-03-12 Thread Jiri Denemark
On Tue, Mar 12, 2013 at 13:34:07 +0100, Viktor Mihajlovski wrote: On 03/04/2013 07:47 AM, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch is

Re: [libvirt] [PATCH] Apply security label when entering LXC namespaces

2013-03-12 Thread Eric Blake
On 03/12/2013 11:28 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Add a new virDomainLxcEnterSecurityLabel() function as a counterpart to virDomainLxcEnterNamespaces(), which can change the current calling process to have a new security context. This call runs

Re: [libvirt] Adding and Clearing bridge addresses

2013-03-12 Thread Laine Stump
On 03/12/2013 01:45 PM, Gene Czarcinski wrote: I have been working on this patch to have libvirt optionally set static routes. So I found the function that adds both IPv4 and IPv6 addresses to the bridge in virnetdev.c. I found that besides the virNetDevAddIPv4Address() there is also

Re: [libvirt] [libvirt-glib] gconfig: API for SPICE image compression options

2013-03-12 Thread Zeeshan Ali (Khattak)
On Tue, Mar 12, 2013 at 7:07 PM, Christophe Fergeau cferg...@redhat.com wrote: On Tue, Mar 12, 2013 at 06:28:36PM +0200, Zeeshan Ali (Khattak) wrote: On Tue, Mar 12, 2013 at 3:16 PM, Christophe Fergeau cferg...@redhat.com wrote: On Sat, Mar 09, 2013 at 04:44:14PM +0200, Zeeshan Ali (Khattak)

Re: [libvirt] Adding and Clearing bridge addresses

2013-03-12 Thread Daniel P. Berrange
On Tue, Mar 12, 2013 at 03:11:56PM -0400, Laine Stump wrote: On 03/12/2013 01:45 PM, Gene Czarcinski wrote: I have been working on this patch to have libvirt optionally set static routes. So I found the function that adds both IPv4 and IPv6 addresses to the bridge in virnetdev.c. I

[libvirt] [libvirt-glib v2] gconfig: API for SPICE image compression

2013-03-12 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds API to set/get image compression configuration on domain/graphics[@type='spice'] nodes. Also included are simple tests for this API. --- V2: * No separate class for 'image' node. * Use trigraph extensions of glib-mkenums to assign

[libvirt] [PATCH v4 0/2] qemu: -dtb option support

2013-03-12 Thread Olivia Yin
Sometime QEMU need load specific device tree binary images. These patches provide -dtb option support and update docs/tests. Olivia Yin (2): qemu: add support for dtb option conf: Add support for dtb option in QEMU src/qemu/qemu_capabilities.c |6

[libvirt] [PATCH v4 1/2] qemu: add support for dtb option

2013-03-12 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com The dtb option sets the filename for the device tree. If without this option support, -dtb file will be converted into qemu:commandline in domain XML file. For example, '-dtb /media/ram/test.dtb' will be converted into qemu:commandline

[libvirt] [PATCH v4 2/2] conf: Add support for dtb option in QEMU

2013-03-12 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com This patch adds support to set the device trees file. --- docs/formatdomain.html.in |5 + docs/schemas/domaincommon.rng |5 + src/conf/domain_conf.c|4 src/conf/domain_conf.h|1 + 4 files

[libvirt] [PATCH] qemu: add PCI-multibus support for ppc

2013-03-12 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- src/qemu/qemu_capabilities.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 7bc1ebc..7d7791d 100644 --- a/src/qemu/qemu_capabilities.c +++