[libvirt] [PATCH v2 1/1][RESEND] Add NVRAM device

2013-03-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch is to add NVRAM device to allow users to specify its address. In QEMU, NVRAM

[libvirt] [PATCH 1/1][RESEND]Remove contiguous CPU indexes assumption

2013-03-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64 platform, CPU indexes are not contiguous because SMT is needed to be disabled, so CPU information is not right on ppc64 and vpuinfo, vcpupin can't work

[libvirt] [PATCH 1/1][RESEND] Set legacy USB option with default for ppc64.

2013-03-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -device xxx still can't work well for ppc64 platform. It's better use legacy USB option with default for ppc64. This patch is to legacy USB option with default for ppc64. Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com ---

[libvirt] [PATCH 1/1][RESEND] ppc64 cpu features

2013-03-14 Thread Li Zhang
From: Li Zhang zhlci...@linux.vnet.ibm.com This patch adds a CPU feature powernv identifying IBM Power processor that supports native hypervisor e.g. KVM. This can be used by virtualization management software to determine the CPU capabilities. PVR doesn't indicate whether it a host or a guest

[libvirt] [PATCHv6] virtio-rng: Add rate limiting options for virtio-RNG

2013-03-14 Thread Peter Krempa
Qemu's implementation of virtio RNG supports rate limiting of the entropy used. This patch exposes the option to tune this functionality. This patch is based on qemu commit 904d6f588063fb5ad2b61998acdf1e73fb4 The rate limiting is exported in the XML as: devices ... rng model='virtio'

[libvirt] separate module for pci passthrough device assigning and in-use tracking

2013-03-14 Thread Chunyan Liu
Hi, Shradha, Laine Some time before I found you had a thread discussing in-use tracking for network and pci-passthrough devices[1], it mentioned code for tracking pci device allocation should be better as a separate module rather than a part of qemu, so that it could solve data sharing problem

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way.

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way.

Re: [libvirt] [PATCHv4 3/5] S390: QEMU driver support for CCW addresses

2013-03-14 Thread Viktor Mihajlovski
On 03/14/2013 12:03 AM, Eric Blake wrote: +if (virAsprintf(addrstr, %x.%x.%04x, Should we zero-pad the first two fields too, or is it common to only pad the last field in ccw addresses ? but left this alone. You can submit a followup patch if it is necessary. That's OK, only the last

[libvirt] [PATCH] json: add stream parser

2013-03-14 Thread Dmitry Guryanov
Add function virJSONValueFromStream, which reads data from a stream and passes it to json parser. When end of the object is reached, it returns this object. To avoid reading from the stream by single bytes it reads to a buffer (in a structure virJSONStreamParserState), which should be passed to a

[libvirt] [PATCH 0/4] Various virsh cleanups and enhancements

2013-03-14 Thread Martin Kletzander
Wanting to resolve rhbz#919372 (fixed in [3/4]) I came accross few things that could've used some polishing, so here's the series. Martin Kletzander (4): Make vshDebug work when parsing parameters Fix snapshot-create-as syntax in help output Allow multiple parameters for schedinfo Cleanup

[libvirt] [PATCH 3/4] Allow multiple parameters for schedinfo

2013-03-14 Thread Martin Kletzander
virsh schedinfo was able to set only one parameter at a time (not counting the deprecated options), but it is useful to set more at once, so this patch adds the possibility to do stuff like this: virsh schedinfo domain cpu_shares=0 vcpu_period=0 vcpu_quota=0 \ emulator_period=0 emulator_quota=0

[libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

2013-03-14 Thread Martin Kletzander
According to the man page, the memspec parameter should have the '--memspec' option mandatory and this is as close as we can get to that. What this change does is explained below. man virsh: snapshot-create-as ... [[--live] [--memspec memspec]] virsh help snapshot-create-as before this patch:

[libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-14 Thread Martin Kletzander
The vshInit initializes ctl-debug by which vshDebug (which is also called in vshParseArgv) decides whether to print out the message or not. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/virsh.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[libvirt] [libvirt-sandbox][PATCH] Fix copypaste error in autogen.sh

2013-03-14 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- autogen.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/autogen.sh b/autogen.sh index 86cd496..4b760fa 100755 --- a/autogen.sh +++ b/autogen.sh @@ -12,7 +12,7 @@ DIE=0 (autoconf --version) /dev/null /dev/null 21 || {

[libvirt] Problems with live migration

2013-03-14 Thread Toni F. [ackstorm]
Hi all, I have working with Openstack Folsom and with Glusterfs as shared storage for /instances. All working fine, but when i'm trying to use nova live-migration: 2013-03-07 18:33:42 3140 ERROR nova.virt.libvirt.driver [-] [instance: 773164b5-5e5c-4328-a762-d91f50f2ac33] Live Migration

[libvirt] Problems with live migration

2013-03-14 Thread Toni F. [ackstorm]
Hi all, I have working with Openstack Folsom and with Glusterfs as shared storage for /instances. All working fine, but when i'm trying to use nova live-migration: 2013-03-07 18:33:42 3140 ERROR nova.virt.libvirt.driver [-] [instance: 773164b5-5e5c-4328-a762-d91f50f2ac33] Live Migration

[libvirt] can this vm-xml-interface works,thanks

2013-03-14 Thread yue
hi,all,please look at interface . actually ,virbr0 is NAT, my program product a vm-xml which is not standard. it use the way to product bridge interface to product a NAT interface. but i want to know if this can work rightly. interface type='bridge' # type='network' mac

Re: [libvirt] [libvirt-glib v2] gconfig: API for SPICE image compression

2013-03-14 Thread Christophe Fergeau
Hey, On Tue, Mar 12, 2013 at 10:56:31PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds API to set/get image compression configuration on domain/graphics[@type='spice'] nodes. Also included are simple tests for this API. --- V2: *

Re: [libvirt] [PATCH] util: fix clear_emulator_capabilities=0

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 04:09:44PM -0600, Eric Blake wrote: On 03/13/2013 01:37 PM, Laine Stump wrote: My commit 7a2e845a865dc7fa82d2393ea2a770cfc8cf00b4 (and its prerequisites) managed to effectively ignore the clear_emulator_capabilities setting in qemu.conf (visible in the code as the

Re: [libvirt] [PATCHv6] virtio-rng: Add rate limiting options for virtio-RNG

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 08:55:52AM +0100, Peter Krempa wrote: Qemu's implementation of virtio RNG supports rate limiting of the entropy used. This patch exposes the option to tune this functionality. This patch is based on qemu commit 904d6f588063fb5ad2b61998acdf1e73fb4 The rate limiting

Re: [libvirt] [PATCH] json: add stream parser

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 12:55:15PM +0400, Dmitry Guryanov wrote: Add function virJSONValueFromStream, which reads data from a stream and passes it to json parser. When end of the object is reached, it returns this object. To avoid reading from the stream by single bytes it reads to a buffer

Re: [libvirt] [libvirt-sandbox][PATCH] Fix copypaste error in autogen.sh

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 05:48:39PM +0800, Alex Jia wrote: Signed-off-by: Alex Jia a...@redhat.com --- autogen.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/autogen.sh b/autogen.sh index 86cd496..4b760fa 100755 --- a/autogen.sh +++ b/autogen.sh @@ -12,7

[libvirt] [libvirt-sandbox][PATCH] Avoid segfault if broadcast address is NULL

2013-03-14 Thread Alex Jia
It seems the broadcast address parameter is not optional now, if users haven't specified the broadcast address to the network interface then a segfault will be raised. This patch is just a temporary solution to avoid segfault, and with the patch, users will get a expected error Unable to parse

Re: [libvirt] [PATCH v2 1/1][RESEND] Add NVRAM device

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 02:54:19PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com For pSeries guest in QEMU, NVRAM is one kind of spapr-vio device. Users are allowed to specify spapr-vio devices'address. But NVRAM is not supported in libvirt. So this patch is to add NVRAM

Re: [libvirt] [PATCHv2 1/1][RESEND] Optimize machine option to set more options with it.

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 02:54:20PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com Currently, -machine option is used only when dump-guest-core is used. To use options defined in machine option for new version of QEMU, it needs to use -machine xxx, and to be compatible

Re: [libvirt] [PATCH 1/1][RESEND]Remove contiguous CPU indexes assumption

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 02:54:22PM +0800, Li Zhang wrote: From: Li Zhang zhlci...@linux.vnet.ibm.com When getting CPUs' information, it assumes that CPU indexes are not contiguous. But for ppc64 platform, CPU indexes are not contiguous because SMT is needed to be disabled, so CPU information

Re: [libvirt] [libvirt-sandbox][PATCH] Avoid segfault if broadcast address is NULL

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 07:00:43PM +0800, Alex Jia wrote: It seems the broadcast address parameter is not optional now, if users haven't specified the broadcast address to the network interface then a segfault will be raised. This patch is just a temporary solution to avoid segfault, and

Re: [libvirt] [PATCH] Prevent streams from becoming libvirtd controlling TTY

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 04:33:34PM -0600, Eric Blake wrote: On 03/13/2013 11:24 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com When opening a stream to a device which is a TTY, that device may become the controlling TTY of libvirtd, if libvirtd was

[libvirt] Libvirt + LXC terminals

2013-03-14 Thread Purcareata Bogdan-B43198
Hello all, I am looking for a way to start a container with libvirt and bind multiple consoles to it. My container is running busybox, the filesystem created using the LXC package (0.8.0). My libvirt version is 0.10.1. Configuration of the filesystem: - in the container rootfs, /dev contains 2

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: [...] diff --git a/qapi-schema.json b/qapi-schema.json index 28b070f..bb361e1 100644 --- a/qapi-schema.json +++ b/qapi-schema.json

Re: [libvirt] [PATCH] json: add stream parser

2013-03-14 Thread Dmitry Guryanov
On 130314 10:53:59, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 12:55:15PM +0400, Dmitry Guryanov wrote: Add function virJSONValueFromStream, which reads data from a stream and passes it to json parser. When end of the object is reached, it returns this object. To avoid reading from

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2013 at 01:13:54PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: [...] diff --git a/qapi-schema.json b/qapi-schema.json index

Re: [libvirt] [Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Mar 14, 2013 at 09:06:15AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an

[libvirt] [PATCH] remote: Prevent race when closing a connection

2013-03-14 Thread Viktor Mihajlovski
A race condition can occur when virConnectClose is called parallel to the execution of the connection close callback in remoteClientCloseFunc. The race happens if the connection object is destroyed (including the mutex) while remoteClientCloseFunc is waiting for the connection mutex. After the

Re: [libvirt] Libvirt + LXC terminals

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 11:10:31AM +, Purcareata Bogdan-B43198 wrote: Hello all, I am looking for a way to start a container with libvirt and bind multiple consoles to it. My container is running busybox, the filesystem created using the LXC package (0.8.0). My libvirt version is 0.10.1.

[libvirt] [PATCH v7 0/3] DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. First patch only adds the event with ID, second patch adds a path field. Split this way for ease of backport (stable

[libvirt] [PATCH v7 2/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- QMP/qmp-events.txt| 16 hw/qdev.c

Re: [libvirt] [PATCHv6] virtio-rng: Add rate limiting options for virtio-RNG

2013-03-14 Thread Peter Krempa
On 03/14/13 11:50, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 08:55:52AM +0100, Peter Krempa wrote: Qemu's implementation of virtio RNG supports rate limiting of the entropy used. This patch exposes the option to tune this functionality. This patch is based on qemu commit

Re: [libvirt] Libvirt + LXC terminals

2013-03-14 Thread Purcareata Bogdan-B43198
Thank you very much for the detailed help! Your setup worked flawlessly. Best regards, Bogdan P. -Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Thursday, March 14, 2013 2:31 PM To: Purcareata Bogdan-B43198 Cc: libvirt-l...@redhat.com Subject: Re:

[libvirt] [PATCH v8 3/3] qmp: add path to device_deleted event

2013-03-14 Thread Michael S. Tsirkin
Add QOM path to device deleted event. It now becomes useful to report it for devices which don't have an ID assigned. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- QMP/qmp-events.txt | 4 +++- hw/qdev.c | 5 +++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH v8 0/3] DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. First patch only adds the event with ID, second patch adds a path field. Split this way for ease of backport (stable

[libvirt] [PATCH v8 1/3] qdev: DEVICE_DELETED event

2013-03-14 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- QMP/qmp-events.txt| 16 hw/qdev.c

[libvirt] [PATCH] Fix size probing for VDI images

2013-03-14 Thread Ján Tomko
Commit 027bf2ea used the wrong offset: the text field at the start of the header has 64 bytes, not 68. [1] Bug: https://bugzilla.redhat.com/show_bug.cgi?id=921452 [1] https://forums.virtualbox.org/viewtopic.php?p=29267#p29267 --- Relevant for v1.0.3-maint. src/util/virstoragefile.c | 2 +- 1

[libvirt] [PATCH v8 2/3] qom: pass original path to unparent method

2013-03-14 Thread Michael S. Tsirkin
We need to know the original path since unparenting loses this state. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/qdev.c| 4 ++-- include/qom/object.h | 3 ++- qom/object.c | 4 +++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c

[libvirt] [PATCH libvirt-glib v2 1/2] Add gvir_config_object_replace_child_with_attribute_enum()

2013-03-14 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org Internal libvirt-gconfig helper to replace enum XML attributes. --- libvirt-gconfig/libvirt-gconfig-object-private.h | 5 + libvirt-gconfig/libvirt-gconfig-object.c | 14 ++ 2 files changed, 19 insertions(+) diff --git

[libvirt] [PATCH libvirt-glib v2 2/2] gconfig: API for SPICE image compression

2013-03-14 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds API to set/get image compression configuration on domain/graphics[@type='spice'] nodes. Also included are simple tests for this API. --- .../libvirt-gconfig-domain-graphics-spice.c| 38 +-

Re: [libvirt] [PATCH] Fix size probing for VDI images

2013-03-14 Thread Martin Kletzander
On 03/14/2013 01:45 PM, Ján Tomko wrote: Commit 027bf2ea used the wrong offset: the text field at the start of the header has 64 bytes, not 68. [1] Bug: https://bugzilla.redhat.com/show_bug.cgi?id=921452 [1] https://forums.virtualbox.org/viewtopic.php?p=29267#p29267 --- Relevant for

Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-14 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 03:36:56PM -0600, Eric Blake wrote: On 03/07/2013 11:14 AM, Stefan Berger wrote: Add support for file descriptor sets by converting some of the command line parameters to use /dev/fdset/%d if -add-fd is found to be supported by QEMU. For those devices libvirt now

Re: [libvirt] [Qemu-devel] [PATCH v8 0/3] DEVICE_DELETED event

2013-03-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. First patch only adds the event with ID, second patch adds a path field.

Re: [libvirt] [PATCH V1 1/6] Add QMP probing for TPM

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 12:03:49PM -0400, Stefan Berger wrote: Probe for QEMU's QMP TPM support by querying the lists of supported TPM models (query-tpm-models) and backend types (query-tpm-types). The setting of the capability flags following the strings returned from the commands above

Re: [libvirt] [PATCH V1 2/6] Parse TPM in domain XML

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 12:03:50PM -0400, Stefan Berger wrote: Parse the domain XML with TPM support. Convert the strings from QEMU's QMP TPM commands into capability flags. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- docs/schemas/domaincommon.rng | 43 ++

Re: [libvirt] [PATCH V1 1/6] Add QMP probing for TPM

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 12:03:49PM -0400, Stefan Berger wrote: Index: libvirt/src/util/virutil.c === --- libvirt.orig/src/util/virutil.c +++ libvirt/src/util/virutil.c @@ -3379,3 +3379,17 @@ cleanup: VIR_FREE(buf);

Re: [libvirt] [PATCH] Fix size probing for VDI images

2013-03-14 Thread Ján Tomko
On 03/14/2013 02:57 PM, Martin Kletzander wrote: On 03/14/2013 01:45 PM, Ján Tomko wrote: Commit 027bf2ea used the wrong offset: the text field at the start of the header has 64 bytes, not 68. [1] Bug: https://bugzilla.redhat.com/show_bug.cgi?id=921452 [1]

Re: [libvirt] [PATCH V1 3/6] Add documentation for TPM in domain XML

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 12:03:51PM -0400, Stefan Berger wrote: Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- docs/formatdomain.html.in | 57 ++ 1 file changed, 57 insertions(+) This ought to be part of the patch which introduces

Re: [libvirt] [PATCH V1 4/6] Add SELinux labeling support for TPM

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 12:03:52PM -0400, Stefan Berger wrote: Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/security/security_selinux.c | 90 1 file changed, 90 insertions(+) I imagine we also need to update

Re: [libvirt] [PATCH V1 6/6] Add test case for TPM passthrough

2013-03-14 Thread Daniel P. Berrange
On Wed, Mar 13, 2013 at 12:03:54PM -0400, Stefan Berger wrote: Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.args |6 +++ tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.xml | 29 +++

Re: [libvirt] [PATCH V9 3/3] Add support for file descriptor sets

2013-03-14 Thread Eric Blake
On 03/12/2013 05:21 AM, Stefan Berger wrote: And here, these files support SELinux labeling, so maybe fd passing is overkill, other than proof of concept that we are doing fd passing correctly. So, I'm debating on how much of this patch needs to be applied, or whether we should split it into

Re: [libvirt] [PATCH V1 1/6] Add QMP probing for TPM

2013-03-14 Thread Stefan Berger
On 03/14/2013 10:20 AM, Daniel P. Berrange wrote: On Wed, Mar 13, 2013 at 12:03:49PM -0400, Stefan Berger wrote: Probe for QEMU's QMP TPM support by querying the lists of supported TPM models (query-tpm-models) and backend types (query-tpm-types). The setting of the capability flags following

Re: [libvirt] [PATCH V1 1/6] Add QMP probing for TPM

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 10:44:32AM -0400, Stefan Berger wrote: On 03/14/2013 10:20 AM, Daniel P. Berrange wrote: On Wed, Mar 13, 2013 at 12:03:49PM -0400, Stefan Berger wrote: Probe for QEMU's QMP TPM support by querying the lists of supported TPM models (query-tpm-models) and backend types

Re: [libvirt] [PATCH] qemu: detect multi-head qxl via more than version check

2013-03-14 Thread Jiri Denemark
On Wed, Mar 13, 2013 at 18:48:46 -0600, Eric Blake wrote: Multi-head QXL support is so useful that distros have started to backport it to qemu earlier than 1.2. After discussion with Alon Levy, we determined that the existence of the qxl-vga.surfaces property is a reliable indicator of

Re: [libvirt] [PATCH V1 1/6] Add QMP probing for TPM

2013-03-14 Thread Stefan Berger
On 03/14/2013 10:47 AM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:44:32AM -0400, Stefan Berger wrote: On 03/14/2013 10:20 AM, Daniel P. Berrange wrote: Hm, this surprises me since this would put JSON specific code into the monitor APIs (qemu_monitor.c) while qemu_monitor.c typically

[libvirt] [PATCH] Fix deps for generating RPC dispatch code

2013-03-14 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The src/lxc/lxc_*_dispatch.h files only had deps on the RPC generator script the XDR definition file. So when the Makefile.am args passed to the generator were change, the disaptch code was not re-generated. This caused a build failure CC

Re: [libvirt] [PATCH] Fix deps for generating RPC dispatch code

2013-03-14 Thread Eric Blake
On 03/14/2013 08:56 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The src/lxc/lxc_*_dispatch.h files only had deps on the RPC generator script the XDR definition file. So when the Makefile.am args passed to the generator were change, the disaptch code was not

Re: [libvirt] [PATCH libvirt-glib v2 1/2] Add gvir_config_object_replace_child_with_attribute_enum()

2013-03-14 Thread Christophe Fergeau
ACK On Thu, Mar 14, 2013 at 03:53:46PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org Internal libvirt-gconfig helper to replace enum XML attributes. --- libvirt-gconfig/libvirt-gconfig-object-private.h | 5 +

Re: [libvirt] [PATCH libvirt-glib v2 2/2] gconfig: API for SPICE image compression

2013-03-14 Thread Christophe Fergeau
ACK On Thu, Mar 14, 2013 at 03:53:47PM +0200, Zeeshan Ali (Khattak) wrote: From: Zeeshan Ali (Khattak) zeesha...@gnome.org This patch adds API to set/get image compression configuration on domain/graphics[@type='spice'] nodes. Also included are simple tests for this API. ---

[libvirt] [PATCH 0/3] Enable virtio-scsi and virtio-rng for s390

2013-03-14 Thread Viktor Mihajlovski
Early QEMU versions did not support virtio-scsi or virtio-rng for s390 machines. This series enables libvirt to exploit the capabilities provided by newer QEMUs. Viktor Mihajlovski (3): qemu: rename virtio-scsi capability S390: Enable virtio-scsi and virtio-rng S390: Testcases for

[libvirt] [PATCH 3/3] S390: Testcases for virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
Adding test cases for virtio-scsi and virtio-rng. Since ccw is covering the superset of the s390 bus handling, these are deemed to be sufficient. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-disk-virtio-scsi-ccw.args |9 ++

[libvirt] [PATCH 2/3] S390: Enable virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
Newer versions of QEMU support virtio-scsi and virtio-rng devices on the virtio-s390 and ccw busses. Adding capability detecion, address assignment and command line generation for that. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c |4

Re: [libvirt] [PATCH] qemu: detect multi-head qxl via more than version check

2013-03-14 Thread Eric Blake
On 03/14/2013 08:47 AM, Jiri Denemark wrote: On Wed, Mar 13, 2013 at 18:48:46 -0600, Eric Blake wrote: Multi-head QXL support is so useful that distros have started to backport it to qemu earlier than 1.2. After discussion with Alon Levy, we determined that the existence of the

[libvirt] [PATCH 1/3] qemu: rename virtio-scsi capability

2013-03-14 Thread Viktor Mihajlovski
QEMU_CAPS_VIRTIO_SCSI_PCI implies that virtio-scsi is only supported for the PCI bus, which is not the case. Remove the _PCI suffix. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c |4 ++-- src/qemu/qemu_capabilities.h |2 +-

Re: [libvirt] [PATCH 1/3] qemu: rename virtio-scsi capability

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 04:54:21PM +0100, Viktor Mihajlovski wrote: QEMU_CAPS_VIRTIO_SCSI_PCI implies that virtio-scsi is only supported for the PCI bus, which is not the case. Remove the _PCI suffix. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH] util: fix clear_emulator_capabilities=0

2013-03-14 Thread Laine Stump
On 03/13/2013 06:09 PM, Eric Blake wrote: On 03/13/2013 01:37 PM, Laine Stump wrote: My commit 7a2e845a865dc7fa82d2393ea2a770cfc8cf00b4 (and its prerequisites) managed to effectively ignore the clear_emulator_capabilities setting in qemu.conf (visible in the code as the VIR_EXEC_CLEAR_CAPS

Re: [libvirt] can this vm-xml-interface works,thanks

2013-03-14 Thread Laine Stump
On 03/14/2013 05:49 AM, yue wrote: hi,all,please look at interface . actually ,virbr0 is NAT, my program product a vm-xml which is not standard. it use the way to product bridge interface to product a NAT interface. but i want to know if this can work rightly. interface

Re: [libvirt] when define NAT network, assign what kind of forward dev is better

2013-03-14 Thread Laine Stump
On 03/06/2013 11:30 PM, yue wrote: hi all: in my case, my physical machine has one ethernet, i want to use both bridge and nat network. i create a bridge outbr0(addif eth0), when creating NAT network, there are 3 options for forward-dev 1.forward mode=nat / 2.forward mode=nat dev=outbr0/

Re: [libvirt] Adding and Clearing bridge addresses

2013-03-14 Thread Laine Stump
On 03/13/2013 08:34 AM, Gene Czarcinski wrote: On 03/12/2013 03:23 PM, Daniel P. Berrange wrote: On Tue, Mar 12, 2013 at 03:11:56PM -0400, Laine Stump wrote: On 03/12/2013 01:45 PM, Gene Czarcinski wrote: I have been working on this patch to have libvirt optionally set static routes. So I

[libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
Newer versions of QEMU support virtio-scsi and virtio-rng devices on the virtio-s390 and ccw busses. Since the virtio-capability is orthogonal to the implementing bus we add a generic virtio-scsi capability but do not touch the already existing virtio-scsi-pci capability for PCI based systems.

[libvirt] [PATCHv2 2/2] S390: Testcases for virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
Adding test cases for virtio-scsi and virtio-rng. Since ccw is covering the superset of the s390 bus handling, these are deemed to be sufficient. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-disk-virtio-scsi-ccw.args |9 ++

Re: [libvirt] [PATCH 1/4] Make vshDebug work when parsing parameters

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 10:27:32AM +0100, Martin Kletzander wrote: The vshInit initializes ctl-debug by which vshDebug (which is also called in vshParseArgv) decides whether to print out the message or not. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/virsh.c | 6 ++

Re: [libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 10:27:33AM +0100, Martin Kletzander wrote: According to the man page, the memspec parameter should have the '--memspec' option mandatory and this is as close as we can get to that. What this change does is explained below. man virsh: snapshot-create-as ...

Re: [libvirt] [PATCH 4/4] Cleanup useless flags specifications

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 10:27:35AM +0100, Martin Kletzander wrote: After we switched to C99 initialization, I noticed there were many places where the specification of .flags parameter differed. After going through many options and deciding whether to unify the initialization to be '.flags =

[libvirt] [PATCHv2 0/2] Enable virtio-scsi and virtio-rng for s390

2013-03-14 Thread Viktor Mihajlovski
Early QEMU versions did not support virtio-scsi or virtio-rng for s390 machines. This series enables libvirt to exploit the capabilities provided by newer QEMUs. V2 Changes: - Dropped 1/3, the rename of virtio-scsi-pci capability, we will keep it for compatibility reasons. - Add a new

Re: [libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

2013-03-14 Thread Daniel P. Berrange
On Thu, Mar 14, 2013 at 06:12:31PM +0100, Viktor Mihajlovski wrote: Newer versions of QEMU support virtio-scsi and virtio-rng devices on the virtio-s390 and ccw busses. Since the virtio-capability is orthogonal to the implementing bus we add a generic virtio-scsi capability but do not touch

Re: [libvirt] [PATCH 2/4] Fix snapshot-create-as syntax in help output

2013-03-14 Thread Eric Blake
On 03/14/2013 11:16 AM, Daniel P. Berrange wrote: On Thu, Mar 14, 2013 at 10:27:33AM +0100, Martin Kletzander wrote: According to the man page, the memspec parameter should have the '--memspec' option mandatory and this is as close as we can get to that. What this change does is explained

Re: [libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
On 03/14/2013 06:29 PM, Daniel P. Berrange wrote: Sorry, I think I should have been clearer before. I was only meaning to reject the rename of the string. Renaming the exist enum symbol is fine, as long as corresponding string is left unchanged. So no need for this new enum entry. Daniel I

Re: [libvirt] [PATCH] v1:Support for adding a static route to a bridge

2013-03-14 Thread Gene Czarcinski
On 03/13/2013 09:30 PM, Gene Czarcinski wrote: On 03/13/2013 04:04 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this

Re: [libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

2013-03-14 Thread Eric Blake
On 03/14/2013 11:52 AM, Viktor Mihajlovski wrote: On 03/14/2013 06:29 PM, Daniel P. Berrange wrote: Sorry, I think I should have been clearer before. I was only meaning to reject the rename of the string. Renaming the exist enum symbol is fine, as long as corresponding string is left

Re: [libvirt] [PATCHv2 1/2] S390: Enable virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
On 03/14/2013 06:56 PM, Eric Blake wrote: s|virtio-scsi-pci;| /* the -pci suffix is a back-compat historical wart */| don't tempt me use *that* wording ... but, yes I am convinced by now -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research Development

Re: [libvirt] libvirtd segfault

2013-03-14 Thread AL13N
Op maandag 11 maart 2013 12:59:08 schreef Eric Blake: On 03/10/2013 09:25 AM, AL13N wrote: regarding http://www.redhat.com/archives/libvir-list/2012-December/msg01365.html and https://www.redhat.com/archives/libvir-list/2012-December/msg00935.html There have been several fixes

[libvirt] [PATCHv3 0/3] Enable virtio-scsi and virtio-rng for s390

2013-03-14 Thread Viktor Mihajlovski
Early QEMU versions did not support virtio-scsi or virtio-rng for s390 machines. This series enables libvirt to exploit the capabilities provided by newer QEMUs. Note: I have to apologize for the superfluous iterations which could have been avoided by reading the comment in front of the enum...

[libvirt] [PATCHv3 2/3] S390: Enable virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
Newer versions of QEMU support virtio-scsi and virtio-rng devices on the virtio-s390 and ccw busses. Adding capability detecion, address assignment and command line generation for that. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- src/qemu/qemu_capabilities.c |4

[libvirt] [PATCHv3 3/3] S390: Testcases for virtio-scsi and virtio-rng

2013-03-14 Thread Viktor Mihajlovski
Adding test cases for virtio-scsi and virtio-rng. Since ccw is covering the superset of the s390 bus handling, these are deemed to be sufficient. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- .../qemuxml2argv-disk-virtio-scsi-ccw.args |9 ++

[libvirt] [PATCHv3 1/3] qemu: Rename virtio-scsi capability

2013-03-14 Thread Viktor Mihajlovski
QEMU_CAPS_VIRTIO_SCSI_PCI implies that virtio-scsi is only supported for the PCI bus, which is not the case. Remove the _PCI suffix. Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com --- V3 Changes - Rename only the enum symbol, not the string reptresentation

Re: [libvirt] libvirtd segfault

2013-03-14 Thread AL13N
Op maandag 11 maart 2013 12:59:08 schreef Eric Blake: On 03/10/2013 09:25 AM, AL13N wrote: regarding http://www.redhat.com/archives/libvir-list/2012-December/msg01365.html and https://www.redhat.com/archives/libvir-list/2012-December/msg00935.html There have been several fixes

Re: [libvirt] [PATCH] util: fix clear_emulator_capabilities=0

2013-03-14 Thread Laine Stump
On 03/14/2013 12:26 PM, Laine Stump wrote: On 03/13/2013 06:09 PM, Eric Blake wrote: On 03/13/2013 01:37 PM, Laine Stump wrote: My commit 7a2e845a865dc7fa82d2393ea2a770cfc8cf00b4 (and its prerequisites) managed to effectively ignore the clear_emulator_capabilities setting in qemu.conf

Re: [libvirt] RFC: dhcp option element revisited

2013-03-14 Thread Laine Stump
On 03/05/2013 03:48 PM, Laine Stump wrote: Before 1.0.3, Pieter Hollants kindly implemented the XML I had earlier suggested to support configure-by-number dhcp options in libvirt networks. https://www.redhat.com/archives/libvir-list/2013-February/msg01251.html I also posted a followup

Re: [libvirt] [PATCH V1 4/6] Add SELinux labeling support for TPM

2013-03-14 Thread Stefan Berger
On 03/14/2013 10:29 AM, Daniel P. Berrange wrote: On Wed, Mar 13, 2013 at 12:03:52PM -0400, Stefan Berger wrote: Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- src/security/security_selinux.c | 90 1 file changed, 90 insertions(+) I

Re: [libvirt] [PATCH] util: fix clear_emulator_capabilities=0

2013-03-14 Thread Eric Blake
On 03/14/2013 01:09 PM, Laine Stump wrote: -capng_clear(CAPNG_SELECT_BOTH); +if (clearExistingCaps || (uid != 1 uid != 0)) Did you mean uid != 0? Well, actually I meant uid != -1 uid != 0 (and I had to look at it 5 times to see that the negative sign was missing). 'uid != -1'

Re: [libvirt] [PATCH 3/4] Allow multiple parameters for schedinfo

2013-03-14 Thread Eric Blake
On 03/14/2013 03:27 AM, Martin Kletzander wrote: virsh schedinfo was able to set only one parameter at a time (not counting the deprecated options), but it is useful to set more at once, so this patch adds the possibility to do stuff like this: virsh schedinfo domain cpu_shares=0

  1   2   >