Re: [libvirt] [PATCH] Fix parsing of bond interface XML

2013-03-21 Thread Eric Blake
On 03/21/2013 03:50 PM, Jim Fehlig wrote: Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface This configuration does not

Re: [libvirt] [PATCH] nwfilter: probe for inverted ctdir

2013-03-21 Thread Eric Blake
On 03/21/2013 04:04 PM, Stefan Berger wrote: Linux netfilter at some point inverted the meaning of the '--ctdir reply' and newer netfilter implementations now expect '--ctdir original' instread and vice-versa. s/instread/instead/ We probe for this netfilter change via a UDP message over

[libvirt] [PATCH V2] Fix parsing of bond interface XML

2013-03-21 Thread Jim Fehlig
Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface This configuration does not contain the optional updelay and downdelay

Re: [libvirt] [PATCH] Fix parsing of bond interface XML

2013-03-21 Thread Jim Fehlig
Eric Blake wrote: On 03/21/2013 03:50 PM, Jim Fehlig wrote: Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface This

Re: [libvirt] [PATCH V2] Fix parsing of bond interface XML

2013-03-21 Thread Eric Blake
On 03/21/2013 05:13 PM, Jim Fehlig wrote: Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface This configuration does not

Re: [libvirt] [PATCH V2] Fix parsing of bond interface XML

2013-03-21 Thread Jim Fehlig
Eric Blake wrote: On 03/21/2013 05:13 PM, Jim Fehlig wrote: Noticed that parsing bond interface XML containing the miimon element fails interface type=bond name=bond0 ... bond mode=active-backup miimon freq=100 carrier=netif/ ... /bond /interface This

Re: [libvirt] [PATCH] nwfilter: probe for inverted ctdir

2013-03-21 Thread Stefan Berger
On 03/21/2013 06:26 PM, Eric Blake wrote: On 03/21/2013 04:04 PM, Stefan Berger wrote: C guarantees that this is initialized to false without having to explicitly state that. Looks big, but it's a one-time probe done at initialization, and seems like it does the trick. You may want to wait for

Re: [libvirt] [PATCH] Make virsh support '~' and '$HOME' in interactive mode

2013-03-21 Thread Zhang Xiaohe
于 2013年03月21日 21:08, Eric Blake 写道: On 03/21/2013 04:20 AM, Daniel P. Berrange wrote: In other words, if we're going to do this, go all the way and use wordexp() to get shell-like expansion, instead of reinventing it ourselves. Except that wordexp() is not portable to mingw, and not provided

Re: [libvirt] [PATCH] nwfilter: probe for inverted ctdir

2013-03-21 Thread Eric Blake
On 03/21/2013 06:40 PM, Stefan Berger wrote: On 03/21/2013 06:26 PM, Eric Blake wrote: On 03/21/2013 04:04 PM, Stefan Berger wrote: C guarantees that this is initialized to false without having to explicitly state that. Looks big, but it's a one-time probe done at initialization, and seems

Re: [libvirt] [PATCH] Make virsh support '~' and '$HOME' in interactive mode

2013-03-21 Thread Eric Blake
On 03/21/2013 07:33 PM, Zhang Xiaohe wrote: 于 2013年03月21日 21:08, Eric Blake 写道: On 03/21/2013 04:20 AM, Daniel P. Berrange wrote: In other words, if we're going to do this, go all the way and use wordexp() to get shell-like expansion, instead of reinventing it ourselves. Except that

Re: [libvirt] [PATCH 2/2] make: regenerate bindings when classname.py changes

2013-03-21 Thread Guannan Ren
On 03/21/2013 06:48 PM, Osier Yang wrote: On 2013年03月21日 16:41, Guannan Ren wrote: --- python/Makefile.am | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/python/Makefile.am b/python/Makefile.am index 55c5e41..18da9a2 100644 --- a/python/Makefile.am +++

Re: [libvirt] [PATCH 1/2] python: treat flags as default argument with value 0

2013-03-21 Thread Guannan Ren
On 03/21/2013 06:47 PM, Osier Yang wrote: On 2013年03月21日 16:41, Guannan Ren wrote: The following four functions have not changed because default arguments have to come after positional arguments. Changing them will break the the binding APIs. migrate(self, dconn, flags, dname, uri, bandwidth):

Re: [libvirt] [PATCH 1/2] python: treat flags as default argument with value 0

2013-03-21 Thread Eric Blake
On 03/21/2013 04:47 AM, Osier Yang wrote: On 2013年03月21日 16:41, Guannan Ren wrote: The following four functions have not changed because default arguments have to come after positional arguments. Changing them will break the the binding APIs. migrate(self, dconn, flags, dname, uri,

Re: [libvirt] [PATCH 2/2] make: regenerate bindings when classname.py changes

2013-03-21 Thread Eric Blake
On 03/21/2013 02:41 AM, Guannan Ren wrote: --- python/Makefile.am | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/python/Makefile.am b/python/Makefile.am index 55c5e41..18da9a2 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -26,7 +26,8 @@

Re: [libvirt] [PATCH] Make virsh support '~' and '$HOME' in interactive mode

2013-03-21 Thread Zhang Xiaohe
于 2013年03月22日 10:17, Eric Blake 写道: On 03/21/2013 07:33 PM, Zhang Xiaohe wrote: 于 2013年03月21日 21:08, Eric Blake 写道: On 03/21/2013 04:20 AM, Daniel P. Berrange wrote: In other words, if we're going to do this, go all the way and use wordexp() to get shell-like expansion, instead of reinventing

Re: [libvirt] [PATCH] qemu: add support for LSI MegaRAID SAS1078 (aka megasas) SCSI controller

2013-03-21 Thread Osier Yang
On 2013年03月21日 22:11, Paolo Bonzini wrote: This does nothing more than adding the new device and capability. The device is present since QEMU 1.2.0. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- docs/formatdomain.html.in | 6 ++-- docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH 1/2] python: treat flags as default argument with value 0

2013-03-21 Thread Eric Blake
On 03/21/2013 09:24 PM, Guannan Ren wrote: migrate(self, dconn, flags, dname, uri, bandwidth): migrate2(self, dconn, dxml, flags, dname, uri, bandwidth): migrateToURI(self, duri, flags, dname, bandwidth): migrateToURI2(self, dconnuri, miguri, dxml, flags, dname, bandwidth): So how are they

Re: [libvirt] [PATCH 1/2] python: treat flags as default argument with value 0

2013-03-21 Thread Guannan Ren
On 03/22/2013 11:31 AM, Eric Blake wrote: On 03/21/2013 09:24 PM, Guannan Ren wrote: migrate(self, dconn, flags, dname, uri, bandwidth): migrate2(self, dconn, dxml, flags, dname, uri, bandwidth): migrateToURI(self, duri, flags, dname, bandwidth): migrateToURI2(self, dconnuri, miguri, dxml,

Re: [libvirt] [PATCH] Make virsh support '~' and '$HOME' in interactive mode

2013-03-21 Thread Eric Blake
On 03/21/2013 09:18 PM, Zhang Xiaohe wrote: Originally, I think '~' and '$HOME' is most commonly used, so it should be acceptable to just expand these. But now I'm confused. You said if we're going to do this, go all the way Expanding just '~' and '$HOME' but nothing else is a disservice to

[libvirt] Build failed in Jenkins: libvirt-syntax-check #759

2013-03-21 Thread Jenkins CI
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/759/ -- Started by upstream project libvirt-build build number 856 [workspace] $ /bin/sh -xe /tmp/hudson8330114436432330964.sh + make syntax-check GENbracket-spacing-check GFDL_version 0.88

[libvirt] [PATCH] Link libvirt_util with numa library

2013-03-21 Thread prasadjoshi . linux
From: Prasad Joshi prasadjoshi.li...@gmail.com When the libvirt is configured with numactl, the virt-aa-helper compilation fails with following errors CCLD virt-aa-helper libvirt_util.a(...): In function `virNumaSetupMemoryPolicy': virnuma.c:109: undefined reference to `numa_available'

Re: [libvirt] [PATCH] Link libvirt_util with numa library

2013-03-21 Thread Eric Blake
On 03/21/2013 10:01 PM, prasadjoshi.li...@gmail.com wrote: From: Prasad Joshi prasadjoshi.li...@gmail.com When the libvirt is configured with numactl, the virt-aa-helper compilation fails with following errors The patch fixes this problem by adding numa library to the list of libraries

[libvirt] [PATCH] python:remove semicolon in python code

2013-03-21 Thread Guannan Ren
This breaked make syntax-check testing Pushed under trivial rule --- python/generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/generator.py b/python/generator.py index fbaf797..0237374 100755 --- a/python/generator.py +++ b/python/generator.py @@ -1490,7

Re: [libvirt] [PATCH v2 0/6] libvirt support for userspace iSCSI initiator (libiscsi)

2013-03-21 Thread Osier Yang
On 2013年03月21日 22:43, Osier Yang wrote: On 2013年03月21日 20:46, Daniel P. Berrange wrote: On Thu, Mar 21, 2013 at 12:53:48PM +0100, Paolo Bonzini wrote: This series adds support for the libiscsi userspace initiator. Compared to v1, logical units are now specified with IQN/LUN syntax in the name

Re: [libvirt] [PATCH] qemu: add support for LSI MegaRAID SAS1078 (aka megasas) SCSI controller

2013-03-21 Thread Osier Yang
On 2013年03月22日 11:29, Osier Yang wrote: On 2013年03月21日 22:11, Paolo Bonzini wrote: This does nothing more than adding the new device and capability. The device is present since QEMU 1.2.0. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- docs/formatdomain.html.in | 6 ++--

Re: [libvirt] Build failed in Jenkins: libvirt-syntax-check #759

2013-03-21 Thread Osier Yang
On 2013年03月22日 11:54, Jenkins CI wrote: Seehttp://honk.sigxcpu.org:8001/job/libvirt-syntax-check/759/ -- Started by upstream project libvirt-build build number 856 [workspace] $ /bin/sh -xe /tmp/hudson8330114436432330964.sh + make syntax-check GEN

Re: [libvirt] Cannot initialize thread local for current identity

2013-03-21 Thread Osier Yang
On 2013年03月21日 19:48, Gao feng wrote: When I play with the latest libvirt,my libvirtd force me out of console of domain. I find the problem is introduced by commit ebf78be4c277cffae57d99daa199a9b3c1cf9804 Set the current client identity during API call dispatch. Below is the error message

[libvirt] Jenkins build is back to normal : libvirt-syntax-check #760

2013-03-21 Thread Jenkins CI
See http://honk.sigxcpu.org:8001/job/libvirt-syntax-check/760/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Make virsh support '~' and '$HOME' in interactive mode

2013-03-21 Thread Zhang Xiaohe
于 2013年03月22日 11:43, Eric Blake 写道: Expanding everything means re-implementing what the shell does. wordexp() would be ideal for this, except that wordexp() is not portable enough. By the time we end up rewriting enough code to do what wordexp() already could do, we are adding lots of bloat

Re: [libvirt] Problems with filesystem type='block'

2013-03-21 Thread Doug Goldstein
On Sun, Mar 3, 2013 at 11:19 PM, Gao feng gaof...@cn.fujitsu.com wrote: Hi Doug, On 2013/03/04 12:38, Doug Goldstein wrote: On Sun, Mar 3, 2013 at 5:24 PM, Doug Goldstein car...@gentoo.org wrote: On Fri, Dec 21, 2012 at 10:15 PM, Lars Kellogg-Stedman l...@oddbit.com wrote: Using libvirt

Re: [libvirt] Cannot initialize thread local for current identity

2013-03-21 Thread Gao feng
On 2013/03/22 12:20, Osier Yang wrote: On 2013年03月21日 19:48, Gao feng wrote: When I play with the latest libvirt,my libvirtd force me out of console of domain. I find the problem is introduced by commit ebf78be4c277cffae57d99daa199a9b3c1cf9804 Set the current client identity during API

<    1   2