-Original Message-
From: Gao feng [mailto:gaof...@cn.fujitsu.com]
Sent: Wednesday, March 27, 2013 5:10 AM
To: Purcareata Bogdan-B43198
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] Unable to start container on Fedora 17 with kernel
3.8.0
On 2013/03/27 01:12, Purcareata
On Mon, Mar 25, 2013 at 11:47:21 +0100, Peter Krempa wrote:
On 03/25/13 11:43, Jiri Denemark wrote:
When we write a log message into a log, we separate thread ID from
timestamp using : . However, when storing the message into the ring
buffer, we omitted the separator, e.g.:
On Tue, Mar 26, 2013 at 10:17:01 -0600, Eric Blake wrote:
On 03/26/2013 09:52 AM, Jiri Denemark wrote:
Despite of the comment stating virNetClientIncomingEvent handler should
s/of //
never be called with either client-haveTheBuck or client-wantClose
set, there is a sequence of events
2013/3/26 Osier Yang jy...@redhat.com:
On 25/03/13 14:51, Chunyan Liu wrote:
2013/3/22 Osier Yang jy...@redhat.com:
On 2013年03月22日 17:36, Chunyan Liu wrote:
Hi, List,
As the mail I've sent a week before:
https://www.redhat.com/archives/libvir-list/2013-March/msg00730.html
I'm willing to
On 03/26/13 10:54, Viktor Mihajlovski wrote:
Check function pointer before calling.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/remote/remote_driver.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c
On Tue, Mar 26, 2013 at 12:46:52 +, Yuan, Ye A wrote:
Hi all,
I'm a graduate student in Shanghai, and will do experiment about live
migration using KVM as hypervisor.
Due to my demand, I want to get each iteration time and downtime in
migration.
I found there is no API to implement
On Mon, Mar 25, 2013 at 01:20:19PM +0800, Alex Jia wrote:
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=924574
Valgrind defects memory error:
==19297== Invalid free() / delete / delete[] / realloc()
==19297==at 0x4A077A6: free (vg_replace_malloc.c:446)
==19297==by
On Mon, Mar 25, 2013 at 06:41:37PM +0800, Alex Jia wrote:
Signed-off-by: Alex Jia a...@redhat.com
---
bin/virt-sandbox-service-create.pod |7 ++-
bin/virt-sandbox.c |7 ++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git
On 03/26/13 10:54, Viktor Mihajlovski wrote:
By adjusting the reference count of the connection object we
prevent races between callback function and virConnectClose.
Hum. Here I agree that this is definitely possible (and I managed to
reproduce the invalid read and possible memory
On Wed, Mar 27, 2013 at 11:16:26AM +0100, Peter Krempa wrote:
On 03/26/13 10:54, Viktor Mihajlovski wrote:
By adjusting the reference count of the connection object we
prevent races between callback function and virConnectClose.
Hum. Here I agree that this is definitely possible (and I
---
src/qemu/qemu_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1f9b8b2..96bf235 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -950,6 +950,7 @@ qemuShutdown(void) {
return -1;
---
src/uml/uml_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index b08212d..09a777c 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -640,6 +640,7 @@ umlShutdown(void) {
Jiri thank you, and I will attempt to do some research using
virDomainGetJobStats API.
Any stupid questions I will ask you later if necessary. :)
Best wishes,
Yale Yuan
-Original Message-
From: Jiri Denemark [mailto:jdene...@redhat.com]
Sent: Wednesday, March 27, 2013 5:38 PM
To:
On 03/27/13 11:51, Daniel P. Berrange wrote:
On Wed, Mar 27, 2013 at 11:16:26AM +0100, Peter Krempa wrote:
On 03/26/13 10:54, Viktor Mihajlovski wrote:
By adjusting the reference count of the connection object we
prevent races between callback function and virConnectClose.
Hum. Here I agree
Jiri, sorry for my stupid.
I read your instruction about your API, but there is no function do get
'iteration time'.
Does that mean I should implement it by myself?
And if I want to get the dirty page bitmap, should I review libvirt source code
and print information to log file during migration?
On Wed, Mar 27, 2013 at 12:22:39 +, Yuan, Ye A wrote:
I read your instruction about your API, but there is no function do
get 'iteration time'.
Right, you can only get downtime. The reason is that QEMU does not
provide statistics about iteration time.
Does that mean I should implement it
On 03/26/13 10:54, Viktor Mihajlovski wrote:
Before closing the connection we unregister the close callback
to prevent a reference leak. We make sure that we only unregister
if we have previously registered a callback (not the case for
virsh connect!). Further, the messages on virConnectClose !=
On 03/21/2013 05:42 PM, Peter Krempa wrote:
Use the established approach to improve this function too.
---
tools/virsh-domain.c | 52
+++-
tools/virsh.pod | 15 +++
2 files changed, 50 insertions(+), 17 deletions(-)
diff
On 03/21/2013 03:11 PM, Peter Krempa wrote:
This patch uses the new helper to avoid the more complex check for
domain state modification flags.
---
ACK after 1.0.4,
Martin
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 03/21/2013 05:42 PM, Peter Krempa wrote:
The man page states that with --config the next boot is affected. This
can be understood as if _only_ the next bood was affected. This isn't
s/bood/boot/
true if the machine is running.
This patch adds the full --live, --config, --current
On 03/21/2013 05:42 PM, Peter Krempa wrote:
flags were declared as signed and the parameter options can be
declared directly.
I don't see any 'signed flags' here,
ACK after 1.0.4 with that sentece removed.
Martin
--
libvir-list mailing list
libvir-list@redhat.com
:):):)
I found that QEMU do migration and libvirt invoke it
Thanks your help, Jiri!
I will view QEMU source code ~~~!!!
Best wishes,
Yale Yuan
-Original Message-
From: Jiri Denemark (jdene...@redhat.com) [mailto:jdene...@redhat.com]
Sent: Wednesday, March 27, 2013 8:47 PM
To:
On 03/27/13 10:36, Peter Krempa wrote:
On 03/26/13 10:54, Viktor Mihajlovski wrote:
Check function pointer before calling.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/remote/remote_driver.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
ACK. The
From: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
Before closing the connection we unregister the close callback
to prevent a reference leak.
Further, the messages on virConnectClose != 0 are a bit more specific
now.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
From: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
By adjusting the reference count of the connection object we
prevent races between callback function and virConnectClose.
Signed-off-by: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com
---
src/libvirt.c | 5 +
1 file changed, 5
The function is used to establish connection so it should be in the main
virsh file. This movement also enables further improvements done in next
patches.
---
tools/virsh-host.c | 67
tools/virsh.c | 69
This patch improves the error message after disconnecting from the
hypervisor and adds the close callback operations required not to leak
the callback reference.
---
tools/virsh.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/tools/virsh.c
Originaly reported by Viktor, this changes a few bits I didn't like
on the original series.
Peter Krempa (2):
virsh: Move cmdConnect from virsh-host.c to virsh.c
virsh: Register and unregister the close callback also in cmdConnect
Viktor Mihajlovski (2):
libvirt: Increase connection
On 03/27/2013 03:05 PM, Peter Krempa wrote:
This patch improves the error message after disconnecting from the
hypervisor and adds the close callback operations required not to leak
the callback reference.
---
tools/virsh.c | 23 +--
1 file changed, 17 insertions(+), 6
On 03/27/13 16:00, Viktor Mihajlovski wrote:
On 03/27/2013 03:05 PM, Peter Krempa wrote:
This patch improves the error message after disconnecting from the
hypervisor and adds the close callback operations required not to leak
the callback reference.
---
tools/virsh.c | 23
On 03/15/2013 10:19 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
Currently, -machine option is used only when dump-guest-core is set.
To use options defined in machine option for newer version of QEMU,
it needs to use -machine xxx, and to be compatible with older
On 03/27/13 16:05, Peter Krempa wrote:
On 03/27/13 16:00, Viktor Mihajlovski wrote:
On 03/27/2013 03:05 PM, Peter Krempa wrote:
This patch improves the error message after disconnecting from the
hypervisor and adds the close callback operations required not to leak
the callback reference.
---
On 03/21/2013 12:42 PM, Peter Krempa wrote:
The man page states that with --config the next boot is affected. This
can be understood as if _only_ the next bood was affected. This isn't
true if the machine is running.
Are you certain of that? My understanding was that when --config was
On 03/27/2013 04:13 PM, Peter Krempa wrote:
I've re-run the test suite and I'm not getting any errors. I have the
current upstream (including your 2/3 patch from v1) and these four on top.
What tests are failing for you?
Peter
After taking out 1/3 I don't get the errors, which is logical,
On 03/27/13 16:26, Viktor Mihajlovski wrote:
On 03/27/2013 04:13 PM, Peter Krempa wrote:
I've re-run the test suite and I'm not getting any errors. I have the
current upstream (including your 2/3 patch from v1) and these four on
top.
What tests are failing for you?
Peter
After taking out
When libvirtd loads active network configs from network state directory,
it should release the class_id memory block which was allocated
at the time of loading xml from network config directory.
virBitmapParse will create a new memory block of bitmap class_id which
causes a memory leak.
This
On 03/27/13 16:22, Laine Stump wrote:
On 03/21/2013 12:42 PM, Peter Krempa wrote:
The man page states that with --config the next boot is affected. This
can be understood as if _only_ the next bood was affected. This isn't
true if the machine is running.
Are you certain of that? My
On 03/27/2013 04:32 PM, Peter Krempa wrote:
My tree actually contains 1/3 from your v1 series and I also reposted it
in my v2 and I don't seem to be getting errors when I have the 4 (5 with
the one pushed upstream) patches applied.
Peter
Never mind and sorry. It seems that I was tricked by
On 03/27/2013 12:02 PM, Guannan Ren wrote:
---
src/qemu/qemu_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1f9b8b2..96bf235 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -950,6 +950,7 @@
On 03/27/2013 12:03 PM, Guannan Ren wrote:
---
src/uml/uml_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index b08212d..09a777c 100644
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -640,6 +640,7 @@ umlShutdown(void) {
On 03/27/13 13:53, Martin Kletzander wrote:
On 03/21/2013 05:42 PM, Peter Krempa wrote:
Use the established approach to improve this function too.
---
tools/virsh-domain.c | 52 +++-
tools/virsh.pod | 15 +++
2 files changed,
On 03/27/2013 11:39 AM, Peter Krempa wrote:
On 03/27/13 16:22, Laine Stump wrote:
On 03/21/2013 12:42 PM, Peter Krempa wrote:
The man page states that with --config the next boot is affected. This
can be understood as if _only_ the next bood was affected. This isn't
true if the machine is
On 03/26/2013 07:59 AM, Stefan Berger wrote:
On 03/22/2013 04:37 PM, Stefan Berger wrote:
Linux netfilter at some point inverted the meaning of the '--ctdir
reply'
and newer netfilter implementations now expect '--ctdir original'
instead and vice-versa.
We probe for this netfilter change via
This one is a 'one-off' but it ought to be possible to use the generator
to create the function (it has signature 'conn, int, int : int')
Signed-off-by: David Scott dave.sc...@eu.citrix.com
---
config.h.in |3 +++
configure.ac|1 +
libvirt/.depend
Hi,
I've made an prototype set of ocaml bindings for the libvirt event
mechanism -- here is what I've got so far.
It's possible to register for all the types supported by
virConnectDomainEventRegisterAny
I've not tested each type of event yet, but the basics are all working.
For every
Signed-off-by: David Scott dave.sc...@eu.citrix.com
---
.gitignore|1 +
Makefile.in |1 +
examples/.depend | 14 ++---
examples/Makefile.in | 13 -
examples/domain_events.ml | 124 +
5 files
A client may register a callback as follows:
E.register_default_impl ();
let conn = C.connect_readonly ?name () in
E.register_any conn (E.Lifecycle (fun dom e -
printd dom Lifecycle %s (E.Lifecycle.to_string e)
));
Internally this will:
1. generate a unique int64 used
On 03/27/13 17:25, Laine Stump wrote:
On 03/27/2013 11:39 AM, Peter Krempa wrote:
On 03/27/13 16:22, Laine Stump wrote:
On 03/21/2013 12:42 PM, Peter Krempa wrote:
The man page states that with --config the next boot is affected. This
can be understood as if _only_ the next bood was affected.
On Wed, Mar 27, 2013 at 04:59:29PM +, David Scott wrote:
Hi,
I've made an prototype set of ocaml bindings for the libvirt event
mechanism -- here is what I've got so far.
It's possible to register for all the types supported by
virConnectDomainEventRegisterAny
I've not tested
On 03/27/2013 09:35 AM, Guannan Ren wrote:
When libvirtd loads active network configs from network state directory,
it should release the class_id memory block which was allocated
at the time of loading xml from network config directory.
virBitmapParse will create a new memory block of bitmap
On 03/27/2013 10:30 AM, Laine Stump wrote:
My opinion is that the patch we should apply should be a simple patch
that just removes use of --ctdir. According to the netfilter developer
who responded to the thread on libvirt-users, it doesn't add any extra
security not already provided by
If an IPv4 address is *not* specified, then the IPv4 network is isolated
and, by default, internal (internal to the specific interface) IPv4
routing is enabled..
If an IPv6 address is *not* specified, then the IPv6 network is isolated
and, by default, internal IPv6 routing is disabled but can
On 03/26/2013 08:06 AM, Martin Kletzander wrote:
On 03/26/2013 12:26 PM, Peter Krempa wrote:
Format the address using the helper to avoid code duplication.
---
src/conf/domain_conf.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
I'd ACK that, fine use for the cleanup, but
On 03/21/2013 09:35 AM, Michal Privoznik wrote:
Don't forget other seclabels when adding a seclabel type='none'/.
Michal Privoznik (2):
security_manager: Don't manipulate domain XML in
virDomainDefGetSecurityLabelDef
security: Don't add seclabel of type none if there's already a
On 03/25/2013 10:43 AM, Osier Yang wrote:
v2: https://www.redhat.com/archives/libvir-list/2013-February/msg00118.html
v2 - v3:
* 6/8 of v1 is ACKed/pushed.
* Use virStringToLong_ui instead of sscanf
* Fixed various nits pointed out by John
This is the 3rd part to implement NPIV
On 03/25/2013 09:24 PM, Hu Tao wrote:
On Mon, Mar 25, 2013 at 08:39:40PM +0100, Stefan Seyfried wrote:
Hi all,
iptables-1.4.18 removed the long deprecated state match.
Use conntrack instead in forwarding rules.
Fixes openSUSE bug https://bugzilla.novell.com/811251 #811251.
real patch is
On 03/25/2013 08:25 AM, Paolo Bonzini wrote:
The need_prctl variable is not really needed. If it is false,
capng_apply will be called twice with the same set, causing
a little extra work but no problem. This keeps the code a bit
simpler.
It is also clearer to invoke
On 03/25/2013 08:25 AM, Paolo Bonzini wrote:
When running unprivileged, virSetUIDGIDWithCaps will fail because it
tries to add the requested capabilities to the permitted and effective
sets.
Detect this case, and invoke the child with cleared permitted and
effective sets. If it is a setuid
On 03/27/2013 02:01 PM, Eric Blake wrote:
On 03/27/2013 10:30 AM, Laine Stump wrote:
My opinion is that the patch we should apply should be a simple patch
that just removes use of --ctdir. According to the netfilter developer
who responded to the thread on libvirt-users, it doesn't add any
On 03/27/2013 06:06 PM, Daniel P. Berrange wrote:
On Mon, Mar 25, 2013 at 06:41:37PM +0800, Alex Jia wrote:
Signed-off-by: Alex Jiaa...@redhat.com
---
bin/virt-sandbox-service-create.pod |7 ++-
bin/virt-sandbox.c |7 ++-
2 files changed, 12 insertions(+), 2
On 03/27/2013 06:05 PM, Daniel P. Berrange wrote:
On Mon, Mar 25, 2013 at 01:20:19PM +0800, Alex Jia wrote:
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=924574
Valgrind defects memory error:
==19297== Invalid free() / delete / delete[] / realloc()
==19297==at 0x4A077A6: free
On Wed, Mar 27, 2013 at 5:22 PM, Eric Blake ebl...@redhat.com wrote:
On 03/25/2013 09:24 PM, Hu Tao wrote:
On Mon, Mar 25, 2013 at 08:39:40PM +0100, Stefan Seyfried wrote:
Hi all,
iptables-1.4.18 removed the long deprecated state match.
Use conntrack instead in forwarding rules.
Fixes
On 2013年03月27日 23:08, Martin Kletzander wrote:
On 03/15/2013 10:19 AM, Li Zhang wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
Currently, -machine option is used only when dump-guest-core is set.
To use options defined in machine option for newer version of QEMU,
it needs to use
I tagged it in git and pushed the tarball to the usual area:
ftp://libvirt.org/libvirt/
the rpms are being pushed ATM.
Based on my own limited testing this still looks like good to go,
but more feedback (portability ?) would be nice.
If all goes well this will go out very early on Monday as
On 28/03/13 06:00, Eric Blake wrote:
On 03/25/2013 10:43 AM, Osier Yang wrote:
v2: https://www.redhat.com/archives/libvir-list/2013-February/msg00118.html
v2 - v3:
* 6/8 of v1 is ACKed/pushed.
* Use virStringToLong_ui instead of sscanf
* Fixed various nits pointed out by John
This is
On 03/28/2013 01:45 AM, Eric Blake wrote:
On 03/27/2013 09:35 AM, Guannan Ren wrote:
When libvirtd loads active network configs from network state directory,
it should release the class_id memory block which was allocated
at the time of loading xml from network config directory.
virBitmapParse
On 03/28/2013 12:00 AM, Martin Kletzander wrote:
On 03/27/2013 12:02 PM, Guannan Ren wrote:
---
src/qemu/qemu_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 1f9b8b2..96bf235 100644
--- a/src/qemu/qemu_driver.c
+++
On 03/28/2013 12:01 AM, Martin Kletzander wrote:
On 03/27/2013 12:03 PM, Guannan Ren wrote:
---
src/uml/uml_driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index b08212d..09a777c 100644
--- a/src/uml/uml_driver.c
+++
68 matches
Mail list logo
