[libvirt] [PATCH] Wire up sysinfo for LXC driver

2013-04-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The sysinfo code used by QEMU is trivially portable to the LXC driver --- src/lxc/lxc_conf.h | 3 +++ src/lxc/lxc_driver.c | 29 + 2 files changed, 32 insertions(+) diff --git a/src/lxc/lxc_conf.h b/src/lxc/lxc_conf.h

[libvirt] [PATCH] Add armv6l architecture to list of valid arches

2013-04-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The Raspberry Pi runs the armv6l architecture and apparently people are trying to run libvirt LXC on it. So we should allow that as a valid arch Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virarch.c | 1 + src/util/virarch.h |

[libvirt] [PATCH] Cope with missing /sys/devices/system/cpu/cpu0/topology files

2013-04-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Not all kernel builds have any entries under the location /sys/devices/system/cpu/cpu0/topology. We already cope with that being missing in some cases, but not all. Update the code which looks for thread_siblings to cope with the missing file

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-03 Thread Gene Czarcinski
On 04/02/2013 03:31 PM, Laine Stump wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this functionality

Re: [libvirt] [PATCH] Wire up sysinfo for LXC driver

2013-04-03 Thread Eric Blake
On 04/03/2013 11:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The sysinfo code used by QEMU is trivially portable to the LXC driver --- src/lxc/lxc_conf.h | 3 +++ src/lxc/lxc_driver.c | 29 + 2 files changed, 32

Re: [libvirt] [PATCH] Implement minimal sysinfo for ARM platforms

2013-04-03 Thread Eric Blake
On 04/03/2013 11:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Implement the bare minimal sysinfo for ARM platforms by reading the CPU models from /proc/cpuinfo Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/util/virsysinfo.c

[libvirt] [PATCH] Create fake NUMA info if libnuma isn't available

2013-04-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If libnuma is not compiled in, or numa_available() returns an error, stub out fake NUMA info consisting of one NUMA cell containing all CPUs and memory. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- src/nodeinfo.c | 137

[libvirt] [PATCH v2 2/3] Auto-add a root filesystem element to LXC containers on startup

2013-04-03 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Currently the LXC container code has two codepaths, depending on whether there is a filesystem element with a target path of '/'. If we automatically add a filesystem device with src=/ and dst=/, for any container which has not specified a root

[libvirt] libvirtd segfault on latest git

2013-04-03 Thread Luiz Capitulino
Hi, Libvirtd from latest git (HEAD fc8c1787) is segfaulting when I try to restore a previously saved domain (backtrace below). I was testing a custom QEMU when it happened first time, but it also happens with latest qemu.git (HEAD 162cbbd17). What I did to run libvirt from source was: 1. Build

[libvirt] [PATCH] security_manager: fix comparison

2013-04-03 Thread Guido Günther
otherwise we crash later on if we don't find a match like: #0 0xb72c2b4f in virSecurityManagerGenLabel (mgr=0xb8e42d20, vm=0xb8ef40c0) at security/security_manager.c:424 #1 0xb18811f3 in qemuProcessStart (conn=conn@entry=0xb8eed880, driver=driver@entry=0xb8e3b1e0, vm=vm@entry=0xb8ef58f0,

Re: [libvirt] [PATCH] security_manager: fix comparison

2013-04-03 Thread Luiz Capitulino
On Wed, 3 Apr 2013 22:23:28 +0200 Guido Günther a...@sigxcpu.org wrote: otherwise we crash later on if we don't find a match like: #0 0xb72c2b4f in virSecurityManagerGenLabel (mgr=0xb8e42d20, vm=0xb8ef40c0) at security/security_manager.c:424 #1 0xb18811f3 in qemuProcessStart

Re: [libvirt] [PATCH] security_manager: fix comparison

2013-04-03 Thread Guido Günther
On Wed, Apr 03, 2013 at 02:53:05PM -0600, Eric Blake wrote: On 04/03/2013 02:40 PM, Luiz Capitulino wrote: On Wed, 3 Apr 2013 22:23:28 +0200 Guido Günther a...@sigxcpu.org wrote: otherwise we crash later on if we don't find a match like: #0 0xb72c2b4f in virSecurityManagerGenLabel

Re: [libvirt] [PATCH] Cope with missing /sys/devices/system/cpu/cpu0/topology files

2013-04-03 Thread Eric Blake
On 04/03/2013 01:31 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Not all kernel builds have any entries under the location /sys/devices/system/cpu/cpu0/topology. We already cope with that being missing in some cases, but not all. Update the code which looks for

Re: [libvirt] [PATCH] Add armv6l architecture to list of valid arches

2013-04-03 Thread Eric Blake
On 04/03/2013 12:59 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The Raspberry Pi runs the armv6l architecture and apparently people are trying to run libvirt LXC on it. So we should allow that as a valid arch Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Create fake NUMA info if libnuma isn't available

2013-04-03 Thread Eric Blake
On 04/03/2013 02:12 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If libnuma is not compiled in, or numa_available() returns an error, stub out fake NUMA info consisting of one NUMA cell containing all CPUs and memory. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] security_manager: fix comparison

2013-04-03 Thread Eric Blake
On 04/03/2013 02:40 PM, Luiz Capitulino wrote: On Wed, 3 Apr 2013 22:23:28 +0200 Guido Günther a...@sigxcpu.org wrote: otherwise we crash later on if we don't find a match like: #0 0xb72c2b4f in virSecurityManagerGenLabel (mgr=0xb8e42d20, vm=0xb8ef40c0) at

Re: [libvirt] [PATCH v2 2/3] Auto-add a root filesystem element to LXC containers on startup

2013-04-03 Thread Eric Blake
On 04/03/2013 02:15 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Currently the LXC container code has two codepaths, depending on whether there is a filesystem element with a target path of '/'. If we automatically add a filesystem device with src=/ and dst=/,

Re: [libvirt] [PATCH] Add support for SD cards in nodedev driver

2013-04-03 Thread Eric Blake
On 04/03/2013 11:24 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The nodedev driver currently only detects harddisk, cdrom and floppy devices. This adds support for SD cards, which are common storage for ARM devices, eg the Google ChromeBook device

[libvirt] [sandbox PATCH 04/15] Add -u UNITFILE option to virt-sandbox-service reload command

2013-04-03 Thread Dan Walsh
The command will allow administrators or the systemd service to reload units which are running within a container. If you have one or more units defined for a container, then just those units will get the reloads, as opposed to stopping and restarting the container. --- bin/virt-sandbox-service

[libvirt] [sandbox PATCH 07/15] Remove distinction from Internal vs External Functions.

2013-04-03 Thread Dan Walsh
This patch removes all __METHOD and _METHOD functions calls. Since it is not intended that virt-sandbox-service will be imported into another python module, there is limited value to using the internal indicators. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 118

[libvirt] [sandbox PATCH 01/15] virt-sandbox-service-util needs to free allocated memory.

2013-04-03 Thread Dan Walsh
Coverity found that we could be leaking memory with virt-sandbox-service-util -e --- bin/virt-sandbox-service-util.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/bin/virt-sandbox-service-util.c b/bin/virt-sandbox-service-util.c index 4d164d8..a292fcd 100644 ---

[libvirt] [sandbox PATCH 09/15] Add exception handler GlibGerror to virt-sandbox-service

2013-04-03 Thread Dan Walsh
GlibGerror can be raised by virt-sandbox-service, this patch will catch the exception and write the error to stderr. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 4 1 file changed, 4 insertions(+) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service

[libvirt] [sandbox PATCH 03/15] Move virt-sandbox-service bash completion script to default directory.

2013-04-03 Thread Dan Walsh
bash_completion scripts have added a new way to do completions, where you place you scripts in /usr/share/bash_completion/completions rather then /etc/bash_completions.d. We should follow the new standard, and this patch moves our bash_completion script to the proper location with the proper

[libvirt] [sandbox PATCH 02/15] Add support for InteractiveContainers to virt-sandbox-service-util

2013-04-03 Thread Dan Walsh
We need to add support for interactive sandbox/containers for OpenShift. This patch will create the correct container type based off the /etc/libvirt-sandbox/service/* --- bin/virt-sandbox-service-util.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-)

[libvirt] Patch set to add InteractiveContainer support to virt-sandbox

2013-04-03 Thread Dan Walsh
Resend of patches with lots of cleanups. This patch set adds InteractiveContainer support to virt-sandbox-service command. This is needed if we want to support the OpenShift model of containers. There are also some bug fix patches in the set. [sandbox PATCH 01/15]

[libvirt] [sandbox PATCH 14/15] Check for LXC if virt-sandbox-service execute command specified

2013-04-03 Thread Dan Walsh
virt-sandbox-service execute is not supported on qemu sandboxes. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 8c9ea76..7b0410a 100755 ---

[libvirt] [sandbox PATCH 11/15] Refactor Container class into Container and ServiceContainer Class.

2013-04-03 Thread Dan Walsh
This way we can share common methods between the ServiceContainer and the InteractiveContainer (Patch to be added) --- bin/virt-sandbox-service | 754 --- 1 file changed, 385 insertions(+), 369 deletions(-) diff --git a/bin/virt-sandbox-service

[libvirt] [sandbox PATCH 08/15] Make CONFIG_PATH external to the Container Class

2013-04-03 Thread Dan Walsh
This patch moves CONFIG_PATH external from the Container Class. This will eliminate the need to create a container to get this constant. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[libvirt] [sandbox PATCH 15/15] Create new /etc/rc.d directory to bind mount over system.

2013-04-03 Thread Dan Walsh
We need to prevent SYSVInit scripts from running by default in the ServiceContainer. The so we recreate all of the directories under /etc/rc.d and copy the functions file over. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 10 +++--- 1 file changed, 7

[libvirt] [sandbox PATCH 10/15] Change variable config to config_path to avoid confusion.

2013-04-03 Thread Dan Walsh
save_config uses an internal variable to indicate the path to the virt-sandbox configuration file, this path renames this variable to prevent confusion. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[libvirt] [sandbox PATCH 12/15] Add support for InteractiveContainer

2013-04-03 Thread Dan Walsh
First use case will be OpenShift Differentiate on create based on whether one or more unit files specified (ServiceContainer), or a command is specified (Interactive Container). Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service| 165

[libvirt] [sandbox PATCH 06/15] Internationalize all output strings in virt-sandbox-service

2013-04-03 Thread Dan Walsh
Wrap all output strings with _() to make sure we get proper translations. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/bin/virt-sandbox-service

[libvirt] [sandbox PATCH 05/15] Change virt-sandbox-service-create.pod to use correct command --copy

2013-04-03 Thread Dan Walsh
Current the documentation says that you use --clone while the code uses --copy when you are createing a sandbox service container. Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service-create.pod | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[libvirt] [sandbox PATCH 13/15] Use args.uri rather then hard coding lxc:///

2013-04-03 Thread Dan Walsh
Signed-off-by: Dan Walsh dwa...@redhat.com --- bin/virt-sandbox-service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 8571374..8c9ea76 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@ -928,7

[libvirt] [PATCH] storage: Fix volume cloning for logical volume.

2013-04-03 Thread Atsushi Kumagai
When creating a logical volume with virStorageVolCreateXMLFrom, qemu-img convert is called internally if clonevol is a file volume. Then, vol-target.format is used as output_fmt parameter but the target.format of logical volumes is always 0 because logical volumes haven't the volume format type

<    1   2