On 04/09/13 16:52, Eric Blake wrote:
On 04/09/2013 07:02 AM, Peter Krempa wrote:
This patch fixes crash of the daemon that happens due to the following race
condition:
...
---
src/conf/domain_conf.c | 4
1 file changed, 4 insertions(+)
Commit message needs help, but the code is
Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
suites/libvirt-cim/lib/XenKvmLib/vxml.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/suites/libvirt-cim/lib/XenKvmLib/vxml.py
b/suites/libvirt-cim/lib/XenKvmLib/vxml.py
index 51a4166..82ab501 100644
---
Hey,
On Mon, Apr 08, 2013 at 01:54:21PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
.gitignore | 7 +
Makefile.am | 2 +-
On 09/04/13 10:32, Han Cheng wrote:
Add scsi hostdev, it looks like:
hostdev mode='subsystem' type='scsi'
source
adapter name='scsi_host0'/
address bus='0' target='0' unit='0'/
/source
address type='drive' controller='0' bus='0' target='4' unit='8'/
Hey Jaime,
On Mon, Apr 08, 2013 at 05:35:06PM +0200, Jaime Loureiro Acuña wrote:
My name is Jaime Loureiro and I work in the Network Applications area in
University of Vigo. I am writing to you hoping you can help me with some
libvirt graphics issues.
I was analysing the source code of the
On Wed, Apr 10, 2013 at 04:46:45AM +0200, Tabibel Sami wrote:
I am doing master degree of Cryptology and information security
I have good C and Python skills, and i am interested to work on
Introduce API to query IP addresses for given domain Libvirt
project.
I am looking for any comment
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
---
src/libxl/libxl_conf.c | 72
++
src/libxl/libxl_conf.h | 2 ++
2 files changed, 74 insertions(+)
This needs todo more than just create the config. You need to use
the
On Mon, Apr 08, 2013 at 01:54:20PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
To allow the compiler to check args add G_GNUC_PRINTF and
G_GNUC_NULL_TERMINATED to libvirt-gconfig-helpers-private.h
ACK
Christophe
pgpWa4waUk5wn.pgp
Description: PGP
On Tue, Apr 09, 2013 at 04:06:06PM -0400, Laine Stump wrote:
On 04/09/2013 04:58 AM, Daniel P. Berrange wrote:
On Mon, Apr 08, 2013 at 03:32:07PM -0400, Laine Stump wrote:
Actually I do wonder if we should reprent a PCI root as two
controller elements, one representing the actual PCI root
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
Script to be called to prepare custom device for domain. Done with Xen
in mind, it maps to libxl_device_disk.script.
XML configuration would be:
disk type='block' device='disk'
source dev='/dev/mapper/custom-device'/
On 10.04.2013 11:12, Stefan Hajnoczi wrote:
On Wed, Apr 10, 2013 at 04:46:45AM +0200, Tabibel Sami wrote:
I am doing master degree of Cryptology and information security
I have good C and Python skills, and i am interested to work on
Introduce API to query IP addresses for given domain Libvirt
==5306== 8 bytes in 1 blocks are definitely lost in loss record 24 of 277
==5306==at 0x4C28B2F: calloc (vg_replace_malloc.c:593)
==5306==by 0x5293CAF: virAllocN (viralloc.c:152)
==5306==by 0x52DFEAE: virXPathNodeSet (virxml.c:611)
==5306==by 0x5313DD9: virNetworkDefParseXML
This is an update of
https://www.redhat.com/archives/libvir-list/2013-April/msg00352.html
Currently libvirt creates a cgroups hiearchy at
$LOCATION-OF-LIBVIRTD/libvirt/{qemu,lxc}/$GUEST-NAME
eg
/sys/fs/cgroup
├── blkio
│ └── libvirt
│ ├── lxc
│ │ └── busy
│ └──
From: Daniel P. Berrange berra...@redhat.com
Currently the virCgroupPtr struct contains 3 pieces of
information
- path - path of the cgroup, relative to current process'
cgroup placement
- placement - current process' placement in each controller
- mounts - mount point of each controller
From: Daniel P. Berrange berra...@redhat.com
Instead of calling virCgroupForDomain every time we need
the virCgrouPtr instance, just do it once at Vm startup
and cache a reference to the object in virLXCDomainObjPrivatePtr
until shutdown of the VM. Removing the virCgroupPtr from
the LXC driver
From: Daniel P. Berrange berra...@redhat.com
Rename all the virCgroupForXXX methods to use the form
virCgroupNewXXX since they are all constructors. Also
make sure the output parameter is the last one in the
list, and annotate all pointers as non-null. Fix up
all callers, and make sure they use
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/util/vircgroup.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index c336806..d3c43a2 100644
---
From: Daniel P. Berrange berra...@redhat.com
Some aspects of the cgroups setup / detection code are quite subtle
and easy to break. It would greatly benefit from unit testing, but
this is difficult because the test suite won't have privileges to
play around with cgroups. The solution is to use
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
docs/formatdomain.html.in| 26 ++
docs/schemas/domaincommon.rng| 12 +
src/conf/domain_conf.c | 78
From: Daniel P. Berrange berra...@redhat.com
Currently if virCgroupMakeGroup fails, we can get in a situation
where some controllers have been setup, but others not. Ensure
we call virCgroupRemove to remove what we've done upon failure
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
From: Daniel P. Berrange berra...@redhat.com
If a cgroup controller is co-mounted with another, eg
/sys/fs/cgroup/cpu,cpuacct
Then it is a requirement that there exist symlinks at
/sys/fs/cgroup/cpu
/sys/fs/cgroup/cpuacct
pointing to the real mount point. Add support to virCgroupPtr
From: Daniel P. Berrange berra...@redhat.com
A resource partition is an absolute cgroup path, ignoring the
current process placement. Expose a virCgroupNewPartition API
for constructing such cgroups
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 4 +-
From: Daniel P. Berrange berra...@redhat.com
Add a virCgroupIsolateMount method which looks at where the
current process is place in the cgroups (eg /system/demo.lxc.libvirt)
and then remounts the cgroups such that this sub-directory
becomes the root directory from the current process' POV.
From: Daniel P. Berrange berra...@redhat.com
The virCgroupNewDriver method had a 'bool privileged' param.
If a false value was ever passed in, it would simply not
work, since non-root users don't have any privileges to create
new cgroups. Just delete this broken code entirely and make
the QEMU
From: Daniel P. Berrange berra...@redhat.com
Historically QEMU/LXC guests have been placed in a cgroup layout
that is
$LOCATION-OF-LIBVIRTD/libvirt/{qemu,lxc}/$VMNAME
This is bad for a number of reasons
- The cgroup hierarchy gets very deep which seriously
impacts kernel performance due
On 10.04.2013 11:14, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
Script to be called to prepare custom device for domain. Done with Xen
in mind, it maps to libxl_device_disk.script.
XML configuration would be:
disk type='block' device='disk'
On Wed, Apr 10, 2013 at 10:57:08AM +0200, Christophe Fergeau wrote:
Hey,
On Mon, Apr 08, 2013 at 01:54:21PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
.gitignore
On Fri, Feb 8, 2013 at 4:07 PM, Michal Privoznik mpriv...@redhat.com wrote:
On 07.02.2013 16:19, Stefan Hajnoczi wrote:
I have created the Google Summer of Code 2013 wiki page where you can
add project ideas:
http://wiki.qemu.org/Google_Summer_of_Code_2013
Please add project ideas you are
From: Richard W.M. Jones rjo...@redhat.com
---
docs/formatdomain.html.in | 10 --
docs/schemas/domaincommon.rng | 1 +
src/conf/domain_conf.c| 3 ++-
src/conf/domain_conf.h| 1 +
src/qemu/qemu_command.c | 44 +--
This patch allows you to use the qemu Secure Shell (ssh) block device.
This is not upstream yet, but you can find my latest version here:
http://lists.nongnu.org/archive/html/qemu-devel/2013-04/threads.html#01703
This patch lets you specify a ssh device like this:
disk type='network'
On 04/04/13 15:35, Peter Krempa wrote:
This patch adds the ability to configure non-contiguous boot orders on boot
devices. This allows unplugging devices that have boot order specified without
breaking migration.
The new code now uses a slightly less memory efficient approach to store the
boot
On Wed, Apr 10, 2013 at 05:52:26PM +0200, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=920441
Currently, we are discarding listen attribute from qemu cookie even though
we strive to gather it. This result in not so cool bug: if user have
different networks, one for
On 10.04.2013 17:57, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 05:52:26PM +0200, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=920441
Currently, we are discarding listen attribute from qemu cookie even though
we strive to gather it. This result in not so cool
https://bugzilla.redhat.com/show_bug.cgi?id=920441
Currently, we are discarding listen attribute from qemu cookie even though
we strive to gather it. This result in not so cool bug: if user have
different networks, one for management/migration, and one for VNC/SPICE we
pass incorrect host to the
On Wed, Apr 10, 2013 at 06:01:15PM +0200, Michal Privoznik wrote:
On 10.04.2013 17:57, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 05:52:26PM +0200, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=920441
Currently, we are discarding listen attribute from qemu
On 04/10/2013 05:51 AM, Guannan Ren wrote:
==5306== 8 bytes in 1 blocks are definitely lost in loss record 24 of 277
==5306==at 0x4C28B2F: calloc (vg_replace_malloc.c:593)
==5306==by 0x5293CAF: virAllocN (viralloc.c:152)
==5306==by 0x52DFEAE: virXPathNodeSet (virxml.c:611)
https://bugzilla.redhat.com/show_bug.cgi?id=920441
Currently, we are discarding listen attribute from qemu cookie even though
we strive to gather it. This result in not so cool bug: if user have
different networks, one for management/migration, and one for VNC/SPICE we
pass incorrect host to the
On Wed, Apr 10, 2013 at 07:04:12PM +0200, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=920441
Currently, we are discarding listen attribute from qemu cookie even though
we strive to gather it. This result in not so cool bug: if user have
different networks, one for
On 10.04.2013 12:08, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of calling virCgroupForDomain every time we need
the virCgrouPtr instance, just do it once at Vm startup
and cache a reference to the object in qemuDomainObjPrivatePtr
until shutdown of the
On 04/10/2013 05:10 AM, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
This can be useful for route or NAT networks, or any other custom
network setup. Especially configuration example in documentation uses
script/ tag with type 'ethernet'.
---
On 10.04.2013 12:08, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce a method virFileDeleteTree for recursively deleting
an entire directory tree
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
src/libvirt_private.syms | 1 +
On 10.04.2013 12:08, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Instead of calling virCgroupForDomain every time we need
the virCgrouPtr instance, just do it once at Vm startup
and cache a reference to the object in virLXCDomainObjPrivatePtr
until shutdown of the
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
src/parallels/parallels_driver.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a2c3a64..a54e6ca 100644
--- a/src/conf/domain_conf.c
---
src/conf/domain_conf.c | 4 ++--
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_command.c | 6 +++---
src/vbox/vbox_tmpl.c| 12 ++--
src/xenxs/xen_sxpr.c| 4 ++--
src/xenxs/xen_xm.c | 4 ++--
6 files changed, 16 insertions(+), 16 deletions(-)
diff --git
This changes all the bitfield into bool type in domain_conf.h,
except domain-autostart, domain-persistent, and domain-updated,
as the public APIs like virDomainIsPersistent returns domain-persistent
as integer, they can be changed internally, but not that deserved.
Osier Yang (8):
Cleanup:
Members of struct virPCIDevice are changed together.
---
src/conf/domain_conf.c | 6 +++---
src/conf/domain_conf.h | 6 +++---
src/util/virpci.c | 58 +-
src/util/virpci.h | 6 +++---
4 files changed, 38 insertions(+), 38 deletions(-)
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Introduce a method virFileDeleteTree for recursively deleting
an entire directory tree
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
+
+/**
+ * virFileDeleteTree:
+ *
+ *
---
src/conf/domain_conf.h | 2 +-
src/lxc/lxc_hostdev.c | 2 +-
src/qemu/qemu_hostdev.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 09ce261..d8c1f6e 100644
--- a/src/conf/domain_conf.h
+++
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
src/xenxs/xen_sxpr.c | 2 +-
src/xenxs/xen_xm.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a54e6ca..c595401 100644
--- a/src/conf/domain_conf.c
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index c595401..753d248 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -4734,7 +4734,7 @@
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_command.c | 4 ++--
src/util/virpci.c | 6 +++---
src/util/virpci.h | 2 +-
src/xenxs/xen_sxpr.c| 2 +-
src/xenxs/xen_xm.c | 2 +-
7 files changed, 10 insertions(+), 10 deletions(-)
diff --git
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index afd4467..9f8687e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5489,7 +5489,7 @@
On 04/09/2013 04:28 PM, Gene Czarcinski wrote:
OK, how about having it both ways. If we can have both mask and
prefix, why not both via and gateway. I know gateway has some history
attached to it but the new /sbin/ip uses via. I am just trying to
keep a line of text being as close to not
On 04/09/2013 04:28 PM, Gene Czarcinski wrote:
On 04/04/2013 12:08 PM, Laine Stump wrote:
Except that it's obvious from your response that I misunderstood your
patch, and thought that you were trying to make the route to an
otherwise unreachable network a part of the unreachable network's
On 04/10/2013 01:38 PM, Gene Czarcinski wrote:
On 04/09/2013 04:28 PM, Gene Czarcinski wrote:
OK, how about having it both ways. If we can have both mask and
prefix, why not both via and gateway. I know gateway has some
history attached to it but the new /sbin/ip uses via. I am just
trying
On 04/10/2013 03:09 PM, Laine Stump wrote:
On 04/09/2013 04:28 PM, Gene Czarcinski wrote:
On 04/04/2013 12:08 PM, Laine Stump wrote:
Except that it's obvious from your response that I misunderstood your
patch, and thought that you were trying to make the route to an
otherwise unreachable
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This is mostly (modified) copypaste from libvirt-glib.
---
Makefile.am| 2 +-
configure.ac | 37 +
vapi/Makefile.am | 26 ++
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
This is mostly (modified) copypaste from libvirt-glib.
---
v2: Removed redundant libvirt-gobject dependency.
Makefile.am| 2 +-
configure.ac | 37 +
vapi/Makefile.am
On 04/11/2013 12:05 AM, Laine Stump wrote:
On 04/10/2013 05:51 AM, Guannan Ren wrote:
==5306== 8 bytes in 1 blocks are definitely lost in loss record 24 of 277
==5306==at 0x4C28B2F: calloc (vg_replace_malloc.c:593)
==5306==by 0x5293CAF: virAllocN (viralloc.c:152)
==5306==by
Hi Daniel,
Just Ping.
Did you ever successfully convert QEMU xml file to argv on other platforms?
Best Regards,
Olivia
-Original Message-
From: Yin Olivia-R63875
Sent: Tuesday, April 09, 2013 1:22 PM
To: 'libvir-list@redhat.com'
Cc: 'libvirt-us...@redhat.com'
Subject: fail to
Hi Daniel,
I have several patches pending in mailing list.
Would you mind giving more suggestions?
Thanks a lot. :)
[PATCH v4 1/2] Add USB option capability
https://www.redhat.com/archives/libvir-list/2013-April/msg00587.html
[PATCH v4 2/2]testcase: Add a new USB option test case
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The definition of structs for cgroups are kept in vircgroup.c since
they are intended to be private from users of the API. To enable
effective testing, however, they need to be accessible. To
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Rename all the virCgroupForXXX methods to use the form
virCgroupNewXXX since they are all constructors. Also
make sure the output parameter is the last one in the
list, and annotate all pointers
On 2013/04/10 18:08, Daniel P. Berrange wrote:
This is an update of
https://www.redhat.com/archives/libvir-list/2013-April/msg00352.html
Currently libvirt creates a cgroups hiearchy at
$LOCATION-OF-LIBVIRTD/libvirt/{qemu,lxc}/$GUEST-NAME
eg
/sys/fs/cgroup
├── blkio
│ └──
On 04/10/2013 04:08 AM, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
Some aspects of the cgroups setup / detection code are quite subtle
and easy to break. It would greatly benefit from unit testing, but
this is difficult because the test suite won't have privileges
Laine Stump wrote:
On 04/10/2013 05:10 AM, Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
This can be useful for route or NAT networks, or any other custom
network setup. Especially configuration example in documentation uses
script/
On 11/04/13 09:52, Laine Stump wrote:
On 04/10/2013 12:32 PM, Osier Yang wrote:
This changes all the bitfield into bool type in domain_conf.h,
except domain-autostart, domain-persistent, and domain-updated,
as the public APIs like virDomainIsPersistent returns domain-persistent
as integer, they
Daniel P. Berrange wrote:
On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote:
---
src/libxl/libxl_conf.c | 72
++
src/libxl/libxl_conf.h | 2 ++
2 files changed, 74 insertions(+)
This needs todo more than just
Marek Marczykowski wrote:
libxl uses some xenstore entries for hints in memory management
(especially when starting new domain). This includes dom0 memory limit
and Xen free memory margin, based on current system state. Entries are
created at first usage, so force such usage at daemon startup,
69 matches
Mail list logo
