Re: [libvirt] VirtualBox 4.2 Support

2013-06-12 Thread Jean-Baptiste Rouault
On Wednesday 12 June 2013 04:15:53 Dead Horse wrote: Last activity I could find on this subject was here: https://www.redhat.com/archives/libvir-list/2013-May/msg01610.html Further activity here as well: https://www.redhat.com/archives/libvir-list/2013-June/msg00379.html I am willing to

Re: [libvirt] libvirtd 1.0.6 refuses to start

2013-06-12 Thread Michal Privoznik
On 11.06.2013 16:59, Franky Van Liedekerke wrote: I just downloaded and compiled libvirtd on the same server as I did 1.0.4. Upon updating, libvirtd refuses to start, with this in the logfile (obfuscated the hostname by xxx's): 2013-06-11 13:43:49.154+: 3336: info : libvirt version:

Re: [libvirt] [PATCH 1/2] libxl: Report connect type as Xen

2013-06-12 Thread Daniel Veillard
On Tue, Jun 11, 2013 at 10:27:37AM -0600, Jim Fehlig wrote: Michal Privoznik wrote: On 11.06.2013 16:12, Jim Fehlig wrote: Michal Privoznik wrote: On 10.06.2013 22:21, Jim Fehlig wrote: Currently, the libxl driver reports a connection type of xenlight. To be

Re: [libvirt] AttributeError in virConnect.__del__ at program exit

2013-06-12 Thread Sandro Bonazzola
Il 11/06/2013 18:21, Cole Robinson ha scritto: On 06/11/2013 07:58 AM, Sandro Bonazzola wrote: Hi, using vdsm python code, I've the following error at program exit that seems to be related to libvirt python code, something wrong in a destructor: Exception AttributeError:

[libvirt] [PATCH] libvirt_private.syms: add virProcessGetStartTime

2013-06-12 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=973543 --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1ea7467..042081f 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1711,6 +1711,7 @@

Re: [libvirt] [PATCH] libvirt_private.syms: add virProcessGetStartTime

2013-06-12 Thread Michal Privoznik
On 12.06.2013 10:15, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=973543 --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1ea7467..042081f 100644 --- a/src/libvirt_private.syms +++

[libvirt] [PATCH] nodedev: fix vport detection for FC HBA

2013-06-12 Thread Ján Tomko
Use the host number as the host number when constructing the sysfs path instead of the variable we are trying to fill. https://bugzilla.redhat.com/show_bug.cgi?id=973543 --- Untested, but we do the same in virFindFCHostCapableVport in src/util/virutil.c.

Re: [libvirt] [PATCH] libvirt_private.syms: add virProcessGetStartTime

2013-06-12 Thread Ján Tomko
On 06/12/2013 10:21 AM, Michal Privoznik wrote: On 12.06.2013 10:15, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=973543 --- src/libvirt_private.syms | 1 + 1 file changed, 1 insertion(+) ACK Michal Thanks, pushed now. Jan -- libvir-list mailing list

Re: [libvirt] [PATCH] nodedev: fix vport detection for FC HBA

2013-06-12 Thread Michal Privoznik
On 12.06.2013 10:41, Ján Tomko wrote: Use the host number as the host number when constructing the sysfs path instead of the variable we are trying to fill. https://bugzilla.redhat.com/show_bug.cgi?id=973543 --- Untested, but we do the same in virFindFCHostCapableVport in

Re: [libvirt] [PATCH] nodedev: fix vport detection for FC HBA

2013-06-12 Thread Ján Tomko
On 06/12/2013 11:02 AM, Michal Privoznik wrote: On 12.06.2013 10:41, Ján Tomko wrote: Use the host number as the host number when constructing the sysfs path instead of the variable we are trying to fill. https://bugzilla.redhat.com/show_bug.cgi?id=973543 --- Untested, but we do the same in

[libvirt] [PATCH] snapshot: fix snapshot-delete option check error

2013-06-12 Thread Guannan Ren
For descendant of a snapshot, we need to check if they are external for both flag VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN and VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY For the snapshot itself, only check it if VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN is given. --- src/qemu/qemu_driver.c | 5 +++-- 1 file

Re: [libvirt] [PATCH] qemu: allow restore with non-migratable XML input

2013-06-12 Thread Michal Privoznik
On 11.06.2013 15:15, Ján Tomko wrote: Convert input XML to migratable before using it in qemuDomainSaveImageOpen. XML in the save image is migratable, i.e. doesn't contain implicit controllers. If these controllers were in a non-default order in the input XML, the ABI check would fail.

[libvirt] [PATCH] schema: simplify RNG pattern, remove superfluous optional

2013-06-12 Thread Claudio Bley
Signed-off-by: Claudio Bley cb...@av-test.de --- Just a minor nit which lets Emacs' nxml-mode fail when parsing the corresponding RNC schema. docs/schemas/domaincommon.rng |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH] schema: simplify RNG pattern, remove superfluous optional

2013-06-12 Thread Jiri Denemark
On Wed, Jun 12, 2013 at 13:51:29 +0200, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Just a minor nit which lets Emacs' nxml-mode fail when parsing the corresponding RNC schema. docs/schemas/domaincommon.rng |8 +++- 1 file changed, 3 insertions(+), 5

[libvirt] [PATCH 1/2] migration: Make erroring out on I/O error controllable by flag

2013-06-12 Thread Peter Krempa
Paolo Bonzini pointed out that it's actually possible to migrate a qemu instance that was paused due to I/O error and it will be able to work on the destination if the storage is accessible. This patch introduces flag VIR_MIGRATE_ABORT_ON_ERROR that cancels the migration in case an I/O error

[libvirt] [PATCH 2/2] migration: Don't propagate VIR_MIGRATE_ABORT_ON_ERROR

2013-06-12 Thread Peter Krempa
This flag is meant for errors happening on the source of the migration and isn't used on the destination. To allow better migration compatibility, don't propagate it to the destination. --- src/libvirt.c | 17 +++-- src/qemu/qemu_migration.c | 16 ++-- 2 files

[libvirt] [PATCH 0/2] Don't always fail migrations on I/O errors

2013-06-12 Thread Peter Krempa
Recently I've added code that aborts migration in case of I/O error. This may not be desirable as qemu does actually support such migration. This series adds a flag that enables this option that will be now disabled by default. Peter Krempa (2): migration: Make erroring out on I/O error

Re: [libvirt] [PATCH] schema: simplify RNG pattern, remove superfluous optional

2013-06-12 Thread Claudio Bley
At Wed, 12 Jun 2013 15:29:45 +0200, Jiri Denemark wrote: On Wed, Jun 12, 2013 at 13:51:29 +0200, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- Just a minor nit which lets Emacs' nxml-mode fail when parsing the corresponding RNC schema.

Re: [libvirt] [PATCH 1/2] libxl: Report connect type as Xen

2013-06-12 Thread Jim Fehlig
Daniel Veillard wrote: On Tue, Jun 11, 2013 at 10:27:37AM -0600, Jim Fehlig wrote: Michal Privoznik wrote: On 11.06.2013 16:12, Jim Fehlig wrote: Michal Privoznik wrote: On 10.06.2013 22:21, Jim Fehlig wrote: Currently, the libxl

[libvirt] Upstream : virt-install and virt-manager fails to install the guest with the error qemu: could not load PC BIOS 'bios.bin'

2013-06-12 Thread chandrashekar shastri
Hi All, Upstream : virt-install and virt-manager fails to install the guest with the error qemu: could not load PC BIOS 'bios.bin' Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 libvirt version : 1.0.5

Re: [libvirt] [PATCH 1/2] libxl: Report connect type as Xen

2013-06-12 Thread Jim Fehlig
Daniel Veillard wrote: On Tue, Jun 11, 2013 at 10:27:37AM -0600, Jim Fehlig wrote: Michal Privoznik wrote: On 11.06.2013 16:12, Jim Fehlig wrote: Michal Privoznik wrote: On 10.06.2013 22:21, Jim Fehlig wrote: Currently, the libxl

[libvirt] NMI watchdog issue

2013-06-12 Thread chandrashekar shastri
Hi All, We are testing the upstream KVM with : Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 libvirt version : 1.0.5 virt-install : 0.600.3 I have followed the below steps to test the NMI watchdog feature

Re: [libvirt] [PATCH 1/2] libxl: Report connect type as Xen

2013-06-12 Thread Daniel Veillard
On Wed, Jun 12, 2013 at 08:26:48AM -0600, Jim Fehlig wrote: Daniel Veillard wrote: On Tue, Jun 11, 2013 at 10:27:37AM -0600, Jim Fehlig wrote: Michal Privoznik wrote: On 11.06.2013 16:12, Jim Fehlig wrote: Michal Privoznik wrote: On 10.06.2013

Re: [libvirt] [PATCH] configure: Remove unused brctl check

2013-06-12 Thread Cole Robinson
On 06/11/2013 09:56 PM, Laine Stump wrote: On 06/11/2013 06:07 PM, Cole Robinson wrote: brctl isn't used anywhere AFAICT Too true. We switched to ioctls a long time ago. ACK. Thanks, pushed. (though how did I get dropped from the CC? Is that intentional on your part? It's the second

Re: [libvirt] AttributeError in virConnect.__del__ at program exit

2013-06-12 Thread Cole Robinson
On 06/12/2013 04:10 AM, Sandro Bonazzola wrote: Il 11/06/2013 18:21, Cole Robinson ha scritto: On 06/11/2013 07:58 AM, Sandro Bonazzola wrote: Hi, using vdsm python code, I've the following error at program exit that seems to be related to libvirt python code, something wrong in a destructor:

[libvirt] [PATCH 2/2] xen: Implement virConnectGetSysinfo

2013-06-12 Thread Jim Fehlig
virConnectGetSysinfo was never implemented in the legacy xen driver. This patch provides an implementation based on the qemu driver. --- src/xen/xen_driver.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git a/src/xen/xen_driver.c

[libvirt] [PATCH 1/2] libxl: Implement virConnectGetSysinfo

2013-06-12 Thread Jim Fehlig
virConnectGetSysinfo was never implemented in the libxl driver. This patch provides an implementation based on the qemu driver. --- src/libxl/libxl_conf.h |1 + src/libxl/libxl_driver.c | 29 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git

[libvirt] [PATCH 0/2] Implement virConnectGetSysinfo in libxl and xen drivers

2013-06-12 Thread Jim Fehlig
While discussing a recent libxl patch, we realized virConnectGetSysinfo was never implemented in the libxl and legacy xen drivers. This small series provides an implementation for these drivers. Jim Fehlig (2): libxl: Implement virConnectGetSysinfo xen: Implement virConnectGetSysinfo

[libvirt] [PATCH] lxc: Create /dev/tty within a container

2013-06-12 Thread Richard Weinberger
Many applications use /dev/tty to read from stdin. E.g. zypper on openSUSE. Let's create this device node to unbreak those applications. As /dev/tty is a synonym for the current controlling terminal it cannot harm the host or any other containers. Signed-off-by: Richard Weinberger rich...@nod.at

Re: [libvirt] [PATCH] configure: Remove unused brctl check

2013-06-12 Thread Laine Stump
On 06/12/2013 11:51 AM, Cole Robinson wrote: On 06/11/2013 09:56 PM, Laine Stump wrote: On 06/11/2013 06:07 PM, Cole Robinson wrote: brctl isn't used anywhere AFAICT Too true. We switched to ioctls a long time ago. ACK. Thanks, pushed. (though how did I get dropped from the CC? Is that

Re: [libvirt] [PATCH] remote: Forbid default /session connections when using ssh transport

2013-06-12 Thread Laine Stump
On 06/10/2013 08:44 AM, Peter Krempa wrote: Can you include in the commit log a link to the BZ describing this problem? It helps *immensely* when trying to trace things months/years later. Without the socket path explicitly specified, the remote driver tried to connect to the /system

Re: [libvirt] [PATCH v2 1/2] add hostdev passthrough common library

2013-06-12 Thread Marek Marczykowski-Górecki
On 07.06.2013 00:00, Chunyan Liu wrote: Write separate module for hostdev passthrough common library so that it could be used by all hypervisor drivers and maintain a global hostdev state. Changes to v1: * add scsi part to common library * instead of hardcode, check for driver

[libvirt] ANNOUNCE: libvirt 0.9.11.10 maintenance release

2013-06-12 Thread Cole Robinson
libvirt 0.9.11.10 maintenance release is now available. This is libvirt 0.9.11 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.11.10.tar.gz Changes in this version: *

[libvirt] ANNOUNCE: libvirt 0.10.2.6 maintenance release

2013-06-12 Thread Cole Robinson
libvirt 0.10.2.6 maintenance release is now available. This is libvirt 0.10.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.10.2.6.tar.gz Changes in this version: * qemu:

[libvirt] ANNOUNCE: libvirt 1.0.5.2 maintenance release

2013-06-12 Thread Cole Robinson
libvirt 1.0.5.2 maintenance release is now available. This is libvirt 1.0.5 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.0.5.2.tar.gz Changes in this version: * virsh:

[libvirt] [PATCH v2 01/14] libxl: allow only 'ethernet' and 'bridge' interfaces, allow script there

2013-06-12 Thread Marek Marczykowski-Górecki
Actually only those interface types are handled correctly so reject others instead of ignoring settings (i.e. treating as bridge/ethernet anyway). Also allow script/ in 'ethernet' (which should be the only script-allowing type). Keep script/ allowed in bridge to be compatible with legacy 'xen'

[libvirt] [PATCH v2] A bunch of extensions to libxl driver

2013-06-12 Thread Marek Marczykowski-Górecki
This are some additional features to libxl driver. Some of them require change in domain config structures/syntax. Details described with each patch. There are two bugfix patches for deadlock during daemon startup. Changes since v1: - dropped 'script' disk parameter patches - updated 'script'

[libvirt] [PATCH v2 03/14] conf: support backend domain name in disk and network devices

2013-06-12 Thread Marek Marczykowski-Górecki
At least Xen supports backend drivers in another domain (aka driver domain). This patch introduces XML config option for such setting as 'domain' element with 'name' attribute. Verification its content is left for the driver. In the future some option will be needed for USB devices (hostdev

[libvirt] [PATCH v2 04/14] libxl: support backend domain setting for disk and net devices

2013-06-12 Thread Marek Marczykowski-Górecki
This implement handling of domain name=''/ parameter introduced in previous patch. Lookup on domain name (to get domain ID) requires libxlDriverPrivate object, so it must be passed down to libxlMakeDisk and libxlMakeNet from top level callers. Changes in v2: - rebase on 1.0.6+ - fix

[libvirt] [PATCH v2 11/14] libxl: support network device attach/detach

2013-06-12 Thread Marek Marczykowski-Górecki
Both live and config. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 164 ++- 1 file changed, 161 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c

[libvirt] [PATCH v2 07/14] libxl: fix deadlock in libxlReconnectDomain

2013-06-12 Thread Marek Marczykowski-Górecki
Use virDomainObjListRemoveLocked instead of virDomainObjListRemove, as driver-domains is already taken by virDomainObjListForEach. Above deadlock can be triggered when libvirtd is started after some domain have been started by hand (in which case driver will not find libvirt-xml domain config).

[libvirt] [PATCH v2 02/14] libxl: populate xenstore memory entries at startup, handle dom0_mem

2013-06-12 Thread Marek Marczykowski-Górecki
libxl uses some xenstore entries for hints in memory management (especially when starting new domain). This includes dom0 memory limit and Xen free memory margin, based on current system state. Entries are created at first function usage, so force such call at daemon startup, which most likely

[libvirt] [PATCH v2 08/14] libxl: initialize device structures

2013-06-12 Thread Marek Marczykowski-Górecki
Do not leave uninitialized variables, not all parameters are set in libxlMake*. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 8 1 file changed, 8 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index

[libvirt] [PATCH v2 05/14] libxl: fill HVM SDL and VNC settings based on graphics/ entries

2013-06-12 Thread Marek Marczykowski-Górecki
Vfb entries in domain config are used only by PV drivers. Qemu parameters are build based on b_info struct. So fill it with the same data as vfb entries (actually the first one). This will additionally allow graphic-less domain, when no graphics/ entries are present in domain XML (previously VNC

[libvirt] [PATCH v2 10/14] libxl: support domain config modification in virDomainRestoreFlags

2013-06-12 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 8dec70b..7b50853 100644 ---

[libvirt] [PATCH v2 13/14] libxl: implement lifecycle actions from domain config

2013-06-12 Thread Marek Marczykowski-Górecki
Instead of hardcoded actions for poweroff, reboot and crash. Known limitations: 1. Crash actions not fully implemented (namely no coredump done). 2. VIR_DOMAIN_LIFECYCLE_PRESERVE emit VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN event but do not mark domain object as stopped. So effectively use of 'preserve'

[libvirt] [PATCH v2 06/14] conf: virDomainObjListRemoveLocked function

2013-06-12 Thread Marek Marczykowski-Górecki
While iterating with virDomainObjListForEach it is safe to remove current element. But while iterating, 'doms' lock is already taken, so can't use standard virDomainObjListRemove. So introduce virDomainObjListRemoveLocked for this purpose. Changes in v2: - fix indentation Signed-off-by: Marek

[libvirt] [PATCH v2 09/14] libxl: support paused domain restore in virDomainRestoreFlags

2013-06-12 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index b2cff5b..8dec70b 100644 --- a/src/libxl/libxl_driver.c +++

[libvirt] [PATCH v2 14/14] libxl: add tablet/mouse input device support

2013-06-12 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 278c5e5..61c370f 100644 --- a/src/libxl/libxl_conf.c +++

[libvirt] [PATCH v2 12/14] libxl: pass ipaddr to libxl toolstack

2013-06-12 Thread Marek Marczykowski-Górecki
Do not silently ignore its value. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index d654ace..278c5e5 100644 --- a/src/libxl/libxl_conf.c

[libvirt] virsh live migration w/o shared storage fails with error as vm is not running

2013-06-12 Thread chandrashekar shastri
Hi All, We are testing the upstream KVM with : Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 libvirt version : 1.0.5 virt-install : 0.600.3 I have followed the below steps to test the Live migration w/o