Re: [libvirt] [PATCH v4 2/4] storage: report error rather than warning if backing files doesn't exist

2013-07-16 Thread Martin Kletzander
On 07/15/2013 05:31 PM, Ján Tomko wrote: On 07/02/2013 11:35 AM, Guannan Ren wrote: If one of backing files for disk source doesn't exist, the guest will not be able to find and use the disk even though the disk still exists in guest xml definition. So reporting an error make more sense.

[libvirt] [PATCH] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Alex Jia
If users haven't configured guest agent then qemuAgentCommand() will dereference a NULL 'mon' pointer, which causes crash of libvirtd. GDB backtrace: (gdb) bt #0 virNetServerFatalSignal (sig=11, siginfo=value optimized out, context=value optimized out) at rpc/virnetserver.c:326 #1 signal

Re: [libvirt] [PATCH 3/4] cpu: Clean up code style

2013-07-16 Thread Jiri Denemark
On Mon, Jul 15, 2013 at 18:24:46 +0200, Peter Krempa wrote: --- src/conf/cpu_conf.c | 4 ++-- src/cpu/cpu_x86.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) ACK Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/4] conf: Clean up error reporting in cpu definition parsing

2013-07-16 Thread Jiri Denemark
On Mon, Jul 15, 2013 at 18:24:44 +0200, Peter Krempa wrote: Use VIR_ERR_XML_ERROR instead of VIR_ERR_INTERNAL_ERROR in XML parsing code and move %s formating strings right after the error code. --- src/conf/cpu_conf.c | 74 ++--- 1 file

Re: [libvirt] [PATCH 2/4] cpu: Add virCPUDefUpdateFeature()

2013-07-16 Thread Jiri Denemark
On Mon, Jul 15, 2013 at 18:24:45 +0200, Peter Krempa wrote: This new function updates or adds a feature to a existing cpu model definition. This function will be helpful to allow tuning of host-model features in later patches. --- src/conf/cpu_conf.c | 38

Re: [libvirt] [PATCH] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Peter Krempa
On 07/16/13 08:31, Alex Jia wrote: If users haven't configured guest agent then qemuAgentCommand() will dereference a NULL 'mon' pointer, which causes crash of libvirtd. uhh, right :/ I broke that :/ GDB backtrace: (gdb) bt #0 virNetServerFatalSignal (sig=11, siginfo=value optimized out,

Re: [libvirt] [PATCH v4 2/4] storage: report error rather than warning if backing files doesn't exist

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 08:14:54AM +0200, Martin Kletzander wrote: On 07/15/2013 05:31 PM, Ján Tomko wrote: On 07/02/2013 11:35 AM, Guannan Ren wrote: If one of backing files for disk source doesn't exist, the guest will not be able to find and use the disk even though the disk still exists

Re: [libvirt] [PATCH v4 1/3] Add a privileged field to storageDriverState

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 04:26:10PM -0400, John Ferlan wrote: Use the privileged value in order to generate a connection which could be passed to the various storage backend drivers. In particular, the iSCSI driver will need a connect in order to perform pool authentication using the 'chap'

Re: [libvirt] [PATCH 4/4] cpu: Allow fine tuning of host-model cpu

2013-07-16 Thread Jiri Denemark
On Mon, Jul 15, 2013 at 18:24:47 +0200, Peter Krempa wrote: https://bugzilla.redhat.com/show_bug.cgi?id=799354 Until now, the host-model cpu mode couldn't be influenced. This patch allows to use the feature elements to either enable or disable specific CPU flags. This can be used to force

Re: [libvirt] [PATCH v4 2/4] storage: report error rather than warning if backing files doesn't exist

2013-07-16 Thread Martin Kletzander
On 07/16/2013 10:40 AM, Daniel P. Berrange wrote: On Tue, Jul 16, 2013 at 08:14:54AM +0200, Martin Kletzander wrote: On 07/15/2013 05:31 PM, Ján Tomko wrote: On 07/02/2013 11:35 AM, Guannan Ren wrote: If one of backing files for disk source doesn't exist, the guest will not be able to find

Re: [libvirt] [PATCH] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Alex Jia
On 07/16/2013 04:35 PM, Peter Krempa wrote: On 07/16/13 08:31, Alex Jia wrote: If users haven't configured guest agent then qemuAgentCommand() will dereference a NULL 'mon' pointer, which causes crash of libvirtd. uhh, right :/ I broke that :/ GDB backtrace: (gdb) bt #0

Re: [libvirt] [PATCH 4/4] cpu: Allow fine tuning of host-model cpu

2013-07-16 Thread Peter Krempa
On 07/16/13 10:45, Jiri Denemark wrote: On Mon, Jul 15, 2013 at 18:24:47 +0200, Peter Krempa wrote: https://bugzilla.redhat.com/show_bug.cgi?id=799354 Until now, the host-model cpu mode couldn't be influenced. This patch allows to use the feature elements to either enable or disable specific

Re: [libvirt] [PATCH v4 2/4] storage: report error rather than warning if backing files doesn't exist

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:47:54AM +0200, Martin Kletzander wrote: On 07/16/2013 10:40 AM, Daniel P. Berrange wrote: On Tue, Jul 16, 2013 at 08:14:54AM +0200, Martin Kletzander wrote: On 07/15/2013 05:31 PM, Ján Tomko wrote: On 07/02/2013 11:35 AM, Guannan Ren wrote: If one of backing

[libvirt] [PATCH v2] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Alex Jia
If users haven't configured guest agent then qemuAgentCommand() will dereference a NULL 'mon' pointer, which causes crash of libvirtd. With the patch, when the qemu-ga service isn't running in the guest, a expected error error: Guest agent is not responding: Guest agent not available for now will

Re: [libvirt] [PATCH v4 1/3] Add a privileged field to storageDriverState

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 09:44:52AM +0100, Daniel P. Berrange wrote: On Mon, Jul 15, 2013 at 04:26:10PM -0400, John Ferlan wrote: Use the privileged value in order to generate a connection which could be passed to the various storage backend drivers. In particular, the iSCSI driver will

Re: [libvirt] [PATCH v5 2/5] domain_conf: Auto fill chardev port

2013-07-16 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 07:23:59PM +0200, Michal Privoznik wrote: Now that we have callbacks, we should auto fill in omitted pieces of information. It's important for chardev hotplug to fill in the correct /{serial,parallel,console,channel}/target/@port if no value has been provided by user.

Re: [libvirt] [PATCH v5 3/5] qemu: Implement chardev hotplug on config level

2013-07-16 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 07:24:00PM +0200, Michal Privoznik wrote: There are two levels on which a device may be hotplugged: config and live. The config level requires just an insert or remove from internal domain definition structure, which is exactly what this patch does. There is currently

Re: [libvirt] [PATCH v5 4/5] qemu: Implement chardev hotplug on live level

2013-07-16 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 07:24:01PM +0200, Michal Privoznik wrote: Since previous patches has prepared everything for us, we may now implement live hotplug of a character device. --- src/qemu/qemu_command.c | 38 +- src/qemu/qemu_driver.c | 26 ++--

Re: [libvirt] [PATCH v5 5/5] qemuhotplugtest: Introduce test for chardev hotplug

2013-07-16 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 07:24:02PM +0200, Michal Privoznik wrote: The test is currently testing just device update function. However, chardev hotplug is implemented just for device attach and detach. This fact means, the test needs to be rewritten (the majority of the code is still shared).

[libvirt] [test-API][PATCH] Modify repos/network/network_list.py and add network_list case to conf

2013-07-16 Thread hongming zhang
Modify the old network_list.py. The new network_list.py covers all flags of listAllNetworks and the following api. and add network_list to basic_network.conf. virNetwork: name() bridgeName() isActive() isPersistent() virConnect: listAllNetworks() --- cases/basic_network.conf | 37 +-

Re: [libvirt] [PATCH v3 2/3] libxl: advertise the support for VIR_TYPED_PARAM_STRING

2013-07-16 Thread Daniel P. Berrange
On Sat, Jul 13, 2013 at 02:27:10AM +0200, Dario Faggioli wrote: domainGetNumaParameters has a string typed parameter, hence it is necessary for the libxl driver to support this. This change implements the connectSupportsFeature hook for the libxl driver, advertising that

Re: [libvirt] [PATCH v3 1/3] libxl: implement NUMA capabilities reporting

2013-07-16 Thread Daniel P. Berrange
On Sat, Jul 13, 2013 at 02:27:03AM +0200, Dario Faggioli wrote: Starting from Xen 4.2, libxl has all the bits and pieces in place for retrieving an adequate amount of information about the host NUMA topology. It is therefore possible, after a bit of shuffling, to arrange those information in

Re: [libvirt] [PATCH v3 3/3] libxl: implement virDomainGetNumaParameters

2013-07-16 Thread Daniel P. Berrange
On Sat, Jul 13, 2013 at 02:27:18AM +0200, Dario Faggioli wrote: Although, having it depending on Xen = 4.3 (by using the proper libxl feature flag). Xen currently implements a NUMA placement policy which is basically the same as the 'interleaved' policy of `numactl', although it can be

Re: [libvirt] [PATCH v4] Make logical pools independent on target path

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 04:29:54PM +0200, Martin Kletzander wrote: When using logical pools, we had to trust the target-path provided. This parameter, however, can be completely ommited and we can use '/dev/source.name' safely and populate it to target.path. Resolves:

Re: [libvirt] [PATCH 01/12] Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:02PM +0200, Jiri Denemark wrote: --- daemon/remote.c | 32 + include/libvirt/libvirt.h.in | 18 python/libvirt-override-virConnect.py | 9 python/libvirt-override.c | 52 -

Re: [libvirt] [PATCH 02/12] examples: Handle VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:03PM +0200, Jiri Denemark wrote: --- examples/domain-events/events-c/event-test.c | 23 +- examples/domain-events/events-python/event-test.py | 4 2 files changed, 26 insertions(+), 1 deletion(-) ACK Daniel -- |:

Re: [libvirt] [PATCH 04/12] qemu: Add qemuDomainReleaseDeviceAddress to remove any address

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:05PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_command.c | 35 --- src/qemu/qemu_command.h | 8 +++--- src/qemu/qemu_hotplug.c | 75 - 3 files changed, 47 insertions(+), 71 deletions(-)

Re: [libvirt] [PATCH 03/12] Clarify virDomainDetachDeviceFlags documentation

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:04PM +0200, Jiri Denemark wrote: --- src/libvirt.c | 12 1 file changed, 12 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 4dc91d7..860188b 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -10825,6 +10825,18 @@ error: *

Re: [libvirt] [PATCH 06/12] qemu: Separate controller removal into a standalone function

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:07PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

Re: [libvirt] [PATCH 07/12] qemu: Separate net device removal into a standalone function

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:08PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 101 +--- 1 file changed, 62 insertions(+), 39 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|

Re: [libvirt] [PATCH 05/12] qemu: Separate disk device removal into a standalone function

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:06PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_driver.c | 31 +--- src/qemu/qemu_hotplug.c | 127 ++-- src/qemu/qemu_hotplug.h | 4 +- 3 files changed, 73 insertions(+), 89 deletions(-) ACK Daniel

Re: [libvirt] [PATCH 08/12] qemu: Separate host device removal into a standalone function

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:09PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 240 1 file changed, 142 insertions(+), 98 deletions(-) ACK Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :|

Re: [libvirt] [PATCH 10/12] qemu: Add support for DEVICE_DELETED event

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:11PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_monitor.c | 13 + src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_monitor_json.c | 15 +++ 5 files

Re: [libvirt] [PATCH 09/12] Add virDomainDefFindDevice for looking up a device by its alias

2013-07-16 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 07:11:10PM +0200, Jiri Denemark wrote: --- src/conf/domain_conf.c | 41 + src/conf/domain_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 46 insertions(+) Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCH v3 05/10] Determine whether to start balloon memory stats gathering.

2013-07-16 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 10:40:01AM -0400, John Ferlan wrote: On 07/12/2013 08:39 AM, Daniel P. Berrange wrote: On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote: At vm startup and attach attempt to set the balloon driver statistics collection period based on the value found in the

Re: [libvirt] [PATCH v3 04/10] Add 'period' for Memballoon statistics gathering capability

2013-07-16 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 10:16:20AM -0400, John Ferlan wrote: On 07/12/2013 08:35 AM, Daniel P. Berrange wrote: ps, forgot to mention last time that you need to add a test case for this new XML - or just add the XML to 1. Copied qemuxml2argv-balloon-device.xml to

Re: [libvirt] [PATCH v3 10/10] Allow balloon driver collection to be adjusted dynamically

2013-07-16 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 10:41:23AM -0400, John Ferlan wrote: On 07/12/2013 08:45 AM, Daniel P. Berrange wrote: On Thu, Jul 11, 2013 at 07:56:00PM -0400, John Ferlan wrote: ...snip... index 5fbd32c..4cbf105 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c

Re: [libvirt] [PATCH v3 1/3] libxl: implement NUMA capabilities reporting

2013-07-16 Thread Dario Faggioli
On mar, 2013-07-16 at 10:41 +0100, Daniel P. Berrange wrote: On Sat, Jul 13, 2013 at 02:27:03AM +0200, Dario Faggioli wrote: [..] diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 4a0fba9..c097d1e 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@

Re: [libvirt] [PATCH v4] Make logical pools independent on target path

2013-07-16 Thread Martin Kletzander
On 07/16/2013 11:48 AM, Daniel P. Berrange wrote: On Mon, Jul 15, 2013 at 04:29:54PM +0200, Martin Kletzander wrote: When using logical pools, we had to trust the target-path provided. This parameter, however, can be completely ommited and we can use '/dev/source.name' safely and populate it

Re: [libvirt] [PATCH v3 1/3] libxl: implement NUMA capabilities reporting

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 11:10:25AM +0100, Dario Faggioli wrote: On mar, 2013-07-16 at 10:41 +0100, Daniel P. Berrange wrote: On Sat, Jul 13, 2013 at 02:27:03AM +0200, Dario Faggioli wrote: @@ -788,9 +903,40 @@ libxlMakeCapabilities(libxl_ctx *ctx) return NULL; } -

Re: [libvirt] [PATCH RESEND 1/7] LXC: Setup disks for container on host side

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:00:00AM +0800, Gao feng wrote: Since mknod in container is forbidden, we should setup disks on host side. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 98

Re: [libvirt] [PATCH RESEND 2/7] LXC: controller: change the owner of disk to the root of container

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:00:01AM +0800, Gao feng wrote: These disk devices are created for container, the owner should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 3 +++ 1 file changed, 3 insertions(+) ACK Daniel -- |:

Re: [libvirt] [PATCH RESEND 4/7] LXC: Change the owner of live attached disk device

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:00:03AM +0800, Gao feng wrote: The owner of this disk device should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_driver.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/lxc_driver.c

Re: [libvirt] [PATCH RESEND 5/7] LXC: Create host devices for container on host side

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:00:04AM +0800, Gao feng wrote: Otherwise the container will fail to start if we enable user namespace, since there is no rights to do mknod in uninit user namespace. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_container.c | 263

Re: [libvirt] [PATCH RESEND 7/7] LXC: Change the owner of live attached host devices

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:00:06AM +0800, Gao feng wrote: The owner of this host devices should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_driver.c | 9 + 1 file changed, 9 insertions(+) ACK Daniel -- |: http://berrange.com

Re: [libvirt] [PATCH RESEND 3/7] LXC: Move virLXCControllerChown to lxc_container.c

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:00:02AM +0800, Gao feng wrote: lxc driver will use this function to change the owner of hot added devices. Move virLXCControllerChown to lxc_container.c and Rename it to lxcContainerChown. Signed-off-by: Gao feng gaof...@cn.fujitsu.com ---

Re: [libvirt] [PATCH RESEND 6/7] LXC: Change the owner of host devices to the root of container

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 10:00:05AM +0800, Gao feng wrote: These host devices are created for container, the owner should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_controller.c | 9 + 1 file changed, 9 insertions(+) ACK Daniel

[libvirt] [v3 PATCH] storage: skip async-deleted volume while fs storage is being refreshed

2013-07-16 Thread Guannan Ren
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=977706 v1, v2 by Ján Tomko https://www.redhat.com/archives/libvir-list/2013-July/msg00639.html To get volume file fd in the fist place. The purpose of doing so is to ensure the async deletion of volume doesn't make impact on the following

Re: [libvirt] [PATCH v4 1/3] Add a privileged field to storageDriverState

2013-07-16 Thread John Ferlan
On 07/16/2013 05:31 AM, Daniel P. Berrange wrote: On Tue, Jul 16, 2013 at 09:44:52AM +0100, Daniel P. Berrange wrote: On Mon, Jul 15, 2013 at 04:26:10PM -0400, John Ferlan wrote: Use the privileged value in order to generate a connection which could be passed to the various storage backend

Re: [libvirt] [PATCH v2] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Peter Krempa
On 07/16/13 11:30, Alex Jia wrote: If users haven't configured guest agent then qemuAgentCommand() will dereference a NULL 'mon' pointer, which causes crash of libvirtd. With the patch, when the qemu-ga service isn't running in the guest, a expected error error: Guest agent is not responding:

Re: [libvirt] [PATCH v4 2/4] storage: report error rather than warning if backing files doesn't exist

2013-07-16 Thread Martin Kletzander
On 07/16/2013 11:08 AM, Daniel P. Berrange wrote: [...] Which BZ are you referring to ? I read BZ 977706 to be about not causing errors during pool-refresh if a 2nd node has deleted the volume while the first node is in the middle of refresh. This isn't about keeping deleted volumes visible.

[libvirt] [PATCH] cgroup: Free line even if no characters were read

2013-07-16 Thread Ján Tomko
Even if getline doesn't read any characters it allocates a buffer. ==404== 120 bytes in 1 blocks are definitely lost in loss record 1,344 of 1,671 ==404==at 0x4C2C71B: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==404==by 0x906F862: getdelim (iogetdelim.c:68)

Re: [libvirt] [PATCH v2] qemu: Prevent crash of libvirtd without guest agent configuration

2013-07-16 Thread Peter Krempa
On 07/16/13 13:42, Peter Krempa wrote: On 07/16/13 11:30, Alex Jia wrote: If users haven't configured guest agent then qemuAgentCommand() will dereference a NULL 'mon' pointer, which causes crash of libvirtd. With the patch, when the qemu-ga service isn't running in the guest, a expected error

[libvirt] [PATCH] rbd: Do not free the secret if it is not set

2013-07-16 Thread Wido den Hollander
Not all RBD (Ceph) storage pools have cephx authentication turned on, so secret might not be initialized. It could also be that the secret couldn't be located. Only call virSecretFree() if secret is initialized earlier. Signed-off-by: Wido den Hollander w...@widodh.nl ---

Re: [libvirt] [PATCH v3 00/10] Re-enable memballoon driver statistics reporting

2013-07-16 Thread John Ferlan
On 07/11/2013 07:55 PM, John Ferlan wrote: This patch set replaces: https://www.redhat.com/archives/libvir-list/2013-July/msg00435.html Changes 01 - No change 02 03 - Adjust typecaste to switch() and remove default: 04 - Use unsigned int as requested 05 - Add

Re: [libvirt] [PATCH] rbd: Do not free the secret if it is not set

2013-07-16 Thread Ján Tomko
On 07/16/2013 02:26 PM, Wido den Hollander wrote: Not all RBD (Ceph) storage pools have cephx authentication turned on, so secret might not be initialized. It could also be that the secret couldn't be located. Only call virSecretFree() if secret is initialized earlier. Signed-off-by:

[libvirt] [PATCH] qemu: Fix double free of returned JSON array in qemuAgentGetVCPUs()

2013-07-16 Thread Peter Krempa
A part of the returned monitor response was freed twice and caused crashes of the daemon when using guest agent cpu count retrieval. # virsh vcpucount dom --guest Introduced in v1.0.6-48-gc6afcb0 --- src/qemu/qemu_agent.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_agent.c

Re: [libvirt] [PATCH] qemu: Fix double free of returned JSON array in qemuAgentGetVCPUs()

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 03:47:10PM +0200, Peter Krempa wrote: A part of the returned monitor response was freed twice and caused crashes of the daemon when using guest agent cpu count retrieval. # virsh vcpucount dom --guest Introduced in v1.0.6-48-gc6afcb0 --- src/qemu/qemu_agent.c |

Re: [libvirt] [PATCH] Create directory for lease files if it's missing

2013-07-16 Thread Guido Günther
On Thu, Jul 11, 2013 at 07:33:52PM +0200, Guido Günther wrote: If we don't autostart a network it's not being created. Debian Bug http://bugs.debian.org/715200 Ping? -- Guido --- src/nwfilter/nwfilter_dhcpsnoop.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

Re: [libvirt] [PATCH] Create directory for lease files if it's missing

2013-07-16 Thread Daniel P. Berrange
On Tue, Jul 16, 2013 at 04:04:56PM +0200, Guido Günther wrote: On Thu, Jul 11, 2013 at 07:33:52PM +0200, Guido Günther wrote: If we don't autostart a network it's not being created. Debian Bug http://bugs.debian.org/715200 Ping? -- Guido --- src/nwfilter/nwfilter_dhcpsnoop.c |

[libvirt] [PATCH RFC] lib: Forbid guest interaction with RO connections in virDomainGetVcpusFlags

2013-07-16 Thread Peter Krempa
Don't allow guest agent interaction by read-only connections as the agent may be mailicious. --- src/libvirt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index 0cdac0d..f064f32 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -9891,6 +9891,12 @@

Re: [libvirt] [PATCH] qemu: Fix double free of returned JSON array in qemuAgentGetVCPUs()

2013-07-16 Thread Peter Krempa
On 07/16/13 15:52, Daniel P. Berrange wrote: On Tue, Jul 16, 2013 at 03:47:10PM +0200, Peter Krempa wrote: A part of the returned monitor response was freed twice and caused crashes of the daemon when using guest agent cpu count retrieval. # virsh vcpucount dom --guest Introduced in

Re: [libvirt] [PATCH RFC] lib: Forbid guest interaction with RO connections in virDomainGetVcpusFlags

2013-07-16 Thread Eric Blake
On 07/16/2013 08:37 AM, Peter Krempa wrote: Don't allow guest agent interaction by read-only connections as the agent may be mailicious. s/mailicious/malicious/ --- src/libvirt.c | 6 ++ 1 file changed, 6 insertions(+) Do we have any other commands that a read-only connection can use

Re: [libvirt] [PATCH RESEND 7/7] LXC: Change the owner of live attached host devices

2013-07-16 Thread Eric Blake
On 07/16/2013 04:49 AM, Daniel P. Berrange wrote: On Tue, Jul 16, 2013 at 10:00:06AM +0800, Gao feng wrote: The owner of this host devices should be the root user of container. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/lxc/lxc_driver.c | 9 + 1 file changed, 9

[libvirt] [PATCH] xen: Use internal interfaces in xenDomainUsedCpus

2013-07-16 Thread Stefan Bader
Based on Daniel's feedback I did a split for public/private functions for those that cause the lockup when getting XML. Maybe not complete but at least seems to allow basic usage again (through virt-manager). -Stefan --- From f406c6891fb92a45dc5d5a4d794c5d667965d096 Mon Sep 17 00:00:00 2001

[libvirt] xen: Add interface versions for Xen 4.3

2013-07-16 Thread Stefan Bader
I tried to follow previous changes. This worked for me using Xen-4.3 and the xm stack (I know rather deprecated but as long as one can get it working, still). -Stefan --- From 4c36fb22f01689472f6e170a8df6e08fd8c27a42 Mon Sep 17 00:00:00 2001 From: Stefan Bader stefan.ba...@canonical.com Date:

[libvirt] [PATCH] build: avoid compiler warning on shadowed name

2013-07-16 Thread Eric Blake
Introduced in commit 24b08219; compilation on RHEL 6.4 complained: qemu/qemu_hotplug.c: In function 'qemuDomainAttachChrDevice': qemu/qemu_hotplug.c:1257: error: declaration of 'remove' shadows a global declaration [-Wshadow] /usr/include/stdio.h:177: error: shadowed declaration is here

Re: [libvirt] [PATCH] Create directory for lease files if it's missing

2013-07-16 Thread Guido Günther
On Tue, Jul 16, 2013 at 03:18:25PM +0100, Daniel P. Berrange wrote: On Tue, Jul 16, 2013 at 04:04:56PM +0200, Guido Günther wrote: On Thu, Jul 11, 2013 at 07:33:52PM +0200, Guido Günther wrote: If we don't autostart a network it's not being created. Debian Bug

[libvirt] [PATCH] qemu_conf: Properly mark driver-config as self-locking APIs

2013-07-16 Thread Michal Privoznik
Since a9e97e0c we don't require driver-config, or virQEMUDriverGetConfig() to be called with locked QEMU driver. In fact, calling it with the driver locked would cause deadlock. Hence, the annotation to the struct field is not right. --- src/qemu/qemu_conf.h | 3 +-- 1 file changed, 1

Re: [libvirt] [PATCH 04/12] qemu: Add qemuDomainReleaseDeviceAddress to remove any address

2013-07-16 Thread Jiri Denemark
On Tue, Jul 16, 2013 at 10:54:50 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:05PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_command.c | 35 --- src/qemu/qemu_command.h | 8 +++--- src/qemu/qemu_hotplug.c | 75

Re: [libvirt] [PATCH 05/12] qemu: Separate disk device removal into a standalone function

2013-07-16 Thread Jiri Denemark
On Tue, Jul 16, 2013 at 10:56:13 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:06PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_driver.c | 31 +--- src/qemu/qemu_hotplug.c | 127 ++-- src/qemu/qemu_hotplug.h | 4

Re: [libvirt] [PATCH 08/12] qemu: Separate host device removal into a standalone function

2013-07-16 Thread Jiri Denemark
On Tue, Jul 16, 2013 at 10:58:11 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:09PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 240 1 file changed, 142 insertions(+), 98 deletions(-) ACK Pushed, thanks.

Re: [libvirt] [PATCH 07/12] qemu: Separate net device removal into a standalone function

2013-07-16 Thread Jiri Denemark
On Tue, Jul 16, 2013 at 10:57:45 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:08PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 101 +--- 1 file changed, 62 insertions(+), 39 deletions(-) ACK Pushed, thanks.

Re: [libvirt] [PATCH 06/12] qemu: Separate controller removal into a standalone function

2013-07-16 Thread Jiri Denemark
On Tue, Jul 16, 2013 at 10:56:55 +0100, Daniel Berrange wrote: On Mon, Jul 15, 2013 at 07:11:07PM +0200, Jiri Denemark wrote: --- src/qemu/qemu_hotplug.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) ACK Pushed, thanks. Jirka -- libvir-list mailing

Re: [libvirt] Hard link to root-owned file now fails (since Fedora 19)

2013-07-16 Thread Richard W.M. Jones
On Tue, Jul 16, 2013 at 01:37:33PM -0400, Colin Walters wrote: But ok, so as you said in the followup, the real root issue here is libvirt calling chown [on the kernel and initrd]. It's not clear to me why it does so. It's a good question, and trying to formulate an answer made me question

Re: [libvirt] [PATCH] qemu_conf: Properly mark driver-config as self-locking APIs

2013-07-16 Thread Eric Blake
On 07/16/2013 12:25 PM, Michal Privoznik wrote: Since a9e97e0c we don't require driver-config, or virQEMUDriverGetConfig() to be called with locked QEMU driver. In fact, calling it with the driver locked would cause deadlock. Hence, the annotation to the struct field is not right. ---

Re: [libvirt] [PATCH] cgroup: Free line even if no characters were read

2013-07-16 Thread Guannan Ren
On 07/16/2013 08:14 PM, Ján Tomko wrote: Even if getline doesn't read any characters it allocates a buffer. ==404== 120 bytes in 1 blocks are definitely lost in loss record 1,344 of 1,671 ==404==at 0x4C2C71B: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==404==by

Re: [libvirt] [PATCH] cgroup: Free line even if no characters were read

2013-07-16 Thread Eric Blake
On 07/16/2013 06:14 AM, Ján Tomko wrote: Even if getline doesn't read any characters it allocates a buffer. ==404== 120 bytes in 1 blocks are definitely lost in loss record 1,344 of 1,671 ==404==at 0x4C2C71B: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==404==

Re: [libvirt] [PATCH v4 2/4] storage: report error rather than warning if backing files doesn't exist

2013-07-16 Thread Guannan Ren
On 07/16/2013 04:40 PM, Daniel P. Berrange wrote: On Tue, Jul 16, 2013 at 08:14:54AM +0200, Martin Kletzander wrote: On 07/15/2013 05:31 PM, Ján Tomko wrote: On 07/02/2013 11:35 AM, Guannan Ren wrote: If one of backing files for disk source doesn't exist, the guest will not be able to find

Re: [libvirt] [test-API][PATCH] Modify repos/network/network_list.py and add network_list case to conf

2013-07-16 Thread Guannan Ren
On 07/16/2013 05:38 PM, hongming zhang wrote: Modify the old network_list.py. The new network_list.py covers all flags of listAllNetworks and the following api. and add network_list to basic_network.conf. virNetwork: name() bridgeName() isActive() isPersistent() virConnect: listAllNetworks() ---

Re: [libvirt] [PATCH] add console support in libxl

2013-07-16 Thread Bamvor Jian Zhang
Hi, Jim thanks your reply. one comment below. 已写入 Jim Fehlig jfeh...@suse.com On 07/04/2013 05:58 AM, Bamvor Jian Zhang wrote: this patch introduce the console api in libxl driver for both pv and hvm guest. and import and update the libxlMakeChrdevStr function which was deleted in

Re: [libvirt] [PATCH v4 2/4] storage: report error rather than warning if backing files doesn't exist

2013-07-16 Thread Guannan Ren
On 07/15/2013 11:31 PM, Ján Tomko wrote: On 07/02/2013 11:35 AM, Guannan Ren wrote: If one of backing files for disk source doesn't exist, the guest will not be able to find and use the disk even though the disk still exists in guest xml definition. So reporting an error make more sense.