Re: [libvirt] [PATCH v2] bridge driver: extract platform specifics

2013-08-01 Thread Roman Bogorodskiy
Hi Eric! Any chance you could take a look at it? I know that patches could hang much longer, but this one blocks my further work on making bridge driver work on FreeBSD. After we're done with the split, you will be able to rest from me for some time because proper FreeBSD implementation will not

Re: [libvirt] [PATCH 1/9] qemu_command: Drop incorrect ATTRIBUTE_UNUSED annotation

2013-08-01 Thread Laine Stump
On 07/31/2013 10:14 PM, Cole Robinson wrote: --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index aa3a2fd..d924110 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@

Re: [libvirt] [PATCH 2/9] domain_conf: Set QEMU ARM default USB model to 'none'

2013-08-01 Thread Laine Stump
On 07/31/2013 10:14 PM, Cole Robinson wrote: Preferably what we'd do is not add any USB controller by default, but that goes against how the QEMU driver has historically acted for other architectures, so let's be consistent. --- src/conf/domain_conf.c | 18 -- 1 file

Re: [libvirt] [PATCH 3/9] domain_conf: Don't add default memballoon device on ARM

2013-08-01 Thread Laine Stump
On 07/31/2013 10:14 PM, Cole Robinson wrote: Unlike USB, qemu_command can handle an empty memballoon device, so just don't add it. And add test cases for a basic working ARM guest. --- docs/schemas/domaincommon.rng | 19 +++ src/conf/domain_conf.c

[libvirt] [PATCHv3 4/4] change lxc driver to use hostdev common library

2013-08-01 Thread cyliu
From: Chunyan Liu cy...@suse.com Change lxc driver to use hostdev common library instead of its own APIs in lxc_hostdev.[ch] Signed-off-by: Chunyan Liu cy...@suse.com --- po/POTFILES.in|1 - src/Makefile.am |1 - src/lxc/lxc_conf.h|4 - src/lxc/lxc_driver.c | 45

[libvirt] [PATCHv3 0/4] write separate module for hostdev passthrough

2013-08-01 Thread cyliu
From: Chunyan Liu cy...@suse.com These patches implements a separate module for hostdev passthrough so that it could be shared by different drivers and can maintain a global state of a host device. Plus, add passthrough to libxl driver, and change qemu driver and lxc driver to use hostdev common

[libvirt] [PATCHv3 2/4] add pci passthrough to libxl driver

2013-08-01 Thread cyliu
From: Chunyan Liu cy...@suse.com Add pci passthrough to libxl driver, support attach-device, detach-device and start a vm with pci hostdev specified. Signed-off-by: Chunyan Liu cy...@suse.com --- src/libxl/libxl_conf.c | 65 src/libxl/libxl_conf.h |5 +-

Re: [libvirt] [PATCH 5/9] qemu: Don't try to allocate PCI addresses for ARM

2013-08-01 Thread Laine Stump
On 07/31/2013 10:14 PM, Cole Robinson wrote: --- src/qemu/qemu_command.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4209e5e..6da35d0 100644 --- a/src/qemu/qemu_command.c +++

Re: [libvirt] [PATCH 7/9] qemu: Fix networking for ARM guests

2013-08-01 Thread Laine Stump
On 07/31/2013 10:14 PM, Cole Robinson wrote: Similar to the chardev bit, ARM boards depend on the old style '-net nic' for actually instantiating net devices. And add tests for working ARM XML with console, disk, and networking. --- src/qemu/qemu_command.c| 34

Re: [libvirt] [PATCH 8/9] qemu: Only setup vhost if virtType == kvm

2013-08-01 Thread Laine Stump
On 07/31/2013 10:14 PM, Cole Robinson wrote: vhost only works in KVM mode AIUI, What's your definition of AIUI? :-) That makes sense, but in case you haven't yet asked MST, I'm CC'ing him to get it straight from the source. MST? If that's true, then ACK (and we might want to backport this to

Re: [libvirt] [PATCH 9/9] qemu: Support virtio-mmio transport for virtio on ARM

2013-08-01 Thread Laine Stump
On 07/31/2013 10:14 PM, Cole Robinson wrote: Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. Okay, so there is something named virtio-mmio that is visible in the qemu capabilities; it isn't added to

Re: [libvirt] [PATCH 8/9] qemu: Only setup vhost if virtType == kvm

2013-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2013 at 03:06:41AM -0400, Laine Stump wrote: On 07/31/2013 10:14 PM, Cole Robinson wrote: vhost only works in KVM mode AIUI, What's your definition of AIUI? :-) That makes sense, but in case you haven't yet asked MST, I'm CC'ing him to get it straight from the source. MST?

Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation.

2013-08-01 Thread Daniel P. Berrange
On Wed, Jul 31, 2013 at 11:50:18PM -0400, Jincheng Miao wrote: On 08/01/2013 05:48 AM, Eric Blake wrote: When compiling qemuagenttest, a link error occurs like: ./.libs/libqemumonitortestutils.a(qemumonitortestutils.o): In function `qemuMonitorTestFree':

Re: [libvirt] [PATCH 4/9] qemu: Fix adding specifying char devs for ARM

2013-08-01 Thread Daniel P. Berrange
On Wed, Jul 31, 2013 at 10:14:34PM -0400, Cole Robinson wrote: QEMU ARM boards don't give us any way to explicitly wire in a -chardev, so use the old style -serial options. --- src/qemu/qemu_capabilities.c | 18 ++ src/qemu/qemu_capabilities.h | 4

Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation.

2013-08-01 Thread Jincheng Miao
Hi DB, I do not disable shared libs explicit in my memory, I think that is all default. My fc19 computer is in my home. So I will check it when I get home as soon as possible. - Original Message - From: Daniel P. Berrange berra...@redhat.com To: Jincheng Miao jm...@redhat.com Cc: Eric

Re: [libvirt] [PATCH 7/9] qemu: Fix networking for ARM guests

2013-08-01 Thread Daniel P. Berrange
On Wed, Jul 31, 2013 at 10:14:37PM -0400, Cole Robinson wrote: Similar to the chardev bit, ARM boards depend on the old style '-net nic' for actually instantiating net devices. And add tests for working ARM XML with console, disk, and networking. --- src/qemu/qemu_command.c

Re: [libvirt] [PATCH 9/9] qemu: Support virtio-mmio transport for virtio on ARM

2013-08-01 Thread Daniel P. Berrange
On Wed, Jul 31, 2013 at 10:14:39PM -0400, Cole Robinson wrote: Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use virtio-XXX-device rather than virtio-XXX-pci,

Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation.

2013-08-01 Thread Jincheng Miao
hi DB, in my fc19 build log, I see ../src/.libs/libvirt.so, maybe it tells that no disable shared libraries. - Original Message - From: Jincheng Miao jm...@redhat.com To: Daniel P. Berrange berra...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, August 1, 2013 4:08:49 PM

[libvirt] [PATCH v2 3/3] Test network XML update

2013-08-01 Thread Ján Tomko
Add checks for updating sections of network definition via virNetworkDefUpdateSection. https://bugzilla.redhat.com/show_bug.cgi?id=989569 --- src/conf/network_conf.h| 9 + src/conf/network_conf.c| 2 +- src/libvirt_private.syms

[libvirt] [PATCH v2 2/3] Reverse logic allowing partial DHCP host XML

2013-08-01 Thread Ján Tomko
Before, missing attributes were only OK when adding entries; modification and deletion required all of them. Now, only deletion works with missing attributes, as long as the host is uniquely identified. --- src/conf/network_conf.c | 21 + 1 file changed, 5 insertions(+), 16

[libvirt] [PATCH v2 0/3] Add tests for network update XML parsing

2013-08-01 Thread Ján Tomko
v1: https://www.redhat.com/archives/libvir-list/2013-July/msg01971.html v2: remove the spaces from other elements instead of adding one Ján Tomko (3): Remove the space before the slash in network XML Reverse logic allowing partial DHCP host XML Test network XML update

Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation.

2013-08-01 Thread Jincheng Miao
Sorry about uploading a large attachment. And the build log link is: https://app.box.com/s/gbjihylb3gvvh89xbn5m - Original Message - From: Jincheng Miao jm...@redhat.com To: Eric Blake ebl...@redhat.com Cc: libvir-list@redhat.com Sent: Thursday, August 1, 2013 4:03:29 PM Subject: Re:

[libvirt] [PATCH v2 1/3] Remove the space before the slash in network XML

2013-08-01 Thread Ján Tomko
This matches the style we use elsewhere and allows nat-network-dns-srv-record{,-minimal}.xml to be tested in network XML - XML test. --- src/conf/network_conf.c| 24 +++--- src/network/default.xml| 4 ++--

[libvirt] [PATCHv2 2/5] virstring.h/c: Util method for making some find and replace in strings

2013-08-01 Thread Manuel VIVES
--- src/libvirt_private.syms |1 + src/util/virstring.c | 48 ++ src/util/virstring.h |2 ++ 3 files changed, 51 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 4127f14..70ed546 100644 ---

[libvirt] [PATCHv2 4/5] vbox_tmpl.c: Patch for redefining snapshots

2013-08-01 Thread Manuel VIVES
The snapshots are saved in xml files, and then can be redefined --- src/vbox/vbox_tmpl.c | 846 +- 1 file changed, 838 insertions(+), 8 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 6a5f41a..4138702 100644 ---

[libvirt] [PATCHv2 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2

2013-08-01 Thread Manuel VIVES
Hi, This is a serie of patches in order to support undefining and redefining snapshots with VirtualBox 4.2. The serie of patches is rather big, and adds among other things some utility functions unrelated to VirtualBox in patches 1 2. The code review could be done in several parts: e.g. patches

[libvirt] [PATCHv2 5/5] vbox_tmpl.c: Add methods for undefining snapshots

2013-08-01 Thread Manuel VIVES
All the informations concerning snapshots (and snapshot disks) will be deleted from the vbox xml. But the differencing disks will be kept so you will be able to redefine the snapshots. --- src/vbox/vbox_tmpl.c | 386 ++ 1 file changed, 386

[libvirt] [PATCHv2 1/5] viruuid.h/c: Util method for finding uuid patterns in some strings

2013-08-01 Thread Manuel VIVES
--- src/libvirt_private.syms |1 + src/util/viruuid.c | 79 ++ src/util/viruuid.h |1 + 3 files changed, 81 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a958d94..4127f14 100644 ---

[libvirt] [PATCHv2 3/5] vbox_tmpl.c: Better XML description for snapshots

2013-08-01 Thread Manuel VIVES
It will be needed for the futur patches because we will redefine snapshots --- src/conf/domain_conf.c | 20 ++- src/vbox/vbox_tmpl.c | 424 ++-- 2 files changed, 424 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH 1/2] maint: use modern autoconf idioms

2013-08-01 Thread Peter Krempa
On 08/01/13 00:48, Eric Blake wrote: Autoconf 2.59 says that AC_OUTPUT with arguments is obsolete, and we are already using the replacement for some, but not all, of our output files. * configure.ac (AC_OUTPUT): Rewrite to use AC_CONFIG_FILES. Signed-off-by: Eric Blake ebl...@redhat.com ---

[libvirt] ANNOUNCE: libvirt-sandbox Sahara Desert release 0.5.0

2013-08-01 Thread Daniel P. Berrange
I pleased to announce the a new public release of libvirt-sandbox, version 0.5.0, is now available for download ftp://libvirt.org/libvirt/sandbox/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) The libvirt-sandbox package

Re: [libvirt] [PATCH 18/20] qemuagenttest: Introduce testing of shutdown commands

2013-08-01 Thread John Ferlan
On 07/30/2013 09:05 AM, Peter Krempa wrote: This patch exports a few utility functions and adds testing of shutdown commands of the guest agent. --- ...snip... + +static int +qemuAgentShutdownTestMonitorHandler(qemuMonitorTestPtr test, +

Re: [libvirt] [PATCH 14/20] qemumonitortestutils: Add the ability to check arguments of commands

2013-08-01 Thread John Ferlan
On 07/30/2013 09:05 AM, Peter Krempa wrote: ...snip... +/* this allows to add a responder that is able to check + * a (shallow) structure of arguments for a command */ +int +qemuMonitorTestAddItemParams(qemuMonitorTestPtr test, + const char *cmdname, +

Re: [libvirt] [PATCH 2/2] build: add configure option to disable gnulib tests

2013-08-01 Thread Peter Krempa
On 08/01/13 00:48, Eric Blake wrote: The gnulib testsuite is relatively stable - the only times it is likely to have a test change from pass to fail is on a gnulib submodule update or a major system change (such as moving from Fedora 18 to 19, or other large change to libc). While it is an

Re: [libvirt] [PATCH 2/2] build: add configure option to disable gnulib tests

2013-08-01 Thread Eric Blake
On 08/01/2013 07:10 AM, Peter Krempa wrote: On 08/01/13 00:48, Eric Blake wrote: The gnulib testsuite is relatively stable - the only times it is likely to have a test change from pass to fail is on a gnulib submodule update or a major system change (such as moving from Fedora 18 to 19, or

[libvirt] [PATCH 2/3] qemuagenttest: Test timeout of agent commands

2013-08-01 Thread Peter Krempa
If VIR_TEST_EXPENSIVE is enabled, test timeout of agent commands. This test takes 6 seconds to finish. --- tests/qemuagenttest.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c index

[libvirt] [PATCH 3/3] test-lib.sh: Update helper for VIR_TEST_EXPENSIVE and use it in virsh-all

2013-08-01 Thread Peter Krempa
When the test-lib for shell tests was introduced it did think of expensive tests although this option was never used. Update the code for the new env variable name. Use this function in the virsh-all test that blindly runs all virsh commands without any arguments and thus it's rather time

[libvirt] [PATCH 1/3] qemuagenttest: Test arbitrary command passthrough

2013-08-01 Thread Peter Krempa
Excercise the arbitrary command passthrough API. --- tests/qemuagenttest.c | 45 + 1 file changed, 45 insertions(+) diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c index cabd5b7..1818d50 100644 --- a/tests/qemuagenttest.c +++

[libvirt] [PATCH 0/3] Rest of qemu agent tests and fix of expensive tests

2013-08-01 Thread Peter Krempa
This series contains the rest of the qemu agent tests that have been tweaked to act according to the VIR_TEST_EXPENSIVE env variable and also uses it for the virsh-all test Peter Krempa (3): qemuagenttest: Test arbitrary command passthrough qemuagenttest: Test timeout of agent commands

Re: [libvirt] [PATCH 18/20] qemuagenttest: Introduce testing of shutdown commands

2013-08-01 Thread Peter Krempa
On 08/01/13 13:39, John Ferlan wrote: On 07/30/2013 09:05 AM, Peter Krempa wrote: This patch exports a few utility functions and adds testing of shutdown commands of the guest agent. --- ...snip... + +static int +qemuAgentShutdownTestMonitorHandler(qemuMonitorTestPtr test, +

Re: [libvirt] [PATCH 1/2] maint: use modern autoconf idioms

2013-08-01 Thread Eric Blake
On 08/01/2013 04:40 AM, Peter Krempa wrote: On 08/01/13 00:48, Eric Blake wrote: Autoconf 2.59 says that AC_OUTPUT with arguments is obsolete, and we are already using the replacement for some, but not all, of our output files. * configure.ac (AC_OUTPUT): Rewrite to use AC_CONFIG_FILES.

Re: [libvirt] [PATCH 00/20] tests: add qemu agent test

2013-08-01 Thread Daniel P. Berrange
On Tue, Jul 30, 2013 at 03:05:35PM +0200, Peter Krempa wrote: As promised earlier I'm sending a unit test for guest agent interaction. This series contains a few refactors and additions of monitor test utils and then add tests for all agent interaction functions. The refactors done in this

[libvirt] [PATCH 0/3] Fix coverity issues introduced by qemuagenttest and the refactor

2013-08-01 Thread Peter Krempa
Fix the issues reported by John and also add yet another test subcase. Peter Krempa (3): qemuagenttest: Fix checking of shutdown mode qemuagenttest: Check invalid response in shutdown test qemumonitortestutils: Don't skip va_end() on error path tests/qemuagenttest.c| 32

[libvirt] [PATCH 1/3] qemuagenttest: Fix checking of shutdown mode

2013-08-01 Thread Peter Krempa
Coverity complained about unused variable that contains the shutdown mode. The original intention was to check it against the requested mode. Also the fixed check reveald a mistake in the expected shutdown mode. Reported by John Ferlan. --- tests/qemuagenttest.c | 9 - 1 file changed, 8

[libvirt] [PATCH 2/3] qemuagenttest: Check invalid response in shutdown test

2013-08-01 Thread Peter Krempa
The shutdown test utilizes waiting for condition to exit the test. This addition will return an error for the shutdown command to see if the condition waiting code will not hang. --- tests/qemuagenttest.c | 23 +++ 1 file changed, 23 insertions(+) diff --git

[libvirt] [PATCH 3/3] qemumonitortestutils: Don't skip va_end() on error path

2013-08-01 Thread Peter Krempa
When allocation of memory failed the error path didn't call va_end() causing a coverity failure. Reported by John Ferlan. --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index

Re: [libvirt] [PATCH v5 2/2] qemu: support to drop disk with 'optional' startupPolicy

2013-08-01 Thread Martin Kletzander
On 07/31/2013 09:51 AM, Guannan Ren wrote: Go through disks of guest, if one disk doesn't exist or its backing chain is broken, with 'optional' startupPolicy, for CDROM and Floppy we only discard its source path definition in xml, for disks we drop it from disk list and free it. ---

[libvirt] Libvirt not getting connected to ESX server

2013-08-01 Thread varun bhatnagar
Hi, I was trying to connect to ESX server using libvirt's virsh console but I am getting the following error: *virsh# connect esx://172.16.73.14* *Enter username for 172.16.73.14 [root]: root* *Enter root's password for 172.16.73.14:* *error: Failed to connect to the hypervisor* *error: internal

Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation.

2013-08-01 Thread Jincheng Miao
If I build libvirt with CFLAGS=-O0 in fedora 19, the error will happen. If CFLAGS=-O2, not. I think this optimization options break the rule of lazy linking. - Original Message - From: Eric Blake ebl...@redhat.com To: Jincheng Miao jm...@redhat.com Cc: libvir-list@redhat.com Sent:

Re: [libvirt] [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Eric Blake
On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic).

Re: [libvirt] [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2013 at 10:26:53AM -0600, Eric Blake wrote: On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have

[libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19.

2013-08-01 Thread Jincheng Miao
Someone may need to build libvirt with -O0. When building libvirt with -O0 flag in fedora 19, it will fail to generate qemuagenttest, a link error occurs like: ./.libs/libqemumonitortestutils.a(qemumonitortestutils.o): In function `qemuMonitorTestFree': libvirt/tests/qemumonitortestutils.c:346:

Re: [libvirt] [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Marcel Apfelbaum
On Thu, 2013-08-01 at 19:31 +0300, Michael S. Tsirkin wrote: On Thu, Aug 01, 2013 at 10:26:53AM -0600, Eric Blake wrote: On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running

Re: [libvirt] [PATCH 1/3] qemuagenttest: Fix checking of shutdown mode

2013-08-01 Thread John Ferlan
On 08/01/2013 10:39 AM, Peter Krempa wrote: Coverity complained about unused variable that contains the shutdown mode. The original intention was to check it against the requested mode. Also the fixed check reveald a mistake in the expected shutdown mode. Reported by John Ferlan. ---

Re: [libvirt] [PATCH 1/3] qemuagenttest: Fix checking of shutdown mode

2013-08-01 Thread Eric Blake
On 08/01/2013 08:39 AM, Peter Krempa wrote: Coverity complained about unused variable that contains the shutdown mode. The original intention was to check it against the requested mode. Also the fixed check reveald a mistake in the expected shutdown mode. s/reveald/revealed/ Reported by

Re: [libvirt] [PATCH 3/3] qemumonitortestutils: Don't skip va_end() on error path

2013-08-01 Thread Eric Blake
On 08/01/2013 08:39 AM, Peter Krempa wrote: When allocation of memory failed the error path didn't call va_end() causing a coverity failure. Reported by John Ferlan. --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK. diff --git

Re: [libvirt] [PATCH 2/3] qemuagenttest: Check invalid response in shutdown test

2013-08-01 Thread Eric Blake
On 08/01/2013 08:39 AM, Peter Krempa wrote: The shutdown test utilizes waiting for condition to exit the test. This addition will return an error for the shutdown command to see if the condition waiting code will not hang. --- tests/qemuagenttest.c | 23 +++ 1 file

Re: [libvirt] [PATCH 3/3] qemumonitortestutils: Don't skip va_end() on error path

2013-08-01 Thread John Ferlan
On 08/01/2013 10:39 AM, Peter Krempa wrote: When allocation of memory failed the error path didn't call va_end() causing a coverity failure. Reported by John Ferlan. --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ACK John -- libvir-list mailing

Re: [libvirt] [PATCH 2/3] qemuagenttest: Check invalid response in shutdown test

2013-08-01 Thread John Ferlan
On 08/01/2013 10:39 AM, Peter Krempa wrote: The shutdown test utilizes waiting for condition to exit the test. This addition will return an error for the shutdown command to see if the condition waiting code will not hang. --- tests/qemuagenttest.c | 23 +++ 1 file

Re: [libvirt] [PATCH 2/3] qemuagenttest: Check invalid response in shutdown test

2013-08-01 Thread Eric Blake
On 08/01/2013 11:57 AM, John Ferlan wrote: On 08/01/2013 10:39 AM, Peter Krempa wrote: The shutdown test utilizes waiting for condition to exit the test. This addition will return an error for the shutdown command to see if the condition waiting code will not hang. --- tests/qemuagenttest.c

[libvirt] [PATCH 02/17] qemu: Avoid using global qemu_driver in event handlers

2013-08-01 Thread Jiri Denemark
We will have to pass a mock-up of the driver when testing monitor events. --- src/qemu/qemu_capabilities.c | 5 ++- src/qemu/qemu_monitor.c | 24 +++ src/qemu/qemu_monitor.h | 69 -- src/qemu/qemu_process.c | 99

[libvirt] [PATCH 00/17] Add tests for disk hotplug

2013-08-01 Thread Jiri Denemark
This series adds tests for hotplugging all supported disk types. Jiri Denemark (17): qemu: Typedef monitor callbacks qemu: Avoid using global qemu_driver in event handlers qemu: Move qemuDomainAttachDeviceDiskLive to qemu_hotplug.c qemu: Move qemuDomainDetachDeviceDiskLive to

[libvirt] [PATCH 01/17] qemu: Typedef monitor callbacks

2013-08-01 Thread Jiri Denemark
Otherwise defining variables that hold callbacks pointers is ugly and several places have to be changed when new parameters are added. --- src/qemu/qemu_monitor.c | 6 +- src/qemu/qemu_monitor.h | 171 +++- 2 files changed, 98 insertions(+), 79

[libvirt] [PATCH 07/17] qemuhotplugtest: Define QMP_OK for the most common reply

2013-08-01 Thread Jiri Denemark
--- tests/qemuhotplugtest.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 98dfd93..4712334 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -344,24 +344,27 @@ mymain(void) #define

[libvirt] [PATCH 04/17] qemu: Move qemuDomainDetachDeviceDiskLive to qemu_hotplug.c

2013-08-01 Thread Jiri Denemark
--- src/qemu/qemu_driver.c | 52 -- src/qemu/qemu_hotplug.c | 67 - src/qemu/qemu_hotplug.h | 9 +++ 3 files changed, 64 insertions(+), 64 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 05/17] qemuhotplugtest: Generate better output

2013-08-01 Thread Jiri Denemark
Each test case label now contains more data useful to identify the test. --- tests/qemuhotplugtest.c | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index c7be5f6..4f48ee0 100644 ---

[libvirt] [PATCH 13/17] qemu: Let tests override waiting time for device unplug

2013-08-01 Thread Jiri Denemark
We don't want tests to wait 5 seconds for an event which we know will never come. --- src/Makefile.am | 1 + src/qemu/qemu_hotplug.c | 10 ++ src/qemu/qemu_hotplugpriv.h | 31 +++ 3 files changed, 38 insertions(+), 4 deletions(-) create mode

[libvirt] [PATCH 03/17] qemu: Move qemuDomainAttachDeviceDiskLive to qemu_hotplug.c

2013-08-01 Thread Jiri Denemark
--- src/qemu/qemu_driver.c | 114 -- src/qemu/qemu_hotplug.c | 142 src/qemu/qemu_hotplug.h | 16 ++ 3 files changed, 134 insertions(+), 138 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 15/17] qemuhotplugtest: Add tests for async virtio disk detach

2013-08-01 Thread Jiri Denemark
--- tests/qemuhotplugtest.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 4901178..5e25ea9 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -389,6 +389,19 @@ mymain(void) #define QMP_OK

[libvirt] [PATCH 06/17] qemuhotplugtest: Compare domain XML after device hotplug

2013-08-01 Thread Jiri Denemark
We need to make sure a device is properly added/removed (or not) to a domain definition to check that a hotplug API did not lie to us. --- tests/qemuhotplugtest.c| 67 +-- ...qemuhotplug-console-compat-2+console-virtio.xml | 127 + 2 files

[libvirt] [PATCH 08/17] qemuxml2argvtest: Add XML for testing device hotplug

2013-08-01 Thread Jiri Denemark
This is a generic XML usable for hotplugging various types of devices. --- .../qemuxml2argv-hotplug-base.args | 7 .../qemuxml2argvdata/qemuxml2argv-hotplug-base.xml | 38 ++ tests/qemuxml2argvtest.c | 4 +++ 3 files changed, 49

[libvirt] [PATCH 09/17] qemuhotplugtest: Add tests for virtio disk hotplug

2013-08-01 Thread Jiri Denemark
--- tests/qemuhotplugtest.c| 44 ++--- .../qemuhotplug-disk-virtio.xml| 7 .../qemuhotplug-hotplug-base+disk-virtio.xml | 46 ++ 3 files changed, 91 insertions(+), 6 deletions(-) create mode 100644

[libvirt] [PATCH 14/17] qemuhotplugtest: Add support for DEVICE_DELETED event

2013-08-01 Thread Jiri Denemark
--- tests/qemuhotplugtest.c | 29 +++-- tests/qemumonitortestutils.c | 2 ++ 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 6fa331e..4901178 100644 --- a/tests/qemuhotplugtest.c +++

[libvirt] [PATCH 17/17] qemuhotplugtest: Add tests for virtio SCSI disk hotplug

2013-08-01 Thread Jiri Denemark
--- tests/qemuhotplugtest.c| 18 + .../qemuhotplugtestdata/qemuhotplug-disk-scsi.xml | 7 .../qemuhotplug-hotplug-base+disk-scsi.xml | 46 ++ 3 files changed, 71 insertions(+) create mode 100644

[libvirt] [PATCH 11/17] tests: Add support for passing driver to qemu monitor

2013-08-01 Thread Jiri Denemark
The driver is then passed to monitor event handlers. --- tests/qemuhotplugtest.c | 2 +- tests/qemumonitortestutils.c | 5 +++-- tests/qemumonitortestutils.h | 6 -- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index

[libvirt] [PATCH 10/17] tests: Add support for passing vm to qemu monitor

2013-08-01 Thread Jiri Denemark
Some tests need the monitor to operate on an already existing VM object rather than on a new mock-up the monitor test normally creates. --- tests/qemuhotplugtest.c | 2 +- tests/qemumonitorjsontest.c | 26 +- tests/qemumonitortestutils.c | 19 ++-

[libvirt] [PATCH 12/17] qemu: Export qemuProcessHandleDeviceDeleted for tests

2013-08-01 Thread Jiri Denemark
--- src/Makefile.am | 1 + src/qemu/qemu_process.c | 5 +++-- src/qemu/qemu_process.h | 2 +- src/qemu/qemu_processpriv.h | 37 + 4 files changed, 42 insertions(+), 3 deletions(-) create mode 100644 src/qemu/qemu_processpriv.h diff

[libvirt] [PATCH 16/17] qemuhotplugtest: Add tests for USB disk hotplug

2013-08-01 Thread Jiri Denemark
--- tests/qemuhotplugtest.c| 17 tests/qemuhotplugtestdata/qemuhotplug-disk-usb.xml | 7 .../qemuhotplug-hotplug-base+disk-usb.xml | 45 ++ 3 files changed, 69 insertions(+) create mode 100644

[libvirt] [PATCH 0/2] Coverity/Valgrind issues

2013-08-01 Thread John Ferlan
One new Coverity defect was discovered from existing code in this mornings run. Also recent changes seem to have adjusted tests and provoked valgrind to find/display potential leaks. That path had already been vetted previously in a shorter stack trace - just adjust the trace to allow inclusion

[libvirt] [PATCH 1/2] tests: Coverity found new NULL_RETURNS

2013-08-01 Thread John Ferlan
Coverity reported the existing missing check of the return value and subsequent use from a call to virJSONValueFromString() in testJSONAddRemove(). --- tests/jsontest.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/jsontest.c b/tests/jsontest.c index

[libvirt] [PATCH 2/2] valgrind: Adjust filter for _dl_allocate_tls

2013-08-01 Thread John Ferlan
More tests are now using the path - adjust the filter to include any path from a test through ptrhread_create to _dl_allocate_tls --- tests/.valgrind.supp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index f04912d..d4fef85

Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19.

2013-08-01 Thread Eric Blake
On 08/01/2013 11:05 AM, Jincheng Miao wrote: Someone may need to build libvirt with -O0. When building libvirt with -O0 flag in fedora 19, it will fail to generate qemuagenttest, a link error occurs like: ./.libs/libqemumonitortestutils.a(qemumonitortestutils.o): In function

Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation.

2013-08-01 Thread Eric Blake
On 08/01/2013 10:04 AM, Jincheng Miao wrote: [please don't top-post on technical lists] If I build libvirt with CFLAGS=-O0 in fedora 19, the error will happen. If CFLAGS=-O2, not. I think this optimization options break the rule of lazy linking. I still couldn't reproduce your problem, when

Re: [libvirt] [PATCH 1/2] tests: Coverity found new NULL_RETURNS

2013-08-01 Thread Eric Blake
On 08/01/2013 02:06 PM, John Ferlan wrote: Coverity reported the existing missing check of the return value and subsequent use from a call to virJSONValueFromString() in testJSONAddRemove(). --- tests/jsontest.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) ACK. diff

Re: [libvirt] [PATCH 2/2] valgrind: Adjust filter for _dl_allocate_tls

2013-08-01 Thread Eric Blake
On 08/01/2013 02:06 PM, John Ferlan wrote: More tests are now using the path - adjust the filter to include any path from a test through ptrhread_create to _dl_allocate_tls s/ptrhread/pthread/ ACK. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

Re: [libvirt] [PATCH] Fix build w/o cgroups

2013-08-01 Thread Eric Blake
On 07/31/2013 11:27 PM, Roman Bogorodskiy wrote: Build without cgroups support started to fail again recently. Do the following to fix it: - Add missing 'partition' arg that was added to the virCgroupValidateMachineGroup() but forgotten for the stub of the same function - Add stubs

Re: [libvirt] [PATCH 0/2] Coverity/Valgrind issues

2013-08-01 Thread John Ferlan
On 08/01/2013 04:06 PM, John Ferlan wrote: One new Coverity defect was discovered from existing code in this mornings run. Also recent changes seem to have adjusted tests and provoked valgrind to find/display potential leaks. That path had already been vetted previously in a shorter stack

Re: [libvirt] [PATCH v2] bridge driver: extract platform specifics

2013-08-01 Thread Eric Blake
On 07/24/2013 06:22 AM, Roman Bogorodskiy wrote: * Move platform specific things (e.g. firewalling and route collision checks) into bridge_driver_platform * Create two platform specific implementations: - bridge_driver_linux: Linux implementation using iptables, it's actually the

Re: [libvirt] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Paolo Bonzini
On 08/01/2013 06:26 PM, Eric Blake wrote: On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be

Re: [libvirt] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Eric Blake
On 08/01/2013 04:23 PM, Paolo Bonzini wrote: Automatic devices with no command line argument have proven to be a nightmare for libvirt as well. Although the just-released libvirt 1.1.1 now supports the on_crash element for controlling the command line parameters of qemu related to how qemu

[libvirt] ANNOUNCE: libvirt 1.0.5.5 maintenance release

2013-08-01 Thread Cole Robinson
libvirt 1.0.5.5 maintenance release is now available. This is libvirt 1.0.5 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.0.5.5.tar.gz Changes in this version: * Set the

[libvirt] ANNOUNCE: libvirt 0.10.2.7 maintenance release

2013-08-01 Thread Cole Robinson
libvirt 0.10.2.7 maintenance release is now available. This is libvirt 0.10.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.10.2.7.tar.gz Changes in this version: * udev:

[libvirt] libvirt lxc fail to start when --with-dbus=no

2013-08-01 Thread Gao feng
2013-08-02 02:14:24.044+: 22126: error : virDBusGetSystemBus:1194 : internal error: DBus support not compiled into this binary int virSystemdCreateMachine(const char *name, const char *drivername, bool privileged,

Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19.

2013-08-01 Thread Jincheng Miao
- Original Message - From: Eric Blake ebl...@redhat.com To: Jincheng Miao jm...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, August 2, 2013 4:09:24 AM Subject: Re: [libvirt] [PATCHv2] build: fix qemuagenttest build with -O0 in fedora 19. This adds trailing whitespace,

Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation.

2013-08-01 Thread Jincheng Miao
- Original Message - From: Eric Blake ebl...@redhat.com To: Jincheng Miao jm...@redhat.com Cc: libvir-list@redhat.com Sent: Friday, August 2, 2013 4:01:02 AM Subject: Re: [libvirt] [PATCH] Fix test case qemuagenttest compilation. I still couldn't reproduce your problem, when I