Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-10 Thread Daniel P. Berrange
On Tue, Sep 10, 2013 at 01:29:40AM +, Liuji (Jeremy) wrote: -Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Monday, September 09, 2013 7:26 PM To: Liuji (Jeremy) Cc: libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng Subject: Re:

Re: [libvirt] [libvirt-php] bug in libvirt_domain_change_vcpus()

2013-09-10 Thread Daniel P. Berrange
On Mon, Sep 09, 2013 at 06:51:54PM +0200, Michal Novotny wrote: Hi Olivier, this is not really a bug as it's intended. The libvirt_domain_change_vcpus() is not the same as (yet unimplemented) virDomainSetVcpus() API so it's not bug. I realize that naming could be a little confusing so if you

Re: [libvirt] [PATCH] Ensure root filesystem is recursively mounted readonly

2013-09-10 Thread Daniel P. Berrange
On Tue, Sep 10, 2013 at 09:58:13AM +0800, Gao feng wrote: On 09/09/2013 11:30 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com If the guest is configured with filesystem type='mount' source dir='/'/ target dir='/'/ readonly/

[libvirt] [PATCH v3]LXC: Helper function for checking permission of dir when userns enabled

2013-09-10 Thread Chen Hanxiao
From: Chen Hanxiao chenhanx...@cn.fujitsu.com If we enable userns, the process with uid/gid in idmap should have enough permission to access dir we provided for containers. Currently, the debug log is very implicit or misleading sometimes. This patch will help clarify this for us when using debug

Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-10 Thread Liuji (Jeremy)
-Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Tuesday, September 10, 2013 3:57 PM To: Liuji (Jeremy) Cc: libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng Subject: Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro On

[libvirt] [PATCH] Update docs about user namespace for LXC

2013-09-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Mention that user namespace can be enabled using the UID/GID mapping schema. Fix typo in link anchor for container args in domain XML docs. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/drvlxc.html.in | 14 +-

[libvirt] [PATCH v2 3/6] qemu: add usb-bot support from disks points of view

2013-09-10 Thread Guannan Ren
usb-bot only supports 16 luns(0~15) and they must be contiguous, (using lun 0 and 2 without 1 doesn't work). In this case qemu doesn't throw an error, we can not find the lun 2 in guests. So Adding a checking function in libvirt to prevent from this case. --- src/conf/domain_conf.c | 59

[libvirt] [PATCH v2 4/6] qemu: refactor out function to build scsi device qemu commandline

2013-09-10 Thread Guannan Ren
--- src/qemu/qemu_command.c | 124 +++- 1 file changed, 48 insertions(+), 76 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1a6accd..aa91f57 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@

[libvirt] [PATCH v2 2/6] qemu: add usb-bot model scsi controller

2013-09-10 Thread Guannan Ren
usb-bot is SCSI HBA which support only one SCSI target with ID 0. we can create one or more SCSI devices connected to it with -device as its luns. For usb-bot the limit is 15 luns. The difference from other SCSI controllers is that usb-bot needs usb-bus support. That means usb-bot is required to

[libvirt] [PATCH v2 0/6]qemu: add usb-bot scsi controller support

2013-09-10 Thread Guannan Ren
BZ:https://bugzilla.redhat.com/show_bug.cgi?id=917702 v2: After discussion in BZ, qemu guys hope the usb-bot(+usb-uas) can be supported although the absence of its hot-plug feature. In this patch, libvirt gives an unsupported error in this case. v1:

Re: [libvirt] [PATCH]LXC doc: Add warns if net namespace not enabled

2013-09-10 Thread Daniel P. Berrange
On Mon, Sep 09, 2013 at 04:33:54PM +0800, Chen Hanxiao wrote: ping... -Original Message- From: libvir-list-boun...@redhat.com [mailto:libvir-list-boun...@redhat.com] On Behalf Of Chen Hanxiao Sent: Tuesday, September 03, 2013 10:04 AM To: 'Daniel P. Berrange' Cc:

[libvirt] [PATCH v2 5/6] qemu: no hot-plug/unplug support currently for usb-bot

2013-09-10 Thread Guannan Ren
--- src/conf/domain_conf.c | 4 +++- src/qemu/qemu_hotplug.c | 14 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7a4969e..60ca298 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17118,7

[libvirt] [PATCH v2 6/6] tests: add xml2argv test for usb-bot scsi controller

2013-09-10 Thread Guannan Ren
--- .../qemuxml2argv-disk-scsi-usbbot.args | 11 .../qemuxml2argv-disk-scsi-usbbot.xml | 33 ++ tests/qemuxml2argvtest.c | 3 ++ 3 files changed, 47 insertions(+) create mode 100644

[libvirt] [PATCH v2 1/6] qemu: add usb-bot qemu cap flag

2013-09-10 Thread Guannan Ren
QEMU_CAPS_DEVICE_USB_BOT /* -device usb-bot */ --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index d94188a..5cd7d45 100644 --- a/src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCH] Ensure root filesystem is recursively mounted readonly

2013-09-10 Thread Gao feng
On 09/10/2013 04:11 PM, Daniel P. Berrange wrote: Using SELinux, or dropping certain capabilities will prevent that, so this is still useful protection even if unconfined root can get around it. In addition Eric Biederman has a change to allow the mount state to be locked prevent this

Re: [libvirt] [PATCH]LXC doc: Add warns if net namespace not enabled

2013-09-10 Thread Chen Hanxiao
-Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Tuesday, September 10, 2013 5:20 PM To: Chen Hanxiao Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH]LXC doc: Add warns if net namespace not enabled On Mon, Sep 09, 2013 at 04:33:54PM +0800,

Re: [libvirt] [PATCH 1/4] build: avoid $(srcdir) in *_SOURCES

2013-09-10 Thread Michal Privoznik
On 09.09.2013 17:51, Eric Blake wrote: Trying to enable automake's subdir-objects option resulted in the creation of literal directories such as src/$(srcdir)/remote/. I traced this to the fact that we had used a literal $(srcdir) in a location that later fed an automake *_SOURCES variable.

Re: [libvirt] [PATCH 0/4] build: use subdir-objects

2013-09-10 Thread Michal Privoznik
On 09.09.2013 17:51, Eric Blake wrote: Automake 1.14 is annoyingly loud about warning that the future automake 2.0 will turn on subdir-objects by default. Since automake 1.9 also supports subdir-objects, the best course of action is to enable the feature. But we have to fix some problems

[libvirt] [PATCH 05/14] conf: Factor out setting of metadata to simplify code

2013-09-10 Thread Peter Krempa
The code to set the metadata in a domain definition is common to live and inactive domains. Factor it out into a common func. --- src/conf/domain_conf.c | 113 +++-- 1 file changed, 53 insertions(+), 60 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH 10/14] conf: allow to add XML metadata using the virDomainSetMetadata api

2013-09-10 Thread Peter Krempa
The functionality wasn't originally implemented. This patch adds the ability to modify domain's XML metadata using the API. --- src/conf/domain_conf.c | 47 ++- src/util/virxml.c | 32 src/util/virxml.h | 4

[libvirt] [PATCH 08/14] virsh-domain: Add command to allow modifications of XML metadata

2013-09-10 Thread Peter Krempa
The metadata modification functions will support modification of the XML metadata. Add a virsh command to allow using this approach. --- tools/virsh-domain.c | 161 +++ 1 file changed, 161 insertions(+) diff --git a/tools/virsh-domain.c

[libvirt] [PATCH 06/14] util: Add helper to convert libxml2 nodes to a string

2013-09-10 Thread Peter Krempa
--- src/libvirt_private.syms | 1 + src/util/virxml.c| 33 + src/util/virxml.h| 2 ++ 3 files changed, 36 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 0631941..18e9a4b 100644 --- a/src/libvirt_private.syms

[libvirt] [PATCH 04/14] qemu: Factor out body of qemuDomainSetMetadata for universal use

2013-09-10 Thread Peter Krempa
The function impelemnted common behavior that can be reused for other hypervisor drivers that use the virDomainObj data structures. Factor out the core into a separate helper func. --- src/conf/domain_conf.c | 85 src/conf/domain_conf.h | 10

[libvirt] [PATCH 01/14] virsh-domain: Remove spurious ATTRIBUTE_UNUSED from cmdDesc

2013-09-10 Thread Peter Krempa
The cmd variable is actually used so remove the attribute. --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 74feca1..f6bfad0 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6707,7

[libvirt] [PATCH 07/14] virsh-domain: use virXMLNodeDump instead of xmlNodeDump

2013-09-10 Thread Peter Krempa
--- tools/virsh-domain.c | 117 ++- 1 file changed, 31 insertions(+), 86 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 727a42a..0d00440 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2359,7 +2359,7 @@

[libvirt] [PATCH 02/14] virsh-domain: Line up signal names array

2013-09-10 Thread Peter Krempa
Line up the array so that the grid is visible. --- Notes: Not an useful change but it tripped my OCD while looking at the file. tools/virsh-domain.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c

[libvirt] [PATCH 00/14] Add ability to handle the metadata element using the API

2013-09-10 Thread Peter Krempa
This series adds the initialy omitted functionality of changing the metadata element using the virDomain[Get|Set]Metadata API. First few patches are cleanup of some code noticed during implementation of the other stuff. Peter Krempa (14): virsh-domain: Remove spurious ATTRIBUTE_UNUSED from

[libvirt] [PATCH 11/14] lib: Don't force the key argument when deleting metadata

2013-09-10 Thread Peter Krempa
virDomainSetMetadata when operating on the metadata element was requesting the @key argument to be passed even if @metadata was NULL used to delete the corresponding metadata element. This is not needed as the key is only used when adding the element and matching is done via the XML namespace. ---

[libvirt] [PATCH 09/14] conf: Add support for requesting of XML metadata via the API

2013-09-10 Thread Peter Krempa
The virDomainGetMetadata function was designed to support also retrieval of app specific metadata from the metadata element. This functionality was never implemented originally. --- src/conf/domain_conf.c | 19 src/libvirt_private.syms | 1 + src/util/virxml.c| 122

[libvirt] [PATCH 14/14] tests: Add metadata tests

2013-09-10 Thread Peter Krempa
This test excercises the virDomain[Get|Set]Metadata API and tests it for regressions --- tests/Makefile.am| 7 ++ tests/metadatatest.c | 245 +++ 2 files changed, 252 insertions(+) create mode 100644 tests/metadatatest.c diff --git

[libvirt] [PATCH 12/14] lxc: Add metadata modification APIs

2013-09-10 Thread Peter Krempa
--- src/lxc/lxc_driver.c | 70 1 file changed, 70 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index b587c22..d49f524 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -4591,6 +4591,74 @@

[libvirt] [PATCH 03/14] qemu: Factor out body of qemuDomainGetMetadata for universal use

2013-09-10 Thread Peter Krempa
The function impelemnted common behavior that can be reused for other hypervisor drivers that use the virDomainObj data structures. Factor out the core into a separate helper func. --- src/conf/domain_conf.c | 55 src/conf/domain_conf.h | 7

[libvirt] [PATCH 13/14] test: Add metadata support into the test driver

2013-09-10 Thread Peter Krempa
--- src/test/test_driver.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c225618..23f7b2e 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -2585,6 +2585,72 @@

[libvirt] [PATCH] Add some notes about security considerations when using LXC

2013-09-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Describe some of the issues to be aware of when configuring LXC guests with security isolation as a goal. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/drvlxc.html.in | 93 + 1 file

Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-10 Thread Eric Blake
On 09/10/2013 02:29 AM, Liuji (Jeremy) wrote: Yes,it's an actual crash problem. I found the problem in the above problem scenario in my first mail. A problem scenario: 1) The XML of VM contain the below segment: numatune memory mode='preferred' placement='auto' nodeset='0'/

Re: [libvirt] [PATCH 1/4] build: avoid $(srcdir) in *_SOURCES

2013-09-10 Thread Eric Blake
On 09/10/2013 03:58 AM, Michal Privoznik wrote: Some things to remember that affect VPATH builds, and where an in-tree build is blissfully unaware of the issues: if a VPATH build fails to find a file that was used as a prereq of any other target, then the rule for that file will expand $@ to

[libvirt] [PATCH 0/2] Handle read only root in LXC

2013-09-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com A v2 of this patch https://www.redhat.com/archives/libvir-list/2013-September/msg00405.html Daniel P. Berrange (2): Move array of mounts out of lxcContainerMountBasicFS Ensure root filesystem is recursively mounted readonly

[libvirt] [PATCH 1/2] Move array of mounts out of lxcContainerMountBasicFS

2013-09-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move the array of basic mounts out of the lxcContainerMountBasicFS function, to a global variable. This is to allow it to be referenced by other methods wanting to know what the basic mount paths are. Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH 2/2] Ensure root filesystem is recursively mounted readonly

2013-09-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com If the guest is configured with filesystem type='mount' source dir='/'/ target dir='/'/ readonly/ /filesystem Then any submounts under / should also end up readonly, except for those setup as basic mounts. eg if the user has

[libvirt] [PATCH] qemu: Fix connectGetType() API

2013-09-10 Thread Michal Novotny
This patch fixes qemuConnectGetType() API function to return KVM if appropriate, i.e. when /dev/kvm exists as the KVM module is loaded. No further check is being done so it's merely showing the possibility that KVM virtualization is available on the host however we don't have any guest information

Re: [libvirt] link fow downloading libvirt-0.10.2-19.el6

2013-09-10 Thread arun abhinay
Hi All, I could finally fix this issue with the patch mentioned in comment 17 in https://bugzilla.redhat.com/show_bug.cgi?id=911609#c28 applied on libvirt-1.0.3 version and all my tests are fine. Thanks a lot for your support. Thanks Abhinay On Wed, Sep 4, 2013 at 2:45 PM, Eric Blake

Re: [libvirt] [libvirt-php] bug in libvirt_domain_change_vcpus()

2013-09-10 Thread Michal Novotny
On 09/10/2013 10:09 AM, Daniel P. Berrange wrote: On Mon, Sep 09, 2013 at 06:51:54PM +0200, Michal Novotny wrote: Hi Olivier, this is not really a bug as it's intended. The libvirt_domain_change_vcpus() is not the same as (yet unimplemented) virDomainSetVcpus() API so it's not bug. I realize

Re: [libvirt] [PATCH] qemu: Fix connectGetType() API

2013-09-10 Thread Daniel P. Berrange
On Tue, Sep 10, 2013 at 03:06:29PM +0200, Michal Novotny wrote: This patch fixes qemuConnectGetType() API function to return KVM if appropriate, i.e. when /dev/kvm exists as the KVM module is loaded. No further check is being done so it's merely showing the possibility that KVM virtualization

[libvirt] [PATCH] Fix cgroups when all are mounted on /sys/fs/cgroup

2013-09-10 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Some users in Ubuntu/Debian seem to have a setup where all the cgroup controllers are mounted on /sys/fs/cgroup rather than any /sys/fs/cgroup/controller name. In the loop which detects which controllers are present for a mount point we were modifying

Re: [libvirt] [PATCH] qemu: Fix connectGetType() API

2013-09-10 Thread Michal Novotny
On 09/10/2013 03:19 PM, Daniel P. Berrange wrote: On Tue, Sep 10, 2013 at 03:06:29PM +0200, Michal Novotny wrote: This patch fixes qemuConnectGetType() API function to return KVM if appropriate, i.e. when /dev/kvm exists as the KVM module is loaded. No further check is being done so it's

Re: [libvirt] [PATCH] DBus: introduce virDBusIsServiceEnabled

2013-09-10 Thread Daniel P. Berrange
On Tue, Sep 10, 2013 at 11:34:32AM +0800, Gao feng wrote: This patch introduces virDBusIsServiceEnabled, we can use this method to get if the service is supported. In one case, if org.freedesktop.machine1 is unavailable on host, we should skip creating machine through systemd.

Re: [libvirt] [PATCH] qemu: Fix connectGetType() API

2013-09-10 Thread Eric Blake
On 09/10/2013 07:37 AM, Michal Novotny wrote: If you want to know whether kvm virt is possible or not, then query the capabilities XML. Daniel Ok, if this is merely returning the driver name wouldn't it be better to rename it to virConnectGetDriverName() ? Unfortunately, we don't like

Re: [libvirt] [PATCH v2 2/5] cpu_models: implement the remote protocol

2013-09-10 Thread Daniel P. Berrange
On Sat, Sep 07, 2013 at 01:11:23AM +0200, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- daemon/remote.c | 47 +++ src/remote/remote_driver.c | 59

Re: [libvirt] [PATCH v2 4/5] cpu_models: add the support for the test protocol

2013-09-10 Thread Daniel P. Berrange
On Sat, Sep 07, 2013 at 01:11:25AM +0200, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/test/test_driver.c | 16 1 file changed, 16 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c225618..03d9c96

Re: [libvirt] [PATCH v2 1/5] cpu_models: add new public API

2013-09-10 Thread Daniel P. Berrange
On Sat, Sep 07, 2013 at 01:11:22AM +0200, Giuseppe Scrivano wrote: The new function virConnectGetCPUModelNames allows to retrieve the list of CPU models known by the hypervisor for a specific architecture. Signed-off-by: Giuseppe Scrivano gscri...@redhat.com ---

[libvirt] [v4 1/5] virsh: Add vshCmdCompleter and vshOptCompleter

2013-09-10 Thread Tomas Meszaros
completer and completer_flags added to the _vshCmdOptDef structure so it will be possible for completion generators to conveniently call option completer functions with desired flags. --- v4 * merged (*vshCmdCompleter) and (*vshOptCompleter) into (*vshCompleter) * deleted completer and

Re: [libvirt] [PATCH] qemu: endjob returns a bool

2013-09-10 Thread Eric Blake
On 09/09/2013 01:43 PM, Doug Goldstein wrote: On Mon, Sep 9, 2013 at 2:12 PM, Eric Blake ebl...@redhat.com wrote: Osier Yang pointed out that ever since commit 31cb030, the signature of qemuDomainObjEndJob was changed to return a bool. While comparison against 0 or 0 still gives the right

[libvirt] [v4 5/5] virsh: Add vshRebootShutdownModeCompleter

2013-09-10 Thread Tomas Meszaros
vshRebootShutdownModeCompleter returns available shutdown mode names. This can be used for --mode auto completion for commands such as reboot or shutdown. for example: virsh # reboot --mode TAB acpi agentinitctl signal virsh # reboot --mode iTAB virsh # reboot --mode initctl ---

[libvirt] [v4 4/5] virsh: Add vshSuspendTargetCompleter

2013-09-10 Thread Tomas Meszaros
vshSuspendTargetCompleter returns targets available for suspend. This completer can be used for the command option completion (for dompmsuspend, etc.). virsh # dompmsuspend --target TAB mem diskhybrid virsh # dompmsuspend --target hTAB virsh # dompmsuspend --target hybrid --- v2 *

Re: [libvirt] [PATCH v2 1/5] cpu_models: add new public API

2013-09-10 Thread Eric Blake
On 09/10/2013 08:38 AM, Daniel P. Berrange wrote: On Sat, Sep 07, 2013 at 01:11:22AM +0200, Giuseppe Scrivano wrote: The new function virConnectGetCPUModelNames allows to retrieve the list of CPU models known by the hypervisor for a specific architecture. Signed-off-by: Giuseppe Scrivano

[libvirt] [v4 0/5] virsh: More intelligent auto-completion

2013-09-10 Thread Tomas Meszaros
This series implements advanced auto-completion for virsh. Using custom option completers (examples in 3/5, 4/5 and 5/5), it is possible to further complete any option with defined completer function. Option completer function should return list of completed names for each desired option. Using

Re: [libvirt] [PATCH] Add some notes about security considerations when using LXC

2013-09-10 Thread Eric Blake
On 09/10/2013 04:43 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Describe some of the issues to be aware of when configuring LXC guests with security isolation as a goal. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- docs/drvlxc.html.in | 93

Re: [libvirt] [PATCH] Fix cgroups when all are mounted on /sys/fs/cgroup

2013-09-10 Thread Eric Blake
On 09/10/2013 07:35 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Some users in Ubuntu/Debian seem to have a setup where all the cgroup controllers are mounted on /sys/fs/cgroup rather than any /sys/fs/cgroup/controller name. In the loop which detects which

Re: [libvirt] [PATCH 0/2] fix configure to require yajl if qemu is new enough

2013-09-10 Thread Eric Blake
On 09/10/2013 11:43 AM, Jonathan Lebon wrote: I can confirm that configure now happily yells at me. Thanks, Thanks for testing. Jonathan - Original Message - Ping. On 09/05/2013 04:18 PM, Eric Blake wrote: After yet another debug session on IRC about failure to use qemu

Re: [libvirt] [PATCH 0/2] fix configure to require yajl if qemu is new enough

2013-09-10 Thread Jonathan Lebon
I can confirm that configure now happily yells at me. Thanks, Jonathan - Original Message - Ping. On 09/05/2013 04:18 PM, Eric Blake wrote: After yet another debug session on IRC about failure to use qemu because yajl-devel wasn't installed, I came up with these patches. The

Re: [libvirt] [PATCH] Update docs about user namespace for LXC

2013-09-10 Thread Eric Blake
On 09/10/2013 03:08 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Mention that user namespace can be enabled using the UID/GID mapping schema. Fix typo in link anchor for container args in domain XML docs. Signed-off-by: Daniel P. Berrange

[libvirt] Help needed in simulating libvirt

2013-09-10 Thread Arun Viswanath
Hi All, I'm need to simulate libvirt API's say to mock the libvirt API responses. (Actually I need to simulate qemu API's response). Because of my project needs I need to write this simulated libvirt server in Java. I believe the simulated libvirt can be written as java RPC which should capable

[libvirt] [PATCH 2/2] storage: btrfs subvolumes for directory pools

2013-09-10 Thread Oskari Saarenmaa
This commit adds support for btrfs subvolumes as directory volumes. The directory storage pool can be used to manage btrfs subvolumes on an existing btrfs filesystem. The driver can create new blank subvolumes and snapshots of existing subvolumes as well as delete existing subvolumes. The

Re: [libvirt] [libvirt-php] bug in libvirt_domain_change_vcpus()

2013-09-10 Thread Michal Novotny
On 09/10/2013 10:09 AM, Daniel P. Berrange wrote: On Mon, Sep 09, 2013 at 06:51:54PM +0200, Michal Novotny wrote: Hi Olivier, this is not really a bug as it's intended. The libvirt_domain_change_vcpus() is not the same as (yet unimplemented) virDomainSetVcpus() API so it's not bug. I realize

[libvirt] [v4 3/5] virsh: Add vshDomainCompleter

2013-09-10 Thread Tomas Meszaros
Function vshDomainCompler returns domains names which can be used by various virsh commands, for example: virsh # start --domain TAB fedora domain_foodomain_bar --- v2 * global variable __my_conn renamed to vshConn * @name is now const char * * label cleanup renamed to error v3 *

Re: [libvirt] [PATCH] build: require libnl-3 if netcf uses it

2013-09-10 Thread Eric Blake
ping; I'm debating about pushing this under the build-breaker rule On 09/04/2013 03:19 PM, Eric Blake wrote: Commits 9298bfb and f6c2951 both tried to make it possible to select the correct libnl (1 vs. 3) according to what netcf used, when both libraries are installed. This works to avoid

Re: [libvirt] [PATCH 0/2] fix configure to require yajl if qemu is new enough

2013-09-10 Thread Eric Blake
Ping. On 09/05/2013 04:18 PM, Eric Blake wrote: After yet another debug session on IRC about failure to use qemu because yajl-devel wasn't installed, I came up with these patches. The first is just preparation (no change to generated code); and with the second, I validated that uninstalling

[libvirt] [v4 2/5] virsh: Improve readline generators and readline completion

2013-09-10 Thread Tomas Meszaros
This patch is rather big and introduces several new functions, but I kept all new functions in the one patch because they are all connected together. I had to extend vshReadlineOptionsGenerator() a lot, so it is possible to fully complete options by calling appropriate opt-completer().

[libvirt] [PATCH 1/2] virFileFsType: get filesystem type of a given path

2013-09-10 Thread Oskari Saarenmaa
This can be used by storage pools to figure out which actions are available on various paths (for example subvolumes when running on btrfs.) Signed-off-by: Oskari Saarenmaa o...@ohmu.fi --- src/libvirt_private.syms | 1 + src/util/virfile.c | 47

[libvirt] [PATCHv2 RESEND] Add forwarders attribute to dns / element.

2013-09-10 Thread Diego Woitasen
Useful to set custom forwarders instead of using the contents of /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM domain names from domain 0, when domain option is used. Signed-off-by: Diego Woitasen diego.woita...@vhgroup.net --- docs/formatnetwork.html.in

Re: [libvirt] [Users] VNC/Spice console connection failure

2013-09-10 Thread Dan Kenigsberg
On Tue, Sep 10, 2013 at 05:31:23PM +, SULLIVAN, Chris (WGK) wrote: Hi Itamar, BZ created: https://bugzilla.redhat.com/show_bug.cgi?id=1006490 Thanks, Thanks, but we cannot simply require libvirt 1.1.0, as it does not ship with F19. We need get a fix backported to F19, so that we can

Re: [libvirt] [Users] VNC/Spice console connection failure

2013-09-10 Thread Eric Blake
On 09/10/2013 03:52 PM, Dan Kenigsberg wrote: On Tue, Sep 10, 2013 at 05:31:23PM +, SULLIVAN, Chris (WGK) wrote: Hi Itamar, BZ created: https://bugzilla.redhat.com/show_bug.cgi?id=1006490 Thanks, Thanks, but we cannot simply require libvirt 1.1.0, as it does not ship with F19. We

Re: [libvirt] [PATCH v2 1/5] cpu_models: add new public API

2013-09-10 Thread Eric Blake
On 09/06/2013 05:11 PM, Giuseppe Scrivano wrote: The new function virConnectGetCPUModelNames allows to retrieve the list of CPU models known by the hypervisor for a specific architecture. Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- include/libvirt/libvirt.h.in | 18

Re: [libvirt] [PATCH v2 3/5] cpu_models: add the support for qemu

2013-09-10 Thread Eric Blake
On 09/06/2013 05:11 PM, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- src/qemu/qemu_driver.c | 14 ++ 1 file changed, 14 insertions(+) ACK. Would any of the drivers besides qemu and test benefit from an implementation? For example, does this

Re: [libvirt] [PATCH v2 2/5] cpu_models: implement the remote protocol

2013-09-10 Thread Eric Blake
On 09/06/2013 05:11 PM, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- daemon/remote.c | 47 +++ src/remote/remote_driver.c | 59 src/remote/remote_protocol.x | 20

Re: [libvirt] [PATCH v2 5/5] cpu_models: add Python bindings

2013-09-10 Thread Eric Blake
On 09/06/2013 05:11 PM, Giuseppe Scrivano wrote: Signed-off-by: Giuseppe Scrivano gscri...@redhat.com --- python/generator.py | 2 +- python/libvirt-override-api.xml | 7 ++ python/libvirt-override.c | 56 +

Re: [libvirt] [PATCH] docs, comments: minor typo fixes

2013-09-10 Thread Eric Blake
On 09/10/2013 12:10 PM, Oskari Saarenmaa wrote: Signed-off-by: Oskari Saarenmaa o...@ohmu.fi --- 84 files changed, 97 insertions(+), 97 deletions(-) +++ b/docs/news.html.in @@ -13327,7 +13327,7 @@ and check the a href=http://libvirt.org/git/?p=libvirt.git;a=log;GIT log/a h30.1.5:

[libvirt] [PATCH 0/2] btrfs subvolume management

2013-09-10 Thread Oskari Saarenmaa
Moved btrfs subvolume management to storage_backend_fs.c instead of implementing it as a separate pool as suggested by Daniel P. Berrange in https://www.redhat.com/archives/libvir-list/2013-September/msg00316.html Oskari Saarenmaa (2): virFileFsType: get filesystem type of a given path

[libvirt] [PATCH] docs, comments: minor typo fixes

2013-09-10 Thread Oskari Saarenmaa
Signed-off-by: Oskari Saarenmaa o...@ohmu.fi --- 84 files changed, 97 insertions(+), 97 deletions(-) diff --git a/ChangeLog-old b/ChangeLog-old index b5d44d5..e07b11c 100644 --- a/ChangeLog-old +++ b/ChangeLog-old @@ -5504,7 +5504,7 @@ Tue Nov 11 15:51:42 GMT 2008 Daniel P. Berrange

Re: [libvirt] [libvirt-users] Help needed in simulating libvirt

2013-09-10 Thread Eric Blake
On 09/10/2013 12:03 PM, Arun Viswanath wrote: Hi All, I'm need to simulate libvirt API's say to mock the libvirt API responses. (Actually I need to simulate qemu API's response). Because of my project needs I need to write this simulated libvirt server in Java. I believe the simulated

Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

2013-09-10 Thread Liuji (Jeremy)
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Tuesday, September 10, 2013 8:28 PM To: Liuji (Jeremy) Cc: Daniel P. Berrange; libvir-list@redhat.com; Jinbo (Justin); Luohao (brian); Haofeng Subject: Re: [libvirt] [PATCH] virBitmapFree: Change the function to

Re: [libvirt] [PATCH] Add some notes about security considerations when using LXC

2013-09-10 Thread Chen Hanxiao
-Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Tuesday, September 10, 2013 6:44 PM To: libvir-list@redhat.com Cc: Chen Hanxiao; Daniel P. Berrange Subject: [PATCH] Add some notes about security considerations when using LXC From: Daniel P. Berrange

Re: [libvirt] [PATCH] Add some notes about security considerations when using LXC

2013-09-10 Thread Gao feng
On 09/11/2013 10:33 AM, Chen Hanxiao wrote: -Original Message- From: Daniel P. Berrange [mailto:berra...@redhat.com] Sent: Tuesday, September 10, 2013 6:44 PM To: libvir-list@redhat.com Cc: Chen Hanxiao; Daniel P. Berrange Subject: [PATCH] Add some notes about security

[libvirt] [PATCH v2] DBus: introduce virDBusIsServiceEnabled

2013-09-10 Thread Gao feng
This patch introduces virDBusIsServiceEnabled, we can use this method to get if the service is supported. In one case, if org.freedesktop.machine1 is unavailable on host, we should skip creating machine through systemd. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- src/util/virdbus.c|

Re: [libvirt] [PATCH] Update docs about user namespace for LXC

2013-09-10 Thread Gao feng
On 09/10/2013 05:08 PM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Mention that user namespace can be enabled using the UID/GID mapping schema. Fix typo in link anchor for container args in domain XML docs. Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH] tools: add missing 'interface' type and update man page

2013-09-10 Thread Alex Jia
Signed-off-by: Alex Jia a...@redhat.com --- tools/virt-xml-validate.in | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in index 6bfa68f..8be9595 100644 --- a/tools/virt-xml-validate.in +++