Re: [libvirt] [PATCH] Clarify documentation on possible return values in case of errors

2014-01-10 Thread Claudio Bley
At Fri, 10 Jan 2014 07:42:52 +0100, Guido Günther wrote: On Thu, Jan 09, 2014 at 08:07:25AM +0100, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- src/libvirt.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) ACK. Thanks, pushed.

[libvirt] traffic control on hypervisor

2014-01-10 Thread yue
hi,all if we can control the bandwidth of vm at hypervisor level? i know linux tc command can control traffic, but it is at ISO level 3, vm;s network is on bridge at level 2. how libvirt implement traffic control over vm? thanks-- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 1/8] storage: fs: Fix comment for virStorageBackendFileSystemDelete

2014-01-10 Thread Peter Krempa
On 01/09/14 22:06, Eric Blake wrote: On 01/06/2014 09:44 AM, Peter Krempa wrote: The comment was talking about creating the pool while the function is deleting it. Fix the mismatch. --- src/storage/storage_backend_fs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) ACK, safe

Re: [libvirt] [PATCH 8/8] storage: Improve error message when a storage backend is missing

2014-01-10 Thread Peter Krempa
On 01/09/14 23:46, Eric Blake wrote: On 01/06/2014 09:44 AM, Peter Krempa wrote: Include the name of the storage backend in the error message instead of just the number. --- src/storage/storage_backend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ACK; this one is okay for

Re: [libvirt] [PATCH 3/8] storage: lvm: Avoid forward decl of virStorageBackendLogicalDeleteVol

2014-01-10 Thread Peter Krempa
On 01/09/14 23:32, Eric Blake wrote: On 01/06/2014 09:44 AM, Peter Krempa wrote: Change code ordering to avoid the need for a forward declaration. --- src/storage/storage_backend_logical.c | 67 --- 1 file changed, 31 insertions(+), 36 deletions(-) ACK;

Re: [libvirt] [Users] libvirt migration port configuration and virPortAllocator

2014-01-10 Thread Gianluca Cecchi
On Fri, Jan 10, 2014 at 9:53 AM, Sven Kieske wrote: Hi, any chance this also gets backported to EL 6 ? I would open a BZ, but just if it's technically possible. The version difference is quite huge. The bug for RH EL 6 has been already opened as a clone some months ago:

Re: [libvirt] traffic control on hypervisor

2014-01-10 Thread Michal Privoznik
On 10.01.2014 09:37, yue wrote: hi,all if we can control the bandwidth of vm at hypervisor level? i know linux tc command can control traffic, but it is at ISO level 3, vm;s network is on bridge at level 2. how libvirt implement traffic control over vm? thanks I'm not sure the

Re: [libvirt] /var/lib/libvirt/qemu permissions are wrong

2014-01-10 Thread Marcelo Cerri
Thanks Richard, I agree with you. Do you have any suggestion how this should be implemented? My first impression is that the virSecurityManager* internal API should be extended to support that. The current code in qemu_process.c already uses virSecurityManagerSetDaemonSocketLabel() and

Re: [libvirt] /var/lib/libvirt/qemu permissions are wrong

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 08:11:32AM -0200, Marcelo Cerri wrote: Thanks Richard, I agree with you. Do you have any suggestion how this should be implemented? My first impression is that the virSecurityManager* internal API should be extended to support that. The current code in

[libvirt] [PATCH 1/2] storage: Break long lines and clean up spaces in storage backend header

2014-01-10 Thread Peter Krempa
--- src/storage/storage_backend.h | 56 --- 1 file changed, 37 insertions(+), 19 deletions(-) diff --git a/src/storage/storage_backend.h b/src/storage/storage_backend.h index 9e07dd8..378bc4d 100644 --- a/src/storage/storage_backend.h +++

[libvirt] [PATCH 2/2] storage: FS: Tweak some comments and fix typo

2014-01-10 Thread Peter Krempa
--- src/storage/storage_backend_fs.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 6ebdd46..dad7b53 100644 --- a/src/storage/storage_backend_fs.c +++

[libvirt] [PATCH 0/2] Trivial fixes for 1.2.1

2014-01-10 Thread Peter Krempa
Peter Krempa (2): storage: Break long lines and clean up spaces in storage backend header storage: FS: Tweak some comments and fix typo src/storage/storage_backend.h| 56 ++-- src/storage/storage_backend_fs.c | 21 --- 2 files changed,

Re: [libvirt] [PATCH 2/2] spice: expose the QEMU disable file transfer option

2014-01-10 Thread Christophe Fergeau
Hey, On Thu, Jan 09, 2014 at 07:21:25AM -0500, Francesco Romani wrote: the code to disable copypaste uses VIR_ERR_INTERNAL_ERROR when it's not able to parse the enum value, but the compression code uses VIR_ERR_CONFIG_UNSUPPORTED, and the mouse code uses VIR_ERR_XML_ERROR :( The rest of

Re: [libvirt] [PATCH] Clarify documentation on possible return values in case of errors

2014-01-10 Thread Eric Blake
On 01/09/2014 12:07 AM, Claudio Bley wrote: Signed-off-by: Claudio Bley cb...@av-test.de --- src/libvirt.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index ffd4f8e..73972f2 100644 --- a/src/libvirt.c +++

Re: [libvirt] [PATCH 2/2] spice: expose the QEMU disable file transfer option

2014-01-10 Thread Francesco Romani
Hi, On Thu, Jan 09, 2014 at 07:21:25AM -0500, Francesco Romani wrote: the code to disable copypaste uses VIR_ERR_INTERNAL_ERROR when it's not able to parse the enum value, but the compression code uses VIR_ERR_CONFIG_UNSUPPORTED, and the mouse code uses VIR_ERR_XML_ERROR :( The rest

[libvirt] Compile time error in event-test.c

2014-01-10 Thread Avanti Ajay
Hi... I am trying to compile the event-test.c code of the libvirt package. I am getting this error : I know it is a loader problem. Do I need to install any binaries? administrator@administrator-desktop:~/Desktop/libvirt/examples/domain-events/events-c$ gcc event-test.c -o event -lvirt

Re: [libvirt] [Users] libvirt migration port configuration and virPortAllocator

2014-01-10 Thread Sven Kieske
Hi, any chance this also gets backported to EL 6 ? I would open a BZ, but just if it's technically possible. The version difference is quite huge. -- Mit freundlichen Grüßen / Regards Sven Kieske Systemadministrator Mittwald CM Service GmbH Co. KG Königsberger Straße 6 32339 Espelkamp T:

Re: [libvirt] [PATCH] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-10 Thread Daniel P. Berrange
On Mon, Dec 30, 2013 at 07:23:00PM +0200, Pavel Fux wrote: Hi, I am talking about *Bug 987088*https://bugzilla.redhat.com/show_bug.cgi?id=987088, I have added a patch and a description of the fix, this is a copy of my comment on the bug: the default code behavior is wait for 3 seconds

Re: [libvirt] New feature discussion: Grouping multiple libvirt's in a pool

2014-01-10 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 10:29:23AM +0200, Ahmed Ossama wrote: Greetings All, I would like to say Hi to everyone on the list since this is my first message. I have couple of servers running CentOS and Debian with kvm and libvirt on top. Lately I've been thinking of coordinating them

Re: [libvirt] [PATCH] test driver: Add authentication to test driver.

2014-01-10 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 06:39:40PM +, Richard W.M. Jones wrote: There is no easy way to test authentication against libvirt. This commit modifies the test driver to allow simple username/password authentication. You modify the test XML by adding: node ... auth user

Re: [libvirt] Regression testing libvirt authentication

2014-01-10 Thread Eric Blake
On 01/10/2014 07:12 AM, Daniel P. Berrange wrote: On Wed, Jan 08, 2014 at 04:32:12PM +, Richard W.M. Jones wrote: I'm trying to find a way to regression-test a program which uses libvirt authentication (virConnectAuth, virConnectAuthPtr). Ideally the test:/// driver would be able to fake

Re: [libvirt] Regression testing libvirt authentication

2014-01-10 Thread Daniel P. Berrange
On Wed, Jan 08, 2014 at 04:32:12PM +, Richard W.M. Jones wrote: I'm trying to find a way to regression-test a program which uses libvirt authentication (virConnectAuth, virConnectAuthPtr). Ideally the test:/// driver would be able to fake authentication demands, but it doesn't seem to

Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-10 Thread Daniel P. Berrange
On Thu, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote: From: Pavel Fux pa...@stratoscale.com Adding an option to change monitor socket opening timeout the current default is 3 seconds and in some cases it's not enough Signed-off-by: Pavel Fux pa...@stratoscale.com

Re: [libvirt] Compile time error in event-test.c

2014-01-10 Thread Michal Privoznik
On 10.01.2014 11:15, Avanti Ajay wrote: Hi... I am trying to compile the event-test.c code of the libvirt package. I am getting this error : I know it is a loader problem. Do I need to install any binaries?

Re: [libvirt] [PATCH] test driver: Add authentication to test driver.

2014-01-10 Thread Richard W.M. Jones
On Fri, Jan 10, 2014 at 02:15:00PM +, Daniel P. Berrange wrote: On Wed, Jan 08, 2014 at 06:39:40PM +, Richard W.M. Jones wrote: There is no easy way to test authentication against libvirt. This commit modifies the test driver to allow simple username/password authentication.

Re: [libvirt] [PATCH 1/2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-10 Thread Martin Kletzander
On Fri, Jan 10, 2014 at 02:18:37PM +, Daniel P. Berrange wrote: On Thu, Jan 09, 2014 at 09:22:05AM +0100, Martin Kletzander wrote: From: Pavel Fux pa...@stratoscale.com Adding an option to change monitor socket opening timeout the current default is 3 seconds and in some cases it's

Re: [libvirt] [PATCH 0/2] Try to get rid of most monitor timeout errors

2014-01-10 Thread Michal Privoznik
On 09.01.2014 09:22, Martin Kletzander wrote: This is basically v3 of the patch Pavel Fux sent [1] with the addition of changing the default as discussed in the same thread [2]. Martin [1] https://www.redhat.com/archives/libvir-list/2014-January/msg00060.html [2]

Re: [libvirt] [PATCH 05/10] snapshot: Add support for specifying snapshot disk backing type

2014-01-10 Thread Peter Krempa
On 01/10/14 00:30, Eric Blake wrote: On 01/09/2014 09:15 AM, Peter Krempa wrote: Add support for specifying various types when doing snapshots. This will later allow to do snapshots on network backed volumes. Disks of type 'volume' are not supported by snapshots (yet). ---

Re: [libvirt] [PATCH 07/10] storage: Implement ephemeral storage APIs for local disk volumes

2014-01-10 Thread Peter Krempa
On 01/10/14 00:39, Eric Blake wrote: On 01/09/2014 09:15 AM, Peter Krempa wrote: This patch implements the APIs for getting temporary storage pools for the local filesystem driver using storage_backend_fs. --- src/check-aclrules.pl| 3 + src/storage/storage_driver.c | 253

Re: [libvirt] [v9 2/6] add unit test for hostdev common library

2014-01-10 Thread Jim Fehlig
Chunyan Liu wrote: Add unit test for hostdev common library. Current tests are based on virpcimock. Signed-off-by: Chunyan Liu cy...@suse.com --- tests/Makefile.am |5 + tests/virhostdevtest.c | 481 tests/virpcimock.c |

[libvirt] [PATCH] conf: Always use VIR_ERR_XML_ERROR on enumFromString() failures

2014-01-10 Thread Christophe Fergeau
Currently, during XML parsing, when a call to a FromString() function to get an enum value fails, the error which is reported is either VIR_ERR_CONFIG_UNSUPPORTED, VIR_ERR_INTERNAL_ERROR or VIR_ERR_XML_ERROR. This commit makes such conversion failures consistently return VIR_ERR_XML_ERROR ---

Re: [libvirt] [PATCH] conf: Always use VIR_ERR_XML_ERROR on enumFromString() failures

2014-01-10 Thread Daniel P. Berrange
On Fri, Jan 10, 2014 at 06:13:21PM +0100, Christophe Fergeau wrote: Currently, during XML parsing, when a call to a FromString() function to get an enum value fails, the error which is reported is either VIR_ERR_CONFIG_UNSUPPORTED, VIR_ERR_INTERNAL_ERROR or VIR_ERR_XML_ERROR. This commit

[libvirt] [PATCH 0/2] v3: spice: expose the disable file transfer option

2014-01-10 Thread Francesco Romani
Addressed Christophe's comments. Added filetransfer check in another test. I think now the setting should survive a dumpxml roundtrip, any suggestion for further improvement is of course welcome. Francesco Romani (2): spice: detect if qemu can disable file transfer spice: expose the QEMU

[libvirt] [PATCH 1/2] spice: detect if qemu can disable file transfer

2014-01-10 Thread Francesco Romani
spice-server offers an API to disable file transfer messages on the agent channel between the client and the guest. This is supported in qemu through the disable-agent-file-xfer option. This detects if QEMU supports this option, and add a capability if does. --- src/qemu/qemu_capabilities.c

[libvirt] [PATCH 2/2] spice: expose the QEMU disable file transfer option

2014-01-10 Thread Francesco Romani
spice-server offers an API to disable file transfer messages on the agent channel between the client and the guest. This is supported in qemu through the disable-agent-file-xfer option. This patch exposes this option to libvirt. Adds a new element 'filetransfer', with one property,

Re: [libvirt] [PATCH] conf: Always use VIR_ERR_XML_ERROR on enumFromString() failures

2014-01-10 Thread Christophe Fergeau
On Fri, Jan 10, 2014 at 05:15:50PM +, Daniel P. Berrange wrote: On Fri, Jan 10, 2014 at 06:13:21PM +0100, Christophe Fergeau wrote: Currently, during XML parsing, when a call to a FromString() function to get an enum value fails, the error which is reported is either

[libvirt] [PATCH] schema: fix idmap validation

2014-01-10 Thread Eric Blake
When idmap was added to LXC, we forgot to cover it in the testsuite. The schema was missing an element layer, and as a result, virt-xml-validate was failing on valid dumpxml output. Reported by Eduard - Gabriel Munteanu on IRC. * docs/schemas/domaincommon.rng (idmap): Include idmap element, and

[libvirt] [PATCH] Exercise the ABI stability check code in test suite

2014-01-10 Thread Daniel P. Berrange
Any test suite which involves a virDomainDefPtr should call virDomainDefCheckABIStability with itself just as a basic sanity check that the identity-comparison always succeeds. This would have caught the recent NULL pointer access crash. Make sure we cope with def-name being NULL since the VMWare

Re: [libvirt] [PATCH] schema: fix idmap validation

2014-01-10 Thread Daniel P. Berrange
On Fri, Jan 10, 2014 at 10:42:35AM -0700, Eric Blake wrote: When idmap was added to LXC, we forgot to cover it in the testsuite. The schema was missing an element layer, and as a result, virt-xml-validate was failing on valid dumpxml output. Reported by Eduard - Gabriel Munteanu on IRC. *

Re: [libvirt] [PATCH] schema: fix idmap validation

2014-01-10 Thread Eric Blake
On 01/10/2014 10:48 AM, Daniel P. Berrange wrote: On Fri, Jan 10, 2014 at 10:42:35AM -0700, Eric Blake wrote: When idmap was added to LXC, we forgot to cover it in the testsuite. The schema was missing an element layer, and as a result, virt-xml-validate was failing on valid dumpxml output.

Re: [libvirt] [PATCH] Exercise the ABI stability check code in test suite

2014-01-10 Thread Eric Blake
On 01/10/2014 10:41 AM, Daniel P. Berrange wrote: Any test suite which involves a virDomainDefPtr should call virDomainDefCheckABIStability with itself just as a basic sanity check that the identity-comparison always succeeds. This would have caught the recent NULL pointer access crash.

[libvirt] [PATCH] Don't crash if a connection closes early

2014-01-10 Thread Jiri Denemark
https://bugzilla.redhat.com/show_bug.cgi?id=1047577 When a client closes its connection to libvirtd early during virConnectOpen, more specifically just after making REMOTE_PROC_CONNECT_SUPPORTS_FEATURE call to check if VIR_DRV_FEATURE_PROGRAM_KEEPALIVE is supported without even waiting for the

Re: [libvirt] [PATCH] Don't crash if a connection closes early

2014-01-10 Thread Eric Blake
On 01/10/2014 12:19 PM, Jiri Denemark wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1047577 When a client closes its connection to libvirtd early during virConnectOpen, more specifically just after making REMOTE_PROC_CONNECT_SUPPORTS_FEATURE call to check if

[libvirt] [PATCH] build: fix build on mingw with winpthreads

2014-01-10 Thread Eric Blake
On my Fedora 20 box with mingw cross-compiler, the build failed with: ../../src/rpc/virnetclient.c: In function 'virNetClientSetTLSSession': ../../src/rpc/virnetclient.c:745:14: error: unused variable 'oldmask' [-Werror=unused-variable] sigset_t oldmask, blockedsigs; ^ I

[libvirt] [PATCHv2] build: fix build on mingw with winpthreads

2014-01-10 Thread Eric Blake
On my Fedora 20 box with mingw cross-compiler, the build failed with: ../../src/rpc/virnetclient.c: In function 'virNetClientSetTLSSession': ../../src/rpc/virnetclient.c:745:14: error: unused variable 'oldmask' [-Werror=unused-variable] sigset_t oldmask, blockedsigs; ^ I

Re: [libvirt] traffic control on hypervisor

2014-01-10 Thread yue
hi, Michal Privoznik i am a bit confusion about type of vm's interface . interface type='network' and interface type='bridge' do the Qos in libvirt can apply to both case? thanks At 2014-01-10 17:45:23,Michal Privoznik mpriv...@redhat.com wrote: On 10.01.2014 09:37, yue wrote:

[libvirt] [PATCH python] virStream.sendAll() fix raising an undeclared var

2014-01-10 Thread Doug Goldstein
The exception is raised from the variable 'e', which was undeclared in this context. Used code that is compatible with old and new Python versions. --- libvirt-override-virStream.py | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-override-virStream.py b/libvirt-override-virStream.py