Hello,
I want to use ivshmemory device which is supported by qemu, but libvirt does
not support it.
So I use qemu:commandline to make ivshmemory device in qemu command
pass-through.
But then hot-plug a virtio-net device failed.
The reason is that a qemu:commandline pci device's slot number
Amos Kong ak...@redhat.com writes:
Hi QEMU/Libvirt list,
When I worked on query-command-line-options, I first used some marcos [1] to
generate two config option tables. This will cover all the options,
but it returns a string, it's difficult for libvirt to parse and use
it.
Finally I got
From: Joel SIMOES joel.sim...@laposte.net
Correct ret return 0 on success
---
src/storage/storage_backend_sheepdog.c | 92 ++
1 file changed, 82 insertions(+), 10 deletions(-)
diff --git a/src/storage/storage_backend_sheepdog.c
On Tue, Jan 28, 2014 at 09:17:46 +, Wangyufei (James) wrote:
Hello,
I want to use ivshmemory device which is supported by qemu, but libvirt does
not support it.
So I use qemu:commandline to make ivshmemory device in qemu command
pass-through.
But then hot-plug a virtio-net device
On Mon, Jan 27, 2014 at 01:03:23PM -0700, Eric Blake wrote:
On 01/23/2014 05:37 AM, Daniel P. Berrange wrote:
There are a number of pthreads impls available on Win32
these days, in particular the mingw64 project has a good
impl. Delete the native windows thread implementation and
rely on
Il 28/01/2014 10:36, Markus Armbruster ha scritto:
I think the data you can usefully collect with this approach is
approximately the data getopt_long()[*] gets: list of named command line
options, and whether they take an argument.
You can use this data to fill in options not covered by
On Mon, Jan 27, 2014 at 03:23:29PM -0500, Stefan Berger wrote:
On 01/27/2014 12:18 PM, Daniel P. Berrange wrote:
Since we introduced fine grained locking into the QEMU driver so
that VM start can run in parallel, we appear to have caused a
race with the nwfilter code. In particular since we no
On Mon, Jan 27, 2014 at 06:39:36PM -0700, Jim Fehlig wrote:
[Adding libvirt list...]
Ian Jackson wrote:
Jim Fehlig writes (Re: [Xen-devel] [PATCH 00/12] libxl: fork: SIGCHLD
flexibility):
BTW, I only see the crash when the save/restore script is running. I
stopped the other
On Tue, Jan 28, 2014 at 09:17:46AM +, Wangyufei (James) wrote:
Hello,
I want to use ivshmemory device which is supported by qemu, but libvirt
does not support it.
So I use qemu:commandline to make ivshmemory device in qemu command
pass-through.
But then hot-plug a virtio-net device
On 01/27/14 18:49, Eric Blake wrote:
On 01/16/2014 06:14 AM, Peter Krempa wrote:
The temporary pool code will need to initialize some fields for the
temporary gluster volumes. This is done by the createVol function of
the storage backend. This patch implements only the metadata setting.
On Mon, Jan 27, 2014 at 06:46:31PM +0800, Fam Zheng wrote:
On Mon, 01/27 10:38, Paolo Bonzini wrote:
Il 27/01/2014 09:17, Amos Kong ha scritto:
CC Libvirt-list
Original discussion:
http://marc.info/?l=qemu-develm=139048842504757w=2
[Qemu-devel] [PATCH v4 0/5] QMP full
Il 28/01/2014 11:45, Amos Kong ha scritto:
My question is why is this generate-and-parse necessary?
It's request of Libvirt, actually we can directly return the raw
schema to Libvirt without extending/parsing, then Libvirt parse
by itself.
Can we achieve it with less duplication?
Let's see
On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote:
On 01/27/2014 12:18 PM, Daniel P. Berrange wrote:
The nwfilter conf update mutex previously serialized
updates to the internal data structures for firewall
rules, and updates to the firewall itself. Since the
Hm, wasn't aware
On 01/28/2014 04:53 AM, Jiri Denemark wrote:
Jiri Denemark (4):
tests: Better support for VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES
cpu: Fix VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES
cpu: Try to use source CPU model in virConnectBaselineCPU
tests: Add more tests for
Il 22/01/2014 13:40, Laszlo Ersek ha scritto:
(b)
VenHw(C1E791A2-64CF-4B68-BDF1-1C31DABBDC84,131C)/
HD(1,GPT,2F972E52-F7E0-4504-9FE7-F60E66352266,0x800,0x32000)/
\Image
This is the file called Image, in the root directory of the filesystem
on the GPT hard disk partition
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/01/2014 10:36, Markus Armbruster ha scritto:
I think the data you can usefully collect with this approach is
approximately the data getopt_long()[*] gets: list of named command line
options, and whether they take an argument.
You can use this
Il 28/01/2014 12:55, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/01/2014 10:36, Markus Armbruster ha scritto:
I think the data you can usefully collect with this approach is
approximately the data getopt_long()[*] gets: list of named command line
options, and
On Thu, Jan 23, 2014 at 05:25:18PM +0100, Laszlo Ersek wrote:
On 01/23/14 15:58, Daniel P. Berrange wrote:
I disagree that users setting their persistent boot variables form
inside the guest fall in the same category. That feature is an
unalienable part of UEFI.
The goal we have is that
On 01/28/14 12:54, Paolo Bonzini wrote:
Il 22/01/2014 13:40, Laszlo Ersek ha scritto:
(b)
VenHw(C1E791A2-64CF-4B68-BDF1-1C31DABBDC84,131C)/
HD(1,GPT,2F972E52-F7E0-4504-9FE7-F60E66352266,0x800,0x32000)/
\Image
This is the file called Image, in the root directory of the
On Mon, Jan 27, 2014 at 03:45:13PM -0700, Eric Blake wrote:
On 01/27/2014 10:18 AM, Daniel P. Berrange wrote:
Add virRWLock backed up by a POSIX rwlock primitive
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
+int virRWLockInit(virRWLockPtr m)
+{
+if
On Mon, Jan 27, 2014 at 03:47:19PM -0700, Eric Blake wrote:
On 01/27/2014 10:18 AM, Daniel P. Berrange wrote:
There are a number of pthreads impls available on Win32
these days, in particular the mingw64 project has a good
impl. Delete the native windows thread implementation and
rely on
Il 28/01/2014 13:16, Laszlo Ersek ha scritto:
On 01/28/14 12:54, Paolo Bonzini wrote:
Il 22/01/2014 13:40, Laszlo Ersek ha scritto:
(b)
VenHw(C1E791A2-64CF-4B68-BDF1-1C31DABBDC84,131C)/
HD(1,GPT,2F972E52-F7E0-4504-9FE7-F60E66352266,0x800,0x32000)/
\Image
This is the file
On 01/28/2014 06:15 AM, Daniel P. Berrange wrote:
On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote:
On 01/27/2014 12:18 PM, Daniel P. Berrange wrote:
The nwfilter conf update mutex previously serialized
updates to the internal data structures for firewall
rules, and updates to the
On 01/28/14 13:10, Daniel P. Berrange wrote:
On Thu, Jan 23, 2014 at 05:25:18PM +0100, Laszlo Ersek wrote:
On 01/23/14 15:58, Daniel P. Berrange wrote:
I disagree that users setting their persistent boot variables form
inside the guest fall in the same category. That feature is an
On Tue, Jan 28, 2014 at 01:33:22PM +0100, Laszlo Ersek wrote:
On 01/28/14 13:10, Daniel P. Berrange wrote:
On Thu, Jan 23, 2014 at 05:25:18PM +0100, Laszlo Ersek wrote:
On 01/23/14 15:58, Daniel P. Berrange wrote:
I disagree that users setting their persistent boot variables form
inside
On Tue, Jan 28, 2014 at 07:31:04AM -0500, Stefan Berger wrote:
On 01/28/2014 06:15 AM, Daniel P. Berrange wrote:
On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote:
On 01/27/2014 12:18 PM, Daniel P. Berrange wrote:
The nwfilter conf update mutex previously serialized
updates to the
On 01/28/14 13:25, Paolo Bonzini wrote:
Il 28/01/2014 13:16, Laszlo Ersek ha scritto:
On 01/28/14 12:54, Paolo Bonzini wrote:
Il 22/01/2014 13:40, Laszlo Ersek ha scritto:
(b)
VenHw(C1E791A2-64CF-4B68-BDF1-1C31DABBDC84,131C)/
On Tue, Jan 28, 2014 at 02:50:51PM +0800, Qiao Nuohan wrote:
Hello,
Do you have some comments on this?
Hi, I can't find this series in ML, neither in archives, can you
resend it, please?
It'd be enough to send it to the list(s), I think there is no need to
Cc all people more-or-less
On 01/28/14 13:36, Daniel P. Berrange wrote:
On Tue, Jan 28, 2014 at 01:33:22PM +0100, Laszlo Ersek wrote:
On 01/28/14 13:10, Daniel P. Berrange wrote:
On Thu, Jan 23, 2014 at 05:25:18PM +0100, Laszlo Ersek wrote:
On 01/23/14 15:58, Daniel P. Berrange wrote:
I disagree that users setting
On Tue, Jan 28, 2014 at 01:47:13PM +0100, Laszlo Ersek wrote:
On 01/28/14 13:36, Daniel P. Berrange wrote:
On Tue, Jan 28, 2014 at 01:33:22PM +0100, Laszlo Ersek wrote:
On 01/28/14 13:10, Daniel P. Berrange wrote:
On Thu, Jan 23, 2014 at 05:25:18PM +0100, Laszlo Ersek wrote:
On 01/23/14
On Thu, Jan 23, 2014 at 03:06:16PM -0500, Adam Walters wrote:
This patchset implements a tiered driver loading system. I split the
hypervisor
drivers out into their own tier, which is loaded after the other drivers. This
has the net effect of ensuring that things like secrets, networks, etc.,
On 01/27/14 23:40, Eric Blake wrote:
On 01/16/2014 06:14 AM, Peter Krempa wrote:
Add support for gluster backed images as sources for snapshots in the
qemu driver. This will also simplify adding further network backed
volumes as sources for snapshot in case qemu will support them.
---
While reviewing danpb's win32 patch for the mainloop integration code,
I found 2 more issues in the existing code (one leak, one bug). These
patches fix this (first patch is just some cleanup).
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
gvir_event_handle_add() creates a GIOChannel in order to watch the fd it
was given for changes.
gvir_event_handle_remove() is freeing all the resources allocated by
gvir_event_handle_add() except for this GIOChannel. This commit adds
the needed g_io_channel_unref() call to
It's possible to create a handle to watch for file events which do not
watch for any file event. Such a handle can be enabled later with
gvir_event_handle_update() by setting some conditions to watch for.
When a handle is disabled after it has been created,
gvir_event_handle_update() makes sure
Trying to remove a disabled timer or handle will cause
gvir_{event,timer}_handle_remove() to return an error
rather than removing it.
---
libvirt-glib/libvirt-glib-event.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libvirt-glib/libvirt-glib-event.c
---
.gitignore | 8
1 file changed, 8 insertions(+)
diff --git a/.gitignore b/.gitignore
index 712778f..3eabf64 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@ build-aux/depcomp
build-aux/install-sh
build-aux/ltmain.sh
build-aux/missing
+build-aux/test-driver
gnulib
This patch series adds support for GTester tests to libvirt-glib, and
starts implementing some unit tests for libvirt-gconfig, and for a very
specific part of the event handling code.
This series
https://www.redhat.com/archives/libvir-list/2014-January/msg00939.html
is needed for the gconfig
It's currently only testing removal of disabled timer/watches
---
tests/Makefile.am | 6 +-
tests/test-events.c | 172
2 files changed, 176 insertions(+), 2 deletions(-)
create mode 100644 tests/test-events.c
diff --git
ACK
On Mon, Jan 27, 2014 at 10:53:09AM +, Daniel P. Berrange wrote:
Libvirt uses gnulib for making winsock look like POSIX
sockets. This means that in the libvirt event handle
callbacks the application will be given a file descriptor
rather than a winsock HANDLE object. The
[Adding Luiz...]
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/01/2014 12:55, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/01/2014 10:36, Markus Armbruster ha scritto:
I think the data you can usefully collect with this approach is
approximately the data
Il 28/01/2014 14:16, Markus Armbruster ha scritto:
That would mean we can't ever add an option that doesn't take an
argument again.
We can add it under an existing QemuOpts group or invent a new one
(like we did for -rt or -msg).
Do you mean -rtc?
I meant -rt, but -rtc applies just as
On 01/28/14 00:23, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1049391
virConnectBaselineCPU test results are now stored in different files
depending on VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
tests/cputest.c
On 01/28/2014 04:46 PM, Kashyap Chamarthy wrote:
On 01/28/2014 04:53 AM, Jiri Denemark wrote:
Jiri Denemark (4):
tests: Better support for VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES
cpu: Fix VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES
cpu: Try to use source CPU model in virConnectBaselineCPU
On 01/28/2014 04:14 AM, Paolo Bonzini wrote:
Let's see the feedback of Eric.
Eric's feedback is certainly useful, but I think we need to look at it
from the QEMU perspective more than the libvirt perspective.
Passing the raw schema and letting libvirt parse it is a Really Bad idea
from
On 01/19/2014 06:55 PM, Roman Bogorodskiy wrote:
A set of fields for CPU stats could vary on different platforms,
for example, FreeBSD doesn't report 'iowait'.
Make virsh print out only the fields that were actually filled.
---
tools/virsh-host.c | 118
On 01/28/2014 05:45 AM, Martin Kletzander wrote:
On Tue, Jan 28, 2014 at 02:50:51PM +0800, Qiao Nuohan wrote:
Hello,
Do you have some comments on this?
Hi, I can't find this series in ML, neither in archives, can you
resend it, please?
It'd be enough to send it to the list(s), I think
On 01/28/14 00:23, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1049391
VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES flag for virConnectBaselineCPU
did not work if the resulting guest CPU would disable some features
present in its base model. This patch makes sure we won't
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/01/2014 14:16, Markus Armbruster ha scritto:
That would mean we can't ever add an option that doesn't take an
argument again.
We can add it under an existing QemuOpts group or invent a new one
(like we did for -rt or -msg).
Do you mean -rtc?
On 01/28/2014 08:50 AM, Ján Tomko wrote:
On 01/27/2014 05:16 PM, Eric Blake wrote:
On 01/22/2014 06:37 AM, Ján Tomko wrote:
Split out the repetitive code.
---
src/nodeinfo.c | 77
+++---
1 file changed, 30 insertions(+), 47 deletions(-)
On 01/28/14 00:23, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1049391
When all source CPU XMLs contain just a single CPU model (with a
possibly varying set of additional feature elements),
virConnectBaselineCPU will try to use this CPU model in the computed
guest CPU.
On 01/28/14 00:23, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1049391
The new tests would fail in various ways without the two previous
commits.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
tests/cputest.c | 5 +++
On Mon, Jan 27, 2014 at 03:47:19PM -0700, Eric Blake wrote:
On 01/27/2014 10:18 AM, Daniel P. Berrange wrote:
There are a number of pthreads impls available on Win32
these days, in particular the mingw64 project has a good
impl. Delete the native windows thread implementation and
rely on
Il 28/01/2014 15:28, Markus Armbruster ha scritto:
I'd rather not promise all options will take an argument, or desugar
into some option that takes an argument, forever and ever. But I don't
see the need for such a promise. If we decide we want such options, we
just have to do the necessary
On Tue, Jan 28, 2014 at 08:12:35AM -0700, Eric Blake wrote:
On 01/28/2014 08:10 AM, Daniel P. Berrange wrote:
On Mon, Jan 27, 2014 at 03:47:19PM -0700, Eric Blake wrote:
On 01/27/2014 10:18 AM, Daniel P. Berrange wrote:
There are a number of pthreads impls available on Win32
these days,
On 01/28/2014 08:10 AM, Daniel P. Berrange wrote:
On Mon, Jan 27, 2014 at 03:47:19PM -0700, Eric Blake wrote:
On 01/27/2014 10:18 AM, Daniel P. Berrange wrote:
There are a number of pthreads impls available on Win32
these days, in particular the mingw64 project has a good
impl. Delete the
Round two.
Michal Privoznik (3):
virfile: Introduce virFileAppendStr
virCommand: Introduce virCommandSetDryRun
virnetdevbandwidthtest: Introduce testVirNetDevBandwidthSet
src/libvirt_private.syms | 2 +
src/util/vircommand.c | 58 -
So far we only have an API that truncates the file prior to
writing it. However, experience show need for new API that just
appends a string to file.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/libvirt_private.syms | 1 +
src/util/virfile.c | 57
On Tue, Jan 28, 2014 at 8:05 AM, Daniel P. Berrange berra...@redhat.comwrote:
On Thu, Jan 23, 2014 at 03:06:16PM -0500, Adam Walters wrote:
This patchset implements a tiered driver loading system. I split the
hypervisor
drivers out into their own tier, which is loaded after the other
The test tries to set some QoS limits and check if the commands
that are actually executed are the expected ones.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/virnetdevbandwidthtest.c | 98 ++
1 file changed, 98 insertions(+)
diff --git
There are some units within libvirt that utilize virCommand API to run
some commands and deserve own unit testing. These units are, however,
not desired to be rewritten to dig virCommand API usage out. As a great
example virNetDevBandwidth could be used. The problem with the bandwidth
unit is: it
With libvirt-glib update, I've noticed a deprecation warning:
libvirt-designer-domain.c: In function 'gvir_designer_domain_add_disk_full':
libvirt-designer-domain.c:1610:9: error:
'gvir_config_domain_disk_set_driver_type' is deprecated (declared at
On 26.01.2014 19:24, Cole Robinson wrote:
I've just pushed a new tool to virt-manager.git called virt-xml. virt-xml uses
virt-install's command line options to allow building and editing domain XML.
Best way to describe what it can do is with a bunch of examples:
See a list of all suboptions
On Mon, Jan 27, 2014 at 11:28:31AM +, Daniel P. Berrange wrote:
On Fri, Jan 24, 2014 at 05:17:02PM +0100, Martin Kletzander wrote:
On Fri, Jan 24, 2014 at 12:56:43PM +, Daniel P. Berrange wrote:
On Thu, Jan 23, 2014 at 07:47:54PM +0200, Pavel Fux wrote:
there are 8 servers with 8
On Tue, Jan 28, 2014 at 05:08:14PM +0100, Michal Privoznik wrote:
There are some units within libvirt that utilize virCommand API to run
some commands and deserve own unit testing. These units are, however,
not desired to be rewritten to dig virCommand API usage out. As a great
example
On Thu, Jan 23, 2014 at 03:14:19PM -0500, Adam Walters wrote:
This patchset adds a driver named 'config' which provides access to
configuration data, such as secret and storage definitions, without
requiring a connection to a hypervisor. This complements my previous
patchset, which resolves
Implementation obtains CPU usage information using
kern.cp_time and kern.cp_times sysctl(8)s and reports
CPU utilization.
---
include/libvirt/libvirt.h.in | 8
src/nodeinfo.c | 104 +++
tools/virsh-host.c | 11 -
3 files
A set of fields for CPU stats could vary on different platforms,
for example, FreeBSD doesn't report 'iowait'.
Make virsh print out only the fields that were actually filled.
---
tools/virsh-host.c | 119 -
1 file changed, 72 insertions(+), 47
Ján Tomko wrote:
Maybe creating an enum with VIR_ENUM_DECL/VIR_ENUM_IMPL would make the code
easier to read? (You could use the FromString/ToString functions and an array
of bools to tell missing/zero fields apart instead of NULL pointers)
I'll try to play around with that approach.
On 28.01.2014 15:04, Jamie Strandboge wrote:
On 01/26/2014 03:47 PM, Felix Geyer wrote:
Make virt-aa-helper create rules to allow VMs access to filesystem
mounts from the host.
Note that virt-aa-helper access to various parts of the filesystem is
generally
ok. However, can you be more
yet another version - this time with virBuffer approach.
Michal Privoznik (2):
virCommand: Introduce virCommandSetDryRun
virnetdevbandwidthtest: Introduce testVirNetDevBandwidthSet
src/libvirt_private.syms | 1 +
src/util/vircommand.c | 57 +--
The test tries to set some QoS limits and check if the commands
that are actually executed are the expected ones.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
tests/virnetdevbandwidthtest.c | 76 ++
1 file changed, 76 insertions(+)
diff --git
There are some units within libvirt that utilize virCommand API to run
some commands and deserve own unit testing. These units are, however,
not desired to be rewritten to dig virCommand API usage out. As a great
example virNetDevBandwidth could be used. The problem with the bandwidth
unit is: it
Hi,
a user of Debian's libvirt backport to wheezy using Xen reported libvirt
1.2.1 failing for him like:
info : libvirt version: 1.2.1
error : virIdentityGetSystem:173 : Unable to lookup SELinux process context:
Invalid argument
error : xenHypervisorDoV2Sys:1011 : Unable to issue hypervisor
Hey,
On Tue, Jan 28, 2014 at 05:49:29PM +0100, Michal Privoznik wrote:
With libvirt-glib update, I've noticed a deprecation warning:
libvirt-designer-domain.c: In function 'gvir_designer_domain_add_disk_full':
libvirt-designer-domain.c:1610:9: error:
On 01/28/2014 09:51 AM, Daniel P. Berrange wrote:
Do we really need to write it out to a file, or would it be simpler to
just pass in a virBufferPtr instead, so we just write to RAM. This
avoids any tmpfile naming complexity in code using this.
Ah, a virBufferPtr would be even nicer - less
On Tue, Jan 28, 2014 at 15:32:37 +0100, Peter Krempa wrote:
On 01/28/14 00:23, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1049391
The new tests would fail in various ways without the two previous
commits.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
On 01/28/2014 12:12 PM, Felix Geyer wrote:
On 28.01.2014 15:04, Jamie Strandboge wrote:
On 01/26/2014 03:47 PM, Felix Geyer wrote:
Make virt-aa-helper create rules to allow VMs access to filesystem
mounts from the host.
Note that virt-aa-helper access to various parts of the filesystem is
Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
need to check the ACL rules to filter which events to send. But
it overlooked one thing: the event dispatch queue is running in
the main loop thread, and therefore does not normally have a
current virIdentityPtr. But filter checks
On 01/28/2014 07:38 AM, Daniel P. Berrange wrote:
On Tue, Jan 28, 2014 at 07:31:04AM -0500, Stefan Berger wrote:
On 01/28/2014 06:15 AM, Daniel P. Berrange wrote:
On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote:
On 01/27/2014 12:18 PM, Daniel P. Berrange wrote:
The nwfilter
https://bugzilla.redhat.com/show_bug.cgi?id=1045124
When loading modules, libvirt does not honor the modprobe blacklist.
By adding a -b to the modprobe command libvirt will fail to load a
module if it's on the blacklist
Check if the failure to load a driver was due to it being on the blacklist
Commit f9f56340 for CVE-2014-0028 almost had the right idea - we
need to check the ACL rules to filter which events to send. But
it overlooked one thing: the event dispatch queue is running in
the main loop thread, and therefore does not normally have a
current virIdentityPtr. But filter checks
It's almost simpler to revert the botched CVE-2014-0028 patch
and show just the final result with filtering in the right location.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Created by squashing the original CVE fix together with the
updates to filter in remote.c; this representation avoids
Guido Günther wrote:
Hi,
a user of Debian's libvirt backport to wheezy using Xen reported libvirt
1.2.1 failing for him like:
info : libvirt version: 1.2.1
error : virIdentityGetSystem:173 : Unable to lookup SELinux process context:
Invalid argument
error : xenHypervisorDoV2Sys:1011 :
--memory-only option is introduced without compression supported. Therefore,
this is a freature regression of virsh dump. This patchset is used to add
compression support in libvirt side and please refer the following address to
see the qemu side, the lastest version of qemu side v7(ready for
--memory-only option is introduced without compression supported. Therefore,
this is a freature regression of virsh dump. This patch is used to add
--compress and [--compression-format] string to the command
virsh dump --memory-only and send dump-guest-memory command to qemu with dump
format
This patch is used to add dump_memory_format to qemu.conf and make the
specified format as the default dump format of 'virsh dump --memory-only'.
But when --compress is specified with dump command, the format configured
by dump_memory_format will be overrided. dump_memory_format can one of elf,
On 01/28/2014 06:40 PM, Jim Fehlig wrote:
Commit df36af58 broke parsing of http response from xend. The prior
use of atoi() would happily parse e.g. a string containing 200 OK\r\n,
whereas virStrToLong_i() will fail when called with a NULL end_ptr.
Change the calls to virStrToLong_i() to
Eric Blake wrote:
On 01/28/2014 06:40 PM, Jim Fehlig wrote:
Commit df36af58 broke parsing of http response from xend. The prior
use of atoi() would happily parse e.g. a string containing 200 OK\r\n,
whereas virStrToLong_i() will fail when called with a NULL end_ptr.
Change the calls to
Hi,
On Sun, Jan 26, 2014 at 10:47:34PM +0100, Felix Geyer wrote:
[..snip..] `
+if (recursive) {
+// allow reading (but not creating) the dir
+virBufferAsprintf(buf, \%s/\ r,\n, tmp);
Just a minor nit. Libvirt prefers /* */ style comments (see HACKING).
Cheers,
-- Guido
90 matches
Mail list logo
