Re: [libvirt] [PATCH v5 0/3] support dumping guest memory in compressed format

Hello, Do you have any comments? On 03/06/2014 05:35 PM, Qiao, Nuohan/乔 诺涵 wrote: dumping guest's memroy is introduced without compression supported, and this is a freature regression of 'virsh dump --memory-only'. This patchset is used to add support in libvirt side to make qemu dump

Re: [libvirt] [PATCH] libvirt-tck: Update hook syntax for libvirt 0.9.0+

On 07/03/14 00:27, Mike Latimer wrote: Starting with libvirt 0.9.0+, hook scripts can be called from several new locations. These locations must also be reflected in the expected logs of the hook tests. The final test in 052-domain-hook.t intentionally produces a failed start, which should show

Re: [libvirt] [PATCH 1/9] conf: eliminate hardcoded indent from domain xml

On 03/06/2014 07:15 PM, Eric Blake wrote: On 03/06/2014 08:24 AM, Laine Stump wrote: if (def-label) { virBufferAddLit(buf, \n); -virBufferEscapeString(buf, label%s/label\n, +virBufferAdjustIndent(buf, 2); +virBufferEscapeString(buf, label%s/label\n,

Re: [libvirt] [PATCH 4/9] conf: eliminate outmoded/odd indent method from interface xml

On 03/06/2014 08:39 PM, Eric Blake wrote: On 03/06/2014 08:24 AM, Laine Stump wrote: These format functions needed the ability to be indented by an arbitrary amount, but were written before the introduction of virBufferAdjustIndent(). They instead used the much more clunky method of adding a

Re: [libvirt] [PATCH] libvirt-tck: Ignore SIGPIPE in 051-daemon-hook.t

On 07/03/14 01:11, Mike Latimer wrote: This test completes successfully, but results in a return code of 141 due to a broken pipe when restarting libvirtd. This patch just masks the SIGPIPE and undefines $tck to avoid the 141 return code. If there is a way to reestablish the tck connection after

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

On Fri, Mar 7, 2014 at 1:22 AM, Christian Benvenuti (benve) be...@cisco.com wrote: -Original Message- From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On Behalf Of Stefan Hajnoczi Sent: Friday, February 14, 2014 7:58 AM To: Cedric Bosdonnat Cc: Jan Kiszka;

[libvirt] [PATCH 03/13] src/nwfilter: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/nwfilter/nwfilter_gentech_driver.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 8c5cd57..ef3d4bd 100644 ---

[libvirt] [PATCH 00/13] Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

The aim of this patch is to substitute the following pattern: VIR_REALLOC(array, cnt + 1); array[cnt++] = new_elem; with shorter: VIR_APPEND_ELEMENT(array, cnt, new_elem); In addition, remove writable-only memmove() when removing elements, with VIR_DELETE_ELEMENT(). Completeness

[libvirt] [PATCH 05/13] src/parallels: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/parallels/parallels_driver.c | 15 --- src/parallels/parallels_storage.c | 32 2 files changed, 12 insertions(+), 35 deletions(-) diff --git a/src/parallels/parallels_driver.c

[libvirt] [PATCH 01/13] conf: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

This fixes a possible double free. In virNetworkAssignDef() if virBitmapNew() fails, then virNetworkObjFree(network) is called. However, with network-def pointing to actual @def. So if caller frees @def again, ... Moreover, this fixes one possible memory leak too. In virInterfaceAssignDef() if

[libvirt] [PATCH 07/13] src/qemu: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/qemu/qemu_command.c | 90 ++-- src/qemu/qemu_conf.c | 8 +--- src/qemu/qemu_conf.h | 2 +- src/qemu/qemu_driver.c | 10 ++--- src/qemu/qemu_monitor_json.c | 2 +-

[libvirt] [PATCH 06/13] src/phyp: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/phyp/phyp_driver.c | 16 +++- src/phyp/phyp_driver.h | 2 +- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 9adb6b0..e819256 100644 ---

[libvirt] [PATCH 09/13] src/storage: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/storage/storage_backend_disk.c| 13 - src/storage/storage_backend_fs.c | 5 + src/storage/storage_backend_iscsi.c | 5 + src/storage/storage_backend_logical.c | 8 +++-

[libvirt] [PATCH 02/13] src/lxc/: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/lxc/lxc_container.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index f2440ff..e034051 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c

[libvirt] [PATCH 10/13] src/test: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/test/test_driver.c | 41 + 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 6806ffd..986f215 100644 --- a/src/test/test_driver.c

[libvirt] [PATCH 08/13] src/rpc: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/rpc/virnetclient.c | 11 +-- src/rpc/virnetserver.c | 11 ++- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 9deec9e..327768b 100644 ---

[libvirt] [PATCH 04/13] src/openvz: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/openvz/openvz_conf.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 0ea8243..11f048b 100644 --- a/src/openvz/openvz_conf.c +++

[libvirt] [PATCH 11/13] src/util: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/util/virjson.c | 12 +++- src/util/virlockspace.c | 12 ++-- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 7044e11..02b5f3f 100644 ---

[libvirt] [PATCH 12/13] src/xen: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/xen/xen_driver.c | 19 ++- src/xen/xen_driver.h | 2 +- src/xen/xen_inotify.c | 13 ++--- src/xen/xm_internal.c | 18 +++--- src/xen/xs_internal.c | 19 ++- src/xen/xs_internal.h |

Re: [libvirt] [bug-report] libvirtd can't be connected by using the master branch with lots of VMs

On Fri, Mar 07, 2014 at 01:06:10PM +0800, Wangpan wrote: bug address: https://bugzilla.redhat.com/show_bug.cgi?id=1066801 I can reproduce it at master/v1.2.1-maint/v1.1.4-maint/v1.1.3.4 release branches everytime, but cann't reproduce it at v1.2.1，so I believe this bug is imported by the

[libvirt] [PATCH 13/13] src/xenxs: Utilize more of VIR_(APPEND|INSERT|DELETE)_ELEMENT

Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/xenxs/xen_sxpr.c | 43 +-- src/xenxs/xen_xm.c | 27 --- 2 files changed, 25 insertions(+), 45 deletions(-) diff --git a/src/xenxs/xen_sxpr.c b/src/xenxs/xen_sxpr.c index

Re: [libvirt] [PATCH 1/9] conf: eliminate hardcoded indent from all xml

On 03/06/2014 10:32 PM, Eric Blake wrote: On 03/06/2014 08:24 AM, Laine Stump wrote: [0/9 in the subject line] Many of the domain xml format functions (including all of the device format functions) had hard-coded spaces, which made for incorrect indentation when those functions were called

Re: [libvirt] [PATCH] libvirt-tck: prefer kvm if multiple domain types exist

On 07/03/14 01:39, Mike Latimer wrote: When matching capabilities of a guest, if multiple domain types exist (for example, 'qemu' and 'kvm') the order in which they are returned can change. To avoid unpredictable test results, this patch prefers kvm if that domain type exists. If not, the

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

Eric Blake ebl...@redhat.com writes: On 03/05/2014 07:36 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from

Re: [libvirt] [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

Amos Kong ak...@redhat.com writes: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_groups[]. Current query-command-line-options only checks options from vm_config_groups[], so some options will be

Re: [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

Hi Stefan, Christian, On Fri, 2014-03-07 at 10:16 +0100, Stefan Hajnoczi wrote: I am not applying as a student and I am not offering myself as a mentor (I do not qualify as a mentor), I Just wanted to point out a possible interesting (and challenging) project. I am afraid it would be

[libvirt] [PATCH 1/4] virsh: Sort options alphabetically

Man page, help output and also parsing is sorted in order to find options smoothly. Signed-off-by: Martin Kletzander mklet...@redhat.com --- tools/virsh.c | 64 - tools/virsh.pod | 38 +- 2 files changed,

[libvirt] [PATCH 2/4] virsh: Add keepalive in new vshConnect function

Introducing keepalive similarly to Guannan around 2 years ago. Since we want to introduce keepalive for every connection, it makes sense to wrap the connecting function into new virsh one that can deal keepalive as well. Function vshConnect() is now used for connecting and keepalive added in

[libvirt] [PATCH 0/4] Add keepalive support in virsh

*** BLURB *** Martin Kletzander (4): virsh: Sort options alphabetically virsh: Add keepalive in new vshConnect function virsh: Prohibit virConnectOpen* functions in virsh [DO_NOT_APPLY_UPSTREAM] virsh: add connection monitoring into vshWatchJob cfg.mk | 8 ++-

[libvirt] [PATCH 3/4] virsh: Prohibit virConnectOpen* functions in virsh

Addition of vshConnect() makes virConnectOpen() functions obsolete in virsh. Thus all virsh-*.[ch] files should be left only with vshConnect() in the case of need. Signed-off-by: Martin Kletzander mklet...@redhat.com --- cfg.mk | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

[libvirt] [PATCH 4/4] [DO_NOT_APPLY_UPSTREAM] virsh: add connection monitoring into vshWatchJob

Similarly to Guannan's patches in 2012, this one does add the connection monitoring into vshWatchJob function. *But Beware*, while testing this I discovered it adds no new functionality. Probably since we're catching disconnects by a callback, there is no way to get to the code introduced.

[libvirt] [PATCH v14 03/49] update qemuPrepareHostUSBDevices parameters to keep consistency

Update parameters from vm-def to specific name, hostdevs, nhostdevs to keep consistentcy with PreparePCIDevices and PrepareSCSIDevices. And, at the same time, make it reusable in later patch. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 11 ++- 1 file changed,

[libvirt] [PATCH v14 01/49] virscsi: fix memory leak

Signed-off-by: Chunyan Liu cy...@suse.com --- src/util/virscsi.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/util/virscsi.c b/src/util/virscsi.c index 69eae24..627b3f8 100644 --- a/src/util/virscsi.c +++ b/src/util/virscsi.c @@ -296,12 +296,17 @@

[libvirt] [PATCH v14 10/49] qemu_hostdev: move netconfig file location to virhostdev stateDir

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 72d84c8..a95fbb6 100644 --- a/src/qemu/qemu_hostdev.c +++

[libvirt] [PATCH v14 00/49] write separate module for hostdev passthrough

These patches implements a separate module for hostdev passthrough so that it could be shared by different drivers and can maintain a global state of a host device. Patch 1: fix memory leak in virscsi.c Patch 2: improve virHostdevManager to use virOject wrapper and keep reference Patches 3~7:

[libvirt] [PATCH v14 14/49] pass driver name as a parameter to virHostdevPrepareHostdevPCIDevices

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index ec5e0d5..7f8f93c 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -659,6

[libvirt] [PATCH v14 05/49] qemu: remove functions used internally only from qemu_hostdev.h

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 12 ++-- src/qemu/qemu_hostdev.h | 13 - 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index c4dc9e9..0814263 100644 ---

[libvirt] [PATCH v14 02/49] virhostdev: use virObject to virHostdevManager to keep reference

Use virObject to virHostdevManager, so that each driver using virHostdevManager can keep a reference to it, and through counting refs to make virHostdevManager get freed. Signed-off-by: Chunyan Liu cy...@suse.com --- src/util/virhostdev.c | 54 ++-

[libvirt] [PATCH v14 09/49] qemu_hostdev: move ColdBoot as a flag

For extracting hostdev codes from qemu_hostdev.c to common library, change qemu specific COLD_BOOT handling to be a flag, and pass it to hostdev functions. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 6 +++--- src/qemu/qemu_hostdev.h | 4 ++-- src/qemu/qemu_process.c

[libvirt] [PATCH v14 07/49] lxc: use general virhostdev lists instead of its own

Signed-off-by: Chunyan Liu cy...@suse.com --- src/lxc/lxc_conf.h| 5 ++--- src/lxc/lxc_driver.c | 12 +++- src/lxc/lxc_hostdev.c | 32 ++-- 3 files changed, 27 insertions(+), 22 deletions(-) diff --git a/src/lxc/lxc_conf.h b/src/lxc/lxc_conf.h index

[libvirt] [PATCH v14 06/49] qemu: use general virhostdev lists instead of its own

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_conf.h| 9 +-- src/qemu/qemu_driver.c | 59 --- src/qemu/qemu_hostdev.c | 151 ++-- 3 files changed, 108 insertions(+), 111 deletions(-) diff --git

[libvirt] [PATCH v14 13/49] rename qemuGet*PciHostDeviceList to virHostdevGet*PciHostDeviceList

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index d733fef..ec5e0d5 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 15/49] extract general code from qemuDomainReAttachHostdevDevices

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 7f8f93c..e578519 100644 --- a/src/qemu/qemu_hostdev.c +++

[libvirt] [PATCH v14 04/49] qemu: reuse hostdev interfaces to avoid duplicate

Same logic of preparing/reattaching hostdevs could be used in attach/detach hotplug places, so reuse hostdev interfaces to avoid duplicate, also for later extracting general code to common library. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 4 ++--

[libvirt] [PATCH v14 19/49] extract general code from qemuUpdateActivePciHostdevs

Extract general code from qemuUpdateActivePciHostdevs to virHostdevUpdateActivePciHostdevs. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 11/49] extract general code from qemuPrepareHostdevPCIDevices

Extract general code from qemuPrepareHostdevPCIDevices to virHostdevPrepareHostdevPCIDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 44 +--- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git

[libvirt] [PATCH v14 08/49] qemu_hostdev: move cfg-relaxedACS as a flag

For extracting hostdev codes from qemu_hostdev.c to common library, change qemu specific cfg-relaxedACS handling to be a flag, and pass it to hostdev functions. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 11 +++ src/qemu/qemu_hostdev.h | 10 --

[libvirt] [PATCH v14 16/49] pass driver name as a parameter to virHostdevReAttachPCIDevices

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index e578519..5fa6eb4 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -1288,6

[libvirt] [PATCH v14 12/49] rename qemu*NetConfigRestore/Replace to virHostdevNetConfigRestore/Replace

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 5dc68a6..d733fef 100644 ---

[libvirt] [PATCH v14 17/49] rename qemuReAttachPciDevice to virHostdevReAttachPciDevice

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 5fa6eb4..2dfe252 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 22/49] pass driver_name as parameter of virHostdevUpdate*Hostdevs functions

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 24ebb60..ee3a18d 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 21/49] extract general code from qemuUpdateActiveScsiHostdevs

Extract general code from qemuUpdateActiveScsiHostdevs to virHostdevUpdateActiveScsiHostdevs Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 24/49] extract general code from qemuPrepareHostUSBDevices

Extract general code from qemuPrepareHostUSBDevices to virHostdevPrepareHostUSBDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 20/49] extract general code from qemuUpdateActiveUsbHostdevs

Extract general code from qemuUpdateActiveUsbHostdevs to virHostdevUpdateActiveUsbHostdevs. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 32/49] pass driver name as paramter to virHostdevReAttachUsbHostdevs

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 3d6396b..af1fe87 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -318,6

[libvirt] [PATCH v14 18/49] move virHostdevPrepare(ReAttach)PCIDevices to virhostdev.c

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 3 +- src/qemu/qemu_hostdev.c | 647 -- src/qemu/qemu_hostdev.h | 5 - src/qemu/qemu_process.c | 1 + src/util/virhostdev.c| 648

[libvirt] [PATCH v14 26/49] pass driver name to virHostdevPrepareUSBDevices

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index b72e9f9..0eb78ac 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -235,6

[libvirt] [PATCH v14 25/49] rename qemu*USBDevices to virHostdev*USBDevices

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 25a34e8..b72e9f9 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@

[libvirt] [PATCH v14 34/49] extract general code from qemuDomainReAttachHostScsiDevices

Extract general code from qemuDomainReAttachHostScsiDevices to virHostdevDomainReAttachHostScsiDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git

[libvirt] [PATCH v14 23/49] move virHostdevUpdate* functions to virhostdev.c

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 3 + src/qemu/qemu_hostdev.c | 151 --- src/util/virhostdev.c| 151 +++ src/util/virhostdev.h| 12 4 files changed, 166

[libvirt] [PATCH v14 36/49] move virHostdevReAttachHostScsiDevices to virhostdev.c

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 62 src/util/virhostdev.c| 62 src/util/virhostdev.h| 6 + 4 files changed, 69

[libvirt] [PATCH v14 35/49] pass driver name as parameter to virHostdevReAttachScciHostdevs

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 5e46a3d..b4ab1bd 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -330,6

[libvirt] [PATCH v14 38/49] extract general code of NodeDeviceReAttach

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_driver.c | 61 +- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b980725..3abcf5a 100644 --- a/src/qemu/qemu_driver.c

[libvirt] [PATCH v14 28/49] extract general code from qemuPrepareHostSCSIDevices

Extract general code from qemuPrepareHostSCSIDevices to virHostdevPrepareHostSCSIDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 63 + 1 file changed, 37 insertions(+), 26 deletions(-) diff --git

[libvirt] [PATCH v14 27/49] move virHostdevPrepareHostUSBDevices to virhostdev.c

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 217 --- src/util/virhostdev.c| 216 ++ src/util/virhostdev.h| 7 ++ 4 files changed, 224

[libvirt] [PATCH v14 39/49] extract general code of NodeDeviceReset

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_driver.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3abcf5a..6b6a170 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH v14 40/49] move virHostdevNodeDevice* to virhostdev.c

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 3 ++ src/qemu/qemu_driver.c | 81 src/util/virhostdev.c| 81 src/util/virhostdev.h| 8 + 4 files changed, 92

[libvirt] [PATCH v14 29/49] pass driver name as parameter to virHostdevPrepareSCSIDevices

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c index 9ad32e0..41ee32f 100644 --- a/src/qemu/qemu_hostdev.c +++ b/src/qemu/qemu_hostdev.c @@ -247,6

[libvirt] [PATCH v14 45/49] add parameter checks to common interfaces

Check NULL parameter inputs Signed-off-by: Chunyan Liu cy...@suse.com --- src/util/virhostdev.c | 57 +++ 1 file changed, 57 insertions(+) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 577de48..5f61bfc 100644 ---

[libvirt] [PATCH v14 31/49] extract general code from qemuDomainReAttachHostUsbDevices

Extract general code from qemuDomainReAttachHostUsbDevices to virHostdevDomainReAttachHostUsbDevices. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hostdev.c

[libvirt] [PATCH v14 48/49] add hostdev pci backend type for xen

Add VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN. For legacy xen, it will use pciback as stub driver. Signed-off-by: Chunyan Liu cy...@suse.com --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 3 ++- src/conf/domain_conf.h| 1 + src/libxl/libxl_domain.c | 9

[libvirt] [PATCH v14 33/49] move virHostdevReAttachUsbHostdevs to virhostdev.c

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 66 src/util/virhostdev.c| 66 src/util/virhostdev.h| 6 + 4 files changed, 73

[libvirt] [PATCH v14 41/49] improve parameter name to let it more meaningful

Signed-off-by: Chunyan Liu cy...@suse.com --- src/util/virhostdev.c | 44 +++- src/util/virhostdev.h | 12 ++-- 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 4302385..2c8bdf9

[libvirt] [PATCH v14 49/49] add pci passthrough to libxl driver

Add pci passthrough to libxl driver, support attach-device, detach-device and start a vm with pci hostdev specified. Signed-off-by: Chunyan Liu cy...@suse.com --- src/libxl/libxl_conf.c | 63 +++ src/libxl/libxl_conf.h | 7 +- src/libxl/libxl_driver.c | 454

[libvirt] [PATCH v14 47/49] change lxc_hostdev.c to use virhostdev common library APIs

Signed-off-by: Chunyan Liu cy...@suse.com --- src/lxc/lxc_hostdev.c | 305 ++ 1 file changed, 10 insertions(+), 295 deletions(-) diff --git a/src/lxc/lxc_hostdev.c b/src/lxc/lxc_hostdev.c index 635f2e5..07480dc 100644 --- a/src/lxc/lxc_hostdev.c

[libvirt] [PATCH v14 46/49] add unit test for new virhostdev common library

Add unit test for hostdev common library. Current tests are based on virpcimock. Signed-off-by: Chunyan Liu cy...@suse.com --- .gitignore | 1 + tests/Makefile.am | 5 + tests/virhostdevtest.c | 507 + 3 files changed, 513

[libvirt] [PATCH v14 30/49] move virHostdevPrepareHostSCSIDevices to virhostdev.c

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 1 + src/qemu/qemu_hostdev.c | 111 --- src/util/virhostdev.c| 111 +++ src/util/virhostdev.h| 6 +++ 4 files changed, 118

Re: [libvirt] Release of libvirt-1.2.2

Jason Helfman wrote: On Thu, Mar 6, 2014 at 5:22 AM, Eric Blake ebl...@redhat.com wrote: On 03/06/2014 12:02 AM, Jason Helfman wrote: On Sun, Mar 2, 2014 at 7:26 AM, Daniel Veillard veill...@redhat.com wrote: As planned I have tagged libvirt-1.2.2 in git and it seem the git

[libvirt] [PATCH v14 37/49] extract general code of NodeDeviceDetach

Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_driver.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3d25d14..b980725 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH v14 42/49] rename some function names to keep consistency

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 8 src/qemu/qemu_hostdev.c | 16 +++ src/util/virhostdev.c| 52 src/util/virhostdev.h| 40 ++--- 4 files

[libvirt] [PATCH v14 44/49] add 3 wrapper functions for prepare/reattach/update domain hostdevs

Signed-off-by: Chunyan Liu cy...@suse.com --- src/libvirt_private.syms | 4 ++ src/util/virhostdev.c| 103 +++ src/util/virhostdev.h| 20 + 3 files changed, 127 insertions(+) diff --git a/src/libvirt_private.syms

Re: [libvirt] [PATCH] qemu: don't munge user input during block commit

On 07.03.2014 00:47, Eric Blake wrote: While investigating https://bugzilla.redhat.com/show_bug.cgi?id=1061827 I noticed that we pass user input unscathed for block-pull, but always pass a canonical absolute name through for block-commit. [Note that we probably _ought_ to validate that the

Re: [libvirt] [PATCH v14 00/49] write separate module for hostdev passthrough

The whole patch series could be get from here: https://github.com/chunyanliu/libvirt/commits/hostdev_passthrough -Chunyan On 3/7/2014 at 06:52 PM, in message 1394189596-22994-1-git-send-email-cy...@suse.com, Chunyan Liu cy...@suse.com wrote: These patches implements a separate module for

[libvirt] [PATCH v14 43/49] improve virHostdevUpdate* parameters to make it more widely used

Changes parameter from vm def to specific hostdevs info and name info, so that it could be used more widely, e.g, could be used without full vm def info. Signed-off-by: Chunyan Liu cy...@suse.com --- src/qemu/qemu_hostdev.c | 9 ++--- src/util/virhostdev.c | 34

[libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

There is a forever growing list of test cases. It is just not worth listing each one individually when a wildcard can do the job. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- .gitignore | 73 +- 1 file changed, 1

Re: [libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

On 07.03.2014 12:59, Daniel P. Berrange wrote: There is a forever growing list of test cases. It is just not worth listing each one individually when a wildcard can do the job. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- .gitignore | 73

Re: [libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

On Fri, Mar 07, 2014 at 01:59:31PM +0100, Michal Privoznik wrote: On 07.03.2014 12:59, Daniel P. Berrange wrote: There is a forever growing list of test cases. It is just not worth listing each one individually when a wildcard can do the job. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Wildcard ignore tests/*test instead of listing every one

On 03/07/2014 06:18 AM, Martin Kletzander wrote: On Fri, Mar 07, 2014 at 01:59:31PM +0100, Michal Privoznik wrote: On 07.03.2014 12:59, Daniel P. Berrange wrote: There is a forever growing list of test cases. It is just not worth listing each one individually when a wildcard can do the job.

[libvirt] [PATCH] Change file names in comments to match the files they are in

Some of these are leftovers from renaming the files, others are just typos. Also introduce an ugly awk script to enforce this. --- cfg.mk | 25 + daemon/libvirtd-config.c| 2 +- daemon/libvirtd-config.h| 2

[libvirt] Seeking for advice on 'virsh console' problems debugging

Hi, I've been trying to understand why 'virsh console' doesn't work on FreeBSD for some time and now I feel like I got stuck. Background of the problem. Some time ago I started implementing console support for the bhyve driver. I initially implemented it using nmdm(4) device:

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

On Fri, Mar 07, 2014 at 05:49:34PM +0400, Roman Bogorodskiy wrote: Hi, I've been trying to understand why 'virsh console' doesn't work on FreeBSD for some time and now I feel like I got stuck. Background of the problem. Some time ago I started implementing console support for the bhyve

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

Daniel P. Berrange wrote: All those mangled messages are being printed out by libvirt client code, and it is totally expected that log messages libvirt prints are mangled in this way for the console. What's more important is what data coming from the guest looks like. All those spaces

[libvirt] [PATCH] qemu: Forbid sgio support for SCSI generic host device

The kernel didn't support the unprivileged SGIO for SCSI generic device finally, and since it's unknow whether the way to support unprivileged SGIO for SCSI generic device will be similar as for SCSI block device or not, even it's simliar (I.e. via sysfs, for SCSI block device, it's

Re: [libvirt] Seeking for advice on 'virsh console' problems debugging

On Fri, Mar 07, 2014 at 06:15:24PM +0400, Roman Bogorodskiy wrote: Daniel P. Berrange wrote: All those mangled messages are being printed out by libvirt client code, and it is totally expected that log messages libvirt prints are mangled in this way for the console. What's more

Re: [libvirt] [PATCH 0/4] Fix for virIdentityGetSystem when SELinux is disabled

On 06.03.2014 07:02, Michael Chapman wrote: If SELinux is compiled into libvirt but it is disabled on the host, libvirtd logs: error : virIdentityGetSystem:173 : Unable to lookup SELinux process context: Invalid argument on each and every client connection. This patch series adds a

[libvirt] [PATCH] virscsi: Introduce virSCSIDeviceUsedByInfoFree

This resolves a Coverity RESOURCE_LEAK issue introduced by commit id 'de6fa535' where the virSCSIDeviceSetUsedBy() didn't VIR_FREE the 'copy' or possibly VIR_STRDUP()'d values. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virscsi.c | 26 +++--- 1 file changed,

Re: [libvirt] [PATCH v14 01/49] virscsi: fix memory leak

On 03/07/2014 05:52 AM, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/util/virscsi.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/util/virscsi.c b/src/util/virscsi.c index 69eae24..627b3f8 100644 --- a/src/util/virscsi.c

Re: [libvirt] [PATCH] Change file names in comments to match the files they are in

On 07.03.2014 14:45, Ján Tomko wrote: Some of these are leftovers from renaming the files, others are just typos. Also introduce an ugly awk script to enforce this. --- cfg.mk | 25 + daemon/libvirtd-config.c| 2 +-

Re: [libvirt] [PATCH] virscsi: Introduce virSCSIDeviceUsedByInfoFree

On 03/07/2014 03:55 PM, John Ferlan wrote: This resolves a Coverity RESOURCE_LEAK issue introduced by commit id 'de6fa535' where the virSCSIDeviceSetUsedBy() didn't VIR_FREE the 'copy' or possibly VIR_STRDUP()'d values. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virscsi.c

Re: [libvirt] [PATCH] libvirt-tck: Update hook syntax for libvirt 0.9.0+

On Friday, March 07, 2014 05:02:00 PM Osier Yang wrote: ACK, but wondering why we didn't discover it, according to the log for the hook scripts have been changed. I'm not sure why this hasn't been seen before. The only thing that makes sense is that the hook tests haven't been tested since the

  1   2   >