Thanks.
libvirt 1.1.0 qemu 1.5.1 host kernel 3.0.58
guest hasn't ipv6 enabled.
macvtap0 Link encap:Ethernet HWaddr 52:54:00:37:CD:68
inet6 addr: fe80::5054:ff:fe37:cd68/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:0 errors:0
Change the existing code and introduce a syntax-check rule.
Ján Tomko (24):
Indent top-level labels by one space in daemon/
Indent top-level labels by one space in examples/
Indent top-level labels by one space in src/conf/
Indent top-level labels by one space in src/cpu/
Indent
---
daemon/libvirtd-config.c | 6 +-
daemon/libvirtd.c| 14 +--
daemon/remote.c | 222 +++
daemon/stream.c | 4 +-
4 files changed, 123 insertions(+), 123 deletions(-)
diff --git a/daemon/libvirtd-config.c
---
examples/dominfo/info1.c | 2 +-
examples/domsuspend/suspend.c| 8
examples/hellolibvirt/hellolibvirt.c | 8
examples/openauth/openauth.c | 10 +-
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/examples/dominfo/info1.c
---
src/cpu/cpu.c | 8
src/cpu/cpu_generic.c | 6 +++---
src/cpu/cpu_map.c | 6 +++---
src/cpu/cpu_powerpc.c | 20 ++--
src/cpu/cpu_x86.c | 50 +-
5 files changed, 45 insertions(+), 45 deletions(-)
diff
---
src/conf/capabilities.c | 6 +-
src/conf/cpu_conf.c | 12 +-
src/conf/device_conf.c | 2 +-
src/conf/domain_audit.c | 18 +--
src/conf/domain_conf.c | 222 +--
src/conf/domain_event.c
---
src/locking/domain_lock.c | 10 +-
src/locking/lock_daemon.c | 26 +-
src/locking/lock_daemon_config.c | 4 ++--
src/locking/lock_daemon_dispatch.c | 16
src/locking/lock_driver_lockd.c| 18 +-
---
src/lxc/lxc_cgroup.c | 16 +++---
src/lxc/lxc_conf.c | 6 +--
src/lxc/lxc_container.c | 42 +++
src/lxc/lxc_controller.c | 54 +--
src/lxc/lxc_driver.c | 136 +++
src/lxc/lxc_fuse.c | 10 ++--
---
src/esx/esx_driver.c| 110 ++--
src/esx/esx_interface_driver.c | 4 +-
src/esx/esx_network_driver.c| 12 ++--
src/esx/esx_storage_backend_iscsi.c | 22
src/esx/esx_storage_backend_vmfs.c | 36 ++--
---
src/libxl/libxl_conf.c | 18 +++---
src/libxl/libxl_domain.c | 24
src/libxl/libxl_driver.c | 152 +++
3 files changed, 97 insertions(+), 97 deletions(-)
diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index
---
src/parallels/parallels_driver.c | 64 ++--
src/parallels/parallels_network.c | 22 ++---
src/parallels/parallels_storage.c | 68 +++
src/parallels/parallels_utils.c | 2 +-
4 files changed, 78 insertions(+), 78
---
src/storage/storage_backend.c | 20 -
src/storage/storage_backend_disk.c | 6 +--
src/storage/storage_backend_fs.c | 16
src/storage/storage_backend_gluster.c | 12 +++---
src/storage/storage_backend_iscsi.c| 12 +++---
---
src/network/bridge_driver.c | 92 +++
src/network/bridge_driver_linux.c | 40 -
2 files changed, 66 insertions(+), 66 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 20930f3..46c0cb0 100644
---
src/nwfilter/nwfilter_dhcpsnoop.c | 42 +++
src/nwfilter/nwfilter_driver.c| 22
src/nwfilter/nwfilter_ebiptables_driver.c | 36 +-
src/nwfilter/nwfilter_gentech_driver.c| 12 -
---
src/vbox/vbox_MSCOMGlue.c | 6 +--
src/vbox/vbox_XPCOMCGlue.c | 2 +-
src/vbox/vbox_tmpl.c | 106 ++---
3 files changed, 57 insertions(+), 57 deletions(-)
diff --git a/src/vbox/vbox_MSCOMGlue.c b/src/vbox/vbox_MSCOMGlue.c
index
---
src/remote/remote_driver.c | 268 ++---
1 file changed, 134 insertions(+), 134 deletions(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 72545df..ed7dde6 100644
--- a/src/remote/remote_driver.c
+++
---
src/xen/xen_driver.c | 112 +++
src/xen/xen_hypervisor.c | 4 +-
src/xen/xen_inotify.c| 4 +-
src/xen/xend_internal.c | 46 +--
src/xen/xm_internal.c| 28 ++--
src/xen/xs_internal.c| 12 ++---
6 files
---
src/test/test_driver.c | 272 -
1 file changed, 136 insertions(+), 136 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 5694680..ef88d4b 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -294,7
---
src/rpc/virkeepalive.c| 6 +++---
src/rpc/virnetclient.c| 22 +++---
src/rpc/virnetclientprogram.c | 6 +++---
src/rpc/virnetclientstream.c | 14 +++---
src/rpc/virnetmessage.c | 18 +-
src/rpc/virnetsaslcontext.c | 28
---
tools/virsh-console.c| 4 +-
tools/virsh-domain-monitor.c | 34 +++---
tools/virsh-domain.c | 196 +--
tools/virsh-edit.c | 6 +-
tools/virsh-host.c | 14 +--
Indent top-level labels by one space.
Add the rule to HACKING and enforce it by syntax-check.
---
HACKING | 31 ++-
cfg.mk | 6 ++
docs/hacking.html.in | 37 ++---
3 files changed, 38 insertions(+), 36
It is used to break out of the loop early if one regex does not match.
Use the 'break' statement instead.
---
src/util/vircommand.c | 43 ---
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index
Simplify the code. This should have no functional change
(except for the impossible leak fix in 3/5). Most of this
functionality is tested in viriscsitest.
Ján Tomko (5):
Remove useless 'maxReg' variable
Simplify the loop in virCommandRunRegex
Free groups in case of a partial match
Use
Do not check for border iterator values inside the loop,
move the code before/after the loop instead.
---
src/util/vircommand.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index f1adb1e..c17792b 100644
---
---
src/util/vircommand.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index fab3aba..7d13828 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -2832,7 +2832,7 @@ virCommandRunRegex(virCommandPtr cmd,
Instead of adding one to the iterator on every use.
---
src/util/vircommand.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 7d13828..a21a88b 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -2845,10
If there are more than two regexes, but only one of them matches,
the matched groups would be leaked.
---
src/util/vircommand.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index c17792b..fab3aba 100644
---
Some of the function attributes marked as nonnull actually explicitly
handle the arguments for NULL. All changed functions handle missing
initiatoriqn argument well and virISCSIScanTargets also handles well
if the return pointers are missing. Remove some of the liberaly used
ATTRIBUTE_NONNULLs as
On 03/25/2014 08:23 AM, Peter Krempa wrote:
Some of the function attributes marked as nonnull actually explicitly
handle the arguments for NULL. All changed functions handle missing
initiatoriqn argument well and virISCSIScanTargets also handles well
if the return pointers are missing. Remove
On 03/25/14 08:32, Ján Tomko wrote:
On 03/25/2014 08:23 AM, Peter Krempa wrote:
Some of the function attributes marked as nonnull actually explicitly
handle the arguments for NULL. All changed functions handle missing
initiatoriqn argument well and virISCSIScanTargets also handles well
if the
According to our documentation the key value has the following
meaning: Providing an identifier for the volume which identifies a
single volume. The currently used keys for gluster volumes consist of
the gluster volume name and file path. This can't be considered unique
as a different storage
On 03/25/14 08:53, Peter Krempa wrote:
According to our documentation the key value has the following
.. OOPS, git-send-email looked frozen when I was killing it. Apparently
it managed to send the mail anyways. Ignore this one please.
Peter
signature.asc
Description: OpenPGP digital
Ok, it seems I isolated the problem.
The linking error shows up only on FreeBSD with gcc toolchain installed,
because it does not support pie. With clang everything is fine.
There is an issue with detection mechanism. Currently, it is done in
configure script with:
gcc -std=gnu99 -o conftest
src/util/virfile.c
*Check if libvirtd is running uninstalled from a build tree and change
iohelper_path accordingly
---
src/util/virfile.c | 19 +--
1 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/util/virfile.c b/src/util/virfile.c
index
Now that we have virSetUninstalledDir() and virGetUninstalledDir(), we
no longer need virFDStreamSetIOHelper().
---
src/fdstream.c | 11 ---
src/fdstream.h |2 --
src/libvirt_private.syms |1 -
tests/fdstreamtest.c |3 ---
4 files changed, 0
src/lxc/lxc_conf.c:
*Check if libvirtd is running uninstalled from a build tree and change
lxc_path accordingly
---
src/lxc/lxc_conf.c | 19 +--
1 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/lxc/lxc_conf.c b/src/lxc/lxc_conf.c
index d4432cf..ad8f78a
src/storage/storage_backend_disk.c:
*Check if libvirtd is running uninstalled from a build tree and change
parthelper_path accordingly
---
src/storage/storage_backend_disk.c | 28 ++--
1 files changed, 26 insertions(+), 2 deletions(-)
diff --git
src/libvirt_private.syms
*Add symbols
daemon/libvirtd.c
*Set uninstallDir when libvirtd is running uninstalled
from a build tree
src/util/virutil.c
*Introduce virSetUninstalledDir
*Introduce virGetUninstalledDir
---
daemon/libvirtd.c|1 +
src/libvirt_private.syms |
Hello Serge,
On Mon, 2014-03-24 at 22:21 -0500, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
See lp#1276719 for the bug description. As virt-aa-helper doesn't know
Great, thanks for addressing this.
the VFIO groups to use for the guest,
Is there really no way
src/storage/storage_backend_disk.c:
*Check if libvirtd is running uninstalled from a build tree and change
parthelper_path accordingly
---
src/fdstream.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/fdstream.c b/src/fdstream.c
index
On Tue, Mar 25, 2014 at 01:53:11PM +0530, Nehal J Wani wrote:
src/libvirt_private.syms
*Add symbols
daemon/libvirtd.c
*Set uninstallDir when libvirtd is running uninstalled
from a build tree
src/util/virutil.c
*Introduce virSetUninstalledDir
*Introduce
On Tue, Mar 25, 2014 at 10:11:14AM +, Daniel P. Berrange wrote:
On Tue, Mar 25, 2014 at 01:53:11PM +0530, Nehal J Wani wrote:
src/libvirt_private.syms
*Add symbols
daemon/libvirtd.c
*Set uninstallDir when libvirtd is running uninstalled
from a build tree
On 24.3.2014 20:14, Eric Blake wrote:
Changes since v1: rebase to latest code base, address review comments
regarding a leak of dom, add prereq patch to fix bugs that I had
been copying and pasting
Eric Blake (2):
event: fix domain reference bugs
qemu: support arbitrary monitor events
On 24.03.2014 21:45, Brian Rak wrote:
I'm seeing a very weird (and somewhat reproducable) crash in
setSchedulerParameters. The backtrace looks like this:
*** glibc detected *** python2.7: free(): invalid pointer:
0x0152bc48 ***
=== Backtrace: =
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
Notes:
pushed as a build-breaker
generator.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/generator.py b/generator.py
index 0e9600f..e409921 100755
--- a/generator.py
+++ b/generator.py
@@ -273,6 +273,7 @@ skipped_types = {
-Original Message-
From: Eric Blake [mailto:ebl...@redhat.com]
Sent: Tuesday, March 25, 2014 12:01 AM
To: Paolo Bonzini; Gonglei (Arei); qemu-de...@nongnu.org
Cc: quint...@redhat.com; owass...@redhat.com; Yanqiangjun; Zhaoyanbin
(A); Zengjunliang; libvir-list@redhat.com
Subject: Re:
When libvirtd is run from a build directory without being installed, it
should not depend on files from a libvirt package installed in the
system. Currently, APIs defined in src/ don't know whether libvirtd
is being run from the build dir or the installed dir. The following
additions provide the
See lp#1276719 for the bug description. As virt-aa-helper doesn't know
the VFIO groups to use for the guest, allow access to all
/dev/vfio/[0-9]* and /dev/vfio/vfio files if there is a potential need
for vfio
---
examples/apparmor/libvirt-qemu | 1 +
examples/apparmor/usr.sbin.libvirtd | 3
I have observed the following with libvirt xml:
vcpu6/vcpu
cpu
topology sockets='1' cores='4' threads='2'/
/cpu
So according to the topology maximum supported is 8 vcpus, while the
libvirt sets that to 6 - specified in vcpu tag. Shouldn't libvirt
error this out as the mismatch between the
I have observed the following with libvirt xml:
vcpu6/vcpu
cpu
topology sockets='1' cores='4' threads='2'/
/cpu
So according to the topology maximum supported is 8 vcpus, while the
libvirt sets that to 6 - specified in vcpu tag. Shouldn't libvirt
error this out as the mismatch between the
On Tue, Mar 25, 2014 at 08:03:44AM +0100, Ján Tomko wrote:
Change the existing code and introduce a syntax-check rule.
Ján Tomko (24):
Indent top-level labels by one space in daemon/
Indent top-level labels by one space in examples/
Indent top-level labels by one space in src/conf/
On 03/23/2014 11:28 AM, Roman Bogorodskiy wrote:
We use virBhyveTapGetRealDeviceName() to map network interface name
to a real device path, trying to open possible devices and getting
names by ioctl.
Make it skip devices that fail to open with EBUSY because they're
most likely already used
On 03/25/2014 02:40 PM, Martin Kletzander wrote:
On Tue, Mar 25, 2014 at 08:04:08AM +0100, Ján Tomko wrote:
diff --git a/cfg.mk b/cfg.mk
index 559f719..cbcf40b 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -898,6 +898,12 @@ sc_prohibit_virConnectOpen_in_virsh:
halt='Use vshConnect() in virsh
On 03/25/2014 09:41 AM, Martin Kletzander wrote:
On Tue, Mar 25, 2014 at 08:03:44AM +0100, Ján Tomko wrote:
Change the existing code and introduce a syntax-check rule.
Ján Tomko (24):
Indent top-level labels by one space in daemon/
Indent top-level labels by one space in examples/
On 03/25/2014 04:37 AM, Pavel Hrdina wrote:
On 24.3.2014 20:14, Eric Blake wrote:
Changes since v1: rebase to latest code base, address review comments
regarding a leak of dom, add prereq patch to fix bugs that I had
been copying and pasting
Eric Blake (2):
event: fix domain reference
On Wed, Mar 19, 2014 at 11:48:14AM -0600, Laine Stump wrote:
A patch submitted by Steven Malin last week pointed out a problem with
libvirt's DNS SRV record configuration:
https://www.redhat.com/archives/libvir-list/2014-March/msg00536.html
When searching for that message later, I found
This started off with some regression testing after going forward to Xen-4.4. We
currently would pair that with a libvirt version 1.2.2 and right now operations
through virsh seem to be working (mostly) well. But when using virt-manager (not
the most up-to-date versions but some combinations that
Commit d9f19c30d054c86b15a304f4118baa4fa75af9d2 moved a lot of the
configuration setup into libxlDriverConfigNew().
However that tries to create the libxl/libxl-driver.log before the
libxl directory gets created in libxlStateInitialize().
This causes the daemon to fail on systems that have not
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
See lp#1276719 for the bug description. As virt-aa-helper doesn't know
the VFIO groups to use for the guest, allow access to all
/dev/vfio/[0-9]* and /dev/vfio/vfio files if there is a potential need
for vfio
---
Thanks, Cédric! Looks good to
On Tue, Mar 25, 2014 at 04:22:54PM +0100, Stefan Bader wrote:
This started off with some regression testing after going forward to Xen-4.4.
We
currently would pair that with a libvirt version 1.2.2 and right now
operations
through virsh seem to be working (mostly) well. But when using
On 25.03.2014 16:36, Daniel P. Berrange wrote:
On Tue, Mar 25, 2014 at 04:22:54PM +0100, Stefan Bader wrote:
This started off with some regression testing after going forward to
Xen-4.4. We
currently would pair that with a libvirt version 1.2.2 and right now
operations
through virsh seem
On Tue, Mar 25, 2014 at 04:42:25PM +0100, Stefan Bader wrote:
On 25.03.2014 16:36, Daniel P. Berrange wrote:
On Tue, Mar 25, 2014 at 04:22:54PM +0100, Stefan Bader wrote:
This started off with some regression testing after going forward to
Xen-4.4. We
currently would pair that with a
On 25.03.2014 16:46, Daniel P. Berrange wrote:
On Tue, Mar 25, 2014 at 04:42:25PM +0100, Stefan Bader wrote:
On 25.03.2014 16:36, Daniel P. Berrange wrote:
On Tue, Mar 25, 2014 at 04:22:54PM +0100, Stefan Bader wrote:
This started off with some regression testing after going forward to
On 03/25/2014 09:28 AM, Stefan Bader wrote:
Commit d9f19c30d054c86b15a304f4118baa4fa75af9d2 moved a lot of the
configuration setup into libxlDriverConfigNew().
However that tries to create the libxl/libxl-driver.log before the
libxl directory gets created in libxlStateInitialize().
This
On 14.03.2014 16:03, Ján Tomko wrote:
---
src/lxc/lxc_cgroup.c | 13 ++---
src/lxc/lxc_driver.c | 6 +-
src/qemu/qemu_cgroup.c | 12 +---
src/qemu/qemu_driver.c | 7 ++-
4 files changed, 30 insertions(+), 8 deletions(-)
I'd expect some explanation in the
On 14.03.2014 16:03, Ján Tomko wrote:
Currently, cputuneshares0/shares/cputune is treated
as if it were not specified.
Treat is as a valid value if it was explicitly specified
and write it to the cgroups.
---
src/conf/domain_conf.c | 12
Ján Tomko wrote:
This would leak devpath.
ACK with VIR_FREE(devpath) added either before 'continue', or the virAsprintf
allocating it.
Pushed, thanks!
Roman Bogorodskiy
pgpevKP6sj_6k.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
---
setup.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/setup.py b/setup.py
index cfbbe2c..554d10d 100755
--- a/setup.py
+++ b/setup.py
@@ -11,7 +11,6 @@ from distutils.errors import DistutilsExecError
import distutils
import sys
-import datetime
import os
import os.path
import re
This means we call it twice for a build operation, but I don't think
that's a big deal.
---
setup.py | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/setup.py b/setup.py
index a8fdeb4..f137b22 100755
--- a/setup.py
+++ b/setup.py
@@ -34,13 +34,14 @@
This series reorganizes setup.py to not unconditionally call
pkg-config. This will allow 'setup.py clean' and 'setup.py --help'
to work correctly even if pkg-config or libvirt-devel aren't installed.
https://bugzilla.redhat.com/show_bug.cgi?id=1074170
Cole Robinson (4):
setup.py: Remove unused
Makes it a bit more clear what all that code is used for, rather than
intermixing it with function definitions.
Besides the comment additions, this is a no-op and just reindents the
block, into a function.
---
setup.py | 97 ++--
1 file
If pkg-config isn't installed, or a too old libvirt, we can't even
do 'python setup.py --help' without throwing an exception.
Have the pkg-config checks and validation only throw an exception if
being called from the 'build' step.
https://bugzilla.redhat.com/show_bug.cgi?id=1074170
---
setup.py
There is a domain id in the virDomain structure as well as in the
virDomainObj structure. While the former can become stale the latter
is kept up to date. So it is safer to always (virDomainObjPtr)-def-id
internally.
This will fix issues seen when managing Xen guests through libvirt from
Recent changes in the module seemed to have caused Coverity to reanalyze
certain parts of the code. Previously the code was modified via commit
id '11a11812' to resolve a different error (perhaps DEADCODE). Up through
commit id '7b3f1f8c' there were no issues.
The new error indicats the 'outbuf'
Recent changes to the module seemed to have caused Coverity to find a new
issue regarding the failure to check the return from a sendmsg. The code
doesn't seem to care about the return status, so just added an ignore_value
to keep Coverity quiet.
Signed-off-by: John Ferlan jfer...@redhat.com
---
For virlog.c and commandtest.c - it seems recent changes within the
modules have allowed Coverity to dig deeper and find different issues.
Not sure why Coverity has that ability... Since I was making changes,
figured I'd clean up the lxc_controller fd leak as well - these should
clean the Jenkins
On error the lofd would have been leaked.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/lxc/lxc_controller.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index 800a306..928a43d 100644
---
In 'make syntax-check', we have a rule that prevents layering
violations between the various files in src. However, we
forgot to treat conf/ and the more recently-added access/ as
lower-level directories, and were not detecting cases where
they might have used a driver file. Also, it's not nice
qemuDomainSetSchedulerParametersFlags() calls virQEMUDriverGetConfig() twice
and makes the reference counter leak. This removes redundant call.
---
src/qemu/qemu_driver.c |1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 76f789e..ca971f3
I just realized this was never reviewed/commented on. Without this patch,
libvirtd is left in a state where future tests expect hooks to exist, but the
hooks themselves are removed in $hook-cleanup. The subsequent 'hook files not
found' errors cause the tests to fail.
-Mike
On Thursday, March
On 03/25/2014 11:39 AM, Cole Robinson wrote:
This series reorganizes setup.py to not unconditionally call
pkg-config. This will allow 'setup.py clean' and 'setup.py --help'
to work correctly even if pkg-config or libvirt-devel aren't installed.
On 03/25/2014 12:00 PM, John Ferlan wrote:
Recent changes to the module seemed to have caused Coverity to find a new
issue regarding the failure to check the return from a sendmsg. The code
doesn't seem to care about the return status, so just added an ignore_value
to keep Coverity quiet.
On 03/25/2014 12:00 PM, John Ferlan wrote:
Recent changes in the module seemed to have caused Coverity to reanalyze
certain parts of the code. Previously the code was modified via commit
id '11a11812' to resolve a different error (perhaps DEADCODE). Up through
commit id '7b3f1f8c' there were
On 03/25/2014 02:37 PM, Tomoki Sekiyama wrote:
qemuDomainSetSchedulerParametersFlags() calls virQEMUDriverGetConfig() twice
and makes the reference counter leak. This removes redundant call.
---
src/qemu/qemu_driver.c |1 -
1 file changed, 1 deletion(-)
ACK and pushed. Problem
On 03/25/2014 12:00 PM, John Ferlan wrote:
On error the lofd would have been leaked.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/lxc/lxc_controller.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
+
+ cleanup:
VIR_FREE(loname);
+if (ret ==
On 03/25/2014 04:54 PM, Eric Blake wrote:
On 03/25/2014 11:39 AM, Cole Robinson wrote:
This series reorganizes setup.py to not unconditionally call
pkg-config. This will allow 'setup.py clean' and 'setup.py --help'
to work correctly even if pkg-config or libvirt-devel aren't installed.
On Tue, 2014-03-25 at 10:40 -0500, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
See lp#1276719 for the bug description. As virt-aa-helper doesn't know
the VFIO groups to use for the guest, allow access to all
/dev/vfio/[0-9]* and /dev/vfio/vfio files if there is a
On 03/25/2014 02:00 PM, John Ferlan wrote:
For virlog.c and commandtest.c - it seems recent changes within the
modules have allowed Coverity to dig deeper and find different issues.
Not sure why Coverity has that ability... Since I was making changes,
figured I'd clean up the lxc_controller
Quoting Cedric Bosdonnat (cbosdon...@suse.com):
On Tue, 2014-03-25 at 10:40 -0500, Serge Hallyn wrote:
Quoting Cédric Bosdonnat (cbosdon...@suse.com):
See lp#1276719 for the bug description. As virt-aa-helper doesn't know
the VFIO groups to use for the guest, allow access to all
Hi.
This is a small patch set to fix a few issues I've discovered while testing
Claudio's patch set.
The first patch is trivial, it adds the ConnectionCloseListener interface and
corresponding
enum, which were missing.
The second patch ensures that the JNA callbacks cannot be garbage
Currently nothing prevents the JNA callback objects used when registering
for domain events from being garbage collected. JNA requires that callback
objects are not GCed whilst they are in use by C code.
To solve this we hold a reference to the callback alongside the callback id.
This ensures
---
src/main/java/org/libvirt/event/ConnectionCloseListener.java | 9 +
src/main/java/org/libvirt/event/ConnectionCloseReason.java | 8
2 files changed, 17 insertions(+)
create mode 100644 src/main/java/org/libvirt/event/ConnectionCloseListener.java
create mode 100644
Hi
Simple patch to set the Java source level within the pom, this makes it
easier to import the project into Eclipse. I've also added an ignore for
a local pom file.
I've added plugins to publish the sources and javadocs into Maven. This
allows Maven (and IDE integration) to automatically
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it
easier to import the project into Eclipse. I've also added an ignore for
a local pom file.
I've added plugins to publish the sources and javadocs into Maven. This
Update the pom to set the Java source level. This enables Eclipse
to correctly configure itself.
Also include plugins to publish the source and javadocs vai Maven.
Update .gitignore to exclude a local pom.
---
.gitignore | 1 +
pom.xml.in | 41 +
2
On 03/25/2014 10:19 PM, Eric Blake wrote:
On 03/25/2014 09:29 PM, Chris Ellis wrote:
Hi
Simple patch to set the Java source level within the pom, this makes it
easier to import the project into Eclipse. I've also added an ignore for
a local pom file.
I've added plugins to publish the
Hi all:
There maybe a bug about detaching virtual net device（such as virtio nic、
RTL8138、E1000）。
When live detaching the net device, there are some problems:
(1)If the Guest OS don't support the hot plugging pci device, detach
the virtual network device by Libvirt, the net device in Qemu will
97 matches
Mail list logo
