Modify the structure _virDomainBlockIoTuneInfo to support total_bytes_sec_max,
write_bytes_sec_max,
read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max,
size_iops_sec options.
Add the boolean support_max_options in the structure _virDomainBlockIoTuneInfo
to know
if
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
tools/virsh-domain.c | 119 +++
1 file changed, 119 insertions(+)
diff --git a/tools/virsh-domain.c
Add defines for the news options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max
total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
include/libvirt/libvirt.h.in | 54
Detect if the the qemu binary currently in use suport the bps_max option and
thy firends,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_monitor_text.c | 75
Check the arability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_command.c | 49 +
1 file changed, 49
On 09/06/2014 09:30 PM, Hongbin Lu wrote:
The OpenVZ driver reported an error on parsing some OpenVZ config
parameters (e.g. diskspace). This issue is due to the driver made
two incorrect assumptions about the value of the parameters:
1. Assume paramaeter is just a number (without unit
On Mon, Sep 15, 2014 at 05:20:46PM +0200, Michal Privoznik wrote:
On 15.09.2014 17:15, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 03:43:55PM +0200, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only for x86_64 and i686
which leaves us failing to build on other
On 09/15/2014 01:46 AM, Martin Kletzander wrote:
On Thu, Sep 11, 2014 at 09:54:51AM -0400, Laine Stump wrote:
On 09/08/2014 07:40 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
+ref name=virSwitch/
Purely cosmetic, but how about calling them
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_monitor_json.c | 58
1 file changed,
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary support
bps_max,
if not print an error message, if yes add it to info variable
Signed-off-by: Matthias Gatto matthias.ga...@outscale.com
---
src/qemu/qemu_driver.c |
On Mon, Sep 15, 2014 at 04:22:18PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 05:20:46PM +0200, Michal Privoznik wrote:
On 15.09.2014 17:15, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 03:43:55PM +0200, Michal Privoznik wrote:
Currently, the setns() wrapper is supported only
On Mon, Sep 15, 2014 at 10:38:20AM +0200, Erik Skultety wrote:
We already are checking for negative value, reporting an error, but
using wrong function, so the check never succeeds. This patch provides
Actually it could succeed, for example with queues=asdf or 3d it
would return a -1. So I
On 15.09.2014 17:32, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 04:22:18PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 05:20:46PM +0200, Michal Privoznik wrote:
On 15.09.2014 17:15, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 03:43:55PM +0200, Michal Privoznik wrote:
On Mon, Sep 15, 2014 at 09:29:05AM -0600, Eric Blake wrote:
On 09/15/2014 01:46 AM, Martin Kletzander wrote:
On Thu, Sep 11, 2014 at 09:54:51AM -0400, Laine Stump wrote:
On 09/08/2014 07:40 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
+ref
On Mon, Sep 15, 2014 at 10:42:15AM +0200, Erik Skultety wrote:
When spanning tree protocol is allowed in bridge settings, forward delay
value is set as well (default is 0 if omitted). Until now, there was no
check for delay value validity. Delay makes sense only as a positive
numerical value.
On Mon, Sep 15, 2014 at 05:34:36PM +0200, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 10:38:20AM +0200, Erik Skultety wrote:
We already are checking for negative value, reporting an error, but
using wrong function, so the check never succeeds. This patch provides
Actually it could
Instead of writing our own wrapper over setns function, require
it in glibc (when compiling with LXC). Our implementation uses
private macros from kernel header files which should not be done.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
This is an alternative approach as requested by
On 09/15/2014 05:16 PM, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 05:12:12PM +0200, Pavel Hrdina wrote:
This patch series introduce new cputune event to inform
management applications about every change of cputune values
for running domains.
There is missing documentation for all
On Mon, Sep 15, 2014 at 05:36:16PM +0200, Michal Privoznik wrote:
On 15.09.2014 17:32, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 04:22:18PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 05:20:46PM +0200, Michal Privoznik wrote:
On 15.09.2014 17:15, Martin Kletzander wrote:
From: Francesco Romani from...@redhat.com
This patch implements the VIR_DOMAIN_STATS_BALLOON group of statistics.
Signed-off-by: Francesco Romani from...@redhat.com
---
include/libvirt/libvirt.h.in | 1 +
src/libvirt.c| 6 ++
src/qemu/qemu_driver.c | 37
From: Francesco Romani from...@redhat.com
This patch implements the VIR_DOMAIN_STATS_VCPU group of statistics. To
do so, this patch also extracts a helper to gather the vCPU information.
Signed-off-by: Francesco Romani from...@redhat.com
Signed-off-by: Peter Krempa pkre...@redhat.com
---
Notes:
From: Francesco Romani from...@redhat.com
This patch implements the VIR_DOMAIN_STATS_CPU_TOTAL group of
statistics.
Signed-off-by: Francesco Romani from...@redhat.com
Signed-off-by: Peter Krempa pkre...@redhat.com
---
Notes:
Version 6:
- added a check that skips the stats group in case
After my review on Francesco's series I've tested the patches a bit more and
found a few problems.
I'm re-sending the series and also I've added a few patches that tweak the
documentation for this.
Francesco Romani (8):
qemu: bulk stats: extend internal collection API
qemu: bulk stats:
Document the fields returned.
---
tools/virsh.pod | 47 +++
1 file changed, 47 insertions(+)
diff --git a/tools/virsh.pod b/tools/virsh.pod
index b929480..789641c 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -835,6 +835,53 @@ default all
From: Francesco Romani from...@redhat.com
Exports to the domstats commands the new bulk stats groups.
Signed-off-by: Francesco Romani from...@redhat.com
---
tools/virsh-domain-monitor.c | 35 +++
tools/virsh.pod | 4 +++-
2 files changed, 38
From: Francesco Romani from...@redhat.com
Future patches which will implement more bulk stats groups for QEMU will
need to access the connection object.
To accomodate that, a few changes are needed:
* enrich internal prototype to pass qemu driver object
* add per-group flag to mark if one
On 09/15/2014 03:20 PM, Martin Kletzander wrote:
Changes to v1:
- 1/3 is now not connected to the rest of the patches any more
- whitespaces
- memShared='on/off' - memAccess='private/shared'
Martin Kletzander (3):
schemas: finish virTristate{Bool,Switch} transition
docs, conf,
Add a note to make the users aware that some stats groups or fields may
be missing in certain cases.
---
src/libvirt.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/libvirt.c b/src/libvirt.c
index 03f7e5b..b3ddf95 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -21657,6 +21657,11
From: Francesco Romani from...@redhat.com
Management software wants to be able to allocate disk space on demand.
To support this they need keep track of the space occupation of the
block device. This information is reported by qemu as part of block
stats.
This patch extend the block information
State that full stats for the stats groups are available in the
virConnectGetAllDomainStats documentation section rather than
duplicating the docs.
---
src/libvirt.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index a8892a2..03f7e5b
From: Francesco Romani from...@redhat.com
This patch implements the VIR_DOMAIN_STATS_INTERFACE group of
statistics.
Signed-off-by: Francesco Romani from...@redhat.com
Signed-off-by: Peter Krempa pkre...@redhat.com
---
Notes:
Version 6:
- this stats group is now skipped if the guest is
From: Francesco Romani from...@redhat.com
This patch implements the VIR_DOMAIN_STATS_BLOCK group of statistics.
To do so, an helper function to get the block stats of all the disks of
a domain is added.
Signed-off-by: Francesco Romani from...@redhat.com
Signed-off-by: Peter Krempa
On 09/04/2014 10:25 PM, Hongbin Lu wrote:
This patch adds initial migration support to the OpenVZ driver,
using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration
functions.
---
src/openvz/openvz_conf.h |5 +-
src/openvz/openvz_driver.c | 348
On Mon, Sep 15, 2014 at 05:44:17PM +0200, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 05:36:16PM +0200, Michal Privoznik wrote:
On 15.09.2014 17:32, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 04:22:18PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 05:20:46PM +0200,
On Mon, Sep 15, 2014 at 05:41:38PM +0200, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 05:34:36PM +0200, Martin Kletzander wrote:
On Mon, Sep 15, 2014 at 10:38:20AM +0200, Erik Skultety wrote:
We already are checking for negative value, reporting an error, but
using wrong function, so the
On Mon, Sep 15, 2014 at 05:41:38PM +0200, Michal Privoznik wrote:
Instead of writing our own wrapper over setns function, require
it in glibc (when compiling with LXC). Our implementation uses
private macros from kernel header files which should not be done.
Signed-off-by: Michal Privoznik
On Mon, Sep 15, 2014 at 05:43:30PM +0200, Pavel Hrdina wrote:
On 09/15/2014 05:16 PM, Daniel P. Berrange wrote:
On Mon, Sep 15, 2014 at 05:12:12PM +0200, Pavel Hrdina wrote:
This patch series introduce new cputune event to inform
management applications about every change of cputune values
On 09/15/2014 04:09 AM, Peter Krempa wrote:
On 09/13/14 15:27, John Ferlan wrote:
Coverity complains about the calculation of the buf len within
the PROBE macro. So to quiet things down, do the calculation prior
to usage in either write() or qemuMonitorIOWriteWithFD() calls and
then have
On 09/15/2014 09:42 AM, Peter Krempa wrote:
State that full stats for the stats groups are available in the
virConnectGetAllDomainStats documentation section rather than
duplicating the docs.
---
src/libvirt.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git
On 09/15/2014 09:42 AM, Peter Krempa wrote:
Add a note to make the users aware that some stats groups or fields may
be missing in certain cases.
---
src/libvirt.c | 5 +
1 file changed, 5 insertions(+)
ACK.
diff --git a/src/libvirt.c b/src/libvirt.c
index 03f7e5b..b3ddf95 100644
On 09/03/2014 12:15 PM, John Ferlan wrote:
...snip...
John Ferlan (7):
virsh: Add iothread to 'attach-disk'
qemu: Issue query-iothreads and to get list of active IOThreads
vircgroup: Introduce virCgroupNewIOThread
qemu_domain: Add niothreadpids and iothreadpids
qemu_cgroup:
This is a folloup to commit 5f719596, which checks for a route
conflicting with the standard libvirt default network subnet
(192.168.122.0/24). It turns out that the output of ip route show
doesn't have a trailing newline, so there would be no match if the
route we were looking for was the final
On 09/15/2014 11:34 AM, Laine Stump wrote:
This is a folloup to commit 5f719596, which checks for a route
conflicting with the standard libvirt default network subnet
(192.168.122.0/24). It turns out that the output of ip route show
doesn't have a trailing newline,
Well, 'ip' outputs the
On 09/08/2014 01:46 AM, Martin Kletzander wrote:
This way it behaves more like the daemon itself does (acquiring a
pidfile, deleting the socket before binding, etc.).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138604
On 09/15/2014 01:56 PM, Eric Blake wrote:
On 09/15/2014 11:34 AM, Laine Stump wrote:
This is a folloup to commit 5f719596, which checks for a route
conflicting with the standard libvirt default network subnet
(192.168.122.0/24). It turns out that the output of ip route show
doesn't have a
I missed adding virCgroupNewIOThread to the !VIR_CGROUP_SUPPORTED
Pushing as build breaker
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/util/vircgroup.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index 13c7b7d..1dbe6f9
On 09/03/2014 10:15 AM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1101574
Add an option 'iothreadpin' to the cpuset to allow for setting the
CPU affinity for each IOThread.
The iothreadspin will mimic the vcpupin with respect to being able to
assign each iothread to a
Chunyan Liu wrote:
Xen libxl can support Xen HVM direct kernel boot now. To support
Xen HVM direct kernel boot in libvirt, it still needs some changes
to libvirt code: accept HVM direct kernel boot related configuration
in xml, parse those info into virDomainDefPtr, and fill in related
parts
On 09/11/2014 07:43 AM, Ján Tomko wrote:
Just to make this series work until Martin pushes his more complete
cleanup:
https://www.redhat.com/archives/libvir-list/2014-September/msg00391.html
---
docs/schemas/basictypes.rng | 6 ++
1 file changed, 6 insertions(+)
Looks like this
On 09/11/2014 07:43 AM, Ján Tomko wrote:
Use just one int variable for all the FromString calls.
---
src/conf/domain_conf.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
ACK
--
libvir-list mailing list
libvir-list@redhat.com
On 09/11/2014 07:43 AM, Ján Tomko wrote:
Instead of checking upfront if the driver element will be needed
in a big condition, just format all the attributes into a string
and output the driver element if the string is not empty.
---
src/conf/domain_conf.c | 68
On 09/11/2014 07:43 AM, Ján Tomko wrote:
---
src/qemu/qemu_command.c | 20
.../qemuxml2argv-net-virtio-disable-offloads.args| 8
tests/qemuxml2argvtest.c | 2 ++
3 files changed, 30 insertions(+)
On 09/11/2014 07:43 AM, Ján Tomko wrote:
Add the following attributes:
csum, gso, guest_tso4, guest_tso6, guest_ecn
to the driver element of network interface
which control the virtio-net device properties
of the same names.
---
docs/formatdomain.html.in | 27
On 09/11/2014 05:43 AM, Ján Tomko wrote:
Add the following attributes:
csum, gso, guest_tso4, guest_tso6, guest_ecn
to the driver element of network interface
which control the virtio-net device properties
of the same names.
---
docs/formatdomain.html.in | 27
On 09/03/2014 10:15 AM, John Ferlan wrote:
The following patches will add more support for IOThreads not completed
from the initial patches. These changes support the remaining elements of
bz https://bugzilla.redhat.com/show_bug.cgi?id=1101574 (working through
unsetting the private bits - as
* docs/schemas/domaincommon.rng (cputune): Add interleave.
* tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml: Swap
up order, copying canonical form...
* tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-iothreads.xml:
...here.
* tests/qemuxml2xmltest.c (mymain): Mark the difference.
On 09/15/2014 07:06 PM, Eric Blake wrote:
On 09/03/2014 10:15 AM, John Ferlan wrote:
The following patches will add more support for IOThreads not completed
from the initial patches. These changes support the remaining elements of
bz https://bugzilla.redhat.com/show_bug.cgi?id=1101574
If there are no iothreads, then return from qemuProcessDetectIOThreadPIDs
without error; otherwise, the following occurs:
error: Failed to start domain $dom
error: An error occurred, but the cause is unknown
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_process.c | 6 +-
1
Found by inspection of the i+1 change. IOThreads are numbered 1..n
thus the virCgroupNewIOThread needs to create a 1..n value not 0 based.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Change i+1 to i + 1
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/qemu/qemu_cgroup.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index c1d89bb..9d39370 100644
--- a/src/qemu/qemu_cgroup.c
+++
Well I guess it happens to everyone - hopefully only once though...
The IOThreads code really messed up a few things - git bisection for
the build is broken as of 5f6ad32c733a3bd158938aecabb0508a434ece95,
but that's resolved by 938fb12fad6d15c9fdb73f998c4e0ec1e278721f
which adds the
On 09/15/2014 07:34 PM, Eric Blake wrote:
* docs/schemas/domaincommon.rng (cputune): Add interleave.
* tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml: Swap
up order, copying canonical form...
* tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-iothreads.xml:
...here.
*
On 09/15/2014 06:13 PM, John Ferlan wrote:
Well I guess it happens to everyone - hopefully only once though...
Yep, the brown bag of shame lets you learn from mistakes rather quickly :)
The IOThreads code really messed up a few things - git bisection for
the build is broken as of
On 09/15/2014 06:39 PM, John Ferlan wrote:
On 09/15/2014 07:34 PM, Eric Blake wrote:
* docs/schemas/domaincommon.rng (cputune): Add interleave.
* tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml: Swap
up order, copying canonical form...
*
On 09/15/2014 08:55 PM, Eric Blake wrote:
On 09/15/2014 06:13 PM, John Ferlan wrote:
Well I guess it happens to everyone - hopefully only once though...
Yep, the brown bag of shame lets you learn from mistakes rather quickly :)
The IOThreads code really messed up a few things - git
---
src/openvz/openvz_driver.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index 57b3c22..3147311 100644
--- a/src/openvz/openvz_driver.c
+++ b/src/openvz/openvz_driver.c
@@ -2364,7 +2364,10 @@
Hi John,
Thanks for pointing that out. A fix was proposed in here
https://www.redhat.com/archives/libvir-list/2014-September/msg01000.html.
Best regards,
Hongbin
On Mon, Sep 15, 2014 at 11:46 AM, John Ferlan jfer...@redhat.com wrote:
On 09/04/2014 10:25 PM, Hongbin Lu wrote:
This patch
Since block-stream is not supported on qemu-kvm, so libvirt should
post more accurate error info when do blockpull with qemu-kvm but
not Command 'block-stream' is not found
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140981
Signed-off-by: Shanzhi Yu s...@redhat.com
---
101 - 168 of 168 matches
Mail list logo
