For virQEMUCapsInitQMPMonitor I didn't find other way to check the
capability than to check the version, and virQEMUCapsComputeCmdFlags
is not call when qemu use QMP(or I've miss how to call it).
I don't understand how i should change this patch, can you explain it
to me please ?
On Fri, Sep 19,
When I've add this field I was thinking it would simplify the check of
the capability of read_iops_sec_max and co.
But you're right I can add some arguments in the functions which use
read_iops_sec_max and co.
I will remove this for the v3 of this patch.
On Fri, Sep 19, 2014 at 1:11 PM, Michal
The unit of '--pagesize' of freepages is kibibytes.
https://bugzilla.redhat.com/show_bug.cgi?id=1145048
Signed-off-by: Jincheng Miao jm...@redhat.com
---
tools/virsh-host.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/tools/virsh-host.c
Jincheng Miao (3):
virsh-host: fix pagesize unit of freepages
nodeinfo: report error when given node is out of range
Fix typo of virNodeGetFreePages comment
src/libvirt.c | 2 +-
src/nodeinfo.c | 24 +---
tools/virsh-host.c | 27 ++-
3
Signed-off-by: Jincheng Miao jm...@redhat.com
---
src/libvirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 7c63825..aa83365 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -21307,7 +21307,7 @@ virDomainSetTime(virDomainPtr dom,
*
https://bugzilla.redhat.com/show_bug.cgi?id=1145050
Signed-off-by: Jincheng Miao jm...@redhat.com
---
src/nodeinfo.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index af23b8b..1728891 100644
--- a/src/nodeinfo.c
Up until now, we set memballoon period in monitor successfully, however
we did not update domain definition structure, thus dumpxml was omitting
period attribute in memballoon element
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140960
---
src/qemu/qemu_driver.c | 8 +++-
1 file
Erik Skultety (2):
qemu: Fix updating bandwidth limits in live XML
qemu: Fix updating balloon period in live XML
src/qemu/qemu_driver.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
--
1.9.3
--
libvir-list mailing list
libvir-list@redhat.com
When trying to update bandwidth limits on a running domain, limits get
updated in our internal structures, however XML parser reads
bandwidth limits from network 'actual' definition. Commiting this patch
it is now available to update bandwidth 'actual' definition as well,
thus updating domain
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to disabled.
Rename machine type pc-1.0 to pc-1.0-qemu-git.
Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm
On 22.09.2014 11:39, Matthias Gatto wrote:
For virQEMUCapsInitQMPMonitor I didn't find other way to check the
capability than to check the version, and virQEMUCapsComputeCmdFlags
is not call when qemu use QMP(or I've miss how to call it).
I don't understand how i should change this patch, can
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to disabled.
Rename machine type pc-1.0 to
On Sun, Sep 21, 2014 at 03:38:58PM +0100, Alex Bligh wrote:
Add a machine type pc-1.0-qemu-kvm for live migrate compatibility
with qemu-kvm version 1.0.
Signed-off-by: Alex Bligh a...@alex.org.uk
---
hw/acpi/piix4.c | 47
+--
On Mon, Sep 22, 2014 at 12:42:47PM +0100, Daniel P. Berrange wrote:
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding
On 22 Sep 2014, at 12:36, Michael S. Tsirkin m...@redhat.com wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to disabled.
Rename machine type pc-1.0 to
On Mon, Sep 22, 2014 at 12:50:14PM +0100, Alex Bligh wrote:
On 22 Sep 2014, at 12:36, Michael S. Tsirkin m...@redhat.com wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm,
When virConnectDomainQemuMonitorEventRegister is called with the
VIR_CONNECT_DOMAIN_QEMU_MONITOR_EVENT_REGISTER_REGEX flag,
ignore the flag instead of crashing.
https://bugzilla.redhat.com/show_bug.cgi?id=1144920
---
src/conf/domain_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 19.09.2014 18:13, Daniel P. Berrange wrote:
On Wed, Sep 10, 2014 at 03:26:13PM +0200, Michal Privoznik wrote:
The most interesting part where all the hard work takes place.
For storing triplets of strings a two dimensional table would be
the most intuitive approach. Or, if the triplet is
Michael,
(Reordering)
On 22 Sep 2014, at 12:50, Michael S. Tsirkin m...@redhat.com wrote:
@@ -257,6 +259,11 @@ static int pit_dispatch_post_load(void *opaque, int
version_id)
return 0;
}
+static bool has_irq_disabled(void *opaque, int version_id)
+{
+return (version_id = 3)
On Mon, Sep 22, 2014 at 01:28:30PM +0100, Alex Bligh wrote:
Michael,
(Reordering)
On 22 Sep 2014, at 12:50, Michael S. Tsirkin m...@redhat.com wrote:
@@ -257,6 +259,11 @@ static int pit_dispatch_post_load(void *opaque, int
version_id)
return 0;
}
+static bool
On Wed, Sep 17, 2014 at 17:18:35 +0200, Peter Krempa wrote:
Extract code used to check save image XMLs provided by users to separate
use.
---
src/qemu/qemu_driver.c | 100
-
1 file changed, 66 insertions(+), 34 deletions(-)
ACK
Jirka
--
On Wed, Sep 17, 2014 at 17:18:36 +0200, Peter Krempa wrote:
Add a new parameter that will allow to return the XML stored in the save
image for further manipulation and adjust the callers. This option will
be used in later patches.
---
src/qemu/qemu_driver.c | 18 +++---
1 file
Sadly that is not true. For instance on Ubuntu Precise
it's invoked as qemu-system-x86_64 by at least one
management application known to me.
Well change it to call qemu-kvm then :)
Also what happens if you install qemu as well?
Does it conflict?
I'm not an Ubuntu maintainer but AFAIK
On 09/18/2014 10:39 AM, Pavel Hrdina wrote:
This patch series introduce new tunable event to inform management
applications about changes of tunable values. With this universal
event we will be able to report updates for all different tunable
values like cpu tuning, block tinning, memory
It's a minor typo issue, /dev/vhost-net is a default device.
# ll /dev/vhost-net
crw---. 1 root root 10, 238 Sep 22 20:30 /dev/vhost-net
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in
On Mon, Sep 22, 2014 at 1:38 PM, Michal Privoznik mpriv...@redhat.com wrote:
On 22.09.2014 11:39, Matthias Gatto wrote:
For virQEMUCapsInitQMPMonitor I didn't find other way to check the
capability than to check the version, and virQEMUCapsComputeCmdFlags
is not call when qemu use QMP(or I've
On 09/12/2014 06:33 AM, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_conf.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index ac10b64..013f3de 100644
--- a/src/qemu/qemu_conf.c
+++
On 09/12/2014 06:31 AM, Chen Fan wrote:
when specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001:0DB8::1428]:
so we should add brackets when parsing
On Wed, Sep 17, 2014 at 17:18:37 +0200, Peter Krempa wrote:
Split out the call to the update method only to places where it is
actually used rather than having a mega-method that does all the stuff.
---
src/qemu/qemu_driver.c | 26 +++---
1 file changed, 15 insertions(+),
On Wed, Sep 17, 2014 at 17:18:38 +0200, Peter Krempa wrote:
Move them to the single corresponding function rather than having them
in the common chunk of code.
---
src/qemu/qemu_driver.c | 76
+++---
1 file changed, 41 insertions(+), 35
When using virt-xml-validate to check tap and vhost attributes
in interface of domain xml, should validate them separately,
don't combine to check them, we can ignore/specify any of them.
---
docs/schemas/domaincommon.rng | 4
1 file changed, 4 insertions(+)
diff --git
On 09/08/2014 09:05 PM, Stefan Berger wrote:
From: Stefan Berger stef...@linux.vnet.ibm.com
Pass the TPM file descriptor to QEMU via command line.
Instead of passing /dev/tpm0 we now pass /dev/fdset/10 and the additional
parameters -add-fd set=10,fd=20.
This addresses the use case when QEMU is
commit 72f919f558902968bd0cf9f99f25ac62cbfe3ac6 introduced an user
friendly error message when trying to use IDE disks as readonly.
Do the same thing for the SATA bus.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112939
Signed-off-by: Giuseppe Scrivano gscri...@redhat.com
---
Description of problem: Fail to compile
Version-Release number of selected component (if applicable):
Version 1.0.3 through 1.1.1
How reproducible:
Steps to Reproduce:
1./configure --prefix=/usr --localstatedir=/var --sysconfdir=/etc
2.make
Actual results:
On Wed, Sep 17, 2014 at 17:18:39 +0200, Peter Krempa wrote:
---
docs/hooks.html.in | 11
src/qemu/qemu_driver.c | 69
+-
src/util/virhook.c | 3 ++-
src/util/virhook.h | 1 +
4 files changed, 76 insertions(+), 8
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/conf/domain_conf.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index bb4a4cb..9cc118c 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
On Mon, Sep 22, 2014 at 04:02:49PM +0200, Giuseppe Scrivano wrote:
commit 72f919f558902968bd0cf9f99f25ac62cbfe3ac6 introduced an user
friendly error message when trying to use IDE disks as readonly.
Do the same thing for the SATA bus.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112939
On Mon, Sep 22, 2014 at 09:12:18PM +0800, Jianwei Hu wrote:
It's a minor typo issue, /dev/vhost-net is a default device.
# ll /dev/vhost-net
crw---. 1 root root 10, 238 Sep 22 20:30 /dev/vhost-net
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Mon, Sep 22, 2014 at 09:46:29PM +0800, Jianwei Hu wrote:
When using virt-xml-validate to check tap and vhost attributes
in interface of domain xml, should validate them separately,
don't combine to check them, we can ignore/specify any of them.
unnecessarily indented commit
On 09/22/14 15:41, Jiri Denemark wrote:
On Wed, Sep 17, 2014 at 17:18:38 +0200, Peter Krempa wrote:
Move them to the single corresponding function rather than having them
in the common chunk of code.
---
src/qemu/qemu_driver.c | 76
+++---
1
---
docs/hooks.html.in | 11
src/qemu/qemu_driver.c | 70 +-
src/util/virhook.c | 3 ++-
src/util/virhook.h | 1 +
4 files changed, 78 insertions(+), 7 deletions(-)
diff --git a/docs/hooks.html.in b/docs/hooks.html.in
index
On Mon, Sep 22, 2014 at 16:55:43 +0200, Peter Krempa wrote:
---
docs/hooks.html.in | 11
src/qemu/qemu_driver.c | 70
+-
src/util/virhook.c | 3 ++-
src/util/virhook.h | 1 +
4 files changed, 78 insertions(+), 7
On 09/22/14 17:07, Jiri Denemark wrote:
On Mon, Sep 22, 2014 at 16:55:43 +0200, Peter Krempa wrote:
---
docs/hooks.html.in | 11
src/qemu/qemu_driver.c | 70
+-
src/util/virhook.c | 3 ++-
src/util/virhook.h | 1 +
4
Martin Kletzander mklet...@redhat.com writes:
On Mon, Sep 22, 2014 at 04:02:49PM +0200, Giuseppe Scrivano wrote:
commit 72f919f558902968bd0cf9f99f25ac62cbfe3ac6 introduced an user
friendly error message when trying to use IDE disks as readonly.
Do the same thing for the SATA bus.
Closes:
Daniel P. Berrange berra...@redhat.com writes:
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to
Michael S. Tsirkin m...@redhat.com writes:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to disabled.
Rename machine type pc-1.0 to pc-1.0-qemu-git.
Make pc-1.0
On Mon, Sep 22, 2014 at 05:24:55PM +0200, Markus Armbruster wrote:
Daniel P. Berrange berra...@redhat.com writes:
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option
Il 22/09/2014 17:24, Markus Armbruster ha scritto:
You're right. However, this particular horse left the barn a long time
ago: the pc-* machine types differ in qemu-kvm and upstream QEMU.
Sure, when qemu-kvm was merged back into QEMU, its machine type variants
were dropped. But they live
Am 22.09.2014 um 15:05 schrieb Alex Bligh:
Sadly that is not true. For instance on Ubuntu Precise
it's invoked as qemu-system-x86_64 by at least one
management application known to me.
Well change it to call qemu-kvm then :)
Also what happens if you install qemu as well?
Does it conflict?
On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
Cleanup virDomanDef structure from other nested structure and create
separate type definition for them.
Fix a typo in virDomainHugePage.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
src/conf/domain_conf.h | 102
Quoting Michael S. Tsirkin (m...@redhat.com):
On Mon, Sep 22, 2014 at 05:24:55PM +0200, Markus Armbruster wrote:
Daniel P. Berrange berra...@redhat.com writes:
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh
On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
examples/object-events/event-test.c | 52
-
1 file changed, 51 insertions(+), 1 deletion(-)
ACK (still)
John
--
libvir-list mailing list
On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
This new event will use typedParameters to expose what has been actually
updated and the reason is that we can in the future extend any tunable
values or add new tunable values. With typedParameters we don't have to
worry about creating some other
On 09/18/2014 04:39 AM, Pavel Hrdina wrote:
Now we have universal tunable event so we can use it for reporting
changes to user. The cputune values will be prefixed with cputune to
distinguish it from other tunable events.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
On 09/22/2014 06:09 AM, Ján Tomko wrote:
When virConnectDomainQemuMonitorEventRegister is called with the
VIR_CONNECT_DOMAIN_QEMU_MONITOR_EVENT_REGISTER_REGEX flag,
ignore the flag instead of crashing.
https://bugzilla.redhat.com/show_bug.cgi?id=1144920
---
src/conf/domain_event.c | 2 +-
On 09/22/2014 05:57 PM, Eric Blake wrote:
On 09/22/2014 06:09 AM, Ján Tomko wrote:
When virConnectDomainQemuMonitorEventRegister is called with the
VIR_CONNECT_DOMAIN_QEMU_MONITOR_EVENT_REGISTER_REGEX flag,
ignore the flag instead of crashing.
On 09/19/2014 04:57 AM, Peter Krempa wrote:
On 09/19/14 12:29, Daniel P. Berrange wrote:
On Fri, Sep 19, 2014 at 11:44:20AM +0200, Francesco Romani wrote:
The commit 74c066df4d8 introduced an helper to factor a code path
which is shared between the existing API and the new bulk stats API.
In
On 09/17/2014 04:53 PM, Jiri Denemark wrote:
This is a modified version of RDMA migration patches sent back in
January by Michael R. Hines. See individual patches for (numerous)
changes since v2.
Jiri Denemark (3):
qemu: Fix old tcp:host URIs more cleanly
qemu: Prepare support for
On 09/17/2014 04:53 PM, Jiri Denemark wrote:
For compatibility with old libvirt we need to support both tcp:host and
tcp://host migration URIs. Let's make the code that parses them a bit
cleaner.
Signed-off-by: Jiri Denemark jdene...@redhat.com
---
Notes:
Version 3:
- new patch
On 09/21/2014 10:58 AM, Laszlo Ersek wrote:
Hi Cole and Michal,
I'm attaching three patches:
On 09/20/14 02:37, Cole Robinson wrote:
On 09/17/2014 06:55 PM, Cole Robinson wrote:
We expose a simple combobox with two entries: BIOS, and UEFI. The
UEFI option is only selectable if 1) libvirt
On 22 Sep 2014, at 16:45, Andreas Färber afaer...@suse.de wrote:
What about adding a bool property qemu-kvm-compat to the MachineClass?
Then a qemu-kvm shell script (like SUSE uses) can pass -global
machine.qemu-kvm-compat=on whereas qemu-system-x86_64 would run in the
default non-qemu-kvm
On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to
Alex Bligh a...@alex.org.uk writes:
On 22 Sep 2014, at 16:45, Andreas Färber afaer...@suse.de wrote:
What about adding a bool property qemu-kvm-compat to the MachineClass?
Then a qemu-kvm shell script (like SUSE uses) can pass -global
machine.qemu-kvm-compat=on whereas qemu-system-x86_64
On 22 Sep 2014, at 16:44, Paolo Bonzini pbonz...@redhat.com wrote:
time, RHEL7 did it. Ubuntu didn't, and probably neither did Debian.
This patch singles out pc-1.0 just because it used to be the default in
Ubuntu 12.04. So basically it's making upstream carry the burden of a
decision of
On 09/22/14 18:37, Cole Robinson wrote:
On 09/21/2014 10:58 AM, Laszlo Ersek wrote:
(2) Unfortunately, even libvirtd needs to be modified, in addition.
My patch for (1) *does* pass VIR_DOMAIN_UNDEFINE_NVRAM to libvirtd (I
verified that with gdb), but libvirtd doesn't act upon it correctly.
On 09/22/2014 10:26 AM, Ján Tomko wrote:
On 09/22/2014 05:57 PM, Eric Blake wrote:
On 09/22/2014 06:09 AM, Ján Tomko wrote:
When virConnectDomainQemuMonitorEventRegister is called with the
VIR_CONNECT_DOMAIN_QEMU_MONITOR_EVENT_REGISTER_REGEX flag,
ignore the flag instead of crashing.
On 9/17/14, 4:33 PM, Anirban Chakraborty abc...@juniper.net wrote:
V2:
Consolidate calls to virNetDevBandwidthSet
Clear bandwidth settings when the interface is detached or domain
destroyed
V1:
Ethernet interfaces in libvirt currently do not support bandwidth setting.
For example, following xml
Add a machine parameter qemu-kvm-migration for live migrate compatibility
with qemu-kvm version 1.0. Usage:
-machine pc-1.0,qemu-kvm-migration=on
This has three effects:
1. cirrus-vga.vgamem_mb defaults to 16 rather than 8
2. A type 2 piix4_pm record is interpreted as being type 3
3. A type 2
This patch series adds inbound migrate capability from qemu-kvm version
1.0. The main ideas are those set out in Cole Robinson's patch here:
http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20
however, rather than patching statically (and breaking inbound
On 22 Sep 2014, at 20:10, Paolo Bonzini pbonz...@redhat.com wrote:
I'm arguing against special-casing pc-1.0. Just apply the patch to
Ubuntu downstream and call it a day.
It's perfectly normal for machine types to be part of the downstream
(not so secret) sauce.
Well, I've just sent
https://bugzilla.redhat.com/show_bug.cgi?id=1141621
Using qemu-attach to attach to a qemu created process and then
attempting to virsh detach-interface caused a libvirtd crash
since the assumption was that device aliases were in place and
that assumption is not necessarily true for the
On 09/15/2014 07:48 AM, Michal Privoznik wrote:
As of 136ad4974 it is possible to specify different huge pages per
guest NUMA node. However, there's no check if nodeset specified in
./hugepages/page contains only those guest NUMA nodes that exist.
In other words with current code it is
On 09/22/2014 02:49 PM, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1141621
Using qemu-attach to attach to a qemu created process and then
attempting to virsh detach-interface caused a libvirtd crash
since the assumption was that device aliases were in place and
that
Michal Privoznik wrote:
On 20.09.2014 01:36, Jim Fehlig wrote:
Martin Kletzander wrote:
On Fri, Sep 19, 2014 at 02:37:12PM -0600, Jim Fehlig wrote:
Michal Privoznik wrote:
On 08.09.2014 18:30, Jim Fehlig wrote:
If an NTP server is configured on the host, it is possible for
libvirt-guests to
Quoting Alex Bligh (a...@alex.org.uk):
On 22 Sep 2014, at 20:10, Paolo Bonzini pbonz...@redhat.com wrote:
I'm arguing against special-casing pc-1.0. Just apply the patch to
Ubuntu downstream and call it a day.
It's perfectly normal for machine types to be part of the downstream
On Mon, 2014-09-22 at 15:34 +0200, Ján Tomko wrote:
On 09/12/2014 06:33 AM, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_conf.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/cpu_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 6c454ee..116aa58 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -413,7 +413,7 @@
On Mon, 2014-09-22 at 15:34 +0200, Ján Tomko wrote:
On 09/12/2014 06:31 AM, Chen Fan wrote:
when specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
We don't accept any other values except '0'.
Signed-off-by: Chen Hanxiao chenhanx...@cn.fujitsu.com
---
docs/formatdomain.html.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index eefdd5e..bb72452 100644
---
On Mon, Sep 22, 2014 at 05:45:28PM +0200, Andreas Färber wrote:
Am 22.09.2014 um 15:05 schrieb Alex Bligh:
Sadly that is not true. For instance on Ubuntu Precise
it's invoked as qemu-system-x86_64 by at least one
management application known to me.
Well change it to call qemu-kvm then
On Mon, Sep 22, 2014 at 05:54:02PM +0100, Alex Bligh wrote:
However, that's not compatible with using PC_COMPAT as far as I
know (unless there is some cunning way you can make a machine
parameter change compat_props things).
Of course not, PC_COMPAT is the reverse: have machine type
influence
On 09/22/2014 07:45 PM, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/conf/cpu_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
ACK and pushed.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
if specifying migration_host to an Ipv6 address without brackets,
it was resolved to an incorrect address, such as:
tcp:2001:0DB8::1428:,
but the correct address should be:
tcp:[2001:0DB8::1428]:
so we should add brackets when parsing it.
Signed-off-by: Chen Fan
nowadays, virSocketAddrIsNumeric only validated the income address
if numeric, but sometimes we need to know whether the address is
an IPv4 or an IPv6 address.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu_migration.c | 4 ++--
src/util/virsocketaddr.c | 13
When enabling the migration_address option, by default it is
set to 127.0.0.1, but it's not a valid address for migration.
so we should add verification and set the default migration_address
to 0.0.0.0.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/qemu/qemu.conf |
add some check in migration configuration.
Chen Fan (4):
virsocketaddr: return address family in virSocketAddrIsNumeric
migration: add migration_host support for Ipv6 address without
brackets
conf: add virSocketAddrIsLocalhost to Check migration_host
conf: Check migration_address
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
src/libvirt_private.syms | 1 +
src/qemu/qemu_conf.c | 8
src/util/virsocketaddr.c | 35 +++
src/util/virsocketaddr.h | 3 +++
4 files changed, 47 insertions(+)
diff --git
87 matches
Mail list logo
