Re: [libvirt] [PATCH] vbox: remove unused code that causes build failures

2014-11-03 Thread Taowei Luo
Sorry for troubling. I'm checking the release note and just find I missed this. This state existed because it is in the middle of something (say I am rewriting the whole network driver and storage driver for vbox.) And I did forget to remove vbox[0-9][0-9]NetworkDriver since we don't need it any

Re: [libvirt] [PATCH v2 2/2] qemu: avoid rare race when undefining domain

2014-11-03 Thread Michal Privoznik
On 31.10.2014 15:47, Martin Kletzander wrote: When one domain is being undefined and at the same time started, for example, there is a possibility of a rare problem occuring. - Thread 1 does virDomainUndefine(), has the lock, checks that the domain is active and because it's not, calls

[libvirt] Release of libvirt-python-1.2.10

2014-11-03 Thread Daniel Veillard
I also tagged and pushed a new version of libvirt-python, it is available at: ftp://libvirt.org/libvirt/python it handle the new header split in libvirt-1.2.10 and fixes a number of issues: Documentation: d Change the comment in getPyNodeCPUCount method reflecting correct called methods

Re: [libvirt] [PATCH v2 2/2] qemu: avoid rare race when undefining domain

2014-11-03 Thread Martin Kletzander
On Mon, Nov 03, 2014 at 09:54:09AM +0100, Michal Privoznik wrote: On 31.10.2014 15:47, Martin Kletzander wrote: When one domain is being undefined and at the same time started, for example, there is a possibility of a rare problem occuring. - Thread 1 does virDomainUndefine(), has the lock,

Re: [libvirt] [v5][Patch 0/4] Libvirt CPU enhancements for Power KVM

2014-11-03 Thread Michal Privoznik
On 31.10.2014 10:15, Prerna Saxena wrote: This patch series is a collection of enhancements for PowerPC CPUs on PowerKVM. In this iteration, I have followed Dan's suggestion on using existing cpu mode format to describe powerPC compatibility mode. Hope this can finally make it for 1.2.10 !

Re: [libvirt] [v5][PATCH 2/4] PowerPC : Add support for launching VMs in 'compat' mode.

2014-11-03 Thread Michal Privoznik
On 31.10.2014 10:51, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Tue, 28 Oct 2014 15:05:59 +0530 PowerISA allows processors to run VMs in binary compatibility (compat) mode supporting an older version of ISA. QEMU has recently added support to explicitly denote a

Re: [libvirt] [v5][PATCH 4/4] docs: Add documentation for compat mode.

2014-11-03 Thread Michal Privoznik
On 31.10.2014 10:54, Prerna Saxena wrote: From dd917ef27269bc3a9af2294212b088f838792315 Mon Sep 17 00:00:00 2001 From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Fri, 31 Oct 2014 15:13:16 +0530 Subject: [PATCH 4/4] docs: Add documentation for compat mode. Add documentation to explain how

Re: [libvirt] [PATCH] mingw: fix build failure

2014-11-03 Thread Martin Kletzander
On Sat, Nov 01, 2014 at 01:36:24AM +0100, Pavel Hrdina wrote: On 10/31/2014 11:50 PM, Eric Blake wrote: On 10/31/2014 12:13 PM, Pavel Hrdina wrote: This macro seems to be defined only on linux/unix and it fails during mingw build. Its value is '16' (taken from net/if.h) so define it if it's

Re: [libvirt] [PATCH] network: Add bandwidth support to ethernet interface

2014-11-03 Thread Michal Privoznik
On 30.10.2014 00:56, Anirban Chakraborty wrote: Ethernet interfaces in libvirt currently do not support bandwidth setting. For example, following xml file for an interface will not apply these settings to corresponding qdiscs. interface type=ethernet mac address=02:36:1d:18:2a:e4/

Re: [libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-11-03 Thread Ján Tomko
On 11/03/2014 05:22 AM, weiwei li wrote: mig-nbd is initialized by qemuMigrationCookieXMLParse(called by qemuMigrationEatCookie),with a condition that the nbd infomation contained in Cookie string. I found in debug info that qemuMigrationStartNBDServer had been called in

[libvirt] [PATCH] qemu: Update fsfreeze status on domain state transitions

2014-11-03 Thread Michal Privoznik
As of b6d4dad1 (1.2.5) libvirt keeps track if domain disks have been frozen. However, this falls into that set of information which don't survive domain restart. Therefore, we need to clear the flag upon some state transitions. Moreover, once we clear the flag we must update the status file too.

Re: [libvirt] [[PATCH libvirt-java]] Implement Connect.listAllDomains

2014-11-03 Thread Cedric Bosdonnat
Hello Claudio, On Fri, 2014-10-31 at 23:40 +0100, Claudio Bley wrote: At Sat, 25 Oct 2014 16:25:48 -0700, Cédric Bosdonnat wrote: I'd prefer an enum instead of these (ugly) constants. As a side node, these constants are useless since the ListAllDomainsFlags is not public. Ok, I mimicked

[libvirt] [PATCH 1/4] video: cleanup usage of vram attribute and update documentation

2014-11-03 Thread Pavel Hrdina
The vram attribute was introduced to set the video memory but it is usable only for few hypervisors excluding QEMU/KVM. QEMU/KVM has different attribute for this purpose vgamem_mb and it will be introduced lately. The correct usage of vram is to set the video memory for other hypervisors or to

[libvirt] [PATCH 3/4] caps: introduce new qemu capability for vgamem_mb device property

2014-11-03 Thread Pavel Hrdina
Allow setting vgamem size for video devices. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/qemu/qemu_capabilities.c | 41 src/qemu/qemu_capabilities.h | 5 +

[libvirt] [PATCH 2/4] qxl: fix setting ram and vram values for qemu qxl device

2014-11-03 Thread Pavel Hrdina
QEMU has two different type of QXL display device. The first qxl-vga is for primary video device and second qxl is for secondary video device. There are also two different ways how to specify those devices on qemu command line, the first one and obsolete is using -vga option and the current new

[libvirt] [PATCH 4/4] qemu-command: introduce new vgamem attribute for video devices

2014-11-03 Thread Pavel Hrdina
So far we hadn't any option to set video memory size for qemu video devices. There were only vram (ram for QXL) attribute but it was valid only for QXL video device, but it didn't set video memory only pci bar memory. To provide this feature to users qemu has dedicated device attribute called

[libvirt] [PATCH 0/4] [RFE] introduce new vgamem attribute for video devices

2014-11-03 Thread Pavel Hrdina
This patch series fixes few issues with vram and ram attributes for video devices and introduces new vgamem attribute to allow setting up video memory size for QEMU video devices. Pavel Hrdina (4): video: cleanup usage of vram attribute and update documentation qxl: fix setting ram and vram

Re: [libvirt] [PATCH v4 1/3] bitmap: add virBitmapLastSetBit for finding the last bit position of bitmap

2014-11-03 Thread Martin Kletzander
On Thu, Oct 30, 2014 at 01:44:17PM +0800, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 45 + src/util/virbitmap.h | 3 +++ tests/virbitmaptest.c| 13

Re: [libvirt] [PATCH v4 0/3] add nodeset check in numatune

2014-11-03 Thread Martin Kletzander
On Thu, Oct 30, 2014 at 01:44:16PM +0800, Chen Fan wrote: when setting elements memnode and nodeset in attribute numatune more than the host nodes in XML file, VM boot should fail. so add check for that. You should run make syntax-check and make check on those patches, it would find at least

Re: [libvirt] [PATCH v4 3/3] virnuma: use virNumaNodesetIsAvailable checking nodeset in virNumaSetupMemoryPolicy

2014-11-03 Thread Martin Kletzander
On Thu, Oct 30, 2014 at 01:44:19PM +0800, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virnuma.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/src/util/virnuma.c b/src/util/virnuma.c index 4188ef5..613a43c 100644

Re: [libvirt] [PATCH v4 2/3] numatune: add check for numatune nodeset range

2014-11-03 Thread Martin Kletzander
On Thu, Oct 30, 2014 at 01:44:18PM +0800, Chen Fan wrote: There was no check for 'nodeset' attribute in numatune-related elements. This patch adds validation that any nodeset specified does not exceed maximum host node. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com ---

Re: [libvirt] [Nbd] [Qemu-devel] spec, RFC: TLS support for NBDµ

2014-11-03 Thread Stefan Hajnoczi
On Fri, Oct 31, 2014 at 07:15:08PM +0100, Wouter Verhelst wrote: On Thu, Oct 30, 2014 at 10:40:56AM +, Stefan Hajnoczi wrote: Also, I suggest at least developing a prototype before releasing the specification changes. Issues that were unknown ahead of time might be discovered during

Re: [libvirt] [PATCH] examples: add systemtap script to ease lock debugging

2014-11-03 Thread Michal Privoznik
On 29.10.2014 14:44, Martin Kletzander wrote: As discussed before, this simple script should help with debugging deadlocks, although there are still some caveats. RWLocks are not handled by this and if your deadlock if very racy, it may not lock up when running with this script due to the

[libvirt] [PATCH] vbox: Prevent from registering storage driver with NULL

2014-11-03 Thread Taowei Luo
Since 5892944fc853 the virRegisterStorageDriver may be called with a NULL storageDriver if it failed on vboxGetStorageDriver. So make sure the storageDriver is not NULL before register. --- src/vbox/vbox_driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] vbox: Prevent from registering storage driver with NULL

2014-11-03 Thread Martin Kletzander
On Mon, Nov 03, 2014 at 11:32:41PM +0800, Taowei Luo wrote: Since 5892944fc853 the virRegisterStorageDriver may be called with a NULL storageDriver if it failed on vboxGetStorageDriver. So make sure the storageDriver is not NULL before register. --- src/vbox/vbox_driver.c |2 +- 1 file

Re: [libvirt] [PATCH v4 1/3] bitmap: add virBitmapLastSetBit for finding the last bit position of bitmap

2014-11-03 Thread Chen, Fan
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 01:44:17PM +0800, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 45 +

Re: [libvirt] [PATCH v4 2/3] numatune: add check for numatune nodeset range

2014-11-03 Thread Chen, Fan
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 01:44:18PM +0800, Chen Fan wrote: There was no check for 'nodeset' attribute in numatune-related elements. This patch adds validation that any nodeset specified does not exceed maximum host node.

Re: [libvirt] [PATCH v4 3/3] virnuma: use virNumaNodesetIsAvailable checking nodeset in virNumaSetupMemoryPolicy

2014-11-03 Thread Chen, Fan
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 01:44:19PM +0800, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virnuma.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git

Re: [libvirt] [PATCH v4 0/3] add nodeset check in numatune

2014-11-03 Thread Chen, Fan
On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 01:44:16PM +0800, Chen Fan wrote: when setting elements memnode and nodeset in attribute numatune more than the host nodes in XML file, VM boot should fail. so add check for that. You should run make

[libvirt] [PATCH v5 2/3] numatune: add check for numatune nodeset range

2014-11-03 Thread Chen Fan
There was no check for 'nodeset' attribute in numatune-related elements. This patch adds validation that any nodeset specified does not exceed maximum host node. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/conf/numatune_conf.c | 28

[libvirt] [PATCH v5 0/3] add nodeset check in numatune

2014-11-03 Thread Chen Fan
when setting elements memnode and nodeset in attribute numatune more than the host nodes in XML file, VM boot should fail. so add check for that. Chen Fan (3): bitmap: add virBitmapLastSetBit for finding the last bit position of bitmap numatune: add check for numatune nodeset range

[libvirt] [PATCH v5 1/3] bitmap: add virBitmapLastSetBit for finding the last bit position of bitmap

2014-11-03 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/libvirt_private.syms | 1 + src/util/virbitmap.c | 45 + src/util/virbitmap.h | 3 +++ tests/virbitmaptest.c| 13 - 4 files changed, 61 insertions(+), 1 deletion(-)

[libvirt] [PATCH v5 3/3] virnuma: use virNumaNodesetIsAvailable checking nodeset in virNumaSetupMemoryPolicy

2014-11-03 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virnuma.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/util/virnuma.c b/src/util/virnuma.c index 2540bd2..89435de 100644 --- a/src/util/virnuma.c +++ b/src/util/virnuma.c @@ -98,16 +98,13

Re: [libvirt] [PATCH 2/2] qemu: migration: Ignore null ptr in qemuMigrationStopNBDServer

2014-11-03 Thread weiwei li
agree,I have tested the flag and it works well, i will post another patch later. Thanks very much! 2014-11-03 20:03 GMT+08:00 Ján Tomko jto...@redhat.com: On 11/03/2014 05:22 AM, weiwei li wrote: mig-nbd is initialized by qemuMigrationCookieXMLParse(called by qemuMigrationEatCookie),with a

[libvirt] [PATCH] qemu: fix up NBD Server can not be stopped properly

2014-11-03 Thread weiwei li
In qemuMigrationFinish mig-nbd can not be initialized by qemuMigrationEatCookie without a flag QEMU_MIGRATION_COOKIE_NBD. That cause qemuMigrationStopNBDServer return and the NBD server can not be stopped properly. Signed-off-by: Weiwei Li nuonu...@tencent.com Signed-off-by: Ján Tomko

Re: [libvirt] [PATCH v4 3/3] virnuma: use virNumaNodesetIsAvailable checking nodeset in virNumaSetupMemoryPolicy

2014-11-03 Thread Martin Kletzander
On Tue, Nov 04, 2014 at 02:05:16AM +, Chen, Fan wrote: On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 01:44:19PM +0800, Chen Fan wrote: Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- src/util/virnuma.c | 23 --- 1 file

Re: [libvirt] [PATCH v4 2/3] numatune: add check for numatune nodeset range

2014-11-03 Thread Martin Kletzander
On Tue, Nov 04, 2014 at 01:57:52AM +, Chen, Fan wrote: On Mon, 2014-11-03 at 14:18 +0100, Martin Kletzander wrote: On Thu, Oct 30, 2014 at 01:44:18PM +0800, Chen Fan wrote: diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c index bff3b0f..7218747 100644 ---

Re: [libvirt] [PATCH v5 0/3] add nodeset check in numatune

2014-11-03 Thread Martin Kletzander
On Tue, Nov 04, 2014 at 10:44:38AM +0800, Chen Fan wrote: when setting elements memnode and nodeset in attribute numatune more than the host nodes in XML file, VM boot should fail. so add check for that. ACK Pushed, thank you for the patches. Martin Chen Fan (3): bitmap: add

[libvirt] [PATCH] domain: Improve error output for virDomainListGetStats

2014-11-03 Thread Luyao Huang
When pass flags --domain and --list-* to cmdDomstats, a unsupport error will output from qemuConnectGetAllDomainStats. error: unsupported flags (0x1) in function qemuConnectGetAllDomainStats From manual of virsh: The approaches can't be combined. Improve error to: error: --domain and --list-*