On Mon, Jul 11, 2016 at 09:55:01PM -0600, Eric Blake wrote:
> The old 32-bit-only mingw project had a mismatch in its
> that omitted ssize_t, but where size_t was a different rank than
> int. But now that mingw64 (both 32- and 64-bit) is the more
> popular platform (Fedora has dropped mingw in
On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote:
> We can't mock tests on Mingw, which lacks dlopen() and friends;
> follow the paradigms used in other mock files of conditionally
> compiling nothing when not building for Linux.
>
> Signed-off-by: Eric Blake
> ---
>
On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote:
We can't mock tests on Mingw, which lacks dlopen() and friends;
follow the paradigms used in other mock files of conditionally
compiling nothing when not building for Linux.
Signed-off-by: Eric Blake
---
On Tue, Jul 12, 2016 at 04:28:22PM +0800, Luyao Huang wrote:
In commit ec5dcf2a and b0b4a35c, we have moved some xml to
new directories, but forget fix the Makefile. Add 2 directories
in EXTRA_DIST to fix broken vpath build.
Signed-off-by: Luyao Huang
---
tests/Makefile.am |
On 07/12/2016 05:41 PM, Martin Kletzander wrote:
On Tue, Jul 12, 2016 at 04:28:22PM +0800, Luyao Huang wrote:
In commit ec5dcf2a and b0b4a35c, we have moved some xml to
new directories, but forget fix the Makefile. Add 2 directories
in EXTRA_DIST to fix broken vpath build.
Signed-off-by:
In commit ec5dcf2a and b0b4a35c, we have moved some xml to
new directories, but forget fix the Makefile. Add 2 directories
in EXTRA_DIST to fix broken vpath build.
Signed-off-by: Luyao Huang
---
tests/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Tue, Jul 12, 2016 at 11:27:43AM +0200, Martin Kletzander wrote:
> On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote:
> > We can't mock tests on Mingw, which lacks dlopen() and friends;
> > follow the paradigms used in other mock files of conditionally
> > compiling nothing when not
On Mon, Jul 11, 2016 at 07:06:04PM +0200, Michal Privoznik wrote:
In an unlikely event of execve() failing, the virCommandExec()
function does not report any error, even though checks that are
at the beginning of the function are verbose when failing.
Signed-off-by: Michal Privoznik
Currently the QEMU processes inherit their core dump rlimit
from libvirtd, which is really suboptimal. This change allows
their limit to be directly controller from qemu.conf instead.
---
Changed in v2:
- Allow use of string "unlimited"
src/libvirt_private.syms | 2 ++
On Mon, Jul 11, 2016 at 10:25:27PM +0200, Tomasz Flendrich wrote:
The file tests/qemuhotplugtestdevices/qemuhotplug-ccw-virtio-2-explicit.xml
should have an endline at the end to pass the syntax-check.
Should I post the patch again with that fixed, or it’s okay? I don’t know how
such minor
On Mon, Jul 11, 2016 at 03:22:44PM -0300, Julio Faracco wrote:
> This commit introduces the virHookCheck() before running the command (hook).
> The virHookCheck() before virCommandRun() will avoid errors with changes
> (removal and other permissions changes) in the hook file, while the libvirt
>
On Mon, Jul 11, 2016 at 05:35:03PM -0600, Jim Fehlig wrote:
> At least with systemd v210, NOTIFY_SOCKET is abstact, e.g.
> @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket
> with "Connection refused". The unix(7) man page contains the following
> details wrt abstract socket
On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote:
Currently the QEMU processes inherit their core dump rlimit
from libvirtd, which is really suboptimal. This change allows
their limit to be directly controller from qemu.conf instead.
---
Changed in v2:
- Allow use of string
On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote:
> On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote:
> > Currently the QEMU processes inherit their core dump rlimit
> > from libvirtd, which is really suboptimal. This change allows
> > their limit to be directly
On Tue, Jul 12, 2016 at 10:45:12AM +0100, Daniel P. Berrange wrote:
On Tue, Jul 12, 2016 at 11:27:43AM +0200, Martin Kletzander wrote:
On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote:
> We can't mock tests on Mingw, which lacks dlopen() and friends;
> follow the paradigms used in
On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote:
> MinGW complained that we might be dereferencing a NULL pointer. While
^^ Does anybody use that?
> that's most probably not going to be true (now), the logic certainly
> allows for that and we might actually do this a lot in the
On Tue, Jul 12, 2016 at 12:53:18PM +0200, Martin Kletzander wrote:
> On Tue, Jul 12, 2016 at 10:56:53AM +0100, Daniel P. Berrange wrote:
> > On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote:
> > > On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote:
> > > >
MinGW complained that we might be dereferencing a NULL pointer. While
that's most probably not going to be true (now), the logic certainly
allows for that and we might actually do this a lot in the future with
sparse vcpu mapping.
../../src/conf/domain_conf.c: In function
On Mon, Jun 27, 2016 at 06:03:38PM +0300, Olga Krishtal wrote:
The modification of .volWipe callback wipes ploop volume using one of
given wiping algorithm: dod, nnsa, etc.
However, in case of ploop volume we need to reinitialize root.hds and
DiskDescriptor.xml.
v2:
- added check on ploop
These are a few simple and one complex testcases.
The simple ones test attaching and detaching ccw devices
with both implicitly and explicitly stated addresses.
In the complex one, attaching and detaching a device
should make the address free to reuse.
I have plan to rework the address handling,
On 13.07.2016 06:39, Yan Fu wrote:
> Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1354238
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index f8d9afe..55a5404 100644
> ---
Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1354238
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f8d9afe..55a5404 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@
On 07/12/2016 02:05 AM, Daniel P. Berrange wrote:
> On Mon, Jul 11, 2016 at 09:55:01PM -0600, Eric Blake wrote:
>> The old 32-bit-only mingw project had a mismatch in its
>> that omitted ssize_t, but where size_t was a different rank than
>> int. But now that mingw64 (both 32- and 64-bit) is the
The systemd-machined tools libvirt uses were split into a
systemd-container RPM. Without depending on this, libvirt
may silently fallback to the non-systemd cgroup impl which
is not desirable.
Signed-off-by: Daniel P. Berrange
---
libvirt.spec.in | 6 ++
1 file changed,
On Thu, 2016-06-30 at 11:04 +0200, Andrea Bolognani wrote:
> Does something like the following look reasonable? If it
> does, I'll take care of submitting it.
>
> name: libvirt
> desc: The virtualization API
> site: https://libvirt.org/
> tags:
> - api
> - c
> - cross-platform
> - library
> - oss
On 07/01/2016 07:37 AM, Cole Robinson wrote:
> This series reworks test:///default open handling to use the same
> XML parsing helpers that a non-default test://$PATH open uses.
> Saves some code, and makes it easier to extend test:///default,
> for example in patch #4 which we want for testing
On Sat, Jul 09, 2016 at 11:02 AM +0200, Michal Privoznik
wrote:
> On 06.07.2016 15:47, Marc Hartmayer wrote:
>> The virDomainGetCPUStats() API contract permits nparams ==
>> 0. print_cpu_usage() assumes nparams > 0 because the domtop example
>> application isn't very useful
On Tue, Jul 12, 2016 at 10:56:53AM +0100, Daniel P. Berrange wrote:
On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote:
On Tue, Jul 12, 2016 at 10:12:36AM +0100, Daniel P. Berrange wrote:
> Currently the QEMU processes inherit their core dump rlimit
> from libvirtd, which is
I hit an interesting failure on my 32-bit F24 machine:
In file included from ../../src/util/virconf.c:32:0:
../../src/util/virconf.c: In function 'virConfGetValueSSizeT':
../../src/util/virconf.c:1269:26: error: format '%zd' expects argument
of type 'signed size_t', but argument 9 has type 'long
On 07/12/2016 03:27 AM, Martin Kletzander wrote:
> On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote:
>> We can't mock tests on Mingw, which lacks dlopen() and friends;
>> follow the paradigms used in other mock files of conditionally
>> compiling nothing when not building for Linux.
>>
On Tue, Jul 12, 2016 at 01:36:37PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 12, 2016 at 12:53:18PM +0200, Martin Kletzander wrote:
On Tue, Jul 12, 2016 at 10:56:53AM +0100, Daniel P. Berrange wrote:
> On Tue, Jul 12, 2016 at 11:38:22AM +0200, Martin Kletzander wrote:
> > On Tue, Jul 12,
On 12.07.2016 13:49, Marc Hartmayer wrote:
> On Sat, Jul 09, 2016 at 11:02 AM +0200, Michal Privoznik
> wrote:
>> On 06.07.2016 15:47, Marc Hartmayer wrote:
>>> The virDomainGetCPUStats() API contract permits nparams ==
>>> 0. print_cpu_usage() assumes nparams > 0 because
On Tue, Jul 12, 2016 at 03:01:57PM +0200, Peter Krempa wrote:
On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote:
MinGW complained that we might be dereferencing a NULL pointer. While
^^ Does anybody use that?
Well, if nobody uses that, feel free to send a patch removing all
On 12.07.2016 05:20, Tomáš Golembiovský wrote:
> When fetching domains with virConnectListAllDomains() and when filtering
> by snapshot existence is requested the ESX driver first lists all the
> domains and then check one-by-one for snapshot existence. This process
> takes unnecessarily long
On Tue, Jul 12, 2016 at 17:54:03 +0200, Martin Kletzander wrote:
> On Tue, Jul 12, 2016 at 03:01:57PM +0200, Peter Krempa wrote:
> >On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote:
[...]
> >> I could've pushed this as a build breaker, but I'm not really sure
> >> everyone will
At least with systemd v210, NOTIFY_SOCKET is abstact, e.g.
@/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket
with "Connection refused". The unix(7) man page contains the following
details wrt abstract socket addresses
abstract: an abstract socket address is distinguished (from a
Daniel P. Berrange wrote:
> On Mon, Jul 11, 2016 at 05:35:03PM -0600, Jim Fehlig wrote:
>> At least with systemd v210, NOTIFY_SOCKET is abstact, e.g.
>> @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket
>> with "Connection refused". The unix(7) man page contains the following
>>
On Tue, Jul 12, 2016 at 06:24:01PM +0200, Peter Krempa wrote:
On Tue, Jul 12, 2016 at 17:54:03 +0200, Martin Kletzander wrote:
On Tue, Jul 12, 2016 at 03:01:57PM +0200, Peter Krempa wrote:
>On Tue, Jul 12, 2016 at 13:44:10 +0200, Martin Kletzander wrote:
[...]
>> I could've pushed this as a
On Tue, Jul 12, 2016 at 11:07:10AM -0600, Jim Fehlig wrote:
> At least with systemd v210, NOTIFY_SOCKET is abstact, e.g.
> @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket
> with "Connection refused". The unix(7) man page contains the following
> details wrt abstract socket
Daniel P. Berrange wrote:
> On Tue, Jul 12, 2016 at 11:07:10AM -0600, Jim Fehlig wrote:
>> At least with systemd v210, NOTIFY_SOCKET is abstact, e.g.
>> @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket
>> with "Connection refused". The unix(7) man page contains the following
>>
40 matches
Mail list logo