[libvirt] [PATCH] Allow saving QEMU libvirt state to a pipe

All, Currently the "virsh save" command opens a file to save a domain's XML and memory state, does the save, and then re-opens the file to simulate seeking to the beginning to update the header to indicate that the file is complete. For pipes this is not possible, attempting to re-open

Re: [libvirt] [systemd-devel] How to make udev not touch my device?

Hello Michal, Michal Privoznik [2016-11-04 8:47 +0100]: > That means that whenever a VM is being started up, libvirtd (our > daemon we have) relabels all the necessary paths that QEMU process > (representing VM) can touch. Does that mean it's shipping an udev rule that does that? Or actually

Re: [libvirt] [PATCH 2/5] s390: Report blank host model instead of "host"

On Fri, Nov 04, 2016 at 11:00:29 -0400, Jason J. Herne wrote: > On 11/03/2016 08:54 AM, Jiri Denemark wrote: > > On Wed, Nov 02, 2016 at 16:34:32 -0400, Jason J. Herne wrote: > >> From: "Collin L. Walling" > >> > >> On s390 , the host's features are heavily influenced

[libvirt] [PATCH] vshReadlineParse: Remove unused variable

After 06a7b1ff4 the @_need_arg is not used anywhere. Well, it is set but never read: vsh.c: In function 'vshReadlineParse': vsh.c:2658:14: warning: variable 'opts_need_arg' set but not used [-Wunused-but-set-variable] uint64_t opts_need_arg, opts_seen; ^

Re: [libvirt] [PATCH v3] [glib 5/5] gconfig, tests: Add test case for unknown devices

On Thu, Nov 3, 2016 at 4:31 PM, Christophe Fergeau wrote: > On Thu, Nov 03, 2016 at 02:40:58PM +0100, Zeeshan Ali wrote: >> --- >> tests/test-gconfig.c| 24 >> tests/xml/gconfig-domain-device-unknown.xml | 5 + >> 2 files

Re: [libvirt] [libvirt-glib] tests: Don't leak xml data in test-gconfig-device-unknown

On Fri, Nov 04, 2016 at 11:15:01AM +0100, Christophe Fergeau wrote: > --- > tests/test-gconfig.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c > index 9cf3f12..2c98c25 100644 > --- a/tests/test-gconfig.c > +++ b/tests/test-gconfig.c > @@

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Fri, Nov 04, 2016 at 09:43:00AM +0100, Erik Skultety wrote: On Thu, Nov 03, 2016 at 04:13:11PM +, Daniel P. Berrange wrote: On Thu, Nov 03, 2016 at 03:25:55PM +, Daniel P. Berrange wrote: > > The bluriness is caused by inkscape anti-aliasing the font when > exporting the SVG to PNG.

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Fri, Nov 04, 2016 at 11:44:03AM +0100, Martin Kletzander wrote: > On Fri, Nov 04, 2016 at 09:43:00AM +0100, Erik Skultety wrote: > > On Thu, Nov 03, 2016 at 04:13:11PM +, Daniel P. Berrange wrote: > > > On Thu, Nov 03, 2016 at 03:25:55PM +, Daniel P. Berrange wrote: > > > > > > > > The

Re: [libvirt] [PATCH] docs: Add Qt Virtual machines manager and Qt Remote viewer

On 03.11.2016 13:44, Alexander Vasilenko wrote: > --- > docs/apps.html.in | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/docs/apps.html.in b/docs/apps.html.in > index 1a138b3..4efb318 100644 > --- a/docs/apps.html.in > +++ b/docs/apps.html.in > @@ -208,6 +208,17 @@ >

[libvirt] [libvirt-glib] tests: Don't leak xml data in test-gconfig-device-unknown

--- tests/test-gconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index 9cf3f12..2c98c25 100644 --- a/tests/test-gconfig.c +++ b/tests/test-gconfig.c @@ -782,6 +782,7 @@ static void test_domain_device_unknown(void)

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Fri, Nov 04, 2016 at 09:43:00AM +0100, Erik Skultety wrote: > On Thu, Nov 03, 2016 at 04:13:11PM +, Daniel P. Berrange wrote: > > On Thu, Nov 03, 2016 at 03:25:55PM +, Daniel P. Berrange wrote: > > > > > > The bluriness is caused by inkscape anti-aliasing the font when > > > exporting

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Fri, Nov 04, 2016 at 10:17:18AM +0100, Peter Krempa wrote: > > The bigger change is in the layout, with the huge > > left hand sitemap nav bar being removed to give more > > space to the main content. The front page now directly > > links to the key pages that were shown to be highly > >

Re: [libvirt] [PATCH 6/8] qemu: Unify cached caps validity checks

On Thu, Nov 03, 2016 at 16:37:59 +0100, Pavel Hrdina wrote: > On Wed, Nov 02, 2016 at 10:22:35AM +0100, Jiri Denemark wrote: > > Let's keep all run time validation of cached QEMU capabilities in > > virQEMUCapsIsValid and call it whenever we access the cache. > > virQEMUCapsInitCached should keep

Re: [libvirt] [PATCH 5/8] qemu: Store loaded QEMU binary ctime in qemuCaps

On Thu, Nov 03, 2016 at 16:15:39 +0100, Pavel Hrdina wrote: > On Wed, Nov 02, 2016 at 10:22:34AM +0100, Jiri Denemark wrote: > > virQEMUCapsLoadCache loads QEMU capabilities from a file, but strangely > > enough it returns the loaded QEMU binary ctime in qemuctime parameter > > instead of storing

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Mon, Oct 31, 2016 at 12:41:41 +, Daniel Berrange wrote: > The current libvirt website design dates from 2008 and > has not changed significantly since. Compared to > contemporary open source project websites it looks > pretty dated and cluttered. IMO dated is not that bad. Cluttered is the

Re: [libvirt] [PATCH v2 00/19] Avoid races with udev

On Fri, Nov 04, 2016 at 08:48:06AM +0100, Michal Privoznik wrote: > On 03.11.2016 13:33, Daniel P. Berrange wrote: > > On Thu, Nov 03, 2016 at 08:18:50PM +0800, Michal Privoznik wrote: > >> This is v2 of: > >> > >> https://www.redhat.com/archives/libvir-list/2016-October/msg01151.html > >> > >>

[libvirt] How to make udev not touch my device?

Hey udev developers, I'm a libvirt developer and I've been facing an interesting issue recently. Libvirt is a library for managing virtual machines and as such allows basically any device to be exposed to a virtual machine. For instance, a virtual machine can use /dev/sdX as its own disk. Because

Re: [libvirt] [PATCH] fix parsing security labels from virt-aa-helper

On Thu, Nov 3, 2016 at 6:15 PM, Guido Günther wrote: Thanks for your feedback Guido! On Mon, Oct 31, 2016 at 11:32:44AM +0100, Christian Ehrhardt wrote: > > When parsing labels virt-aa-helper does no more pass > > VIR_DOMAIN_DEF_PARSE_INACTIVE due to dfbc9a83 that tried to

Re: [libvirt] [PATCH v2 00/19] Avoid races with udev

On 03.11.2016 13:33, Daniel P. Berrange wrote: > On Thu, Nov 03, 2016 at 08:18:50PM +0800, Michal Privoznik wrote: >> This is v2 of: >> >> https://www.redhat.com/archives/libvir-list/2016-October/msg01151.html >> >> diff to v1: >> - Added udev rule (patch 18/19) >> - Wire the beast into spec file

Re: [libvirt] [PATCH] vshReadlineParse: Remove unused variable

On Fri, Nov 04, 2016 at 09:58:53 +0100, Michal Privoznik wrote: > After 06a7b1ff4 the @_need_arg is not used anywhere. Well, > it is set but never read: > > vsh.c: In function 'vshReadlineParse': > vsh.c:2658:14: warning: variable 'opts_need_arg' set but not used > [-Wunused-but-set-variable] >

Re: [libvirt] [PATCH 6/8] qemu: Unify cached caps validity checks

On Wed, Nov 02, 2016 at 10:22:35AM +0100, Jiri Denemark wrote: > Let's keep all run time validation of cached QEMU capabilities in > virQEMUCapsIsValid and call it whenever we access the cache. > virQEMUCapsInitCached should keep only the checks which do not make > sense once the cache is loaded

[libvirt] [PATCH] qemu: Allow use of hot plugged host CPUs if no affinity set

Running VMs couldn't use newly hot plugged host CPUs even if the VMs had no CPU pinning defined AND the cpuset controller was disabled in the libvirt qemu configuration. This was because in this case the process affinity was set by libvirt to all currently present host CPUs in order to avoid

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Thu, Nov 03, 2016 at 04:13:11PM +, Daniel P. Berrange wrote: > On Thu, Nov 03, 2016 at 03:25:55PM +, Daniel P. Berrange wrote: > > > > The bluriness is caused by inkscape anti-aliasing the font when > > exporting the SVG to PNG. I'll see if I can find any inkscape > > options to reduce

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On 03.11.2016 17:13, Daniel P. Berrange wrote: > On Thu, Nov 03, 2016 at 03:25:55PM +, Daniel P. Berrange wrote: >> >> The bluriness is caused by inkscape anti-aliasing the font when >> exporting the SVG to PNG. I'll see if I can find any inkscape >> options to reduce this anti-aliasing, or

Re: [libvirt] [PATCH] qemu: Fix build on RHEL-6

On Fri, Nov 04, 2016 at 13:19:28 +0100, Jiri Denemark wrote: > Commit c29e6d4805 cause build failure on RHEL-6: > > ../../src/qemu/qemu_capabilities.c: In function 'virQEMUCapsIsValid': > ../../src/qemu/qemu_capabilities.c:4085: error: declaration of 'ctime' > shadows a global declaration

Re: [libvirt] [PATCH 04/17] docs: add footer to all pages

On Fri, Nov 04, 2016 at 02:19:22PM +0100, Ján Tomko wrote: > On Mon, Oct 31, 2016 at 12:41:45PM +, Daniel P. Berrange wrote: > > Add a footer to all pages containing a blurb about the > > code of conduct, and links to social media sites. > > > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Fri, Nov 04, 2016 at 09:05:49AM -0500, Eric Blake wrote: > On 10/31/2016 07:41 AM, Daniel P. Berrange wrote: > > The libvirt logo used a specific font with angled tops > > to letters like "l", "b" and "t" - this is the "Overpass" > > font, made available by Red Hat under an open source > > font

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On 10/31/2016 07:41 AM, Daniel P. Berrange wrote: > The libvirt logo used a specific font with angled tops > to letters like "l", "b" and "t" - this is the "Overpass" > font, made available by Red Hat under an open source > font license. The re-branding makes use of webfont > support so that we

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Fri, Nov 04, 2016 at 10:17:18AM +0100, Peter Krempa wrote: On Mon, Oct 31, 2016 at 12:41:41 +, Daniel Berrange wrote: The current libvirt website design dates from 2008 and has not changed significantly since. Compared to contemporary open source project websites it looks pretty dated

[libvirt] [PATCH] qemu: Fix build on RHEL-6

Commit c29e6d4805 cause build failure on RHEL-6: ../../src/qemu/qemu_capabilities.c: In function 'virQEMUCapsIsValid': ../../src/qemu/qemu_capabilities.c:4085: error: declaration of 'ctime' shadows a global declaration [-Wshadow] /usr/include/time.h:258: error: shadowed declaration is here

Re: [libvirt] [PATCH 06/17] docs: add page describing contribution to libvirt

On Mon, Oct 31, 2016 at 12:41:47PM +, Daniel P. Berrange wrote: Add a page that describes what contributions libvirt is looking for and how to get involved. Neat. Signed-off-by: Daniel P. Berrange --- docs/contribute.html.in | 140

[libvirt] [PATCH 2/2] qemuDomainAttachNetDevice: Enable multiqueue for vhost-user

https://bugzilla.redhat.com/show_bug.cgi?id=1386976 We have everything ready. Actually the only limitation was our check that denied hotplug of vhost-user. Signed-off-by: Michal Privoznik --- src/qemu/qemu_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[libvirt] [PATCH 1/2] qemuDomainAttachNetDevice: Don't overwrite error on rollback

If there is an error hotpluging a net device (for whatever reason) a rollback operation is performed. However, whilst doing so various helper functions that are called report errors on their own. This results in the original error to be overwritten and thus misleading the user. Signed-off-by:

Re: [libvirt] [PATCH 00/17] Redo website layout and branding

On Fri, Nov 04, 2016 at 12:09:30PM +0100, Martin Kletzander wrote: > On Fri, Nov 04, 2016 at 10:17:18AM +0100, Peter Krempa wrote: > > On Mon, Oct 31, 2016 at 12:41:41 +, Daniel Berrange wrote: > > > The current libvirt website design dates from 2008 and > > > has not changed significantly

Re: [libvirt] [PATCH 12/17] docs: expand downloads page to cover all modules

On Mon, Oct 31, 2016 at 12:41:53PM +, Daniel P. Berrange wrote: Previously the download page only covered the main libvirt module and the app dev guide. Expand it to provide direct links to all artifacts published by the project, whether the main library, language bindings, docs, or testing.

[libvirt] [PATCH 0/2] Allow hotplug of vhost-mq

Basically this is trivial. Everything is prepared and the only thing that prevented us from doing this was missing exception in one check. Trivial. Michal Privoznik (2): qemuDomainAttachNetDevice: Don't overwrite error on rollback qemuDomainAttachNetDevice: Enable multiqueue for vhost-user

Re: [libvirt] [PATCH 04/17] docs: add footer to all pages

On Mon, Oct 31, 2016 at 12:41:45PM +, Daniel P. Berrange wrote: Add a footer to all pages containing a blurb about the code of conduct, and links to social media sites. Signed-off-by: Daniel P. Berrange --- docs/libvirt.css | 44

Re: [libvirt] [PATCH 2/5] s390: Report blank host model instead of "host"

On 11/03/2016 08:54 AM, Jiri Denemark wrote: On Wed, Nov 02, 2016 at 16:34:32 -0400, Jason J. Herne wrote: From: "Collin L. Walling" On s390 , the host's features are heavily influenced by not only the host hardware but also by hardware microcode level, host OS

Re: [libvirt] [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

Eduardo Habkost writes: > (CCing libvirt people, as I forgot to CC them) > > On Mon, Oct 31, 2016 at 03:07:23PM +0100, Igor Mammedov wrote: >> On Fri, 28 Oct 2016 23:48:06 -0200 >> Eduardo Habkost wrote: >> >> > When an abstract class is used on

Re: [libvirt] [Qemu-devel] [PATCH v4 7/8] qmp: Support abstract classes on device-list-properties

On Fri, Nov 04, 2016 at 04:45:17PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > (CCing libvirt people, as I forgot to CC them) > > > > On Mon, Oct 31, 2016 at 03:07:23PM +0100, Igor Mammedov wrote: > >> On Fri, 28 Oct 2016 23:48:06 -0200 > >> Eduardo

[libvirt] [PATCH glib] Add missing dep on intltool

Libvirt-glib requires intltool at build time. Previously it was pulled in transitively via another RPM dependancy. As of Fedora 26, this no longer happens, exposing the missing RPM dep. Signed-off-by: Daniel P. Berrange --- Pushed as a build fix for rawhide

[libvirt] ANNOUNCE: libvirt-glib release 1.0.0

I am pleased to announce that a new release of the libvirt-glib package, version 1.0.0, is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) Changes in this release: - Switch to

[libvirt] [PATCH] Unbreak rebuilding docs with release tarballs

Release tarballs ship the include/libvirt/libvirt-common.h. when srcdir != builddir we end up including libvirt-common.h twice: from $top_srcdir/include/libvirt-common.h and from $builddir/include/libvirt-common.h leading to function virTypedParamsGetUInt from