[libvirt] [PATCH] docs: link to news file and other resources

2016-12-14 Thread Daniel P. Berrange
In the website reorg we accidentally lost all links to the nice reformatted news.html file. Add a link on the front page, and also extend the download page table so that it includes links to API docs and news files for each module (where available) Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Deal with gnutls 3.5.6 regression

2016-12-14 Thread Daniel P. Berrange
Anyone want to review this, if not I'll just claim its a build breaker fix... On Thu, Dec 08, 2016 at 09:56:43AM +, Daniel P. Berrange wrote: > On Mon, Dec 05, 2016 at 12:04:36PM +, Daniel P. Berrange wrote: > > I was not originally planning to do anything for the gnutls 3.5.6 > >

Re: [libvirt] [PATCH jenkins-ci] Add libvirt-go to build

2016-12-14 Thread Daniel P. Berrange
On Wed, Dec 14, 2016 at 11:44:54AM +0100, Michal Privoznik wrote: > On 14.12.2016 11:27, Daniel P. Berrange wrote: > > Signed-off-by: Daniel P. Berrange > > --- > > jobs/go.yaml | 71 > > > >

[libvirt] [PATCH jenkins-ci] Add libvirt-go to build

2016-12-14 Thread Daniel P. Berrange
Signed-off-by: Daniel P. Berrange --- jobs/go.yaml | 71 projects/libvirt-go.yaml | 14 ++ 2 files changed, 85 insertions(+) create mode 100644 jobs/go.yaml create mode 100644 projects/libvirt-go.yaml

[libvirt] [PATCH] docs: Use href_base in absolute links

2016-12-14 Thread Martin Kletzander
That way all links work even if you click them in a subdirectory. Signed-off-by: Martin Kletzander --- docs/page.xsl | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/page.xsl b/docs/page.xsl index fcb51916ce25..1d662c670686 100644 ---

Re: [libvirt] [PATCH] Deal with gnutls 3.5.6 regression

2016-12-14 Thread Ján Tomko
On Wed, Dec 14, 2016 at 09:15:12AM +, Daniel P. Berrange wrote: Anyone want to review this, if not I'll just claim its a build breaker fix... On Thu, Dec 08, 2016 at 09:56:43AM +, Daniel P. Berrange wrote: On Mon, Dec 05, 2016 at 12:04:36PM +, Daniel P. Berrange wrote: > I was not

Re: [libvirt] [PATCH] Deal with gnutls 3.5.6 regression

2016-12-14 Thread Daniel P. Berrange
On Wed, Dec 14, 2016 at 11:01:10AM +0100, Ján Tomko wrote: > On Wed, Dec 14, 2016 at 09:15:12AM +, Daniel P. Berrange wrote: > > Anyone want to review this, if not I'll just claim its a build > > breaker fix... > > > > On Thu, Dec 08, 2016 at 09:56:43AM +, Daniel P. Berrange wrote: > > >

[libvirt] [PATCH v1] libxl: reverse defaults on HVM net device attach

2016-12-14 Thread Joao Martins
libvirt libxl picks its own default with respect to the default NIC to use. libxlMakeNic is the one responsible for this and on boot it picks LIBXL_NIC_TYPE_VIF_IOEMU for HVM domains such that it accomodates both PV and emulated one. The good behaving guest at boot will then select the pv and

Re: [libvirt] [PATCH] Deal with gnutls 3.5.6 regression

2016-12-14 Thread Michal Privoznik
On 14.12.2016 11:17, Daniel P. Berrange wrote: > On Wed, Dec 14, 2016 at 11:01:10AM +0100, Ján Tomko wrote: >> On Wed, Dec 14, 2016 at 09:15:12AM +, Daniel P. Berrange wrote: >>> Anyone want to review this, if not I'll just claim its a build >>> breaker fix... >>> >>> On Thu, Dec 08, 2016 at

Re: [libvirt] [PATCH jenkins-ci] Add libvirt-go to build

2016-12-14 Thread Michal Privoznik
On 14.12.2016 11:27, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > jobs/go.yaml | 71 > > projects/libvirt-go.yaml | 14 ++ > 2 files changed, 85 insertions(+) > create mode 100644

Re: [libvirt] [PATCH] docs: Use href_base in absolute links

2016-12-14 Thread Daniel P. Berrange
On Wed, Dec 14, 2016 at 11:55:35AM +0100, Martin Kletzander wrote: > That way all links work even if you click them in a subdirectory. > > Signed-off-by: Martin Kletzander > --- > docs/page.xsl | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) ACK

[libvirt] [PATCH] Fix running of nosetests on python 3

2016-12-14 Thread Daniel P. Berrange
Previously the way Fedora installed /usr/bin/nosetests allowed it to be invoked with either python 2 or 3. Since Fedora 25 though, it contains a module name that only exists on python 2. So we need to be more intelligent and pick a different nosetests binary per version. Signed-off-by: Daniel P.

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-14 Thread Marcel Apfelbaum
On 12/13/2016 05:15 PM, Benjamin Herrenschmidt wrote: On Tue, 2016-12-13 at 14:25 +0200, Marcel Apfelbaum wrote: Hrm, the suggestion of providing both a vanilla-PCI and PCI-E host bridge came up before. I think one of us spotted a problem with that, but I don't recall what it was now. I guess

Re: [libvirt] [PATCH v2 05/10] admin: Introduce virAdmConnectGetLoggingFilters

2016-12-14 Thread Erik Skultety
On Fri, Dec 09, 2016 at 06:59:57AM -0500, John Ferlan wrote: > > > On 11/25/2016 08:12 AM, Erik Skultety wrote: > > Enable libvirt users to query logging filter settings. > > > > Signed-off-by: Erik Skultety > > --- > > daemon/admin.c | 47 > >

Re: [libvirt] [PATCH V3 2/2] qemu: Allow use of hot plugged host CPUs if no affinity set

2016-12-14 Thread Viktor Mihajlovski
On 14.12.2016 00:27, John Ferlan wrote: > > > On 11/25/2016 08:57 AM, Viktor Mihajlovski wrote: >> If the cpuset cgroup controller is disabled in /etc/libvirt/qemu.conf >> QEMU virtual machines can in principle use all host CPUs, even if they >> are hot plugged, if they have no explicit CPU

[libvirt] [PATCH] Avoid variable named 'stat'

2016-12-14 Thread Daniel P. Berrange
Using a variable named 'stat' clashes with the system function 'stat()' causing compiler warnings on some platforms cc1: warnings being treated as errors ../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows

Re: [libvirt] [PATCH 0/4] Add generic perf event support

2016-12-14 Thread Nitesh Konkar
On Wed, Dec 14, 2016 at 4:12 AM, John Ferlan wrote: > > > On 12/13/2016 11:01 AM, Nitesh Konkar wrote: > > Add support and documentation for generic > > perf events like bus_cycles, stalled_cycles_frontend, > > stalled_cycles_backend and ref_cpu_cycles. > > > > Nitesh Konkar

[libvirt] [PATCH] libxl: add QED disk format support

2016-12-14 Thread Cédric Bosdonnat
If libxl has QED disk format support, then pass the feature over to the user. --- src/libxl/libxl_conf.c | 11 +++ src/xenconfig/xen_xl.c | 6 ++ 2 files changed, 17 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 288712f65..02945ae1a 100644 ---

[libvirt] [PATCH] virsh:remove the dead code

2016-12-14 Thread sochin jiang
This patch remove the dead code I found. Signed-off-by: sochin jiang --- tools/virsh-domain.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 3a6fa5c..6dae5cc 100644 --- a/tools/virsh-domain.c +++

[libvirt] [PATCH] virjson: Remove const from virJSONValueObjectForeachKeyValue

2016-12-14 Thread Jiri Denemark
Almost none of our virJSONValue*Get* functions accept const virJSONValue pointers and it wouldn't even make sense since we sometimes modify what we get. And because there is no reason for preventing callers of virJSONValueObjectForeachKeyValue from modifying the values they get in each iteration

Re: [libvirt] [PATCH] virsh:remove the dead code

2016-12-14 Thread Erik Skultety
On Thu, Dec 15, 2016 at 05:00:11AM +0800, sochin jiang wrote: > This patch remove the dead code I found. > > Signed-off-by: sochin jiang > --- > tools/virsh-domain.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c >

Re: [libvirt] [PATCH v2 1/2] xenconfig: add default in xenParseXLDisk()'s switches

2016-12-14 Thread Jim Fehlig
On 12/14/2016 09:15 AM, Cédric Bosdonnat wrote: Without a default: case in the switches in xenParseXLDisk(), build would fail with every new disk backend or image format added in libxl, as this is the case in this error: One upshot of the error is we learn about the new feature :-). But yeah,

Re: [libvirt] [PATCH v3 08/21] qemu: Spawn qemu under mount namespace

2016-12-14 Thread Daniel P. Berrange
On Mon, Dec 12, 2016 at 05:52:54PM +0100, Michal Privoznik wrote: > Prime time. When it comes to spawning qemu process and > relabelling all the devices it's going to touch, there's inherent > race with other applications in the system (e.g. udev). Instead > of trying convincing udev to not touch

Re: [libvirt] [PATCH v5 1/2] conf: List only online cpus for virsh vcpupin

2016-12-14 Thread Viktor Mihajlovski
On 14.12.2016 00:57, John Ferlan wrote: > > > On 11/24/2016 04:55 AM, Nitesh Konkar wrote: >> Currently when the vcpu placement is static >> and cpuset is not specified, CPU Affinity >> under virsh vcpupin shows 0..CPUMAX. This >> patchset will result in display of only >> online CPU's under CPU

Re: [libvirt] [PATCH v2 3/5] conf: Make virNetworkIPDefParseXML a little bit saner

2016-12-14 Thread Laine Stump
On 12/13/2016 08:52 AM, Jiri Denemark wrote: Iterating over all child nodes when we only support one instance of each child is pretty weired. And it would even cause memory leaks if more than one element was specified. ACK, but could you also look for dhcp[2]/tftp[2] and log an error if

[libvirt] [PATCH v2 0/2] libxl QED support

2016-12-14 Thread Cédric Bosdonnat
Hi all, Just added on patch before the QED one to add default: cases in xenParseXLDisk to avoid build failures when building on more uptodate xen. Cédric Bosdonnat (2): xenconfig: add default in xenParseXLDisk()'s switches libxl: add QED disk format support src/libxl/libxl_conf.c | 11

[libvirt] [PATCH v2 2/2] libxl: add QED disk format support

2016-12-14 Thread Cédric Bosdonnat
If libxl has QED disk format support, then pass the feature over to the user. --- src/libxl/libxl_conf.c | 11 +++ src/xenconfig/xen_xl.c | 6 ++ 2 files changed, 17 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 288712f65..02945ae1a 100644 ---

[libvirt] [PATCH v2 1/2] xenconfig: add default in xenParseXLDisk()'s switches

2016-12-14 Thread Cédric Bosdonnat
Without a default: case in the switches in xenParseXLDisk(), build would fail with every new disk backend or image format added in libxl, as this is the case in this error: http://logs.test-lab.xenproject.org/osstest/logs/103325/build-amd64-libvirt/5.ts-libvirt-build.log ---

Re: [libvirt] [PATCH v2 4/5] util: Introduce virSocketAddrPTRDomain

2016-12-14 Thread Laine Stump
On 12/13/2016 08:52 AM, Jiri Denemark wrote: The API creates PTR domain which corresponds to a given addr/prefix. Both IPv4 and IPv6 addresses are supported, but the prefix must be divisible by 8 for IPv4 and divisible by 4 for IPv6. The generated PTR domain has the following format IPv4:

Re: [libvirt] [PATCH v1] libxl: reverse defaults on HVM net device attach

2016-12-14 Thread Jim Fehlig
On 12/14/2016 03:53 AM, Joao Martins wrote: libvirt libxl picks its own default with respect to the default NIC to use. libxlMakeNic is the one responsible for this and on boot it picks LIBXL_NIC_TYPE_VIF_IOEMU for HVM domains such that it accomodates both PV and emulated one. The good behaving

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-14 Thread Laine Stump
On 12/14/2016 12:17 PM, Marcel Apfelbaum wrote: On 12/13/2016 06:00 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 04:15:18PM +0200, Marcel Apfelbaum wrote: On 12/13/2016 02:42 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: Quick interface

Re: [libvirt] [PATCH v4 2/4] storage: optimize calls to virStorageFileInit and friends

2016-12-14 Thread Prasanna Kalever
On Mon, Dec 12, 2016 at 9:53 PM, Peter Krempa wrote: > On Mon, Dec 12, 2016 at 20:01:35 +0530, Prasanna Kalever wrote: >> On Wed, Dec 7, 2016 at 9:38 PM, Peter Krempa wrote: >> > On Tue, Dec 06, 2016 at 22:51:59 +0530, Prasanna Kumar Kalever wrote: >> >>

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-14 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Dec 14, 2016 at 04:34:04PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, Dec 13, 2016 at 08:51:34PM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >>

Re: [libvirt] [PATCH v4 4/4] gluster: cache glfs connection object per volume

2016-12-14 Thread Prasanna Kalever
On Mon, Dec 12, 2016 at 8:02 PM, Prasanna Kalever wrote: > On Wed, Dec 7, 2016 at 10:38 PM, Peter Krempa wrote: >> On Tue, Dec 06, 2016 at 22:52:01 +0530, Prasanna Kumar Kalever wrote: >>> Currently, in case if we have 4 extra attached disks, then for

Re: [libvirt] [PATCH v2 2/2] libxl: add QED disk format support

2016-12-14 Thread Jim Fehlig
On 12/14/2016 09:15 AM, Cédric Bosdonnat wrote: If libxl has QED disk format support, then pass the feature over to the user. --- src/libxl/libxl_conf.c | 11 +++ src/xenconfig/xen_xl.c | 6 ++ 2 files changed, 17 insertions(+) diff --git a/src/libxl/libxl_conf.c

Re: [libvirt] [PATCH v4 1/4] util: change the virStorageNetHostDef type

2016-12-14 Thread Prasanna Kalever
On Mon, Dec 12, 2016 at 8:00 PM, Peter Krempa wrote: > On Mon, Dec 12, 2016 at 19:54:47 +0530, Prasanna Kalever wrote: >> On Wed, Dec 7, 2016 at 7:31 PM, Peter Krempa wrote: >> > On Tue, Dec 06, 2016 at 22:51:58 +0530, Prasanna Kumar Kalever wrote: >> >>

Re: [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-14 Thread Marcel Apfelbaum
On 12/14/2016 04:46 AM, David Gibson wrote: On Tue, Dec 13, 2016 at 02:25:44PM +0200, Marcel Apfelbaum wrote: On 12/07/2016 06:42 PM, Andrea Bolognani wrote: [Added Marcel to CC] Hi, Sorry for the late reply. On Wed, 2016-12-07 at 15:11 +1100, David Gibson wrote: Is the difference

[libvirt] [RFC v2] qmp: query-device-slots command

2016-12-14 Thread Eduardo Habkost
This adds a new command to QMP: query-device-slots. It will allow management software to query possible slots where devices can be plugged. This implementation of the command will return: * Multiple PCI slots per bus, in the case of PCI buses; * One slot per bus for the other buses (that don't

Re: [libvirt] [PATCH 2/2] qemu_cgroup: allow access to /dev/dri/render*

2016-12-14 Thread Cole Robinson
On 11/10/2016 05:59 AM, Daniel P. Berrange wrote: > On Thu, Nov 10, 2016 at 10:35:46AM +, Marc-André Lureau wrote: >> Hi >> >> What's the status with this patch? If I understand the discussion, it is >> needed, but not enough. Now that SELinux has been fixed (both in f24/f25 >> now), I can see

Re: [libvirt] [PATCH] virsh:remove the dead code

2016-12-14 Thread sochin.jiang
That's OK, thank you for replying. On 2016/12/14 22:28, Erik Skultety wrote: > On Thu, Dec 15, 2016 at 05:00:11AM +0800, sochin jiang wrote: >> This patch remove the dead code I found. >> >> Signed-off-by: sochin jiang >> --- >> tools/virsh-domain.c | 2 -- >> 1 file

[libvirt] [PATCH v2 2/2] virsh: introduce flage --direct for save command

2016-12-14 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene This patch introduces --direct flag for save command. We could use this flag to save vm to a PIPE. We could saving a VM state directly to Ceph RBD images without having an intermediate file.

[libvirt] [PATCH v2 1/2] qemu: Allow saving QEMU libvirt state to a pipe

2016-12-14 Thread Chen Hanxiao
From: Chen Hanxiao Base upon patches from Roy Keene Currently qemuDomainSaveMemory can save vm's config and memory to fd. It write a magic QEMU_SAVE_PARTIAL firstly, then re-open it to change QEMU_SAVE_PARTIAL as QEMU_SAVE_MAGIC. For pipes this

[libvirt] [PATCH v2 0/2] Allow saving QEMU libvirt state to a pipe

2016-12-14 Thread Chen Hanxiao
This series introduce flag VIR_DOMAIN_SAVE_DIRECT to enable command 'save' to write to PIPE. Base upon patches from Roy Keene with some fixes. Change from original patch: 1) Check whether the specified path is a PIPE. 2) Rebase on upstream. 3) Add doc for virsh command

[libvirt] [PATCH] ZFS: Add vol-resize support

2016-12-14 Thread Sergei A Mamonov
Add virStorageBackendZFSResizeVol method for storage_backend_zfs.c --- src/storage/storage_backend_zfs.c | 28 1 file changed, 28 insertions(+) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index 3a43be4..8e57d72 100644 ---

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-14 Thread Marcel Apfelbaum
On 12/13/2016 06:00 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 04:15:18PM +0200, Marcel Apfelbaum wrote: On 12/13/2016 02:42 PM, Eduardo Habkost wrote: On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: Quick interface review only: Eduardo Habkost

Re: [libvirt] [PATCH] ZFS: Add vol-resize support

2016-12-14 Thread Сергей Мамонов
Hello! But shrink without additional checks may be very bad idea. "zfs set volsize=SIZE " not check used size (on zol now) and it can kill VM filesystem. 2016-12-14 20:15 GMT+03:00 Sergei A Mamonov : > Add virStorageBackendZFSResizeVol method for storage_backend_zfs.c > >

[libvirt] [PATCH 2/2] qemu: snapshot: Don't attempt to resume cpus if they were not paused

2016-12-14 Thread Peter Krempa
External disk-only snapshots with recent enough qemu don't require libvirt to pause the VM. The logic determining when to resume cpus was slightly flawed and attempted to resume them even if they were not paused by the snapshot code. This normally was not a problem, but with locking enabled the

[libvirt] [PATCH 0/2] qemu: fix few image/resource locking problems

2016-12-14 Thread Peter Krempa
The problem from patch 2/2 made me to look at the locking infrastructure in libvirt. There are a few broken places. This fixes two mistakes but more patches will come. Peter Krempa (2): qemu: monitor: Don't resume lockspaces in resume event handler qemu: snapshot: Don't attempt to resume cpus

[libvirt] [PATCH 1/2] qemu: monitor: Don't resume lockspaces in resume event handler

2016-12-14 Thread Peter Krempa
After qemu delivers the resume event it's already running and thus it's too late to enter lockspaces since it may already have modified the disk. The code only creates false log entries in the case when locking is enabled. The lockspace needs to be acquired prior to starting cpus. ---

[libvirt] [PATCH] Remove reference to enum that never existed

2016-12-14 Thread Daniel P. Berrange
The virDomainSendProcessSignal method says the flags values come from virDomainProcessSignalFlag, but this enum has never existed. No flags are needed for this method. Signed-off-by: Daniel P. Berrange --- Pushed under trivial docs rule. src/libvirt-domain.c | 2 +- 1

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-14 Thread Eduardo Habkost
On Wed, Dec 14, 2016 at 04:34:04PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Tue, Dec 13, 2016 at 08:51:34PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Tue, Dec 13, 2016 at 12:04:17PM +0100,

Re: [libvirt] [PATCH v2 2/5] schema: Let elements in /network/ip be specified in any order

2016-12-14 Thread Laine Stump
On 12/13/2016 08:52 AM, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- docs/schemas/network.rng| 80 + tests/networkxml2confdata/dhcp6-nat-network.xml | 2 +- tests/networkxml2confdata/netboot-network.xml | 2 +-

Re: [libvirt] [PATCH] virjson: Remove const from virJSONValueObjectForeachKeyValue

2016-12-14 Thread Peter Krempa
On Wed, Dec 14, 2016 at 15:36:17 +0100, Jiri Denemark wrote: > Almost none of our virJSONValue*Get* functions accept const virJSONValue > pointers and it wouldn't even make sense since we sometimes modify what > we get. And because there is no reason for preventing callers of >

Re: [libvirt] [Qemu-devel] [RFC] qmp: query-device-slots command

2016-12-14 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Dec 13, 2016 at 08:51:34PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Tue, Dec 13, 2016 at 12:04:17PM +0100, Markus Armbruster wrote: >> >> Quick interface review only: >> >> >> >> Eduardo