Re: [libvirt] [PATCH v3] Add support for Veritas HyperScale (VxHS) block device protocol

2017-01-27 Thread ashish mittal
Thanks for the review! My inputs on some of the comments - On Wed, Jan 25, 2017 at 7:59 AM, John Ferlan wrote: > > > On 01/19/2017 09:21 PM, Ashish Mittal wrote: >> Sample XML for a vxhs vdisk is as follows: >> >> >> >> >> >> >> >> >>

Re: [libvirt] [PATCH] doc: improve VNC/SPICE password documentation

2017-01-27 Thread Pavel Hrdina
On Thu, Jan 26, 2017 at 03:32:06PM -0500, John Ferlan wrote: > > > On 01/25/2017 05:00 AM, Pavel Hrdina wrote: > > If the passwd attribute is set to empty string it disables VNC/SPICE > > access to the guest. > > > > Signed-off-by: Pavel Hrdina > > --- > >

Re: [libvirt] [PATCH] domain_conf: vnc: preserve autoport value if no port was specified

2017-01-27 Thread Pavel Hrdina
On Thu, Jan 26, 2017 at 04:30:31PM -0500, John Ferlan wrote: > > > On 01/25/2017 12:26 PM, Pavel Hrdina wrote: > > The issue is that if this graphics definition is provided: > > > > > > > > it's parsed as: > > > > > > > > > > > > but if the resulting XML is parsed again the

Re: [libvirt] [PATCH v2 1/5] storage: adds with_storage_vstorage buils option

2017-01-27 Thread Peter Krempa
On Tue, Jan 17, 2017 at 17:10:55 +0300, Olga Krishtal wrote: > This patch only adds --with-storage-vstorage build option. > In order to use vstorage as a backend for storage pool > vstorage tools should be installed. > > Signed-off-by: Olga Krishtal > --- >

Re: [libvirt] [PATCH v2 1/5] storage: adds with_storage_vstorage buils option

2017-01-27 Thread Olga Krishtal
On 27/01/17 12:09, Peter Krempa wrote: On Tue, Jan 17, 2017 at 17:10:55 +0300, Olga Krishtal wrote: This patch only adds --with-storage-vstorage build option. In order to use vstorage as a backend for storage pool vstorage tools should be installed. Signed-off-by: Olga Krishtal

Re: [libvirt] [PATCH v2 1/5] storage: adds with_storage_vstorage buils option

2017-01-27 Thread Peter Krempa
On Fri, Jan 27, 2017 at 12:31:03 +0300, Olga Krishtal wrote: > On 27/01/17 12:09, Peter Krempa wrote: > > On Tue, Jan 17, 2017 at 17:10:55 +0300, Olga Krishtal wrote: > > > This patch only adds --with-storage-vstorage build option. > > > In order to use vstorage as a backend for storage pool > >

Re: [libvirt] char: Logging serial pty output when disconnected

2017-01-27 Thread Daniel P. Berrange
On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: > Interactive access to a guest serial console can be enabled by hooking > the serial device to a pty backend, e.g. -device > isa-serial,chardev=cs0 -chardev pty,id=cs0. With libvirt this can be > configured via port='0'/>. > > Output

[libvirt] [PATCH 2/2] tests: storage: Fix storage xml2xml test for vstorage pool

2017-01-27 Thread Peter Krempa
The input and output were the same, but the output file did not correspond to what libvirt would output. --- tests/storagepoolxml2xmlout/pool-vstorage.xml | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/storagepoolxml2xmlout/pool-vstorage.xml

[libvirt] [PATCH 1/2] configure: Fix copy-paste error in vstorage backend check

2017-01-27 Thread Peter Krempa
The 'fs' backend m4 code was copied, but one of the condition were not changed which resulted into: configure:Gluster: yes configure:ZFS: yes configure: Virtuozzo storage: check Make the code turn on the virtuozzo driver automatically if the tools are found. ---

[libvirt] [PATCH 0/2] vstorage: fix configure script and tests

2017-01-27 Thread Peter Krempa
Apparently this was not tested prior to being pushed. Fix a configure problem and the test output file. Pushed under the trivial (1/2) and build-breaker (2/2) rules. Peter Krempa (2): configure: Fix copy-paste error in vstorage backend check tests: storage: Fix storage xml2xml test for

Re: [libvirt] [PATCH python 0/7] Remove unused code from generator

2017-01-27 Thread Pavel Hrdina
On Thu, Jan 19, 2017 at 03:31:20PM +, Daniel P. Berrange wrote: > All this functionality is inherited from libxml, but is not required > to generate libvirt python bindings. ACK series Pavel signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2 1/5] storage: adds with_storage_vstorage buils option

2017-01-27 Thread Olga Krishtal
On 27/01/17 12:37, Peter Krempa wrote: On Fri, Jan 27, 2017 at 12:31:03 +0300, Olga Krishtal wrote: On 27/01/17 12:09, Peter Krempa wrote: On Tue, Jan 17, 2017 at 17:10:55 +0300, Olga Krishtal wrote: This patch only adds --with-storage-vstorage build option. In order to use vstorage as a

Re: [libvirt] [PATCH 1/2] configure: Fix copy-paste error in vstorage backend check

2017-01-27 Thread Olga Krishtal
On 27/01/17 12:45, Peter Krempa wrote: The 'fs' backend m4 code was copied, but one of the condition were not changed which resulted into: configure:Gluster: yes configure:ZFS: yes configure: Virtuozzo storage: check Make the code turn on the virtuozzo driver automatically if the

Re: [libvirt] [PATCH 2/2] tests: storage: Fix storage xml2xml test for vstorage pool

2017-01-27 Thread Olga Krishtal
On 27/01/17 12:45, Peter Krempa wrote: The input and output were the same, but the output file did not correspond to what libvirt would output. --- tests/storagepoolxml2xmlout/pool-vstorage.xml | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

[libvirt] [PATCH] qemu: Use iohelper during restore

2017-01-27 Thread Shivaprasad G Bhat
Commit afe6e58 & c4caab53 made necessary changes to use io-helpers during save and restore. The commit c4caab53 missed to remove the redundant check in qemuDomainSaveImageOpen() because of which virFileWrapperFdNew() is not called if bypass_cache is false. Signed-off-by: Shivaprasad G Bhat

[libvirt] [PATCH 1/9] perf: add cpu_clock software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the cpu_clock perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincommon.rng | 1

[libvirt] [PATCH 7/9] perf: add page_faults_maj software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the page_faults_maj perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 4 ++-- docs/schemas/domaincommon.rng

[libvirt] [PATCH 0/9] perf: Add software perf events

2017-01-27 Thread Nitesh Konkar
This patch series adds software perf events. Nitesh Konkar (9): perf: add cpu_clock software perf event support perf: add task_clock software perf event support perf: add page_faults software perf event support perf: add context_switches software perf event support perf: add

[libvirt] [PATCH 2/9] perf: add task_clock software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the task_clock perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 5 +++-- docs/schemas/domaincommon.rng |

[libvirt] [PATCH 4/9] perf: add context_switches software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the context_switches perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincommon.rng

[libvirt] [PATCH 3/9] perf: add page_faults software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the page_faults perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincommon.rng |

[libvirt] [PATCH 8/9] perf: add alignment_faults software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the alignment_faults perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 4 ++-- docs/schemas/domaincommon.rng

[libvirt] [PATCH 6/9] perf: add page_faults_min software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the page_faults_min perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 5 +++-- docs/schemas/domaincommon.rng

[libvirt] [PATCH 5/9] perf: add cpu_migrations software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the cpu_migrations perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 6 ++ docs/news.xml | 4 ++-- docs/schemas/domaincommon.rng |

[libvirt] [PATCH 9/9] perf: add emulation_faults software perf event support

2017-01-27 Thread Nitesh Konkar
This patch adds support and documentation for the emulation_faults perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 7 +++ docs/news.xml | 5 +++-- docs/schemas/domaincommon.rng

[libvirt] [PATCH] [PATCH perl] Add support for more perf events

2017-01-27 Thread Nitesh Konkar
Signed-off-by: Nitesh Konkar --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files changed, 144

Re: [libvirt] [PATCH] [PATCH perl] Add support for more perf events

2017-01-27 Thread Nitesh Konkar
Note: This is actually for go bindings. Error in the commit's subject. Sending a v2 On Fri, Jan 27, 2017 at 6:29 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Signed-off-by: Nitesh Konkar > --- > connect.go | 54 ++ >

[libvirt] [PATCH] [PATCH go] Add support for more perf events

2017-01-27 Thread Nitesh Konkar
Signed-off-by: Nitesh Konkar --- connect.go | 54 ++ domain.go | 54 ++ domain_compat.h | 36 3 files changed, 144

[libvirt] [PATCH 1/2] conf: move VIR_DOMAIN_USB_HUB_PORTS to the header file

2017-01-27 Thread Ján Tomko
For reusing in qemu_domain_address.c. --- src/conf/domain_addr.c | 2 -- src/conf/domain_addr.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 555da59..e0adea9 100644 --- a/src/conf/domain_addr.c +++

[libvirt] [PATCH 0/2] qemu: auto-add all necessary hubs

2017-01-27 Thread Ján Tomko
not just one. https://bugzilla.redhat.com/show_bug.cgi?id=1410188 Ján Tomko (2): conf: move VIR_DOMAIN_USB_HUB_PORTS to the header file qemu: Add enough USB hubs to accomodate all devices src/conf/domain_addr.c | 2 -- src/conf/domain_addr.h

[libvirt] [PATCH 2/2] qemu: Add enough USB hubs to accomodate all devices

2017-01-27 Thread Ján Tomko
Commit 815d98a started auto-adding one hub if there are more USB devices than available USB ports. This was a strange choice, since there might be even more devices. Before USB address allocation was implemented in libvirt, QEMU automatically added a new USB hub if the old one was full. Adjust

[libvirt] [PATCH] [libvirt-perl PATCH] Add more PERF_ constants

2017-01-27 Thread Nitesh Konkar
Signed-off-by: Nitesh Konkar --- Changes| 10 +- Virt.xs| 9 + lib/Sys/Virt/Domain.pm | 54 ++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --git a/Changes

Re: [libvirt] [PATCH] [PATCH go] Add support for more perf events

2017-01-27 Thread Peter Krempa
On Fri, Jan 27, 2017 at 18:37:23 +0530, Nitesh Konkar wrote: > Signed-off-by: Nitesh Konkar > --- > connect.go | 54 ++ > domain.go | 54 ++ >

[libvirt] [PATCH 1/1] qemu: libvirt live migration over RDMA of ipv6 addr failed

2017-01-27 Thread David Dai
Using libvirt to do live migration over RDMA via ip v6 address failed. For example: # virsh migrate --live --migrateuri rdma://[deba::]:49152 \ rhel73_host1_guest1 qemu+ssh://[deba::]/system --verbose root@deba::'s password: error: internal error: unable to execute

[libvirt] [PATCH] qemu: assign USB addresses on redirdev hotplug too

2017-01-27 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1375410 --- src/qemu/qemu_hotplug.c | 8 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index a6de254..57ecc02 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1587,6

Re: [libvirt] [PATCH] qemu: assign USB addresses on redirdev hotplug too

2017-01-27 Thread Pavel Hrdina
On Fri, Jan 27, 2017 at 05:44:24PM +0100, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1375410 > --- > src/qemu/qemu_hotplug.c | 8 > 1 file changed, 8 insertions(+) ACK Pavel signature.asc Description: Digital signature -- libvir-list mailing list

[libvirt] [PATCH] qemu: assign USB port on a selected hub for all devices

2017-01-27 Thread Ján Tomko
Due to a logic error, the autofilling of USB port when a bus is specified: does not work for non-hub devices on domain startup. Fix the logic in qemuDomainAssignUSBPortsIterator to also assign ports for USB addresses that do not yet have one.

[libvirt] [PATCH] spec: Enable qemu driver for RHEL-7 on aarch64

2017-01-27 Thread Jiri Denemark
Signed-off-by: Jiri Denemark --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 7d8858d3f..e8c272bd7 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -36,7 +36,7 @@ %define with_qemu_tcg 0