[libvirt] [PATCH] storage: Fix build on i686

off_t is signed and it's size is the same as long only on 64b archs. Thus it cannot be formatted as %lu. Signed-off-by: Jiri Denemark --- src/storage/storage_backend_logical.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH] Revert "storage: Better describe logical pool creation/definition parameters"

On Tue, Mar 28, 2017 at 09:51:22 +0200, Ján Tomko wrote: > This reverts commit ca4515d2639057020c749470f390fe1f5981e91e > which broke the functionality of logical storage pools > not named after their volume groups. > --- > src/conf/storage_conf.c | 8 > tools/virsh.pod | 7

Re: [libvirt] [PATCH] news: Fix typo in element name

On Tue, Mar 28, 2017 at 10:13:29AM +0200, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- Oops, pushed as trivial. We really need a schema for news.xml... Patches are welcome ;-) docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCHv2 0/2] Restore logical pool functionality

On 03/28/2017 04:40 AM, Ján Tomko wrote: > John Ferlan (1): > storage: Better describe logical pool creation/definition parameters > > Ján Tomko (1): > Revert "storage: Better describe logical pool creation/definition > parameters" > > src/conf/storage_conf.c | 8 >

[libvirt] [PATCH 3/4] schema: Introduce schema for the news.xml file

Since this file gets changed (and broken) rather often, introduce a schema file so that the test suite can validate it. --- docs/news.xml | 2 ++ docs/schemas/news.rng | 73 +++ tests/virschematest.c | 2 ++ 3 files changed, 77

[libvirt] [PATCH 1/4] tests: schema: Add possibility to validate individual files

Sometimes it may be desired to validate individual files against a schema. Refactor the data structures to unify them and introduce a new macro DO_TEST_FILE(schema, xmlfile) which will test the XML file against the given schema file. --- tests/virschematest.c | 34

[libvirt] [PATCH 0/4] news: Add schema validation and tweak few details

The file caused quite some trouble. Add schema validation so that breakage is kept to a minimum. Peter Krempa (4): tests: schema: Add possibility to validate individual files news: Introduce rules for the schema file and fix offending lines schema: Introduce schema for the news.xml file

[libvirt] [PATCH 2/4] news: Introduce rules for the schema file and fix offending lines

Add more strict rules for the news file and fix offending entries. --- docs/news.xml | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 17186b954..024b659e8 100644 --- a/docs/news.xml +++

[libvirt] [PATCH 4/4] news: Add template for a section

After the release it's necessary to add a new section for the upcomming release. Add a template so that it does not have to be compiled over and over again. --- docs/news.xml | 21 + 1 file changed, 21 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

Re: [libvirt] [PATCH v2 0/7] Memory locking fixes

On Mon, 2017-03-27 at 22:16 +0200, Martin Kletzander wrote: > About that ^^ there's still something to fix, but if you follow my > advice, ACK series. Thanks. Pushed on account of the fact that it was ACKed before the freeze started. -- Andrea Bolognani / Red Hat / Virtualization --

Re: [libvirt] [PATCH] storage: Fix build on i686

On 03/28/2017 12:55 PM, Jiri Denemark wrote: off_t is signed and it's size is the same as long only on 64b archs. Thus it cannot be formatted as %lu. Signed-off-by: Jiri Denemark --- src/storage/storage_backend_logical.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[libvirt] [PATCHv2 2/2] storage: Better describe logical pool creation/definition parameters

From: John Ferlan https://bugzilla.redhat.com/show_bug.cgi?id=1398087 Clean up the virsh man page description for --pool-create-as in order to better describe how the various arguments are used when creating (or defining) a logical pool. Signed-off-by: Ján Tomko

[libvirt] [PATCH v2] qemu: command: align disk serial check to schema

Disk serial schema has extra '.+' allowed characters in comparison with check in code. Looks like there is no reason for that as qemu allows any character AFAIK for serial. This discrepancy is originated in 85d15b51 where ability to add serial was added. --- Diff from v1: * fix xml2argv disk

[libvirt] Entering freeze for libvirt-3.2.0

Hi all, as planned I tagged RC1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I had an issue with networking in my limited testing, without time to really dig it seems my guest image wasn't able to do DNS resolution, that could be an issue on my

Re: [libvirt] [PATCH v2 3/4] storage: Better describe logical pool creation/definition parameters

On Mon, Mar 27, 2017 at 20:03:42 -0400, John Ferlan wrote: > > > On 03/27/2017 05:19 PM, Jiri Denemark wrote: > > On Mon, Mar 27, 2017 at 13:42:22 -0400, John Ferlan wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1398087 > >> > >> Clean up the virsh man page description for

[libvirt] [PATCH] Revert "storage: Better describe logical pool creation/definition parameters"

This reverts commit ca4515d2639057020c749470f390fe1f5981e91e which broke the functionality of logical storage pools not named after their volume groups. --- src/conf/storage_conf.c | 8 tools/virsh.pod | 7 --- 2 files changed, 15 deletions(-) diff --git

Re: [libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev

On Mon, Mar 27, 2017 at 08:24:58PM +0200, Martin Kletzander wrote: On Mon, Mar 27, 2017 at 12:30:23PM -0400, Laine Stump wrote: On 03/27/2017 11:40 AM, John Ferlan wrote: On 03/27/2017 11:30 AM, Martin Kletzander wrote: Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

hi Martin (cc libvir-list) I am a little confused about cat support. I am currently rebasing my code on top of pre-cat branch from your private github repo, today when I check it you have removed it and create a cat branch and there are some related code pushed[1], can I know what ’s your

Re: [libvirt] [PATCH] storage: Better describe logical pool creation/definition parameters

On Sat, Mar 25, 2017 at 08:18:46AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1398087 Clean up the virsh man page description for --pool-create-as in order to better describe how the various arguments are used when creating (or defining) a logical pool. Also move the

Re: [libvirt] [PATCH] Revert "storage: Better describe logical pool creation/definition parameters"

On Tue, Mar 28, 2017 at 09:51:22AM +0200, Ján Tomko wrote: > This reverts commit ca4515d2639057020c749470f390fe1f5981e91e > which broke the functionality of logical storage pools > not named after their volume groups. I think that we should also revert commit 5edf9aaf54 because the news change

Re: [libvirt] [PATCH v2 6/7] tests: Introduce QEMU memory locking limit tests

On Mon, 2017-03-27 at 22:15 +0200, Martin Kletzander wrote: [...] > Looking at this function I don't think we really understood each other. > Looks like I explain better with code than words, so let me fix that > right up.  ACK with the following squashed in: I understood your suggestion, I just

[libvirt] [PATCHv2 1/2] Revert "storage: Better describe logical pool creation/definition parameters"

This reverts commit ca4515d2639057020c749470f390fe1f5981e91e which also included a functional change that broke logical storage pools not named after their volume groups. --- src/conf/storage_conf.c | 8 tools/virsh.pod | 7 --- 2 files changed, 15 deletions(-) diff --git

[libvirt] [PATCH] news: Fix typo in element name

Signed-off-by: Jiri Denemark --- Oops, pushed as trivial. We really need a schema for news.xml... docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 85a1d4d97..17186b954 100644 --- a/docs/news.xml +++

[libvirt] [PATCHv2 0/2] Restore logical pool functionality

John Ferlan (1): storage: Better describe logical pool creation/definition parameters Ján Tomko (1): Revert "storage: Better describe logical pool creation/definition parameters" src/conf/storage_conf.c | 8 tools/virsh.pod | 7 +++ 2 files changed, 3 insertions(+),

Re: [libvirt] [PATCH 1/2] networkUpdateState: Create virMacMap module more frequently

On 03/28/2017 02:22 AM, Laine Stump wrote: On 03/22/2017 10:43 AM, Michal Privoznik wrote: Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git

Re: [libvirt] [PATCH 1/8] Revert "qemu: Forbid without "

On Mon, 27 Mar 2017 10:33:52 +0200 Andrea Bolognani wrote: > On Fri, 2017-03-24 at 13:36 -0400, Luiz Capitulino wrote: > > > Turns out this check is excessively strict: there are ways > > > other than to raise the memory locking > > > limit for QEMU processes, one prominent

[libvirt] [PATCH 1/2] schema: do not require name for certain pool types

Pool types that have the VIR_STORAGE_POOL_SOURCE_NAME flag set allow omitting the element and instead fill out the pool name from the element. Relax the schema to make optional for these pool. Expressing that at least one of these is required is out of scope of the schema.~ ---

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

On Mon, 27 Mar 2017 12:33:48 +0200 Andrea Bolognani wrote: > On Fri, 2017-03-24 at 13:58 -0400, Luiz Capitulino wrote: > [...] > > > +be allowed to swap them out, which might be required for some > > > +workloads such as RT. For QEMU/KVM guests, the memory

[libvirt] [PATCH v2] virNetDevIPCheckIPv6ForwardingCallback fixes

Add check for more than one RTA_OIF, even though this is rather unlikely. Get rid of the buggy switch / break as this code won't need to handle more attributes. Use VIR_WARNINGS_NO_CAST_ALIGN to fix impossible to fix util/virnetdevip.c:560:17: error: cast increases required alignment of target

[libvirt] libvirt3.1.0 bug suspected: libvirtd restart, VM start/stop

Hi all, It seems there is a bug for libvirtd which I couldn't find here . *Here is description:* Version-Release number of selected component (if applicable): Libvirt - 3.1.0 (built

Re: [libvirt] [PATCH 1/2] schema: do not require name for certain pool types

On Tue, Mar 28, 2017 at 03:22:07PM +0200, Ján Tomko wrote: Pool types that have the VIR_STORAGE_POOL_SOURCE_NAME flag set allow omitting the element and instead fill out the pool name from the element. Relax the schema to make optional for these pool. s/pool/pools/ Expressing that at

Re: [libvirt] [PATCH 2/4] news: Introduce rules for the schema file and fix offending lines

On Tue, 2017-03-28 at 13:58 +0200, Peter Krempa wrote: > Add more strict rules for the news file and fix offending entries. s/more strict/stricter/ > --- >  docs/news.xml | 41 - >  1 file changed, 28 insertions(+), 13 deletions(-) >  > diff --git

Re: [libvirt] [PATCH 3/4] schema: Introduce schema for the news.xml file

On Tue, 2017-03-28 at 13:58 +0200, Peter Krempa wrote: [...] > @@ -18,6 +18,8 @@ >   each tag is required to contain at least one tag. >  >   Lines should be kept under 80 columns, and should not exceed 100 >columns. > + > + This file is validated against docs/news.rng schema. It's

Re: [libvirt] [PATCH 2/2] conf: do not steal pointers from the pool source

On Tue, Mar 28, 2017 at 03:22:08PM +0200, Ján Tomko wrote: Since commit fcbbb28 we steal the pointer to the storage pool source name if there was no pool name specified. Properly duplicate the string to avoid freeing it twice. https://bugzilla.redhat.com/show_bug.cgi?id=1436400 ---

[libvirt] [PATCH 0/2] conf: do not steal pointers from the pool source

https://bugzilla.redhat.com/show_bug.cgi?id=1436400 Ján Tomko (2): schema: do not require name for certain pool types conf: do not steal pointers from the pool source docs/schemas/storagepool.rng | 27 +- src/conf/storage_conf.c

Re: [libvirt] [PATCH 1/4] tests: schema: Add possibility to validate individual files

On Tue, 2017-03-28 at 13:58 +0200, Peter Krempa wrote: [...] > @@ -196,6 +192,30 @@ mymain(void) >  } >  \ >  } while (0) >  > +#define DO_TEST_FILE(sch, xmlfile)    >   \ > +

[libvirt] [PATCH 2/2] conf: do not steal pointers from the pool source

Since commit fcbbb28 we steal the pointer to the storage pool source name if there was no pool name specified. Properly duplicate the string to avoid freeing it twice. https://bugzilla.redhat.com/show_bug.cgi?id=1436400 --- src/conf/storage_conf.c | 5 +++--

Re: [libvirt] [PATCH 1/4] tests: schema: Add possibility to validate individual files

On Tue, Mar 28, 2017 at 01:58:56PM +0200, Peter Krempa wrote: Sometimes it may be desired to validate individual files against a schema. Refactor the data structures to unify them and introduce a new macro DO_TEST_FILE(schema, xmlfile) which will test the XML file against the given schema file.

Re: [libvirt] [PATCH 4/4] news: Add template for a section

On Tue, 2017-03-28 at 13:58 +0200, Peter Krempa wrote: > After the release it's necessary to add a new section for the > upcomming release. Add a template so that it does not have to be s/upcomming/upcoming/ [...] > @@ -20,6 +20,27 @@ >   Lines should be kept under 80 columns, and should

[libvirt] [PATCH 2/2] virGetDomain: Set domain ID too

So far our code is full of the following pattern: dom = virGetDomain(conn, name, uuid) if (dom) dom->id = 42; There is no reasong why it couldn't be just: dom = virGetDomain(conn, name, uuid, id); After all, client domain representation consists of tuple (name, uuid, id).

[libvirt] [PATCH 0/2] Slightly rework domain ID handling

The first patch fixes an actual bug: our virConnectGetAllDomainStats API does not fill out the domain ID, therefore users just see domain name and UUID. And while fixing it I realized, that our virGetDomain function can do better. However, given that we are in the freeze, I'd like to push just

[libvirt] [PATCH 1/2] qemuDomainGetStats: Copy domain ID too

One of the problems with our virGetDomain function is that it copies just domain name and domain UUID. Therefore it's very easy to forget aboud domain ID. This can cause some bugs, like virConnectGetAllDomainStats not reporting proper domain IDs. Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

On Tue, Mar 28, 2017 at 12:40:04PM -0400, Luiz Capitulino wrote: On Tue, 28 Mar 2017 18:26:12 +0200 Andrea Bolognani wrote: On Tue, 2017-03-28 at 09:43 -0400, Luiz Capitulino wrote: > > Another stab at it (which plugs into my original version): > >  > >   [...] remove the

Re: [libvirt] [PATCH 1/8] Revert "qemu: Forbid without "

On Tue, 2017-03-28 at 09:27 -0400, Luiz Capitulino wrote: > > Well, it *does* work if you set it up properly, eg. raise the > > memory locking limit for the user under which libvirtd will > > run instead of the user under which QEMU processes will run. >  > Doesn't libvirtd run as root? Yes. You

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

On Tue, 2017-03-28 at 09:43 -0400, Luiz Capitulino wrote: > > Another stab at it (which plugs into my original version): > >  > >   [...] remove the limit on locked memory altogether. Thus, > >   enabling this option opens up to a potential security risk: > >   the host will be unable to reclaim

Re: [libvirt] [PATCH 1/2] qemuDomainGetStats: Copy domain ID too

On Tue, Mar 28, 2017 at 05:15:07PM +0200, Michal Privoznik wrote: > One of the problems with our virGetDomain function is that it > copies just domain name and domain UUID. Therefore it's very > easy to forget aboud domain ID. This can cause some bugs, like > virConnectGetAllDomainStats not

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

On Tue, 28 Mar 2017 18:26:12 +0200 Andrea Bolognani wrote: > On Tue, 2017-03-28 at 09:43 -0400, Luiz Capitulino wrote: > > > Another stab at it (which plugs into my original version): > > >  > > >   [...] remove the limit on locked memory altogether. Thus, > > >   enabling

Re: [libvirt] [PATCH 8/8] docs: Improve documentation related to memory locking

On Tue, 2017-03-28 at 12:40 -0400, Luiz Capitulino wrote: > > The strong wording is intentional: we really, really don't > > want people to enable this unless their setup can't work > > without it. >  > I don't see how using strong wording is going to be helpful > to users who need to use the

Re: [libvirt] [PATCH 2/2] virGetDomain: Set domain ID too

On Tue, Mar 28, 2017 at 05:15:08PM +0200, Michal Privoznik wrote: > So far our code is full of the following pattern: > > dom = virGetDomain(conn, name, uuid) > if (dom) > dom->id = 42; > > There is no reasong why it couldn't be just: > > dom = virGetDomain(conn, name, uuid, id); >

Re: [libvirt] [PATCH v4 00/14] Introduce vGPU mdev framework to libvirt

On 2017年03月27日 15:42, yonglihe wrote: Verify Summary: * the none rooted mode starting a high-privileges VM actually. The configurations is source generated default value except tls disabled. 1. rooted virsh define ./libvirt/vgpu-win10.xml Domain vgpu-win10 defined from

[libvirt] encountered failed test cases with latest checkout of libvirt

Hi all, This email content might be duplicated with other thread posted in other places that I do not know yet where to find or search (please let me know if it is true). I am working on a small bug of virsh domxml-to-native. Before I made any changes to the code in order to fix the bug, I 'make

Re: [libvirt] [PATCH] news: Make changes understandable for users

On Mon, 2017-03-27 at 22:38 +0200, Jiri Denemark wrote: > > When reading release notes, patch summary is not always the best > > description of what users can expect in new version.  I propose > > changing it slightly so that it describes what exactly happens and > > when. > >  > > However, we do

Re: [libvirt] [PATCH 9/9] qemu: format caching-mode on iommu command line

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Format the caching-mode option for the intel-iommu device, > based on its attribute value. > > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH 3/9] Split out virDomainIOMMUDefFormat

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Make adding subelements easier. No bz reference here > --- > src/conf/domain_conf.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index ffc6a68..1245fdd

Re: [libvirt] [PATCH 4/9] conf: add to

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Add a new attribute to control interrupt remapping. > > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 > --- > docs/formatdomain.html.in | 22 - > docs/schemas/domaincommon.rng | 9 +

Re: [libvirt] [PATCH 2/9] qemu: format kernel_irqchip on the command line

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Add kernel_irqchip=off/split/on to the QEMU command line > and a capability that looks for it in query-command-line-options > output. > > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 > --- > src/libvirt_private.syms

Re: [libvirt] [PATCH 6/9] qemu: refactor qemuBuildIOMMUCommandLine

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Introduce a separate buffer for options and use a helper > variable for def->iommu. No bz reference here > --- > src/qemu/qemu_command.c | 21 +++-- > 1 file changed, 15 insertions(+), 6 deletions(-) > ACK -- libvir-list mailing

Re: [libvirt] [PATCH 5/9] qemu: allow conditional device property probing

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Do not probe for devices that QEMU does not know > when probing for device options. No bz reference here > --- > src/qemu/qemu_capabilities.c | 99 > ++-- > 1 file changed, 68 insertions(+), 31 deletions(-) >

Re: [libvirt] [PATCH 7/9] qemu: format intremap= on intel-iommu command line

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Add the intremap= option to QEMU command line, corresponding > to the attribute of the iommu device. > > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 > --- > src/qemu/qemu_capabilities.c | 8 >

Re: [libvirt] [PATCH 1/9] conf: add to

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Add a new element with a mode attribute. > > Possible values are off, split or on. > > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 Shouldn't this just go on the "last" patch in the series. IDC really, but if you're going to add to all

Re: [libvirt] [PATCH 8/9] conf: add caching attribute to iommu device

On 03/23/2017 11:26 AM, Ján Tomko wrote: > Add a new attribute to control the caching mode. > > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 > --- > docs/formatdomain.html.in | 9 +++ > docs/schemas/domaincommon.rng | 5 >

Re: [libvirt] [PATCH] news: Make changes understandable for users

On Tue, Mar 28, 2017 at 08:09:02PM +0200, Andrea Bolognani wrote: On Mon, 2017-03-27 at 22:38 +0200, Jiri Denemark wrote: > When reading release notes, patch summary is not always the best > description of what users can expect in new version.  I propose > changing it slightly so that it

Re: [libvirt] [PATCH 1/2] networkUpdateState: Create virMacMap module more frequently

On Tue, Mar 28, 2017 at 11:08:01AM +0200, Michal Privoznik wrote: On 03/28/2017 02:22 AM, Laine Stump wrote: On 03/22/2017 10:43 AM, Michal Privoznik wrote: The virMacMap module is there for dumping [domain, ] pairs into a file so that libvirt_guest NSS module can use it. Whenever a interface

Re: [libvirt] [PATCH 2/2] network: Don't crash on domain destroy

On Wed, Mar 22, 2017 at 03:43:17PM +0100, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1434882 Imagine the following scenario: 1) virsh net-start default 2) virsh start myFavouriteDomain 3) virsh net-destroy default 4) virsh destroy myFavouriteDomain (assuming