Re: [libvirt] [RFC PATCH 01/11] nodedev: Fix guideline violations in nodedev modules

On Wed, Mar 29, 2017 at 03:50:28PM +0200, Peter Krempa wrote: > On Wed, Mar 29, 2017 at 14:51:11 +0200, Erik Skultety wrote: > > We recently started to enforce certain guideline rule a bit more, e.g. > > functions delimited by 2 newlines in *.c, by 1 newline in *.h, return > > types on a separate

[libvirt] [PATCH] tests: Rename VIRT_TEST_* macros to VIR_TEST_*

We use the "vir" prefix pretty consistently in our APIs, both external and internal, which made these macros stood out. --- tests/bhyveargv2xmltest.c | 2 +- tests/bhyvexml2argvtest.c | 2 +- tests/bhyvexml2xmltest.c | 2 +- tests/commandtest.c| 2 +-

[libvirt] [PATCH 0/3 for 3.2.0] Fix host-model CPU with non-migratable features

This series fixes a regression in libvirt which would break domains with a CPU defined as, for example: Such domains would work just fine with libvirt <= 3.1.0 or QEMU < 2.9.0, but they would be broken with current libvirt and QEMU >= 2.9.0. This is because we started asking

[libvirt] [PATCH 2/3] qemu: Check migratable host CPU features

If calling query-cpu-model-expansion on the 'host'/'max' CPU model with 'migratable' property set to false succeeds, we know QEMU is able to tell us which features would disable migration. Thus we can mark all enabled features as migratable. Signed-off-by: Jiri Denemark ---

[libvirt] [PATCH 3/3] qemu: Check non-migratable host CPU features

CPU features which change their value from disabled to enabled between two calls to query-cpu-model-expansion (the first with no extra properties set and the second with 'migratable' property set to false) can be marked as enabled and non-migratable in qemuMonitorCPUModelInfo. Since the code

[libvirt] [PATCH v2 5/5] tests: Test ACPI, UEFI requirements

Make sure every combination of ACPI and UEFI works, or fails to work, as expected. --- .../qemuxml2argv-aarch64-acpi-nouefi.args | 22 + .../qemuxml2argv-aarch64-acpi-nouefi.xml | 22 + .../qemuxml2argv-aarch64-acpi-uefi.args|

Re: [libvirt] [PATCH 3/4] qemu: Enforce ACPI, UEFI requirements

On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: > > @@ -6252,9 +6252,23 @@ qemuBuildPMCommandLine(virCommandPtr cmd, > >  virCommandAddArg(cmd, "-no-shutdown"); > >  } > >   > > +/* Architectures that support ACPI also support -no-acpi as a way > > + * of turning it off,

[libvirt] [PATCH v2 4/5] qemu: Enforce ACPI, UEFI requirements

Depending on the architecture, requirements for ACPI and UEFI can be different; more specifically, while on x86 UEFI requires ACPI, on aarch64 it's the other way around. Enforce these requirements when validating the domain, and make the error message more accurate by mentioning that they're not

[libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

The capabilities used in test cases should match those used during normal operation for the tests to make any sense. --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 ++

[libvirt] [PATCH v2 3/5] qemu: Advertise ACPI support for aarch64 guests

So far, libvirt has assumed that only x86 supports ACPI, but that's inaccurate since aarch64 supports it too. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1429509 --- src/qemu/qemu_capabilities.c | 28 -- .../caps_2.6.0-gicv2.aarch64.xml

[libvirt] [PATCH v2 0/5] qemu: ACPI and UEFI fixes

Changes from [v1]: * use a dedicated function for setting basic arch-dependent capabilities instead of having two copies of the same code that will have to be kept in sync; * enforce requirements at guest validation time rather than at command line creation time; * shuffle

[libvirt] [libvirt-perl][PATCH 2/3] Add virDomainSetBlockThreshold API

Signed-off-by: Michal Privoznik --- Changes| 1 + Virt.xs| 12 lib/Sys/Virt/Domain.pm | 9 + 3 files changed, 22 insertions(+) diff --git a/Changes b/Changes index 4d6136f..3faaf08 100644 --- a/Changes +++ b/Changes @@

[libvirt] [libvirt-perl][PATCH 1/3] Add block threshold event

Signed-off-by: Michal Privoznik --- Changes| 1 + Virt.xs| 48 lib/Sys/Virt/Domain.pm | 6 ++ t/030-api-coverage.t | 1 + 4 files changed, 56 insertions(+) diff --git a/Changes

[libvirt] [PATCH v2 1/5] qemu: Split virQEMUCapsInitArchQMPBasic()

Instead of having a single function that probes the architecture from the monitor and then sets a bunch of basic capabilities based on it, have a separate function for each part: virQEMUCapsInitQMPArch() only sets the architecture, and virQEMUCapsInitQMPBasicArch() only sets the capabilities.

Re: [libvirt] [PATCH v2 0/4] Add schema validation for news

On Wed, Mar 29, 2017 at 09:28:12AM +0200, Peter Krempa wrote: v2: - rename DO_TEST to DO_TEST_DIR along with changes in the first patch - add 'abs_srcdir' to the tested XML path so that vpath builds work - fix wording of the rules for adding news entries - fix commit messages Peter Krempa (4):

Re: [libvirt] [PATCH v2 4/4] news: Add template for a section

On Wed, Mar 29, 2017 at 09:28:16AM +0200, Peter Krempa wrote: After the release it's necessary to add a new section for the upcoming release. Add a template so that it does not have to be compiled over and over again. s/compiled/copied/? Jan signature.asc Description: Digital signature --

[libvirt] [python PATCH 1/2] event: fix comment for _dispatchDomainEventMetadataChangeCallback

The comment was copied from the device removal failed event. --- libvirt-override-virConnect.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-override-virConnect.py b/libvirt-override-virConnect.py index bcd72ac..35009bb 100644 --- a/libvirt-override-virConnect.py

[libvirt] [python PATCH 0/2] Fix event comment and add handler for block threshold

Peter Krempa (2): event: fix comment for _dispatchDomainEventMetadataChangeCallback event: Add handler for block threshold event examples/event-test.py | 4 +++ libvirt-override-virConnect.py | 11 +++- libvirt-override.c | 62

Re: [libvirt] [RFC PATCH 01/11] nodedev: Fix guideline violations in nodedev modules

On Wed, Mar 29, 2017 at 14:51:11 +0200, Erik Skultety wrote: > We recently started to enforce certain guideline rule a bit more, e.g. > functions delimited by 2 newlines in *.c, by 1 newline in *.h, return > types on a separate line, etc. This patch adjusts these issues in all > nodedev modules. >

[libvirt] [libvirt-perl][PATCH 0/3] Reflect upstream changes

Couple of new APIs and constants were added to libvirt. Reflect them in the perl bindings. Michal Privoznik (3): Add block threshold event Add virDomainSetBlockThreshold API Add VIR_MIGRATE_TLS constant Changes| 3 +++ Virt.xs| 61

Re: [libvirt] [RFC PATCH 03/11] conf: nodedev: Split virNodeDeviceDefFormat into more functions

On Wed, Mar 29, 2017 at 03:51:54PM +0200, Peter Krempa wrote: > On Wed, Mar 29, 2017 at 14:51:13 +0200, Erik Skultety wrote: > > Make the code look cleaner by moving the capability specific bits into > > separate functions. > > > > Signed-off-by: Erik Skultety > > --- > >

Re: [libvirt] [RFC PATCH 03/11] conf: nodedev: Split virNodeDeviceDefFormat into more functions

On Wed, Mar 29, 2017 at 14:51:13 +0200, Erik Skultety wrote: > Make the code look cleaner by moving the capability specific bits into > separate functions. > > Signed-off-by: Erik Skultety > --- > src/conf/node_device_conf.c | 578 >

Re: [libvirt] [PATCH] qemu: domain: Properly lookup top of chain in qemuDomainGetStorageSourceByDevstr

On Wed, Mar 29, 2017 at 10:01:14 -0500, Eric Blake wrote: > On 03/29/2017 09:58 AM, Peter Krempa wrote: > > When idx is 0 virStorageFileChainLookup returns the base (bottom) of the > > backing chain rather than the top. This is expected by the callers of > > qemuDomainGetStorageSourceByDevstr. > >

Re: [libvirt] [python PATCH 0/2] Fix event comment and add handler for block threshold

On 03/29/2017 10:00 AM, Peter Krempa wrote: > Peter Krempa (2): > event: fix comment for _dispatchDomainEventMetadataChangeCallback > event: Add handler for block threshold event ACK > > examples/event-test.py | 4 +++ > libvirt-override-virConnect.py | 11 +++- >

[libvirt] [PATCH 0/3] Fix gluster volume lookup of multiple volumes

Fix the broken XPath and add tests. Peter Krempa (3): storage: util: Split out the gluster volume extraction code into new function test: Introduce testing of virStorageUtilGlusterExtractPoolSources storage: Fix XPath for looking up gluster volume name src/storage/storage_util.c

[libvirt] [PATCH 3/3] storage: Fix XPath for looking up gluster volume name

Use the relative lookup specifier rather than the global one. Otherwise only the first name would be looked up. Add a test case to cover the scenario. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1436574 --- src/storage/storage_util.c | 2 +-

[libvirt] [PATCH] qemu: domain: Properly lookup top of chain in qemuDomainGetStorageSourceByDevstr

When idx is 0 virStorageFileChainLookup returns the base (bottom) of the backing chain rather than the top. This is expected by the callers of qemuDomainGetStorageSourceByDevstr. Add a special case for idx == 0 --- With this you are not able to specify the top image of a disk when using

[libvirt] [PATCH 1/3] qemuMonitorCPUModelInfo: Add support for non-migratable features

QEMU is able to tell us whether a CPU feature would block migration or not. This patch adds support for storing such features in qemuMonitorCPUModelInfo. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 39 +---

[libvirt] [python PATCH 2/2] event: Add handler for block threshold event

Unfortunately python doesn't generate those. --- examples/event-test.py | 4 +++ libvirt-override-virConnect.py | 9 ++ libvirt-override.c | 62 ++ 3 files changed, 75 insertions(+) diff --git a/examples/event-test.py

Re: [libvirt] [PATCH] qemu: domain: Properly lookup top of chain in qemuDomainGetStorageSourceByDevstr

On 03/29/2017 09:58 AM, Peter Krempa wrote: > When idx is 0 virStorageFileChainLookup returns the base (bottom) of the > backing chain rather than the top. This is expected by the callers of > qemuDomainGetStorageSourceByDevstr. > > Add a special case for idx == 0 > --- > With this you are not

Re: [libvirt] [PATCH v4 00/14] Introduce vGPU mdev framework to libvirt

On 03/28/2017 10:05 PM, yonglihe wrote: > On 2017年03月27日 15:42, yonglihe wrote: >> >> Verify Summary: >> * the none rooted mode starting a high-privileges VM actually. >> >> The configurations is source generated default value except tls disabled. >> >> >> 1. rooted >> >> virsh define

[libvirt] testing volDownload and volUpload different md5 on source and dest for qcow2

Hi. I'm fix libvirt php binding to properly recv from stream and after that test volume download and volume upload functions. And see, that in case of raw image md5sum on src and on dst is equal. But in case of qcow - phisical size of image is different and md5sum does not equal. Why this can

Re: [libvirt] [PATCH 3/4] qemu: Enforce ACPI, UEFI requirements

On 03/29/2017 10:12 AM, Andrea Bolognani wrote: > On Mon, 2017-03-27 at 08:03 -0400, John Ferlan wrote: >>> @@ -6252,9 +6252,23 @@ qemuBuildPMCommandLine(virCommandPtr cmd, >>> virCommandAddArg(cmd, "-no-shutdown"); >>> } >>> >>> +/* Architectures that support ACPI also

Re: [libvirt] [PATCH] docs: document bhyve UEFI support

Laine Stump wrote: > On 03/27/2017 12:33 PM, Roman Bogorodskiy wrote: > > - Add a news entry > > - Update the driver page with documentation of the new options > >and some examples > > --- > > docs/drvbhyve.html.in | 94 > > +++ > >

[libvirt] [PATCH] [libvirt-php] fix libvirt_stream_send/libvirt_stream_recv

Signed-off-by: Vasiliy Tolstov --- src/libvirt-php.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index e8384795d635..4e088e746281 100644 --- a/src/libvirt-php.c +++

[libvirt] [PATCH] [libvirt-php] fix libvirt_stream_send/libvirt_stream_recv

When php disable call pass time by reference this breaks libvirt_stream_recv and also bring more memory allocations from zend engine. Vasiliy Tolstov (1): fix libvirt_stream_send/libvirt_stream_recv src/libvirt-php.c | 36 1 file changed, 16 insertions(+),

Re: [libvirt] encountered failed test cases with latest checkout of libvirt

On 03/29/2017 04:47 AM, Michal Privoznik wrote: >> >> For the valgrind testing with 'make -C tests valgrind', the errors were >> *mostly* due to >> "FATAL: can't open suppressions file "./.valgrind.supp". I am using >> valgrind 3.12.0. I suspect it may be a simple tweak to makefile to supply an

[libvirt] [PATCH 1/3] storage: util: Split out the gluster volume extraction code into new function

To allow testing of the algorithm, split out the extractor into a separate helper. --- src/storage/storage_util.c | 93 +++--- src/storage/storage_util.h | 4 ++ 2 files changed, 58 insertions(+), 39 deletions(-) diff --git a/src/storage/storage_util.c

[libvirt] [PATCH 2/3] test: Introduce testing of virStorageUtilGlusterExtractPoolSources

Add a test program called virstorageutiltest and test the gluster pool detection code. --- tests/Makefile.am | 15 ++- .../virstorageutildata/gluster-parse-basic-dst.xml | 6 ++ .../virstorageutildata/gluster-parse-basic-src.xml | 47 ++

[libvirt] [RFC PATCH 01/11] nodedev: Fix guideline violations in nodedev modules

We recently started to enforce certain guideline rule a bit more, e.g. functions delimited by 2 newlines in *.c, by 1 newline in *.h, return types on a separate line, etc. This patch adjusts these issues in all nodedev modules. Signed-off-by: Erik Skultety ---

[libvirt] [RFC PATCH 07/11] nodedev: Fill in the mdev info for the parent PCI device

The parent device needs to report the generic stuff about the supported mediated devices types, like device API, available instances, and description which might hold some useful data about supported resolutions for the type given, framebuffer size, etc. Unfortunately, these are not standardized

[libvirt] [RFC PATCH 00/11] Add mdev reporting capability to the nodedev driver

This series enables the node device driver to report information about the existing mediated devices on the host. There is no device creation involved yet. The information reported by the node device driver is split into two parts, one that is reported within the physical parent's capabilities

[libvirt] [RFC PATCH 09/11] nodedev: Format the mdev capability of the PCI parent device

This introduces a new nested capability element of type 'mdev' with the resulting XML of the following format: ... ... optional, raw, unstructured resource allocation data vfio-pci NUM ... ... ...

[libvirt] [RFC PATCH 02/11] nodedev: Make use of the compile-time missing enum in switch error

So udevGetDeviceDetails was one those functions using an enum in a switch, but since it had a 'default' case, compiler didn't warn about an unhandled enum. Moreover, the error about an unsupported device type reported in the default case is unnecessary, since by the time we get there,

[libvirt] [RFC PATCH 03/11] conf: nodedev: Split virNodeDeviceDefFormat into more functions

Make the code look cleaner by moving the capability specific bits into separate functions. Signed-off-by: Erik Skultety --- src/conf/node_device_conf.c | 578 1 file changed, 322 insertions(+), 256 deletions(-) diff --git

[libvirt] [RFC PATCH 05/11] docs: Use our XSLT template to generate list of supported pool types

Since we do have this template at hand, why not using it wherever possible. Also, just to be grammatically correct, let's use singular, aka 'pool' instead of plural in the enumerated list of supported types. Signed-off-by: Erik Skultety --- docs/storage.html.in | 62

[libvirt] [RFC PATCH 10/11] docs: Provide a nodedev driver stub documentation

There's lot more to document about the nodedev driver, besides PCI and SR-IOV (even this might need to be extended), but let's start small-ish and at least have a page for it linked from the drivers.html. Signed-off-by: Erik Skultety --- docs/drivers.html.in| 6 +-

[libvirt] [RFC PATCH 06/11] nodedev: Introduce the mdev capability to the nodedev driver structure

Besides updating the capability enum, this patch introduces 'virNodeDevCapMdev' structure which will store everything libvirt can gather from sysfs about a mediated device. Since we need to report the info for both the mediated child device it's parent mdev capabilities (merely the mdev types'

[libvirt] [RFC PATCH 08/11] nodedev: Introduce udevProcessMediatedDevice

Start discovering the mediated devices on the host system and format the attributes for the child device into the XML. Compared to the parent device which reports generic information about the abstract mediated devices types, a child device only reports the type name it has been instantiated from

[libvirt] [RFC PATCH 11/11] docs: Document the mediated devices within the nodedev driver

Signed-off-by: Erik Skultety --- docs/drvnodedev.html.in | 91 + 1 file changed, 91 insertions(+) diff --git a/docs/drvnodedev.html.in b/docs/drvnodedev.html.in index ed185c3df3..776c88cc87 100644 --- a/docs/drvnodedev.html.in

[libvirt] [RFC PATCH 04/11] nodedev: udevProcessPCI: Drop syspath variable

Since we have that information provided by @def which is not a private object, there is really no need for the variable. Signed-off-by: Erik Skultety --- src/node_device/node_device_udev.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH v4 00/14] Introduce vGPU mdev framework to libvirt

On 03/28/2017 10:05 PM, yonglihe wrote: On 2017年03月27日 15:42, yonglihe wrote: Verify Summary: * the none rooted mode starting a high-privileges VM actually. The configurations is source generated default value except tls disabled. 1. rooted virsh define ./libvirt/vgpu-win10.xml Domain

Re: [libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

On 03/29/2017 10:08 AM, Andrea Bolognani wrote: > The capabilities used in test cases should match those used > during normal operation for the tests to make any sense. Could you add just a bit of text about why all -no-acpi is removed (mostly) and why -no-hpet is added to a couple? It's

Re: [libvirt] [PATCH v2 3/5] qemu: Advertise ACPI support for aarch64 guests

On 03/29/2017 10:08 AM, Andrea Bolognani wrote: > So far, libvirt has assumed that only x86 supports ACPI, > but that's inaccurate since aarch64 supports it too. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1429509 > --- > src/qemu/qemu_capabilities.c | 28 >

Re: [libvirt] [PATCH v2 1/5] qemu: Split virQEMUCapsInitArchQMPBasic()

On 03/29/2017 10:08 AM, Andrea Bolognani wrote: > Instead of having a single function that probes the > architecture from the monitor and then sets a bunch of > basic capabilities based on it, have a separate function > for each part: virQEMUCapsInitQMPArch() only sets the > architecture, and

Re: [libvirt] [PATCH v2 5/5] tests: Test ACPI, UEFI requirements

On 03/29/2017 10:08 AM, Andrea Bolognani wrote: > Make sure every combination of ACPI and UEFI works, or fails to > work, as expected. > --- > .../qemuxml2argv-aarch64-acpi-nouefi.args | 22 + > .../qemuxml2argv-aarch64-acpi-nouefi.xml | 22

Re: [libvirt] [PATCH v2 4/5] qemu: Enforce ACPI, UEFI requirements

On 03/29/2017 10:08 AM, Andrea Bolognani wrote: > Depending on the architecture, requirements for ACPI and UEFI can > be different; more specifically, while on x86 UEFI requires ACPI, > on aarch64 it's the other way around. > > Enforce these requirements when validating the domain, and make >

[libvirt] [PATCH v2 3/4] schema: Introduce schema for the news.xml file

Since this file gets changed (and broken) rather often, introduce a schema file so that the test suite can validate it. --- docs/news.xml | 2 ++ docs/schemas/news.rng | 73 +++ tests/virschematest.c | 2 ++ 3 files changed, 77

[libvirt] [PATCH v2 0/4] Add schema validation for news

v2: - rename DO_TEST to DO_TEST_DIR along with changes in the first patch - add 'abs_srcdir' to the tested XML path so that vpath builds work - fix wording of the rules for adding news entries - fix commit messages Peter Krempa (4): tests: schema: Add possibility to validate individual files

[libvirt] [PATCH v2 4/4] news: Add template for a section

After the release it's necessary to add a new section for the upcoming release. Add a template so that it does not have to be compiled over and over again. --- docs/news.xml | 21 + 1 file changed, 21 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

[libvirt] [PATCH v2 1/4] tests: schema: Add possibility to validate individual files

Sometimes it may be desired to validate individual files against a schema. Refactor the data structures to unify them and introduce a new macro DO_TEST_FILE(schema, xmlfile) which will test the XML file against the given schema file. --- tests/virschematest.c | 75

Re: [libvirt] [PATCH 1/2] networkUpdateState: Create virMacMap module more frequently

On 03/28/2017 10:42 PM, Martin Kletzander wrote: > Makes sense to me, however you might want to look at an idea in the second patch. Maybe it would help a bit. Maybe it wouldn't :-/ I feel like the consensus is either to have a pointer to an object (in which case it's enabled) or not

Re: [libvirt] [PATCH v4 11/14] qemu: Bump the memory locking limit for mdevs as well

On Wed, 2017-03-22 at 16:27 +0100, Erik Skultety wrote: > Since mdevs are just another type of VFIO devices, we should increase > the memory locking limit the same way we do for VFIO PCI devices. >  > Signed-off-by: Erik Skultety > --- >  src/qemu/qemu_domain.c | 9 +

Re: [libvirt] [PATCH v4 11/14] qemu: Bump the memory locking limit for mdevs as well

On Wed, Mar 29, 2017 at 10:41:52AM +0200, Andrea Bolognani wrote: > On Wed, 2017-03-22 at 16:27 +0100, Erik Skultety wrote: > > Since mdevs are just another type of VFIO devices, we should increase > > the memory locking limit the same way we do for VFIO PCI devices. > > > > Signed-off-by: Erik

Re: [libvirt] encountered failed test cases with latest checkout of libvirt

On Wed, Mar 29, 2017 at 1:01 AM, D L wrote: > Hi all, > > This email content might be duplicated with other thread posted in other > places that I do not know yet where to find or search (please let me know > if it is true). I am working on a small bug of virsh

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

On Tue, Mar 28, 2017 at 03:22:34PM +0800, Eli Qiao wrote: hi Martin (cc libvir-list) I am a little confused about cat support. I am currently rebasing my code on top of pre-cat branch from your private github repo, today when I check it you have removed it and create a cat branch and there

Re: [libvirt] [PATCH] news: Make changes understandable for users

On Tue, 2017-03-28 at 22:17 +0200, Martin Kletzander wrote: > > This one looks like it would qualify on several accounts, > > but it could also definitely use a description to flesh out > > exactly what was changed, something along the lines of > >  > >    > > Initialize volumes properly when

[libvirt] [PATCH] [libvirt-php] allow to specify empty base and top

allow to specify empty base and top to do active block commit Vasiliy Tolstov (1): allow to specify empty base and top for block commit src/libvirt-php.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) -- 2.9.3 -- libvir-list mailing list

[libvirt] [PATCH v2 2/4] news: Introduce rules for the schema file and fix offending lines

Add stricter rules for the news file and fix offending entries. --- docs/news.xml | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index b2e21efca..5115cb1ab 100644 --- a/docs/news.xml +++ b/docs/news.xml

[libvirt] [PATCH] network: Drop unused networkRestartRadvd

Since its introduction in 1ce4922e720 this function lived as an outcast in an #if 0 block. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/network/bridge_driver.c

[libvirt] [PATCH] allow to specify empty base and top for block commit

Signed-off-by: Vasiliy Tolstov --- src/libvirt-php.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index e8384795d635..6bbacda19611 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 29 March 2017 at 3:45 PM, Martin Kletzander wrote: > On Tue, Mar 28, 2017 at 03:22:34PM +0800, Eli Qiao wrote: > > hi Martin >

Re: [libvirt] [GSoC] Libvirt accepted as GSoC 2017 mentor organization

On 02/28/2017 01:11 PM, Michal Privoznik wrote: Dear all, yesterday I received great news: Libvirt has been accepted as a mentor organization for this year's Google Summer of Code [1]. Just a gentle reminder that students application deadline is April 3rd 16:00 UTC so if you are a student

Re: [libvirt] [PATCH] test: Add fake cpu id file

On Wed, Mar 29, 2017 at 05:50:05PM +0800, Eli Qiao wrote: Added fake cpu cache id and resctrl file Thanks for that, however I would rather see you adding new directory to tests/vircaps2xmldata which describes yet another machine, so that we have different inputs to the tests. I have the ID

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

On Wed, Mar 29, 2017 at 05:59:47PM +0800, Eli Qiao wrote: On Wednesday, 29 March 2017 at 5:47 PM, Martin Kletzander wrote: On Wed, Mar 29, 2017 at 05:31:42PM +0800, Eli Qiao wrote: > > > -- > Best regards > Eli > > 天涯无处不重逢 > a leaf duckweed belongs to the sea, where not to meet in life > >

Re: [libvirt] [PATCH] util: Add more virsysfs functions for handling resctrl sysfs

On Wed, Mar 29, 2017 at 05:44:36PM +0800, Eli Qiao wrote: Extended /sys/fs/resctrl sysfs handling. This looks good, few notes below. Signed-off-by: Eli Qiao --- src/libvirt_private.syms | 4 ++ src/util/virsysfs.c | 98

Re: [libvirt] [PATCH] news: Make changes understandable for users

On 03/29/2017 03:54 AM, Andrea Bolognani wrote: > On Tue, 2017-03-28 at 22:17 +0200, Martin Kletzander wrote: >>> This one looks like it would qualify on several accounts, >>> but it could also definitely use a description to flesh out >>> exactly what was changed, something along the lines of

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

-- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 29 March 2017 at 5:19 PM, Martin Kletzander wrote: > On Wed, Mar 29, 2017 at 04:22:16PM +0800, Eli Qiao wrote: > > > > > >

[libvirt] [PATCH] util: Add more virsysfs functions for handling resctrl sysfs

Extended /sys/fs/resctrl sysfs handling. Signed-off-by: Eli Qiao --- src/libvirt_private.syms | 4 ++ src/util/virsysfs.c | 98 +++- src/util/virsysfs.h | 15 3 files changed, 116 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

On Wed, Mar 29, 2017 at 04:22:16PM +0800, Eli Qiao wrote: -- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 29 March 2017 at 3:45 PM, Martin Kletzander wrote: On Tue, Mar 28, 2017

Re: [libvirt] libvirt3.1.0 bug suspected: libvirtd restart, VM start/stop

On 03/28/2017 01:54 PM, Stepan Andr wrote: Hi all, It seems there is a bug for libvirtd which I couldn't find here . *Here is description:* Version-Release number of selected

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

On Wednesday, 29 March 2017 at 5:47 PM, Martin Kletzander wrote: > On Wed, Mar 29, 2017 at 05:31:42PM +0800, Eli Qiao wrote: > > > > > > -- > > Best regards > > Eli > > > > 天涯无处不重逢 > > a leaf duckweed belongs to the sea, where not to meet in life > > > > Sent with Sparrow

Re: [libvirt] encountered failed test cases with latest checkout of libvirt

On Wed, Mar 29, 2017 at 03:01:06AM -0400, Dan wrote: For the valgrind testing with 'make -C tests valgrind', the errors were *mostly* due to "FATAL: can't open suppressions file "./.valgrind.supp". I am using valgrind 3.12.0. Yeah, we reference the suppression file relatively, you need to:

Re: [libvirt] [PATCH resend V10 01/12] Resctrl: Add some utils functions

On Wed, Mar 29, 2017 at 05:31:42PM +0800, Eli Qiao wrote: -- Best regards Eli 天涯无处不重逢 a leaf duckweed belongs to the sea, where not to meet in life Sent with Sparrow (http://www.sparrowmailapp.com/?sig) OK, please do something with your client. Having the footer here on top for every

[libvirt] [PATCH] test: Add fake cpu id file

Added fake cpu cache id and resctrl file Signed-off-by: Eli Qiao --- tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/id | 1 + tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/id | 1 +

Re: [libvirt] encountered failed test cases with latest checkout of libvirt

On 03/29/2017 09:01 AM, Dan wrote: On Wed, Mar 29, 2017 at 1:01 AM, D L wrote: Hi all, This email content might be duplicated with other thread posted in other places that I do not know yet where to find or search (please let me know if it is true). I am working on a