Re: [libvirt] [PATCH] test: fixing variable names for test suite inside configure.ac.

Thanks Michal, There are other variables with the same behaviour. ACL for example. I will check everything and submit a new bugfix. 2017-05-22 1:33 GMT-03:00 Michal Privoznik : > On 05/20/2017 04:53 PM, Julio Faracco wrote: >> Both variables for gcov and oom have wrong names

Re: [libvirt] [PATCH] qemu: Remove unused variables in qemuDomainUpdateDeviceConfig

On Tue, May 16, 2017 at 03:45:09AM -0400, Kothapally Madhu Pavan wrote: priv and qemuCaps variables are not used anymore. Signed-off-by: Kothapally Madhu Pavan --- src/qemu/qemu_driver.c | 11 --- 1 file changed, 11 deletions(-) ACK and pushed. Jan

[libvirt] [PATCH 5/7] util: helper functions for fibre channel devices

We will need some convenient helper functions for managing sysfs-entries for fibre channel-backed devices. Let's implement them and make them available in the private API. Signed-off-by: Bjoern Walk --- po/POTFILES.in | 1 + src/Makefile.am | 1 +

[libvirt] [PATCH 4/7] virsh: nodedev: ability to filter CCW capabilities

Now that the node_device driver is aware of CCW devices, let's hook up virsh so that we can filter them properly. Reviewed-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer Signed-off-by: Bjoern Walk ---

[libvirt] [PATCH 6/7] node_device: introduce new capability FC_RPORT

Similar to scsi_host and fc_host, there is a relation between a scsi_target and its transport specific fc_remote_port. Let's expose this relation and relevant information behind it. An example for a virsh nodedev-dumpxml: virsh # nodedev-dumpxml scsi_target0_0_0 scsi_target0_0_0

[libvirt] [PATCH 7/7] docs: update news.xml

Mention CCW and fc_remote_port capablities in the news.xml file. Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

[libvirt] [PATCH 1/7] node_device: Use the iterator variable

From: Marc Hartmayer As the switch statement checks data.type of the iterator variable @cap it must use this variable for the update too. Suggested-by: Bjoern Walk Signed-off-by: Marc Hartmayer ---

[libvirt] [PATCH 2/7] node_device: Unlock obj in case of an error too

From: Marc Hartmayer Unlock @obj in case of an error too. Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski Signed-off-by: Marc Hartmayer ---

[libvirt] [PATCH 0/7] extend node_device for CCW and fc_remote_port

Let's introduce two new capabilities to the node_device driver and fix two smaller issues on the way. The first is for CCW devices, most common on the S390 architecture. We expose the relevant cssid, ssid and devno values. The second is for fibre channel-backed SCSI devices, where we introduce

[libvirt] [PATCH 3/7] node_device: detect CCW devices

Make CCW devices available to the node_device driver. The devices are already seen by udev so let's implement necessary code for detecting them properly. Topologically, CCW devices are similar to PCI devices, e.g.: +- ccw_0_0_1a2b | +- scsi_host0 | +-

Re: [libvirt] [PATCH] Revert "qemu: propagate bridge MTU into qemu "host_mtu" option"

On Mon, May 22, 2017 at 03:30:48AM -0400, Laine Stump wrote: > This reverts commit 2841e675. > > It turns out that adding the host_mtu field to the PCI capabilities in > the guest bumps the length of PCI capabilities beyond the 32 byte > boundary, so the virtio-net device gets 64 bytes of ioport

Re: [libvirt] [PATCH v2] Provide a useful README file

On Mon, 2017-05-22 at 14:00 +0200, Andrea Bolognani wrote: > > +Libvirt API for virtualization > > +== > > + > > +Libvirt provides a portable, long term stable C API for managing the > > I like using "libvirt" with a capital L consistently, even > when it's at the

Re: [libvirt] [PATCH] qemu: process: Clear priv->namespaces on VM shutdown

On Mon, May 22, 2017 at 01:40:01PM +0200, Peter Krempa wrote: Otherwise the private data entry would be kept across instances of the same VM even if it's not configured to do so. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1453142 --- src/qemu/qemu_process.c | 4 1 file changed, 4

Re: [libvirt] [PATCH] virStreamSparseSendAll: Reset @want in each iteration

On Mon, May 22, 2017 at 01:06:26PM +0200, Michal Privoznik wrote: There's a slight problem with the current function. Assume we are currently in a data section and we have say 42 bytes until next section (okay, in reality sections are capped to the sector size, but bear with me). Therefore, just

Re: [libvirt] [PATCH] qemu: process: Clear priv->namespaces on VM shutdown

On Mon, May 22, 2017 at 01:40:01PM +0200, Peter Krempa wrote: > Otherwise the private data entry would be kept across instances of the > same VM even if it's not configured to do so. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1453142 > --- > src/qemu/qemu_process.c | 4 > 1

Re: [libvirt] [PATCH 8/8] apparmor, libvirt-qemu: Add ppc64el related changes

On Thu, 2017-05-18 at 10:53 +0200, Stefan Bader wrote: > @@ -102,6 +103,7 @@ >/usr/bin/qemu-system-or32 rmix, >/usr/bin/qemu-system-ppc rmix, >/usr/bin/qemu-system-ppc64 rmix, > +  /usr/bin/qemu-system-ppc64le rmix, Why does Ubuntu have qemu-system-ppc64le at all? qemu-system-ppc64

[libvirt] [PATCH] qemu: process: Clear priv->namespaces on VM shutdown

Otherwise the private data entry would be kept across instances of the same VM even if it's not configured to do so. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1453142 --- src/qemu/qemu_process.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_process.c

Re: [libvirt] [PATCH 2/8] apparmor, virt-aa-helper: allow /usr/share/OVMF/ too

On 19.05.2017 09:46, Guido Günther wrote: > Hi Stefan, > On Thu, May 18, 2017 at 10:53:40AM +0200, Stefan Bader wrote: >> From: Simon McVittie >> >> The split firmware and variables files introduced by >> https://bugs.debian.org/764918 are in a different directory for some

Re: [libvirt] [PATCH 8/8] apparmor, libvirt-qemu: Add ppc64el related changes

On 19.05.2017 11:03, Christian Ehrhardt wrote: > > On Fri, May 19, 2017 at 9:55 AM, Guido Günther > wrote: > > LGTM but I don't know much about PPC64, it's SLOF and where the device > tree should be located. > > > Hi those paths for SLOF are

[libvirt] [PATCH] Revert "qemu: propagate bridge MTU into qemu "host_mtu" option"

This reverts commit 2841e675. It turns out that adding the host_mtu field to the PCI capabilities in the guest bumps the length of PCI capabilities beyond the 32 byte boundary, so the virtio-net device gets 64 bytes of ioport space instead of 32, which offsets the address of all the other

Re: [libvirt] [PATCH v2] Provide a useful README file

On Tue, 2017-05-16 at 13:29 +0100, Daniel P. Berrange wrote: > The current README file contents has almost no useful info, and that > which does exist is very outdated. >  > Signed-off-by: Daniel P. Berrange > --- >  > In v2: >  >  - Use markdown syntax >  - Use README.md

Re: [libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

On 19.05.2017 13:13, Guido Günther wrote: > On Fri, May 19, 2017 at 11:18:18AM +0200, Christian Ehrhardt wrote: >> On Fri, May 19, 2017 at 10:03 AM, Guido Günther wrote: >> >>> But if we aim for a profile replace on blockcommit [1] the would't matter >>> since the whole profile

Re: [libvirt] [PATCH V2 2/2] libxl: add default listen address for VNC and spice

On 05/19/2017 11:33 PM, Jim Fehlig wrote: > If a VNC listen address is not specified in domXML, libxl > will default to 127.0.0.1, but this is never reflected in the domXML. > In the case of spice, a missing listen address resulted in listening > on all interfaces, i.e. '0.0.0.0'. If not

[libvirt] [libvirt-python][PATCH 1/4] Implement virStreamSendHole/virStreamRecvHole

The return value for virStreamRecvHole is slightly different to its C counterpart. In python, either it returns the hole size or None if C API fails. Signed-off-by: Michal Privoznik --- generator.py | 2 ++ libvirt-override-virStream.py | 21

[libvirt] [libvirt-python][PATCH 2/4] virStream: Introduce virStreamRecvFlags

Yet again, we need a custom wrapper over virStreamRecvFlags because our generator is not capable of generating it. Signed-off-by: Michal Privoznik --- generator.py | 1 + libvirt-override-virStream.py | 18 ++ libvirt-override.c

[libvirt] [libvirt-python][PATCH 4/4] examples: Introduce sparsestream.py

Sparse streams are not that straight forward to use for the very first time. Especially the sparseRecvAll() and sparseSendAll() methods which expects callbacks. What we can do to make it easier for developers is to have an example where they can take an inspiration from. Signed-off-by: Michal

[libvirt] [libvirt-python][PATCH 3/4] virStream: Introduce virStreamSparse{Recv, Send}All

Yet again, our parser is not capable of generating proper wrapper. To be fair, this one wold be really tough anyway. Signed-off-by: Michal Privoznik --- generator.py | 2 + libvirt-override-virStream.py | 117 ++ 2

Re: [libvirt] [PATCH] virCapabilitiesInitCaches: Don't leak cache dir

On Mon, May 22, 2017 at 12:08:53PM +0200, Michal Privoznik wrote: > To every virDirOpen we must have VIR_DIR_CLOSE otherwise FD is > leaked. > > Signed-off-by: Michal Privoznik > --- > src/conf/capabilities.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH V2 1/2] maint: define a macro for IPv4 loopback address

On 05/19/2017 11:33 PM, Jim Fehlig wrote: > Use a macro instead of hardcoding "127.0.0.1" throughout the > sources. > > Signed-off-by: Jim Fehlig Reviewed-by: Joao Martins > --- > src/internal.h | 2 ++ > src/qemu/qemu_conf.c | 4

Re: [libvirt] [PATCH 0/2] fix labeling for chardev source path

On Mon, May 15, 2017 at 04:28:33PM +0200, Pavel Hrdina wrote: > Pavel Hrdina (2): > conf: don't iterate over backcompat console in virDomainChrDefForeach > qemu: don't relabel chardev source file if virtlogd is used ping signature.asc Description: Digital signature -- libvir-list mailing

[libvirt] [PATCH] virStreamSparseSendAll: Reset @want in each iteration

There's a slight problem with the current function. Assume we are currently in a data section and we have say 42 bytes until next section (okay, in reality sections are capped to the sector size, but bear with me). Therefore, just before (handler) is called to fill up the buffer with data, @want

[libvirt] [PATCH] virCapabilitiesInitCaches: Don't leak cache dir

To every virDirOpen we must have VIR_DIR_CLOSE otherwise FD is leaked. Signed-off-by: Michal Privoznik --- src/conf/capabilities.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index

[libvirt] [libvirt-python][PATCH 0/4] Implement sparse streams

*** BLURB HERE *** Michal Privoznik (4): Implement virStreamSendHole/virStreamRecvHole virStream: Introduce virStreamRecvFlags virStream: Introduce virStreamSparse{Recv,Send}All examples: Introduce sparsestream.py examples/sparsestream.py | 119

Re: [libvirt] [libvirt-python][PATCH 0/4] Implement sparse streams

On 05/22/2017 12:57 PM, Michal Privoznik wrote: > *** BLURB HERE *** > > Michal Privoznik (4): > Implement virStreamSendHole/virStreamRecvHole > virStream: Introduce virStreamRecvFlags > virStream: Introduce virStreamSparse{Recv,Send}All > examples: Introduce sparsestream.py > >

Re: [libvirt] [PATCH v2] Provide a useful README file

On Mon, 2017-05-22 at 16:17 +0100, Daniel P. Berrange wrote: > > My preference would be to call this README.markdown instead. >  > While it appears github supports both names, README.md appears > more commonly used to me - indeed github's own markup repor > uses that name >  >   

Re: [libvirt] [PATCH v3] Provide a useful README file

On Mon, 2017-05-22 at 16:18 +0100, Daniel P. Berrange wrote: [...] > +While to build & install as an unprivileged user > + > +``` > +$ ./configure --prefix=$HOME/usr > +$  make > +$  make install > +``` > + > + Two nits I missed the first time around: the spurious whitespace between '$' and

[libvirt] [libvirt-perl][PATCH] Add LIST_CAP_MDEV & LIST_CAP_MDEV_TYPES constants

Signed-off-by: Michal Privoznik --- The sparse streams are still missing. Working on that. Changes| 2 +- Virt.xs| 2 ++ lib/Sys/Virt/NodeDevice.pm | 8 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Changes

Re: [libvirt] [libvirt-perl][PATCH] Add LIST_CAP_MDEV & LIST_CAP_MDEV_TYPES constants

On Mon, May 22, 2017 at 05:23:31PM +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > > The sparse streams are still missing. Working on that. > > Changes| 2 +- > Virt.xs| 2 ++ > lib/Sys/Virt/NodeDevice.pm | 8

[libvirt] [RFC PATCH 2/2] lib: Add note that bulk stats API queries may overrun RPC buffers

Hint that the users should limit the number of VMs queried in the bulk stats API. --- src/libvirt-domain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 310b91b37..b01f2705c 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c

[libvirt] [RFC PATCH 0/2] Bandaid to "fix" bulk stats API on big hosts

Make the API fail less often by bumping the RPC message size and telling users not to request stats for too many VMs until we figure out a better solution to get a lot of stats. Peter Krempa (2): rpc: Bump maximum message size to 32M lib: Add note that bulk stats API queries may overrun RPC

[libvirt] [RFC PATCH 1/2] rpc: Bump maximum message size to 32M

While most of the APIs are okay with 16M messages, the bulk stats API can run into the limit in big configurations. Before we devise a new plan for this, bump this limit slightly to accomodate some more configs. --- src/rpc/virnetprotocol.x | 4 ++-- 1 file changed, 2 insertions(+), 2

[libvirt] [PATCH v3] Provide a useful README file

The current README file contents has almost no useful info, and that which does exist is very outdated. Signed-off-by: Daniel P. Berrange --- Makefile.am | 1 + README | 14 +-- README.md | 80 + 3

Re: [libvirt] [PATCH v2] Provide a useful README file

On Mon, May 22, 2017 at 02:00:01PM +0200, Andrea Bolognani wrote: > On Tue, 2017-05-16 at 13:29 +0100, Daniel P. Berrange wrote: > > The current README file contents has almost no useful info, and that > > which does exist is very outdated. > >  > > Signed-off-by: Daniel P. Berrange

[libvirt] libvirt-question

Hello,does libvirt provides API to get qemu process ID by vm ID or name??or is there any methods to do this?? thanks!! zhun...@gmail.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 8/8] apparmor, libvirt-qemu: Add ppc64el related changes

On 22.05.2017 15:12, Andrea Bolognani wrote: > On Thu, 2017-05-18 at 10:53 +0200, Stefan Bader wrote: >> @@ -102,6 +103,7 @@ >> /usr/bin/qemu-system-or32 rmix, >> /usr/bin/qemu-system-ppc rmix, >> /usr/bin/qemu-system-ppc64 rmix, >> + /usr/bin/qemu-system-ppc64le rmix, > > Why does

Re: [libvirt] [PATCH V2 2/2] libxl: add default listen address for VNC and spice

On 05/22/2017 03:31 AM, Joao Martins wrote: On 05/19/2017 11:33 PM, Jim Fehlig wrote: If a VNC listen address is not specified in domXML, libxl will default to 127.0.0.1, but this is never reflected in the domXML. In the case of spice, a missing listen address resulted in listening on all

Re: [libvirt] [RFC] Fixing a regression caused by recent CPU driver changes

On Thu, May 18, 2017 at 10:22:59AM +0200, Jiri Denemark wrote: > The big question is how to fix the regression in a backward compatible > way and still keep the ability to properly check guest CPU ABI with new > enough libvirt and QEMU. Clearly, we need to keep both the original and > the updated