Re: [libvirt] [PATCH v2] util: Fix stack smashing in virNetDevGetFamilyId

On 09/21/2017 01:57 PM, Laine Stump wrote: > After commit 8708ca01c0d libvirtd consistently aborts with "stack > smashing detected" when nodedev driver is initialized. > > This is caused by nlmsg_parse() being told that its array of nlattr* > has CTRL_CMD_MAX (10) entries, when in fact it is

Re: [libvirt] [PATCH v4] Avoid possible NULL pointer dereferences in qemuDomainGetTLSObjects

On 09/21/2017 03:57 PM, Ashish Mittal wrote: > Passing a NULL value for the argument secAlias to the function > qemuDomainGetTLSObjects can cause a segmentation fault in > libvirtd. > > Fixed two possibile places where we could dereference a NULL secAlias. > > Signed-off-by: Ashish Mittal

Re: [libvirt] [PATCH] tests: Add QEMU 2.10.0 capabilities test for s390x

On 09/19/2017 10:06 AM, Boris Fiuczynski wrote: > Adding s390x qemu caps test for qemu version 2.10.0. > > Signed-off-by: Boris Fiuczynski > --- > .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 16441 > +++ >

Re: [libvirt] [PATCH v2 03/14] conf: Add/Allow parsing the auth in the disk source

On 09/21/2017 08:38 AM, Peter Krempa wrote: > On Fri, Sep 15, 2017 at 20:30:06 -0400, John Ferlan wrote: >> Since the virStorageAuthDefPtr auth; is a member of _virStorageSource >> it really should be allowed to be a subelement of the disk >> for the RBD and iSCSI prototcols. That way we can

Re: [libvirt] [PATCH v3] Avoid a possible NULL pointer dereference in qemuDomainGetTLSObjects

On 09/21/2017 04:33 AM, Erik Skultety wrote: > On Thu, Sep 21, 2017 at 01:24:29AM -0700, ashish mittal wrote: >> On Thu, Sep 21, 2017 at 12:21 AM, Erik Skultety wrote: >> >>> On Wed, Sep 20, 2017 at 12:19:16PM -0700, ashish mittal wrote: On Wed, Sep 20, 2017 at 6:11

Re: [libvirt] [PATCH v4] Avoid possible NULL pointer dereferences in qemuDomainGetTLSObjects

Thank you! Do let me know if there's any thing else I can help with on the remaining VxHS patches. Regards, Ashish On Thu, Sep 21, 2017 at 4:28 PM, John Ferlan wrote: > > > On 09/21/2017 03:57 PM, Ashish Mittal wrote: > > Passing a NULL value for the argument secAlias to

[libvirt] [PATCH v4] Avoid possible NULL pointer dereferences in qemuDomainGetTLSObjects

Passing a NULL value for the argument secAlias to the function qemuDomainGetTLSObjects can cause a segmentation fault in libvirtd. Fixed two possibile places where we could dereference a NULL secAlias. Signed-off-by: Ashish Mittal --- src/qemu/qemu_hotplug.c | 6 -- 1

Re: [libvirt] [PATCH v2 03/14] conf: Add/Allow parsing the auth in the disk source

On Fri, Sep 15, 2017 at 20:30:06 -0400, John Ferlan wrote: > Since the virStorageAuthDefPtr auth; is a member of _virStorageSource > it really should be allowed to be a subelement of the disk > for the RBD and iSCSI prototcols. That way we can set up to allow > the element to be formatted within

Re: [libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries

On Mon, 2017-09-18 at 14:59 +0200, Michal Privoznik wrote: > > Pino Toscano (5): > > tests: qemuxml2argv: fix expected type for usb-bus-missing > > tests: qemuxml2argv: fail also on unexpected pass > > qemu: pass the virDomainDef to qemuDomainChrDefValidate > > qemu: reject parallel ports

[libvirt] [PATCH 2/2] qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy

Because qemuDomainDefCopy needs a string representation of a domain definition, there's no reason for calling the lower level qemuDomainDefFormatBuf API. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[libvirt] [PATCH 1/2] qemu: Fix error checking in qemuDomainDefFormatXMLInternal

virDomainDefFormatInternal (called by qemuDomainDefFormatXMLInternal) already checks for buffer errors and properly resets the buffer on failure. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff

[libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

The virSocketAddrFormat() allocates the string and it's caller responsibility to free it afterwards. ==28857== 11 bytes in 1 blocks are definitely lost in loss record 37 of 168 ==28857==at 0x4C2BEDF: malloc (vg_replace_malloc.c:299) ==28857==by 0x9A81D79: strdup (in /lib64/libc-2.23.so)

[libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

Jiri Denemark (2): qemu: Fix error checking in qemuDomainDefFormatXMLInternal qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy src/qemu/qemu_domain.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) -- 2.14.1 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 2/2] qemu: don't update cpu unconditionally for migratable flag

Imagine if we use 'virsh dumpxml --migratable' for offline domain to get config to tweak before migration. Currenly cpu section will be expanded, host-cpu mode turns into custom and migration fails because of ABI check. Looks like ABI check does not make much sence for offline migration but we

Re: [libvirt] [PATCH 4/6] conf: Drop unused VIR_DOMAIN_DEF_FORMAT_UPDATE_CPU

On Tue, Sep 19, 2017 at 09:36:18 +0200, Michal Privoznik wrote: > On 09/18/2017 03:35 PM, Jiri Denemark wrote: > > The only real usage of this flag was removed by "cpu_conf: Drop > > updateCPU from virCPUDefFormat". > > ... > > diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h > >

[libvirt] [PATCH 0/2] qemu: don't update cpu unconditionally for migratable flag

First patch is just a refactoring. Nikolay Shirokovskiy (2): qemu: make explicit that formatting migratable imposes secure qemu: don't update cpu unconditionally for migratable flag src/qemu/qemu_domain.c | 27 ++- src/qemu/qemu_domain.h | 4

[libvirt] [PATCH 1/2] qemu: make explicit that formatting migratable imposes secure

qemu code always set VIR_DOMAIN_XML_SECURE flags when VIR_DOMAIN_XML_MIGRATABLE is set. At the same time qemu code itself does not analyse VIR_DOMAIN_XML_SECURE presense in any way. Thus we can just append secure flag conditionally down the stack before call to virDomainDefFormatInternal which

Re: [libvirt] [PATCH 2/2] qemu: Order PCI controllers on the command line

On 09/21/2017 05:11 AM, Andrea Bolognani wrote: > On Mon, 2017-09-11 at 13:22 +0200, Peter Krempa wrote: >> Please make sure that the migration stream does not depend on the >> ordering of the controllers. Re-arranging them could be a problem if we >> don't have a way to migrate them afterwards. >

Re: [libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

On 09/21/2017 08:55 AM, Michal Privoznik wrote: > The virSocketAddrFormat() allocates the string and it's caller > responsibility to free it afterwards. > > ==28857== 11 bytes in 1 blocks are definitely lost in loss record 37 of 168 > ==28857==at 0x4C2BEDF: malloc (vg_replace_malloc.c:299) >

Re: [libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

On 09/21/2017 08:55 AM, Michal Privoznik wrote: > The virSocketAddrFormat() allocates the string and it's caller > responsibility to free it afterwards. > > ==28857== 11 bytes in 1 blocks are definitely lost in loss record 37 of 168 > ==28857==at 0x4C2BEDF: malloc (vg_replace_malloc.c:299)

Re: [libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

On 09/21/2017 04:01 PM, Ján Tomko wrote: > On Thu, Sep 21, 2017 at 02:55:12PM +0200, Michal Privoznik wrote: >> The virSocketAddrFormat() allocates the string and it's caller >> responsibility to free it afterwards. >> > > Introduced by not-yet-released commit 8703813 > >> ==28857== 11 bytes in

Re: [libvirt] [PATCH 2/2] qemu: don't update cpu unconditionally for migratable flag

On 21.09.2017 17:24, Jiri Denemark wrote: > On Thu, Sep 21, 2017 at 16:39:39 +0300, Nikolay Shirokovskiy wrote: >> Imagine if we use 'virsh dumpxml --migratable' for offline domain >> to get config to tweak before migration. Currenly cpu section will >> be expanded, host-cpu mode turns into

Re: [libvirt] [PATCH v2 07/14] conf: Add/Allow parsing the encryption in the disk source

On Fri, Sep 15, 2017 at 20:30:10 -0400, John Ferlan wrote: > Since the virStorageEncryptionPtr encryption; is a member of > _virStorageSource it really should be allowed to be a subelement > of the disk for various disk formats: > >Source{File|Dir|Block|Volume} >

Re: [libvirt] [PATCH 1/2] qemu: make explicit that formatting migratable imposes secure

On Thu, Sep 21, 2017 at 16:39:38 +0300, Nikolay Shirokovskiy wrote: > qemu code always set VIR_DOMAIN_XML_SECURE flags when > VIR_DOMAIN_XML_MIGRATABLE > is set. At the same time qemu code itself does not analyse > VIR_DOMAIN_XML_SECURE > presense in any way. Thus we can just append secure flag

[libvirt] [PATCH v1 6/7] qemu: Assign device aliases at define time

https://bugzilla.redhat.com/show_bug.cgi?id=1434451 Users might want to uniquely identify devices even before the domain is started. Therefore we must generate device aliases right at the define time. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c

[libvirt] [PATCH v1 1/7] qemu_command: Drop useless alias checks

At the point when we are building the command line all aliases are assigned. There's no point in checking. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git

Re: [libvirt] [PATCH 2/2] qemu: don't update cpu unconditionally for migratable flag

On Thu, Sep 21, 2017 at 17:32:33 +0300, Nikolay Shirokovskiy wrote: > > > On 21.09.2017 17:24, Jiri Denemark wrote: > > On Thu, Sep 21, 2017 at 16:39:39 +0300, Nikolay Shirokovskiy wrote: > >> Imagine if we use 'virsh dumpxml --migratable' for offline domain > >> to get config to tweak before

Re: [libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

On 09/21/2017 04:58 PM, Peter Krempa wrote: > On Thu, Sep 21, 2017 at 16:08:05 +0200, Michal Privoznik wrote: >> On 09/21/2017 04:01 PM, Ján Tomko wrote: >>> On Thu, Sep 21, 2017 at 02:55:12PM +0200, Michal Privoznik wrote: > > [...] > >>> >>> ACK >>> >>> Looks like aiforaf in libvirt_nss.c

[libvirt] [PATCH v1 2/7] qemuAssignDeviceRNGAlias: Allow index to be passed

When generating aliases for RNG at the domain startup phase it make no sense trying to recalculate the next free index every time. We already know the index - it's the same as the index in the def->rngs[] array. Signed-off-by: Michal Privoznik --- src/qemu/qemu_alias.c |

[libvirt] [PATCH v1 5/7] domain: Add virDomainDefAssignAliasesCallback

This will be called at the end of virDomainDefPostParse to allow hypervisor drivers to fill in device aliases. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 7 +++ src/conf/domain_conf.h | 13 + 2 files changed, 20 insertions(+) diff --git

Re: [libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

On Thu, Sep 21, 2017 at 15:23:06 +0200, Jiri Denemark wrote: > Jiri Denemark (2): > qemu: Fix error checking in qemuDomainDefFormatXMLInternal > qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy > > src/qemu/qemu_domain.c | 16 +++- > 1 file changed, 3 insertions(+), 13

Re: [libvirt] [PATCH v2] qemu: Introduce a wrapper over virFileWrapperFdClose

On 09/19/2017 09:56 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1448268 > > When migrating to a file (e.g. when doing 'virsh save file'), > couple of things are happening in the thread that is executing > the API: > > 1) the domain obj is locked > 2) iohelper is

[libvirt] [PATCH v1 4/7] qemu: Allow regeneration of aliases

In the near future the qemuAssignDeviceAliases() function is going to be called multiple times: once at the domain define time, then in domain prepare phase. To avoid regenerating the same aliases the second time we need to be able to tell the function which time it is being called.

[libvirt] [PATCH v1 3/7] qemu: Move device alias assignment to separate functions

Let's move all the virAsprintf()-s into separate functions for better structure of the code. Later, when somebody wants to generate a device alias, all they need is to expose the function. Signed-off-by: Michal Privoznik --- src/qemu/qemu_alias.c | 90

[libvirt] [PATCH v1 0/7] qemu: Assign device aliases at define time

Rather big change because I had to update a lot of domain XMLs under tests/. You can find the patches at mu github too: https://github.com/zippy2/libvirt/commits/aliases All the changes to the tests are result of VIR_TEST_REGENERATE_OUTPUT=1. For more reference see:

Re: [libvirt] [PATCH v2 08/14] conf: Move LUKS encryption formatting to disk source

On Fri, Sep 15, 2017 at 20:30:11 -0400, John Ferlan wrote: > Alter the output of the formatting to be a child of the disk's source > rather than a child of the disk for LUKS encryption, but keep the legacy > QCOW encryption as a child of disk. NACK, see 4/14 signature.asc Description: PGP

Re: [libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

On Thu, Sep 21, 2017 at 16:08:05 +0200, Michal Privoznik wrote: > On 09/21/2017 04:01 PM, Ján Tomko wrote: > > On Thu, Sep 21, 2017 at 02:55:12PM +0200, Michal Privoznik wrote: [...] > >> > > > > ACK > > > > Looks like aiforaf in libvirt_nss.c could use the same treatment. > > I've no idea

Re: [libvirt] [PATCH 0/2] A few cleanups related to qemuDomainDefFormat*

On Thu, Sep 21, 2017 at 03:23:06PM +0200, Jiri Denemark wrote: Jiri Denemark (2): qemu: Fix error checking in qemuDomainDefFormatXMLInternal qemu: Use qemuDomainDefFormatXML in qemuDomainDefCopy src/qemu/qemu_domain.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-)

Re: [libvirt] [PATCH v2] qemu: Introduce a wrapper over virFileWrapperFdClose

On 09/21/2017 04:18 PM, John Ferlan wrote: > > > On 09/19/2017 09:56 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1448268 >> >> When migrating to a file (e.g. when doing 'virsh save file'), >> couple of things are happening in the thread that is executing >> the

Re: [libvirt] [PATCH v2 06/14] qemu: Introduce privateData for _virStorageSource

On Fri, Sep 15, 2017 at 20:30:09 -0400, John Ferlan wrote: > Since the secret information is really _virStorageSource specific > piece of data, let's create a privateData object for _virStorageSource > and move the @secinfo from _qemuDomainDiskPrivate into a new > _qemuDomainDiskSrcPrivate

Re: [libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

On Thu, Sep 21, 2017 at 02:55:12PM +0200, Michal Privoznik wrote: The virSocketAddrFormat() allocates the string and it's caller responsibility to free it afterwards. Introduced by not-yet-released commit 8703813 ==28857== 11 bytes in 1 blocks are definitely lost in loss record 37 of 168

Re: [libvirt] [PATCH 2/2] qemu: don't update cpu unconditionally for migratable flag

On Thu, Sep 21, 2017 at 16:39:39 +0300, Nikolay Shirokovskiy wrote: > Imagine if we use 'virsh dumpxml --migratable' for offline domain > to get config to tweak before migration. Currenly cpu section will > be expanded, host-cpu mode turns into custom and migration fails > because of ABI check. >

Re: [libvirt] [PATCH v2 10/14] qemu: Move encinfo from private disk to private disk src

On Fri, Sep 15, 2017 at 20:30:13 -0400, John Ferlan wrote: > Since the encryption information can also be disk source specific > move it from _qemuDomainDiskPrivate to _qemuDomainDiskSrcPrivate. > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_command.c | 6 ++ >

Re: [libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries

On 09/21/2017 12:51 PM, Andrea Bolognani wrote: > On Mon, 2017-09-18 at 14:59 +0200, Michal Privoznik wrote: >>> Pino Toscano (5): >>> tests: qemuxml2argv: fix expected type for usb-bus-missing >>> tests: qemuxml2argv: fail also on unexpected pass >>> qemu: pass the virDomainDef to

Re: [libvirt] [PATCH v2 01/14] util: Move virSecretUsageType to virsecret.h

On Fri, Sep 15, 2017 at 20:30:04 -0400, John Ferlan wrote: > Move the virSecretUsageType into the util. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c| 1 + > src/conf/secret_conf.c| 4 +--- > src/conf/secret_conf.h| 2 -- >

Re: [libvirt] [PATCH] cpu_ppc64: Error out when model tag missing in virsh cpu-compare xml

Gentle ping. On Mon, Sep 18, 2017 at 10:27 PM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > libvirtd throws unhandled signal 11 on ppc while running > virsh cpu-compare with missing model tag in the xml. This > patch errors out in such situation. > > Signed-off-by: Nitesh Konkar

Re: [libvirt] [PATCH v2 04/14] conf: Move auth formatting to disk source

On Fri, Sep 15, 2017 at 20:30:07 -0400, John Ferlan wrote: > Alter the output of the formatting to be a child of the disk's source > rather than a child of the disk. I don't think we can do this unconditionally. Apps which use and parse the XML will break. NACK to this approach. You need to

[libvirt] [PATCH] vhost-user: add support reconnect for vhost-user ports

For vhost-user ports, Open vSwitch acts as the server and QEMU the client. When OVS crashed or restart, QEMU shoule be reconnect to OVS. Signed-off-by: ZhiPeng Lu --- v1->v2: - modify xml format --- --- docs/schemas/domaincommon.rng | 12 ++

Re: [libvirt] Questions about function virPCIDeviceIsBehindSwitchLackingACS in virpci.c

> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Thursday, September 21, 2017 10:57 AM > To: Laine Stump > Cc: libvirt-l...@redhat.com; Wuzongyong (Euler Dept) > ; Wanzongshun (Vincent) >

Re: [libvirt] [PATCH] vhost-user: add support reconnect for vhost-user ports

> Re: [libvirt] [PATCH] vhost-user: add support reconnect for vhost-user ports When sending a v2/v3/etc of a patch, use the "-v2" (or -v3, -v4, etc) option to git send-email so that the subject line shows up as "[PATCH v2]". On 09/21/2017 07:39 AM, ZhiPeng Lu wrote: > For vhost-user ports, Open

[libvirt] [PATCH v2] util: Fix stack smashing in virNetDevGetFamilyId

After commit 8708ca01c0d libvirtd consistently aborts with "stack smashing detected" when nodedev driver is initialized. This is caused by nlmsg_parse() being told that its array of nlattr* has CTRL_CMD_MAX (10) entries, when in fact it is declared to have CTRL_ATTR_MAX (8) entries. Since all

Re: [libvirt] [PATCH] nss: Don't leak @ipAddr

On 09/21/2017 11:48 AM, Michal Privoznik wrote: > In aiforaf() (which exists only when building for BSD) the > @ipAddr may be leaked. > > Signed-off-by: Michal Privoznik > --- > tools/nss/libvirt_nss.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [libvirt] [PATCH v1 4/7] qemu: Allow regeneration of aliases

On Thu, Sep 21, 2017 at 06:05:19PM +0200, Peter Krempa wrote: > On Thu, Sep 21, 2017 at 16:47:08 +0200, Michal Privoznik wrote: > > In the near future the qemuAssignDeviceAliases() function is > > going to be called multiple times: once at the domain define > > time, then in domain prepare phase.

Re: [libvirt] [PATCH] util: Fix stack smashing in virNetDevGetFamilyId

On 09/20/2017 07:41 AM, Erik Skultety wrote: > On Wed, Sep 20, 2017 at 12:48:01PM +0200, Jiri Denemark wrote: >> After commit 8708ca01c0d libvirtd consistently aborts with >> "stack smashing detected" when nodedev driver is initialized. >> >> Apparently this is caused by nlmsg_parse trying to

[libvirt] [PATCH] nss: Don't leak @ipAddr

In aiforaf() (which exists only when building for BSD) the @ipAddr may be leaked. Signed-off-by: Michal Privoznik --- tools/nss/libvirt_nss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c index 9904026da..da4bf79a4

[libvirt] [PATCH v1 7/7] conf: Format device alias into inactive XML too

Now that we are generating the device aliases at the define time, we might as well format them into inactive XML. Signed-off-by: Michal Privoznik --- I've trimmed out all the test/ XML changes. I've generated them using: tests $ VIR_TEST_REGENERATE_OUTPUT=1 ./test With

Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On 09/19/2017 03:37 PM, Eduardo Habkost wrote: > Cache mode=passthrough can result in a broken cache topology if > the domain topology is not exactly the same as the host topology. > Warn about that in the documentation. > > Bug report for reference: >

Re: [libvirt] [PATCH] qemuBuildHostNetStr: Don't leak @addr

On 09/21/2017 10:58 AM, Peter Krempa wrote: > On Thu, Sep 21, 2017 at 16:08:05 +0200, Michal Privoznik wrote: >> On 09/21/2017 04:01 PM, Ján Tomko wrote: >>> On Thu, Sep 21, 2017 at 02:55:12PM +0200, Michal Privoznik wrote: > [...] > >>> ACK >>> >>> Looks like aiforaf in libvirt_nss.c could use

Re: [libvirt] [PATCH v1 4/7] qemu: Allow regeneration of aliases

On Thu, Sep 21, 2017 at 16:47:08 +0200, Michal Privoznik wrote: > In the near future the qemuAssignDeviceAliases() function is > going to be called multiple times: once at the domain define > time, then in domain prepare phase. To avoid regenerating the > same aliases the second time we need to be

Re: [libvirt] [PATCH 2/2] qemu: Order PCI controllers on the command line

On Mon, 2017-09-11 at 13:22 +0200, Peter Krempa wrote: > Please make sure that the migration stream does not depend on the > ordering of the controllers. Re-arranging them could be a problem if we > don't have a way to migrate them afterwards. Took me long enough to get around to actually test

Re: [libvirt] [PATCH v9 4/4] qemu: Add TLS support for Veritas HyperScale (VxHS)

On Thu, Sep 21, 2017 at 12:58 AM, Peter Krempa wrote: > On Wed, Sep 20, 2017 at 16:32:45 -0700, ashish mittal wrote: > > Hi, > > > > I have done TLS testing with this patch series and the tests passed fine > > with the secAlias fix in place. > > > > (1) Applied all the v9

Re: [libvirt] [PATCH v9 4/4] qemu: Add TLS support for Veritas HyperScale (VxHS)

On Thu, Sep 21, 2017 at 1:35 AM, ashish mittal wrote: > > > On Thu, Sep 21, 2017 at 12:58 AM, Peter Krempa wrote: > >> On Wed, Sep 20, 2017 at 16:32:45 -0700, ashish mittal wrote: >> > Hi, >> > >> > I have done TLS testing with this patch series and the

Re: [libvirt] [PATCH] qemu: capabilities: Remove support for downstream-only QMP monitor backport

On Thu, Sep 21, 2017 at 10:08:47AM +0200, Peter Krempa wrote: > Some distros (see diff) chose to backport QMP support rather than rebase > to newer version of qemu. As a hack they added the string 'libvirt' to > the qemu -help output. Remove this as downstream-only hacks should be > carried by

Re: [libvirt] [PATCH v3] Avoid a possible NULL pointer dereference in qemuDomainGetTLSObjects

On Thu, Sep 21, 2017 at 12:21 AM, Erik Skultety wrote: > On Wed, Sep 20, 2017 at 12:19:16PM -0700, ashish mittal wrote: > > On Wed, Sep 20, 2017 at 6:11 AM, Erik Skultety > wrote: > > > > > On Wed, Sep 20, 2017 at 05:32:29AM -0700, Ashish Mittal wrote:

Re: [libvirt] [PATCH v3] Avoid a possible NULL pointer dereference in qemuDomainGetTLSObjects

On Thu, Sep 21, 2017 at 01:24:29AM -0700, ashish mittal wrote: > On Thu, Sep 21, 2017 at 12:21 AM, Erik Skultety wrote: > > > On Wed, Sep 20, 2017 at 12:19:16PM -0700, ashish mittal wrote: > > > On Wed, Sep 20, 2017 at 6:11 AM, Erik Skultety > > wrote: >

Re: [libvirt] [PATCH v3] Avoid a possible NULL pointer dereference in qemuDomainGetTLSObjects

On Wed, Sep 20, 2017 at 12:19:16PM -0700, ashish mittal wrote: > On Wed, Sep 20, 2017 at 6:11 AM, Erik Skultety wrote: > > > On Wed, Sep 20, 2017 at 05:32:29AM -0700, Ashish Mittal wrote: > > > Passing a NULL value for the argument secAlias to the function > > >

[libvirt] [PATCH] Fix commandhelper build on win32

For win32 we need EXIT_AM_SKIP which is in testutils.h. We must define NO_LIBVIRT to prevent replacement of fprintf with virFilePrintf as we can't link to libvirt_util.la Signed-off-by: Daniel P. Berrange --- Pushed as a build fix tests/commandhelper.c | 2 ++ 1 file

[libvirt] [PATCH] qemu: capabilities: Remove support for downstream-only QMP monitor backport

Some distros (see diff) chose to backport QMP support rather than rebase to newer version of qemu. As a hack they added the string 'libvirt' to the qemu -help output. Remove this as downstream-only hacks should be carried by downstream and not litter upstream. This effectively reverts commit

Re: [libvirt] [PATCH libvirt-glib 0/5] Portability fixes

On Wed, Sep 20, 2017 at 07:54:45PM +0200, Andrea Bolognani wrote: > Currently, trying to build libvirt-glib on FreeBSD results in all > sorts of interesting failures. > > After applying this series, it's possible to build libvirt-glib > and run the test suite successfully. > > There's even a

Re: [libvirt] [PATCH v9 4/4] qemu: Add TLS support for Veritas HyperScale (VxHS)

On Wed, Sep 20, 2017 at 16:32:45 -0700, ashish mittal wrote: > Hi, > > I have done TLS testing with this patch series and the tests passed fine > with the secAlias fix in place. > > (1) Applied all the v9 patches. > (2) make install. Reload and restart the libvirtd daemon. > (3) Make sure able

Re: [libvirt] [PATCH v2 02/14] util: Fix secret generation in virStorageSourceParseRBDColonString

On Fri, Sep 15, 2017 at 20:30:05 -0400, John Ferlan wrote: > Commit id '5604c056' used the wrong API to generate the oops > correct API as was done in commit id '6887af39'. The data > is actually a usage type not an auth type even though the > result is the same. ACK signature.asc