Re: [libvirt] [PATCH] libvirtd: Explicit dependency on systemd-machined

Hello list. On 01/10/2018 11:06 PM, Michal Koutný wrote: > [...] I see there's no response to the patch. Do you have any comments on this patch? Thanks, Michal signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > This extends the update hook so that it enforces a requirement to have a > Signed-off-by line in every commit message. This can be optionally > turned off in individual repos by setting the "hooks.allowmissingsob" > git config

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote: > On Thu, Jan 18, 2018 at 10:16:55AM +0100, Ján Tomko wrote: > > After the latest CPU additions, the build fails with clang: > > cputest.c:905:1: error: stack frame size of 26136 bytes > > in function 'mymain'

[libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

Document that contributors are required to assert compliance with the Developers Certification of Origin 1.1, by providing Signed-off-by tags for all commit messages. The DCO is formally stating what we have long implicitly expected of contributors in terms of their legal rights to make the

Re: [libvirt] [PATCH] qemu: Refresh caps cache after booting a different kernel

On Mon, Jan 22, 2018 at 01:31:21PM +0100, Jiri Denemark wrote: > On Mon, Jan 22, 2018 at 10:57:57 +, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 11:46:14AM +0100, Jiri Denemark wrote: > > > Whenever a different kernel is booted, some capabilities related to KVM > > > (such as CPUID

Re: [libvirt] [PATCH v2] libvirtd: clarify the TLS conf default vaule setting

On Fri, Jan 19, 2018 at 05:20:10PM -0500, John Ferlan wrote: [...] > More simply stated: > > Provide more details related to the requirement that setting one > of the values requires setting all of them. Sounds clearer. [...] > How about this instead: > > # Use of TLS requires that x509

[libvirt] [PATCH hooks 0/1] Enforce requirement for Signed-off-by line

As a general rule most libvirt commits in recent history have have a valid Signed-off-by line present. There are still cases, however, where this is being forgotten. It is time to put some checks on git pushes to detect missinged Signed-off-by lines and reject the push. I created a new git

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: This extends the update hook so that it enforces a requirement to have a Signed-off-by line in every commit message. This can be optionally turned off in individual repos by setting the "hooks.allowmissingsob" git config

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote: On 01/22/2018 01:22 PM, Daniel P. Berrange wrote: On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote: On Thu, Jan 18, 2018 at 10:16:55AM +0100, Ján Tomko wrote: After the latest CPU additions, the build fails

Re: [libvirt] [PATCH] qemu: Refresh caps cache after booting a different kernel

On Mon, Jan 22, 2018 at 11:46:14AM +0100, Jiri Denemark wrote: > Whenever a different kernel is booted, some capabilities related to KVM > (such as CPUID bits) may change. We need to refresh the cache to see the > changes. > > Signed-off-by: Jiri Denemark > --- > > Notes: >

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

> > On Thu, Jan 18, 2018 at 03:44:49PM +0100, Paolo Bonzini wrote: > >> On 18/01/2018 15:37, Eduardo Habkost wrote: > >>> On Thu, Jan 18, 2018 at 02:39:57PM +0100, Paolo Bonzini wrote: > On 18/01/2018 14:24, Eduardo Habkost wrote: > > However, if there's a simple way to make it possible

Re: [libvirt] [PATCH RESEND v1 1/2] i386: Add Intel Processor Trace feature support

> > On 18/01/2018 14:24, Eduardo Habkost wrote: > > > However, if there's a simple way to make it possible to migrate > > > between hosts with different CPUID[14h] data, it would be even > > > better. With the current KVM intel-pt implementation, what happens > > > if the CPUID[14h] data seen by

[libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

This extends the update hook so that it enforces a requirement to have a Signed-off-by line in every commit message. This can be optionally turned off in individual repos by setting the "hooks.allowmissingsob" git config variable. Signed-off-by: Daniel P. Berrange ---

Re: [libvirt] [PATCH] libvirtd: Explicit dependency on systemd-machined

The patch looks good to me, though I'm not a systemd expert. If no one vetoes it I'll push your patch by the end of the day. -- Cedric On Mon, 2018-01-22 at 09:10 +0100, Michal Koutný wrote: > Hello list. > > On 01/10/2018 11:06 PM, Michal Koutný wrote: > > [...] > > I see there's no response

[libvirt] [PATCH] qemu: Refresh caps cache after booting a different kernel

Whenever a different kernel is booted, some capabilities related to KVM (such as CPUID bits) may change. We need to refresh the cache to see the changes. Signed-off-by: Jiri Denemark --- Notes: The capabilities may also change if a parameter passed to a kvm module

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Thu, Jan 18, 2018 at 10:16:55AM +0100, Ján Tomko wrote: After the latest CPU additions, the build fails with clang: cputest.c:905:1: error: stack frame size of 26136 bytes in function 'mymain' [-Werror,-Wframe-larger-than=] Raise the relaxed limit which is used for tests. ---

Re: [libvirt] [PATCH] qemu: auto-add generic xhci rather than NEC xhci to Q35 domains

On Sat, Jan 20, 2018 at 09:55:14PM -0500, Laine Stump wrote: > We recently added a generic XHCI USB3 controller to QEMU, and libvirt > supports adding that controller rather than the NEC XHCI USB3 > controller, but when auto-adding a USB controller to Q35 domains we > were still adding the

Re: [libvirt] [PATCH] qemu: Refresh caps cache after booting a different kernel

On Mon, Jan 22, 2018 at 10:57:57 +, Daniel P. Berrange wrote: > On Mon, Jan 22, 2018 at 11:46:14AM +0100, Jiri Denemark wrote: > > Whenever a different kernel is booted, some capabilities related to KVM > > (such as CPUID bits) may change. We need to refresh the cache to see the > > changes. >

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: > On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > > This extends the update hook so that it enforces a requirement to have a > > Signed-off-by line in every commit message. This can be optionally > > turned off in

Re: [libvirt] [PATCH] Raise the frame limit for tests

On 01/22/2018 01:22 PM, Daniel P. Berrange wrote: > On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote: >> On Thu, Jan 18, 2018 at 10:16:55AM +0100, Ján Tomko wrote: >>> After the latest CPU additions, the build fails with clang: >>> cputest.c:905:1: error: stack frame size of 26136

Re: [libvirt] [PATCH 3/8] virsh: Introduce virshInterfaceNameCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tools/virsh-completer.c | 47 +++ > tools/virsh-completer.h | 4 > tools/virsh-interface.c | 16 +--- > 3 files changed,

Re: [libvirt] [PATCH 8/8] virsh: Introduce virshSnapshotNameCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tools/virsh-completer.c | 51 > + > tools/virsh-completer.h | 4 > tools/virsh-snapshot.c | 21 +--- > 3 files

Re: [libvirt] [PATCH] docs: formatdomain: Document the CPU feature 'name' attribute

On Wed, Jan 17, 2018 at 09:04:26AM +0100, Kashyap Chamarthy wrote: > On Tue, Jan 16, 2018 at 03:35:20PM -0200, Eduardo Habkost wrote: > > On Fri, Jan 12, 2018 at 08:31:16PM +0100, Kashyap Chamarthy wrote: > > > Currently, the CPU feature 'name' XML attribute, as in: > > [...] > > > > --- > > >

Re: [libvirt] [PATCH 2/8] virsh: Introduce virshStorageVolNameCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > This one is a bit simpler since virStoragePoolListAllVolumes() > has no flags yet. > > Signed-off-by: Michal Privoznik > --- > tools/virsh-completer.c | 52 > + >

Re: [libvirt] [PATCH 4/8] virsh: Introduce virshNetworkNameCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tools/virsh-completer.c | 51 > + > tools/virsh-completer.h | 4 > tools/virsh-network.c | 24 --- > 3

Re: [libvirt] [PATCH 7/8] virsh: Introduce virshSecretUUIDCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > This is a slight change from previous patches since virSecret > does not have a name only UUID strings. > > Signed-off-by: Michal Privoznik > --- > tools/virsh-completer.c | 46

Re: [libvirt] [PATCH 9/8] docs: Mention bash completion feature

On 01/12/2018 10:30 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > docs/news.xml | 11 +++ > 1 file changed, 11 insertions(+) > I think you were planning to change this one anyway considering 4.0.0 got some of this added already. John >

Re: [libvirt] [PATCH 6/8] virsh: Introduce virshNWFilterNameCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > The virConnectListAllNWFilters() has no extra flags yet, which > simplifies things a bit. > CONNECT flags wouldn't make sense here either especially for undefine where things either are or aren't. > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 0/9] Resolve libvirtd hang on termination with connected long running client

Hi, John. Thank you for driving this issue! Unfortunately I have little time now to take participation in reviweing etc. Nikolay On 19.01.2018 20:23, John Ferlan wrote: > RFC: > https://www.redhat.com/archives/libvir-list/2018-January/msg00318.html > > Adjustments since RFC... > > Patches

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 08:58:52AM -0500, John Ferlan wrote: > > > On 01/22/2018 07:05 AM, Daniel P. Berrange wrote: > > This extends the update hook so that it enforces a requirement to have a > > Signed-off-by line in every commit message. This can be optionally > > turned off in individual

Re: [libvirt] [PATCH] Raise the frame limit for tests

On 01/22/2018 01:54 PM, Martin Kletzander wrote: > On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote: >> On 01/22/2018 01:22 PM, Daniel P. Berrange wrote: >>> On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote: On Thu, Jan 18, 2018 at 10:16:55AM +0100, Ján Tomko

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: > On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: > > On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > > > This extends the update hook so that it enforces a requirement to have a > > > Signed-off-by line

Re: [libvirt] [PATCH] docs: document requirement to provide Signed-off-by lines for DCO

On Mon, 2018-01-22 at 12:40 +, Daniel P. Berrange wrote: > Document that contributors are required to assert compliance with the > Developers Certification of Origin 1.1, by providing Signed-off-by tags Both here... > for all commit messages. The DCO is formally stating what we have long >

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 12:57:31PM +, Daniel P. Berrange wrote: On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote: On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote: > On 01/22/2018 01:22 PM, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 12:49:12PM

Re: [libvirt] [PATCH v2] virsh: Checking the volume capacity before uploading a new file.

On Sun, Jan 21, 2018 at 21:51:05 -0200, Julio Faracco wrote: > The current command 'vol-upload' is not checking if the volume accepts > a file bigger than its capacity. It can cause an interrupt of the > upload stream. This commit adds a check that fails before starting to > send new file to

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote: > On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote: > > On 01/22/2018 01:22 PM, Daniel P. Berrange wrote: > > > On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander wrote: > > > > On Thu, Jan 18, 2018 at

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 12:42:47PM +, Daniel P. Berrange wrote: On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > This extends the update hook so that it enforces a requirement to have a > Signed-off-by line in

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On 01/22/2018 02:20 PM, Peter Krempa wrote: > On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: >> On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: >>> On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: This extends the update hook so that it enforces a

Re: [libvirt] [PATCH] Raise the frame limit for tests

On 01/22/2018 02:34 PM, Daniel P. Berrange wrote: > On Mon, Jan 22, 2018 at 02:28:42PM +0100, Martin Kletzander wrote: >> On Mon, Jan 22, 2018 at 12:57:31PM +, Daniel P. Berrange wrote: >>> On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote: On Mon, Jan 22, 2018 at

Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

On Mon, Jan 22, 2018 at 14:01:26 +, Daniel P. Berrange wrote: > On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > > It breaks the build and it is not really useful for anything. > > Why does that break the build ? "{ 0 }" is a valid initializer for > any struct according to

Re: [libvirt] [PATCH 2/9] util: Add virResctrlInfo

On Tue, Jan 02, 2018 at 03:08:30PM -0500, John Ferlan wrote: On 12/13/2017 10:39 AM, Martin Kletzander wrote: This will make the current functions obsolete and it will provide more information to the virresctrl module so that it can be used later. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH] libvirtd: Explicit dependency on systemd-machined

On 01/22/2018 11:10 AM, Cedric Bosdonnat wrote: > The patch looks good to me, though I'm not a systemd expert. > If no one vetoes it I'll push your patch by the end of the day. Yup ACK. Sorry, I had this marked for review but got buried under some other stuff. Cedric feel free to push and don't

Re: [libvirt] [PATCH 1/8] virsh: Introduce virshStoragePoolNameCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tools/virsh-completer.c | 51 > + > tools/virsh-completer.h | 4 > tools/virsh-pool.c | 28 +-- >

Re: [libvirt] [PATCH 5/8] virsh: Introduce virshNodeDeviceNameCompleter

On 01/12/2018 09:37 AM, Michal Privoznik wrote: > Yet again, we don't need listing by device capabilities, so flags > are unused. The CONNECT flags wouldn't make sense anyway ;-) > > Signed-off-by: Michal Privoznik > --- > tools/virsh-completer.c | 45

Re: [libvirt] a libvirt event question

Hello: We found the causes for this issue: QEMU does not connect the socket for sending event until enters into its main_loop if libvirt uses "nowait" to create the chardev for monitor; And qemu cannot send event until it receives the first qmp cmd: qmp_capabilities. So We cannot send event

Re: [libvirt] [PATCH v2] virsh: Checking the volume capacity before uploading a new file.

Hi Peter, I agree about "length" parameter. What I didn't understand is this error (check my test case): # virsh vol-create-as --pool disk-loop loop0 --capacity 20M # virsh vol-info loop0 disk-loop Name: loop0 Type: file Capacity: 20.00 MiB Allocation: 20.00 MiB #

[libvirt] [PATCH v3 2/5] qemu: Introduce VIR_ERR_DEVICE_MISSING

From: Chen Hanxiao Add new error code to be able to allow consumers (such as Nova) to be able to key of a specific error code rather than needing to search the error message." Signed-off-by: Chen Hanxiao --- v3: commit message updated

[libvirt] [PATCH v3 5/5] news: Add VIR_ERR_DEVICE_MISSING change as improvements

From: Chen Hanxiao Signed-off-by: Chen Hanxiao --- docs/news.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index b4d980624..5798f42d8 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -37,6 +37,11 @@

[libvirt] [PATCH v3 3/5] qemu: Use VIR_ERR_DEVICE_MISSING for various hotplug messages

From: Chen Hanxiao Modify OPERATION_FAILED error codes to use DEVICE_MISSING instead. Signed-off-by: Chen Hanxiao --- v3: modify virDomainNetFindIdx to use VIR_ERR_DEVICE_MISSING src/conf/domain_conf.c | 8 src/qemu/qemu_hotplug.c |

[libvirt] [PATCH v3 0/5] Introduce VIR_ERR_DEVICE_MISSING

Use Introduce VIR_ERR_DEVICE_MISSING for hotplug and detach device error message. Chen Hanxiao (5): qemu: Add some more details for hotplug errors when device not found qemu: Introduce VIR_ERR_DEVICE_MISSING qemu: Use VIR_ERR_DEVICE_MISSING for various hotplug messages qemu: Use

[libvirt] [PATCH v3 4/5] qemu: Use VIR_ERR_DEVICE_MISSING for various DetachDeviceConfig messages

From: Chen Hanxiao Modify OPERATION_FAILED error codes to use DEVICE_MISSING instead. Signed-off-by: Chen Hanxiao --- src/qemu/qemu_driver.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[libvirt] [PATCH v3 1/5] qemu: Add some more details for hotplug errors when device not found

From: Chen Hanxiao More proper/detail error messages updated. Signed-off-by: Chen Hanxiao --- v3: subject changed. some description of logs changed. src/libvirt_private.syms | 2 ++ src/qemu/qemu_hotplug.c | 35

Re: [libvirt] [PATCH 3/4] logd: add support for admin protocol in virtlogd

On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd > daemon and define a virtlogd:///{system,session} URI scheme for > connecting to it. > > Signed-off-by: Daniel P. Berrange > --- > src/Makefile.am

Re: [libvirt] [PATCH 4/4] lockd: add support for admin protocol in virtlockd

On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > Add a virtlockd-admin-sock can serves the admin protocol for the virtlockd > daemon and define a virtlockd:///{system,session} URI scheme for > connecting to it. > > Signed-off-by: Daniel P. Berrange > --- > cfg.mk

Re: [libvirt] [PATCH 5/9] resctrl: Add functions to work with resctrl allocations

On Thu, Jan 11, 2018 at 03:58:42PM +0100, Pavel Hrdina wrote: On Wed, Jan 03, 2018 at 04:05:38PM -0500, John Ferlan wrote: On 12/13/2017 10:39 AM, Martin Kletzander wrote: > With this commit we finally have a way to read and manipulate basic resctrl > settings. Locking is done only on

Re: [libvirt] [PATCH 1/4] admin: move admins server impl/dispatch into src/admin directory

On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > The admin server functionality is a generic concept that should be wired > up into all libvirt daemons, but is currently integrated with the > libvirtd code. Move it all into the src/admin directory to prepare for > broader reuse. > >

Re: [libvirt] [PATCH 0/4] Add admin protocol support for virtlogd/virtlockd

On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > The initial admin protocol support was only integrated into libvirtd. > This series extracts that code so that it is reusable with all the > daemons we have (and more than we'll get). > > Daniel P. Berrange (4): > admin: move admins server

Re: [libvirt] [PATCH 2/4] util: add virGetUNIXSocketPath helper

On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > When receiving multiple socket FDs from systemd, it is critical to know > what socket address each corresponds to so we can setup the right > protocols on each. > > Signed-off-by: Daniel P. Berrange > --- >

Re: [libvirt] [PATCH 0/4] Add admin protocol support for virtlogd/virtlockd

On Mon, Jan 22, 2018 at 04:44:10PM +0100, Michal Privoznik wrote: > On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > > The initial admin protocol support was only integrated into libvirtd. > > This series extracts that code so that it is reusable with all the > > daemons we have (and more than

Re: [libvirt] [PATCH 3/4] logd: add support for admin protocol in virtlogd

On Mon, Jan 22, 2018 at 04:44:13PM +0100, Michal Privoznik wrote: > On 01/19/2018 06:09 PM, Daniel P. Berrange wrote: > > Add a virtlogd-admin-sock can serves the admin protocol for the virtlogd > > daemon and define a virtlogd:///{system,session} URI scheme for > > connecting to it. > > > >

[libvirt] [dbus RFC 03/11] src: rename manager to connect

Manager was a good name for the original design. However, the design will be changed that for now libvirt-dbus will be using only local connection and will support multiple drivers. Signed-off-by: Pavel Hrdina --- src/Makefile.am | 2 +-

[libvirt] [dbus RFC 07/11] connect: move domain related code to domain.c

Signed-off-by: Pavel Hrdina --- src/connect.c | 7 ++- src/connect.h | 2 ++ src/domain.c | 7 +++ 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/connect.c b/src/connect.c index 10183f3..314277f 100644 --- a/src/connect.c +++ b/src/connect.c @@

[libvirt] [dbus RFC 08/11] connect: store connect path in connect structure

This prepares for multiple connection objects since each object will have different path based on the driver name. Signed-off-by: Pavel Hrdina --- src/connect.c | 3 ++- src/connect.h | 1 + src/events.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git

[libvirt] [dbus RFC 06/11] connect: implement reconnect functionality to libvirt

If the connection dies for some reason between D-Bus calls we need to properly reconnect because the current connection is not usable anymore. Without this the only solution would be to restart the libvirt-dbus daemon. Signed-off-by: Pavel Hrdina --- src/connect.c | 37

[libvirt] [dbus RFC 02/11] util: introduce virtDBusUtilSetError helper

Signed-off-by: Pavel Hrdina --- src/util.c | 7 +++ src/util.h | 4 2 files changed, 11 insertions(+) diff --git a/src/util.c b/src/util.c index 2445ce0..6636d0a 100644 --- a/src/util.c +++ b/src/util.c @@ -69,6 +69,13 @@ virtDBusUtilSetLastVirtError(sd_bus_error

[libvirt] [dbus RFC 05/11] connect: don't use default libvirt authentication callback

We need to implement our own authentication callback because the default one ask for credentials using STDIO. This is not suitable behavior for daemon. For now we will require usage of client configuration file for libvirt to provide credentials for drivers that require authentication [1]. [1]

[libvirt] [dbus RFC 10/11] main: implement multiple connection within one daemon

This effectively removes --connect parameter from daemon, for now we will support only local connection. Instead of specifying URI for different drivers we will use connect object which allows using multiple drivers from one daemon. In the future if that feature will be requested we can extend

[libvirt] [dbus RFC 09/11] domain: derive domain path from connect path

Each connection have its own domains so we must make the domain path as a sub-path of the specific connection. Signed-off-by: Pavel Hrdina --- src/connect.c | 12 +++ src/connect.h | 1 + src/domain.c | 64 ---

[libvirt] [dbus RFC 04/11] connect: implement lazy connection

Open a connection to libvirt only when it is required. Signed-off-by: Pavel Hrdina --- src/connect.c | 41 +++-- src/connect.h | 1 + 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/src/connect.c b/src/connect.c index

[libvirt] [dbus RFC 01/11] util: introduce VIRT_ARRAY_CARDINALITY macro

Signed-off-by: Pavel Hrdina --- src/util.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util.h b/src/util.h index 0c9f3d7..6d99841 100644 --- a/src/util.h +++ b/src/util.h @@ -8,6 +8,8 @@ #define _cleanup_(_x) __attribute__((__cleanup__(_x))) #define

[libvirt] [dbus RFC 11/11] main: add support for all libvirt drivers

Signed-off-by: Pavel Hrdina --- src/main.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/src/main.c b/src/main.c index 14c7c18..6421919 100644 --- a/src/main.c +++ b/src/main.c @@ -85,13 +85,31 @@ struct virtDBusDriver { };

[libvirt] [dbus RFC 00/11] improve libvirt connections handling

This patch series is a proposal to how to implement libvirt connections in the libvirt D-Bus binding. The design is based on a discussion with Daniel and it should follow D-Bus convention. Each connection is represented as existing object where the object path contains the driver name:

Re: [libvirt] [PATCH v3] libvirtd: clarify the TLS conf default value setting

On 01/21/2018 09:39 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Provide more details related to the requirement that setting one > of the values requires setting all of them. > > Signed-off-by: Chen Hanxiao > > --- > v3: > description

Re: [libvirt] [PATCH] libvirtd: Explicit dependency on systemd-machined

It's now pushed! Thanks a lot Michal for your contribution, feel free to submit other ones in the future ;) -- Cedric On Wed, 2018-01-10 at 23:06 +0100, Michal Koutný wrote: > The libvirtd daemon uses systemd-machined D-Bus API when manipulating > domains. The systemd-machined is D-Bus

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 02:28:42PM +0100, Martin Kletzander wrote: > On Mon, Jan 22, 2018 at 12:57:31PM +, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 01:54:28PM +0100, Martin Kletzander wrote: > > > On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote: > > > > On

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 02:20:52PM +0100, Peter Krempa wrote: > On Mon, Jan 22, 2018 at 13:06:28 +, Daniel Berrange wrote: > > On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: > > > On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > > > > This extends the update hook

Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > It breaks the build and it is not really useful for anything. Why does that break the build ? "{ 0 }" is a valid initializer for any struct according to the C standards. > > Signed-off-by: Jiri Denemark >

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 01:20:12PM +0100, Peter Krempa wrote: > On Mon, Jan 22, 2018 at 12:05:19 +, Daniel Berrange wrote: > > This extends the update hook so that it enforces a requirement to have a > > Signed-off-by line in every commit message. This can be optionally > > turned off in

Re: [libvirt] [PATCH] Raise the frame limit for tests

On Mon, Jan 22, 2018 at 02:01:27PM +0100, Michal Privoznik wrote: On 01/22/2018 01:54 PM, Martin Kletzander wrote: On Mon, Jan 22, 2018 at 01:47:24PM +0100, Michal Privoznik wrote: On 01/22/2018 01:22 PM, Daniel P. Berrange wrote: On Mon, Jan 22, 2018 at 12:49:12PM +0100, Martin Kletzander

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On Mon, Jan 22, 2018 at 02:24:40PM +0100, Ján Tomko wrote: > On Mon, Jan 22, 2018 at 12:42:47PM +, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 01:22:01PM +0100, Ján Tomko wrote: > > > On Mon, Jan 22, 2018 at 12:05:19PM +, Daniel P. Berrange wrote: > > > > This extends the update

[libvirt] [PATCH] qemu: Don't initialize struct utsname

It breaks the build and it is not really useful for anything. Signed-off-by: Jiri Denemark --- Pushed under the build breaker rule. src/qemu/qemu_capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages

On 01/22/2018 07:05 AM, Daniel P. Berrange wrote: > This extends the update hook so that it enforces a requirement to have a > Signed-off-by line in every commit message. This can be optionally > turned off in individual repos by setting the "hooks.allowmissingsob" > git config variable. > >

Re: [libvirt] [PATCH] qemu: Don't initialize struct utsname

On Mon, Jan 22, 2018 at 03:12:46PM +0100, Jiri Denemark wrote: > On Mon, Jan 22, 2018 at 14:01:26 +, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2018 at 02:54:42PM +0100, Jiri Denemark wrote: > > > It breaks the build and it is not really useful for anything. > > > > Why does that break the

Re: [libvirt] [PATCH] apparmor: allow libvirt to send term signal to unconfined

On 01/17/2018 08:34 AM, Guido Günther wrote: Otherwise stopping domains with qemu://session fails like [164012.338157] audit: type=1400 audit(1516202208.784:99): apparmor="DENIED" operation="signal" profile="/usr/sbin/libvirtd" pid=18835 comm="libvirtd" requested_mask="send" denied_mask="send"

Re: [libvirt] [PATCH] apparmor: allow libvirt to send term signal to unconfined

On Mon, Jan 22, 2018 at 10:25:38AM -0700, Jim Fehlig wrote: > On 01/17/2018 08:34 AM, Guido Günther wrote: > > Otherwise stopping domains with qemu://session fails like > > > > [164012.338157] audit: type=1400 audit(1516202208.784:99): > > apparmor="DENIED" operation="signal"